RE: [PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-15 Thread Yang, Fei
>> @@ -157,6 +163,9 @@ int gen11_emit_flush_rcs(struct i915_request *rq, >> u32 mode) >> intel_ring_advance(rq, cs); >> } >> >> +/* hsdes: 1809175790. No fixup needed for gen11 rcs */ >> +rq->aux_inv_fixup = NULL; > > This is a little ugly to me. Can we just set this to

[linux-next:master] BUILD REGRESSION a32cd981a6da2373c093d471ee4405a915e217d5

2022-03-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: a32cd981a6da2373c093d471ee4405a915e217d5 Add linux-next specific files for 20220315 Error/Warning reports: https://lore.kernel.org/linux-doc/202202240704.pqd40a9l-...@intel.com https

Re: [PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-15 Thread Summers, Stuart
On Fri, 2022-03-04 at 14:14 -0800, fei.y...@intel.com wrote: > From: Fei Yang > > GPU hangs have been observed when multiple engines write to the > same aux_inv register at the same time. To avoid this each engine > should only invalidate its own auxiliary table. The function >

Re: [PATCH v4 00/24] DEPT(Dependency Tracker)

2022-03-15 Thread Byungchul Park
On Sat, Mar 12, 2022 at 01:53:26AM +, Hyeonggon Yoo wrote: > On Fri, Mar 04, 2022 at 04:06:19PM +0900, Byungchul Park wrote: > > Hi Linus and folks, > > > > I've been developing a tool for detecting deadlock possibilities by > > tracking wait/event rather than lock(?) acquisition order to try

Re: KASAN splat in vmwgfx driver

2022-03-15 Thread Zack Rusin
On Wed, 2022-03-16 at 00:45 +, Chuck Lever III wrote: > For a kernel development project I'm working on, I'm using > Linux in a VMware guest. After kernel v5.16.2, I noticed > this KASAN splat: Ah, yea, thanks. It's because vmw_bo_create_kernel creates a raw ttm_buffer_object instead of

[PATCH RFC v5 08/21] dept: Apply Dept to seqlock

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by seqlock with adding wait annotation on read side of seqlock. Signed-off-by: Byungchul Park --- include/linux/seqlock.h | 68 +++-- 1 file changed, 66 insertions(+), 2 deletions(-) diff --git

[PATCH RFC v5 19/21] dept: Add nocheck version of init_completion()

2022-03-15 Thread Byungchul Park
For completions who don't want to get tracked by Dept, added init_completion_nocheck() to disable Dept on it. Signed-off-by: Byungchul Park --- include/linux/completion.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/include/linux/completion.h

[PATCH RFC v5 10/21] dept: Add proc knobs to show stats and dependency graph

2022-03-15 Thread Byungchul Park
It'd be useful to show Dept internal stats and dependency graph on runtime via proc for better information. Introduced the knobs. Signed-off-by: Byungchul Park --- kernel/dependency/Makefile| 1 + kernel/dependency/dept.c | 24 -- kernel/dependency/dept_internal.h | 26

[PATCH RFC v5 02/21] dept: Implement Dept(Dependency Tracker)

2022-03-15 Thread Byungchul Park
CURRENT STATUS -- Lockdep tracks acquisition order of locks in order to detect deadlock, and IRQ and IRQ enable/disable state as well to take accident acquisitions into account. Lockdep should be turned off once it detects and reports a deadlock since the data structure and algorithm

[PATCH RFC v5 21/21] dept: Don't create dependencies between different depths in any case

2022-03-15 Thread Byungchul Park
Dept already prevents creating dependencies between different depths of the class indicated by *_lock_nested() when the lock acquisitions happen consecutively. For example: lock A0 with depth lock_nested A1 with depth + 1 ... unlock A1 unlock A0 Dept does not create A0 -> A1

[PATCH RFC v5 20/21] dept: Disable Dept on struct crypto_larval's completion for now

2022-03-15 Thread Byungchul Park
struct crypto_larval's completion is used for multiple purposes e.g. waiting for test to complete or waiting for probe to complete. The completion variable needs to be split according to what it's used for. Otherwise, Dept cannot distinguish one from another and doesn't work properly. Now that it

[PATCH RFC v5 16/21] dept: Distinguish each syscall context from another

2022-03-15 Thread Byungchul Park
It enters kernel mode on each syscall and each syscall handling should be considered independently from the point of view of Dept. Otherwise, Dept may wrongly track dependencies across different syscalls. That might be a real dependency from user mode. However, now that Dept just started to work,

[PATCH RFC v5 07/21] dept: Apply Dept to wait_for_completion()/complete()

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 42 -- kernel/sched/completion.c | 12 ++-- 2 files changed, 50 insertions(+), 4 deletions(-) diff --git

[PATCH RFC v5 14/21] dept: Apply SDT to wait(waitqueue)

2022-03-15 Thread Byungchul Park
Makes SDT able to track dependencies by wait(waitqueue). Signed-off-by: Byungchul Park --- include/linux/wait.h | 6 +- kernel/sched/wait.c | 16 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/include/linux/wait.h b/include/linux/wait.h index

[PATCH RFC v5 00/21] DEPT(Dependency Tracker)

2022-03-15 Thread Byungchul Park
I'm gonna re-add RFC for a while at Ted's request. But hard testing is needed to find false alarms for now that there's no false alarm with my system. I'm gonna look for other systems that might produce false alarms. And it'd be appreciated if you share it when you see any alarms with yours. ---

[PATCH RFC v5 03/21] dept: Embed Dept data in Lockdep

2022-03-15 Thread Byungchul Park
Dept should work independently from Lockdep. However, there's no choise but to rely on Lockdep code and its instances for now. Signed-off-by: Byungchul Park --- include/linux/lockdep.h | 72 --- include/linux/lockdep_types.h | 3 ++

[PATCH RFC v5 01/21] llist: Move llist_{head, node} definition to types.h

2022-03-15 Thread Byungchul Park
llist_head and llist_node can be used by very primitives. For example, Dept for tracking dependency uses llist things in its header. To avoid header dependency, move those to types.h. Signed-off-by: Byungchul Park --- include/linux/llist.h | 8 include/linux/types.h | 8 2

[PATCH RFC v5 17/21] dept: Distinguish each work from another

2022-03-15 Thread Byungchul Park
Workqueue already provides concurrency control. By that, any wait in a work doesn't prevents events in other works with the control enabled. Thus, each work would better be considered a different context. So let Dept assign a different context id to each work. Signed-off-by: Byungchul Park ---

[PATCH RFC v5 15/21] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2022-03-15 Thread Byungchul Park
cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was introduced to make lockdep_assert_cpus_held() work in AP thread. However, the annotation is too strong for that purpose. We don't have to use more than try lock annotation for that. Furthermore, now that Dept was introduced,

[PATCH RFC v5 18/21] dept: Disable Dept within the wait_bit layer by default

2022-03-15 Thread Byungchul Park
The struct wait_queue_head array, bit_wait_table[] in sched/wait_bit.c are shared by all its users, which unfortunately vary in terms of class. So each should've been assigned its own class to avoid false positives. It'd better let Dept work at a higher layer than wait_bit. So disabled Dept

[PATCH RFC v5 09/21] dept: Apply Dept to rwsem

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by rwsem. Signed-off-by: Byungchul Park --- include/linux/lockdep.h | 24 include/linux/percpu-rwsem.h | 10 +- include/linux/rwsem.h| 32 3 files changed, 61 insertions(+), 5

[PATCH RFC v5 12/21] dept: Apply Dept to wait/event of PG_{locked, writeback}

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by PG_{locked,writeback}. For instance, (un)lock_page() generates that type of dependency. Signed-off-by: Byungchul Park --- include/linux/dept_page.h | 78 + include/linux/page-flags.h | 45

[PATCH RFC v5 04/21] dept: Apply Dept to spinlock

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by spinlock. Signed-off-by: Byungchul Park --- include/linux/lockdep.h| 18 +++--- include/linux/spinlock.h | 25 + include/linux/spinlock_types_raw.h | 13 + 3 files changed, 53

[PATCH RFC v5 06/21] dept: Apply Dept to rwlock

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by rwlock. Signed-off-by: Byungchul Park --- include/linux/lockdep.h| 25 - include/linux/rwlock.h | 50 ++ include/linux/rwlock_api_smp.h | 8 +++ include/linux/rwlock_types.h

[PATCH RFC v5 13/21] dept: Apply SDT to swait

2022-03-15 Thread Byungchul Park
Makes SDT able to track dependencies by swait. Signed-off-by: Byungchul Park --- include/linux/swait.h | 4 kernel/sched/swait.c | 10 ++ 2 files changed, 14 insertions(+) diff --git a/include/linux/swait.h b/include/linux/swait.h index 6a8c22b..dbdf2ce 100644 ---

[PATCH RFC v5 11/21] dept: Introduce split map concept and new APIs for them

2022-03-15 Thread Byungchul Park
There is a case where total maps for its wait/event is so large in size. For instance, struct page for PG_locked and PG_writeback is the case. The additional memory size for the maps would be 'the # of pages * sizeof(struct dept_map)' if each struct page keeps its map all the way, which might be

[PATCH RFC v5 05/21] dept: Apply Dept to mutex families

2022-03-15 Thread Byungchul Park
Makes Dept able to track dependencies by mutex families. Signed-off-by: Byungchul Park --- include/linux/lockdep.h | 18 +++--- include/linux/mutex.h | 32 include/linux/rtmutex.h | 7 +++ 3 files changed, 54 insertions(+), 3 deletions(-)

[PATCH v10 00/13] Add GuC Error Capture Support

2022-03-15 Thread Alan Previn
This series: 1. Enables support of GuC to report error-state-capture using a list of MMIO registers the driver registers and GuC will dump, log and notify right before a GuC triggered engine-reset event. 2. Updates the ADS blob creation to register said lists of global,

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-15 Thread Andy Yan
Hi Daniel: On 3/15/22 20:43, Daniel Stone wrote: Hi Andy, On Tue, 15 Mar 2022 at 06:46, Andy Yan wrote: On 3/11/22 16:33, Sascha Hauer wrote: The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB board. Overlay support is tested with the modetest utility. AFBC support on the

Re: [PATCH] WIP: drm/dp_mst: Add support for dumping topology ref histories from debugfs

2022-03-15 Thread Lyude Paul
(Adding this back to the dri-devel mailing list since I didn't notice it got dropped from there) Hm, some comments on this issue down below. Sorry for the delayed response, I was going to try this right after I finished the MST legacy removal but that's ending up taking longer than I hoped. On

KASAN splat in vmwgfx driver

2022-03-15 Thread Chuck Lever III
For a kernel development project I'm working on, I'm using Linux in a VMware guest. After kernel v5.16.2, I noticed this KASAN splat: Mar 15 14:50:39 oracle-102.nfsv4.dev kernel: vmwgfx :00:0f.0: vgaarb: deactivate vga console Mar 15 14:50:39 oracle-102.nfsv4.dev kernel: Console: switching

Re: [PATCH v3 5/5] drm/msm: allow compile time selection of driver components

2022-03-15 Thread Abhinav Kumar
On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: MSM DRM driver already allows one to compile out the DP or DSI support. Add support for disabling other features like MDP4/MDP5/DPU drivers or direct HDMI output support. Suggested-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov ---

Re: [PATCH v3 4/5] drm/msm: stop using device's match data pointer

2022-03-15 Thread Abhinav Kumar
On 3/3/2022 7:21 PM, Dmitry Baryshkov wrote: Let's make the match's data pointer a (sub-)driver's private data. The only user currently is the msm_drm_init() function, using this data to select kms_init callback. Pass this callback through the driver's private data instead. Signed-off-by:

Re: [PATCH v5] drm/msm/disp/dpu1: add inline rotation support for sc7280 target

2022-03-15 Thread kernel test robot
Hi Vinod, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next next-20220315] [cannot apply to tegra-drm/drm/tegra/for-next v5.17-rc8] [If your patch

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Add support for steered register writes

2022-03-15 Thread Lucas De Marchi
On Mon, Mar 14, 2022 at 04:42:03PM -0700, Matt Roper wrote: Upcoming patches will need to steer writes to multicast registers as well as reading them. Although the setting of the 'multicast' bit should only really matter for write operations (reads always operate in a unicast manner and give us

Re: [PATCH 2/3] drm/i915/guc: add steering info to GuC register save/restore list

2022-03-15 Thread Lucas De Marchi
On Mon, Mar 14, 2022 at 04:42:02PM -0700, Matt Roper wrote: From: Daniele Ceraolo Spurio GuC has its own steering mechanism and can't use the default set by i915, so we need to provide the steering information that the FW will need to save/restore registers while processing an engine reset.

Re: [PATCH 5/6] drm/rcar_du: use drm_encoder pointer for drm_writeback_connector

2022-03-15 Thread Abhinav Kumar
Hi Laurent Thank you for your inputs. I liked all the suggestions, hence I have incorporated those and pushed a v2. Thanks Abhinav On 3/13/2022 7:50 AM, Laurent Pinchart wrote: Hi Abhinav On Fri, Mar 11, 2022 at 09:47:17AM -0800, Abhinav Kumar wrote: On 3/10/2022 11:28 PM, Laurent

[PATCH v2 4/6] drm/vc4: change vc4 driver to use drm_writeback_connector_init_with_encoder()

2022-03-15 Thread Abhinav Kumar
vc4 driver currently embeds the drm_encoder into struct vc4_txp and later on uses container_of to retrieve the vc4_txp from the drm_encoder. Since drm_encoder has now been made a pointer inside drm_writeback_connector, make vc4 driver use the new API so that the embedded encoder model can be

[PATCH v2 5/6] drm/rcar_du: pass possible_crtcs as parameter for drm_writeback_connector

2022-03-15 Thread Abhinav Kumar
As part of this series, drm_writeback_connector_init() allows passing possible_crtcs as a parameter so that the API can internally create and setup the encoder. Pass possible_crtcs parameter for drm_writeback_connector_init() for rcar-du writeback driver. changes in v2: - pass possible_crtcs

[PATCH v2 6/6] drm/malidp: pass possible_crtcs as parameter for drm_writeback_connector

2022-03-15 Thread Abhinav Kumar
As part of this series, drm_writeback_connector_init() allows passing possible_crtcs as a parameter so that the API can internally create and setup the encoder. Pass possible_crtcs parameter for drm_writeback_connector_init() for malidp writeback driver. changes in v2: - pass

[PATCH v2 3/6] drm/vkms: pass possible_crtcs as parameter for drm_writeback_connector

2022-03-15 Thread Abhinav Kumar
As part of this series, drm_writeback_connector_init() allows passing possible_crtcs as a parameter so that the API can internally create and setup the encoder. Pass possible_crtcs parameter for drm_writeback_connector_init() for vkms driver. changes in v2: - pass possible_crtcs parameter for

[PATCH v2 1/6] drm: allow real encoder to be passed for drm_writeback_connector

2022-03-15 Thread Abhinav Kumar
For some vendor driver implementations, display hardware can be shared between the encoder used for writeback and the physical display. In addition resources such as clocks and interrupts can also be shared between writeback and the real encoder. To accommodate such vendor drivers and hardware,

[PATCH v2 2/6] drm/komeda: pass possible_crtcs as parameter for drm_writeback_connector

2022-03-15 Thread Abhinav Kumar
As part of this series, drm_writeback_connector_init() allows passing possible_crtcs as a parameter so that the API can internally create and setup the encoder. Pass possible_crtcs parameter for drm_writeback_connector_init() for komeda driver. changes in v2: - pass possible_crtcs parameter

[PATCH v2 0/6] Allow drm_writeback_connector to accept pointer to drm_encoder

2022-03-15 Thread Abhinav Kumar
There are some vendor drivers for which the writeback encoder shares hardware resources such as clocks and interrupts with the rest of the display pipeline. In addition, there can be use-cases where the writeback encoder could be a shared encoder between the physical display path and the writeback

[PATCH] drm/nouveau: Fix spelling mistake "endianess" -> "endianness"

2022-03-15 Thread Colin Ian King
There is a spelling mistake in a nvdev_error error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c

[PATCH] drm/i915/reg: Fix spelling mistake "Unsupport" -> "Unsupported"

2022-03-15 Thread Colin Ian King
There is a spelling mistake in a gvt_vgpu_err error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gvt/handlers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c index

Re: [PATCH] drm: Don't make DRM_PANEL_BRIDGE dependent on DRM_KMS_HELPERS

2022-03-15 Thread Sam Ravnborg
On Tue, Mar 15, 2022 at 09:45:59AM +0100, Thomas Zimmermann wrote: > Fix a number of undefined references to drm_kms_helper.ko in > drm_dp_helper.ko: > > arm-suse-linux-gnueabi-ld: drivers/gpu/drm/dp/drm_dp_mst_topology.o: in > function `drm_dp_mst_duplicate_state': >

Re: [PATCH v4 2/4] drm/panel: Add panel driver for NewVision NV3052C based LCDs

2022-03-15 Thread Sam Ravnborg
Hi Christophe, On Fri, Mar 11, 2022 at 06:02:38PM +0100, Christophe Branchereau wrote: > This driver supports the NewVision NV3052C based LCDs. Right now, it > only supports the LeadTek LTK035C5444T 2.4" 640x480 TFT LCD panel, which > can be found in the Anbernic RG-350M handheld console. I had

[PATCH] drm/amdgpu: Fix spelling mistake "regiser" -> "register"

2022-03-15 Thread Colin Ian King
There is a spelling mistake in a dev_error error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c

Re: [PATCH 6/9] drm/fb-helper: Provide callback to create fbdev dumb buffers

2022-03-15 Thread Thomas Zimmermann
Hi Javier Am 08.03.22 um 18:51 schrieb Javier Martinez Canillas: [...] static struct drm_client_buffer * -drm_client_buffer_create(struct drm_client_dev *client, u32 width, u32 height, u32 format) +drm_client_buffer_create(struct drm_client_dev *client, u32 width, u32 height, u32 format,

Re: [PATCH 00/22] drm: Review of mode copies

2022-03-15 Thread Alex Deucher
On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä wrote: > > On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > > drm: Add drm_mode_init() > > drm/bridge: Use drm_mode_copy() > > drm/imx: Use drm_mode_duplicate() > > drm/panel: Use drm_mode_duplicate() > > drm/vc4: Use

Re: [PATCH 04/22] drm/amdgpu: Use drm_mode_copy()

2022-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 18, 2022 at 11:32 AM Harry Wentland wrote: > > > > On 2022-02-18 05:03, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > struct drm_display_mode embeds a list head, so overwriting > > the full struct with another one will corrupt the list > > (if the

Re: [PATCH 05/22] drm/radeon: Use drm_mode_copy()

2022-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 18, 2022 at 5:04 AM Ville Syrjala wrote: > > From: Ville Syrjälä > > struct drm_display_mode embeds a list head, so overwriting > the full struct with another one will corrupt the list > (if the destination mode is on a list). Use drm_mode_copy() > instead

[RFC PATCH 6/7] drm/i915: add range busy check for ttm region

2022-03-15 Thread Robert Beckett
RFC: should this become a generic interface in intel_memory_region_ops? RFC: would we prefer an different interface? e.g. for_each_obj_in_range Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/intel_region_ttm.c | 19 +++ drivers/gpu/drm/i915/intel_region_ttm.h | 3 +++

[RFC PATCH 7/7] drm/i915: cleanup old stolen state

2022-03-15 Thread Robert Beckett
remove i915->mm.stolen remove i915->mm.stolen_lock they are no longer needed. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 4 ++-- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 -- drivers/gpu/drm/i915/gt/selftest_reset.c | 16 +---

[RFC PATCH 5/7] drm/ttm: add range busy check for range manager

2022-03-15 Thread Robert Beckett
RFC: do we want this to become a generic interface in ttm_resource_manager_func? RFC: would we prefer a different interface? e.g. for_each_resource_in_range or for_each_bo_in_range Signed-off-by: Robert Beckett --- drivers/gpu/drm/ttm/ttm_range_manager.c | 21 +

[RFC PATCH 2/7] drm/i915: add ability to create memory region object in place

2022-03-15 Thread Robert Beckett
Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_region.c | 55 ++ drivers/gpu/drm/i915/gem/i915_gem_region.h | 6 ++ drivers/gpu/drm/i915/gem/i915_gem_ttm.c| 84 ++ drivers/gpu/drm/i915/intel_memory_region.h | 6 ++ 4 files changed, 136

[RFC PATCH 4/7] drm/i915: stolen memory use ttm backend

2022-03-15 Thread Robert Beckett
Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 385 ++--- drivers/gpu/drm/i915/gem/i915_gem_stolen.h | 9 - drivers/gpu/drm/i915/gem/i915_gem_ttm.c| 14 +- drivers/gpu/drm/i915/gem/i915_gem_ttm.h| 7 + 4 files changed, 40

[RFC PATCH 3/7] drm/i915: use gem objects to track stolen nodes

2022-03-15 Thread Robert Beckett
Construct gem objects around stolen nodes. This stops the abuse of interfaces and aids future patches that done use drm nodes for stolen areas. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 72 -- drivers/gpu/drm/i915/gem/i915_gem_stolen.c |

[RFC PATCH 1/7] drm/i915: instantiate ttm ranger manager for stolen memory

2022-03-15 Thread Robert Beckett
Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/intel_region_ttm.c | 29 +++-- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c b/drivers/gpu/drm/i915/intel_region_ttm.c index 737ef3f4ab54..bb564b830c96 100644 ---

Re: [PATCH v8 00/16] clk: provide new devm helpers for prepared and enabled clocks

2022-03-15 Thread Andy Shevchenko
On Mon, Mar 14, 2022 at 5:14 PM Uwe Kleine-König wrote: > > Hello, > > this is another try to convince the relevant people that > devm_clk_get_enabled() is a nice idea. Compared to v7 (back in May 2021) this > series is rebased to v5.17-rc8 and converts quite some drivers that open code >

Re: [v7 1/5] drm/edid: seek for available CEA and DisplayID block from specific EDID block index

2022-03-15 Thread Drew Davenport
On Tue, Mar 15, 2022 at 03:21:05PM +, Lee, Shawn C wrote: > On Tuesday, March 15, 2022 8:33 PM, Nikula, Jani > wrote: > >On Mon, 14 Mar 2022, Drew Davenport wrote: > >> On Mon, Mar 14, 2022 at 10:40:47AM +0200, Jani Nikula wrote: > >>> On Sun, 13 Mar 2022, Lee Shawn C wrote: > >>> >

[PATCH v2 1/3] drm/i915: Report steering details in debugfs

2022-03-15 Thread Matt Roper
Add a new 'steering' node in each gt's debugfs directory that tells whether we're using explicit steering for various types of MCR ranges and, if so, what MMIO ranges it applies to. We're going to be transitioning away from implicit steering, even for slice/dss steering soon, so the information

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/gem: Remove logic for wbinvd_on_all_cpus

2022-03-15 Thread Michael Cheng
+Daniel for additional feedback! On 2022-03-14 4:06 p.m., Michael Cheng wrote: On 2022-03-08 10:58 a.m., Lucas De Marchi wrote: On Tue, Feb 22, 2022 at 08:24:31PM +0100, Thomas Hellström (Intel) wrote: Hi, Michael, On 2/22/22 18:26, Michael Cheng wrote: This patch removes logic for

Re: [PATCH 1/3] drm/i915: Report steering details in debugfs

2022-03-15 Thread Souza, Jose
On Mon, 2022-03-14 at 16:42 -0700, Matt Roper wrote: > Add a new 'steering' node in each gt's debugfs directory that tells > whether we're using explicit steering for various types of MCR ranges > and, if so, what MMIO ranges it applies to. > > We're going to be transitioning away from implicit

Re: [Intel-gfx] [PATCH] drm/i915: Reduce stack usage in debugfs due to SSEU

2022-03-15 Thread Souza, Jose
On Mon, 2022-03-14 at 19:08 -0700, Matt Roper wrote: > From: John Harrison > > sseu_dev_info is already a pretty large structure which will likely > continue to grow when future platforms increase potential DSS and EU > counts. Let's switch the stack placement of this structure in debugfs >

Re: [PATCH 02/22] drm/amdgpu: Remove pointless on stack mode copies

2022-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 18, 2022 at 11:28 AM Harry Wentland wrote: > > > > On 2022-02-18 05:03, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > These on stack copies of the modes appear to be pointless. > > Just look at the originals directly. > > > > Cc: Harry Wentland > >

Re: [PATCH 23/30] drm/amdgpu/dc: fix typos in comments

2022-03-15 Thread Alex Deucher
Applied. Thanks! On Mon, Mar 14, 2022 at 8:01 AM Julia Lawall wrote: > > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/amd/display/dc/bios/command_table.c |6 +++--- > 1 file changed, 3

Re: [PATCH 29/30] drm/amdgpu: fix typos in comments

2022-03-15 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Mar 14, 2022 at 8:01 AM Julia Lawall wrote: > > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c |4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH 01/30] drm/amd/pm: fix typos in comments

2022-03-15 Thread Alex Deucher
Applied. Thanks! On Mon, Mar 14, 2022 at 8:01 AM Julia Lawall wrote: > > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/gpu/drm/amd/pm/amdgpu_pm.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Paul Menzel
Dear Arunpravin, Am 15.03.22 um 16:42 schrieb Arunpravin: On 15/03/22 2:35 pm, Paul Menzel wrote: Am 15.03.22 um 10:01 schrieb Arunpravin: On 15/03/22 1:49 pm, Paul Menzel wrote: Am 14.03.22 um 20:40 schrieb Arunpravin: handle a situation in the condition order-- == min_order, when

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Arunpravin
On 15/03/22 2:35 pm, Paul Menzel wrote: > Dear Arunpravin, > > > Am 15.03.22 um 10:01 schrieb Arunpravin: > >> On 15/03/22 1:49 pm, Paul Menzel wrote: > >>> Am 14.03.22 um 20:40 schrieb Arunpravin: handle a situation in the condition order-- == min_order, when order = 0, leading

RE: [v7 1/5] drm/edid: seek for available CEA and DisplayID block from specific EDID block index

2022-03-15 Thread Lee, Shawn C
On Tuesday, March 15, 2022 8:33 PM, Nikula, Jani wrote: >On Mon, 14 Mar 2022, Drew Davenport wrote: >> On Mon, Mar 14, 2022 at 10:40:47AM +0200, Jani Nikula wrote: >>> On Sun, 13 Mar 2022, Lee Shawn C wrote: >>> > drm_find_cea_extension() always look for a top level CEA block. >>> > Pass

Re: [Intel-gfx] [PATCH] drm/i915: round_up the size to the alignment value

2022-03-15 Thread Arunpravin
On 15/03/22 4:56 pm, Matthew Auld wrote: > On Mon, 14 Mar 2022 at 19:32, Arunpravin > wrote: >> >> handle instances when size is not aligned with the min_page_size. >> Unigine Heaven has allocation requests for example required pages >> are 161 and alignment request is 128. To allocate the

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-15 Thread Alex Deucher
On Mon, Mar 14, 2022 at 11:26 AM Pekka Paalanen wrote: > > On Mon, 14 Mar 2022 10:23:27 -0400 > Alex Deucher wrote: > > > On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote: > > > > > > On Thu, 10 Mar 2022 11:56:41 -0800 > > > Rob Clark wrote: > > > > > > > For something like just notifying

Re: [PATCH 4/5] drm: ssd130x: Reduce temporary buffer sizes

2022-03-15 Thread Geert Uytterhoeven
Hi Andy, On Tue, Mar 15, 2022 at 2:50 PM Andy Shevchenko wrote: > On Tue, Mar 15, 2022 at 12:07:06PM +0100, Geert Uytterhoeven wrote: > > ssd130x_clear_screen() allocates a temporary buffer sized to hold one > > byte per pixel, while it only needs to hold one bit per pixel. > > > >

Re: [PATCH 5/5] drm/repaper: Reduce temporary buffer size in repaper_fb_dirty()

2022-03-15 Thread Andy Shevchenko
On Tue, Mar 15, 2022 at 12:07:07PM +0100, Geert Uytterhoeven wrote: > As the temporary buffer is no longer used to store 8-bit grayscale data, > its size can be reduced to the size needed to store the monochrome > bitmap data. bitmap API? -- With Best Regards, Andy Shevchenko

Re: [PATCH 4/5] drm: ssd130x: Reduce temporary buffer sizes

2022-03-15 Thread Andy Shevchenko
On Tue, Mar 15, 2022 at 12:07:06PM +0100, Geert Uytterhoeven wrote: > ssd130x_clear_screen() allocates a temporary buffer sized to hold one > byte per pixel, while it only needs to hold one bit per pixel. > > ssd130x_fb_blit_rect() allocates a temporary buffer sized to hold one > byte per pixel

RE: [v7 3/5] drm/edid: read HF-EEODB ext block

2022-03-15 Thread Lee, Shawn C
On Tuesday, March 15, 2022 7:03 PM, Nikula, Jani wrote: >On Sun, 13 Mar 2022, Lee Shawn C wrote: >> According to HDMI 2.1 spec. >> >> "The HDMI Forum EDID Extension Override Data Block (HF-EEODB) is >> utilized by Sink Devices to provide an alternate method to indicate an >> EDID Extension

Re: (subset) [PATCH 00/30] fix typos in comments

2022-03-15 Thread Mark Brown
On Mon, 14 Mar 2022 12:53:24 +0100, Julia Lawall wrote: > Various spelling mistakes in comments. > Detected with the help of Coccinelle. > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [21/30] spi: sun4i: fix typos in comments commit:

Re: [PATCH 2/5] drm/format-helper: Fix XRGB888 to monochrome conversion

2022-03-15 Thread Andy Shevchenko
On Tue, Mar 15, 2022 at 01:18:00PM +0100, Javier Martinez Canillas wrote: > On 3/15/22 12:07, Geert Uytterhoeven wrote: > > + for (i = 0; i < bits; i++, pixels--) { > > I think is worth to add a comment here explaining that the pixel is set to > 1 for brightness > 127 and to 0 for

Re: [PATCH 2/5] drm/format-helper: Fix XRGB888 to monochrome conversion

2022-03-15 Thread Andy Shevchenko
On Tue, Mar 15, 2022 at 12:07:04PM +0100, Geert Uytterhoeven wrote: > The conversion functions drm_fb_xrgb_to_mono() and > drm_fb_gray8_to_mono_line() do not behave correctly when the > horizontal boundaries of the clip rectangle are not multiples of 8: > a. When x1 % 8 != 0, the calculated

Re: [PATCH 1/5] drm/format-helper: Rename drm_fb_xrgb8888_to_mono_reversed()

2022-03-15 Thread Geert Uytterhoeven
Hi Andy, On Tue, Mar 15, 2022 at 2:33 PM Andy Shevchenko wrote: > On Tue, Mar 15, 2022 at 12:07:03PM +0100, Geert Uytterhoeven wrote: > > There is no "reversed" handling in drm_fb_xrgb_to_mono_reversed(): > > the function just converts from color to grayscale, and reduces the > > number of

Re: [PATCH 1/5] drm/format-helper: Rename drm_fb_xrgb8888_to_mono_reversed()

2022-03-15 Thread Andy Shevchenko
On Tue, Mar 15, 2022 at 12:07:03PM +0100, Geert Uytterhoeven wrote: > There is no "reversed" handling in drm_fb_xrgb_to_mono_reversed(): > the function just converts from color to grayscale, and reduces the > number of grayscale levels from 256 to 2 (i.e. brightness 0-127 is > mapped to 0,

Re: [PATCH v2 0/8] Add memory shrinker to VirtIO-GPU DRM driver

2022-03-15 Thread Dmitry Osipenko
On 3/15/22 15:47, Emil Velikov wrote: > On Mon, 14 Mar 2022 at 22:44, Dmitry Osipenko > wrote: > >> Dmitry Osipenko (8): >> drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling >> drm/virtio: Check whether transferred 2D BO is shmem >> drm/virtio: Unlock GEM reservations in

Re: [PATCH v2 1/8] drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling

2022-03-15 Thread Dmitry Osipenko
On 3/15/22 01:42, Dmitry Osipenko wrote: > drm_gem_shmem_get_sg_table() never ever returned NULL on error. Correct > the error handling to avoid crash on OOM. > > Cc: sta...@vger.kernel.org > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/virtio/virtgpu_object.c | 6 -- > 1 file

Re: [PATCH 4/5] drm: ssd130x: Reduce temporary buffer sizes

2022-03-15 Thread Geert Uytterhoeven
Hi Javier, On Tue, Mar 15, 2022 at 1:32 PM Javier Martinez Canillas wrote: > On 3/15/22 12:07, Geert Uytterhoeven wrote: > > ssd130x_clear_screen() allocates a temporary buffer sized to hold one > > byte per pixel, while it only needs to hold one bit per pixel. > > > > ssd130x_fb_blit_rect()

Re: [PATCH 2/5] drm/format-helper: Fix XRGB888 to monochrome conversion

2022-03-15 Thread Geert Uytterhoeven
Hi Javier, On Tue, Mar 15, 2022 at 1:18 PM Javier Martinez Canillas wrote: > On 3/15/22 12:07, Geert Uytterhoeven wrote: > > The conversion functions drm_fb_xrgb_to_mono() and > > drm_fb_gray8_to_mono_line() do not behave correctly when the > > horizontal boundaries of the clip rectangle are

Re: [PATCH v2 0/8] Add memory shrinker to VirtIO-GPU DRM driver

2022-03-15 Thread Emil Velikov
On Mon, 14 Mar 2022 at 22:44, Dmitry Osipenko wrote: > Dmitry Osipenko (8): > drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling > drm/virtio: Check whether transferred 2D BO is shmem > drm/virtio: Unlock GEM reservations in error code path These three are legitimate fixes

Re: [PATCH v2 7/8] drm/virtio: Support memory shrinking

2022-03-15 Thread Emil Velikov
Greetings everyone, Food for thought: Would it make sense to have the madvise ioctl as generic DRM one? Looking around - i915, msm & panfrost already have one and the virtio implementation [below] seems as generic as it gets. On Mon, 14 Mar 2022 at 22:44, Dmitry Osipenko wrote: > +#define

Re: [PATCH v8 22/24] drm: rockchip: Add VOP2 driver

2022-03-15 Thread Daniel Stone
Hi Andy, On Tue, 15 Mar 2022 at 06:46, Andy Yan wrote: > On 3/11/22 16:33, Sascha Hauer wrote: > > The driver is tested with HDMI and MIPI-DSI display on a RK3568-EVB > > board. Overlay support is tested with the modetest utility. AFBC support > > on the cluster windows is tested with

Re: [PATCH 5/5] drm/repaper: Reduce temporary buffer size in repaper_fb_dirty()

2022-03-15 Thread Javier Martinez Canillas
On 3/15/22 12:07, Geert Uytterhoeven wrote: > As the temporary buffer is no longer used to store 8-bit grayscale data, > its size can be reduced to the size needed to store the monochrome > bitmap data. > > Fixes: 24c6bedefbe71de9 ("drm/repaper: Use format helper for xrgb to > monochrome

Re: [v7 1/5] drm/edid: seek for available CEA and DisplayID block from specific EDID block index

2022-03-15 Thread Jani Nikula
On Mon, 14 Mar 2022, Drew Davenport wrote: > On Mon, Mar 14, 2022 at 10:40:47AM +0200, Jani Nikula wrote: >> On Sun, 13 Mar 2022, Lee Shawn C wrote: >> > drm_find_cea_extension() always look for a top level CEA block. Pass >> > ext_index from caller then this function to search next available >>

Re: [PATCH 4/5] drm: ssd130x: Reduce temporary buffer sizes

2022-03-15 Thread Javier Martinez Canillas
On 3/15/22 12:07, Geert Uytterhoeven wrote: > ssd130x_clear_screen() allocates a temporary buffer sized to hold one > byte per pixel, while it only needs to hold one bit per pixel. > > ssd130x_fb_blit_rect() allocates a temporary buffer sized to hold one > byte per pixel for the whole frame

Re: [PATCH 3/5] drm: ssd130x: Fix rectangle updates

2022-03-15 Thread Javier Martinez Canillas
On 3/15/22 12:07, Geert Uytterhoeven wrote: > The rectangle update functions ssd130x_fb_blit_rect() and > ssd130x_update_rect() do not behave correctly when x1 != 0 or y1 != > 0, or when y1 or y2 are not aligned to display page boundaries. > E.g. when used as a text console, only the first line of

Re: [PATCH 2/5] drm/format-helper: Fix XRGB888 to monochrome conversion

2022-03-15 Thread Javier Martinez Canillas
On 3/15/22 12:07, Geert Uytterhoeven wrote: > The conversion functions drm_fb_xrgb_to_mono() and > drm_fb_gray8_to_mono_line() do not behave correctly when the > horizontal boundaries of the clip rectangle are not multiples of 8: > a. When x1 % 8 != 0, the calculated pitch is not correct, >

Re: [PATCH v4 00/24] DEPT(Dependency Tracker)

2022-03-15 Thread Hyeonggon Yoo
On Mon, Mar 14, 2022 at 03:59:06PM +0900, Byungchul Park wrote: > On Sat, Mar 12, 2022 at 01:53:26AM +, Hyeonggon Yoo wrote: > > On Fri, Mar 04, 2022 at 04:06:19PM +0900, Byungchul Park wrote: > > > Hi Linus and folks, > > > > > > I've been developing a tool for detecting deadlock

Re: [PATCH 1/5] drm/format-helper: Rename drm_fb_xrgb8888_to_mono_reversed()

2022-03-15 Thread Javier Martinez Canillas
Hello Geert, Thanks for your patch. On 3/15/22 12:07, Geert Uytterhoeven wrote: > There is no "reversed" handling in drm_fb_xrgb_to_mono_reversed(): > the function just converts from color to grayscale, and reduces the > number of grayscale levels from 256 to 2 (i.e. brightness 0-127 is >

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Matthew Auld
On 14/03/2022 19:40, Arunpravin wrote: handle a situation in the condition order-- == min_order, when order = 0, leading to order = -1, it now won't exit the loop. To avoid this problem, added a order check in the same condition, (i.e) when order is 0, we return -ENOSPC Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915: round_up the size to the alignment value

2022-03-15 Thread Matthew Auld
On Mon, 14 Mar 2022 at 19:32, Arunpravin wrote: > > handle instances when size is not aligned with the min_page_size. > Unigine Heaven has allocation requests for example required pages > are 161 and alignment request is 128. To allocate the left over > 33 pages, continues the iteration to find

  1   2   >