Re: [PATCH] drm/amd/display: Fixed the unused-but-set-variable warning

2022-03-17 Thread Paul Menzel
Dear Aashish, Am 17.03.22 um 15:01 schrieb Aashish Sharma: Thank you for your patch. If you are going to send a v2, please use imperative mood. Maybe: drm/amd/display: Fix unused-but-set-variable warning Fixed this kernel test robot warning: Maybe: Fix the kernel test robot warning

[PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-17 Thread fei . yang
From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

[PATCH] drm/i915: avoid concurrent writes to aux_inv

2022-03-17 Thread fei . yang
From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because

[git pull] drm fixes for 5.17-final

2022-03-17 Thread Dave Airlie
Hi Linus, A few minor changes to finish things off, one mgag200 regression, imx fix and couple of panel changes. Regards, Dave. drm-fixes-2022-03-18: drm fixes for 5.17-rc9/final imx: - Don't test bus flags in atomic check mgag200: - Fix PLL setup on some models panel: - Fix bpp settings on

Re: [Freedreno] [PATCH 3/3] drm/msm/gpu: Remove mutex from wait_event condition

2022-03-17 Thread Hillf Danton
On Thu, 17 Mar 2022 14:07:45 -0700 Rob Clark wrote: > On Thu, Mar 17, 2022 at 1:45 PM Akhil P Oommen > wrote: > > > > On 3/11/2022 5:16 AM, Rob Clark wrote: > > > From: Rob Clark > > > > > > The mutex wasn't really protecting anything before. Before the previous > > > patch we could still be

Re: [PATCH 2/4] drm/gma500: Move gma_intel_crtc_funcs into gma_display.c

2022-03-17 Thread kernel test robot
Hi Patrik, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc8 next-20220317] [If your patch is applied to the wrong git

[RFC PATCH] drm/gma500: gma_crtc_gamma_set() can be static

2022-03-17 Thread kernel test robot
drivers/gpu/drm/gma500/gma_display.c:175:5: warning: symbol 'gma_crtc_gamma_set' was not declared. Should it be static? drivers/gpu/drm/gma500/gma_display.c:322:5: warning: symbol 'gma_crtc_cursor_set' was not declared. Should it be static? drivers/gpu/drm/gma500/gma_display.c:440:5: warning:

[PATCH v6 7/7] drm/i915/gt: Adding new sysfs frequency attributes

2022-03-17 Thread Andi Shyti
From: Sujaritha Sundaresan This patch adds the following new sysfs frequency attributes: - punit_req_freq_mhz - throttle_reason_status - throttle_reason_pl1 - throttle_reason_pl2 - throttle_reason_pl4 - throttle_reason_thermal -

[PATCH v6 6/7] drm/i915/gt: Create per-tile RPS sysfs interfaces

2022-03-17 Thread Andi Shyti
Now tiles have their own sysfs interfaces under the gt/ directory. Because RPS is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 tile case: /sys/.../card0 ├── gt │  

[PATCH v6 5/7] drm/i915/gt: Create per-tile RC6 sysfs interface

2022-03-17 Thread Andi Shyti
Now tiles have their own sysfs interfaces under the gt/ directory. Because RC6 is a property that can be configured on a tile basis, then each tile should have its own interface The new sysfs structure will have a similar layout for the 4 tile case: /sys/.../card0 ├── gt │  

[PATCH v6 4/7] drm/i915/gt: create per-tile sysfs interface

2022-03-17 Thread Andi Shyti
Now that we have tiles we want each of them to have its own interface. A directory "gt/" is created under "cardN/" that will contain as many diroctories as the tiles. In the coming patches tile related interfaces will be added. For now the sysfs gt structure simply has an id interface related to

[PATCH v6 3/7] drm/i915: Prepare for multiple GTs

2022-03-17 Thread Andi Shyti
From: Tvrtko Ursulin On a multi-tile platform, each tile has its own registers + GGTT space, and BAR 0 is extended to cover all of them. Up to four GTs are supported in i915->gt[], with slot zero shadowing the existing i915->gt0 to enable source compatibility with legacy driver paths. A

[PATCH v6 2/7] drm/i915/gt: add gt_is_root() helper

2022-03-17 Thread Andi Shyti
The "gt_is_root(struct intel_gt *gt)" helper return true if the gt is the root gt, which means that its id is 0. Return false otherwise. Suggested-by: Michal Wajdeczko Signed-off-by: Andi Shyti Reviewed-by: Michal Wajdeczko Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_gt.h |

[PATCH v6 1/7] drm/i915: Rename INTEL_REGION_LMEM with INTEL_REGION_LMEM_0

2022-03-17 Thread Andi Shyti
With the upcoming multitile support each tile will have its own local memory. Mark the current LMEM with the suffix '0' to emphasise that it belongs to the root tile. Suggested-by: Michal Wajdeczko Signed-off-by: Andi Shyti Reviewed-by: Michal Wajdeczko Reviewed-by: Andrzej Hajda ---

[PATCH v6 0/7] Introduce multitile support

2022-03-17 Thread Andi Shyti
Hi, This is the second series that prepares i915 to host multitile platforms. It introduces the for_each_gt() macro that loops over the tiles to perform per gt actions. This patch is a combination of two patches developed originally by Abdiel, who introduced some refactoring during probe, and

[PATCH v4 2/4] drm: allow real encoder to be passed for drm_writeback_connector

2022-03-17 Thread Abhinav Kumar
For some vendor driver implementations, display hardware can be shared between the encoder used for writeback and the physical display. In addition resources such as clocks and interrupts can also be shared between writeback and the real encoder. To accommodate such vendor drivers and hardware,

[PATCH v4 4/4] drm/vc4: change vc4 driver to use drm_writeback_connector_init_with_encoder()

2022-03-17 Thread Abhinav Kumar
vc4 driver currently embeds the drm_encoder into struct vc4_txp and later on uses container_of to retrieve the vc4_txp from the drm_encoder. Since drm_encoder has now been made a pointer inside drm_writeback_connector, make vc4 driver use the new API so that the embedded encoder model can be

[PATCH v4 1/4] drm: allow passing possible_crtcs to drm_writeback_connector_init()

2022-03-17 Thread Abhinav Kumar
Clients of drm_writeback_connector_init() initialize the possible_crtcs and then invoke the call to this API. To simplify things, allow passing possible_crtcs as a parameter to drm_writeback_connector_init() and make changes to the other drm drivers to make them compatible with this change.

[PATCH v4 3/4] drm: introduce drm_writeback_connector_init_with_encoder() API

2022-03-17 Thread Abhinav Kumar
For vendors drivers which pass an already allocated and initialized encoder especially for cases where the encoder hardware is shared OR the writeback encoder shares the resources with the rest of the display pipeline introduce a new API, drm_writeback_connector_init_with_encoder() which expects

[PATCH v4 0/4] Allow drm_writeback_connector to accept pointer to drm_encoder

2022-03-17 Thread Abhinav Kumar
There are some vendor drivers for which the writeback encoder shares hardware resources such as clocks and interrupts with the rest of the display pipeline. In addition, there can be use-cases where the writeback encoder could be a shared encoder between the physical display path and the writeback

Re: [PATCH v5 6/9] drm/msm/dp: wait for hpd high before any sink interaction

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:51) > The source device should ensure the sink is ready before > proceeding to read the sink capability or performing any aux transactions. > The sink will indicate its readiness by asserting the HPD line. > > The eDP sink requires

[Bug 215652] kernel 5.17-rc fail to load radeon DRM "modprobe: ERROR: could not insert 'radeon': Unknown symbol in module, or unknown parameter (see dmesg)"

2022-03-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215652 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Status|NEW |RESOLVED

Re: linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-03-17 Thread Stephen Rothwell
Hi all, On Fri, 18 Mar 2022 11:55:44 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the drm tree got a conflict in: > > drivers/gpu/drm/bridge/Kconfig > > between commit: > > 3c3384050d68 ("drm: Don't make DRM_PANEL_BRIDGE dependent on > DRM_KMS_HELPERS") > > from the

[PATCH v2] fbdev: defio: fix the pagelist corruption

2022-03-17 Thread Chuansheng Liu
Easily hit the below list corruption: == list_add corruption. prev->next should be next (c0ceb090), but was ec604507edc8. (prev=ec604507edc8). WARNING: CPU: 65 PID: 3959 at lib/list_debug.c:26 __list_add_valid+0x53/0x80 CPU: 65 PID: 3959 Comm: fbdev Tainted: G U RIP:

linux-next: manual merge of the drm tree with the drm-misc-fixes tree

2022-03-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/bridge/Kconfig between commit: 3c3384050d68 ("drm: Don't make DRM_PANEL_BRIDGE dependent on DRM_KMS_HELPERS") from the drm-misc-fixes tree and commit: 803abfd8dda5 ("drm: bridge: fix unmet dependency on

Re: [PATCH 1/4] drm/gma500: Remove unused declarations and other cruft

2022-03-17 Thread kernel test robot
Hi Patrik, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc8 next-20220317] [If your patch is applied to the wrong git

[RFC PATCH] drm/gma500: psb_spank() can be static

2022-03-17 Thread kernel test robot
drivers/gpu/drm/gma500/psb_drv.c:102:6: warning: symbol 'psb_spank' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel test robot --- drivers/gpu/drm/gma500/psb_drv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v5 1/9] arm64: dts: qcom: sc7280: rename edp_out label to mdss_edp_out

2022-03-17 Thread Doug Anderson
Hi, On Wed, Mar 16, 2022 at 10:36 AM Sankeerth Billakanti wrote: > > Rename the edp_out label in the sc7280 platform to mdss_edp_out > so that the nodes related to mdss are all grouped together in > the board specific files. > > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v5: > -

Re: [PATCH v6 5/5] arm64: dts: qcom: sm8250: remove assigned-clock-rate property for mdp clk

2022-03-17 Thread Doug Anderson
Hi, On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera wrote: > > Drop the assigned clock rate property and vote on the mdp clock as per > calculated value during the usecase. > > This patch is dependent on below patch > https://patchwork.kernel.org/patch/12774067/ > > Signed-off-by: Vinod Polimera

Re: [PATCH v6 4/5] arm64: dts: qcom: sdm845: remove assigned-clock-rate property for mdp clk

2022-03-17 Thread Doug Anderson
Hi, On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera wrote: > > Drop the assigned clock rate property and vote on the mdp clock as per > calculated value during the usecase. > > This patch is dependent on below patch > https://patchwork.kernel.org/patch/12774067/ > > Signed-off-by: Vinod Polimera

Re: [PATCH v6 3/5] arm64: dts: qcom: sm7180: remove assigned-clock-rate property for mdp clk

2022-03-17 Thread Doug Anderson
Hi, On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera wrote: > > Drop the assigned clock rate property and vote on the mdp clock as per > calculated value during the usecase. > > This patch is dependent on below patch > https://patchwork.kernel.org/patch/12774067/ > > Signed-off-by: Vinod Polimera

Re: [PATCH v6 2/5] arm64: dts: qcom: sm7280: remove assigned-clock-rate property for mdp clk

2022-03-17 Thread Doug Anderson
Hi, On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera wrote: > > Drop the assigned clock rate property and vote on the mdp clock as per > calculated value during the usecase. > > This patch is dependent on below patch > https://patchwork.kernel.org/patch/12774067/ Some nits on how you're referring

Re: [PATCH v6 1/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe

2022-03-17 Thread Doug Anderson
Hi, On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera wrote: > > use max clock during probe/bind sequence from the opp table. > The clock will be scaled down when framework sends an update. > > Fixes: 25fdd5933("drm/msm: Add SDM845 DPU support") The "Fixes:" format is a little wrong. Should have

[PATCH] drm/msm/dsi: Use connector directly in msm_dsi_manager_connector_init()

2022-03-17 Thread Stephen Boyd
The member 'msm_dsi->connector' isn't assigned until msm_dsi_manager_connector_init() returns (see msm_dsi_modeset_init() and how it assigns the return value). Therefore this pointer is going to be NULL here. Let's use 'connector' which is what was intended. Cc: Dmitry Baryshkov Cc: Sean Paul

Re: [PATCH v5 4/9] drm/panel-edp: add LQ140M1JW46 edp panel entry

2022-03-17 Thread Doug Anderson
Hi, On Wed, Mar 16, 2022 at 10:37 AM Sankeerth Billakanti wrote: > > Add panel identification entry for the sharp LQ140M1JW46 eDP panel > with power sequencing delay information. > > Signed-off-by: Sankeerth Billakanti > --- > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1

Re: [PATCH 2/4] drm/gma500: Move gma_intel_crtc_funcs into gma_display.c

2022-03-17 Thread kernel test robot
Hi Patrik, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc8 next-20220317] [cannot apply to airlied/drm-next] [If your

[PATCH] drm/panel: ili9341: fix optional regulator handling

2022-03-17 Thread Daniel Mack
If the optional regulator lookup fails, reset the pointer to NULL. Other functions such as mipi_dbi_poweron_reset_conditional() only do a NULL pointer check and will otherwise dereference the error pointer. Fixes: 5a04227326b04c15 ("drm/panel: Add ilitek ili9341 panel driver") Signed-off-by:

Re: [PATCH 2/4] drm/gma500: Move gma_intel_crtc_funcs into gma_display.c

2022-03-17 Thread kernel test robot
Hi Patrik, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc8 next-20220317] [cannot apply to airlied/drm-next] [If your

[RFC] drm/msm: Add a way for userspace to allocate GPU iova

2022-03-17 Thread Rob Clark
From: Rob Clark The motivation at this point is mainly native userspace mesa driver in a VM guest. The one remaining synchronous "hotpath" is buffer allocation, because guest needs to wait to know the bo's iova before it can start emitting cmdstream/state that references the new bo. By

Re: [PATCH 1/4] drm/gma500: Remove unused declarations and other cruft

2022-03-17 Thread kernel test robot
Hi Patrik, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc8 next-20220317] [cannot apply to airlied/drm-next] [If your

[PATCH] drm/panel: ld9040: Register a backlight device

2022-03-17 Thread Paul Cercueil
Register a backlight device to be able to switch between all the gamma levels. While this works, and improves the situation, on my device (Galaxy S2 I9100) the screen does not yet look as good as how it did under Android, independently of the gamma setting. The blacks are washed and look grey,

Re: [PATCH v5 5/9] drm/msm/dp: Add eDP support via aux_bus

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:50) > This patch adds support for generic eDP sink through aux_bus. Please unindent commit text paragraphs. This isn't a book. > The eDP/DP controller driver should support aux transactions originating > from the panel-edp driver and hence

Re: [PATCH 4/4] drm/gma500: Cosmetic cleanup of irq code

2022-03-17 Thread Patrik Jakobsson
On Thu, Mar 17, 2022 at 8:57 PM Thomas Zimmermann wrote: > > Hi Patrik > > Am 17.03.22 um 10:25 schrieb Patrik Jakobsson: > > Use the gma_ prefix instead of psb_ since the code is common for all > > chips. Various coding style fixes. Removal of unused code. Removal of > > duplicate function

Re: [PATCH 1/4] drm/gma500: Remove unused declarations and other cruft

2022-03-17 Thread Patrik Jakobsson
On Thu, Mar 17, 2022 at 8:44 PM Thomas Zimmermann wrote: > > Hi Patrik Hi Thomas and Sam, I have already pushed this series with Daniels ack so I'll address any issues in follow-up patches. Thanks for the extra eyes > > Am 17.03.22 um 10:25 schrieb Patrik Jakobsson: > > Most of these are old

Re: [PATCH v5 4/9] drm/panel-edp: add LQ140M1JW46 edp panel entry

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:49) > Add panel identification entry for the sharp LQ140M1JW46 eDP panel > with power sequencing delay information. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 3/9] arm64: dts: qcom: sc7280: Enable backlight for eDP panel

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:48) > Enable backlight support for eDP panel on CRD platform for sc7280. > > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v5: > - Separate out backlight nodes > > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 18 ++ > 1

Re: [PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:47) > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > index e2efbdd..2df654e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -7,6 +7,7 @@ >

Re: [PATCH v5 1/9] arm64: dts: qcom: sc7280: rename edp_out label to mdss_edp_out

2022-03-17 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2022-03-16 10:35:46) > Rename the edp_out label in the sc7280 platform to mdss_edp_out > so that the nodes related to mdss are all grouped together in > the board specific files. > > Signed-off-by: Sankeerth Billakanti > --- Reviewed-by: Stephen Boyd

Re: [PATCH v6 1/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe

2022-03-17 Thread Stephen Boyd
Quoting Vinod Polimera (2022-03-14 07:46:53) > use max clock during probe/bind sequence from the opp table. > The clock will be scaled down when framework sends an update. Capitalize 'use'. Why is it important to use max frequency during probe/bind? Does not setting the clk rate during probe

Re: [Freedreno] [PATCH 3/3] drm/msm/gpu: Remove mutex from wait_event condition

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 1:45 PM Akhil P Oommen wrote: > > On 3/11/2022 5:16 AM, Rob Clark wrote: > > From: Rob Clark > > > > The mutex wasn't really protecting anything before. Before the previous > > patch we could still be racing with the scheduler's kthread, as that is > > not necessarily

Re: [PATCH 1/4] drm/gma500: Remove unused declarations and other cruft

2022-03-17 Thread kernel test robot
Hi Patrik, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.17-rc8 next-20220317] [cannot apply to airlied/drm-next] [If your

Re: [PATCH] drm/panel: add CONFIG_DRM_KMS_HELPER dependencies

2022-03-17 Thread Arnd Bergmann
On Thu, Mar 17, 2022 at 8:15 PM Thomas Zimmermann wrote: > Am 16.03.22 um 21:59 schrieb Arnd Bergmann: > > On Wed, Mar 16, 2022 at 8:31 PM Thomas Zimmermann > > wrote: > > > > I was going for 'depends on' in the panel drivers because I saw the same > > being > > done for other panel drivers,

Re: [Freedreno] [PATCH 3/3] drm/msm/gpu: Remove mutex from wait_event condition

2022-03-17 Thread Akhil P Oommen
On 3/11/2022 5:16 AM, Rob Clark wrote: From: Rob Clark The mutex wasn't really protecting anything before. Before the previous patch we could still be racing with the scheduler's kthread, as that is not necessarily frozen yet. Now that we've parked the sched threads, the only race is with

Re: [PATCH] drm/amdgpu: fix off by one in amdgpu_gfx_kiq_acquire()

2022-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 16, 2022 at 4:42 AM Dan Carpenter wrote: > > This post-op should be a pre-op so that we do not pass -1 as the bit > number to test_bit(). The current code will loop downwards from 63 to > -1. After changing to a pre-op, it loops from 63 to 0. > > Fixes:

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 12:50 PM Andrey Grodzovsky wrote: > > > On 2022-03-17 14:25, Rob Clark wrote: > > On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky > > wrote: > >> > >> On 2022-03-17 13:35, Rob Clark wrote: > >>> On Thu, Mar 17, 2022 at 9:45 AM Christian König > >>> wrote: > Am

Re: [PATCH] drm/amdgpu: Fix spelling mistake "regiser" -> "register"

2022-03-17 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Mar 15, 2022 at 4:20 PM Colin Ian King wrote: > > There is a spelling mistake in a dev_error error message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH v4 4/4] dt-bindings: display/panel: Add Leadtek ltk035c5444t

2022-03-17 Thread Paul Cercueil
Hi, Le ven., mars 11 2022 at 18:02:40 +0100, Christophe Branchereau a écrit : Add binding for the leadtek ltk035c5444t, which is a 640x480 mipi-dbi over spi / 24-bit RGB panel based on the newvision NV03052C chipset. It is found in the Anbernic RG350M mips handheld. Signed-off-by:

Re: [PATCH 4/4] drm/gma500: Cosmetic cleanup of irq code

2022-03-17 Thread Thomas Zimmermann
Hi Patrik Am 17.03.22 um 10:25 schrieb Patrik Jakobsson: Use the gma_ prefix instead of psb_ since the code is common for all chips. Various coding style fixes. Removal of unused code. Removal of duplicate function declarations. Signed-off-by: Patrik Jakobsson ---

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Andrey Grodzovsky
On 2022-03-17 14:25, Rob Clark wrote: On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky wrote: On 2022-03-17 13:35, Rob Clark wrote: On Thu, Mar 17, 2022 at 9:45 AM Christian König wrote: Am 17.03.22 um 17:18 schrieb Rob Clark: On Thu, Mar 17, 2022 at 9:04 AM Christian König wrote:

Re: [PATCH 3/4] drm/gma500: Don't store crtc_funcs in psb_ops

2022-03-17 Thread Thomas Zimmermann
Am 17.03.22 um 10:25 schrieb Patrik Jakobsson: The drm_crtc_funcs are all generic and no chip specific functions are necessary. We can therefore directly put gma_crtc_funcs into the drm_crtc. Signed-off-by: Patrik Jakobsson Reviewed-by: Thomas Zimmermann ---

Re: [PATCH 2/4] drm/gma500: Move gma_intel_crtc_funcs into gma_display.c

2022-03-17 Thread Thomas Zimmermann
Am 17.03.22 um 10:25 schrieb Patrik Jakobsson: All functions live in gma_display.c already so move the vtable. Also shorten the name to gma_crtc_funcs. Signed-off-by: Patrik Jakobsson Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/cdv_device.c| 2 +-

Re: [PATCH 1/4] drm/gma500: Remove unused declarations and other cruft

2022-03-17 Thread Thomas Zimmermann
Hi Patrik Am 17.03.22 um 10:25 schrieb Patrik Jakobsson: Most of these are old leftovers from one of the driver merges. This is all dead code. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_drv.h | 75 +--- 1 file changed, 1 insertion(+), 74

Re: [PATCH 1/4] drm/gma500: Remove unused declarations and other cruft

2022-03-17 Thread Sam Ravnborg
Hi Patrik, On Thu, Mar 17, 2022 at 10:25:52AM +0100, Patrik Jakobsson wrote: > Most of these are old leftovers from one of the driver merges. This is > all dead code. Nice cleanups. For all four patches: Acked-by: Sam Ravnborg

Re: [PATCH,v2] drm/panel: Fix return value check in nt35950_probe()

2022-03-17 Thread Sam Ravnborg
On Thu, Mar 17, 2022 at 04:37:07PM +0800, Lu Wei wrote: > In function nt35950_probe(), mipi_dsi_device_register_full() is called > to create a MIPI DSI device. If it fails, a pointer encoded with an error > will be returned, so use IS_ERR() to check the return value. Besides, use > PTR_ERR to

Re: [PATCH] drm/panel: add CONFIG_DRM_KMS_HELPER dependencies

2022-03-17 Thread Thomas Zimmermann
Hi Arnd Am 16.03.22 um 21:59 schrieb Arnd Bergmann: On Wed, Mar 16, 2022 at 8:31 PM Thomas Zimmermann wrote: Am 16.03.22 um 20:12 schrieb Thomas Zimmermann: Adding a dependency in all drivers that select DRM_MIPI_DBI avoids the problem for now, adding the dependency in DRM_MIPI_DBI as well

Re: [RFC PATCH 1/4] drm/amdkfd: Improve amdgpu_vm_handle_moved

2022-03-17 Thread Felix Kuehling
Am 2022-03-17 um 04:21 schrieb Christian König: Am 17.03.22 um 01:20 schrieb Felix Kuehling: Let amdgpu_vm_handle_moved update all BO VA mappings of BOs reserved by the caller. This will be useful for handling extra BO VA mappings in KFD VMs that are managed through the render node API.

[PATCH v11 00/13] Add GuC Error Capture Support

2022-03-17 Thread Alan Previn
This series: 1. Enables support of GuC to report error-state-capture using a list of MMIO registers the driver registers and GuC will dump, log and notify right before a GuC triggered engine-reset event. 2. Updates the ADS blob creation to register said lists of global,

Re: [PATCH v2] nvidia-wmi-ec-backlight: Add workarounds for confused firmware

2022-03-17 Thread Daniel Dadap
On 3/17/22 12:35, Alex Deucher wrote: Sorry for jumping in here, but I can't seem to find the original thread with this comment. amdgpu_atombios_encoder_init_backlight() is not applicable to these systems. That is the old pre-DC code path. You want amdgpu_dm_register_backlight_device() for

[PATCH] drm/msm: Add missing put_task_struct() in debugfs path

2022-03-17 Thread Rob Clark
From: Rob Clark Fixes: 25faf2f2e065 ("drm/msm: Show process names in gem_describe") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index 02b9ae65a96a..a4f61972667b

Re: [PATCH v2] nvidia-wmi-ec-backlight: Add workarounds for confused firmware

2022-03-17 Thread Daniel Dadap
On 3/17/22 11:42, Hans de Goede wrote: Hi Daniel, On 3/17/22 14:28, Daniel Dadap wrote: On Mar 17, 2022, at 07:17, Hans de Goede wrote: Hi, On 3/16/22 21:33, Daniel Dadap wrote: Some notebook systems with EC-driven backlight control appear to have a firmware bug which causes the system

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 11:10 AM Andrey Grodzovsky wrote: > > > On 2022-03-17 13:35, Rob Clark wrote: > > On Thu, Mar 17, 2022 at 9:45 AM Christian König > > wrote: > >> Am 17.03.22 um 17:18 schrieb Rob Clark: > >>> On Thu, Mar 17, 2022 at 9:04 AM Christian König > >>> wrote: > Am 17.03.22

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Andrey Grodzovsky
On 2022-03-17 13:35, Rob Clark wrote: On Thu, Mar 17, 2022 at 9:45 AM Christian König wrote: Am 17.03.22 um 17:18 schrieb Rob Clark: On Thu, Mar 17, 2022 at 9:04 AM Christian König wrote: Am 17.03.22 um 16:10 schrieb Rob Clark: [SNIP] userspace frozen != kthread frozen .. that is what

[PATCH v2] drm/bridge: nwl-dsi: switch to devm_drm_of_get_bridge

2022-03-17 Thread José Expósito
The function "drm_of_find_panel_or_bridge" has been deprecated in favor of "devm_drm_of_get_bridge". Switch to the new function and reduce boilerplate. Signed-off-by: José Expósito --- v2: (Thanks to Liu Ying) - Rebase on top of drm-misc-next - Remove drm_of_panel_bridge_remove ---

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Andrey Grodzovsky
On 2022-03-17 12:04, Christian König wrote: Am 17.03.22 um 16:10 schrieb Rob Clark: [SNIP] userspace frozen != kthread frozen .. that is what this patch is trying to address, so we aren't racing between shutting down the hw and the scheduler shoveling more jobs at us. Well exactly that's

Re: [PATCH v2 6/8] drm/shmem-helper: Add generic memory shrinker

2022-03-17 Thread Dmitry Osipenko
On 3/17/22 20:32, Daniel Vetter wrote: >> +static void drm_gem_shmem_update_purgeable_status(struct >> drm_gem_shmem_object *shmem) >> +{ >> +struct drm_gem_object *obj = >base; >> +struct drm_gem_shmem_shrinker *gem_shrinker = obj->dev->shmem_shrinker; >> +size_t page_count =

Re: [PATCH v2 6/8] drm/shmem-helper: Add generic memory shrinker

2022-03-17 Thread Dmitry Osipenko
On 3/17/22 19:13, Rob Clark wrote: ... + /* prevent racing with job submission code paths */ + if (!dma_resv_trylock(obj->resv)) + goto shrinker_lock; >>> >>> jfwiw, the trylock here is in the msm code isn't so much for madvise >>>

Re: [PATCH 1/6] drm: allow real encoder to be passed for drm_writeback_connector

2022-03-17 Thread Abhinav Kumar
Hi Daniel On 3/17/2022 3:01 AM, Daniel Vetter wrote: On Fri, Mar 11, 2022 at 10:05:53AM +0200, Laurent Pinchart wrote: On Fri, Mar 11, 2022 at 10:46:13AM +0300, Dmitry Baryshkov wrote: On Fri, 11 Mar 2022 at 04:50, Abhinav Kumar wrote: For some vendor driver implementations, display

Re: [PATCH v2] nvidia-wmi-ec-backlight: Add workarounds for confused firmware

2022-03-17 Thread Alex Deucher
On Thu, Mar 17, 2022 at 12:42 PM Hans de Goede wrote: > > Hi Daniel, > > On 3/17/22 14:28, Daniel Dadap wrote: > > > >> On Mar 17, 2022, at 07:17, Hans de Goede wrote: > >> > >> Hi, > >> > >>> On 3/16/22 21:33, Daniel Dadap wrote: > >>> Some notebook systems with EC-driven backlight control

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 9:45 AM Christian König wrote: > > Am 17.03.22 um 17:18 schrieb Rob Clark: > > On Thu, Mar 17, 2022 at 9:04 AM Christian König > > wrote: > >> Am 17.03.22 um 16:10 schrieb Rob Clark: > >>> [SNIP] > >>> userspace frozen != kthread frozen .. that is what this patch is > >>>

Re: [PATCH v2 6/8] drm/shmem-helper: Add generic memory shrinker

2022-03-17 Thread Daniel Vetter
On Tue, Mar 15, 2022 at 01:42:51AM +0300, Dmitry Osipenko wrote: > Introduce a common DRM SHMEM shrinker. It allows to reduce code > duplication among DRM drivers, it also handles complicated lockings > for the drivers. This is initial version of the shrinker that covers > basic needs of GPU

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Rob Clark
On Thu, Mar 17, 2022 at 10:27 AM Daniel Vetter wrote: > > On Thu, Mar 17, 2022 at 08:40:51AM -0700, Rob Clark wrote: > > On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote: > > > > > > On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote: > > > > Am 16.03.22 um 16:36 schrieb Rob

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Daniel Vetter
On Thu, Mar 17, 2022 at 05:44:57PM +0100, Christian König wrote: > Am 17.03.22 um 17:18 schrieb Rob Clark: > > On Thu, Mar 17, 2022 at 9:04 AM Christian König > > wrote: > > > Am 17.03.22 um 16:10 schrieb Rob Clark: > > > > [SNIP] > > > > userspace frozen != kthread frozen .. that is what this

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Daniel Vetter
On Thu, Mar 17, 2022 at 08:40:51AM -0700, Rob Clark wrote: > On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote: > > > > On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote: > > > Am 16.03.22 um 16:36 schrieb Rob Clark: > > > > [SNIP] > > > > just one point of clarification.. in the

Re: [PATCH v3 1/3] drm: allow real encoder to be passed for drm_writeback_connector

2022-03-17 Thread Abhinav Kumar
Hi Laurent Thanks for the review. On 3/17/2022 1:51 AM, Laurent Pinchart wrote: Hi Abhinav, Thank you for the patch. On Wed, Mar 16, 2022 at 11:48:16AM -0700, Abhinav Kumar wrote: For some vendor driver implementations, display hardware can be shared between the encoder used for writeback

Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-17 Thread Daniel Vetter
On Thu, Mar 17, 2022 at 08:34:21AM -0700, Rob Clark wrote: > On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote: > > > > On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote: > > > Am 16.03.22 um 16:36 schrieb Rob Clark: > > > > [SNIP] > > > > just one point of clarification.. in the

Re: [PATCH -next] drm/bridge: it6505: Fix build error

2022-03-17 Thread Robert Foss
Hey, Thanks for submitting this. I think this[1] patch should solve the issue you're seeing too. Can you confirm that[1] fixes your issues? [1] https://lore.kernel.org/all/YjJXnzJmDGsrZAXj@xps13/ Rob.

RE: [Intel-gfx] [PATCH v2 1/2] drm/i915/dg2: Add preemption changes for Wa_14015141709

2022-03-17 Thread Srivatsa, Anusha
Looks good. Reviewed-by: Anusha Srivatsa > -Original Message- > From: Intel-gfx On Behalf Of Matt > Roper > Sent: Friday, March 4, 2022 3:47 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 1/2] drm/i915/dg2: Add preemption

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add DSC support to MST path

2022-03-17 Thread Ville Syrjälä
On Thu, Mar 17, 2022 at 06:33:53PM +0200, Stanislav Lisovskiy wrote: > Whenever we are not able to get enough timeslots > for required PBN, let's try to allocate those > using DSC, just same way as we do for SST. > > Those patches are experimental yet, i.e not > for merging, still need to be

[PATCH v2 3/3] drm/msm: Add a way to override processes comm/cmdline

2022-03-17 Thread Rob Clark
From: Rob Clark In the cause of using the GPU via virtgpu, the host side process is really a sort of proxy, and not terribly interesting from the PoV of crash/fault logging. Add a way to override these per process so that we can see the guest process's name. v2: Handle kmalloc failure, add

[PATCH v2 2/3] drm/msm: Split out helper to get comm/cmdline

2022-03-17 Thread Rob Clark
From: Rob Clark Deduplicate this from fault_worker and recover_worker. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gpu.c

[PATCH v2 1/3] drm/msm: Add support for pointer params

2022-03-17 Thread Rob Clark
From: Rob Clark The 64b value field is already suffient to hold a pointer instead of immediate, but we also need a length field. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 12 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 4 ++--

[PATCH v2 0/3] drm/msm: Add comm/cmdline override

2022-03-17 Thread Rob Clark
From: Rob Clark Add a way to override comm/cmdline per-drm_file. This is useful for VM scenarios where the host process is just a proxy for the actual guest process. Rob Clark (3): drm/msm: Add support for pointer params drm/msm: Split out helper to get comm/cmdline drm/msm: Add a way to

Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

2022-03-17 Thread Christian König
Am 17.03.22 um 17:18 schrieb Rob Clark: On Thu, Mar 17, 2022 at 9:04 AM Christian König wrote: Am 17.03.22 um 16:10 schrieb Rob Clark: [SNIP] userspace frozen != kthread frozen .. that is what this patch is trying to address, so we aren't racing between shutting down the hw and the scheduler

Re: [PATCH v2] nvidia-wmi-ec-backlight: Add workarounds for confused firmware

2022-03-17 Thread Hans de Goede
Hi Daniel, On 3/17/22 14:28, Daniel Dadap wrote: > >> On Mar 17, 2022, at 07:17, Hans de Goede wrote: >> >> Hi, >> >>> On 3/16/22 21:33, Daniel Dadap wrote: >>> Some notebook systems with EC-driven backlight control appear to have a >>> firmware bug which causes the system to use GPU-driven

[PATCH 1/2] drm: Add missing DP DSC extended capability definitions.

2022-03-17 Thread Stanislav Lisovskiy
Adding DP DSC register definitions, we might need for further DSC implementation, supporting MST and DP branch pass-through mode. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/dp/drm_dp.c| 25 + include/drm/dp/drm_dp_helper.h | 11 ++- 2 files

[PATCH 2/2] drm/i915: Add DSC support to MST path

2022-03-17 Thread Stanislav Lisovskiy
Whenever we are not able to get enough timeslots for required PBN, let's try to allocate those using DSC, just same way as we do for SST. Those patches are experimental yet, i.e not for merging, still need to be tested with proper DSC display, submitting those to check ig nothing else blows up at

[PATCH 0/2] Add DP MST DSC support to i915

2022-03-17 Thread Stanislav Lisovskiy
Currently we have only DSC support for DP SST. Stanislav Lisovskiy (2): drm: Add missing DP DSC extended capability definitions. drm/i915: Add DSC support to MST path drivers/gpu/drm/dp/drm_dp.c | 25 drivers/gpu/drm/i915/display/intel_dp.c | 138 --

Re: [PATCH 1/1] drm/amdkfd: Protect the Client whilst it is being operated on

2022-03-17 Thread Lee Jones
On Thu, 17 Mar 2022, philip yang wrote: >On 2022-03-17 11:13 a.m., Lee Jones wrote: > > On Thu, 17 Mar 2022, Felix Kuehling wrote: > > > Am 2022-03-17 um 11:00 schrieb Lee Jones: > > Good afternoon Felix, > > Thanks for your review. > > > Am 2022-03-17 um 09:16 schrieb Lee Jones: > >

[PATCH 1/2] drm: Add missing DP DSC extended capability definitions.

2022-03-17 Thread Stanislav Lisovskiy
Adding DP DSC register definitions, we might need for further DSC implementation, supporting MST and DP branch pass-through mode. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/dp/drm_dp.c| 25 + include/drm/dp/drm_dp_helper.h | 11 ++- 2 files

Re: [PATCH 1/1] drm/amdkfd: Protect the Client whilst it is being operated on

2022-03-17 Thread philip yang
On 2022-03-17 11:13 a.m., Lee Jones wrote: On Thu, 17 Mar 2022, Felix Kuehling wrote: Am 2022-03-17 um 11:00 schrieb Lee Jones: Good afternoon Felix, Thanks for your review. Am 2022-03-17 um

  1   2   >