Re: [git pull] drm for 5.20/6.0

2022-08-03 Thread Dave Airlie
On Thu, 4 Aug 2022 at 15:25, Dave Airlie wrote: > > On Thu, 4 Aug 2022 at 14:46, Linus Torvalds > wrote: > > > > On Wed, Aug 3, 2022 at 9:27 PM Linus Torvalds > > wrote: > > > > > > I'll do a few more. It's close enough already that it should be just > > > four more reboots to pinpoint exactly

[PATCH] drm/amd/display: restore plane with no modifiers code.

2022-08-03 Thread Dave Airlie
When this file was split in 5d945cbcd4b16a29d6470a80dfb19738f9a4319f Author: Rodrigo Siqueira Date: Wed Jul 20 15:31:42 2022 -0400 drm/amd/display: Create a file dedicated to planes This chunk seemed to get dropped. Linus noticed on this rx580 and I've reproduced on FIJI which makes sense as

Re: [PATCH] tty: vt: selection: Add check for valid tiocl_selection values

2022-08-03 Thread Jiri Slaby
On 30. 07. 22, 20:49, Helge Deller wrote: The line and column numbers for the selection need to start at 1. Add the checks to prevent invalid input. Signed-off-by: Helge Deller Reported-by: syzbot+14b0e8f3fd1612e35...@syzkaller.appspotmail.com diff --git a/drivers/tty/vt/selection.c

Re: [git pull] drm for 5.20/6.0

2022-08-03 Thread Dave Airlie
On Thu, 4 Aug 2022 at 14:46, Linus Torvalds wrote: > > On Wed, Aug 3, 2022 at 9:27 PM Linus Torvalds > wrote: > > > > I'll do a few more. It's close enough already that it should be just > > four more reboots to pinpoint exactly which commit breaks. > > commit

Re: [git pull] drm for 5.20/6.0

2022-08-03 Thread Linus Torvalds
On Wed, Aug 3, 2022 at 9:27 PM Linus Torvalds wrote: > > I'll do a few more. It's close enough already that it should be just > four more reboots to pinpoint exactly which commit breaks. commit 5d945cbcd4b16a29d6470a80dfb19738f9a4319f is the first bad commit. I think it's supposed to make no

Re: [git pull] drm for 5.20/6.0

2022-08-03 Thread Linus Torvalds
On Wed, Aug 3, 2022 at 9:24 PM Dave Airlie wrote: > > I've reproduced it, I'll send you a revert pile when I confirm it is > the buddy allocator. I've bisected it to 86bd6706c404..074293dd9f61 and don't see "buddy" in any of those commits. I'll do a few more. It's close enough already that it

Re: [git pull] drm for 5.20/6.0

2022-08-03 Thread Dave Airlie
On Thu, 4 Aug 2022 at 14:02, Linus Torvalds wrote: > > On Wed, Aug 3, 2022 at 8:53 PM Dave Airlie wrote: > > > > > It works on my intel laptop, so it's amdgpu somewhere. > > > > I'll spin my ryzen up to see if I can reproduce, and test against the > > drm-next pre-merge tree as well. > > So it's

Re: [git pull] drm for 5.20/6.0

2022-08-03 Thread Linus Torvalds
On Wed, Aug 3, 2022 at 8:53 PM Dave Airlie wrote: > > > It works on my intel laptop, so it's amdgpu somewhere. > > I'll spin my ryzen up to see if I can reproduce, and test against the > drm-next pre-merge tree as well. So it's not my merge - I've had a bad result in the middle of the DRM

Re: [git pull] drm for 5.20/6.0

2022-08-03 Thread Dave Airlie
On Thu, 4 Aug 2022 at 13:47, Linus Torvalds wrote: > > On Wed, Aug 3, 2022 at 8:37 PM Dave Airlie wrote: > > > > Actually I did miss that so that looks good. > > .. I wish it did, but I just actually test-booted my desktop with the > result, and it crashes the X server. This seems to be the

Re: [git pull] drm for 5.20/6.0

2022-08-03 Thread Linus Torvalds
On Wed, Aug 3, 2022 at 8:37 PM Dave Airlie wrote: > > Actually I did miss that so that looks good. .. I wish it did, but I just actually test-booted my desktop with the result, and it crashes the X server. This seems to be the splat in Xorg.0.log: (II) Initializing extension DRI2 (II)

Re: [git pull] drm for 5.20/6.0

2022-08-03 Thread Dave Airlie
On Thu, 4 Aug 2022 at 13:16, Linus Torvalds wrote: > > On Wed, Aug 3, 2022 at 7:46 PM Linus Torvalds > wrote: > > > > I think I have it resolved, am still doing a full build test, and will > > then compare against what your suggested merge is. > > Hmm. > > I end up with *almost* the same thing.

Re: [git pull] drm for 5.20/6.0

2022-08-03 Thread pr-tracker-bot
The pull request you sent on Wed, 3 Aug 2022 15:37:43 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2022-08-03 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b44f2fd87919b5ae6e1756d4c7ba2cbba22238e1 Thank you! -- Deet-doot-dot, I am a bot.

Re: [git pull] drm for 5.20/6.0

2022-08-03 Thread Linus Torvalds
On Wed, Aug 3, 2022 at 7:46 PM Linus Torvalds wrote: > > I think I have it resolved, am still doing a full build test, and will > then compare against what your suggested merge is. Hmm. I end up with *almost* the same thing. Except I ended up with a select DRM_BUDDY for the

Re: [git pull] drm for 5.20/6.0

2022-08-03 Thread Linus Torvalds
On Tue, Aug 2, 2022 at 10:38 PM Dave Airlie wrote: > > This is a conflicty one. The late revert in 5.19 of the amdgpu buddy > allocator causes major conflict fallout. The buddy allocator code in > this one works, so the resolutions are usually just to take stuff from > this. It might actually be

Re: [PATCH v3 6/6] drm/msm/dsi: Improve dsi_phy_driver_probe() probe error handling

2022-08-03 Thread Abhinav Kumar
On 8/2/2022 3:37 PM, Douglas Anderson wrote: The dsi_phy_driver_probe() function has a "goto fail" for no reason. Change it to just always return directly when it sees an error. Make this simpler by leveraging dev_err_probe() which is designed to make code like this shorter / simpler.

Re: [PATCH v3 5/6] drm/msm/dsi: Take advantage of devm_regulator_bulk_get_const()

2022-08-03 Thread Abhinav Kumar
On 8/2/2022 3:37 PM, Douglas Anderson wrote: As of the commit 1de452a0edda ("regulator: core: Allow drivers to define their init data as const") we no longer need to do copying of regulator bulk data from initdata to something dynamic. Let's take advantage of that. In addition to saving some

Re: [PATCH v3 4/6] drm/msm/dsi: Use the new regulator bulk feature to specify the load

2022-08-03 Thread Abhinav Kumar
On 8/2/2022 3:37 PM, Douglas Anderson wrote: As of commit 6eabfc018e8d ("regulator: core: Allow specifying an initial load w/ the bulk API") we can now specify the initial load in the bulk data rather than having to manually call regulator_set_load() on each regulator. Let's use it.

Re: [PATCH v3 3/6] drm/msm/dsi: Don't set a load before disabling a regulator

2022-08-03 Thread Abhinav Kumar
On 8/2/2022 3:37 PM, Douglas Anderson wrote: As of commit 5451781dadf8 ("regulator: core: Only count load for enabled consumers"), a load isn't counted for a disabled regulator. That means all the code in the DSI driver to specify and set loads before disabling a regulator is not actually

Re: [PATCH v3 2/6] drm/msm/dsi: Fix number of regulators for SDM660

2022-08-03 Thread Abhinav Kumar
On 8/2/2022 3:37 PM, Douglas Anderson wrote: 1 regulators is specified listed but the number 2 is specified. This presumably means we try to get a regulator with no name. Fix it. Fixes: 033f47f7f121 ("drm/msm/dsi: Add DSI configuration for SDM660") Signed-off-by: Douglas Anderson Agree

Re: [PATCH v3 1/6] drm/msm/dsi: Fix number of regulators for msm8996_dsi_cfg

2022-08-03 Thread Abhinav Kumar
On 8/2/2022 3:37 PM, Douglas Anderson wrote: 3 regulators are specified listed but the number 2 is specified. Fix it. Fixes: 3a3ff88a0fc1 ("drm/msm/dsi: Add 8x96 info in dsi_cfg") Signed-off-by: Douglas Anderson Reviewed-by: Abhinav Kumar Will queue this for -fixes. --- (no changes

Re: New subsystem for acceleration devices

2022-08-03 Thread Dave Airlie
On Thu, 4 Aug 2022 at 06:21, Oded Gabbay wrote: > > On Wed, Aug 3, 2022 at 10:04 PM Dave Airlie wrote: > > > > On Sun, 31 Jul 2022 at 22:04, Oded Gabbay wrote: > > > > > > Hi, > > > Greg and I talked a couple of months ago about preparing a new accel > > > subsystem for compute/acceleration

Re: [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for RGB/BGR swap

2022-08-03 Thread Rob Herring
On Tue, Aug 2, 2022 at 5:33 AM Marek Vasut wrote: > > On 8/1/22 18:32, Rob Herring wrote: > > On Mon, Aug 01, 2022 at 03:19:00PM +0200, Marek Vasut wrote: > >> The ICN6211 is capable of swapping the output DPI RGB/BGR color channels, > >> document a DT property to select this swap in DT. This can

Re: [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for external REFCLK

2022-08-03 Thread Rob Herring
On Mon, Aug 01, 2022 at 03:17:46PM +0200, Marek Vasut wrote: > The ICN6211 is capable of deriving its internal PLL clock from either > MIPI DSI HS clock, external REFCLK clock, or even internal oscillator. > Currently supported is only the first option. Document support for > external REFCLK clock

[PATCH] drm: fix whitespace in drm_plane_create_color_properties()

2022-08-03 Thread Simon Ser
The drm_property_create_enum() call for "COLOR_RANGE" contains a tab character in the middle of the argument list. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_color_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_color_mgmt.c

Re: [PATCH 1/2] drm/msm: Move hangcheck timer restart

2022-08-03 Thread Rob Clark
On Wed, Aug 3, 2022 at 12:52 PM Akhil P Oommen wrote: > > On 8/3/2022 10:53 PM, Rob Clark wrote: > > From: Rob Clark > > > > Don't directly restart the hangcheck timer from the timer handler, but > > instead start it after the recover_worker replays remaining jobs. > > > > If the kthread is

Re: [RESEND RFC 18/18] drm/display/dp_mst: Move all payload info into the atomic state

2022-08-03 Thread Lyude Paul
On Tue, 2022-07-05 at 09:10 +, Lin, Wayne wrote: > > +struct drm_dp_mst_port; > > + > >   /* DP MST stream allocation (payload bandwidth number) */ > >   struct dc_dp_mst_stream_allocation { > >    uint8_t vcp_id; > >    /* number of slots required for the DP stream in > >    * transport

Re: [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-08-03 Thread Jason Baron
On 8/3/22 15:56, jim.cro...@gmail.com wrote: > On Wed, Jul 20, 2022 at 9:32 AM Jim Cromie wrote: >> > >> Hi Jason, Greg, DRM-folk, >> >> This adds 'typed' "class FOO" support to dynamic-debug, where 'typed' >> means either DISJOINT (like drm debug categories), or VERBOSE (like >> nouveau

Re: [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-08-03 Thread jim . cromie
On Wed, Jul 20, 2022 at 9:32 AM Jim Cromie wrote: > > Hi Jason, Greg, DRM-folk, > > This adds 'typed' "class FOO" support to dynamic-debug, where 'typed' > means either DISJOINT (like drm debug categories), or VERBOSE (like > nouveau debug-levels). Use it in DRM modules: core, helpers, and in >

Re: [PATCH 1/2] drm/msm: Move hangcheck timer restart

2022-08-03 Thread Akhil P Oommen
On 8/3/2022 10:53 PM, Rob Clark wrote: From: Rob Clark Don't directly restart the hangcheck timer from the timer handler, but instead start it after the recover_worker replays remaining jobs. If the kthread is blocked for other reasons, there is no point to immediately restart the timer.

Re: [EXT] Re: [PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-03 Thread Olivier Masse
Hi Brian, Thanks for your comments, please find my reply below. On mar., 2022-08-02 at 15:39 +0100, Brian Starkey wrote: > Caution: EXT Email > > Hi Olivier, > > Some comments below as I mentioned off-list. > > One additional point: some devices need to know if a buffer is > protected, so

[PATCH 2/2] drm/amd/pm: Fix a potential gpu_metrics_table memory leak

2022-08-03 Thread Zhen Ni
Memory is allocated for gpu_metrics_table in smu_v13_0_5_init_smc_tables(), but not freed in smu_v13_0_5_fini_smc_tables(). This may cause memory leaks, fix it. Signed-off-by: Zhen Ni --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 1/2] drm/amd/pm: Fix a potential gpu_metrics_table memory leak

2022-08-03 Thread Zhen Ni
Memory is allocated for gpu_metrics_table in smu_v13_0_4_init_smc_tables(), but not freed in smu_v13_0_4_fini_smc_tables(). This may cause memory leaks, fix it. Signed-off-by: Zhen Ni --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] drm/virtio: remove drm_plane_cleanup() destroy hook

2022-08-03 Thread Sam Ravnborg
Hi Danilo, On Wed, Aug 03, 2022 at 04:55:20PM +0200, Danilo Krummrich wrote: > drmm_universal_plane_alloc() already registers drm_plane_cleanup() as > managed release action via drmm_add_action_or_reset(). Hence, > drm_plane_cleanup() should not be set as drm_plane_funcs.destroy hook. > > Fixes:

[PATCH] drm: panel-orientation-quirks: Add quirk for Anbernic Win600

2022-08-03 Thread Maccraft123
From: Maya Matuszczyk This device is another x86 gaming handheld, and as (hopefully) there is only one set of DMI IDs it's using DMI_EXACT_MATCH Signed-off-by: Maya Matuszczyk --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 2/2] drm/msm/rd: Fix FIFO-full deadlock

2022-08-03 Thread Rob Clark
From: Rob Clark If the previous thing cat'ing $debugfs/rd left the FIFO full, then subsequent open could deadlock in rd_write() (because open is blocked, not giving a chance for read() to consume any data in the FIFO). Also it is generally a good idea to clear out old data from the FIFO.

[PATCH 1/2] drm/msm: Move hangcheck timer restart

2022-08-03 Thread Rob Clark
From: Rob Clark Don't directly restart the hangcheck timer from the timer handler, but instead start it after the recover_worker replays remaining jobs. If the kthread is blocked for other reasons, there is no point to immediately restart the timer. Fixes a random symptom of the problem fixed

Re: [PATCH drm-misc-next v7 0/5] drm: rename CMA helpers to DMA helpers

2022-08-03 Thread Sam Ravnborg
Hi Danilo, On Tue, Aug 02, 2022 at 02:04:00AM +0200, Danilo Krummrich wrote: > This patch series renames all CMA helpers to DMA helpers - considering the > hierarchy of APIs (mm/cma -> dma -> gem/fb dma helpers) calling them DMA > helpers seems to be more applicable. > > Additionally, commit

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2022-08-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 --- Comment #23 from crptdng...@gmx.net --- Further details: After logging into spinchat the issue does not occur straight away. It takes a bit, use all buttons a while. This seems to suggest that the issue is related to a memory buffer that

[PATCH] drm/virtio: remove drm_plane_cleanup() destroy hook

2022-08-03 Thread Danilo Krummrich
drmm_universal_plane_alloc() already registers drm_plane_cleanup() as managed release action via drmm_add_action_or_reset(). Hence, drm_plane_cleanup() should not be set as drm_plane_funcs.destroy hook. Fixes: 7847628862a8 ("drm/virtio: plane: use drm managed resources") Signed-off-by: Danilo

Re: [PATCH v2 2/2] drm/i915: Sanitycheck PCI BARs

2022-08-03 Thread Jani Nikula
On Wed, 03 Aug 2022, "Piorkowski, Piotr" wrote: > From: Piotr Piórkowski > > For proper operation of i915 we need usable PCI GTTMMADDR BAR 0 > (1 for GEN2). In most cases we also need usable PCI GFXMEM BAR 2. > Let's add functions to check if BARs are set, and that it have > a size greater than

Re: [PATCH v2 1/2] drm/i915: Use of BARs names instead of numbers

2022-08-03 Thread Jani Nikula
On Wed, 03 Aug 2022, "Piorkowski, Piotr" wrote: > From: Piotr Piórkowski > > At the moment, when we refer to some PCI BAR we use the number of > this BAR in the code. The meaning of BARs between different platforms > may be different. Therefore, in order to organize the code, > let's start using

Re: [PATCH v3 2/6] drm/msm/dsi: Fix number of regulators for SDM660

2022-08-03 Thread Marijn Suijten
On 2022-08-02 15:37:34, Douglas Anderson wrote: > 1 regulators is specified listed but the number 2 is specified. This > presumably means we try to get a regulator with no name. Fix it. > > Fixes: 033f47f7f121 ("drm/msm/dsi: Add DSI configuration for SDM660") This should be: Fixes: 462f7017a691

Re: [PATCH 2/3] drm/amd/display: Fix 'no previous prototype' compiler warns in amdgpu_dm_plane.c

2022-08-03 Thread Rodrigo Siqueira Jordao
On 2022-08-03 08:41, Imre Deak wrote: On Tue, Aug 02, 2022 at 12:57:24PM -0400, Rodrigo Siqueira Jordao wrote: On 2022-08-01 09:52, Imre Deak wrote: Fix compiler warnings like the following triggered by '-Wmissing-prototypes': CC [M]

Re: [PATCH v5 4/7] drm/i915: Check for integer truncation on the configuration of ttm place

2022-08-03 Thread Jani Nikula
On Mon, 25 Jul 2022, Gwan-gyeong Mun wrote: > There is an impedance mismatch between the first/last valid page > frame number of ttm place in unsigned and our memory/page accounting in > unsigned long. > As the object size is under the control of userspace, we have to be prudent > and catch the

Re: [Intel-gfx] [PATCH v5 1/7] drm: Move and add a few utility macros into drm util header

2022-08-03 Thread Jani Nikula
On Wed, 27 Jul 2022, Andi Shyti wrote: > Hi, > > On Mon, Jul 25, 2022 at 12:25:22PM +0300, Gwan-gyeong Mun wrote: >> It moves overflows_type utility macro into drm util header from i915_utils >> header. The overflows_type can be used to catch the truncation between data >> types. And it adds

Re: [PATCH v3 6/6] drm/msm/dsi: Improve dsi_phy_driver_probe() probe error handling

2022-08-03 Thread Doug Anderson
Hi, On Wed, Aug 3, 2022 at 12:32 AM Dmitry Baryshkov wrote: > > > @@ -634,88 +631,71 @@ static int dsi_phy_driver_probe(struct > > platform_device *pdev) > > phy->cphy_mode = (phy_type == PHY_TYPE_CPHY); > > > > phy->base = msm_ioremap_size(pdev, "dsi_phy", >base_size); > >

Re: [PATCH v3 5/6] drm/msm/dsi: Take advantage of devm_regulator_bulk_get_const()

2022-08-03 Thread Doug Anderson
Hi, On Wed, Aug 3, 2022 at 12:19 AM Dmitry Baryshkov wrote: > > On 03/08/2022 01:37, Douglas Anderson wrote: > > As of the commit 1de452a0edda ("regulator: core: Allow drivers to > > define their init data as const") we no longer need to do copying of > > regulator bulk data from initdata to

Re: [PATCH v3 4/6] drm/msm/dsi: Use the new regulator bulk feature to specify the load

2022-08-03 Thread Doug Anderson
Hi, On Wed, Aug 3, 2022 at 12:12 AM Dmitry Baryshkov wrote: > > On 03/08/2022 01:37, Douglas Anderson wrote: > > As of commit 6eabfc018e8d ("regulator: core: Allow specifying an > > initial load w/ the bulk API") we can now specify the initial load in > > the bulk data rather than having to

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-03 Thread Dave Stevenson
On Wed, 3 Aug 2022 at 13:31, Adam Ford wrote: > > On Wed, Aug 3, 2022 at 7:17 AM Dave Stevenson > wrote: > > > > Hi Adam > > > > On Wed, 3 Aug 2022 at 12:03, Adam Ford wrote: > > > > > > On Wed, Aug 3, 2022 at 1:20 AM Marco Felsch > > > wrote: > > > > > > > > On 22-08-02, Adam Ford wrote: > >

Re: [PATCH] video: fbdev: i740fb: Check the argument of i740_calc_vclk()

2022-08-03 Thread Helge Deller
On 8/3/22 11:24, Zheyu Ma wrote: > Since the user can control the arguments of the ioctl() from the user > space, under special arguments that may result in a divide-by-zero bug. > > If the user provides an improper 'pixclock' value that makes the argumet > of i740_calc_vclk() less than

Re: [PATCH] video: fbdev: arkfb: Fix a divide-by-zero bug in ark_set_pixclock()

2022-08-03 Thread Helge Deller
On 8/3/22 11:23, Zheyu Ma wrote: > Since the user can control the arguments of the ioctl() from the user > space, under special arguments that may result in a divide-by-zero bug > in: > drivers/video/fbdev/arkfb.c:784: ark_set_pixclock(info, (hdiv * > info->var.pixclock) / hmul); > with hdiv=1,

Re: [PATCH 2/3] drm/amd/display: Fix 'no previous prototype' compiler warns in amdgpu_dm_plane.c

2022-08-03 Thread Imre Deak
On Tue, Aug 02, 2022 at 12:57:24PM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-08-01 09:52, Imre Deak wrote: > > Fix compiler warnings like the following triggered by > > '-Wmissing-prototypes': > > > >CC [M] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.o > >

Re: [PATCH 2/5] ANDROID: dma-buf: heaps: Add a shrinker controlled page pool

2022-08-03 Thread Brian Starkey
Hi Olivier, On Tue, Aug 02, 2022 at 11:58:40AM +0200, Olivier Masse wrote: > From: John Stultz > > This patch adds a simple shrinker controlled page pool to the > dmabuf heaps subsystem. > > This replaces the use of the networking page_pool, over concerns > that the lack of a shrinker for that

Re: [EXT] Re: [PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-03 Thread Brian Starkey
Hi, On Wed, Aug 03, 2022 at 11:07:54AM +, Olivier Masse wrote: > Hi Brian, > > Thanks for your comments, please find my reply below. > > On mar., 2022-08-02 at 15:39 +0100, Brian Starkey wrote: > > Caution: EXT Email > > > > Hi Olivier, > > > > Some comments below as I mentioned off-list.

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-03 Thread Adam Ford
On Wed, Aug 3, 2022 at 7:17 AM Dave Stevenson wrote: > > Hi Adam > > On Wed, 3 Aug 2022 at 12:03, Adam Ford wrote: > > > > On Wed, Aug 3, 2022 at 1:20 AM Marco Felsch wrote: > > > > > > On 22-08-02, Adam Ford wrote: > > > > > > ... > > > > > > > > I did some reading about the internal timing

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-03 Thread Dave Stevenson
Hi Adam On Wed, 3 Aug 2022 at 12:03, Adam Ford wrote: > > On Wed, Aug 3, 2022 at 1:20 AM Marco Felsch wrote: > > > > On 22-08-02, Adam Ford wrote: > > > > ... > > > > > > I did some reading about the internal timing generator. It appears > > > > that it's required when video formats use

Re: [PATCH v3 5/8] drm/msm/a6xx: Ensure CX collapse during gpu recovery

2022-08-03 Thread Dmitry Baryshkov
On Wed, 3 Aug 2022 at 13:15, Akhil P Oommen wrote: > > On 8/2/2022 12:44 PM, Dmitry Baryshkov wrote: > > On 30/07/2022 12:40, Akhil P Oommen wrote: > >> Because there could be transient votes from other drivers/tz/hyp which > >> may keep the cx gdsc enabled, we should poll until cx gdsc

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-03 Thread Adam Ford
On Wed, Aug 3, 2022 at 1:20 AM Marco Felsch wrote: > > On 22-08-02, Adam Ford wrote: > > ... > > > > I did some reading about the internal timing generator. It appears > > > that it's required when video formats use fractional bytes, and it's > > > preconfigured to run at 720p by default, but

Re: [PATCH 3/5] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-08-03 Thread Akhil P Oommen
On 8/2/2022 12:45 PM, Dmitry Baryshkov wrote: On 30/07/2022 12:17, Akhil P Oommen wrote: Allow a consumer driver to poll for cx gdsc collapse through Reset framework. Signed-off-by: Akhil P Oommen ---   drivers/clk/qcom/gpucc-sc7280.c | 6 ++   1 file changed, 6 insertions(+) diff --git

Re: [PATCH v3 5/8] drm/msm/a6xx: Ensure CX collapse during gpu recovery

2022-08-03 Thread Akhil P Oommen
On 8/2/2022 12:44 PM, Dmitry Baryshkov wrote: On 30/07/2022 12:40, Akhil P Oommen wrote: Because there could be transient votes from other drivers/tz/hyp which may keep the cx gdsc enabled, we should poll until cx gdsc collapses. We can use the reset framework to poll for cx gdsc collapse from

Re: [PATCH 0/5] clk/qcom: Support gdsc collapse polling using 'reset' inteface

2022-08-03 Thread Akhil P Oommen
On 8/3/2022 12:02 AM, Rob Clark wrote: On Tue, Aug 2, 2022 at 12:02 AM Dmitry Baryshkov wrote: On 30/07/2022 12:17, Akhil P Oommen wrote: Some clients like adreno gpu driver would like to ensure that its gdsc is collapsed at hardware during a gpu reset sequence. This is because it has a

RE: [PATCH 2/2] drm/amd/pm: Fix a potential gpu_metrics_table memory leak

2022-08-03 Thread Quan, Evan
[AMD Official Use Only - General] Thanks for the fixes! The series is reviewed-by: Evan Quan Evan > -Original Message- > From: Zhen Ni > Sent: Wednesday, August 3, 2022 5:20 PM > To: airl...@linux.ie; dan...@ffwll.ch; Quan, Evan ; > Deucher, Alexander ; Koenig, Christian > ; Pan,

Re: [BUG] video: fbdev: arkfb: Found a divide-by-zero bug which may cause DoS

2022-08-03 Thread Zheyu Ma
Hi, On Mon, Aug 1, 2022 at 12:35 PM Helge Deller wrote: > > * Zheyu Ma : > > I found a bug in the arkfb driver in the latest kernel, which may cause DoS. > > > > The reason for this bug is that the user controls some input to ioctl, > > making 'mode' 0x7 on line 704, which causes hdiv = 1, hmul

[PATCH] video: fbdev: i740fb: Check the argument of i740_calc_vclk()

2022-08-03 Thread Zheyu Ma
Since the user can control the arguments of the ioctl() from the user space, under special arguments that may result in a divide-by-zero bug. If the user provides an improper 'pixclock' value that makes the argumet of i740_calc_vclk() less than 'I740_RFREQ_FIX', it will cause a divide-by-zero bug

[PATCH] video: fbdev: arkfb: Fix a divide-by-zero bug in ark_set_pixclock()

2022-08-03 Thread Zheyu Ma
Since the user can control the arguments of the ioctl() from the user space, under special arguments that may result in a divide-by-zero bug in: drivers/video/fbdev/arkfb.c:784: ark_set_pixclock(info, (hdiv * info->var.pixclock) / hmul); with hdiv=1, pixclock=1 and hmul=2 you end up with

Re: [PATCH v2 1/2] drm/i915/gt: Move TLB invalidation to its own file

2022-08-03 Thread Andi Shyti
Hi Mauro, On Fri, Jul 29, 2022 at 09:03:54AM +0200, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Prepare for supporting more TLB invalidation scenarios by moving > the current MMIO invalidation to its own file. > > Signed-off-by: Chris Wilson > Cc: Fei Yang > Signed-off-by: Mauro

[PATCH v2 2/2] drm/i915: Sanitycheck PCI BARs

2022-08-03 Thread Piorkowski, Piotr
From: Piotr Piórkowski For proper operation of i915 we need usable PCI GTTMMADDR BAR 0 (1 for GEN2). In most cases we also need usable PCI GFXMEM BAR 2. Let's add functions to check if BARs are set, and that it have a size greater than 0. In case GTTMMADDR BAR, let's validate at the beginning of

[PATCH v2 1/2] drm/i915: Use of BARs names instead of numbers

2022-08-03 Thread Piorkowski, Piotr
From: Piotr Piórkowski At the moment, when we refer to some PCI BAR we use the number of this BAR in the code. The meaning of BARs between different platforms may be different. Therefore, in order to organize the code, let's start using defined names instead of numbers. v2: Add lost header in

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-08-03 Thread Johan Hovold
On Fri, Jul 29, 2022 at 03:07:47PM +0100, Mark Brown wrote: > On Fri, Jul 29, 2022 at 03:35:33PM +0200, Johan Hovold wrote: > > > I guess we just need to drop all those regulator-allow-set-load > > properties for now even if using DT for power-management configuration > > this way does seem to

[PATCH v2] drm/gem: Fix GEM handle release errors

2022-08-03 Thread Jeffy Chen
Currently we are assuming a one to one mapping between dmabuf and handle when releasing GEM handles. But that is not always true, since we would create extra handles for the GEM obj in cases like gem_open() and getfb{,2}(). A similar issue was reported at:

Re: [PATCH v3 2/4] dt-bindings: display: add new bus-format property for panel-dpi

2022-08-03 Thread Marek Vasut
On 6/28/22 20:18, Max Krummenacher wrote: Hello Max, [...] diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml index dae0676b5c6e..52f5db03b6a8 100644 ---

[PATCH v2 0/2] Sanitycheck PCI BARs

2022-08-03 Thread Piorkowski, Piotr
From: Piotr Piórkowski When initializing the i915, we want to be sure that the PCI BARs have been properly initialized. As part of this series, I have prepared two patches, one that introduces BARs names to use in code instead of numbers, and another that adds function to validate BARs before

Re: [PATCH v3 0/6] drm/msm/dsi regulator improvements

2022-08-03 Thread Dmitry Baryshkov
On 03/08/2022 01:37, Douglas Anderson wrote: The main goal of this series is to make a small dent in cleaning up the way we deal with regulator loads for DSI drivers. As of v3 of this series, the regulator API improvements needed for the later patches in the series are merged into mainline.

Re: [PATCH v3 6/6] drm/msm/dsi: Improve dsi_phy_driver_probe() probe error handling

2022-08-03 Thread Dmitry Baryshkov
On 03/08/2022 01:37, Douglas Anderson wrote: The dsi_phy_driver_probe() function has a "goto fail" for no reason. Change it to just always return directly when it sees an error. Make this simpler by leveraging dev_err_probe() which is designed to make code like this shorter / simpler.

[PATCH 4/5] dt-bindings: reserved-memory: add linaro,secure-heap

2022-08-03 Thread Olivier Masse
DMABUF Reserved memory definition for OP-TEE SDP feaure. Signed-off-by: Olivier Masse --- .../reserved-memory/linaro,secure-heap.yaml | 56 +++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/reserved-memory/linaro,secure-heap.yaml diff

[PATCH 0/5] Add dma-buf secure-heap

2022-08-03 Thread Olivier Masse
Purpose of these patches is to add a new dma-buf heap: linaro,secure-heap Linaro OPTEE OS Secure Data Path feature is relying on a reserved memory defined at Linux Kernel level and OPTEE OS level. >From Linux Kernel side, heap management is using dma-buf heaps interface. John Stultz (2):

Re: [PATCH] drm/bridge: megachips: Fix a null pointer dereference bug

2022-08-03 Thread Ian Ray
On Tue, Jul 19, 2022 at 09:38:16AM +0100, Martyn Welch wrote: > On Sat, 2022-07-16 at 16:13 +0800, Zheyu Ma wrote: > > When removing the module we will get the following warning: > > > > [   31.911505] i2c-core: driver [stdp2690-ge-b850v3-fw] unregistered > > [   31.912484] general protection

[PATCH] dma-buf: heaps: Fix comment typo

2022-08-03 Thread Jason Wang
The double `by' is duplicated in the comment, remove one. Signed-off-by: Jason Wang --- drivers/dma-buf/heaps/cma_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c index 28fb04eccdd0..cd386ce639f3

[PATCH 5/5] plat-hikey: Add linaro,secure-heap compatible

2022-08-03 Thread Olivier Masse
Add DMABUF_HEAPS_SECURE in defconfig Signed-off-by: Olivier Masse --- arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 11 +++ arch/arm64/configs/defconfig | 4 2 files changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts

[PATCH 1/5] ANDROID: dma-buf: heaps: Add deferred-free-helper library code

2022-08-03 Thread Olivier Masse
From: John Stultz This patch provides infrastructure for deferring buffer frees. This is a feature ION provided which when used with some form of a page pool, provides a nice performance boost in an allocation microbenchmark. The reason it helps is it allows the page-zeroing to be done out of

[PATCH 3/5] dma-buf: heaps: add Linaro secure dmabuf heap support

2022-08-03 Thread Olivier Masse
add Linaro secure heap bindings: linaro,secure-heap use genalloc to allocate/free buffer from buffer pool. buffer pool info is from dts. use sg_table instore the allocated memory info, the length of sg_table is 1. implement secure_heap_buf_ops to implement buffer share in difference device: 1.

Re: KASAN: use-after-free Read in drm_gem_object_release

2022-08-03 Thread Dipanjan Das
On Fri, Jul 22, 2022 at 9:23 AM Dipanjan Das wrote: > == > description: KASAN: use-after-free Read in drm_gem_object_release > affected file: drivers/gpu/drm/drm_gem.c > kernel version: 5.4.206 > kernel commit:

[PATCH 2/5] ANDROID: dma-buf: heaps: Add a shrinker controlled page pool

2022-08-03 Thread Olivier Masse
From: John Stultz This patch adds a simple shrinker controlled page pool to the dmabuf heaps subsystem. This replaces the use of the networking page_pool, over concerns that the lack of a shrinker for that implementation may cause additional low-memory kills TODO: Take another pass at trying

Re: [PATCH v3 5/6] drm/msm/dsi: Take advantage of devm_regulator_bulk_get_const()

2022-08-03 Thread Dmitry Baryshkov
On 03/08/2022 01:37, Douglas Anderson wrote: As of the commit 1de452a0edda ("regulator: core: Allow drivers to define their init data as const") we no longer need to do copying of regulator bulk data from initdata to something dynamic. Let's take advantage of that. In addition to saving some

Re: [PATCH v3 4/6] drm/msm/dsi: Use the new regulator bulk feature to specify the load

2022-08-03 Thread Dmitry Baryshkov
On 03/08/2022 01:37, Douglas Anderson wrote: As of commit 6eabfc018e8d ("regulator: core: Allow specifying an initial load w/ the bulk API") we can now specify the initial load in the bulk data rather than having to manually call regulator_set_load() on each regulator. Let's use it.

Re: [PATCH v3 3/6] drm/msm/dsi: Don't set a load before disabling a regulator

2022-08-03 Thread Dmitry Baryshkov
On 03/08/2022 01:37, Douglas Anderson wrote: As of commit 5451781dadf8 ("regulator: core: Only count load for enabled consumers"), a load isn't counted for a disabled regulator. That means all the code in the DSI driver to specify and set loads before disabling a regulator is not actually doing

Re: [PATCH v3 2/6] drm/msm/dsi: Fix number of regulators for SDM660

2022-08-03 Thread Dmitry Baryshkov
On 03/08/2022 01:37, Douglas Anderson wrote: 1 regulators is specified listed but the number 2 is specified. This presumably means we try to get a regulator with no name. Fix it. Fixes: 033f47f7f121 ("drm/msm/dsi: Add DSI configuration for SDM660") Signed-off-by: Douglas Anderson

Re: [PATCH v3 1/6] drm/msm/dsi: Fix number of regulators for msm8996_dsi_cfg

2022-08-03 Thread Dmitry Baryshkov
On 03/08/2022 01:37, Douglas Anderson wrote: 3 regulators are specified listed but the number 2 is specified. Fix it. Fixes: 3a3ff88a0fc1 ("drm/msm/dsi: Add 8x96 info in dsi_cfg") Signed-off-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov --- (no changes since v2) Changes in v2: -

Re: [PATCH 1/5] dt-bindings: clk: qcom: Support gpu cx gdsc reset

2022-08-03 Thread Krzysztof Kozlowski
On 30/07/2022 11:17, Akhil P Oommen wrote: > Add necessary definitions in gpucc bindings to ensure gpu cx gdsc collapse > through 'reset' framework for SC7280. > > Signed-off-by: Akhil P Oommen > --- Assuming discussion in cover letter sorts out: Acked-by: Krzysztof Kozlowski Best regards,

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-03 Thread Marco Felsch
On 22-08-02, Adam Ford wrote: ... > > I did some reading about the internal timing generator. It appears > > that it's required when video formats use fractional bytes, and it's > > preconfigured to run at 720p by default, but registers 28h through 37h > > configure it for other video modes. >