Re: New subsystem for acceleration devices

2022-08-04 Thread Dave Airlie
On Thu, 4 Aug 2022 at 17:44, Oded Gabbay wrote: > > On Thu, Aug 4, 2022 at 2:54 AM Dave Airlie wrote: > > > > On Thu, 4 Aug 2022 at 06:21, Oded Gabbay wrote: > > > > > > On Wed, Aug 3, 2022 at 10:04 PM Dave Airlie wrote: > > > > > > > > On Sun, 31 Jul 2022 at 22:04, Oded Gabbay wrote: > > > >

Re: [PATCH 0/3] Fix bugs in *_set_par() caused by user input

2022-08-04 Thread Zheyu Ma
Hello, On Thu, Aug 4, 2022 at 10:43 PM Ondrej Zajicek wrote: > > On Thu, Aug 04, 2022 at 08:41:22PM +0800, Zheyu Ma wrote: > > In the function *_set_par(), the value of 'screen_size' is > > calculated by the user input. If the user provides the improper value, > > the value of 'screen_size' may

[PATCH -next RESEND] drm/amd/display: Simplify bool conversion

2022-08-04 Thread Yang Li
Fix the following coccicheck warning: ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c:109:52-57: WARNING: conversion to bool not needed here Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 2 +- 1 file changed, 1

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-08-04 Thread Benjamin Herrenschmidt
On Wed, 2022-07-20 at 16:27 +0200, Thomas Zimmermann wrote: > +#if !defined(CONFIG_PPC) > +static inline void out_8(void __iomem *addr, int val) > +{ } > +static inline void out_le32(void __iomem *addr, int val) > +{ } > +static inline unsigned int in_le32(const void __iomem *addr) > +{ > +

Re: [PATCH v2 09/10] drm/ofdrm: Add per-model device function

2022-08-04 Thread Benjamin Herrenschmidt
On Tue, 2022-07-26 at 16:40 +0200, Michal Suchánek wrote: > Hello, > > On Tue, Jul 26, 2022 at 03:38:37PM +0200, Javier Martinez Canillas wrote: > > On 7/20/22 16:27, Thomas Zimmermann wrote: > > > Add a per-model device-function structure in preparation of adding > > > color-management support.

Re: [Intel-gfx] [PATCH 3/7] drm/i915/guc: Add GuC <-> kernel time stamp translation information

2022-08-04 Thread Teres Alexis, Alan Previn
I have a question on below code. Everything else looked good. Will r-b as soon as we can close on below question ...alan On Wed, 2022-07-27 at 19:20 -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > It is useful to be able to match GuC events to kernel events when > looking at

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-08-04 Thread Benjamin Herrenschmidt
On Wed, 2022-07-27 at 10:41 +0200, Thomas Zimmermann wrote: > > > > +static void __iomem *ofdrm_mach64_cmap_ioremap(struct ofdrm_device *odev, > > > +struct device_node *of_node, > > > +u64 fb_base) > > > +{ > > > +

Re: New subsystem for acceleration devices

2022-08-04 Thread Jason Gunthorpe
On Thu, Aug 04, 2022 at 08:48:28PM +0300, Oded Gabbay wrote: > > The flip is true of DRM - DRM is pretty general. I bet I could > > implement an RDMA device under DRM - but that doesn't mean it should > > be done. > > > > My biggest concern is that this subsystem not turn into a back door > > for

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Adam Ford
On Thu, Aug 4, 2022 at 9:52 AM Dave Stevenson wrote: > > On Thu, 4 Aug 2022 at 13:51, Marco Felsch wrote: > > > > Hi Dave, > > > > On 22-08-04, Dave Stevenson wrote: > > > Hi Marco > > > > > > On Thu, 4 Aug 2022 at 10:38, Marco Felsch wrote: > > > > > > > > Hi Dave, Adam, > > > > > > > > On

Re: [PATCH 23/33] drm/vc4: hdmi: Move HDMI reset to pm_resume

2022-08-04 Thread Florian Fainelli
On 6/13/22 07:47, Maxime Ripard wrote: From: Dave Stevenson The BCM2835-37 found in the RaspberryPi 0 to 3 have a power domain attached to the HDMI block, handled in Linux through runtime_pm. That power domain is shared with the VEC block, so even if we put our runtime_pm reference in the

Re: [PATCH v2 4/4] Documentation/gpu/amdgpu/amdgpu_dm: add DM docs for pixel blend mode

2022-08-04 Thread Rodrigo Siqueira Jordao
On 2022-08-04 11:01, Melissa Wen wrote: AMD GPU display manager (DM) maps DRM pixel blend modes (None, Pre-multiplied, Coverage) to MPC hw blocks through blend configuration options. Describe relevant elements and how to set and test them to get the expected DRM blend mode on DCN hw. v2: -

Re: mainline build failure for x86_64 allmodconfig with clang

2022-08-04 Thread Nathan Chancellor
On Thu, Aug 04, 2022 at 02:59:01PM -0700, Linus Torvalds wrote: > On Thu, Aug 4, 2022 at 1:43 PM Nathan Chancellor wrote: > > > > I do note that commit 1b54a0121dba ("drm/amd/display: Reduce stack size > > in the mode support function") did have a workaround for GCC. It appears > > clang will

Re: [PATCH v2 3/4] drm/amd/display: add doc entries for MPC blending configuration

2022-08-04 Thread Rodrigo Siqueira Jordao
On 2022-08-04 11:01, Melissa Wen wrote: Describe structs and enums used to set blend mode properties to MPC blocks. Some pieces of information are already available as code comments, and were just formatted. Others were collected and summarised from discussions on AMD issue tracker[1][2].

Re: [PATCH v2 2/4] Documentation/amdgpu/display: add DC color caps info

2022-08-04 Thread Rodrigo Siqueira Jordao
On 2022-08-04 11:01, Melissa Wen wrote: Add details about color correction capabilities and explain a bit about differences between DC hw generations and also how they are mapped between DRM and DC interface. Two schemas for DCN 2.0 and 3.0 (converted to svg from the original png) is included

Re: [PATCH v2 1/4] Documentation/amdgpu_dm: Add DM color correction documentation

2022-08-04 Thread Rodrigo Siqueira Jordao
On 2022-08-04 11:01, Melissa Wen wrote: AMDGPU DM maps DRM color management properties (degamma, ctm and gamma) to DC color correction entities. Part of this mapping is already documented as code comments and can be converted as kernel docs. v2: - rebase to amd-staging-drm-next - fix typos

Re: mainline build failure for x86_64 allmodconfig with clang

2022-08-04 Thread Linus Torvalds
On Thu, Aug 4, 2022 at 1:43 PM Nathan Chancellor wrote: > > I do note that commit 1b54a0121dba ("drm/amd/display: Reduce stack size > in the mode support function") did have a workaround for GCC. It appears > clang will still inline mode_support_configuration(). If I mark it as > 'noinline', the

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-08-04 Thread Dave Airlie
On Fri, 5 Aug 2022 at 01:53, Mike Lothian wrote: > > Hi > > When is this relanding? It should be in Linus tree now enabled. Dave.

Re: mainline build failure for x86_64 allmodconfig with clang

2022-08-04 Thread Nathan Chancellor
On Thu, Aug 04, 2022 at 09:24:41PM +0200, Arnd Bergmann wrote: > On Thu, Aug 4, 2022 at 8:52 PM Linus Torvalds > wrote: > > > > On Thu, Aug 4, 2022 at 11:37 AM Sudip Mukherjee (Codethink) > > wrote:cov_trace_cmp > > > > > > git bisect points to 3876a8b5e241 ("drm/amd/display: Enable building new

Re: [PATCH 11/12] drm/format-helper: Rework XRGB8888-to-MONO conversion

2022-08-04 Thread Sam Ravnborg
On Wed, Jul 27, 2022 at 01:33:11PM +0200, Thomas Zimmermann wrote: > Update XRGB-to-MONO conversion to support struct iosys_map > and convert all users. Although these are single-plane color formats, > the new interface supports multi-plane formats for consistency with > drm_fb_blit(). > >

Re: [PATCH 10/12] drm/format-helper: Rework XRGB8888-to-GRAY8 conversion

2022-08-04 Thread Sam Ravnborg
On Wed, Jul 27, 2022 at 01:33:10PM +0200, Thomas Zimmermann wrote: > Update XRGB-to-GRAY8 conversion to support struct iosys_map > and convert all users. Although these are single-plane color formats, > the new interface supports multi-plane formats for consistency with > drm_fb_blit(). > >

Re: [PATCH 09/12] drm/format-helper: Rework XRGB8888-to-XRGB2101010 conversion

2022-08-04 Thread Sam Ravnborg
On Wed, Jul 27, 2022 at 01:33:09PM +0200, Thomas Zimmermann wrote: > Update XRGB-to-XRGB2101010 conversion to support struct iosys_map > and convert all users. Although these are single-plane color formats, > the new interface supports multi-plane formats for consistency with > drm_fb_blit().

Re: [PATCH 08/12] drm/format-helper: Rework RGB888-to-XRGB8888 conversion

2022-08-04 Thread Sam Ravnborg
On Wed, Jul 27, 2022 at 01:33:08PM +0200, Thomas Zimmermann wrote: > Update RGB888-to-XRGB conversion to support struct iosys_map > and convert all users. Although these are single-plane color formats, > the new interface supports multi-plane formats for consistency with > drm_fb_blit(). > >

Re: [PATCH 07/12] drm/format-helper: Rework RGB565-to-XRGB8888 conversion

2022-08-04 Thread Sam Ravnborg
On Wed, Jul 27, 2022 at 01:33:07PM +0200, Thomas Zimmermann wrote: > Update RGB565-to-XRGB conversion to support struct iosys_map > and convert all users. Although these are single-plane color formats, > the new interface supports multi-plane formats for consistency with > drm_fb_blit(). > >

Re: [PATCH 06/12] drm/format-helper: Rework XRGB8888-to-RGB888 conversion

2022-08-04 Thread Sam Ravnborg
On Wed, Jul 27, 2022 at 01:33:06PM +0200, Thomas Zimmermann wrote: > Update XRGB-to-RGB888 conversion to support struct iosys_map > and convert all users. Although these are single-plane color formats, > the new interface supports multi-plane formats for consistency with > drm_fb_blit(). > >

Re: [PATCH 05/12] drm/format-helper: Rework XRGB8888-to-RGBG565 conversion

2022-08-04 Thread Sam Ravnborg
On Wed, Jul 27, 2022 at 01:33:05PM +0200, Thomas Zimmermann wrote: > Update XRGB-to-RGB565 conversion to support struct iosys_map > and convert all users. Although these are single-plane color formats, > the new interface supports multi-plane formats for consistency with > drm_fb_blit(). > >

Re: [PATCH 04/12] drm/format-helper: Rework XRGB8888-to-RGBG332 conversion

2022-08-04 Thread Sam Ravnborg
Hi Thomas, On Wed, Jul 27, 2022 at 01:33:04PM +0200, Thomas Zimmermann wrote: > Update XRGB-to-RGB332 conversion to support struct iosys_map > and convert all users. Although these are single-plane color formats, > the new interface supports multi-plane formats for consistency with >

Re: [PATCH 03/12] drm/format-helper: Convert drm_fb_swab() to struct iosys_map

2022-08-04 Thread Sam Ravnborg
Hi Thomas, On Wed, Jul 27, 2022 at 01:33:03PM +0200, Thomas Zimmermann wrote: > Convert drm_fb_swab() to use struct iosys_map() and convert users. The > new interface supports multi-plane color formats. It swabs only plane[0], sbut this is maybe enough to say so. A few comments in the following.

Re: New subsystem for acceleration devices

2022-08-04 Thread Oded Gabbay
On Thu, Aug 4, 2022 at 6:04 PM Jeffrey Hugo wrote: > > On 8/4/2022 6:00 AM, Tvrtko Ursulin wrote: > > > > On 04/08/2022 00:54, Dave Airlie wrote: > >> On Thu, 4 Aug 2022 at 06:21, Oded Gabbay wrote: > >>> > >>> On Wed, Aug 3, 2022 at 10:04 PM Dave Airlie wrote: > > On Sun, 31 Jul 2022

Re: [PATCH 02/12] drm/format-helper: Merge drm_fb_memcpy() and drm_fb_memcpy_toio()

2022-08-04 Thread Sam Ravnborg
Hi Thomas, On Wed, Jul 27, 2022 at 01:33:02PM +0200, Thomas Zimmermann wrote: > Merge drm_fb_memcpy() and drm_fb_memcpy() into drm_fb_memcpy() that One of these is drm_fb_memcpy_toio() > uses struct iosys_map for buffers. The new function also supports > multi-plane color formats. Convert all

[PATCH] drm/mediatek: dsi: Move mtk_dsi_stop() call back to mtk_dsi_poweroff()

2022-08-04 Thread Nícolas F . R . A . Prado
As the comment right before the mtk_dsi_stop() call advises, mtk_dsi_stop() should only be called after mtk_drm_crtc_atomic_disable(). That's because that function calls drm_crtc_wait_one_vblank(), which requires the vblank irq to be enabled. Previously mtk_dsi_stop(), being in mtk_dsi_poweroff()

Re: [PATCH 2/2] drm/cmdline-parser: Use assert when needed

2022-08-04 Thread kernel test robot
Hi "Michał, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-tip/drm-tip] [cannot apply to drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next linus/master v5.19 next-20220804] [If your

Re: mainline build failure for x86_64 allmodconfig with clang

2022-08-04 Thread Arnd Bergmann
On Thu, Aug 4, 2022 at 8:52 PM Linus Torvalds wrote: > > On Thu, Aug 4, 2022 at 11:37 AM Sudip Mukherjee (Codethink) > wrote:cov_trace_cmp > > > > git bisect points to 3876a8b5e241 ("drm/amd/display: Enable building new > > display engine with KCOV enabled"). > > Ahh. So that was presumably why

Re: [PATCH 2/2] drm/cmdline-parser: Use assert when needed

2022-08-04 Thread kernel test robot
ative-tests/20220804-212019 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next config: hexagon-randconfig-r001-20220804 (https://download.01.org/0day-ci/archive/20220805/202208050217.vhlt1udz-...@intel.com/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-pr

Re: [PATCH v3 3/3] drm/i915/gt: document TLB cache invalidation functions

2022-08-04 Thread Randy Dunlap
Hi Mauro, On 8/4/22 00:37, Mauro Carvalho Chehab wrote: > Add a description for the TLB cache invalidation algorithm and for > the related kAPI functions. > > Signed-off-by: Mauro Carvalho Chehab > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the

Re: [Intel-gfx] [PATCH] drm: Fix typo 'the the' in comment

2022-08-04 Thread Summers, Stuart
On Thu, 2022-07-21 at 14:23 +0800, Slark Xiao wrote: > Replace 'the the' with 'the' in the comment. > > Signed-off-by: Slark Xiao Reviewed-by: Stuart Summers > --- > drivers/gpu/drm/display/drm_dp_helper.c | 2 +- > drivers/gpu/drm/i915/i915_irq.c | 2 +- >

Re: mainline build failure for x86_64 allmodconfig with clang

2022-08-04 Thread Linus Torvalds
On Thu, Aug 4, 2022 at 11:37 AM Sudip Mukherjee (Codethink) wrote: > > git bisect points to 3876a8b5e241 ("drm/amd/display: Enable building new > display engine with KCOV enabled"). Ahh. So that was presumably why it was disabled before - because it presumably does disgusting things that make

mainline build failure for x86_64 allmodconfig with clang

2022-08-04 Thread Sudip Mukherjee (Codethink)
Hi All, The latest mainline kernel branch fails to build for x86_64 allmodconfig with clang. The errors are: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn30/display_mode_vba_30.c:3596:6: error: stack frame size (2216) exceeds limit (2048) in 'dml30_ModeSupportAndSystemConfigurationFull'

Re: mainline build failure due to 6fdd2077ec03 ("drm/amd/amdgpu: add memory training support for PSP_V13")

2022-08-04 Thread Sudip Mukherjee
On Thu, Aug 4, 2022 at 6:17 PM Linus Torvalds wrote: > > On Thu, Aug 4, 2022 at 12:35 AM Sudip Mukherjee (Codethink) > wrote: > > > > I will be happy to test any patch or provide any extra log if needed. > > It sounds like that file just needs to get a > > #include > > there, and for some

[PATCH] drm/amd/amdgpu: fix build failure due to implicit declaration

2022-08-04 Thread Sudip Mukherjee
The builds for alpha and mips allmodconfig fails with the error: drivers/gpu/drm/amd/amdgpu/psp_v13_0.c:534:23: error: implicit declaration of function 'vmalloc'; did you mean 'kvmalloc'? [-Werror=implicit-function-declaration] drivers/gpu/drm/amd/amdgpu/psp_v13_0.c:534:21: error:

Re: [PATCH v6 00/10] Add PSR support for eDP

2022-08-04 Thread Doug Anderson
Hi, On Thu, Aug 4, 2022 at 9:21 AM Robert Foss wrote: > > On Fri, 29 Jul 2022 at 02:22, Doug Anderson wrote: > > > > Hi, > > > > On Mon, Jul 11, 2022 at 5:57 AM Vinod Polimera > > wrote: > > > > > > Changes in v2: > > > - Use dp bridge to set psr entry/exit instead of dpu_enocder. > > > -

Re: New subsystem for acceleration devices

2022-08-04 Thread Oded Gabbay
On Thu, Aug 4, 2022 at 5:50 PM Jason Gunthorpe wrote: > > On Thu, Aug 04, 2022 at 10:43:42AM +0300, Oded Gabbay wrote: > > > After all, memory management services, or common device chars handling > > I can get from other subsystems (e.g. rdma) as well. I'm sure I could > > model my uAPI to be

[PULL] drm-intel-next-fixes

2022-08-04 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-fixes-2022-08-04: - disable pci resize on 32-bit systems (Nirmoy) - don't leak the ccs state (Matt) - TLB invalidation fixes (Chris) Thanks, Rodrigo. The following changes since commit 2bc7ea71a73747a77e7f83bc085b0d2393235410: Merge tag

Re: [PATCH 1/2] drm/msm: Move hangcheck timer restart

2022-08-04 Thread Rob Clark
On Thu, Aug 4, 2022 at 12:53 AM Akhil P Oommen wrote: > > On 8/4/2022 1:59 AM, Rob Clark wrote: > > On Wed, Aug 3, 2022 at 12:52 PM Akhil P Oommen > > wrote: > >> On 8/3/2022 10:53 PM, Rob Clark wrote: > >>> From: Rob Clark > >>> > >>> Don't directly restart the hangcheck timer from the timer

Re: [PATCH] drm/amd/display: restore plane with no modifiers code.

2022-08-04 Thread Linus Torvalds
On Wed, Aug 3, 2022 at 10:50 PM Dave Airlie wrote: > > With this applied, I get gdm back. I can confirm that it makes thing work again for me too. Applied. Linus

Re: mainline build failure due to 6fdd2077ec03 ("drm/amd/amdgpu: add memory training support for PSP_V13")

2022-08-04 Thread Linus Torvalds
On Thu, Aug 4, 2022 at 12:35 AM Sudip Mukherjee (Codethink) wrote: > > I will be happy to test any patch or provide any extra log if needed. It sounds like that file just needs to get a #include there, and for some reason architectures other than alpha and mips end up getting it

Re: [PATCH 01/12] drm/format-helper: Provide drm_fb_blit()

2022-08-04 Thread Sam Ravnborg
Hi Thomas, On Wed, Jul 27, 2022 at 01:33:01PM +0200, Thomas Zimmermann wrote: > Provide drm_fb_blit() that works with struct iosys_map. Update all > users of drm_fb_blit_toio(), which required a destination buffer in > I/O memory. The new function's interface works with multi-plane > color

Re: [PATCH v6 00/10] Add PSR support for eDP

2022-08-04 Thread Robert Foss
On Fri, 29 Jul 2022 at 02:22, Doug Anderson wrote: > > Hi, > > On Mon, Jul 11, 2022 at 5:57 AM Vinod Polimera > wrote: > > > > Changes in v2: > > - Use dp bridge to set psr entry/exit instead of dpu_enocder. > > - Don't modify whitespaces. > > - Set self refresh aware from atomic_check. >

Re: [v1] drm/msm/disp/dpu1: add support for hierarchical flush for dspp in sc7280

2022-08-04 Thread Dmitry Baryshkov
On Thu, 4 Aug 2022 at 13:29, Kalyan Thota wrote: > > Flush mechanism for DSPP blocks has changed in sc7280 family, it > allows individual sub blocks to be flushed in coordination with > master flush control. > > representation: master_flush && (PCC_flush | IGC_flush .. etc ) > > This change adds

Re: [PATCH] drm/vmwgfx: cleanup comments

2022-08-04 Thread Zack Rusin
On Sat, 2022-07-30 at 09:57 -0400, Tom Rix wrote: > Remove second 'should' > > Spelling replacements > aqcuire -> acquire > applcations -> applications > assumings -> assumes > begining-> beginning > commited-> committed > contol -> control > inbetween -> in between >

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-08-04 Thread Mike Lothian
Hi When is this relanding? Cheers Mike On Mon, 18 Jul 2022 at 21:40, Dixit, Ashutosh wrote: > > On Thu, 14 Jul 2022 08:00:32 -0700, Christian König wrote: > > > > Am 14.07.22 um 15:33 schrieb Alex Deucher: > > > On Thu, Jul 14, 2022 at 9:09 AM Christian König > > > wrote: > > >> Hi Mauro, >

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-04 Thread Sam Ravnborg
Hi Kevin, > 1) Get an un-accelerated driver merged without new uapi, ioctls, etc. All > you need is there already. We already agreed to take the code mostly as-is > and do the cleanups later on. > > 2a) Stay around on dri-devel, send improvements and fixes for the merged > code. > > 2b) In

Re: New subsystem for acceleration devices

2022-08-04 Thread Jeffrey Hugo
On 8/4/2022 6:00 AM, Tvrtko Ursulin wrote: On 04/08/2022 00:54, Dave Airlie wrote: On Thu, 4 Aug 2022 at 06:21, Oded Gabbay wrote: On Wed, Aug 3, 2022 at 10:04 PM Dave Airlie wrote: On Sun, 31 Jul 2022 at 22:04, Oded Gabbay wrote: Hi, Greg and I talked a couple of months ago about

[PATCH v2 4/4] Documentation/gpu/amdgpu/amdgpu_dm: add DM docs for pixel blend mode

2022-08-04 Thread Melissa Wen
AMD GPU display manager (DM) maps DRM pixel blend modes (None, Pre-multiplied, Coverage) to MPC hw blocks through blend configuration options. Describe relevant elements and how to set and test them to get the expected DRM blend mode on DCN hw. v2: - add ref tag (Tales) Signed-off-by: Melissa

[PATCH v2 3/4] drm/amd/display: add doc entries for MPC blending configuration

2022-08-04 Thread Melissa Wen
Describe structs and enums used to set blend mode properties to MPC blocks. Some pieces of information are already available as code comments, and were just formatted. Others were collected and summarised from discussions on AMD issue tracker[1][2]. [1]

[PATCH v2 2/4] Documentation/amdgpu/display: add DC color caps info

2022-08-04 Thread Melissa Wen
Add details about color correction capabilities and explain a bit about differences between DC hw generations and also how they are mapped between DRM and DC interface. Two schemas for DCN 2.0 and 3.0 (converted to svg from the original png) is included to illustrate it. They were obtained from a

[PATCH v2 1/4] Documentation/amdgpu_dm: Add DM color correction documentation

2022-08-04 Thread Melissa Wen
AMDGPU DM maps DRM color management properties (degamma, ctm and gamma) to DC color correction entities. Part of this mapping is already documented as code comments and can be converted as kernel docs. v2: - rebase to amd-staging-drm-next - fix typos (Tales) - undo kernel-docs inside functions

[PATCH v2 0/4] Documentation/amdgpu/display: describe color and blend mode properties mapping

2022-08-04 Thread Melissa Wen
As mentioned in the previous version, patches 1 and 2 describe DM mapping of DRM color correction properties to DC interface and where detached from 3D LUT RFC series [1]. Patches 3 and 4 describe MPC block programming that matches the three DRM blend modes and came from previous work [2][3] and

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Dave Stevenson
On Thu, 4 Aug 2022 at 13:51, Marco Felsch wrote: > > Hi Dave, > > On 22-08-04, Dave Stevenson wrote: > > Hi Marco > > > > On Thu, 4 Aug 2022 at 10:38, Marco Felsch wrote: > > > > > > Hi Dave, Adam, > > > > > > On 22-08-03, Dave Stevenson wrote: > > > > Hi Adam > > > > > > > > On Wed, 3 Aug 2022

Re: New subsystem for acceleration devices

2022-08-04 Thread Jason Gunthorpe
On Thu, Aug 04, 2022 at 10:43:42AM +0300, Oded Gabbay wrote: > After all, memory management services, or common device chars handling > I can get from other subsystems (e.g. rdma) as well. I'm sure I could > model my uAPI to be rdma uAPI compliant (I can define proprietary uAPI > there as well),

RE: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Biju Das
Hi Adam, > Subject: Re: imx8mm lcdif->dsi->adv7535 no video, no errors > > On Thu, Aug 4, 2022 at 7:52 AM Marco Felsch > wrote: > > > > Hi Dave, > > > > On 22-08-04, Dave Stevenson wrote: > > > Hi Marco > > > > > > On Thu, 4 Aug 2022 at 10:38, Marco Felsch > wrote: > > > > > > > > Hi Dave,

[PATCH v4 1/6] drm/msm/dsi: Fix number of regulators for msm8996_dsi_cfg

2022-08-04 Thread Douglas Anderson
3 regulators are listed but the number 2 is specified. Fix it. Fixes: 3a3ff88a0fc1 ("drm/msm/dsi: Add 8x96 info in dsi_cfg") Signed-off-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- Changes in v4: - Use more gooder English in the commit description.

[PATCH v4 2/6] drm/msm/dsi: Fix number of regulators for SDM660

2022-08-04 Thread Douglas Anderson
1 regulator is listed but the number 2 is specified. This presumably means we try to get a regulator with no name. Fix it. Fixes: 462f7017a691 ("drm/msm/dsi: Fix DSI and DSI PHY regulator config from SDM660") Signed-off-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn

[PATCH v4 3/6] drm/msm/dsi: Don't set a load before disabling a regulator

2022-08-04 Thread Douglas Anderson
As of commit 5451781dadf8 ("regulator: core: Only count load for enabled consumers"), a load isn't counted for a disabled regulator. That means all the code in the DSI driver to specify and set loads before disabling a regulator is not actually doing anything useful. Let's remove it. It should be

[PATCH v4 5/6] drm/msm/dsi: Take advantage of devm_regulator_bulk_get_const()

2022-08-04 Thread Douglas Anderson
As of the commit 1de452a0edda ("regulator: core: Allow drivers to define their init data as const") we no longer need to do copying of regulator bulk data from initdata to something dynamic. Let's take advantage of that. In addition to saving some code, this also moves us to using ARRAY_SIZE() to

[PATCH v4 6/6] drm/msm/dsi: Improve dsi_phy_driver_probe() probe error handling

2022-08-04 Thread Douglas Anderson
The dsi_phy_driver_probe() function has a "goto fail" for no reason. Change it to just always return directly when it sees an error. Make this simpler by leveraging dev_err_probe() which is designed to make code like this shorter / simpler. NOTE: as part of this, we now pass through error codes

[PATCH v4 4/6] drm/msm/dsi: Use the new regulator bulk feature to specify the load

2022-08-04 Thread Douglas Anderson
As of commit 6eabfc018e8d ("regulator: core: Allow specifying an initial load w/ the bulk API") we can now specify the initial load in the bulk data rather than having to manually call regulator_set_load() on each regulator. Let's use it. Signed-off-by: Douglas Anderson Reviewed-by: Dmitry

[PATCH v4 0/6] drm/msm/dsi regulator improvements

2022-08-04 Thread Douglas Anderson
The main goal of this series is to make a small dent in cleaning up the way we deal with regulator loads for DSI drivers. As of v3 of this series, the regulator API improvements needed for the later patches in the series are merged into mainline. Thus this series only contains the DSI changes

Re: [v1] drm/msm/disp/dpu1: add support for hierarchical flush for dspp in sc7280

2022-08-04 Thread Doug Anderson
On Thu, Aug 4, 2022 at 3:29 AM Kalyan Thota wrote: > > +static void dpu_hw_ctl_set_dspp_hierarchical_flush(struct dpu_hw_ctl *ctx, > + enum dpu_dspp dspp, enum dpu_dspp_sub_blk dspp_sub_blk) > +{ > + uint32_t flushbits = 0, active = 0; nit: don't init to 0 since you just override

Re: [PATCH] drm/amd/display: restore plane with no modifiers code.

2022-08-04 Thread Harry Wentland
On 2022-08-04 01:50, Dave Airlie wrote: > When this file was split in > > 5d945cbcd4b16a29d6470a80dfb19738f9a4319f > Author: Rodrigo Siqueira > Date: Wed Jul 20 15:31:42 2022 -0400 > > drm/amd/display: Create a file dedicated to planes > > This chunk seemed to get dropped. Linus noticed on

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Marco Felsch
Hi Adam, On 22-08-04, Adam Ford wrote: > On Thu, Aug 4, 2022 at 7:52 AM Marco Felsch wrote: > > > > Hi Dave, > > > > On 22-08-04, Dave Stevenson wrote: > > > Hi Marco > > > > > > On Thu, 4 Aug 2022 at 10:38, Marco Felsch wrote: > > > > > > > > Hi Dave, Adam, > > > > > > > > On 22-08-03, Dave

[PATCH] drm/gma500: Fix comment typo

2022-08-04 Thread Jason Wang
The double `the' is duplicated in the comment, remove one. Signed-off-by: Jason Wang --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index

[PATCH] drm/panel: nt35510: Fix comment typo

2022-08-04 Thread Jason Wang
The double `the' is duplicated in the comment, remove one. Signed-off-by: Jason Wang --- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35510.c

[PATCH] drm/mipi-dsi: Fix comment typo

2022-08-04 Thread Jason Wang
The double `the' is duplicated in the comment, remove one. Signed-off-by: Jason Wang --- drivers/gpu/drm/drm_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index c40bde96cfdf..fd2790a5664d 100644 ---

[PATCH] drm/display: Fix comment typo

2022-08-04 Thread Jason Wang
The double `the' is duplicated in the comment, remove one. Signed-off-by: Jason Wang --- drivers/gpu/drm/display/drm_dp_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index

[PATCH 2/2] drm/cmdline-parser: Use assert when needed

2022-08-04 Thread Michał Winiarski
Expecting to observe a specific value, when the function responsible for setting the value has failed will lead to extra noise in test output. Use assert when the situation calls for it. Also - very small tidying up around the changed areas (whitespace / variable locality). Signed-off-by: Michał

[PATCH 1/2] drm/cmdline-parser: Merge negative tests

2022-08-04 Thread Michał Winiarski
Negative tests can be expressed as a single parameterized test case, which highlights that we're following the same test logic (passing negative cmdline and expecting drm_mode_parse_command_line_for_connector to fail), which improves readability. Signed-off-by: Michał Winiarski ---

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Marco Felsch
Hi Dave, On 22-08-04, Dave Stevenson wrote: > Hi Marco > > On Thu, 4 Aug 2022 at 11:28, Marco Felsch wrote: > > > > On 22-08-03, Dave Stevenson wrote: > > > On Wed, 3 Aug 2022 at 13:31, Adam Ford wrote: > > > > ... > > > > > > Mine also states the DSI source needs to provide correct video

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Adam Ford
On Thu, Aug 4, 2022 at 7:52 AM Marco Felsch wrote: > > Hi Dave, > > On 22-08-04, Dave Stevenson wrote: > > Hi Marco > > > > On Thu, 4 Aug 2022 at 10:38, Marco Felsch wrote: > > > > > > Hi Dave, Adam, > > > > > > On 22-08-03, Dave Stevenson wrote: > > > > Hi Adam > > > > > > > > On Wed, 3 Aug

[PATCH 0/3] Fix bugs in *_set_par() caused by user input

2022-08-04 Thread Zheyu Ma
In the function *_set_par(), the value of 'screen_size' is calculated by the user input. If the user provides the improper value, the value of 'screen_size' may larger than 'info->screen_size', which may cause a bug in the memset_io(). Zheyu Ma (3): video: fbdev: vt8623fb: Check the size of

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Marco Felsch
Hi Dave, On 22-08-04, Dave Stevenson wrote: > Hi Marco > > On Thu, 4 Aug 2022 at 10:38, Marco Felsch wrote: > > > > Hi Dave, Adam, > > > > On 22-08-03, Dave Stevenson wrote: > > > Hi Adam > > > > > > On Wed, 3 Aug 2022 at 12:03, Adam Ford wrote: > > > > ... > > > > > > > Did managed to get

Re: [PATCH] drm/imx/dcss: get rid of HPD warning message

2022-08-04 Thread Laurentiu Palcu
On Thu, Jul 21, 2022 at 03:25:02PM +0300, Laurent Pinchart wrote: > Hi Laurentiu, > > Thank you for the patch. > > On Thu, Jul 21, 2022 at 03:09:12PM +0300, Laurentiu Palcu wrote: > > When DCSS + MIPI_DSI is used, and the last bridge in the chain supports > > HPD, we can see a "Hot plug

[PATCH 3/3] video: fbdev: s3fb: Check the size of screen before memset_io()

2022-08-04 Thread Zheyu Ma
In the function s3fb_set_par(), the value of 'screen_size' is calculated by the user input. If the user provides the improper value, the value of 'screen_size' may larger than 'info->screen_size', which may cause the following bug: [ 54.083733] BUG: unable to handle page fault for address:

[PATCH 2/3] video: fbdev: arkfb: Check the size of screen before memset_io()

2022-08-04 Thread Zheyu Ma
In the function arkfb_set_par(), the value of 'screen_size' is calculated by the user input. If the user provides the improper value, the value of 'screen_size' may larger than 'info->screen_size', which may cause the following bug: [ 659.399066] BUG: unable to handle page fault for address:

[PATCH 1/3] video: fbdev: vt8623fb: Check the size of screen before memset_io()

2022-08-04 Thread Zheyu Ma
In the function vt8623fb_set_par(), the value of 'screen_size' is calculated by the user input. If the user provides the improper value, the value of 'screen_size' may larger than 'info->screen_size', which may cause the following bug: [ 583.339036] BUG: unable to handle page fault for address:

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-04 Thread Thomas Zimmermann
Hi Am 03.08.22 um 03:49 schrieb Kevin Brace: Hi Thomas, I am honestly surprised of the e-mail back and forth regarding the mainlining of OpenChrome DRM, but let me state my position. That's because your expectations are unrealistic. We don't know you, you apparently have little prior

[PATCH RFC] dma-buf: To check DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT status on debug

2022-08-04 Thread Arvind Yadav
If core DMA-buf framework forgets to call dma_fence_enable_signaling() before calling the dma_fence_is_signaled(). To handle this scenario on debug kernel the DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT needs to be checked before checking the actual signaling status. Signed-off-by: Arvind Yadav ---

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Dave Stevenson
Hi Marco On Thu, 4 Aug 2022 at 11:28, Marco Felsch wrote: > > On 22-08-03, Dave Stevenson wrote: > > On Wed, 3 Aug 2022 at 13:31, Adam Ford wrote: > > ... > > > > Mine also states the DSI source needs to provide correct video timing > > > with start and stop sync packets. > > > > > > If I

Re: New subsystem for acceleration devices

2022-08-04 Thread Tvrtko Ursulin
On 04/08/2022 00:54, Dave Airlie wrote: On Thu, 4 Aug 2022 at 06:21, Oded Gabbay wrote: On Wed, Aug 3, 2022 at 10:04 PM Dave Airlie wrote: On Sun, 31 Jul 2022 at 22:04, Oded Gabbay wrote: Hi, Greg and I talked a couple of months ago about preparing a new accel subsystem for

Re: [RFC PATCH 1/2] drm/panel-edp: Allow overriding the eDP EDID

2022-08-04 Thread Jani Nikula
On Fri, 29 Jul 2022, Doug Anderson wrote: > Hi, > > On Thu, Jul 21, 2022 at 4:36 AM Dmitry Baryshkov > wrote: >> >> On Thu, 21 Jul 2022 at 01:55, Douglas Anderson wrote: >> > >> > I found that writing to `/sys/kernel/debug/dri/*/eDP*/edid_override` >> > wasn't working for me. I could see the

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Dave Stevenson
Hi Marco On Thu, 4 Aug 2022 at 10:38, Marco Felsch wrote: > > Hi Dave, Adam, > > On 22-08-03, Dave Stevenson wrote: > > Hi Adam > > > > On Wed, 3 Aug 2022 at 12:03, Adam Ford wrote: > > ... > > > > > Did managed to get access to the ADV7535 programming guide? This is the > > > > black box here.

[v1] drm/msm/disp/dpu1: add support for hierarchical flush for dspp in sc7280

2022-08-04 Thread Kalyan Thota
Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for the above design. Signed-off-by: Kalyan

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Marco Felsch
On 22-08-03, Dave Stevenson wrote: > On Wed, 3 Aug 2022 at 13:31, Adam Ford wrote: ... > > Mine also states the DSI source needs to provide correct video timing > > with start and stop sync packets. > > > > If I remember correctly, it seemed like Marek V wanted the hard coded > >

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Marco Felsch
On 22-08-03, Adam Ford wrote: > On Wed, Aug 3, 2022 at 7:17 AM Dave Stevenson ... > > Not meaning to butt in, but I have datasheets for ADV7533 and 7535 > > from previously looking at these chips. > > Thanks for the feedback. > > > Mine fairly plainly states: > > "The DSI receiver input

Re: [PATCH v3 2/3] drm/amdgpu_dm: Rely on split out luminance calculation function

2022-08-04 Thread Jani Nikula
On Tue, 19 Jul 2022, Jouni Högander wrote: > Luminance range calculation was split out into drm_edid.c and is now > part of edid parsing. Rely on values calculated during edid parsing and > use these for caps->aux_max_input_signal and caps->aux_min_input_signal. Harry, I'll merge patches 1 & 3

Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

2022-08-04 Thread Alice Chen
Pavel Machek 於 2022年7月31日 週日 清晨5:42寫道: > > +// SPDX-License-Identifier: GPL-2.0-only > > +/* > > + * Copyright (C) 2022 Richtek Technology Corp. > > + * > > + * Author: Alice Chen > Add ">" at end of line. > > The series is quite big, would it be possible to submit LED changes > in separate

Re: [PATCH] drm: fix whitespace in drm_plane_create_color_properties()

2022-08-04 Thread Jani Nikula
On Wed, 03 Aug 2022, Simon Ser wrote: > The drm_property_create_enum() call for "COLOR_RANGE" contains a tab > character in the middle of the argument list. > > Signed-off-by: Simon Ser Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/drm_color_mgmt.c | 2 +- > 1 file changed, 1

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-04 Thread Marco Felsch
Hi Dave, Adam, On 22-08-03, Dave Stevenson wrote: > Hi Adam > > On Wed, 3 Aug 2022 at 12:03, Adam Ford wrote: ... > > > Did managed to get access to the ADV7535 programming guide? This is the > > > black box here. Let me check if I can provide you a link with our repo > > > so you can test

Re: [PATCH] tty: vt: selection: Add check for valid tiocl_selection values

2022-08-04 Thread Jiri Slaby
On 04. 08. 22, 10:44, Helge Deller wrote: On 8/4/22 09:15, Helge Deller wrote: Hello Jiri, Thanks for looking into this patch! On 8/4/22 07:47, Jiri Slaby wrote: On 30. 07. 22, 20:49, Helge Deller wrote: The line and column numbers for the selection need to start at 1. Add the checks to

Re: [Intel-gfx] [PATCH v5 1/7] drm: Move and add a few utility macros into drm util header

2022-08-04 Thread Andi Shyti
Hi Jani, > >> It moves overflows_type utility macro into drm util header from i915_utils > >> header. The overflows_type can be used to catch the truncation between data > >> types. And it adds safe_conversion() macro which performs a type conversion > >> (cast) of an source value into a new

[PATCH v4 6/6] drm/ttm: Switch to using the new res callback

2022-08-04 Thread Arunpravin Paneer Selvam
Apply new intersect and compatible callback instead of having a generic placement range verfications. v2: Added a separate callback for compatiblilty checks (Christian) Signed-off-by: Christian König Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 45

  1   2   >