Re: [PATCH v2 1/3] dma-buf: Add ioctl to query mmap coherency/cache info

2022-09-07 Thread Rob Clark
On Wed, Sep 7, 2022 at 9:55 AM Daniel Vetter wrote: > > On Thu, Aug 18, 2022 at 08:01:53AM -0700, Rob Clark wrote: > > On Thu, Aug 18, 2022 at 7:54 AM Christian König > > wrote: > > > > > > Am 18.08.22 um 16:25 schrieb Rob Clark: > > > > On Thu, Aug 18, 2022 at 4:21 AM Christian König > > > >

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

2022-09-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216455 --- Comment #7 from Alex Deucher (alexdeuc...@gmail.com) --- (In reply to Lijo Lazar from comment #6) > (In reply to Alex Deucher from comment #5) > > (In reply to Lijo Lazar from comment #3) > > > Created attachment 301760 [details] > > > LTR

[pull] amdgpu, amdkfd drm-fixes-6.0

2022-09-07 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.0. The following changes since commit 7e18e42e4b280c85b76967a9106a13ca61c16179: Linux 6.0-rc4 (2022-09-04 13:10:01 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.0-2022-09-07 for you to

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

2022-09-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216455 --- Comment #6 from Lijo Lazar (lijo.la...@gmail.com) --- (In reply to Alex Deucher from comment #5) > (In reply to Lijo Lazar from comment #3) > > Created attachment 301760 [details] > > LTR Fix > > > > Does the attached patch help? > > The

Re: [Intel-gfx] [PATCH v3 13/15] drm/i915/huc: better define HuC status getparam possible return values.

2022-09-07 Thread Teres Alexis, Alan Previn
Yup - simple stuff - LGTM: Reviewed-by: Alan Previn On Fri, 2022-08-19 at 15:53 -0700, Daniele Ceraolo Spurio wrote: > The current HuC status getparam return values are a bit confusing in > regards to what happens in some scenarios. In particular, most of the > error cases cause the ioctl to

[linux-next:master] BUILD REGRESSION 5957ac6635a1a12d4aa2661bbf04d3085a73372a

2022-09-07 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 5957ac6635a1a12d4aa2661bbf04d3085a73372a Add linux-next specific files for 20220907 Error/Warning reports: https://lore.kernel.org/linux-mm/202209070728.o3stvgvt-...@intel.com https

Re: [RFC PATCH 3/3] drm/msm: filter out modes for DP/eDP bridge having unsupported clock

2022-09-07 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-08-29 20:33:09) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index bfd0aeff3f0d..8b91d8adf921 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -117,6 +117,7 @@ struct

Re: [RFC PATCH 2/3] drm/msm: filter out modes for DSI bridge having unsupported clock

2022-09-07 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-08-29 20:33:08) > diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c > index 39bbabb5daf6..3a06a157d1b1 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi.c > +++ b/drivers/gpu/drm/msm/dsi/dsi.c > @@ -265,6 +265,11 @@ int msm_dsi_modeset_init(struct

Re: [RFC PATCH 3/3] drm/msm/dp: move dp_request_irq() call to dp_display_probe()

2022-09-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-09-01 02:15:27) > As the MDSS registers the IRQ domain before populating child devices, > there is little point in deferring the IRQ request up to the > msm_dp_modeset_init(). Following the 'get resources as early as > possible' paradigm, move dp_request_irq() call

Re: [RFC PATCH 2/3] drm/msm/dp: switch to using platform_get_irq()

2022-09-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-09-01 02:15:26) > There is little point in using irq_of_parse_and_map(). Switch to plain > and usual platform_get_irq() for parsing the DP IRQ line. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- > 1 file changed, 2

Re: [RFC PATCH 1/3] drm/msm/dp: fold disable_irq into devm_request_irq

2022-09-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-09-01 02:15:25) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index bfd0aeff3f0d..3173e6962a78 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1251,13 +1251,12 @@ int

Re: [PATCH v2] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-07 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-09-07 12:50:37) > DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an > upstream device disconnect. This patch will enforce this rule by always > cleared DOWNPREAD_CTRL register to 0 before start link training. At rare DOWNSPREAD_CTRL > case that DP

Re: [PATCH v6 1/4] drm/msm: clean event_thread->worker in case of an error

2022-09-07 Thread Abhinav Kumar
On 6/17/2022 4:33 PM, Dmitry Baryshkov wrote: If worker creation fails, nullify the event_thread->worker, so that msm_drm_uninit() doesn't try accessing invalid memory location. While we are at it, remove duplicate assignment to the ret variable. Fixes: 1041dee2178f ("drm/msm: use

[PATCH v4.1] drm/i915/mtl: Define engine context layouts

2022-09-07 Thread Radhakrishna Sripada
From: Matt Roper The part of the media and blitter engine contexts that we care about for setting up an initial state are the same on MTL as they were on DG2 (and PVC), so we need to update the driver conditions to re-use the DG2 context table. For render/compute engines, the part of the

[PATCH v4.1] drm/i915: Read graphics/media/display arch version from hw

2022-09-07 Thread Radhakrishna Sripada
From: Matt Roper Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own architecture major.minor versions and stepping ID's which should be

[PATCH v2] Revert "drm/i915/dg2: extend Wa_1409120013 to DG2"

2022-09-07 Thread Lucas De Marchi
This reverts commit 487970e8bb776c989013bb59d6cbb22e45b9afc6. Updated bspec and workaround database note Wa_1409120013 is not needed for DG2 (or any Xe_LPD) platform. Simply check by display version 12. v2: Simplify condition check to display version (Matt Roper) Cc: Matt Atwood Cc: Clint

Re: [PATCH] drm/i915: Invert if/else ladder for frequency read

2022-09-07 Thread Matt Roper
On Wed, Sep 07, 2022 at 01:30:41PM -0700, Lucas De Marchi wrote: > Continue converting the driver to the convention of last version first, > extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will > be handled by the first branch. > > With the new ranges it's easier to see what

[PATCH] drm/i915: Noop lrc_init_wa_ctx() on recent/future platforms

2022-09-07 Thread Lucas De Marchi
Except for graphics version 8 and 9, nothing is done in lrc_init_wa_ctx(). Assume this won't be needed on future platforms as well and remove the warning. Note that this function is not called for anything below version 8 since those don't use either guc or execlist, i.e. HAS_EXECLISTS() is

RE: [Intel-gfx] [PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-09-07 Thread Sripada, Radhakrishna
Hi Lucas/Matt, > -Original Message- > From: De Marchi, Lucas > Sent: Wednesday, September 7, 2022 3:21 PM > To: Roper, Matthew D > Cc: Sripada, Radhakrishna ; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vivi, Rodrigo > > Subject: Re: [Intel-gfx] [PATCH v4

Re: [PATCH 1/2] drm/i915/gt: Use MEDIA_VER() when handling media fuses

2022-09-07 Thread Lucas De Marchi
On Wed, Sep 07, 2022 at 03:18:00PM -0700, Matt Roper wrote: On Wed, Sep 07, 2022 at 01:39:10PM -0700, Lucas De Marchi wrote: Check for media IP version instead of graphics since this is figuring out the media engines' configuration. Currently the only platform with non-matching graphics/media

Re: [Intel-gfx] [PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-09-07 Thread Lucas De Marchi
On Wed, Sep 07, 2022 at 03:13:31PM -0700, Matt Roper wrote: On Wed, Sep 07, 2022 at 01:49:25PM -0700, Lucas De Marchi wrote: On Thu, Sep 01, 2022 at 11:03:33PM -0700, Radhakrishna Sripada wrote: > From: Matt Roper > > Going forward, the hardware teams no longer consider new platforms to > have

Re: [PATCH 2/2] drm/i915/gt: Extract function to apply media fuses

2022-09-07 Thread Matt Roper
On Wed, Sep 07, 2022 at 01:39:11PM -0700, Lucas De Marchi wrote: > Just like is done for compute and copy engines, extract a function to > handle media engines. While at it, be consistent on using or not the > uncore/gt/info variable aliases. > > Cc: Matt Roper > Signed-off-by: Lucas De Marchi

Re: [PATCH 1/2] drm/i915/gt: Use MEDIA_VER() when handling media fuses

2022-09-07 Thread Matt Roper
On Wed, Sep 07, 2022 at 01:39:10PM -0700, Lucas De Marchi wrote: > Check for media IP version instead of graphics since this is figuring > out the media engines' configuration. Currently the only platform with > non-matching graphics/media version is Meteor Lake: update the check in >

Re: [Intel-gfx] [PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-09-07 Thread Matt Roper
On Wed, Sep 07, 2022 at 01:49:25PM -0700, Lucas De Marchi wrote: > On Thu, Sep 01, 2022 at 11:03:33PM -0700, Radhakrishna Sripada wrote: > > From: Matt Roper > > > > Going forward, the hardware teams no longer consider new platforms to > > have a "generation" in the way we've defined it for past

Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-07 Thread Mateusz Kwiatkowski
Hi Maxime, W dniu 7.09.2022 o 16:34, Maxime Ripard pisze: > On Mon, Sep 05, 2022 at 06:44:42PM +0200, Mateusz Kwiatkowski wrote: >> Hi Maxime, >> >> W dniu 5.09.2022 o 15:37, Maxime Ripard pisze: > +    vfp = vfp_min + (porches_rem / 2); > +    vbp = porches - vfp; Relative

[PATCH] drm/i915: Document and future-proof preemption control policy

2022-09-07 Thread Matt Roper
Intel hardware allows some preemption settings to be controlled either by the kernel-mode driver exclusively, or placed under control of the user-mode drivers; on Linux we always select the userspace control option. The various registers involved in this are not documented very clearly; let's add

[GIT PULL FOR v6.1] R-Car DU changes

2022-09-07 Thread Laurent Pinchart
/media.git tags/du-next-20220907 for you to fetch changes up to cee3e5839cedcc71be755580dc9c0b87fd129116: dt-bindings: display: bridge: renesas,dw-hdmi: Add resets property (2022-09-07 23:50:03 +0300) - Misc fixes

Re: [PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-07 Thread Dmitry Baryshkov
On Wed, 7 Sept 2022 at 22:59, Rob Herring wrote: > > On Thu, Sep 01, 2022 at 01:23:04PM +0300, Dmitry Baryshkov wrote: > > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > > > Note, this removes description of individual DPU port@ nodes. However > > such definitions add no

[PATCH v2 3/4] drm/sched: always keep selected ring sched list in ctx entity

2022-09-07 Thread James Zhu
Always keep selected ring sched list in ctx entity. v2: fixed typo Signed-off-by: James Zhu --- drivers/gpu/drm/scheduler/sched_entity.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_entity.c

[PATCH 4/4] drm/amdgpu: update amdgpu_ctx_init_entity

2022-09-07 Thread James Zhu
update amdgpu_ctx_init_entity with new drm_sched_pick_best. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c index

[PATCH 2/4] drm/sched: implement new drm_sched_pick_best

2022-09-07 Thread James Zhu
drm_sched_pick_best return best selecetd ring schedul list's address. Signed-off-by: James Zhu --- drivers/gpu/drm/scheduler/sched_entity.c | 2 +- drivers/gpu/drm/scheduler/sched_main.c | 14 -- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git

[PATCH 3/4] drm/sched: always keep selecetd ring sched list in ctx entity

2022-09-07 Thread James Zhu
Always keep selecetd ring sched list in ctx entity. Signed-off-by: James Zhu --- drivers/gpu/drm/scheduler/sched_entity.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c index

[PATCH 1/4] drm/sched: returns struct drm_gpu_scheduler ** for drm_sched_pick_best

2022-09-07 Thread James Zhu
drm_sched_pick_best returns struct drm_gpu_scheduler ** instead of struct drm_gpu_scheduler * Signed-off-by: James Zhu --- include/drm/gpu_scheduler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h index

Re: [Intel-gfx] [PATCH v4 02/11] drm/i915: Read graphics/media/display arch version from hw

2022-09-07 Thread Lucas De Marchi
On Thu, Sep 01, 2022 at 11:03:33PM -0700, Radhakrishna Sripada wrote: From: Matt Roper Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own

[PATCH 2/2] drm/i915/gt: Extract function to apply media fuses

2022-09-07 Thread Lucas De Marchi
Just like is done for compute and copy engines, extract a function to handle media engines. While at it, be consistent on using or not the uncore/gt/info variable aliases. Cc: Matt Roper Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 136 --

[PATCH 1/2] drm/i915/gt: Use MEDIA_VER() when handling media fuses

2022-09-07 Thread Lucas De Marchi
Check for media IP version instead of graphics since this is figuring out the media engines' configuration. Currently the only platform with non-matching graphics/media version is Meteor Lake: update the check in gen11_vdbox_has_sfc() so it considers not only version 12, but also any later version

[PATCH] drm/i915: Invert if/else ladder for frequency read

2022-09-07 Thread Lucas De Marchi
Continue converting the driver to the convention of last version first, extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will be handled by the first branch. With the new ranges it's easier to see what platform a branch started to be taken. Besides the >= 11 change, the branch

Re: [PATCH v6 12/12] dt-bindings: display/msm: add support for the display on SM8250

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:12PM +0300, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8250 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/dpu-sm8250.yaml | 96 >

Re: [PATCH V2 1/2] dt-bindings: Add byteswap order to chrontel ch7033

2022-09-07 Thread Laurent Pinchart
Hi Chris, On Wed, Sep 07, 2022 at 08:29:06AM -0500, Chris Morgan wrote: > On Mon, Sep 05, 2022 at 05:20:57PM +0200, Robert Foss wrote: > > On Sat, 3 Sept 2022 at 02:17, Laurent Pinchart wrote: > > > On Fri, Sep 02, 2022 at 10:39:05AM -0500, Chris Morgan wrote: > > > > From: Chris Morgan > > > >

Re: [PATCH v3 2/2] drm/plane_helper: Split into parameterized test cases

2022-09-07 Thread Maíra Canal
On 9/5/22 15:32, Michał Winiarski wrote: > The test was constructed as a single function (test case) which checks > multiple conditions, calling the function that is tested multiple times > with different arguments. > This usually means that it can be easily converted into multiple test > cases. >

Re: [PATCH v6 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas

2022-09-07 Thread Rob Herring
On Thu, 01 Sep 2022 13:23:11 +0300, Dmitry Baryshkov wrote: > Add missing device nodes (DSI, PHYs, DP/eDP) to the existing MDSS > schemas. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/mdss-msm8998.yaml| 12 + > .../bindings/display/msm/mdss-qcm2290.yaml|

Re: [PATCH v3 1/2] drm/plane_helper: Print actual/expected values on failure

2022-09-07 Thread Maíra Canal
On 9/5/22 15:32, Michał Winiarski wrote: > Currently the values are printed with debug log level. > Adjust the log level and link the output with the test by using kunit_err. > > Example output: > foo: dst: 20x20+10+10, expected: 10x10+0+0 > foo: EXPECTATION FAILED at

Re: [PATCH v6 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:06PM +0300, Dmitry Baryshkov wrote: > In order to make the schema more readable, split dpu-sc7180 into the DPU > and MDSS parts, each one describing just a single device binding. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/dpu-sc7180.yaml

Re: build failure of next-20220906 due to 396369d67549 ("drm: vkms: Add support to the RGB565 format")

2022-09-07 Thread Sudip Mukherjee
On Wed, Sep 7, 2022 at 8:23 PM Melissa Wen wrote: > > On 09/07, Sudip Mukherjee wrote: > > Hi Melissa, > > > > On Wed, Sep 7, 2022 at 6:05 PM Melissa Wen wrote: > > > > > > On 09/06, Sudip Mukherjee wrote: > > > > On Tue, Sep 6, 2022 at 4:59 PM Sudip Mukherjee (Codethink) > > > > wrote: > > > >

[PATCH v3 2/2] drm/tests: Change "igt_" prefix to "drm_test_"

2022-09-07 Thread Maíra Canal
With the introduction of KUnit, IGT is no longer the only option to run the DRM unit tests, as the tests can be run through kunit-tool or on real hardware with CONFIG_KUNIT. Therefore, remove the "igt_" prefix from the tests and replace it with the "drm_test_" prefix, making the tests' names

[PATCH v3 1/2] drm/tests: Split drm_framebuffer_create_test into parameterized tests

2022-09-07 Thread Maíra Canal
The igt_check_drm_framebuffer_create is based on a loop that executes tests for all createbuffer_tests test cases. This could be better represented by parameterized tests, provided by KUnit. So, convert the igt_check_drm_framebuffer_create into parameterized tests. Signed-off-by: Maíra Canal

Re: [PATCH v6 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:05PM +0300, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. > > Signed-off-by:

Re: [PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:04PM +0300, Dmitry Baryshkov wrote: > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > Note, this removes description of individual DPU port@ nodes. However > such definitions add no additional value. The reg values do not > correspond to

Re: [PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:04PM +0300, Dmitry Baryshkov wrote: > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > Note, this removes description of individual DPU port@ nodes. However > such definitions add no additional value. The reg values do not > correspond to

[PATCH v2] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-07 Thread Kuogee Hsieh
DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an upstream device disconnect. This patch will enforce this rule by always cleared DOWNPREAD_CTRL register to 0 before start link training. At rare case that DP MSA timing parameters may be mis-interpreted by the sink which

Re: [PATCH v2 09/41] drm/connector: Add TV standard property

2022-09-07 Thread Mateusz Kwiatkowski
Hi Maxime, W dniu 7.09.2022 o 14:10, Maxime Ripard pisze: > Hi, > > On Fri, Sep 02, 2022 at 12:00:33AM +0200, Mateusz Kwiatkowski wrote: >> W dniu 29.08.2022 o 15:11, Maxime Ripard pisze: >>> The TV mode property has been around for a while now to select and get the >>> current TV mode output on

Re: [PATCH v2 4/5] drm/msm/hdmi: don't take extra reference on PHY device

2022-09-07 Thread Abhinav Kumar
On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote: The of_find_device_by_node() already increments the device's usage count, so there is no need to increment it again using get_device(). Drop this extra get_device(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar ---

Re: [PATCH v6 03/12] dt-bindings: display/msm: add interconnects property to qcom,mdss-smd845

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:03PM +0300, Dmitry Baryshkov wrote: > Add interconnects required for the SDM845 MDSS device tree node. This > change was made in the commit c8c61c09e38b ("arm64: dts: qcom: sdm845: > Add interconnects property for display"), but was not reflected in the > schema. > >

Re: [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:01PM +0300, Dmitry Baryshkov wrote: > Split Mobile Display SubSystem (MDSS) root node bindings to the separate > yaml file. Changes to the existing (txt) schema: > - Added optional "vbif_nrt_phys" region used by msm8996 > - Made "bus" and "vsync" clocks optional

Re: [PATCH v2 14/15] vfio: Rename vfio_device_put() and vfio_device_try_get()

2022-09-07 Thread Eric Auger
On 9/1/22 16:37, Kevin Tian wrote: > With the addition of vfio_put_device() now the names become confusing. > > vfio_put_device() is clear from object life cycle p.o.v given kref. > > vfio_device_put()/vfio_device_try_get() are helpers for tracking > users on a registered device. > > Now rename

Re: [PATCH v2 12/15] vfio/amba: Use the new device life cycle helpers

2022-09-07 Thread Eric Auger
Hi Kevin, On 9/1/22 16:37, Kevin Tian wrote: > Implement amba's own vfio_device_ops. > > Remove vfio_platform_probe/remove_common() given no user now. > > Signed-off-by: Kevin Tian > Reviewed-by: Jason Gunthorpe > --- > drivers/vfio/platform/vfio_amba.c | 72 ++- >

Re: [PATCH v2 01/15] vfio: Add helpers for unifying vfio_device life cycle

2022-09-07 Thread Eric Auger
Hi Kevin, On 9/1/22 16:37, Kevin Tian wrote: > The idea is to let vfio core manage the vfio_device life cycle instead > of duplicating the logic cross drivers. This is also a preparatory > step for adding struct device into vfio_device. > > New pair of helpers together with a kref in vfio_device:

Re: [PATCH v2 11/15] vfio/platform: Use the new device life cycle helpers

2022-09-07 Thread Eric Auger
Hi kevin, On 9/1/22 16:37, Kevin Tian wrote: > Move vfio_device_ops from platform core to platform drivers so device > specific init/cleanup can be added. > > Introduce two new helpers vfio_platform_init/release_common() for the > use in driver @init/@release. > >

Re: [Freedreno] [PATCH v2 3/5] drm/msm/hdmi: move resource allocation to probe function

2022-09-07 Thread Abhinav Kumar
On 9/7/2022 12:09 PM, Abhinav Kumar wrote: On 9/7/2022 11:54 AM, Abhinav Kumar wrote: On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote: Rather than having all resource allocation happen in the _bind function (resulting in possible EPROBE_DEFER returns and component bind/unbind cycles)

Re: build failure of next-20220906 due to 396369d67549 ("drm: vkms: Add support to the RGB565 format")

2022-09-07 Thread Melissa Wen
On 09/07, Sudip Mukherjee wrote: > Hi Melissa, > > On Wed, Sep 7, 2022 at 6:05 PM Melissa Wen wrote: > > > > On 09/06, Sudip Mukherjee wrote: > > > On Tue, Sep 6, 2022 at 4:59 PM Sudip Mukherjee (Codethink) > > > wrote: > > > > > > > > Hi All, > > > > > > > > The builds of next-20220906 fails

Re: [Freedreno] [PATCH v2 3/5] drm/msm/hdmi: move resource allocation to probe function

2022-09-07 Thread Abhinav Kumar
On 9/7/2022 11:54 AM, Abhinav Kumar wrote: On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote: Rather than having all resource allocation happen in the _bind function (resulting in possible EPROBE_DEFER returns and component bind/unbind cycles) allocate and check all resources in _probe

Re: [PATCH v2 5/5] drm/msm/hdmi: move msm_hdmi_get_phy() to msm_hdmi_dev_probe()

2022-09-07 Thread Abhinav Kumar
On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote: To continue the idea of failing the probe() rather than failing the bind(), move the call to msm_hdmi_get_phy() function to msm_hdmi_dev_probe(), so that the driver fails the probe if PHY is not yet available rather than succeeding the probe and

Re: [PATCH v2 3/5] drm/msm/hdmi: move resource allocation to probe function

2022-09-07 Thread Abhinav Kumar
On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote: Rather than having all resource allocation happen in the _bind function (resulting in possible EPROBE_DEFER returns and component bind/unbind cycles) allocate and check all resources in _probe function. While we are at it, use platform_get_irq()

Re: build failure of next-20220906 due to 396369d67549 ("drm: vkms: Add support to the RGB565 format")

2022-09-07 Thread Sudip Mukherjee
Hi Melissa, On Wed, Sep 7, 2022 at 6:05 PM Melissa Wen wrote: > > On 09/06, Sudip Mukherjee wrote: > > On Tue, Sep 6, 2022 at 4:59 PM Sudip Mukherjee (Codethink) > > wrote: > > > > > > Hi All, > > > > > > The builds of next-20220906 fails for mips, xtensa and arm allmodconfig. > > > > > > The

Re: [PATCH] drm/dp_mst: Avoid deleting payloads for connectors staying enabled

2022-09-07 Thread Lyude Paul
Surprised this didn't come up on Intel's CI (or at least it certainly didn't when the series that introduced this was tested), thanks for the catch! Reviewed-by: Lyude Paul On Wed, 2022-09-07 at 17:25 +0300, Imre Deak wrote: > When an MST connector stays enabled during a commit the connector's

Re: [PATCH v6 17/57] dyndbg: validate class FOO by checking with module

2022-09-07 Thread Jason Baron
On 9/4/22 17:40, Jim Cromie wrote: > Add module-to-class validation: > > #> echo class DRM_UT_KMS +p > /proc/dynamic_debug/control > > If a query has "class FOO", then ddebug_find_valid_class(), called > from ddebug_change(), requires that FOO is known to module X, > otherwize the query is

Re: [PATCH] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-07 Thread Abhinav Kumar
On 9/7/2022 10:21 AM, Kuogee Hsieh wrote: DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an upstream device disconnect. This patch will enforce this rule by always cleared DOWNPREAD_CTRL register to 0 before start link training. At rare case that DP MSA timing parameters

Re: [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-07 Thread Manivannan Sadhasivam
On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > Johan Hovold has reported that returning a probe deferral from the > msm_dp_modeset_init() can cause issues because the IRQ is not freed > properly. This (compile-tested only) series tries to fix the issue by > moving

[PATCH] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-07 Thread Kuogee Hsieh
DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an upstream device disconnect. This patch will enforce this rule by always cleared DOWNPREAD_CTRL register to 0 before start link training. At rare case that DP MSA timing parameters may be mis-interpreted by the sinker which

Re: [PATCH v2] drm/fb-helper: add virtual screen size check to drm_fb_helper_check_var()

2022-09-07 Thread Alexey Khoroshilov
On 06.09.2022 22:54, Daniel Vetter wrote: > On Thu, Aug 11, 2022 at 11:59:00PM +0300, Alexey Khoroshilov wrote: >> For v2 I would suggest to update description to something like this: >> >> Make sure that virtual screen size is not less than physical screen one. >> >> and comment to: >> /*

Re: [PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed

2022-09-07 Thread José Expósito
Hi Michał, On Mon, Sep 05, 2022 at 08:47:11PM +0200, Michał Winiarski wrote: > When built for UML, KUnit provides virtio/PCI, which means that the > DMA/IOMEM UML emulation needed by DRM is already present and does not > need to be manually added with --kconfig_add. > > References: commit

Re: build failure of next-20220906 due to 396369d67549 ("drm: vkms: Add support to the RGB565 format")

2022-09-07 Thread Melissa Wen
On 09/06, Sudip Mukherjee wrote: > On Tue, Sep 6, 2022 at 4:59 PM Sudip Mukherjee (Codethink) > wrote: > > > > Hi All, > > > > The builds of next-20220906 fails for mips, xtensa and arm allmodconfig. > > > > The errors in mips and xtensa are: > > > > ERROR: modpost: "__divdi3"

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Dan Williams
Christoph Hellwig wrote: > On Wed, Sep 07, 2022 at 09:33:11AM -0300, Jason Gunthorpe wrote: > > Yes, you said that, and I said that when the AMD driver first merged > > it - but it went in anyhow and now people are using it in a bunch of > > places. > > drm folks made up their own weird rules, if

Re: [PATCH 01/12] drm/udl: Restore display mode on resume

2022-09-07 Thread Daniel Vetter
On Wed, Sep 07, 2022 at 07:51:05AM +0200, Takashi Iwai wrote: > On Tue, 06 Sep 2022 22:06:55 +0200, > Daniel Vetter wrote: > > > > On Tue, Aug 16, 2022 at 05:36:44PM +0200, Takashi Iwai wrote: > > > From: Thomas Zimmermann > > > > > > Restore the display mode whne resuming from suspend.

Re: [PATCH v6 1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-09-07 Thread Daniel Vetter
On Wed, Sep 07, 2022 at 08:45:22AM +0200, Christian König wrote: > Am 06.09.22 um 21:58 schrieb Daniel Vetter: > > On Tue, Aug 16, 2022 at 10:33:16AM +0530, Arunpravin Paneer Selvam wrote: > > > > > > On 8/15/2022 4:35 PM, Christian König wrote: > > > > Am 12.08.22 um 15:30 schrieb Arunpravin

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/uc: Enable version reduced firmware files for newest platforms

2022-09-07 Thread Ceraolo Spurio, Daniele
On 9/6/2022 1:29 PM, Ceraolo Spurio, Daniele wrote: On 8/26/2022 6:17 PM, john.c.harri...@intel.com wrote: From: John Harrison Going forwards, the intention is for GuC firmware files to be named for their major version only and HuC firmware files to have no version number in the name at

Re: [PATCH v2 1/3] dma-buf: Add ioctl to query mmap coherency/cache info

2022-09-07 Thread Daniel Vetter
On Thu, Aug 18, 2022 at 08:01:53AM -0700, Rob Clark wrote: > On Thu, Aug 18, 2022 at 7:54 AM Christian König > wrote: > > > > Am 18.08.22 um 16:25 schrieb Rob Clark: > > > On Thu, Aug 18, 2022 at 4:21 AM Christian König > > > wrote: > > >> Am 17.08.22 um 15:44 schrieb Rob Clark: > > >>> On Wed,

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Jason Gunthorpe
On Wed, Sep 07, 2022 at 05:31:14PM +0100, Robin Murphy wrote: > The only trouble is that it's not geared for *PCI* P2P when that may or may > not happen entirely upstream of IOMMU translation. This is why PCI users have to call the pci_distance stuff before using dma_map_resource(), it ensures

Re: [PATCH v2 00/41] drm: Analog TV Improvements

2022-09-07 Thread Noralf Trønnes
Den 07.09.2022 12.36, skrev Stefan Wahren: > Hi Maxime, > > Am 05.09.22 um 16:57 schrieb Maxime Ripard: >> On Fri, Sep 02, 2022 at 01:28:16PM +0200, Noralf Trønnes wrote: >>> >>> Den 01.09.2022 21.35, skrev Noralf Trønnes: I have finally found a workaround for my kernel hangs.

Re: [PATCH v2 1/3] dma-buf: Add ioctl to query mmap coherency/cache info

2022-09-07 Thread Daniel Vetter
On Tue, Aug 16, 2022 at 06:50:54PM +0200, Christian König wrote: > Am 16.08.22 um 16:26 schrieb Rob Clark: > > On Tue, Aug 16, 2022 at 1:27 AM Christian König > > wrote: > > > Am 15.08.22 um 23:15 schrieb Rob Clark: > > > > From: Rob Clark > > > > > > > > This is a fairly narrowly focused

Re: [PATCH] drm/udl: Enable damage clipping

2022-09-07 Thread Daniel Vetter
On Wed, Sep 07, 2022 at 08:59:17AM +0200, Thomas Zimmermann wrote: > Hi > > Am 06.09.22 um 21:35 schrieb Daniel Vetter: > > On Thu, Jul 28, 2022 at 09:47:56AM +0200, Thomas Zimmermann wrote: > > > Call drm_plane_enable_fb_damage_clips() and give userspace a chance > > > of minimizing the updated

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Robin Murphy
On 2022-09-07 16:23, Jason Gunthorpe wrote: On Wed, Sep 07, 2022 at 07:29:58AM -0700, Christoph Hellwig wrote: On Wed, Sep 07, 2022 at 09:33:11AM -0300, Jason Gunthorpe wrote: Yes, you said that, and I said that when the AMD driver first merged it - but it went in anyhow and now people are

Re: [PATCH v2 1/4] drm/sched: Enable signaling for finished fence

2022-09-07 Thread Andrey Grodzovsky
On 2022-09-07 02:37, Christian König wrote: Am 06.09.22 um 21:55 schrieb Andrey Grodzovsky: On 2022-09-06 02:34, Christian König wrote: Am 05.09.22 um 18:34 schrieb Arvind Yadav: Here's enabling software signaling for finished fence. Signed-off-by: Arvind Yadav --- Changes in v1 : 1-

Re: [PATCH v3 11/14] drm/i915/mtl: Add gsi_offset when emitting aux table invalidation

2022-09-07 Thread Iddamsetty, Aravind
On 07-09-2022 05:19, Matt Roper wrote: > The aux table invalidation registers are a bit unique --- they're > engine-centric registers that reside in the GSI register space rather > than within the engines' regular MMIO ranges. That means that when > issuing invalidation on engines in the

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

2022-09-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216455 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Jason Gunthorpe
On Wed, Sep 07, 2022 at 08:32:23AM -0700, Christoph Hellwig wrote: > On Wed, Sep 07, 2022 at 12:23:28PM -0300, Jason Gunthorpe wrote: > > 2) DMABUF abuses dma_map_resource() for P2P and thus doesn't work in > > certain special cases. > > Not just certain special cases, but one of the main

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

2022-09-07 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216455 --- Comment #4 from Gustaw Smolarczyk (wielkie...@gmail.com) --- Yes, it does. LTR+ is no longer being enabled with this patch. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee

Re: [PATCH v2] drm/sced: Add FIFO sched policy to rq

2022-09-07 Thread Andrey Grodzovsky
Luben, just a ping, whenever you have time. Andrey On 2022-09-05 01:57, Christian König wrote: Am 03.09.22 um 04:48 schrieb Andrey Grodzovsky: Poblem: Given many entities competing for same rq on same scheduler an uncceptabliy long wait time for some jobs waiting stuck in rq before being

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Jason Gunthorpe
On Wed, Sep 07, 2022 at 07:29:58AM -0700, Christoph Hellwig wrote: > On Wed, Sep 07, 2022 at 09:33:11AM -0300, Jason Gunthorpe wrote: > > Yes, you said that, and I said that when the AMD driver first merged > > it - but it went in anyhow and now people are using it in a bunch of > > places. > >

Re: Re: [PATCH v2 36/41] drm/sun4i: tv: Merge mode_set into atomic_enable

2022-09-07 Thread Jernej Škrabec
Dne sreda, 07. september 2022 ob 09:41:34 CEST je Maxime Ripard napisal(a): > On Tue, Sep 06, 2022 at 10:04:32PM +0200, Jernej Škrabec wrote: > > Dne ponedeljek, 29. avgust 2022 ob 15:11:50 CEST je Maxime Ripard napisal(a): > > > Our mode_set implementation can be merged into our atomic_enable >

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Christian König
Am 07.09.22 um 14:03 schrieb Christoph Hellwig: On Tue, Sep 06, 2022 at 12:38:44PM +0200, Christian König wrote: The problem is once more that this is MMIO space, in other words register BARs which needs to be exported/imported. Everything used for P2P is bar space. Adding struct pages for

Re: [PATCH v6 00/57] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-09-07 Thread Greg KH
On Sun, Sep 04, 2022 at 03:40:37PM -0600, Jim Cromie wrote: > hi Greg, Jason, DRM-folk, Steven, > > If Im not too late for linux-next in this cycle, heres V6. Diffs are minor: > > - rebased onto e47eb90a0a9a (tag: next-20220901, linux-next/master) >gets past Kconfig conflict, same for

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Robin Murphy
On 2022-09-07 13:33, Jason Gunthorpe wrote: On Wed, Sep 07, 2022 at 05:05:57AM -0700, Christoph Hellwig wrote: On Tue, Sep 06, 2022 at 08:48:28AM -0300, Jason Gunthorpe wrote: Right, this whole thing is the "standard" that dmabuf has adopted instead of the struct pages. Once the AMD GPU driver

Re: [PATCH v6 21/57] dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes

2022-09-07 Thread Greg KH
On Wed, Sep 07, 2022 at 04:54:00PM +0200, Greg KH wrote: > On Sun, Sep 04, 2022 at 03:40:58PM -0600, Jim Cromie wrote: > > Demonstrate use of DECLARE_DYNDBG_CLASSMAP macro, and expose them as > > sysfs-nodes for testing. > > Wait, why sysfs? > > sysfs isn't for testing, why not use debugfs? > >

Re: [PATCH] drm/amdgpu: fix repeated words in comments

2022-09-07 Thread Alex Deucher
On Wed, Sep 7, 2022 at 10:50 AM Robin Murphy wrote: > > On 2022-09-07 12:26, Jilin Yuan wrote: > > Delete the redundant word 'we'. > > FWIW, to me it's not redundant because while indeed it is not correct, > it looks exactly like the kind of typo I might make of "if we", and > parsing it as

Re: [PATCH] drm/amdgpu: fix repeated words in comments

2022-09-07 Thread Robin Murphy
On 2022-09-07 12:34, Jilin Yuan wrote: Delete the redundant word 'and'. Delete the redundant word 'in'. Delete the redundant word 'the'. Delete the redundant word 'are'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH v6 21/57] dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes

2022-09-07 Thread Greg KH
On Sun, Sep 04, 2022 at 03:40:58PM -0600, Jim Cromie wrote: > Demonstrate use of DECLARE_DYNDBG_CLASSMAP macro, and expose them as > sysfs-nodes for testing. Wait, why sysfs? sysfs isn't for testing, why not use debugfs? > > For each of the 4 class-map-types: > > - declare a class-map of

Re: [PATCH] drm/amdgpu: fix repeated words in comments

2022-09-07 Thread Robin Murphy
On 2022-09-07 12:26, Jilin Yuan wrote: Delete the redundant word 'we'. FWIW, to me it's not redundant because while indeed it is not correct, it looks exactly like the kind of typo I might make of "if we", and parsing it as *that* does make sense. The sentence you end up with here can

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-07 Thread Oded Gabbay
On Wed, Sep 7, 2022 at 5:30 PM Christoph Hellwig wrote: > > On Wed, Sep 07, 2022 at 09:33:11AM -0300, Jason Gunthorpe wrote: > > Yes, you said that, and I said that when the AMD driver first merged > > it - but it went in anyhow and now people are using it in a bunch of > > places. > > drm folks

Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-07 Thread Maxime Ripard
On Mon, Sep 05, 2022 at 06:32:14PM +0200, Mateusz Kwiatkowski wrote: > Hi Maxime, > > W dniu 5.09.2022 o 15:32, Maxime Ripard pisze: > > Hi, > > > > On Wed, Aug 31, 2022 at 10:14:28AM +0200, Geert Uytterhoeven wrote: > +enum drm_mode_analog { > +    DRM_MODE_ANALOG_NTSC, > +   

  1   2   >