[PATCH] drm/etnaviv: add sensitive state for PE_RT_ADDR_4_PIPE(3, 0|1) address

2023-12-06 Thread Christian Gmeiner
From: Christian Gmeiner 0x1540 is the address of 4th render target address pair (two pixel pipes). Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/etnaviv/etnaviv_cmd_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_cmd_parser.c

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread Tony Lindgren
* Andreas Kemnade [231205 09:43]: > On Tue, 5 Dec 2023 10:27:56 +0100 > Krzysztof Kozlowski wrote: > > > On 05/12/2023 10:02, Andreas Kemnade wrote: > > > On Tue, 5 Dec 2023 09:45:44 +0100 > > > Krzysztof Kozlowski wrote: > > > > > >>> Sure the clock nodes can be there for the child IP, but

[PATCH] drm/panel: re-alphabetize the menu list

2023-12-06 Thread Randy Dunlap
A few of the DRM_PANEL entries have become out of alphabetical order, so move them around a bit to restore alpha order. Signed-off-by: Randy Dunlap Cc: Neil Armstrong Cc: Jessica Zhang Cc: Sam Ravnborg Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc:

Re: [PATCH v4 06/10] drm/panel: Add Synaptics R63353 panel driver

2023-12-06 Thread Dan Carpenter
/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20231205105341.4100896-7-dario.binacchi%40amarulasolutions.com patch subject: [PATCH v4 06/10] drm/panel: Add Synaptics R63353 panel driver config: i386-randconfig-r071-20231206 (https://download.01.org/0day-ci/archive/20231207

RE: [PATCH v6 3/5] mm/gup: Introduce memfd_pin_user_pages() for pinning memfd pages (v6)

2023-12-06 Thread Kasireddy, Vivek
Hi David, > On 05.12.23 06:35, Vivek Kasireddy wrote: > > For drivers that would like to longterm-pin the pages associated > > with a memfd, the pin_user_pages_fd() API provides an option to > > not only pin the pages via FOLL_PIN but also to check and migrate > > them if they reside in movable

RE: [PATCH v6 3/5] mm/gup: Introduce memfd_pin_user_pages() for pinning memfd pages (v6)

2023-12-06 Thread Kasireddy, Vivek
Hi, > > +struct page *memfd_alloc_page(struct file *memfd, pgoff_t idx) > > +{ > > +#ifdef CONFIG_HUGETLB_PAGE > > + struct folio *folio; > > + int err; > > + > > + if (is_file_hugepages(memfd)) { > > + folio = alloc_hugetlb_folio_nodemask(hstate_file(memfd), > > +

[GIT PULL RESEND] exynos-drm-fixes

2023-12-06 Thread Inki Dae
Hi Dave and Daniel, Just resending you the previous pull request[1] after resolving the build warning. [1] https://lore.kernel.org/dri-devel/20231120225537.1270358-1-inki@samsung.com/ Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes

Re: [PATCH v1 1/2] dt-bindings: display: panel: raspberrypi: Add compatible property for waveshare 7inch touchscreen panel

2023-12-06 Thread Shengyang Chen
Hi, Conor thanks for comment On 2023/12/6 23:40, Conor Dooley wrote: > On Wed, Dec 06, 2023 at 05:43:48PM +0800, Shengyang Chen wrote: >> Hi, Conor >> >> On 2023/11/24 20:31, Conor Dooley wrote: >> > On Fri, Nov 24, 2023 at 06:44:50PM +0800, Shengyang Chen wrote: >> >> The waveshare 7inch

RE: [PATCH RESEND] drm/exynos: dpi: Change connector type to DPI

2023-12-06 Thread SR
Hi Paul, > -Original Message- > From: Paul Cercueil > Sent: Thursday, December 7, 2023 7:19 AM > To: Inki Dae ; Seung-Woo Kim > ; Kyungmin Park ; > Krzysztof Kozlowski ; Alim Akhtar > > Cc: David Airlie ; Daniel Vetter ; > dri-devel@lists.freedesktop.org;

RE: [PATCH v3 08/16] drm/exynos: Convert to platform remove callback returning void

2023-12-06 Thread SR
Hello Uwe Kleine-König, > -Original Message- > From: Uwe Kleine-König > Sent: Wednesday, November 29, 2023 1:55 AM > To: Inki Dae > Cc: linux-samsung-...@vger.kernel.org; Daniel Vetter ; > Jingoo Han ; Seung-Woo Kim ; > Kyungmin Park ; DRI mailing list de...@lists.freedesktop.org>;

Re: [PATCH v1 0/2] Add waveshare 7inch touchscreen panel support

2023-12-06 Thread Keith Zhao
On 2023/12/6 22:56, Dave Stevenson wrote: > Hi Keith > > On Wed, 6 Dec 2023 at 08:55, Keith Zhao wrote: >> >> >> >> On 2023/11/25 0:04, Dave Stevenson wrote: >> > On Fri, 24 Nov 2023 at 15:00, Stefan Wahren wrote: >> >> >> >> Hi Shengyang, >> >> >> >> [fix address of Emma] >> > >> > Not

Re: [PATCH 15/16] drm/msm/dpu: add NV12 in the list of supported WB formats

2023-12-06 Thread Abhinav Kumar
On 8/30/2023 5:26 PM, Dmitry Baryshkov wrote: On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar wrote: Since CDM block support has now been added for writeback blocks add NV12 in the list of supported WB formats. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

Re: [PATCH] media: medkatek: vcodec: support tee decoder

2023-12-06 Thread kernel test robot
Hi Yunfei, kernel test robot noticed the following build errors: [auto build test ERROR on media-tree/master] [also build test ERROR on linus/master v6.7-rc4 next-20231206] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH] media: medkatek: vcodec: support tee decoder

2023-12-06 Thread kernel test robot
Hi Yunfei, kernel test robot noticed the following build errors: [auto build test ERROR on media-tree/master] [also build test ERROR on linus/master v6.7-rc4 next-20231206] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH 07/16] drm/msm/dpu: add cdm blocks to RM

2023-12-06 Thread Dmitry Baryshkov
On Wed, 6 Dec 2023 at 23:02, Abhinav Kumar wrote: > > > > On 11/30/2023 3:47 PM, Abhinav Kumar wrote: > > > > > > On 8/30/2023 4:48 PM, Dmitry Baryshkov wrote: > >> On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar > >> wrote: > >>> > >>> Add the RM APIs necessary to initialize and allocate CDM > >>>

[PATCH RESEND] drm/exynos: dpi: Change connector type to DPI

2023-12-06 Thread Paul Cercueil
When exynos_drm_dpi.c was written, DRM_MODE_CONNECTOR_DPI did not exist yet and I guess that's the reason why DRM_MODE_CONNECTOR_VGA was used as the connector type. However, now it makes more sense to use DRM_MODE_CONNECTOR_DPI as the connector type. Signed-off-by: Paul Cercueil ---

[pull] amdgpu drm-fixes-6.7

2023-12-06 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.7. The following changes since commit 33924328498e903bea74727353e5012d29653aff: Merge tag 'drm-intel-fixes-2023-12-01-1' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2023-12-05 12:19:22 +1000) are available in the Git repository at:

Re: [PATCH v2] dt-bindings: display: adi,adv75xx: Document #sound-dai-cells

2023-12-06 Thread Rob Herring
On Wed, 06 Dec 2023 06:36:43 -0300, Fabio Estevam wrote: > From: Fabio Estevam > > When using audio from ADV7533 or ADV7535 and describing the audio > card via simple-audio-card, the '#sound-dai-cells' needs to be passed. > > Document the '#sound-dai-cells' property to fix the following >

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread H . Nikolaus Schaller
(non-html) > Am 06.12.2023 um 17:15 schrieb Andrew Davis : > > On 12/6/23 10:02 AM, Conor Dooley wrote: >> On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: Am 05.12.2023 um 18:33 schrieb Andrew Davis : On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: >> +

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread H. Nikolaus Schaller
> Am 06.12.2023 um 17:15 schrieb Andrew Davis : > > On 12/6/23 10:02 AM, Conor Dooley wrote: >> On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: Am 05.12.2023 um 18:33 schrieb Andrew Davis : On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: >> + -

[Bug Report] drm/edid: drm_edid_override_connector_update returns a incorrect value

2023-12-06 Thread bbaa
Hello everyone, drm_edid_override_connector_update seem return a incorrect value. drivers/gpu/drm/drm_edid.c (Linux 6.7-rc4) 2294 /** 2295 * drm_edid_override_connector_update - add modes from override/firmware EDID 2296 * @connector: connector we're probing 2297 * 2298 *

[Bug Report] drm/edid: drm_edid_override_connector_update returns a incorrect value

2023-12-06 Thread bbaa
Hello everyone, drm_edid_override_connector_update seem return a incorrect value. drivers/gpu/drm/drm_edid.c (Linux 6.7-rc4) 2294 /** 2295 * drm_edid_override_connector_update - add modes from override/firmware EDID 2296 * @connector: connector we're probing 2297 * 2298 *

[PATCH] drm: Fix FD ownership check in drm_master_check_perm()

2023-12-06 Thread Lingkai Dong
The DRM subsystem keeps a record of the owner of a DRM device file descriptor using thread group ID (TGID) instead of process ID (PID), to ensures all threads within the same userspace process are considered the owner. However, the DRM master ownership check compares the current thread's PID

Re: [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts

2023-12-06 Thread Rob Herring
On Wed, 06 Dec 2023 08:23:37 -0300, Fabio Estevam wrote: > From: Fabio Estevam > > i.MX23 has two LCDIF interrupts instead of a single one like other > i.MX devices. > > Take this into account for properly describing the i.MX23 LCDIF > interrupts. > > This fixes the following dt-schema

Re: [PATCH v7 2/2] drm/i915/guc: Close deregister-context race against CT-loss

2023-12-06 Thread Daniele Ceraolo Spurio
On 11/30/2023 4:10 PM, Teres Alexis, Alan Previn wrote: As far as i can tell, its only if we started resetting / wedging right after this queued worker got started. alan: hope Daniele can proof read my tracing and confirm if got it right. Yup, we don't flush the worker in reset prepare,

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread H. Nikolaus Schaller
> Am 06.12.2023 um 17:02 schrieb Conor Dooley : > > On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: >>> Am 05.12.2023 um 18:33 schrieb Andrew Davis : >>> >>> On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: > + - enum: > + - ti,omap3430-gpu #

Proposal to add CRIU support to DRM render nodes

2023-12-06 Thread Felix Kuehling
Executive Summary: We need to add CRIU support to DRM render nodes in order to maintain CRIU support for ROCm application once they start relying on render nodes for more GPU memory management. In this email I'm providing some background why we are doing this, and outlining some of the

[PATCH RESEND AGAIN v2 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm

2023-12-06 Thread Andi Shyti
From: Nirmoy Das Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause dmesg spamming. Use ratelimit api to reduce log rate. References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038 Signed-off-by: Nirmoy Das Cc: Matthew Auld Reviewed-by: Matthew Auld Reviewed-by:

[PATCH RESEND AGAIN v2 1/2] drm/print: Add drm_dbg_ratelimited

2023-12-06 Thread Andi Shyti
From: Nirmoy Das Add a function for ratelimitted debug print. Signed-off-by: Nirmoy Das Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Matthew Auld Reviewed-by: Andrzej Hajda Reviewed-by: Andi Shyti Reviewed-by: Sam

[PATCH RESEND AGAIN v2 0/2] Add drm_dbg_ratelimited()

2023-12-06 Thread Andi Shyti
Hi, This is the second time I am resending this series in its v2. It has been reviewd, acked, blessed, discussed, rectified, assessed, authorized, validated, glorified, praised, demanded, approved, and yet, I don't understand why no one is merging it. Thanks, Andi v2: pick the right patch with

Re: [PATCH 07/16] drm/msm/dpu: add cdm blocks to RM

2023-12-06 Thread Abhinav Kumar
On 11/30/2023 3:47 PM, Abhinav Kumar wrote: On 8/30/2023 4:48 PM, Dmitry Baryshkov wrote: On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar wrote: Add the RM APIs necessary to initialize and allocate CDM blocks by the rest of the DPU pipeline. ... to be used by the rest? Yes, thanks.

[PATCH v3 4/4] drm/i915/guc: Use the ce_to_guc() wrapper whenever possible

2023-12-06 Thread Andi Shyti
Get the guc reference from the ce using the ce_to_guc() helper. Just a leftover from previous cleanups. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 3/4] drm/i915: Use the new gt_to_guc() wrapper

2023-12-06 Thread Andi Shyti
Get the guc reference from the gt using the gt_to_guc() helper. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/i915_debugfs_params.c | 2 +- drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v3 2/4] drm/i915/guc: Use the new gt_to_guc() wrapper

2023-12-06 Thread Andi Shyti
Get the guc reference from the gt using the gt_to_guc() helper. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 4 +-- drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 3 +- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c| 2 +-

[PATCH v3 0/4] Add gt_to_guc() helper

2023-12-06 Thread Andi Shyti
Hi, this is just a resend of this series: https://patchwork.freedesktop.org/series/125583/ but I removed patch one that introduces guc_to_i915() Thanks, Andi Changelog: == v2 -> v3: - Remove patch 1 that contained guc_to_i915() v1 -> v2: - add the gt_to_guc() helper and change files

[PATCH v3 1/4] drm/i915/gt: Create the gt_to_guc() wrapper

2023-12-06 Thread Andi Shyti
We already have guc_to_gt() and getting to guc from the GT it requires some mental effort. Add the gt_to_guc(). Given the reference to the "gt", the gt_to_guc() will return the pinter to the "guc". Update all the files under the gt/ directory. Signed-off-by: Andi Shyti ---

[PATCH] [v2] drm/i915/display: Check GGTT to determine phys_base

2023-12-06 Thread Paz Zcharya
There was an assumption that for iGPU there should be a 1:1 mapping of GGTT to physical address pointing to the framebuffer. This assumption is not strictly true effective generation 8 or newer. Fix that by checking GGTT to determine the phys address on gen8+. The following algorithm for

[PATCH v3] drm/i915/guc: Create the guc_to_i915() wrapper

2023-12-06 Thread Andi Shyti
Given a reference to "guc", the guc_to_i915() returns the pointer to "i915" private data. Signed-off-by: Andi Shyti Reviewed-by: Nirmoy Das --- Hi, This is almost a resend of the previous patch (check changelog). I have taken this one out from the series as this has been reviewed already.

[PATCH v2] backlight: ili922x: drop kernel-doc for local macros

2023-12-06 Thread Randy Dunlap
Don't use kernel-doc notation for the local macros START_BYTE() and CHECK_FREQ_REG(). This prevents these kernel-doc warnings: ili922x.c:85: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * START_BYTE(id, rs, rw)

Re: [PATCH 12/18] dt-bindings: pwm: add binding for mt8365 SoC

2023-12-06 Thread Uwe Kleine-König
Hello, On Mon, Oct 23, 2023 at 11:44:11PM +0200, Uwe Kleine-König wrote: > On Mon, Oct 23, 2023 at 04:40:12PM +0200, Alexandre Mergnat wrote: > > Display PWM for MT8365 is compatible with MT8183. Then, add MT8365 binding > > along with MT8183 SoC. > > > > Signed-off-by: Alexandre Mergnat > >

Re: [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-06 Thread Abhinav Kumar
On 12/5/2023 7:51 PM, Bjorn Andersson wrote: On Mon, Dec 04, 2023 at 11:22:24AM -0800, Abhinav Kumar wrote: On 12/3/2023 7:31 PM, Bjorn Andersson wrote: On Fri, Dec 01, 2023 at 11:43:36AM -0800, Abhinav Kumar wrote: On 12/1/2023 8:22 AM, Bjorn Andersson wrote: On Fri, Dec 01, 2023 at

Re: [PATCH 1/5] drm/msm/adreno: Split up giant device table

2023-12-06 Thread Rob Clark
On Wed, Dec 6, 2023 at 4:29 AM Konrad Dybcio wrote: > > > > On 12/5/23 23:03, Rob Clark wrote: > > From: Rob Clark > > > > Split into a separate table per generation, in preparation to move each > > gen's device table to it's own file. > > > > Signed-off-by: Rob Clark > > --- > >

Re: [PATCH v3 03/14] drm/panthor: Add the device logical block

2023-12-06 Thread Steven Price
On 04/12/2023 17:32, Boris Brezillon wrote: > The panthor driver is designed in a modular way, where each logical > block is dealing with a specific HW-block or software feature. In order > for those blocks to communicate with each other, we need a central > panthor_device collecting all the

Re: [PATCH] drm/tests: Switch to kunit devices

2023-12-06 Thread kernel test robot
/20231205090405.153140-1-mripard%40kernel.org patch subject: [PATCH] drm/tests: Switch to kunit devices config: i386-randconfig-012-20231206 (https://download.01.org/0day-ci/archive/20231207/202312070010.hafmuyfe-...@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1

Re: [PATCH] backlight: ili922x: fix W=1 kernel-doc warnings

2023-12-06 Thread Randy Dunlap
On 12/6/23 05:25, Lee Jones wrote: > On Wed, 06 Dec 2023, Daniel Thompson wrote: > >> On Tue, Dec 05, 2023 at 02:56:38PM -0800, Randy Dunlap wrote: >>> Fix kernel-doc warnings found when using "W=1". >>> >>> ili922x.c:85: warning: This comment starts with '/**', but isn't a >>> kernel-doc

Re: [PATCH] drm/tests: Switch to kunit devices

2023-12-06 Thread kernel test robot
/20231205090405.153140-1-mripard%40kernel.org patch subject: [PATCH] drm/tests: Switch to kunit devices config: i386-buildonly-randconfig-004-20231206 (https://download.01.org/0day-ci/archive/20231207/202312070011.fdjyhkoz-...@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm

Re: [PATCH v3 00/14] drm: Add a driver for CSF-based Mali GPUs

2023-12-06 Thread Boris Brezillon
Hi Steve, On Wed, 6 Dec 2023 15:47:29 + Steven Price wrote: > On 05/12/2023 08:48, Boris Brezillon wrote: > > Hi Steve, > > > > I forgot to mention that I intentionally dropped your R-b, because > > there was a gazillion of changes all over the place, and I thought it > > deserved a fresh

Re: [PATCH v3 02/14] drm/panthor: Add GPU register definitions

2023-12-06 Thread Steven Price
On 04/12/2023 17:32, Boris Brezillon wrote: > Those are the registers directly accessible through the MMIO range. > > FW registers are exposed in panthor_fw.h. > > v3: > - Add macros to extract GPU ID info > - Formatting changes > - Remove AS_TRANSCFG_ADRMODE_LEGACY - it doesn't exist post-CSF >

Re: [PATCH v3 01/14] drm/panthor: Add uAPI

2023-12-06 Thread Steven Price
On 04/12/2023 17:32, Boris Brezillon wrote: > Panthor follows the lead of other recently submitted drivers with > ioctls allowing us to support modern Vulkan features, like sparse memory > binding: > > - Pretty standard GEM management ioctls (BO_CREATE and BO_MMAP_OFFSET), > with the

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread Andrew Davis
On 12/6/23 10:02 AM, Conor Dooley wrote: On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: Am 05.12.2023 um 18:33 schrieb Andrew Davis : On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: + - enum: + - ti,omap3430-gpu # Rev 121 + -

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread Conor Dooley
On Tue, Dec 05, 2023 at 07:04:05PM +0100, H. Nikolaus Schaller wrote: > > Am 05.12.2023 um 18:33 schrieb Andrew Davis : > > > > On 12/5/23 2:17 AM, H. Nikolaus Schaller wrote: > >>> + - enum: > >>> + - ti,omap3430-gpu # Rev 121 > >>> + - ti,omap3630-gpu # Rev

Re: [PATCH RESEND v2 1/3] drm/encoder: register per-encoder debugfs dir

2023-12-06 Thread Maxime Ripard
Hi Mark, On Tue, Dec 05, 2023 at 04:13:41PM +, Mark Brown wrote: > On Sun, Dec 03, 2023 at 02:53:13PM +0300, Dmitry Baryshkov wrote: > > > Each of connectors and CRTCs used by the DRM device provides debugfs > > directory, which is used by several standard debugfs files and can > > further

Re: [PATCH] drm/bridge: nxp-ptn3460: simplify some error checking

2023-12-06 Thread Robert Foss
On Wed, 6 Dec 2023 18:05:15 +0300, Dan Carpenter wrote: > The i2c_master_send/recv() functions return negative error codes or > they return "len" on success. So the error handling here can be written > as just normal checks for "if (ret < 0) return ret;". No need to > complicate things. > >

Re: [PATCH v3 00/14] drm: Add a driver for CSF-based Mali GPUs

2023-12-06 Thread Steven Price
On 05/12/2023 08:48, Boris Brezillon wrote: > Hi Steve, > > I forgot to mention that I intentionally dropped your R-b, because > there was a gazillion of changes all over the place, and I thought it > deserved a fresh review. No problem, I'll re-review the patches. Thanks for getting the v3 out

Re: [PATCH v1 1/2] dt-bindings: display: panel: raspberrypi: Add compatible property for waveshare 7inch touchscreen panel

2023-12-06 Thread Conor Dooley
On Wed, Dec 06, 2023 at 05:43:48PM +0800, Shengyang Chen wrote: > Hi, Conor > > On 2023/11/24 20:31, Conor Dooley wrote: > > On Fri, Nov 24, 2023 at 06:44:50PM +0800, Shengyang Chen wrote: > >> The waveshare 7inch touchscreen panel is a kind of raspberrypi pi > >> panel > > > > Can you be more

Re: [PATCH v2] dt-bindings: lcdif: Properly describe the i.MX23 interrupts

2023-12-06 Thread Conor Dooley
On Wed, Dec 06, 2023 at 08:23:37AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > i.MX23 has two LCDIF interrupts instead of a single one like other > i.MX devices. > > Take this into account for properly describing the i.MX23 LCDIF > interrupts. > > This fixes the following dt-schema

[PATCH] drm/bridge: nxp-ptn3460: simplify some error checking

2023-12-06 Thread Dan Carpenter
The i2c_master_send/recv() functions return negative error codes or they return "len" on success. So the error handling here can be written as just normal checks for "if (ret < 0) return ret;". No need to complicate things. Btw, in this code the "len" parameter can never be zero, but even if it

[PATCH] drm/debugfs: drop unneeded DEBUG_FS guard

2023-12-06 Thread Dario Binacchi
The Makefile enables/disables the file compilation depending on CONFIG_DEBUG_FS. Signed-off-by: Dario Binacchi --- drivers/gpu/drm/drm_debugfs.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index f291fb4b359f..f80d9cf3e71a

Re: [PATCH] drm/debugfs: fix potential NULL pointer dereference

2023-12-06 Thread Nishanth Menon
On 15:19-20231205, Dmitry Baryshkov wrote: > On Tue, 5 Dec 2023 at 15:06, Marek Szyprowski > wrote: > > > > encoder->funcs entry might be NULL, so check it first before calling its > > methods. This fixes NULL pointer dereference observed on Rasberry Pi > > 3b/4b boards. > > > > Fixes:

Re: [PATCH v1 0/2] Add waveshare 7inch touchscreen panel support

2023-12-06 Thread Dave Stevenson
Hi Keith On Wed, 6 Dec 2023 at 08:55, Keith Zhao wrote: > > > > On 2023/11/25 0:04, Dave Stevenson wrote: > > On Fri, 24 Nov 2023 at 15:00, Stefan Wahren wrote: > >> > >> Hi Shengyang, > >> > >> [fix address of Emma] > > > > Not merged to master yet, but Emma has stepped back from maintenance.

Re: [PATCH v3 3/9] drm/amd/display: read gamut remap matrix in fixed-point 31.32 format

2023-12-06 Thread Rodrigo Siqueira Jordao
On 11/28/23 10:52, Melissa Wen wrote: Instead of read gamut remap data from hw values, convert HW register values (S2D13) into a fixed-point 31.32 matrix for color state log. Change DCN10 log to print data in the format of the gamut remap matrix. Signed-off-by: Melissa Wen ---

Re: [PATCH v3 1/9] drm/amd/display: decouple color state from hw state log

2023-12-06 Thread Rodrigo Siqueira Jordao
On 11/28/23 10:52, Melissa Wen wrote: Prepare to hook up color state log according to the DCN version. v3: - put functions in single line (Siqueira) Signed-off-by: Melissa Wen --- .../amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 26 +-- 1 file changed, 18 insertions(+), 8

Re: [PATCH] drm/imagination: Move dereference after NULL check in pvr_mmu_backing_page_init()

2023-12-06 Thread Frank Binns
Hi Dan, Thank you for the patch. On Wed, 2023-12-06 at 17:37 +0300, Dan Carpenter wrote: > This code dereferences "page->pvr_dev" and then checked for NULL on the > next line. Re-order it to avoid a potential NULL pointer dereference. > > Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM

[PATCH] drm/imagination: Move dereference after NULL check in pvr_mmu_backing_page_init()

2023-12-06 Thread Dan Carpenter
This code dereferences "page->pvr_dev" and then checked for NULL on the next line. Re-order it to avoid a potential NULL pointer dereference. Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/imagination/pvr_mmu.c | 4 +++- 1

Re: [PATCH v4 07/10] dt-bindings: display: panel: Add Ilitek ili9805 panel controller

2023-12-06 Thread Rob Herring
On Tue, Dec 05, 2023 at 11:52:54AM +0100, Dario Binacchi wrote: > From: Michael Trimarchi > > Add documentation for "ilitek,ili9805" panel. > > Signed-off-by: Michael Trimarchi > Signed-off-by: Dario Binacchi Where's Krzysztof's Reviewed-by? Rob

Re: [PATCH v2 0/4] drm: Fix errors about uninitialized/wrong variables

2023-12-06 Thread Maxime Ripard
On Wed, Dec 06, 2023 at 02:50:57PM +0200, Tomi Valkeinen wrote: > Hi all, > > On 03/11/2023 15:14, Tomi Valkeinen wrote: > > Fix cases where smatch reports a use of an uninitialized variable, and > > one where the variable is initialized but contains wrong value. > > > > Tomi > > > >

Re: [PATCH v3 101/108] drm/bridge: ti-sn65dsi86: Make use of devm_pwmchip_alloc() function

2023-12-06 Thread Uwe Kleine-König
On Wed, Dec 06, 2023 at 02:06:11PM +0200, Laurent Pinchart wrote: > On Thu, Nov 23, 2023 at 11:10:18AM +0100, Uwe Kleine-König wrote: > > Once the series is completely applied, the pwm_chip isn't allocated > > using devm_kzalloc any more. You're only looking at an intermediate > > state where I

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-06 Thread Keith Zhao
On 2023/12/6 20:56, Maxime Ripard wrote: > On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote: >> >> +static const struct of_device_id starfive_hdmi_dt_ids[] = { >> >> + { .compatible = "starfive,jh7110-inno-hdmi",}, >> > >> > So it's inno hdmi, just like Rockchip then? >> > >> > This

Re: [PATCH v4 02/10] drm/bridge: Fix a use case in the bridge disable logic

2023-12-06 Thread Michael Nazzareno Trimarchi
Hi Jagan On Wed, Dec 6, 2023 at 2:31 PM Jagan Teki wrote: > > Hi Dario, > > On Wed, Dec 6, 2023 at 6:57 PM Dario Binacchi > wrote: > > > > Hi Dave and Jagan, > > > > On Tue, Dec 5, 2023 at 4:39 PM Dave Stevenson > > wrote: > > > > > > Hi Dario > > > > > > On Tue, 5 Dec 2023 at 10:54, Dario

[PATCH v3 0/4] fbdev: Remove global screen_info in efifb/vesafb

2023-12-06 Thread Thomas Zimmermann
Replace the global instance of screen_info with the per-device instance that is set by the sysfb code. The use of the global screen_info should be limited and ideally be pushed into per-architecture code. v3: * better const correctness in efifb (Sui) * fix build for deferred

[PATCH v3 4/4] fbdev/vesafb: Use screen_info pointer from device

2023-12-06 Thread Thomas Zimmermann
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that vesafb can modify it at will. v2: * comment on devm_kmemdup() usage (Javier) Signed-off-by: Thomas

[PATCH v3 2/4] fbdev/efifb: Use screen_info pointer from device

2023-12-06 Thread Thomas Zimmermann
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that efifb can modify it at will. v2: * comment on devm_kmemdup() usage (Javier) Signed-off-by: Thomas

[PATCH v3 3/4] fbdev/vesafb: Replace references to global screen_info by local pointer

2023-12-06 Thread Thomas Zimmermann
Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/vesafb.c | 66 +++- 1 file changed, 35 insertions(+),

[PATCH v3 1/4] fbdev/efifb: Replace references to global screen_info by local pointer

2023-12-06 Thread Thomas Zimmermann
Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. v3: * use const screen_info in several places (Sui) * fix build for deferred takeover (kernel test robot) Signed-off-by: Thomas Zimmermann Tested-by: Sui Jingfeng

Re: [PATCH v4 02/10] drm/bridge: Fix a use case in the bridge disable logic

2023-12-06 Thread Jagan Teki
Hi Dario, On Wed, Dec 6, 2023 at 6:57 PM Dario Binacchi wrote: > > Hi Dave and Jagan, > > On Tue, Dec 5, 2023 at 4:39 PM Dave Stevenson > wrote: > > > > Hi Dario > > > > On Tue, 5 Dec 2023 at 10:54, Dario Binacchi > > wrote: > > > > > > The patch fixes the code for finding the next bridge with

Re: [PATCH v4 02/10] drm/bridge: Fix a use case in the bridge disable logic

2023-12-06 Thread Dario Binacchi
Hi Dave and Jagan, On Tue, Dec 5, 2023 at 4:39 PM Dave Stevenson wrote: > > Hi Dario > > On Tue, 5 Dec 2023 at 10:54, Dario Binacchi > wrote: > > > > The patch fixes the code for finding the next bridge with the > > "pre_enable_prev_first" flag set to false. In case this condition is > > not

Re: [PATCH] backlight: ili922x: fix W=1 kernel-doc warnings

2023-12-06 Thread Lee Jones
On Wed, 06 Dec 2023, Daniel Thompson wrote: > On Tue, Dec 05, 2023 at 02:56:38PM -0800, Randy Dunlap wrote: > > Fix kernel-doc warnings found when using "W=1". > > > > ili922x.c:85: warning: This comment starts with '/**', but isn't a > > kernel-doc comment. Refer

Re: [RFC PATCH v3 05/23] drm/vkms: Avoid reading beyond LUT array

2023-12-06 Thread Melissa Wen
On 12/06, Melissa Wen wrote: > On 11/10, Arthur Grillo wrote: > > > > > > On 08/11/23 13:36, Harry Wentland wrote: > > > When the floor LUT index (drm_fixp2int(lut_index) is the last > > > index of the array the ceil LUT index will point to an entry > > > beyond the array. Make sure we guard

Re: (subset) [PATCH] drm/imagination: move update_logtype() into ifdef section

2023-12-06 Thread Maxime Ripard
On Mon, 04 Dec 2023 08:32:10 +0100, Arnd Bergmann wrote: > This function is only used when debugfs is enabled, and otherwise > causes a build warning: > > drivers/gpu/drm/imagination/pvr_fw_trace.c:135:1: error: 'update_logtype' > defined but not used [-Werror=unused-function] > > Move the

Re: (subset) [PATCH v2] drm/imagination: Removed unused functions in pvr_fw_trace

2023-12-06 Thread Maxime Ripard
On Mon, 04 Dec 2023 15:13:37 +, Donald Robson wrote: > Fixing the warning below due to an unused file level vtable. Removing > only this causes additional warnings for the now unused functions, so > I've removed those too. > > >> drivers/gpu/drm/imagination/pvr_fw_trace.c:205:37: warning: >

[bug report] drm/imagination: Implement MIPS firmware processor and MMU support

2023-12-06 Thread Dan Carpenter
Hello Sarah Walker, The patch 927f3e0253c1: "drm/imagination: Implement MIPS firmware processor and MMU support" from Nov 22, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/imagination/pvr_vm_mips.c:204 pvr_vm_mips_map() warn: 'pfn' can

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-12-06 Thread Maxime Ripard
Hi, On Wed, Dec 06, 2023 at 02:48:58PM +0200, Tomi Valkeinen wrote: > Hi mipi dsi maintainers (I'm not sure who that is =), > > On 21/09/2023 13:50, Tomi Valkeinen wrote: > > It's been reported that DSI host driver's detach can be called without > > the attach ever happening: > > > >

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-06 Thread Maxime Ripard
On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote: > >> +static const struct of_device_id starfive_hdmi_dt_ids[] = { > >> + { .compatible = "starfive,jh7110-inno-hdmi",}, > > > > So it's inno hdmi, just like Rockchip then? > > > > This should be a common driver. > > Rockchip has a inno

Re: [v3 4/6] drm/vs: Add KMS crtc

2023-12-06 Thread Keith Zhao
On 2023/12/6 16:55, Maxime Ripard wrote: > On Mon, Dec 04, 2023 at 08:33:13PM +0800, Keith Zhao wrote: >> +static const struct vs_plane_info dc_hw_planes_rev0[PLANE_NUM] = { >> +{ >> +.name = "Primary", >> +.id = PRIMARY_PLANE_0,

[bug report] drm/imagination: Implement firmware infrastructure and META FW support

2023-12-06 Thread Dan Carpenter
Hello Sarah Walker, The patch cc1aeedb98ad: "drm/imagination: Implement firmware infrastructure and META FW support" from Nov 22, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/imagination/pvr_vm.c:631 pvr_vm_create_context() error:

Re: [PATCH v2 0/4] drm: Fix errors about uninitialized/wrong variables

2023-12-06 Thread Tomi Valkeinen
Hi all, On 03/11/2023 15:14, Tomi Valkeinen wrote: Fix cases where smatch reports a use of an uninitialized variable, and one where the variable is initialized but contains wrong value. Tomi Signed-off-by: Tomi Valkeinen --- Changes in v2: - Added two more fixes - Link to v1:

Re: [v3 1/6] dt-bindings: display: Add yamls for JH7110 display system

2023-12-06 Thread Sui Jingfeng
Hi, On 2023/12/4 20:33, Keith Zhao wrote: StarFive SoCs JH7110 display system: dc controller, hdmi controller, encoder, vout syscon. add the path of yaml file in MAINTAINERS Signed-off-by: Keith Zhao --- .../starfive/starfive,display-subsystem.yaml | 104

Re: [PATCH 1/5] drm/msm/adreno: Split up giant device table

2023-12-06 Thread Dmitry Baryshkov
On Wed, 6 Dec 2023 at 14:29, Konrad Dybcio wrote: > > > > On 12/5/23 23:03, Rob Clark wrote: > > From: Rob Clark > > > > Split into a separate table per generation, in preparation to move each > > gen's device table to it's own file. > > > > Signed-off-by: Rob Clark > > --- > >

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-12-06 Thread Tomi Valkeinen
Hi mipi dsi maintainers (I'm not sure who that is =), On 21/09/2023 13:50, Tomi Valkeinen wrote: It's been reported that DSI host driver's detach can be called without the attach ever happening: https://lore.kernel.org/all/20230412073954.20601-1-t...@atomide.com/ After reading the code, I

[bug report] drm/imagination: Implement firmware infrastructure and META FW support

2023-12-06 Thread Dan Carpenter
Hello Sarah Walker, The patch cc1aeedb98ad: "drm/imagination: Implement firmware infrastructure and META FW support" from Nov 22, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/imagination/pvr_fw_startstop.c:210 pvr_fw_stop() warn: odd mask '0x &

Re: [PATCH 1/5] drm/msm/adreno: Split up giant device table

2023-12-06 Thread Konrad Dybcio
On 12/5/23 23:03, Rob Clark wrote: From: Rob Clark Split into a separate table per generation, in preparation to move each gen's device table to it's own file. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 59 +++--- 1 file changed, 51

Re: [RFC PATCH v3 05/23] drm/vkms: Avoid reading beyond LUT array

2023-12-06 Thread Melissa Wen
On 11/10, Arthur Grillo wrote: > > > On 08/11/23 13:36, Harry Wentland wrote: > > When the floor LUT index (drm_fixp2int(lut_index) is the last > > index of the array the ceil LUT index will point to an entry > > beyond the array. Make sure we guard against it and use the > > value of the floor

Re: [RFC PATCH v3 03/23] drm/vkms: Create separate Kconfig file for VKMS

2023-12-06 Thread Melissa Wen
On 11/08, Harry Wentland wrote: > This aligns with most other DRM drivers and will allow > us to add new VKMS config options without polluting > the DRM Kconfig. > > v3: > - Change SPDX to GPL-2.0-only to match DRM KConfig >SPDX (Simon) LGTM. I plan to apply this one to drm-misc-next.

Re: [PATCH v2 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

2023-12-06 Thread Tomi Valkeinen
Hi, On 08/11/2023 14:45, Alexander Stein wrote: Hi Tomi, Am Mittwoch, 8. November 2023, 12:27:21 CET schrieb Tomi Valkeinen: These two patches are needed to make tc358767 work in the DRM_BRIDGE_ATTACH_NO_CONNECTOR case, at least when using a DP connector. I have tested this with TI AM654 EVM

Re: [PATCH v3 101/108] drm/bridge: ti-sn65dsi86: Make use of devm_pwmchip_alloc() function

2023-12-06 Thread Laurent Pinchart
On Thu, Nov 23, 2023 at 11:10:18AM +0100, Uwe Kleine-König wrote: > Hello Laurent, > > On Thu, Nov 23, 2023 at 11:46:52AM +0200, Laurent Pinchart wrote: > > (CC'ing Bartosz) > > I'm already in discussion with Bart :-) > > > On Tue, Nov 21, 2023 at 02:50:43PM +0100, Uwe Kleine-König wrote: > > >

Re: [RFC PATCH v3 01/23] drm: Don't treat 0 as -1 in drm_fixp2int_ceil

2023-12-06 Thread Melissa Wen
On 11/08, Harry Wentland wrote: > Unit testing this in VKMS shows that passing 0 into > this function returns -1, which is highly counter- > intuitive. Fix it by checking whether the input is > >= 0 instead of > 0. > Nice finding. Thanks! Could you add the fixes tag? AFAIU, this one: Fixes:

Re: [v3 5/6] drm/vs: Add hdmi driver

2023-12-06 Thread Keith Zhao
On 2023/12/6 17:04, Maxime Ripard wrote: > On Mon, Dec 04, 2023 at 08:33:14PM +0800, Keith Zhao wrote: >> add hdmi driver as encoder and connect >> >> Signed-off-by: Keith Zhao >> --- >> drivers/gpu/drm/verisilicon/Kconfig | 8 + >> drivers/gpu/drm/verisilicon/Makefile| 1

[PATCH] drm/msm/dp: Fix platform_get_irq() check

2023-12-06 Thread Dan Carpenter
The platform_get_irq() function returns negative error codes. It never returns zero. Fix the check accordingly. Fixes: 82c2a5751227 ("drm/msm/dp: tie dp_display_irq_handler() with dp driver") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- 1 file changed, 2

Re: [PATCH v8 8/8] drm/ttm/tests: Add test cases dependent on fence signaling

2023-12-06 Thread Karolina Stolarek
Hi Andi, For next time, I find it difficult to follow all these variables, it's easier to read man = ttm_manager_type(priv->ttm_dev, TTM_PL_SYSTEM); than mem_type = TTM_PL_SYSTEM; ... ... ... man = ttm_manager_type(priv->ttm_dev, mem_type);

[PATCH v4 107/115] drm/bridge: ti-sn65dsi86: Make use of devm_pwmchip_alloc() function

2023-12-06 Thread Uwe Kleine-König
This prepares the pwm driver of the ti-sn65dsi86 to further changes of the pwm core outlined in the commit introducing devm_pwmchip_alloc(). There is no intended semantical change and the driver should behave as before. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/bridge/ti-sn65dsi86.c |

  1   2   >