Hello Ricardo,
On Tue, 5 Mar 2024 at 22:37, T.J. Mercier wrote:
>
> On Tue, Mar 5, 2024 at 3:34 AM Ricardo B. Marliere
> wrote:
> >
> > Since commit 43a7206b0963 ("driver core: class: make class_register() take
> > a const *"), the driver core allows for struct class to be in read-only
> >
Hi Kuro,
Following up my comments from v2 [1]:
On Wed, Mar 6, 2024 at 10:09 AM kuro wrote:
>
> From: kuro chung
>
> ITE added a FIFO reset bit for input video. When system power resume,
> the TTL input of it6505 may get some noise before video signal stable
> and the hardware function reset is
[Why]
Commit:
- commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload
allocation/removement")
accidently overwrite the commit
- commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in
drm_dp_add_payload_part2")
which cause regression.
[How]
Recover the original NULL fix and remove the
rm/bridge: anx7625: add HDMI audio function")
> Signed-off-by: Hsin-Te Yuan
Reviewed-by: Chen-Yu Tsai
> ---
> Changes in v3:
> - Add Fixes tag.
> - Link to v2:
> https://lore.kernel.org/r/20240306-anx7625-v2-1-7138e00b2...@chromium.org
>
> Changes in v2:
> - Add
Add necessary function definitions to compute AS SDP data.
The new intel_dp_compute_as_sdp function computes AS SDP
values based on the display configuration, ensuring proper
handling of Variable Refresh Rate (VRR).
--v2:
- Added DP_SDP_ADAPTIVE_SYNC to infoframe_type_to_idx(). [Ankit]
-
Compute vrr_vsync_start/end, which sets the position
for hardware to send the Vsync at a fixed position
relative to the end of the Vblank.
--v2:
- Updated VSYNC_START/END macros to VRR_VSYNC_START/END. (Ankit)
- Updated bit fields of VRR_VSYNC_START/END. (Ankit)
--v3:
- Add
Add read/write calls for Adaptive Sync SDP.
Signed-off-by: Mitul Golani
---
drivers/gpu/drm/i915/display/intel_ddi.c | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
Enable infoframe and add state checker for Adaptive Sync
SDP enablement.
--v1:
- crtc_state->infoframes.enable, to add on correct place holder.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_display.c | 46
1 file changed,
Add the necessary structures and functions to handle reading and
unpacking Adaptive Sync Secondary Data Packets. Also add support
to write and pack AS SDP.
--v2:
- Correct use of REG_BIT and REG_GENMASK. [Jani]
- Use as_sdp instead of async. [Jani]
- Remove unrelated comments and changes. [Jani]
Add a wrapper function to check if both the source and
sink support Adaptive Sync SDP.
--v1:
Just use drm/i915/dp in subject line.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_dp.c | 8
drivers/gpu/drm/i915/display/intel_dp.h | 1 +
2
Add crtc state dump for Adaptive Sync SDP to know which
crtc specifically caused the failure.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
.../gpu/drm/i915/display/intel_crtc_state_dump.c| 13 +
drivers/gpu/drm/i915/display/intel_display_types.h | 1 +
2 files
Add structure representing Adaptive Sync Secondary Data Packet (AS SDP).
Also, add Adaptive Sync SDP logging in drm_dp_helper.c to facilitate
debugging.
--v2:
- Update logging. [Jani, Ankit]
- Use 'as_sdp' instead of 'async' [Ankit]
- Correct define placeholders to where they are actually used.
Add an API that indicates support for Adaptive Sync SDP in
the sink, which can be utilized by the rest of the DP programming.
--v1:
- Format commit message properly.
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/display/drm_dp_helper.c | 25
An Adaptive-Sync-capable DP protocol converter indicates its
support by setting the related bit in the DPCD register. This
is valid for DP and edp as well.
Computes AS SDP values based on the display configuration,
ensuring proper handling of Variable Refresh Rate (VRR)
in the context of Adaptive
On 06/03/24 10:16 pm, Nicolas Ferre - M43238 wrote:
> Dharma, all,
>
> On 06/03/2024 at 15:35, Dharma B - I70843 wrote:
>>
>> On 05/03/24 3:31 am, Rob Herring wrote:
>>> On Mon, Mar 04, 2024 at 08:00:03PM +0530, Dharma Balasubiramani wrote:
Convert the atmel,lcdc bindings to DT schema.
Hi Jani,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-misc/drm-misc-next]
[cannot apply to drm/drm-next drm-intel/for-linux-next
drm-intel/for-linux-next-fixes linus/master v6.8-rc7 next-20240306]
[If your patch is applied to the wrong git tree, kindly
Hi Jani,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-misc/drm-misc-next]
[cannot apply to drm/drm-next drm-intel/for-linux-next
drm-intel/for-linux-next-fixes linus/master v6.8-rc7 next-20240306]
[If your patch is applied to the wrong git tree, kindly
Add page fault information to the devcoredump.
Output of devcoredump:
AMDGPU Device Coredump
version: 1
kernel: 6.7.0-amd-staging-drm-next
module: amdgpu
time: 29.725011811
process_name: soft_recovery_p PID: 1720
Ring timed out details
IP Type: 0 Ring Name: gfx_0.0.0
[gfxhub] Page
On 3/7/2024 12:51 AM, Deucher, Alexander wrote:
[Public]
-Original Message-
From: Sunil Khatri
Sent: Wednesday, March 6, 2024 1:20 PM
To: Deucher, Alexander ; Koenig, Christian
; Sharma, Shashank
Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-
Volteer devices in the collabora lab are categorized under the
asus-cx9400-volteer device type. The majority of these units
has an Intel Core i5-1130G7 CPU, while some of them have a
Intel Core i7-1160G7 CPU instead. So due to this difference,
new device type template is added for the Intel Core
Hi all,
Today's linux-next merge of the drm tree got a conflict in:
drivers/gpu/drm/i915/display/intel_dp.c
between commit:
984318aaf7b6 ("drm/i915/panelreplay: Move out psr_init_dpcd() from
init_connector()")
from the drm-intel-fixes tree and commit:
e60cff453b82 ("drm/i915/dp:
On Wed, Mar 6, 2024 at 3:24 PM Ville Syrjälä
wrote:
>
> On Wed, Mar 06, 2024 at 07:37:16AM -0800, Rob Clark wrote:
> > On Wed, Mar 6, 2024 at 7:06 AM Ville Syrjälä
> > wrote:
> > >
> > > On Wed, Mar 06, 2024 at 06:49:15AM -0800, Rob Clark wrote:
> > > > On Wed, Mar 6, 2024 at 4:18 AM Thomas
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
head: f89632a9e5fa6c4787c14458cd42a9ef42025434
commit: f89632a9e5fa6c4787c14458cd42a9ef42025434 [2/2] drm: Add
CONFIG_DRM_WERROR
config: sparc-allmodconfig
Hi,
On Wed, Mar 6, 2024 at 4:20 PM Hsin-Yi Wang wrote:
>
> On Wed, Mar 6, 2024 at 3:30 PM Doug Anderson wrote:
> >
> > Hi,
> >
> > On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote:
> > >
> > > +static void
> > > +match_identity(const struct detailed_timing *timing, void *data)
> > > +{
> > >
On Wed, Mar 6, 2024 at 3:30 PM Doug Anderson wrote:
>
> Hi,
>
> On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote:
> >
> > +static void
> > +match_identity(const struct detailed_timing *timing, void *data)
> > +{
> > + struct drm_edid_match_closure *closure = data;
> > + unsigned
On Wed, Mar 06, 2024 at 02:22:47AM +0100, Andi Shyti wrote:
> Enable only one CCS engine by default with all the compute sices
> allocated to it.
>
> While generating the list of UABI engines to be exposed to the
> user, exclude any additional CCS engines beyond the first
> instance.
>
> This
Le 06/03/24 - 17:03, Arthur Grillo a écrit :
> Signed-off-by: Arthur Grillo
> ---
> drivers/gpu/drm/vkms/tests/vkms_format_test.c | 2 +-
> drivers/gpu/drm/vkms/vkms_drv.h | 4
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git
o I can rebase everything on the
> >> line-by-line work.
> >
> > OK, I will do that.
>
> Hi,
>
> I know that I said that, but it would be very difficult to that with my
> b4 workflow. So, I sent a separate series based on the v4:
>
> https://lore.kernel.org/
On Wed, Mar 06, 2024 at 02:22:45AM +0100, Andi Shyti wrote:
> The hardware should not dynamically balance the load between CCS
> engines. Wa_14019159160 recommends disabling it across all
> platforms.
>
> Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement")
> Signed-off-by: Andi
Hi,
On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote:
>
> @@ -1009,6 +1009,19 @@ static const struct panel_desc auo_b101ean01 = {
> },
> };
>
> +static const struct drm_display_mode auo_b116xa3_mode = {
> + .clock = 70589,
> + .hdisplay = 1366,
> + .hsync_start =
Hi,
On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote:
>
> Currently edid quirks are matched by panel id only.
>
> Modify it to match with identity so it's easier to be extended
> for more complex matching if required.
>
> Suggested-by: Jani Nikula
> Signed-off-by: Hsin-Yi Wang
> Reviewed-by:
Hi,
On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote:
>
> @@ -2111,15 +2113,16 @@ static const struct edp_panel_entry edp_panels[] = {
> { /* sentinal */ }
> };
>
> -static const struct edp_panel_entry *find_edp_panel(u32 panel_id)
> +static const struct edp_panel_entry
Hi,
On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote:
>
> +static void
> +match_identity(const struct detailed_timing *timing, void *data)
> +{
> + struct drm_edid_match_closure *closure = data;
> + unsigned int i;
> + const char *name = closure->ident->name;
> +
Hi,
On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote:
>
> drm_edid_get_panel_id() now just directly call edid_extract_panel_id().
>
> Merge them into one function.
>
> Signed-off-by: Hsin-Yi Wang
> ---
> v4->v5: new
> ---
> drivers/gpu/drm/drm_edid.c | 39
Hi,
On Wed, Mar 6, 2024 at 12:04 PM Hsin-Yi Wang wrote:
>
> @@ -2764,58 +2764,71 @@ static u32 edid_extract_panel_id(const struct edid
> *edid)
> }
>
> /**
> - * drm_edid_get_panel_id - Get a panel's ID through DDC
> - * @adapter: I2C adapter to use for DDC
> + * drm_edid_get_panel_id - Get a
On Wed, Mar 06, 2024 at 07:37:16AM -0800, Rob Clark wrote:
> On Wed, Mar 6, 2024 at 7:06 AM Ville Syrjälä
> wrote:
> >
> > On Wed, Mar 06, 2024 at 06:49:15AM -0800, Rob Clark wrote:
> > > On Wed, Mar 6, 2024 at 4:18 AM Thomas Zimmermann
> > > wrote:
> > > >
> > > > Hi,
> > > >
> > > > sorry
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
head: f89632a9e5fa6c4787c14458cd42a9ef42025434
commit: f89632a9e5fa6c4787c14458cd42a9ef42025434 [2/2] drm: Add
CONFIG_DRM_WERROR
config: s390-allyesconfig
On Wed, Mar 6, 2024 at 4:38 AM Yunsheng Lin wrote:
>
> On 2024/3/6 5:17, Mina Almasry wrote:
> > On Tue, Mar 5, 2024 at 4:55 AM Yunsheng Lin wrote:
> >>
> >> On 2024/3/5 10:01, Mina Almasry wrote:
> >>
> >> ...
> >>
> >>>
> >>> The netdev_dmabuf_binding struct is refcounted, and releases its
>
On Wed, Mar 6, 2024 at 11:14 AM Pavel Begunkov wrote:
>
> On 3/6/24 17:04, Mina Almasry wrote:
> > On Wed, Mar 6, 2024 at 6:30 AM Pavel Begunkov
> > wrote:
> >>
> >> On 3/5/24 22:36, Mina Almasry wrote:
> >>> On Tue, Mar 5, 2024 at 1:55 PM David Wei wrote:
>
> On 2024-03-04 18:01,
Add a check to mtk_drm_gem_init if we attempt to allocate a GEM object
of 0 bytes. Currently, no such check exists and the kernel will panic if
a userspace application attempts to allocate a 0x0 GBM buffer.
Tested by attempting to allocate a 0x0 GBM buffer on an MT8188 and
verifying that we now
From: Arnaud Lahache
Fixes a memory leak occurring on each modeset update.
Running a program such as libdrm's modetest[0] with this driver exhausts
all available memory after a few minutes. Enabling kmemleak yields a series
of such leak reports:
unreferenced object 0xc21acf40 (size 64):
comm
y difficult to that with my
b4 workflow. So, I sent a separate series based on the v4:
https://lore.kernel.org/all/20240306-louis-vkms-conv-v1-0-5bfe7d129...@riseup.net/
I hope that it does not difficult things for you.
Best Regards,
~Arthur Grillo
>
> Best Regards,
> ~Arthur Grillo
&
On Wed, 6 Mar 2024 at 21:59, Abhinav Kumar wrote:
>
>
>
> On 3/6/2024 11:52 AM, Dmitry Baryshkov wrote:
> > On Wed, 6 Mar 2024 at 21:50, Abhinav Kumar
> > wrote:
> >>
> >> There are cases where the userspace might still send another
> >> frame after the HPD disconnect causing a modeset cycle
It's found that some panels have variants that they share the same panel id
although their EDID and names are different. When matching generic edp
panels, we should first match with both panel identity, which contains both
panel id and panel name. If not found, match with panel id only.
Now that we have KUnit tests, add instructions on how to run them.
Signed-off-by: Arthur Grillo
---
Documentation/gpu/vkms.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst
index 13b866c3617c..5ef5ef2e6a21 100644
---
Using the drm_fixed calls, this needs to be changed. Which in fact is
more correct, colour.YCbCr_to_RGB() gives 0x8080 for same the yuv
parameters.
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/vkms/tests/vkms_format_test.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Currently edid quirks are matched by panel id only.
Modify it to match with identity so it's easier to be extended
for more complex matching if required.
Suggested-by: Jani Nikula
Signed-off-by: Hsin-Yi Wang
Reviewed-by: Jani Nikula
---
v5: no change
---
drivers/gpu/drm/drm_edid.c | 13
There are 2 different AUO panels using the same panel id. One of the
variants requires using overridden modes to resolve glitching issue as
described in commit 70e0d5550f5c ("drm/panel-edp: Add auo_b116xa3_mode").
Other variants should use the modes parsed from EDID.
Signed-off-by: Hsin-Yi Wang
Create a type drm_edid_ident as the identity of an EDID. Currently it
contains panel id and monitor name.
Create a function that can match a given EDID and an identity:
1. Reject if the panel id doesn't match.
2. If name is not null in identity, try to match it in the detailed timing
blocks.
drm_edid_get_panel_id() now just directly call edid_extract_panel_id().
Merge them into one function.
Signed-off-by: Hsin-Yi Wang
---
v4->v5: new
---
drivers/gpu/drm/drm_edid.c | 39 ++
1 file changed, 18 insertions(+), 21 deletions(-)
diff --git
It's found that some panels have variants that they share the same panel id
although their EDID and names are different. Besides panel id, now we need
more information from the EDID base block to distinguish these panel
variants.
Add drm_edid_read_base_block() to return the EDID base block, which
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/vkms/tests/vkms_format_test.c | 67 +++
1 file changed, 67 insertions(+)
diff --git a/drivers/gpu/drm/vkms/tests/vkms_format_test.c
b/drivers/gpu/drm/vkms/tests/vkms_format_test.c
index 3522ecee960f..66cdd83c3d25 100644
This series is a follow up for 1a5e81de180e ("Revert "drm/panel-edp: Add
auo_b116xa3_mode""). It's found that 2 different AUO panels use the same
product id. One of them requires an overridden mode, while the other should
use the mode directly from edid.
Match the panel for identity (id and
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/vkms/tests/vkms_format_test.c | 2 +-
drivers/gpu/drm/vkms/vkms_drv.h | 4
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/tests/vkms_format_test.c
With the new 32.32 values it makes more sense to use drm_fixed functions
than trying to recreate the wheel.
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/vkms/vkms_formats.c | 54 +++--
1 file changed, 28 insertions(+), 26 deletions(-)
diff --git
Signed-off-by: Arthur Grillo
---
drivers/gpu/drm/vkms/vkms_formats.c | 47 +
1 file changed, 47 insertions(+)
diff --git a/drivers/gpu/drm/vkms/vkms_formats.c
b/drivers/gpu/drm/vkms/vkms_formats.c
index 44d9b9b3bdc3..55ed3f598bd7 100644
---
As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong.
To round a number, you need to add 0.5 to the number and floor that,
drm_fixp2int_round() is adding 0.076. Make it add 0.5.
[1]:
https://lore.kernel.org/all/20240301135327.22efe0dd.pekka.paala...@collabora.com/
/drm/vkms/vkms_drv.h | 4 +
drivers/gpu/drm/vkms/vkms_formats.c | 101 +++---
include/drm/drm_fixed.h | 2 +-
5 files changed, 165 insertions(+), 34 deletions(-)
---
base-commit: 9658aba38ae9f3f3068506c9c8e93e85b500fcb4
change-id: 2024
On 3/6/2024 11:52 AM, Dmitry Baryshkov wrote:
On Wed, 6 Mar 2024 at 21:50, Abhinav Kumar wrote:
There are cases where the userspace might still send another
frame after the HPD disconnect causing a modeset cycle after
a disconnect. This messes the internal state machine of MSM DP driver
On Wed, 6 Mar 2024 at 21:50, Abhinav Kumar wrote:
>
> There are cases where the userspace might still send another
> frame after the HPD disconnect causing a modeset cycle after
> a disconnect. This messes the internal state machine of MSM DP driver
> and can lead to a crash as there can be an
On 3/6/2024 12:59, Harry Wentland wrote:
On 2024-03-06 13:02, Mario Limonciello wrote:
On 3/6/2024 12:00, Xaver Hugl wrote:
Am Mi., 6. März 2024 um 18:19 Uhr schrieb Mario Limonciello
:
So the idea being if the compositor isn't using it we let
power-profiles-daemon (or any other software)
There are cases where the userspace might still send another
frame after the HPD disconnect causing a modeset cycle after
a disconnect. This messes the internal state machine of MSM DP driver
and can lead to a crash as there can be an imbalance between
bridge_disable() and bridge_enable().
This
On Wed, 6 Mar 2024 at 21:35, Abhinav Kumar wrote:
>
> Fix the typo in the name of dp_display_handle_port_status_changed().
>
> Fixes: c58eb1b54fee ("drm/msm/dp: fix connect/disconnect handled at irq_hpd")
> Signed-off-by: Abhinav Kumar
Reviewed-by: Dmitry Baryshkov
--
With best wishes
PCI IDs for XEHPSDV were never added and platform always marked with
force_probe. Drop what's not used and rename some places to either be
xehp or dg2, depending on the platform/IP checks.
The registers not used anymore are also removed.
Signed-off-by: Lucas De Marchi
---
Potential problem
With both XEHPSDV and PVC removed (as platforms, most of their code
remain used by others), there's no need to handle !RCS_MASK() as
other platforms don't ever have fused-off render. Remove those code
paths and the special WA flag when initializing GuC.
Signed-off-by: Lucas De Marchi
---
PCI IDs for PVC were never added and platform always marked with
force_probe. Drop what's not used and rename some places as needed.
The registers not used anymore are also removed.
Signed-off-by: Lucas De Marchi
---
.../gpu/drm/i915/gem/i915_gem_object_types.h | 2 +-
With dynamic load-balancing disabled on the compute side, there's no
reason left to enable WA 16015675438. Drop it from both PVC and DG2.
Note that this can be done because now the driver always set a fixed
partition of EUs during initialization via the ccs_mode configuration.
The flag to GuC is
Remove platforms that never had their PCI IDs added to the driver and
are of course marked with requiring force_probe. Note that most of the
code for those platforms is actually used by subsequent ones, so it's
not a huge amount of code being removed.
With no platform declaring graphics/media IP_VER(12, 50), replace the
checks throughout the code with IP_VER(12, 55) so the code makes sense
by itself with no additional explanation of previous baggage.
The info override for the various _info is then changed so the version
definition is clearer
Fix the typo in the name of dp_display_handle_port_status_changed().
Fixes: c58eb1b54fee ("drm/msm/dp: fix connect/disconnect handled at irq_hpd")
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
[Public]
> -Original Message-
> From: Sunil Khatri
> Sent: Wednesday, March 6, 2024 1:20 PM
> To: Deucher, Alexander ; Koenig, Christian
> ; Sharma, Shashank
>
> Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-
> ker...@vger.kernel.org; Joshi, Mukul ; Paneer
>
On 3/6/24 17:04, Mina Almasry wrote:
On Wed, Mar 6, 2024 at 6:30 AM Pavel Begunkov wrote:
On 3/5/24 22:36, Mina Almasry wrote:
On Tue, Mar 5, 2024 at 1:55 PM David Wei wrote:
On 2024-03-04 18:01, Mina Almasry wrote:
+struct memory_provider_ops {
+ int (*init)(struct page_pool *pool);
On Wed, Mar 6, 2024 at 1:17 AM Jani Nikula wrote:
>
> On Tue, 05 Mar 2024, Hsin-Yi Wang wrote:
> > Create a type drm_edid_ident as the identity of an EDID. Currently it
> > contains panel id and monitor name.
> >
> > Create a function that can match a given EDID and an identity:
> > 1. Reject if
On 2024-03-06 13:02, Mario Limonciello wrote:
> On 3/6/2024 12:00, Xaver Hugl wrote:
>> Am Mi., 6. März 2024 um 18:19 Uhr schrieb Mario Limonciello
>> :
>>> So the idea being if the compositor isn't using it we let
>>> power-profiles-daemon (or any other software) take control via sysfs and
>>>
Hi Daniel,
On 3/6/24 10:24, Daniel Díaz wrote:
[ ... ]
Thank you SO very much for this work! This is very much appreciated!
Thanks a lot for the feedback.
We run into these warnings at LKFT all the time, and making sure that
the noise doesn't drown the relevant signal is very important.
On Wed, Mar 6, 2024 at 1:23 AM Jani Nikula wrote:
>
> On Tue, 05 Mar 2024, Hsin-Yi Wang wrote:
> > It's found that some panels have variants that they share the same panel id
> > although their EDID and names are different. When matching generic edp
> > panels, we should first match with both
Ensure drm headers build, are self-contained, have header guards, and
have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y.
The mechanism follows similar patters used in i915, xe, and usr/include.
To cover include/drm, we need to recurse there using the top level
Kbuild and the new
Fix some formatting errors and excess documentation.
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_execbuf_util.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/drm/ttm/ttm_execbuf_util.h
b/include/drm/ttm/ttm_execbuf_util.h
index
There's no proper way to document function pointer members, but at least
silence the warnings.
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_kmap_iter.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/drm/ttm/ttm_kmap_iter.h b/include/drm/ttm/ttm_kmap_iter.h
Include for pgprot_t.
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_caching.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/drm/ttm/ttm_caching.h b/include/drm/ttm/ttm_caching.h
index 235a743d90e1..a18f43e93aba 100644
--- a/include/drm/ttm/ttm_caching.h
+++
Some renames, some formatting fixes, add some as FIXME.
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_bo.h | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/include/drm/ttm/ttm_bo.h b/include/drm/ttm/ttm_bo.h
index 0223a41a64b2..8b1eb6828f0a 100644
---
Make documentation match code.
Signed-off-by: Jani Nikula
---
include/drm/i915_pxp_tee_interface.h | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/include/drm/i915_pxp_tee_interface.h
b/include/drm/i915_pxp_tee_interface.h
index
Make the documentation match code.
Signed-off-by: Jani Nikula
---
include/drm/i915_hdcp_interface.h | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/include/drm/i915_hdcp_interface.h
b/include/drm/i915_hdcp_interface.h
index 4c9c8167c2d5..a9f2ee576de8
There's no proper way to document function pointer members, but at least
silence the warnings.
Signed-off-by: Jani Nikula
---
include/drm/i915_gsc_proxy_mei_interface.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/drm/i915_gsc_proxy_mei_interface.h
Rename dma_fence to fence to match code.
Signed-off-by: Jani Nikula
---
include/drm/drm_suballoc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_suballoc.h b/include/drm/drm_suballoc.h
index c2188bb0b157..7ba72a81a808 100644
--- a/include/drm/drm_suballoc.h
Mark some members private to silence kernel-doc warnings, and add FIXME
comments.
Signed-off-by: Jani Nikula
---
include/drm/i2c/ch7006.h | 1 +
include/drm/i2c/sil164.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/drm/i2c/ch7006.h b/include/drm/i2c/ch7006.h
index
Include for ERR_PTR.
Signed-off-by: Jani Nikula
---
include/drm/drm_of.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h
index 082a6e980d01..02d1cdd7f798 100644
--- a/include/drm/drm_of.h
+++ b/include/drm/drm_of.h
@@ -2,6 +2,7 @@
#ifndef
Remove excess funcs kernel-doc.
Signed-off-by: Jani Nikula
---
include/drm/drm_gem_vram_helper.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/drm/drm_gem_vram_helper.h
b/include/drm/drm_gem_vram_helper.h
index e18429f09e53..c89c9bafeb44 100644
---
Include for types used.
Signed-off-by: Jani Nikula
---
include/drm/drm_lease.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/drm/drm_lease.h b/include/drm/drm_lease.h
index 5c9ef6a2aeae..53545b4ca9ef 100644
--- a/include/drm/drm_lease.h
+++ b/include/drm/drm_lease.h
@@ -6,6
As the documentation says, all the fields are considered private. Mark
them private also for kernel-doc to silence warnings.
Signed-off-by: Jani Nikula
---
include/drm/drm_format_helper.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/drm/drm_format_helper.h
Mark some parts private to silence kernel-doc warnings, and add FIXME.
Signed-off-by: Jani Nikula
---
include/drm/drm_encoder_slave.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/drm/drm_encoder_slave.h b/include/drm/drm_encoder_slave.h
index 7214101fd731..7f0ee97bb3a5 100644
Add a number of require includes and forward declare struct
drm_crtc. s/crc/crcs/ kernel-doc to match code.
Signed-off-by: Jani Nikula
---
include/drm/drm_debugfs_crc.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_debugfs_crc.h
Include for u8.
Signed-off-by: Jani Nikula
---
include/drm/amd_asic_type.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/drm/amd_asic_type.h b/include/drm/amd_asic_type.h
index 724c45e3e9a7..9be85b821aa6 100644
--- a/include/drm/amd_asic_type.h
+++
Drop excess vcpi member documentation.
Signed-off-by: Jani Nikula
---
include/drm/display/drm_dp_mst_helper.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/drm/display/drm_dp_mst_helper.h
b/include/drm/display/drm_dp_mst_helper.h
index 9b19d8bd520a..3ae88a383a41 100644
---
s/_features/_feat/ to match code.
Signed-off-by: Jani Nikula
---
include/drm/drm_kunit_helpers.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_kunit_helpers.h b/include/drm/drm_kunit_helpers.h
index 6e99627edf45..e7cc17ee4934 100644
---
Include and forward declare struct platform device.
Signed-off-by: Jani Nikula
---
include/drm/bridge/samsung-dsim.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/drm/bridge/samsung-dsim.h
b/include/drm/bridge/samsung-dsim.h
index e0c105051246..9764d6eb5beb
Including the file twice leads to errors.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_internal.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h
index 8e4faf0a28e6..d69744c9ac15 100644
---
Forward declare struct drm_printer.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_internal.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_crtc_internal.h
b/drivers/gpu/drm/drm_crtc_internal.h
index a514d5207e41..72c26f996b3b 100644
---
First, fix a bunch of issues in drm headers, uncovered with the last
patch. A few kernel-doc warnings are just brushed under the carpet for
now, with a FIXME comment. Otherwise, pretty straightforward stuff.
Second, add a header test facility to catch issues at build time when
Hello!
On Tue, 5 Mar 2024 at 12:40, Guenter Roeck wrote:
> Some unit tests intentionally trigger warning backtraces by passing bad
> parameters to kernel API functions. Such unit tests typically check the
> return value from such calls, not the existence of the warning backtrace.
>
> Such
1 - 100 of 230 matches
Mail list logo
