Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-01 Thread Archit Taneja
Hi, On Wednesday 01 August 2012 07:55 PM, Rob Clark wrote: On Wed, Aug 1, 2012 at 4:21 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Tue, 2012-07-31 at 09:45 -0500, Rob Clark wrote: On Tue, Jul 31, 2012 at 8:40 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: It's not really about

Re: [PATCH] drm/omap: use omapdss low level API

2012-11-15 Thread Archit Taneja
On Friday 16 November 2012 12:14 PM, Archit Taneja wrote: On Friday 16 November 2012 05:30 AM, Rob Clark wrote: if (!obj) @@ -565,14 +344,6 @@ static int dev_load(struct drm_device *dev, unsigned long flags) dev-dev_private = priv; -ret = omapdss_compat_init(); -if (ret

Re: [PATCH] drm/omap: use omapdss low level API

2012-11-15 Thread Archit Taneja
On Friday 16 November 2012 05:30 AM, Rob Clark wrote: This patch changes the omapdrm KMS to bypass the omapdss compat layer and use the core omapdss API directly. This solves some layering issues that would cause unpin confusion vs GO bit status, because we would not know whether a particular

Re: [RFC v2 0/5] Common Display Framework

2013-02-06 Thread Archit Taneja
On Monday 04 February 2013 03:35 PM, Marcus Lorentzon wrote: On 02/02/2013 12:35 AM, Laurent Pinchart wrote: Hi Marcus, On Tuesday 08 January 2013 18:08:19 Marcus Lorentzon wrote: On 01/08/2013 05:36 PM, Tomasz Figa wrote: On Tuesday 08 of January 2013 11:12:26 Marcus Lorentzon wrote: [...]

[PATCH] omapdrm: Make fixed resolution panels work

2013-02-14 Thread Archit Taneja
with DT. I can try if needed. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/staging/omapdrm/omap_connector.c | 10 -- drivers/staging/omapdrm/omap_encoder.c |6 -- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/staging/omapdrm/omap_connector.c

Re: [PATCH] omapdrm: Make fixed resolution panels work

2013-02-17 Thread Archit Taneja
On Thursday 14 February 2013 09:24 PM, Rob Clark wrote: On Thu, Feb 14, 2013 at 6:52 AM, Archit Taneja arc...@ti.com wrote: The omapdrm driver requires omapdss panel drivers to expose ops like detect, set_timings and check_timings. These can be NULL for fixed panel DPI, DBI, DSI and SDI drivers

[PATCH 0/4] drm/omap: Misc fixes and improvements

2013-03-05 Thread Archit Taneja
platforms with different combinations of panels connected to it. - Fix certain areas in omapdrm which allow fixed resolution panels to work. Archit Taneja (4): drm/omap: Don't return from modeset_init if a panel doesn't satisfy omapdrm requirements drm/omap: Fix and improve crtc and overlay

[PATCH 1/4] drm/omap: Don't return from modeset_init if a panel doesn't satisfy omapdrm requirements

2013-03-05 Thread Archit Taneja
of the future panels and encoders which come after it, that isn't the correct thing to do, we should go through the rest of the panels. Replace the 'return's with 'continue's. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/gpu/drm/omapdrm/omap_drv.c |4 ++-- 1 file changed, 2 insertions

[PATCH 3/4] drm/omap: Make fixed resolution panels work

2013-03-05 Thread Archit Taneja
that it calls set_timings only if the panel driver has one. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/gpu/drm/omapdrm/omap_connector.c | 10 -- drivers/gpu/drm/omapdrm/omap_encoder.c |6 -- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu

[PATCH 4/4] omapdss: features: fixed supported outputs for OMAP4

2013-03-05 Thread Archit Taneja
at the DSS level, and we also need to configure the hdmi pll in the DPI driver so that the TV manager has a pixel clock. We don't support that yet. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dss_features.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH 2/4] drm/omap: Fix and improve crtc and overlay manager correlation

2013-03-05 Thread Archit Taneja
yet though. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/gpu/drm/omapdrm/omap_crtc.c| 21 ++-- drivers/gpu/drm/omapdrm/omap_drv.c | 192 +++- drivers/gpu/drm/omapdrm/omap_drv.h | 38 +-- drivers/gpu/drm/omapdrm/omap_encoder.c |7

Re: [PATCH 3/4] drm/omap: Make fixed resolution panels work

2013-03-06 Thread Archit Taneja
On Wednesday 06 March 2013 06:15 AM, Rob Clark wrote: On Tue, Mar 5, 2013 at 9:17 AM, Archit Taneja arc...@ti.com wrote: The omapdrm driver requires omapdss panel drivers to expose ops like detect, set_timings and check_timings. These can be NULL for fixed panel DPI, DBI, DSI and SDI drivers

Re: [PATCH 4/4] omapdss: features: fixed supported outputs for OMAP4

2013-03-12 Thread Archit Taneja
On Monday 11 March 2013 05:58 PM, Tomi Valkeinen wrote: On 2013-03-05 16:17, Archit Taneja wrote: The support outputs struct for overlay managers is incorrect for OMAP4. Make these changes: - DPI isn't supported via the LCD1 overlay manager, remove DPI as a supported output. - the TV

Re: [PATCH 4/4] omapdss: features: fixed supported outputs for OMAP4

2013-03-12 Thread Archit Taneja
On Tuesday 12 March 2013 04:08 PM, Tomi Valkeinen wrote: On 2013-03-12 08:07, Archit Taneja wrote: On Monday 11 March 2013 05:58 PM, Tomi Valkeinen wrote: On 2013-03-05 16:17, Archit Taneja wrote: The support outputs struct for overlay managers is incorrect for OMAP4. Make these changes

[PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-12 Thread Archit Taneja
that it calls set_timings only if the panel driver has one. Signed-off-by: Archit Taneja arc...@ti.com --- Note: In v2, we make sure that the mode passed on to omapdrm matches the timings of the fixed resolution panel. drivers/gpu/drm/omapdrm/omap_connector.c | 27

Re: [PATCH 4/4] omapdss: features: fixed supported outputs for OMAP4

2013-03-12 Thread Archit Taneja
On Tuesday 12 March 2013 07:07 PM, Tomi Valkeinen wrote: On 2013-03-12 14:57, Archit Taneja wrote: We could also use the recommended channel way for omapdrm, I can't figure out what's the better approach at the moment. Hmm, I think it'd be safer to use the recommended channel from omapdss

Re: [PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-12 Thread Archit Taneja
On Tuesday 12 March 2013 07:36 PM, Tomi Valkeinen wrote: On 2013-03-12 15:06, Archit Taneja wrote: The omapdrm driver requires omapdss panel drivers to expose ops like detect, set_timings and check_timings. These can be NULL for fixed panel DPI, DBI, DSI and SDI drivers. At some places

Re: [PATCH 4/4] omapdss: features: fixed supported outputs for OMAP4

2013-03-12 Thread Archit Taneja
On Tuesday 12 March 2013 07:59 PM, Tomi Valkeinen wrote: On 2013-03-12 16:01, Archit Taneja wrote: On Tuesday 12 March 2013 07:07 PM, Tomi Valkeinen wrote: So, I don't disagree with you. But I don't quite understand why we could not use the fixed channels for now? They should work in all

Re: [PATCH v4 09/21] modetest: Allow specifying plane position

2013-03-25 Thread Archit Taneja
Hi Laurent, On Tuesday 19 March 2013 08:25 PM, Laurent Pinchart wrote: Extend the -P option to allow specifying the plane x and y offsets. The position is optional, if not specified the plane will be positioned at the center of the screen as before. Thanks for this series. I tested the

Re: [PATCH v4 09/21] modetest: Allow specifying plane position

2013-03-26 Thread Archit Taneja
On Tuesday 26 March 2013 04:11 AM, Laurent Pinchart wrote: Hi Archit, On Monday 25 March 2013 11:44:35 Archit Taneja wrote: Hi Laurent, On Tuesday 19 March 2013 08:25 PM, Laurent Pinchart wrote: Extend the -P option to allow specifying the plane x and y offsets. The position is optional

[PATCH v2 0/8] omapdss/omapdrm: Misc fixes and improvements

2013-03-26 Thread Archit Taneja
and dsi video mode calc series posted by Tomi. Reference branch: git://gitorious.org/~boddob/linux-omap-dss2/archit-dss2-clone.git for-3.10/misc_drm_dss Archit Taneja (8): drm/omap: Don't return from modeset_init if a panel doesn't satisfy omapdrm requirements drm/omap: Fix and improve crtc

[PATCH v2 1/8] drm/omap: Don't return from modeset_init if a panel doesn't satisfy omapdrm requirements

2013-03-26 Thread Archit Taneja
of the future panels and encoders which come after it, that isn't the correct thing to do, we should go through the rest of the panels. Replace the 'return's with 'continue's. Reviewed-by: Rob Clark robdcl...@gmail.com Signed-off-by: Archit Taneja arc...@ti.com --- drivers/gpu/drm/omapdrm

[PATCH v2 2/8] drm/omap: Fix and improve crtc and overlay manager correlation

2013-03-26 Thread Archit Taneja
depending on the sequence in which the panels/outputs are parsed. The optimal way would be some sort of back tracking approach, where we improve the set of managers we use as we iterate through the list of panels/encoders. That's something left for later. Signed-off-by: Archit Taneja arc...@ti.com

[PATCH v3 3/8] drm/omap: Make fixed resolution panels work

2013-03-26 Thread Archit Taneja
that it calls set_timings only if the panel driver has one. Signed-off-by: Archit Taneja arc...@ti.com --- v3: clear the timings local variable first before using memcmp v2: make sure the timings we try to set for a fixed resolution panel match the panel's timings drivers/gpu/drm/omapdrm

[PATCH v2 4/8] omapdss: features: fixed supported outputs for OMAP4

2013-03-26 Thread Archit Taneja
at the DSS level, and we also need to configure the hdmi pll in the DPI driver so that the TV manager has a pixel clock. We don't support that yet. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dss_features.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH v2 5/8] omapdss: DISPC: add max pixel clock limits for LCD and TV managers

2013-03-26 Thread Archit Taneja
the encoder driver. The OMAP2 TRM doesn't mention the maximum pixel clock limit. This value is left as half of DSS_FCLK, as OMAP2 requires the PCD to be atleast 2. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dispc.c | 32 +++- 1 file changed

[PATCH v2 6/8] omapdss: Features: Fix some parameter ranges

2013-03-26 Thread Archit Taneja
the OMAP4 param range struct. Fix the maximum DSS_FCLK on OMAP2, it's 133 Mhz according to the TRM. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dss_features.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/omap2/dss

[PATCH v2 7/8] OMAPDSS: DISPC: Configure doublestride for NV12 when using 2D Tiler buffers

2013-03-26 Thread Archit Taneja
is 0 or 180 degrees. The stride value is the same for 90 and 270 degree Tiler views, hence the bit shouldn't be set. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dispc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/video/omap2

[PATCH v2 8/8] OMAPDSS: DISPC: Revert to older DISPC Smart Standby mechanism for OMAP5

2013-03-26 Thread Archit Taneja
of asserting Mstandby. Configure this field to prevent underflows. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dispc.c |7 +++ drivers/video/omap2/dss/dispc.h |1 + 2 files changed, 8 insertions(+) diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video

Re: [PATCH v3 3/8] drm/omap: Make fixed resolution panels work

2013-03-27 Thread Archit Taneja
On Wednesday 27 March 2013 12:54 PM, Tomi Valkeinen wrote: On 2013-03-26 15:45, Archit Taneja wrote: The omapdrm driver requires omapdss panel drivers to expose ops like detect, set_timings and check_timings. These can be NULL for fixed panel DPI, DBI, DSI and SDI drivers. At some places

Re: [PATCH v2 5/8] omapdss: DISPC: add max pixel clock limits for LCD and TV managers

2013-03-27 Thread Archit Taneja
On Wednesday 27 March 2013 01:00 PM, Tomi Valkeinen wrote: On 2013-03-26 15:45, Archit Taneja wrote: Each version of OMAP has a limitation on the maximum pixel clock frequency supported by an overlay manager. This limit isn't checked by omapdss. Add dispc feats for lcd and tv managers and check

Re: [PATCH v2 6/8] omapdss: Features: Fix some parameter ranges

2013-03-27 Thread Archit Taneja
On Wednesday 27 March 2013 01:03 PM, Tomi Valkeinen wrote: On 2013-03-26 15:45, Archit Taneja wrote: Increase the DSS_FCLK and DSI_FCLK max supported frequencies, these come because some frequencies were increased from OMAP5 ES1 to OMAP5 ES2. We support only OMAP5 ES2 in the kernel, so replace

Re: [PATCH v2 0/8] omapdss/omapdrm: Misc fixes and improvements

2013-03-27 Thread Archit Taneja
On Wednesday 27 March 2013 01:24 PM, Tomi Valkeinen wrote: On 2013-03-26 15:45, Archit Taneja wrote: These are misc fixes and improvements within omapdrm and omapdss. The fixes do the following: - Make omapdrm smarter to choose the right overlay managers as it's crtcs. This makes sure

[PATCH] drm/omap: Take a fb reference in omap_plane_update()

2013-04-09 Thread Archit Taneja
/unreference in update_pin(), which is taken for the scanout of the plane's current framebuffer, and an unreference the previous framebuffer. Signed-off-by: Archit Taneja arc...@ti.com Cc: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/omapdrm/omap_plane.c |6 ++ 1 file changed, 6 insertions

[PATCH] drm: cleanup: use drm_framebuffer_reference instead of a kref_get

2013-04-10 Thread Archit Taneja
drm_framebuffer_lookup() does a kref_get() for the framebuffer if it finds one corresponding to the fb id passed to it. Use drm_framebuffer_reference() instead for clarity since it's the function used in other places to take a reference. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/gpu

[PATCH 3/4] drm: omap: Enable DT support for DMM

2013-09-13 Thread Archit Taneja
Enable use of DT for DMM/Tiler. Originally worked on by Andy Gross. Cc: Andy Gross andy...@gmail.com Cc: DRI Development dri-devel@lists.freedesktop.org Signed-off-by: Archit Taneja arc...@ti.com --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 11 +++ 1 file changed, 11 insertions

Re: [PATCH 3/4] drm: omap: Enable DT support for DMM

2013-09-16 Thread Archit Taneja
On Friday 13 September 2013 07:44 PM, Rob Clark wrote: On Fri, Sep 13, 2013 at 5:14 AM, Archit Taneja arc...@ti.com wrote: Enable use of DT for DMM/Tiler. Originally worked on by Andy Gross. looks good.. but do we want to get information about # of LUT's, etc, from DT? Or did we decide

[PATCH v2 2/2] drm: omap: Enable DT support for DMM

2013-09-16 Thread Archit Taneja
Enable use of DT for DMM/Tiler. Originally worked on by Andy Gross. Cc: Andy Gross andy...@gmail.com Cc: DRI Development dri-devel@lists.freedesktop.org Signed-off-by: Archit Taneja arc...@ti.com --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 11 +++ 1 file changed, 11 insertions

Re: [PATCH] drm: omap: fix: Defer probe if an omapdss device requests for it at connect

2013-09-18 Thread Archit Taneja
On Wednesday 18 September 2013 04:38 PM, Archit Taneja wrote: Some omapdss panels are connected to outputs/encoders(HDMI/DSI/DPI) that require regulators. The output's connect op tries to get a regulator which may not exist yet because it might get registered later in the kernel boot. omapdrm

Re: [PATCH] drm: omap: fix: Defer probe if an omapdss device requests for it at connect

2013-09-18 Thread Archit Taneja
On Wednesday 18 September 2013 06:11 PM, Tomi Valkeinen wrote: On 18/09/13 14:08, Archit Taneja wrote: Some omapdss panels are connected to outputs/encoders(HDMI/DSI/DPI) that require regulators. The output's connect op tries to get a regulator which may not exist yet because it might get

[PATCH 1/2] drm: omap: fix: Defer probe if an omapdss device requests for it at connect

2013-09-19 Thread Archit Taneja
is yet to probe. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/gpu/drm/omapdrm/omap_crtc.c | 5 +++ drivers/gpu/drm/omapdrm/omap_drv.c | 64 - drivers/gpu/drm/omapdrm/omap_drv.h | 1 + 3 files changed, 48 insertions(+), 22 deletions(-) diff --git

[PATCH 2/2] drm: omap: disconnect devices when omapdrm module is removed

2013-09-19 Thread Archit Taneja
omapdrm established connections for omap_dss_device devices when probed. It should also be responsible to disconnect the devices. Keeping the devices connected can prevent the panel driver modules from unloading, it can also cause problems when omapdrm is re-inserted. Signed-off-by: Archit Taneja

Re: [PATCH 2/2] drm: omap: disconnect devices when omapdrm module is removed

2013-09-19 Thread Archit Taneja
Hi, On Thursday 19 September 2013 03:38 PM, Tomi Valkeinen wrote: On 19/09/13 11:49, Archit Taneja wrote: omapdrm established connections for omap_dss_device devices when probed. It should also be responsible to disconnect the devices. Keeping the devices connected can prevent the panel driver

Re: [PATCH 39/51] DMA-API: others: use dma_set_coherent_mask()

2013-09-26 Thread Archit Taneja
On Thursday 26 September 2013 04:25 PM, Russell King - ARM Linux wrote: On Thu, Sep 26, 2013 at 04:21:36PM +0530, Archit Taneja wrote: Hi, On Friday 20 September 2013 04:41 AM, Russell King wrote: The correct way for a driver to specify the coherent DMA mask is not to directly access

Re: [PATCH 39/51] DMA-API: others: use dma_set_coherent_mask()

2013-09-26 Thread Archit Taneja
Hi, On Friday 20 September 2013 04:41 AM, Russell King wrote: The correct way for a driver to specify the coherent DMA mask is not to directly access the field in the struct device, but to use dma_set_coherent_mask(). Only arch and bus code should access this member directly. Convert all

[PATCH v2 0/2] drm: omap: Fix omapdrm probe and module insertion/removal issues

2013-10-07 Thread Archit Taneja
disable in the omap_encoder_destroy() op, I needed some suggestions on whether there is a better way to do this. changes in v2: - Add special case when no panels are available to connect. - Make sure panels are diabled (and then disconnected) when omapdrm is removed Archit Taneja (2): drm: omap

[PATCH v2 1/2] drm: omap: fix: Defer probe if an omapdss device requests for it at connect

2013-10-07 Thread Archit Taneja
boot with omapdrm on an omap4 panda ES board. The regulators used by HDMI aren't initialized because I2c isn't initialized, I2C isn't initialized as it's pins are not configured because pinctrl is yet to probe. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/gpu/drm/omapdrm/omap_crtc.c | 5

[PATCH v2 2/2] drm: omap: disconnect devices when omapdrm module is removed

2013-10-07 Thread Archit Taneja
to prevent this, would appreciate some help here. Signed-off-by: Archit Taneja arc...@ti.com --- drivers/gpu/drm/omapdrm/omap_drv.c | 15 +++ drivers/gpu/drm/omapdrm/omap_encoder.c | 3 +++ 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm

Re: [PATCH v2 0/2] drm: omap: Fix omapdrm probe and module insertion/removal issues

2013-10-09 Thread Archit Taneja
Hi Rob, On Monday 07 October 2013 03:08 PM, Archit Taneja wrote: With the new omapdss device model. The user(omapdrm/omapfb) of a omap_dss_device has to call connect() to use the device. A connect() call can request to defer probe if the device(or the previous entities in the chain) have

[PATCH v3 2/2] drm: omap: Enable DT support for DMM

2013-10-10 Thread Archit Taneja
Enable use of DT for DMM/Tiler. Originally worked on by Andy Gross andy...@gmail.com Cc: Andy Gross andy...@gmail.com Cc: DRI Development dri-devel@lists.freedesktop.org Signed-off-by: Archit Taneja arc...@ti.com --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 11 +++ 1 file changed, 11

[PATCH v4 2/2] drm: omap: Enable DT support for DMM

2013-10-15 Thread Archit Taneja
Enable use of DT for DMM/Tiler. Originally worked on by Andy Gross andy...@gmail.com Cc: Andy Gross andy...@gmail.com Cc: DRI Development dri-devel@lists.freedesktop.org Signed-off-by: Archit Taneja arc...@ti.com --- drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 11 +++ 1 file changed, 11

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-01 Thread Archit Taneja
On 01/30/2017 10:35 PM, Jani Nikula wrote: On Sat, 28 Jan 2017, Peter Senna Tschudin <peter.se...@collabora.com> wrote: On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote: Hi Archit, Thank you for the comments! [...] + total_size = (block[EDID_EXT_BLOCK_CN

Re: [PATCH 3/4] drm/bridge: Drivers for megachips-stdpxxxx-ge-b850v3-fw (LVDS-DP++)

2017-02-01 Thread Archit Taneja
;airl...@linux.ie> Cc: Thierry Reding <tred...@nvidia.com> Cc: Thierry Reding <thierry.red...@gmail.com> Cc: Archit Taneja <arch...@codeaurora.org> Cc: Enric Balletbo <enric.balle...@collabora.com> Signed-off-by: Peter Senna Tschudin <peter.se...@collabora.c

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-02 Thread Archit Taneja
On 02/01/2017 05:51 PM, Peter Senna Tschudin wrote: On 01 February, 2017 12:35 CET, Daniel Vetter <dan...@ffwll.ch> wrote: On Wed, Feb 01, 2017 at 10:58:43AM +, Peter Senna Tschudin wrote: Hi Archit, On 01 February, 2017 10:44 CET, Archit Taneja <arch...@codeaurora.o

Re: [PATCH v3 00/25] drm/bridge/sii8620: add Ultra HD modes support

2017-02-02 Thread Archit Taneja
On 02/01/2017 01:17 PM, Andrzej Hajda wrote: Hi Archit, Sorry for spamming, forgot to add the list. This quite big patchset adds support for 4K Ultra HD modes in SiI8620 MHL bridge. To support it full MHL3 protocol and its sub-protocols should be implemented. Patchset contains also various

Re: [PATCH v2 19.1/25] drm/bridge/mhl: add MHL3 infoframe related definitions

2017-01-31 Thread Archit Taneja
On 01/26/2017 07:20 PM, Andrzej Hajda wrote: MHL3 protocol uses vendor specific infoframes to transmit additional information to the sink. This patch adds definitions of structures and constants used to create such frames. Signed-off-by: Andrzej Hajda ---

Re: [PATCH 05/11] drm/msm: get an iova from the address space instead of an id

2017-02-08 Thread Archit Taneja
goto fail_unlock; + } This check isn't needed. As of now, we don't create a fbdev device if we don't have kms initialized. Otherwise, Reviewed-by: Archit Taneja <arch...@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collabora

Re: [PATCH 10/10] drm/msm/dsi: Add PHY/PLL for 8x96

2017-01-22 Thread Archit Taneja
On 01/20/2017 01:47 AM, Stephen Boyd wrote: On 01/07, Archit Taneja wrote: + +static struct clk *pll_14nm_postdiv_register(struct dsi_pll_14nm *pll_14nm, +const char *name, +const char *parent_name

Re: [PATCH 07/24] drm/bridge/sii8620: add support for burst eMSC transmissions

2017-01-23 Thread Archit Taneja
On 01/20/2017 01:08 PM, Andrzej Hajda wrote: Burst transmissions are used in MHL3 mode negotiation. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/bridge/sil-sii8620.c | 196 ++- drivers/gpu/drm/bridge/sil-sii8620.h | 4 + 2 files

Re: [PATCH 19/24] drm/bridge/sii8620: rewrite hdmi start sequence

2017-01-23 Thread Archit Taneja
On 01/20/2017 01:08 PM, Andrzej Hajda wrote: MHL3 protocol requires registry adjustments depending on chosen video mode. Necessary information is gathered in mode_fixup callback. In case of HDMI video modes driver should also send special AVI and MHL infoframes. Signed-off-by: Andrzej Hajda

Re: [PATCH 04/24] drm/bridge/sii8620: add continuations to messages

2017-01-23 Thread Archit Taneja
On 01/20/2017 01:08 PM, Andrzej Hajda wrote: Due to asynchronous nature of MHL flow of execution is dispersed. Logical continuation of some actions happens after response of peer, i.e in interrupt handler. To simplify coding continuation mechanism has been added - it is now possible to provide

Re: [PATCH 19/24] drm/bridge/sii8620: rewrite hdmi start sequence

2017-01-24 Thread Archit Taneja
On 01/23/2017 04:42 PM, Andrzej Hajda wrote: On 23.01.2017 10:17, Archit Taneja wrote: On 01/20/2017 01:08 PM, Andrzej Hajda wrote: MHL3 protocol requires registry adjustments depending on chosen video mode. Necessary information is gathered in mode_fixup callback. In case of HDMI video

Re: [PATCH 04/24] drm/bridge/sii8620: add continuations to messages

2017-01-23 Thread Archit Taneja
On 01/23/2017 04:03 PM, Andrzej Hajda wrote: On 23.01.2017 09:31, Archit Taneja wrote: On 01/20/2017 01:08 PM, Andrzej Hajda wrote: Due to asynchronous nature of MHL flow of execution is dispersed. Logical continuation of some actions happens after response of peer, i.e in interrupt handler

Re: [PATCH] drm: bridge: dw-hdmi: fix building without CONFIG_OF

2017-01-23 Thread Archit Taneja
On 01/23/2017 05:50 PM, Arnd Bergmann wrote: The of_node member in struct drm_bridge is hidden when CONFIG_OF is disabled, causing a build error: drivers/gpu/drm/bridge/dw-hdmi.c: In function '__dw_hdmi_probe': drivers/gpu/drm/bridge/dw-hdmi.c:2063:14: error: 'struct drm_bridge' has no

Re: [PATCH] drm/bridge: analogix dp: Fix runtime PM state on driver bind

2017-01-23 Thread Archit Taneja
Hi, On 01/23/2017 10:58 PM, Javier Martinez Canillas wrote: Hello Archit, On 01/09/2017 06:47 AM, Archit Taneja wrote: On 01/05/2017 01:01 PM, Sean Paul wrote: On Fri, Dec 30, 2016 at 4:57 AM, Marek Szyprowski <m.szyprow...@samsung.com> wrote: Analogix_dp_bind() can be calle

Re: [PATCH 17/24] drm/bridge/sii8620: split EDID read and write code

2017-01-24 Thread Archit Taneja
On 01/20/2017 01:08 PM, Andrzej Hajda wrote: MHL3 requires that after reading EDID from the sink source should ask peer for features. To make both protocols happy the patch splits the code accordingly. I was wondering about the EDID code in the driver, what does it exactly do with the EDID?

Re: [PATCH 17/24] drm/bridge/sii8620: split EDID read and write code

2017-01-25 Thread Archit Taneja
On 01/24/2017 05:09 PM, Andrzej Hajda wrote: On 24.01.2017 11:31, Archit Taneja wrote: On 01/20/2017 01:08 PM, Andrzej Hajda wrote: MHL3 requires that after reading EDID from the sink source should ask peer for features. To make both protocols happy the patch splits the code accordingly. I

Re: [PATCH 02/15] drm/bridge: Use recommened kerneldoc for struct member refs

2017-01-25 Thread Archit Taneja
drive-by polish where it makes sense, I read a lot of docs ... This seems like a leftover from the older version of the patch, which we decided to not take. I guess we could drop it. Archit Cc: Archit Taneja <arch...@codeaurora.org> Cc: Jani Nikula <jani.nik...@linux.intel.com&g

[PATCH v2 10/10] drm/msm/dsi: Add PHY/PLL for 8x96

2017-01-24 Thread Archit Taneja
org> Signed-off-by: Archit Taneja <arch...@codeaurora.org> --- v2: - Use clk_hw_register/add_hw_provider funcs instead - Fix some build warnings on arm32 caught by kbuild drivers/gpu/drm/msm/Kconfig|7 + drivers/gpu/drm/msm/Makefile |2 + drivers/gpu

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

2017-02-21 Thread Archit Taneja
On 02/22/2017 05:31 AM, Pandiyan, Dhinakaran wrote: On Fri, 2017-02-17 at 15:37 +0530, Archit Taneja wrote: On 02/16/2017 05:43 AM, Pandiyan, Dhinakaran wrote: On Wed, 2017-02-15 at 16:53 +0530, Archit Taneja wrote: Hi, On 02/09/2017 12:08 PM, Dhinakaran Pandiyan wrote: It is necessary

[PATCH] drm/doc: Fix up some kms function names

2017-02-22 Thread Archit Taneja
A couple of the kms functions didn't have the correct/newest names. This prevented them to be identified as refs in the html doc. Signed-off-by: Archit Taneja <arch...@codeaurora.org> --- include/drm/drm_mode_config.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH -next] drm/bridge/tfp410: Make symbol tfp410_platform_driver static

2017-02-14 Thread Archit Taneja
On 2/9/2017 8:55 PM, Wei Yongjun wrote: From: Wei Yongjun Fixes the following sparse warning: drivers/gpu/drm/bridge/ti-tfp410.c:223:24: warning: symbol 'tfp410_platform_driver' was not declared. Should it be static? This was queued to drm-misc-next Thanks,

Re: [PATCH v3 4/8] drm: Add driver-private objects to atomic state

2017-02-15 Thread Archit Taneja
Hi, On 02/09/2017 12:08 PM, Dhinakaran Pandiyan wrote: It is necessary to track states for objects other than connector, crtc and plane for atomic modesets. But adding objects like DP MST link bandwidth to drm_atomic_state would mean that a non-core object will be modified by the core helper

Re: [bug report] drm/msm/dsi: Move PHY operations out of host

2017-02-12 Thread Archit Taneja
On 02/11/2017 10:47 AM, Dan Carpenter wrote: Hello Hai Li, This is a semi-automatic email about new static checker warnings. The patch b62aa70a98c5: "drm/msm/dsi: Move PHY operations out of host" from Jan 7, 2017, leads to the following Smatch complaint:

[PATCH] drm/msm/dsi: Fix bug in dsi_mgr_phy_enable

2017-02-16 Thread Archit Taneja
) corresponding to the current bridge. Usage of the wrong DSI pointer also resulted in a static checker warning. That too is resolved with this fix. Fixes: b62aa70a98c5 (drm/msm/dsi: Move PHY operations out of host) Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Archit Taneja

Re: [PATCH v2 5/6] drm: convert drivers to use drm_of_find_panel_or_bridge

2017-02-13 Thread Archit Taneja
depending on the particular board, so we want to avoid spurious messages. Plus the kernel is not a DT validator. For the bridge drivers: Reviewed-by: Archit Taneja <arch...@codeaurora.org> Thanks, Archit Signed-off-by: Rob Herring <r...@kernel.org> --- v2: - fix wrong node ptr in

Re: [PATCH v2 4/6] drm: convert drivers to use of_graph_get_remote_node

2017-02-13 Thread Archit Taneja
the kernel is not a DT validator. For the msm and adv75xx driver: Tested by: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Rob Herring <r...@kernel.org> Acked-by: Neil Armstrong <narmstr...@baylibre.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> Tested-by

Re: [PATCH v2 3/6] drm: of: introduce drm_of_find_panel_or_bridge

2017-02-13 Thread Archit Taneja
On 02/10/2017 12:35 AM, Rob Herring wrote: Many drivers have a common pattern of searching the OF graph for either an attached panel or bridge and then finding the DRM struct for the panel or bridge. Also, most drivers need to handle deferred probing when the DRM device is not yet

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

2017-02-17 Thread Archit Taneja
On 02/16/2017 05:43 AM, Pandiyan, Dhinakaran wrote: On Wed, 2017-02-15 at 16:53 +0530, Archit Taneja wrote: Hi, On 02/09/2017 12:08 PM, Dhinakaran Pandiyan wrote: It is necessary to track states for objects other than connector, crtc and plane for atomic modesets. But adding objects like DP

Re: [PATCH 0/6 v4] adv7511 EDID probing improvements

2017-01-18 Thread Archit Taneja
weaked connector.status assignment to avoid race, as suggested by Laurent * Reworked the __adv7511_power_on helpers to avoid calling regcache_sync in the EDID probe path * Added new patch to set EDID_I2C_ADDR register before doing EDID read. Cc: David Airlie <airl...@linux.ie> Cc: Archit

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-24 Thread Archit Taneja
On 10/22/2016 12:13 AM, Russell King - ARM Linux wrote: > On Thu, Oct 20, 2016 at 04:56:44PM +0530, Archit Taneja wrote: >> >> >> On 10/20/2016 02:45 PM, Russell King - ARM Linux wrote: >>> On Thu, Oct 20, 2016 at 02:38:25PM +0530, Archit Taneja wrote: >>

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-24 Thread Archit Taneja
On 10/21/2016 11:39 PM, Russell King - ARM Linux wrote: > On Thu, Oct 20, 2016 at 04:56:44PM +0530, Archit Taneja wrote: >> 3) Rough conversion to bridge: > > So I thought I might give this a try, and see what's needed to complete > the patch, but... > > I thought we'

[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

2016-10-24 Thread Archit Taneja
On 10/22/2016 03:25 PM, Russell King - ARM Linux wrote: > On Fri, Oct 21, 2016 at 09:04:39PM +0200, Jean-Francois Moine wrote: >> On Wed, Oct 19, 2016 at 12:19:30PM +0300, Laurent Pinchart wrote: >> (sorry, I lost your original mail) >> DRM bridges indeed don't create encoders. That

[PATCH v2 1/6] drm/msm/mdp5: Use per-plane rotation property

2016-10-24 Thread Archit Taneja
o me. Thanks, Archit > > v2: Drop the BIT() > > Cc: Rob Clark > Cc: Jilai Wang > Cc: Archit Taneja > Signed-off-by: Ville Syrjälä > Reviewed-by: Rob Clark > --- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 14 +- > 1 file changed, 5 inserti

[PATCH v2 1/6] drm/msm/mdp5: Use per-plane rotation property

2016-10-24 Thread Archit Taneja
On 10/24/2016 03:45 PM, Ville Syrjälä wrote: > On Mon, Oct 24, 2016 at 03:33:18PM +0530, Archit Taneja wrote: >> Hi Ville, >> >> On 10/22/2016 12:52 AM, ville.syrjala at linux.intel.com wrote: >>> From: Ville Syrjälä >>> >>> The global mod

[PATCH v2 1/6] drm/msm/mdp5: Use per-plane rotation property

2016-10-24 Thread Archit Taneja
On 10/24/2016 03:55 PM, Ville Syrjälä wrote: > On Mon, Oct 24, 2016 at 03:52:09PM +0530, Archit Taneja wrote: >> >> >> On 10/24/2016 03:45 PM, Ville Syrjälä wrote: >>> On Mon, Oct 24, 2016 at 03:33:18PM +0530, Archit Taneja wrote: >>>>

[PATCH 3/3] drm/bridge: Add ITE IT6251 bridge driver

2016-10-25 Thread Archit Taneja
Hi, On 10/17/2016 10:03 PM, Marek Vasut wrote: > Add driver for the ITE IT6251 LVDS-to-eDP bridge. > > Signed-off-by: Marek Vasut > Cc: Daniel Vetter > Cc: Sean Cross > --- > drivers/gpu/drm/bridge/Kconfig | 9 + > drivers/gpu/drm/bridge/Makefile | 1 + >

[PATCH 0/2] drm/msm: Fixes for issues seen on DB410c

2016-10-25 Thread Archit Taneja
clocks enabled. The other reason is a deadlock caused by calling drm_hpd_helper_irq_event in a context that might already hold drm_device's mode_config.mutex. Archit Taneja (2): drm/msm/dsi: Queue HPD helper work in attach/detach callbacks drm/msm: Don't provide 'is_enabled' PLL clk_ops

[PATCH 1/2] drm/msm/dsi: Queue HPD helper work in attach/detach callbacks

2016-10-25 Thread Archit Taneja
instead. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi_host.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index f05ed0e..6f24002 100644 --- a/drivers/gpu/drm/msm/dsi

[PATCH 2/2] drm/msm: Don't provide 'is_enabled' PLL clk_ops

2016-10-25 Thread Archit Taneja
domains beforehand. We remove the is_enabled clk_ops from the PLL clocks for now since they aren't mandatory. This needs to be revisited, since bootloaders can enable display, the enable count maintained by clock framework wouldn't work in such cases. Cc: Stephen Boyd Signed-off-by: Archit Taneja

[PATCH v2 1/8] drm/bridge: rgb-to-vga: Support an enable GPIO

2016-10-25 Thread Archit Taneja
Hi, On 10/20/2016 09:13 AM, Chen-Yu Tsai wrote: > Some rgb-to-vga bridges have an enable GPIO, either directly tied to > an enable pin on the bridge IC, or indirectly controlling a power > switch. > > Add support for it. Does the bridge on your platform have an active/passive DAC, or is it a

[PATCH v2 8/8] ARM: dts: sun6i: hummingbird-a31: Enable display output through VGA bridge

2016-10-25 Thread Archit Taneja
On 10/20/2016 09:13 AM, Chen-Yu Tsai wrote: > The Hummingbird A31 board has a RGB-to-VGA bridge which converts RGB > output from the LCD interface to VGA signals. > > Enable this part of the display pipeline. I couldn't find the enable-gpios binding for the bridge that you introduced in the

[PATCH v5 3/3] drm/bridge: add Silicon Image SiI8620 driver

2016-10-26 Thread Archit Taneja
Hi Andrzej, On 10/10/2016 01:09 PM, Andrzej Hajda wrote: > SiI8620 transmitter converts eTMDS/HDMI signal to MHL 3.0. > It is controlled via I2C bus. Its interaction with other > devices in video pipeline is performed mainly on HW level. > The only interaction it does on device driver level is >

[PATCH 2/2] drm/msm: Don't provide 'is_enabled' PLL clk_ops

2016-10-26 Thread Archit Taneja
On 10/26/2016 01:58 AM, Stephen Boyd wrote: > On 10/25, Archit Taneja wrote: >> The DSI/HDMI PLLs in MSM require resources like interface clocks, power >> domains to be enabled before we can access their registers. >> >> The clock framework doesn't have a mechanism

[PATCH v4 1/3] video: add header file for Mobile High-Definition Link (MHL) interface

2016-10-26 Thread Archit Taneja
On 10/07/2016 12:32 PM, Andrzej Hajda wrote: > This header adds definitions specific to MHL protocol. queued to drm-misc. Thanks, Archit -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

[PATCH v4 2/3] dt-bindings: add Silicon Image SiI8620 bridge bindings

2016-10-26 Thread Archit Taneja
On 10/07/2016 12:32 PM, Andrzej Hajda wrote: > SiI8620 transmitter converts eTMDS/HDMI signal to MHL 3.0. It is controlled > via I2C bus. queued to drm-misc. Thanks, Archit > > Signed-off-by: Andrzej Hajda > Acked-by: Rob Herring > --- > .../bindings/video/bridge/sil-sii8620.txt |

[PATCH v5 3/3] drm/bridge: add Silicon Image SiI8620 driver

2016-10-26 Thread Archit Taneja
On 10/10/2016 01:09 PM, Andrzej Hajda wrote: > SiI8620 transmitter converts eTMDS/HDMI signal to MHL 3.0. > It is controlled via I2C bus. Its interaction with other > devices in video pipeline is performed mainly on HW level. > The only interaction it does on device driver level is >

[PATCH v2 2/2] drm/msm: Set CLK_IGNORE_UNUSED flag for PLL clocks

2016-10-27 Thread Archit Taneja
domains beforehand. We set the CLK_IGNORE_UNUSED flag for PLL clocks for now. This needs to be revisited, since bootloaders can enable display, and we would want to disable the PLL clocks if there isn't a display driver using them. Cc: Stephen Boyd Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm

[PATCH v2 1/8] drm/bridge: rgb-to-vga: Support an enable GPIO

2016-10-27 Thread Archit Taneja
On 10/25/2016 02:29 PM, Chen-Yu Tsai wrote: > On Tue, Oct 25, 2016 at 4:09 PM, Archit Taneja > wrote: >> Hi, >> >> On 10/20/2016 09:13 AM, Chen-Yu Tsai wrote: >>> >>> Some rgb-to-vga bridges have an enable GPIO, either directly tied to >>

[PATCH 2/3] drm/bridge: adv7533: Initialize regulators

2016-09-01 Thread Archit Taneja
On 09/01/2016 02:00 AM, Laurent Pinchart wrote: > Hi Archit, > > On Wednesday 31 Aug 2016 22:24:30 Archit Taneja wrote: >> On 8/31/2016 9:23 PM, Laurent Pinchart wrote: >>> On Wednesday 31 Aug 2016 16:22:09 Archit Taneja wrote: >>>> ADV7533 requires su

  1   2   3   4   5   6   7   8   9   10   >