Re: [PATCH v2 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-04-17 Thread Enric Balletbo i Serra
Hi Laurent, On 16/4/20 19:36, Laurent Pinchart wrote: > Hi Enric, > > On Thu, Apr 16, 2020 at 08:35:26PM +0300, Laurent Pinchart wrote: >> On Thu, Apr 16, 2020 at 05:57:19PM +0200, Enric Balletbo i Serra wrote: >>> Use the drm_bridge_connector helper to create a connecto

[PATCH v2 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-04-17 Thread Enric Balletbo i Serra
Replace the manual panel handling code by a drm_panel_bridge. This simplifies the driver and allows all components in the display pipeline to be treated as bridges, paving the way to generic connector handling. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Do not set connector_type

[PATCH v2 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-04-17 Thread Enric Balletbo i Serra
Convert mtk_dsi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/gpu/drm/mediatek/mtk_dsi.c | 106 ++--- 1 file changed, 68 insertions(+), 38

[PATCH v2 1/7] drm/bridge: ps8640: Get the EDID from eDP control

2020-04-17 Thread Enric Balletbo i Serra
The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the .get_edid callback and set the flag to indicate the core to use it. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/gpu/drm/bridge/parade-ps8640.c | 12 1 file changed, 12 insertions

[PATCH v2 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-04-17 Thread Enric Balletbo i Serra
. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/gpu/drm/mediatek/mtk_dsi.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 44718fa3d1ca..2f8876c32864 100644

[PATCH v2 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-04-17 Thread Enric Balletbo i Serra
kernel.org/lkml/20200210063523.13-1-hsi...@chromium.org/ Changes in v2: - Do not set connector_type for panel here. (Sam Ravnborg) Enric Balletbo i Serra (7): drm/bridge: ps8640: Get the EDID from eDP control drm/bridge_connector: Set default status connected for eDP connectors drm/mediatek:

[PATCH v2 2/7] drm/bridge_connector: Set default status connected for eDP connectors

2020-04-17 Thread Enric Balletbo i Serra
In an eDP application, HPD is not required and on most bridge chips useless. If HPD is not used, we need to set initial status as connected, otherwise the connector created by the drm_bridge_connector API remains in an unknown state. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None

[PATCH v2 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-04-17 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None

[PATCH v3 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-04-18 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent

[PATCH v3 5/7] drm/mediatek: mtk_dsi: Use simple encoder

2020-04-18 Thread Enric Balletbo i Serra
The mtk_dsi driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart --- Changes in v3: None Changes in v2: None drivers/gpu/drm/mediatek/mtk_dsi.c | 14 +++--- 1 file

Re: [PATCH v2 1/7] drm/bridge: ps8640: Get the EDID from eDP control

2020-04-18 Thread Enric Balletbo i Serra
Hi Laurent, On 16/4/20 19:22, Laurent Pinchart wrote: > Hi Enric, > > Thank you for the patch. > > On Thu, Apr 16, 2020 at 05:57:13PM +0200, Enric Balletbo i Serra wrote: >> The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the >> .get_edid callback a

Re: [PATCH v2 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-04-18 Thread Enric Balletbo i Serra
Hi Laurent, On 16/4/20 19:24, Laurent Pinchart wrote: > Hi Enric, > > Thank you for the patch. > > On Thu, Apr 16, 2020 at 05:57:15PM +0200, Enric Balletbo i Serra wrote: >> This is really a cosmetic change just to make a bit more readable the >> code after convert th

[PATCH v3 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-04-18 Thread Enric Balletbo i Serra
patch requires https://lkml.org/lkml/2020/4/16/2080 to work properly. - Move the bridge.type line to the patch that adds drm_bridge support. (Laurent Pinchart) Changes in v2: - Do not set connector_type for panel here. (Sam Ravnborg) Enric Balletbo i Serra (7): drm/bridge: ps8640: Get th

[PATCH v3 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-04-18 Thread Enric Balletbo i Serra
. Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Move the bridge.type line to the patch that adds drm_bridge support. (Laurent Pinchart) Changes in v2: None drivers/gpu/drm/mediatek/mtk_dsi.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH v3 1/7] drm/bridge: ps8640: Get the EDID from eDP control

2020-04-18 Thread Enric Balletbo i Serra
The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the .get_edid callback and set the flag to indicate the core to use it. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart --- Changes in v3: None Changes in v2: None drivers/gpu/drm/bridge/parade-ps8640.c | 12

[PATCH v3 2/7] drm/bridge_connector: Set default status connected for eDP connectors

2020-04-18 Thread Enric Balletbo i Serra
In an eDP application, HPD is not required and on most bridge chips useless. If HPD is not used, we need to set initial status as connected, otherwise the connector created by the drm_bridge_connector API remains in an unknown state. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent

[PATCH v3 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-04-18 Thread Enric Balletbo i Serra
Replace the manual panel handling code by a drm_panel_bridge. This simplifies the driver and allows all components in the display pipeline to be treated as bridges, paving the way to generic connector handling. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart --- Changes in

[PATCH v3 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-04-18 Thread Enric Balletbo i Serra
Convert mtk_dsi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Add the bridge.type. (Laurent Pinchart) Changes in v2: None drivers/gpu/drm/mediatek/mtk_dsi.c | 93

Re: [PATCH v3 0/1] drm/bridge: ps8640: Make sure all needed is powered to get the EDID

2020-09-15 Thread Enric Balletbo i Serra
Hi Sam, On 27/8/20 10:59, Enric Balletbo i Serra wrote: > The first 4 patches of the series version 2: > - drm/bridge_connector: Set default status connected for eDP connectors > - drm/bridge: ps8640: Get the EDID from eDP control > - drm/bridge: ps8640: Return an error for inco

Re: [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume

2020-09-29 Thread Enric Balletbo i Serra
ume’ defined but not used > 1124 | static int cdn_dp_resume(struct device *dev) > |^ > > Fix this by defining cdn_dp_resume __maybe_unused > > Signed-off-by: Sam Ravnborg > Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make > cdn_dp_cor

[PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'

2020-10-06 Thread Enric Balletbo i Serra
ct drm_encoder_funcs mtk_dpi_encoder_funcs = { This struct is and the 'mtk_dpi_encoder_destroy()' are not needed anymore, so remove them. Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver") Reported-by: kernel test robot Signed-off-by: Enric Balletbo i Serra ---

[PATCH 1/4] soc / drm: mediatek: Move DDP component defines into mtk-mmsys.h

2020-10-07 Thread Enric Balletbo i Serra
From: Yongqiang Niu MMSYS is the driver which controls the routing of these DDP components, so the definition of the mtk_ddp_comp_id enum should be placed in mtk-mmsys.h Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra --- This patch was

[PATCH 0/4] soc: mediatek: Prepare MMSYS for DDP routing using tables

2020-10-07 Thread Enric Balletbo i Serra
reate struct mtk_mmsys to store context data soc: mediatek: mmsys: Use an array for setting the routing registers Enric Balletbo i Serra (1): soc: mediatek: mmsys: Use devm_platform_ioremap_resource() Yongqiang Niu (1): soc / drm: mediatek: Move DDP component defines into mtk-mmsys.h driver

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-08-22 Thread Enric Balletbo i Serra
Dear drm_bridge maintainers, It's been a while since I send these patches, and I'd like to find a proper solution. On 25/6/20 11:21, Enric Balletbo i Serra wrote: > Hi Sam, > > On 24/6/20 9:07, Sam Ravnborg wrote: >> Hi Enric. >> >> On Tue, Jun 23, 2020

[PATCH v2 1/5] drm/bridge_connector: Set default status connected for eDP connectors

2020-08-26 Thread Enric Balletbo i Serra
-off-by: Enric Balletbo i Serra --- Changes in v2: - Included the patch `drm/bridge_connector: Set default status connected for eDP connectors` drivers/gpu/drm/drm_bridge_connector.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm

[RESEND PATCH v2 1/2] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-08-26 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Reviewed-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra

[PATCH v2 5/5] drm/bridge: ps8640: Rework power state handling

2020-08-26 Thread Enric Balletbo i Serra
o a power on cycle on this device. Otherwise the device fails to retrieve the EDID. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg) drivers/gpu/drm/bridge/parade-ps8640.c | 64 +++--- 1 fil

Re: [PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-08-26 Thread Enric Balletbo i Serra
Hi Bilal, On 24/8/20 21:01, Bilal Wasim wrote: > Hi Chun-Kuan, Enric, > > Is there any plan to merge the following commits in this series to the > mainline? > > drm/bridge: ps8640: Get the EDID from eDP control > drm/bridge_connector: Set default status connected for eDP connectors > Just

[RESEND PATCH v2 2/2] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-08-26 Thread Enric Balletbo i Serra
Convert mtk_dpi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Reviewed-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Maintain error message when attach to bridge fails. (Boris) drivers/gpu/drm/mediatek

[PATCH v2 2/5] drm/bridge: ps8640: Get the EDID from eDP control

2020-08-26 Thread Enric Balletbo i Serra
The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the .get_edid callback and set the flag to indicate the core to use it. Reviewed-by: Laurent Pinchart Acked-by: Sam Ravnborg Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Included the patch `drm/bridge: ps8640: Get

[PATCH v2 3/5] drm/bridge: ps8640: Return an error for incorrect attach flags

2020-08-26 Thread Enric Balletbo i Serra
Bridge drivers that implement the new model only shall return an error from their attach() handler when the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is not set. So make sure we return an error because only the new drm_bridge model is supported. Reviewed-by: Sam Ravnborg Signed-off-by: Enric Balletbo

[PATCH v2 0/5] drm/bridge: ps8640: Make sure all needed is powered to get the EDID

2020-08-26 Thread Enric Balletbo i Serra
/1208 Changes in v2: - Included the patch `drm/bridge_connector: Set default status connected for eDP connectors` - Included the patch `drm/bridge: ps8640: Get the EDID from eDP control` - Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg) Enric Balletbo i Serra (5): drm

[PATCH v2 4/5] drm/bridge: ps8640: Print an error if VDO control fails

2020-08-26 Thread Enric Balletbo i Serra
Print an error message inside ps8640_bridge_vdo_control() function when it fails so we can simplify a bit the callers, they will only need to check the error code. Reviewed-by: Sam Ravnborg Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/gpu/drm/bridge/parade-ps8640.c

[RESEND PATCH v2 0/2] Convert mtk-dpi to drm_bridge API

2020-08-26 Thread Enric Balletbo i Serra
fails. (Boris) Enric Balletbo i Serra (2): drm/mediatek: mtk_dpi: Rename bridge to next_bridge drm/mediatek: mtk_dpi: Convert to bridge driver drivers/gpu/drm/mediatek/mtk_dpi.c | 77 +- 1 file changed, 45 insertions(+), 32 deletions(-) -- 2.28.0

Re: [PATCH v2 5/5] drm/bridge: ps8640: Rework power state handling

2020-08-28 Thread Enric Balletbo i Serra
Hi Sam, Thanks for your comments. On 26/8/20 20:46, Sam Ravnborg wrote: > Hi Enric. > > On Wed, Aug 26, 2020 at 10:15:26AM +0200, Enric Balletbo i Serra wrote: >> The get_edid() callback can be triggered anytime by an ioctl, i.e >> >> d

[PATCH v3 1/1] drm/bridge: ps8640: Rework power state handling

2020-08-28 Thread Enric Balletbo i Serra
o a power on cycle on this device. Otherwise the device fails to retrieve the EDID. Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Make poweron/poweroff and pre_enable/post_disable reverse one to each other (Sam Ravnborg) Changes in v2: - Use drm_bridge_chain_pre_enable/pos

[PATCH v3 0/1] drm/bridge: ps8640: Make sure all needed is powered to get the EDID

2020-08-28 Thread Enric Balletbo i Serra
failed as explained in the third patch. [1] https://lkml.org/lkml/2020/6/15/1208 Changes in v3: - Make poweron/poweroff and pre_enable/post_disable reverse one to each other (Sam Ravnborg) Changes in v2: - Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg) Enric Balletbo i

Re: [PATCH v3 1/1] drm/bridge: ps8640: Rework power state handling

2020-09-01 Thread Enric Balletbo i Serra
Hi Bilal, On 31/8/20 11:32, Bilal Wasim wrote: > > Hi Enric, > > On Thu, 27 Aug 2020 10:59:11 +0200 > Enric Balletbo i Serra wrote: > >> The get_edid() callback can be triggered anytime by an ioctl, i.e >> >> drm_mode_getconnector (ioctl) >>

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Enric Balletbo i Serra
Hi Chun-Kuang, On 14/5/20 18:44, Chun-Kuang Hu wrote: > Hi, Enric: > > Enric Balletbo i Serra 於 2020年5月14日 週四 > 下午11:42寫道: >> >> Hi Chun-Kuang, >> >> On 14/5/20 16:28, Chun-Kuang Hu wrote: >>> Hi, Enric: >>> >>> Enric Bal

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Enric Balletbo i Serra
Hi Chun-Kuang, On 14/5/20 16:28, Chun-Kuang Hu wrote: > Hi, Enric: > > Enric Balletbo Serra 於 2020年5月14日 週四 上午12:41寫道: >> >> Hi Chun-Kuang, >> >> Missatge de Enric Balletbo i Serra del >> dia dv., 1 de maig 2020 a les 17:25: >>> >>> Use

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Enric Balletbo i Serra
Hi again, On 14/5/20 19:12, Enric Balletbo i Serra wrote: > Hi Chun-Kuang, > > On 14/5/20 18:44, Chun-Kuang Hu wrote: >> Hi, Enric: >> >> Enric Balletbo i Serra 於 2020年5月14日 週四 >> 下午11:42寫道: >>> >>> Hi Chun-Kuang, >>> >>> O

[RESEND PATCH 0/3] Convert mtk-dpi to drm_bridge API

2020-05-19 Thread Enric Balletbo i Serra
://lore.kernel.org/patchwork/project/lkml/list/?series=441559 Enric Balletbo i Serra (3): drm/mediatek: mtk_dpi: Rename bridge to next_bridge drm/mediatek: mtk_dpi: Convert to bridge driver drm/mediatek: mtk_dpi: Use simple encoder drivers/gpu/drm/mediatek/mtk_dpi.c | 84

Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data

2020-05-19 Thread Enric Balletbo i Serra
done later already, just delete the call to > of_device_get_match_data. > > Signed-off-by: Matthias Brugger Reviewed-by: Enric Balletbo i Serra > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/m

[RESEND PATCH 1/3] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-05-19 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu

[RESEND PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder

2020-05-19 Thread Enric Balletbo i Serra
The mtk_dpi driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions

[RESEND PATCH 2/3] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-05-19 Thread Enric Balletbo i Serra
Convert mtk_dpi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 66 +++--- 1 file changed, 34 insertions(+), 32

[PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables

2020-05-20 Thread Enric Balletbo i Serra
There are some `static const u8` variables that are not used, this triggers a warning building with `make W=1`, it is safe to remove them, so do it and make the compiler more happy. Signed-off-by: Enric Balletbo i Serra --- .../gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c| 48

[PATCH] drm/mediatek: mtk_hdmi: Remove debug messages for function calls

2020-05-20 Thread Enric Balletbo i Serra
Equivalent information can be nowadays obtained using function tracer Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/mediatek/mtk_hdmi.c| 12 +--- drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c | 4 2 files changed, 1 insertion(+), 15 deletions(-) diff

[PATCHv6 0/5] Add initial support for slimport anx78xx

2015-12-04 Thread Enric Balletbo i Serra
. - Remove dead/unused code. - And others ... Changes since last version: - Add the revision history within the respective patches (requested by Emil) - Add two new patches 01 and 02 as part of the series (requested by Thierry) Enric Balletbo i Serra (5): drm/dp: add DPCD definitions from DP

[PATCHv6 1/5] drm/dp: add DPCD definitions from DP 1.1

2015-12-04 Thread Enric Balletbo i Serra
Add a number of DPCD definitions from DP 1.1 Signed-off-by: Enric Balletbo i Serra --- include/drm/drm_dp_helper.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index bb9d0de..9b0c990 100644 --- a/include/drm

[PATCHv6 2/5] hdmi: added functions for MPEG InfoFrames

2015-12-04 Thread Enric Balletbo i Serra
The MPEG Source (MS) InfoFrame is in EIA/CEA-861B. It describes aspects of the compressed video stream that were used to produce the uncompressed video. The patch adds functions to work with MPEG InfoFrames. Signed-off-by: Enric Balletbo i Serra --- Changes since last version (requested by

[PATCHv6 3/5] of: Add vendor prefix for Analogix Semiconductor, Inc.

2015-12-04 Thread Enric Balletbo i Serra
Analogix Semiconductor develops analog and mixed-signal devices for digital media and communications interconnect applications. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- Changes since last version (requested by Rob Herring) - Fix alphabetical order. Documentation

[PATCHv6 4/5] devicetree: Add new ANX7814 SlimPort transmitter binding.

2015-12-04 Thread Enric Balletbo i Serra
= <&gpio0 4 GPIO_ACTIVE_HIGH>; ports { anx7814_in: endpoint { remote-endpoint = <&hdmi0_out>; }; }; }; Signed-off-by: Enric Balletbo i Serra --- Changes since last version (reque

[PATCHv6 5/5] drm: bridge: anx78xx: Add anx78xx driver support by analogix.

2015-12-04 Thread Enric Balletbo i Serra
using external adapters that converts MyDP or DisplayPort to HDMI or DVI. Signed-off-by: Enric Balletbo i Serra --- Changes since last version: - Fix auto build test ERROR (anx78xx->bridge.of_node = client->dev.of_node) - Remove more magic numbers and use DP_ defines from hdmi.h - Use com

[PATCHv4 0/3] Add initial support for slimport anx78xx

2015-09-25 Thread Enric Balletbo i Serra
ctory - rename the files, variables, types, etc. to anx78xx - plumb through the context struct to all functions that act on the device - use proper messaging (dev_ rather than pr_, _dbg/_err rather than _info) Changes since v1: - As requested by Greg, move from staging to a subsystem. Best regard

[PATCHv4 1/3] of: Add vendor prefix for Analogix Semiconductor, Inc.

2015-09-25 Thread Enric Balletbo i Serra
Analogix Semiconductor develops analog and mixed-signal devices for digital media and communications interconnect applications. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff

[PATCHv4 2/3] devicetree: Add new ANX7814 SlimPort transmitter binding.

2015-09-25 Thread Enric Balletbo i Serra
eg = <0x38>; pd-gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>; reset-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>; }; Signed-off-by: Enric Balletbo i Serra --- .../devicetree/bindings/video/bridge/anx7814.txt | 22 ++ 1 file changed,

[PATCHv4 3/3] drm: bridge: anx78xx: Add anx78xx driver support by analogix.

2015-09-25 Thread Enric Balletbo i Serra
At the moment it only supports ANX7814. The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter designed for portable devices. This driver adds initial support and supports HDMI to DP pass-through mode. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/Kconfig

[PATCH v3 0/3] Add ANX7814 I2C bridge driver

2016-04-08 Thread Enric Balletbo i Serra
//lwn.net/Articles/666885/ Enric Balletbo i Serra (3): of: Add vendor prefix for Analogix Semiconductor devicetree: Add ANX7814 SlimPort transmitter binding. drm: bridge: anx78xx: Add anx78xx driver support. .../devicetree/bindings/vendor-prefixes.txt|1 + .../devicetree/bindings

[PATCH v3 1/3] of: Add vendor prefix for Analogix Semiconductor

2016-04-08 Thread Enric Balletbo i Serra
Analogix Semiconductor Inc. develops analog and mixed-signal devices for digital media and communications interconnect applications. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- Changes since v2: - None Changes since v1: - Add Acked-by: Rob Herring Documentation

[PATCH v3 2/3] devicetree: Add ANX7814 SlimPort transmitter binding.

2016-04-08 Thread Enric Balletbo i Serra
The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter designed for portable devices. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- Changes since v2: - Add Acked-by: Rob Herring Changes since v1: - Rob Herring: - Rename cable-det-gpios for hpd-gpios as

[PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-08 Thread Enric Balletbo i Serra
. Signed-off-by: Enric Balletbo i Serra Tested-by: Nicolas Boichat Reviewed-by: Nicolas Boichat Cc: Emil Velikov Cc: Rob Herring Cc: Dan Carpenter Cc: Daniel Kurtz Cc: Nicolas Boichat --- Changes since v2: - Nicolas Boichat: - Get rid of wait_for macro since is only used once. - Do not

[PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-14 Thread Enric Balletbo i Serra
Hi Thierry, Many thanks for answering and do this accurate report. I'd add a comment on something you (see below). Apart from this I'll add your changes and send a new version. On 14/04/16 15:10, Thierry Reding wrote: > On Fri, Apr 08, 2016 at 02:52:52PM +0200, Enric Balletbo

[PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-14 Thread Enric Balletbo i Serra
Hi Emil, On 14/04/16 16:06, Emil Velikov wrote: > Hi Enric, > > On 14 April 2016 at 14:42, Enric Balletbo i Serra > wrote: >> The patch was implemented first without OR'ing error codes. The reason why I >> changed this is because I received the comments that c

[PATCH v4 0/4] Add ANX7814 I2C bridge driver

2016-04-18 Thread Enric Balletbo i Serra
Kurtz: - Use regmap_bulk in aux_transfer - Fix gpio reset polarity. - Turn off v10 last so we mirror poweron sequence - Fix some error paths. - Remove mutex in anx78xx_detect - kbuild: - WARNING: PTR_ERR_OR_ZERO can be used [1] https://lwn.net/Articles/666885/ Enric Ball

[PATCH v4 2/4] of: Add vendor prefix for Analogix Semiconductor

2016-04-18 Thread Enric Balletbo i Serra
Analogix Semiconductor Inc. develops analog and mixed-signal devices for digital media and communications interconnect applications. Signed-off-by: Enric Balletbo i Serra Acked-by: Rob Herring --- Changes since v3: None Changes since v2: None Changes since v1: - Add Acked-by: Rob Herring

[PATCH v3 3/3] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-18 Thread Enric Balletbo i Serra
Hi, Many thanks for dedicate some time to comment the patch, I'm going to send a v4 version, see my comments below. On 14/04/16 15:10, Thierry Reding wrote: > On Fri, Apr 08, 2016 at 02:52:52PM +0200, Enric Balletbo i Serra wrote: >> Although there are other chips from the same f

[PATCH v4 1/4] drm/dp: Add define to set 0.5% down-spread in MAX_DOWNSPREAD register.

2016-04-18 Thread Enric Balletbo i Serra
Support of 0.5% down-spread is required for DisplayPort Specification Version 1.1 Sink. Signed-off-by: Enric Balletbo i Serra --- include/drm/drm_dp_helper.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 1252108..22be049

[PATCH v4 3/4] devicetree: Add ANX7814 SlimPort transmitter binding.

2016-04-18 Thread Enric Balletbo i Serra
The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter designed for portable devices. Signed-off-by: Enric Balletbo i Serra Cc: Rob Herring --- Changes since v3: - Model v10 as regulator (dvdd10-supply) - Removed the Acked-by: Rob Herring. Guess I need your ack again if

[PATCH v4 4/4] drm: bridge: anx78xx: Add anx78xx driver support.

2016-04-18 Thread Enric Balletbo i Serra
. Signed-off-by: Enric Balletbo i Serra Tested-by: Nicolas Boichat Reviewed-by: Nicolas Boichat Cc: Emil Velikov Cc: Rob Herring Cc: Dan Carpenter Cc: Daniel Kurtz Cc: Nicolas Boichat Cc: Thierry Reding --- Changes since v3: - Thierry Reding: - Add vendor name on symbols and files

[PATCH] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch

2018-10-15 Thread Enric Balletbo i Serra
This patch avoids that building the bridge/analogix source code with smatch triggers complaints about inconsistent indenting. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH] drm/rockchip: psr: do not dereference encoder before it is null checked.

2018-10-15 Thread Enric Balletbo i Serra
abstracted PSR driver") Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/rockchip/rockchip_drm_psr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_psr.c b/drivers/gpu/drm/rockchip/rockchip_drm_psr.c index 1635485955d

[PATCH v2] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch

2018-10-16 Thread Enric Balletbo i Serra
This patch avoids that building the bridge/analogix source code with smatch triggers complaints about inconsistent indenting. It also fixes a typo in DRM_ERROR message, attch is replaced for attach. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Laurent Pinchart --- Changes in v2: - Fix

Re: [PATCH] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch

2018-10-16 Thread Enric Balletbo i Serra
Ho Laurent, On 16/10/18 01:11, Laurent Pinchart wrote: > Hi Enric, > > Thank you for the patch. > > On Saturday, 13 October 2018 14:18:44 EEST Enric Balletbo i Serra wrote: >> This patch avoids that building the bridge/analogix source code with >> smatch triggers co

[PATCH v2] backlight: pwm_bl: Fix brightness levels for non-DT case.

2018-10-30 Thread Enric Balletbo i Serra
Reported-by: Robert Jarzmik Signed-off-by: Enric Balletbo i Serra Tested-by: Robert Jarzmik Acked-by: Daniel Thompson --- Changes in v2: - Rebase on top of mainline - Add Tested-by and Acked-by tags. drivers/video/backlight/pwm_bl.c | 41 +++- 1 file changed, 35 i

[RFC PATCH] drm/rockchip: update cursors asynchronously through atomic.

2018-05-21 Thread Enric Balletbo i Serra
Add support to async updates of cursors by using the new atomic interface for that. Signed-off-by: Enric Balletbo i Serra --- I am sending this as RFC because I still don't have a deep knowledge of the hw and I am not sure if the vop_plane_update function can be reused in both

[PATCH] drm/bridge: analogix-anx78xx: Switch to SPDX identifier.

2018-06-06 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/bridge/analogix-anx78xx.c | 24 --- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix

[PATCH v6 1/2] drm/i915: update cursors asynchronously through atomic

2018-06-06 Thread Enric Balletbo i Serra
-off-by: Enric Balletbo i Serra --- This is another attempt to land the patches to update cursors asynchronously through atomic for the i915 driver. Last version was sent some time ago [1], so these series are rebased on top of current mainline and also solves some issues found. The patches were

Re: [PATCH] drm/bridge: analogix-anx78xx: Switch to SPDX identifier.

2018-06-06 Thread Enric Balletbo i Serra
Hi Laurent, On 05/06/18 12:11, Laurent Pinchart wrote: > Hi Enric, > > Thank you for the patch. > > On Tuesday, 5 June 2018 13:00:50 EEST Enric Balletbo i Serra wrote: >> Adopt the SPDX license identifier headers to ease license compliance >> management. >> &

[PATCH v6 2/2] drm/i915: remove intel_cursor_plane_funcs

2018-06-06 Thread Enric Balletbo i Serra
From: Gustavo Padovan After converting legacy cursor updates to atomic async commits intel_cursor_plane_funcs just duplicates intel_plane_funcs now. Cc: Daniel Vetter Signed-off-by: Gustavo Padovan Signed-off-by: Enric Balletbo i Serra --- Changes in v6: None Changes in v5: None Changes in

Re: [PATCH] drm/bridge: analogix-anx78xx: Switch to SPDX identifier.

2018-06-06 Thread Enric Balletbo i Serra
Hi all, On 05/06/18 12:33, Laurent Pinchart wrote: > Hi Enric, > > On Tuesday, 5 June 2018 13:27:06 EEST Enric Balletbo i Serra wrote: >> On 05/06/18 12:11, Laurent Pinchart wrote: >>> On Tuesday, 5 June 2018 13:00:50 EEST Enric Balletbo i Serra wrote: >>>&g

[PATCH] Documentation: devicetree: tilcdc: fix spelling mistake "suppors" -> "supports"

2018-06-07 Thread Enric Balletbo i Serra
Trivial fix to spelling mistake in tilcdc.txt devicetree documentation. Signed-off-by: Enric Balletbo i Serra --- Documentation/devicetree/bindings/display/tilcdc/tilcdc.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/tilcdc

[PATCH v7 2/2] drm/i915: remove intel_cursor_plane_funcs

2018-06-11 Thread Enric Balletbo i Serra
From: Gustavo Padovan After converting legacy cursor updates to atomic async commits intel_cursor_plane_funcs just duplicates intel_plane_funcs now. Cc: Daniel Vetter Signed-off-by: Gustavo Padovan Signed-off-by: Enric Balletbo i Serra --- Changes in v7: None Changes in v6: None Changes in

[PATCH v7 1/2] drm/i915: update cursors asynchronously through atomic

2018-06-11 Thread Enric Balletbo i Serra
-off-by: Enric Balletbo i Serra --- This is another attempt to land the patches to update cursors asynchronously through atomic for the i915 driver. Last version was sent some time ago [1], so these series are rebased on top of current mainline and also solves some issues found. The patches were

[RFC PATCH 02/10] dt-bindings: devfreq: rk3399_dmc: Add rockchip, pmu phandle.

2018-05-15 Thread Enric Balletbo i Serra
The Rockchip DMC (Dynamic Memory Interface) needs to access to the PMU general register files to know the DRAM type, so add a phandle to the syscon that manages these registers. Signed-off-by: Enric Balletbo i Serra --- Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt | 2 ++ 1 file

[RFC PATCH 08/10] drm: rockchip: Add DDR devfreq support.

2018-05-15 Thread Enric Balletbo i Serra
From: Sean Paul Add support for devfreq to dynamically control the DDR frequency. It will activate when there is one CRTC active, and disable if more than one becomes active (to avoid flickering on one of the screens). Signed-off-by: Sean Paul Signed-off-by: Enric Balletbo i Serra

[RFC PATCH 01/10] devfreq: rockchip-dfi: Move GRF definitions to a common place.

2018-05-15 Thread Enric Balletbo i Serra
Some rk3399 GRF (Generic Register Files) definitions can be used for different drivers. Move these definitions to a common include so we don't need to duplicate these definitions. Signed-off-by: Enric Balletbo i Serra --- drivers/devfreq/event/rockchip-dfi.c

[RFC PATCH 05/10] devfreq: rk3399_dmc / clk: rockchip: Sync with vblank in the kernel for DDRfreq.

2018-05-15 Thread Enric Balletbo i Serra
where the waiting thread can properly wait on a completion. Signed-off-by: Derek Basehore Signed-off-by: Enric Balletbo i Serra --- drivers/clk/rockchip/clk-ddr.c| 142 +- drivers/clk/rockchip/clk.c| 2 +- drivers/clk/rockchip/clk.h| 3 +- dr

[RFC PATCH 04/10] devfreq: rk3399_dmc / rockchip: pm_domains: Register notify to DMC driver.

2018-05-15 Thread Enric Balletbo i Serra
domain driver writes to the same register. So, add a notification mechanism to ensure that the DMC and the PD driver does not access to this register at the same time. Signed-off-by: Lin Huang [rewrite commit message] Signed-off-by: Enric Balletbo i Serra --- As I explained in the cover letter I

[RFC PATCH 09/10] arm64: dts: rk3399: Add dfi and dmc nodes.

2018-05-15 Thread Enric Balletbo i Serra
From: Lin Huang These are required to support DDR DVFS on rk3399 platform. The patch also introduces two new files (rk3399-dram.h and rk3399-dram-default-timing) with default DRAM settings. Signed-off-by: Lin Huang Signed-off-by: Enric Balletbo i Serra --- .../rockchip/rk3399-dram-default

[RFC PATCH 07/10] clk: rockchip: set clk-ddr to GET_RATE_NOCACHE.

2018-05-15 Thread Enric Balletbo i Serra
From: Derek Basehore This adds the flag to the clk-ddr in rockchip to not use the cached rate for get_rate. This is to handle timeout error conditions in SMC for the set rate function. Signed-off-by: Derek Basehore Signed-off-by: Enric Balletbo i Serra --- drivers/clk/rockchip/clk-ddr.c | 2

[RFC PATCH 06/10] devfreq: rk3399_dmc / clk: rockchip: Disable DDR clk timeout on suspend.

2018-05-15 Thread Enric Balletbo i Serra
-off-by: Enric Balletbo i Serra --- drivers/clk/rockchip/clk-ddr.c| 21 ++--- drivers/devfreq/rk3399_dmc.c | 20 +++- drivers/devfreq/rk3399_dmc_priv.h | 1 + 3 files changed, 34 insertions(+), 8 deletions(-) diff --git a/drivers/clk/rockchip/clk-ddr.c b

[RFC PATCH 10/10] arm64: dts: rockchip: Enable dmc and dfi nodes on gru.

2018-05-15 Thread Enric Balletbo i Serra
From: Lin Huang Enable the DMC (Dynamic Memory Controller) and the DFI (DDR PHY Interface) nodes on gru/kevin boards so we can support DDR DVFS. Signed-off-by: Lin Huang Signed-off-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 21 arch

[RFC PATCH 00/10] Add support for drm/rockchip to dynamically control the DDR frequency.

2018-05-15 Thread Enric Balletbo i Serra
feedback. Best regards, Enric Derek Basehore (3): devfreq: rk3399_dmc / clk: rockchip: Sync with vblank in the kernel for DDRfreq. devfreq: rk3399_dmc / clk: rockchip: Disable DDR clk timeout on suspend. clk: rockchip: set clk-ddr to GET_RATE_NOCACHE. Enric Balletbo i Serra (3): d

[RFC PATCH 03/10] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2018-05-15 Thread Enric Balletbo i Serra
disable the DDR ODT. Signed-off-by: Enric Balletbo i Serra --- drivers/devfreq/rk3399_dmc.c| 50 - include/soc/rockchip/rockchip_sip.h | 1 + 2 files changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq

[PATCH v3] backlight: pwm_bl: Fix brightness levels for non-DT case.

2018-11-09 Thread Enric Balletbo i Serra
by: Robert Jarzmik Signed-off-by: Enric Balletbo i Serra Tested-by: Robert Jarzmik Acked-by: Daniel Thompson --- Changes in v3: - Fixed some typos in commit message. - Removed ' in Fixes tag. Changes in v2: - Rebase on top of mainline - Add Tested-by and Acked-by

Re: [PATCH] backlight: pwm_bl: re-add driver internal enabled tracking

2018-11-11 Thread Enric Balletbo i Serra
y_state(pb->pwm, &state); > > regulator_disable(pb->power_supply); > + pb->enabled = false; > } > > static int compute_duty_cycle(struct pwm_bl_data *pb, int brightness) > @@ -483,6 +487,7 @@ static int pwm_backlight_probe(struct

[PATCH v3] backlight: pwm_bl: switch to using "atomic" PWM API

2018-08-15 Thread Enric Balletbo i Serra
The "atomic" API allows us to configure PWM period and duty_cycle and enable it in one call. The patch also moves the pwm_init_state just before any use of the pwm_state struct, this fixes a potential bug where pwm_get_state can be called before pwm_init_state. Signed-off-by: Enric

[PATCH] backlight: pwm_bl: Fix brightness levels for non-DT case.

2018-08-27 Thread Enric Balletbo i Serra
all to pwm_get_state(). Fixes: '88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye")' Reported-by: Robert Jarzmik Signed-off-by: Enric Balletbo i Serra --- drivers/video/backlight/pwm_bl.c | 50 1 file change

[RFC PATCH] drm/atomic: add ASYNC_UPDATE flag to the Atomic IOCTL.

2018-06-28 Thread Enric Balletbo i Serra
Signed-off-by: Enric Balletbo i Serra --- Hi, This is an attempt to introduce the new ASYNC_UPDATE flag for atomic operations, see the commit message for a more detailed description. To test this patch we have created an IGT test that we plan to send to the ML but also was tested using a small

<    1   2   3   4   5   >