Fix badly hardcoded return return value from under fail-label. All
goto branches to the label set the "ret"-variable accordingly.
Signed-off-by: Jyri Sarha <jsa...@ti.com>
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On 01/31/17 17:46, Gabriel Krisman Bertazi wrote:
> Jyri Sarha <jsa...@ti.com> writes:
>
>> Fix badly hardcoded return return value from under fail-label. All
>> goto branches to the label set the "ret"-variable accordingly.
>>
>> Signed-off-by: Jyr
Fix badly hardcoded return return value under fail-label. All goto
branches to the label set the "ret"-variable accordingly.
Signed-off-by: Jyri Sarha <jsa...@ti.com>
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
d instead.
>
> While at it, the 'return' of .disable_vblank is dropped to fix the
> following checkpatch warning.
>
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Shawn Guo <shawn@linaro.org>
> Cc: Jyri Sarha <jsa...@ti.com>
is not able to
fetch the data in burst mode. When this happens it is hard to tell if
there enough bandwidth. Despite what theory says this appears to be
true also for 16-bit color formats.
Signed-off-by: Jyri Sarha <jsa...@ti.com>
---
drivers/gpu/drm/omapdrm/dss/dispc.c | 19 +++
Thanks Rob, for nice cleanup, but ...
On 02/04/17 05:36, Rob Herring wrote:
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> index 6dfdb145f3bb..e74cc236a79b 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> +++
to
fetch the data in burst mode. When this happens it is hard to tell if
there enough bandwidth. Despite what theory says this appears to be
true also for 16-bit color formats.
Signed-off-by: Jyri Sarha <jsa...@ti.com>
---
Chnages since first version:
- "color_mode_to_bpp(color_mode) > 8&q
On 02/08/17 13:25, Laurent Pinchart wrote:
> Hi Jyri,
>
> Thank you for the patch.
>
> On Tuesday 07 Feb 2017 16:41:20 Jyri Sarha wrote:
>> Let's disable all scaling that requires horizontal decimation with
>> higher factor than 4, until we have better estimates of wh
On 01/28/17 18:17, Laurent Pinchart wrote:
> Hi Jyri,
>
> Thank you for the patch.
>
> On Friday 27 Jan 2017 12:04:55 Jyri Sarha wrote:
>> Move drm_atomic_helper_commit_modeset_enables() call to before
>> drm_atomic_helper_commit_planes() call and have a
>> omap_
On 01/30/17 13:15, Laurent Pinchart wrote:
>>> rebase (and retest) this patch on top of "[PATCH 0/5] omapdrm: fences and
>>> zpos" ?
>> Thanks, I'll do that.
> If you intend on merging this patch as a v4.10 fix then there's no need to
> rebase. If it targets v4.11, the above-mentioned series will
ves all debugfs files using
> debugfs_remove_recursive(), so there should be no need for such a
> callback in the future.
>
> Cc: jsa...@ti.com
> Cc: tomi.valkei...@ti.com
> Signed-off-by: Noralf Trønnes <nor...@tronnes.org>
uncommitted drm
state information. information.
Signed-off-by: Jyri Sarha <jsa...@ti.com>
---
drivers/gpu/drm/omapdrm/omap_drv.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c
b/drivers/gpu/drm/omapdrm/omap_drv.c
index 5
This reverts commit dadf4659d0608e034b6633f30300c2eff2dafb4c.
If planes are not disabled when the they are not on any crtc anymore
they will remain active and may show as "ghosts" when the crtc they
were last on is active again.
Signed-off-by: Jyri Sarha <jsa...@ti.com>
---
I hit these two problems while tracking scaling related problems with
omapdrm on DSS5 HW.
Jyri Sarha (2):
Revert "drm: omapdrm: Let the DRM core skip plane commit on inactive
CRTCs"
drm/omapdrm: Move commit_modeset_enables() before commit_planes()
drivers/gpu/drm/omapdrm/o
rm.com>
> Tested-by: Eric Anholt <e...@anholt.net>
For tilcdc part:
Tested-by: Jyri Sarha <jsa...@ti.com>
Cheers,
Jyri
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 10/24/16 11:43, Bartosz Golaszewski wrote:
> Revision 1 of the IP doesn't work if we don't load the palette (even
> if it's not used, which is the case for the RGB565 format).
>
> Add a function called from tilcdc_crtc_enable() which performs all
> required actions if we're dealing with a rev1
On 10/19/16 13:28, Russell King wrote:
> Convert DT component matching to use component_match_add_release().
>
> Signed-off-by: Russell King <rmk+kernel at armlinux.org.uk>
Acked-by: Jyri Sarha
Reviewed-by: Jyri Sarha
However, the patch description is a bit brief. It took me t
st patches should be merged before the third can be
merged. So the merge order should be agreed with tda998x before going
forward.
The last patch is just a cleanup, but depends on earlier ones.
Best regards,
Jyri
[1] https://patchwork.kernel.org/patch/9322771/
Jyri Sarha (3):
drm/tilcdc: Remov
Remove obsolete drm_connector_register() calls from tilcdc_panel.c and
tilcdc_tfp410.c. All connectors are registered when drm_dev_register()
is called.
Signed-off-by: Jyri Sarha
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 --
drivers/gpu/drm/tilcdc
either in component unbind
callback or in platform driver demove callback.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 124
1 file changed, 70 insertions(+), 54 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
b/drivers
Use unload to handle initialization failures instead of complex goto
label mess. To do this the initialization sequence needed slight
reordering and some unload functions needed to become conditional.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 10 ++--
drivers/gpu/drm
On 10/31/16 16:19, Bartosz Golaszewski wrote:
> Revision 1 of the IP doesn't work if we don't load the palette (even
> if it's not used, which is the case for the RGB565 format).
>
> Add a function called from tilcdc_crtc_enable() which performs all
> required actions if we're dealing with a rev1
On 10/28/16 14:52, Daniel Schultz wrote:
> The commit d8ff0c63fbcb ("drm/tilcdc: Adjust the FB_CEILING address")
> added an adjustment of the FB_CEILING address. This is done by decrementing
> the address by one.
>
> On the AM335x (rev 0x4F201000) the framebuffer is rotated left over the
>
On 10/28/16 14:52, Daniel Schultz wrote:
> This error message will be printed when a FIFO underflow irq has
> triggered. Since this happens sometimes and the error message will be
> displayed on the console, it should have a correct spelling.
>
> Signed-off-by: Daniel Schultz
Picked up for my
On 10/31/16 19:33, Jyri Sarha wrote:
> On 10/28/16 14:52, Daniel Schultz wrote:
>> This error message will be printed when a FIFO underflow irq has
>> triggered. Since this happens sometimes and the error message will be
>> displayed on the console, it should have a correct s
On 09/01/16 10:13, Tomi Valkeinen wrote:
> On 31/08/16 16:14, Jyri Sarha wrote:
>> Write DMA base and ceiling address with a single instruction, if
>> available. This should make it more unlikely that LCDC would fetch the
>> DMA addresses in the middle of an update. H
ors output
to be in BGR format. With straight wiring the 16 color is RGB and 24
bit is BGR. These patches try to deal with the issue in reasonable
manner.
For more details see section 3.1.1 in AM335x Silicon Errata:
http://www.ti.com/general/docs/lit/getliterature.tsp?baseLiteratureNumber=sprz360
Jy
drm_helper_disable_unused_functions() should not be called by atomic
drivers.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 3404d24..e45c268
ior in LCDC.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 10 --
drivers/gpu/drm/tilcdc/tilcdc_regs.h | 14 ++
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
in
65,
RGB888 and XRGB formats. However, depending on wiring, the red and
blue colors are swapped in either 16 or 24-bit color modes.
For more details see section 3.1.1 in AM335x Silicon Errata:
http://www.ti.com/general/docs/lit/getliterature.tsp?baseLiteratureNumber=sprz360
Signed-off-by:
but RGB formats, so we must choose such bytes per
pixel value that supports RGB.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 14 +-
drivers/gpu/drm/tilcdc/tilcdc_drv.h | 1 -
drivers/gpu/drm/tilcdc/tilcdc_external.c | 7 +++
drivers/gpu/drm/tilcdc
supported color
formats from 16 bit RGB and 24 bit BGR to 16 bit BGR and 24 bit RGB.
Signed-off-by: Jyri Sarha
---
arch/arm/boot/dts/am335x-boneblack.dts | 11 +++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-boneblack.dts
b/arch/arm/boot/dts/am335x-boneblack.dts
.
Signed-off-by: Jyri Sarha
---
arch/arm/boot/dts/am335x-evm.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 5d28712..c3cbce0 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
Whitespace cleanup of lcdc related nodes. Do all indentation and
alignment with tabs instead of spaces.
Signed-off-by: Jyri Sarha
---
arch/arm/boot/dts/am335x-evmsk.dts | 40 +++---
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/arch/arm/boot/dts
.
Signed-off-by: Jyri Sarha
---
arch/arm/boot/dts/am335x-evmsk.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts
b/arch/arm/boot/dts/am335x-evmsk.dts
index 23b94e7..034e117 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x
Fix property handling for mode object without mode object type.
drm_property_change_valid_get() crashes if atomic ioctl for mode
object does not specify the mode object type. This patch makes
drm_property_change_valid_get() to tolerate such requests.
Signed-off-by: Jyri Sarha
---
This used
s for v4.9
----
Jyri Sarha (4):
drm/tilcdc: Remove drm_helper_disable_unused_functions() call
drm/tilcdc: Write DMA base and ceiling address with single instruction
drm/tilcdc: Add blue-and-red-crossed devicetree property
drm/tilc
On 09/01/16 01:11, Kevin Hilman wrote:
> Hi Jyri,
>
> Jyri Sarha writes:
>
>> On 08/23/16 15:56, Karl Beldan wrote:
>>> Hi,
>>>
>>> I found some missing bits for rev1 of the LCDC and here are some of the
>>> changes I am using to use the DR
Jyri Sarha (3):
drm/tilcdc: Take mode config lock while updating the crtc clock rate
drm/tilcdc: Add tilcdc_crtc_set_clk() and cleanup cpufreq_transition()
drm/tilcdc: Add mutex to protect crtc enable and disable routines
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 93
Take mode config lock while updating the crtc clock rate. To avoid a
race in tilcdc_crtc_update_clk(), we do not want the mode to change
while we update crtc clock.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 5 +
drivers/gpu/drm/tilcdc/tilcdc_drv.h | 2 ++
2 files
Add tilcdc_crtc_set_clk() and cleanup cpufreq_transition(). The new
tilcdc_crtc_set_clk() is used in tilcdc_crtc_mode_set_nofb() instead
tilcdc_crtc_update_clk(). New tilcdc_crtc_update_clk() is implemented
using tilcdc_crtc_set_clk() for cpufreq_transition() alone.
Signed-off-by: Jyri Sarha
Add mutex to protect crtc enable and disable routines. The
tilcdc_crtc_disable() function waits for frame done interrupt, the
internal data will get out of sync, should another enable arrive while
waiting for the interrupt.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 15
On 09/06/16 12:07, Tomi Valkeinen wrote:
>
>
> On 06/09/16 11:19, Jyri Sarha wrote:
>> Take mode config lock while updating the crtc clock rate. To avoid a
>> race in tilcdc_crtc_update_clk(), we do not want the mode to change
>> while we update crtc clock.
>
On 09/06/16 12:30, Tomi Valkeinen wrote:
> On 06/09/16 11:19, Jyri Sarha wrote:
>> Add mutex to protect crtc enable and disable routines. The
>> tilcdc_crtc_disable() function waits for frame done interrupt, the
>> internal data will get out of sync, should another enable ar
The second patch goes a step forward and cleans up the clock setting
code a bit.
BR,
Jyri
Jyri Sarha (5):
drm/tilcdc: Take crtc modeset lock while updating the crtc clock rate
drm/tilcdc: Clean up LCDC functional clock rate setting code
drm/tilcdc: Flush flip-work workqueue bef
Take crtc modeset lock while updating the crtc clock rate. To avoid a
race in tilcdc_crtc_update_clk(), we do not want crtc mode to change
while we update crtc clock.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
and
it needs to take the necessary locks and turn off the CRTC while
keeping the LCDC powered. The reimplemented tilcdc_crtc_update_clk()
is for that purpose and it uses the new tilcdc_crtc_set_clk() to
actually set the clock.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 77
-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index f4e6a5b..6974624 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
the flip-work
queue.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 52ff3e1..1981ae9 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b
not take
the lock. If this ever changes the CRTC locking has to be removed from
tilcdc_crtc_destroy().
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
b/drivers/gpu/drm/tilcdc
c: WARN if CRTC is touched without CRTC lock"
There was a race between mode_set_nofb() and cpufreq_transition()
calling tilcdc_crtc_update_clk() without locking.
The first patch fixes the race in with a minimal change by taking
the drm CRTC lock for the duration of the clock update.
The second patch goes a
Take crtc modeset lock while updating the crtc clock rate. To avoid a
race in tilcdc_crtc_update_clk(), we do not want crtc mode to change
while we update crtc clock.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
and
it needs to take the necessary locks and turn off the CRTC while
keeping the LCDC powered. The reimplemented tilcdc_crtc_update_clk()
is for that purpose and it uses the new tilcdc_crtc_set_clk() to
actually set the clock.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 77
-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index f4e6a5b..6974624 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
the flip-work
queue.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 52ff3e1..1981ae9 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b
.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index 6974624..2763f9f 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm
WARN if CRTC is touched without CRTC lock. The crtc functions should
not be called simultaneously from multiple threads. Having the DRM
CRTC lock should take care of that.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 8
1 file changed, 8 insertions(+)
diff
s for v4.9
----
Jyri Sarha (10):
drm/tilcdc: Remove drm_helper_disable_unused_functions() call
drm/tilcdc: Write DMA base and ceiling address with single instruction
drm/tilcdc: Add blue-and-red-crossed devicetree property
drm/tilcdc: Choose console BPP that supports RGB
On 09/08/16 14:08, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:393:12: warning: no previous prototype
> for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:398:13: warning: no previous prototype
On 09/08/16 14:29, Baoyou Xie wrote:
> We get 3 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:142:29: warning: no previous
> prototype for 'tilcdc_get_overlay' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:198:13: warning: no
On 09/10/16 15:32, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning:
> symbol 'tilcdc_atomic_check' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun
I'll pick this up.
Thanks,
Jyri
>
Remove "default" keyword from blue-and-red-wiring devicetree property
binding document. The code does not support and there is no intention
to support it.
Reported-by: Rob Herring
Signed-off-by: Jyri Sarha
---
I sent the pull request for the color errata changes before I received
-devel/2016-September/117283.html
https://lists.freedesktop.org/archives/dri-devel/2016-September/117284.html
On 09/01/16 12:09, Jyri Sarha wrote:
> Add blue-and-red-wiring -property to LCDC node. Also adds comments on
> how to get support 24 bit RGB mode. After this patch am335x-bon
M_FORMAT_ARGB support
>> - Fixed coding style
>> - Renamed min_pitch to pitch
>> ---
>> drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 15 +--
>> drivers/gpu/drm/tilcdc/tilcdc_plane.c | 7 ---
>> 2 files changed, 9 insertions(+), 13 deletions(-)
>
.
Signed-off-by: Jyri Sarha
Reviewed-by: Tomi Valkeinen
---
arch/arm/boot/dts/am335x-evm.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 5d28712..c3cbce0 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm
Whitespace cleanup of lcdc related nodes. Do all indentation and
alignment with tabs instead of spaces.
Signed-off-by: Jyri Sarha
Reviewed-by: Tomi Valkeinen
---
arch/arm/boot/dts/am335x-evmsk.dts | 40 +++---
1 file changed, 20 insertions(+), 20 deletions
.
Signed-off-by: Jyri Sarha
Reviewed-by: Tomi Valkeinen
---
arch/arm/boot/dts/am335x-evmsk.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts
b/arch/arm/boot/dts/am335x-evmsk.dts
index 23b94e7..034e117 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
://www.spinics.net/lists/devicetree/msg141246.html
Jyri Sarha (3):
ARM: dts: am335x-evm: Add blue-and-red-wiring -property to lcdc node
ARM: dts: am335x-evmsk: Whitespace cleanup of lcdc related nodes
ARM: dts: am335x-evmsk: Add blue-and-red-wiring -property to lcdc node
arch/arm/boot/dts/am335x-evm.dts
On 09/16/16 18:02, Tony Lindgren wrote:
> * Jyri Sarha [160916 04:50]:
>> > These patches complete the am335x LCDC color errata fix[1]. The
>> > functional patches are now queued for v4.9.
>> >
>> > The patch for am335x-boneblack.dts is delayed unt
On 09/17/16 01:17, Nishanth Menon wrote:
> On 09/16/2016 06:50 AM, Jyri Sarha wrote:
> [..]
>> +blue-and-red-wiring = "crossed";
>
> Dumb question: Why is this a Linux generic property - does it make sense
> to have "blue-and-red-wiring" as a Linux
Thanks,
But I have got this already:
https://lists.freedesktop.org/archives/dri-devel/2016-September/117900.html
I will send a pull request soon.
Best regards,
Jyri
On 09/21/16 08:12, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
>
Thank,
But I already have this too:
http://www.spinics.net/lists/kernel/msg2340400.html
Best regards,
Jyri
On 09/21/16 08:14, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning: no previous prototype for
>
On 09/22/16 11:31, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 22 Sep 2016 09:05:14 +0200
>
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "kmalloc_array".
>
On 09/22/16 11:32, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 22 Sep 2016 09:29:23 +0200
>
> Return directly after a memory allocation failed in this function
> at the beginning.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 2 +-
>
On 09/22/16 11:33, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Thu, 22 Sep 2016 10:06:50 +0200
>
> The of_node_put() function was called in some cases
> by the tilcdc_convert_slave_node() function during error handling
> even if the passed variable contained a null pointer.
>
> *
On 09/22/16 21:38, SF Markus Elfring wrote:
>>> The of_node_put() function was called in some cases
>>> by the tilcdc_convert_slave_node() function during error handling
>>> even if the passed variable contained a null pointer.
>>>
>>> * Adjust jump targets according to the Linux coding style
c_panel.c:446:12: warning: symbol 'tilcdc_panel_init' was not
> declared. Should it be static?
> drm/tilcdc/tilcdc_panel.c:451:13: warning: symbol 'tilcdc_panel_fini' was not
> declared. Should it be static?
> drm/tilcdc/tilcdc_drv.c:78:5: warning: symbol 'tilcdc_atomic_check' was not
> de
On 09/22/16 09:18, Daniel Vetter wrote:
> On Wed, Sep 21, 2016 at 06:36:28AM -0700, Sean Paul wrote:
>> Also reorder alphabetically and fix up drm_flip_work header.
>>
>> Signed-off-by: Sean Paul
>
> Reviewed-by: Daniel Vetter
>
Picked this up. Thanks!
Best regards,
Jyri
>> ---
>>
header dependencies
drm/tilcdc: mark symbols static where possible
Jyri Sarha (1):
drm/tilcdc: Remove "default" from blue-and-red-wiring property binding
Markus Elfring (1):
drm/tilcdc: Return directly after a failed kfree_table_init() in
tilcdc_convert_slave_node()
On 09/23/16 10:36, SF Markus Elfring wrote:
>> I think the "if (node)" in the of_node_put() is there on purpose,
>
> Yes, of course.
>
> Does such an implementation detail correspond to a general software design
> pattern?
>
Yes it does. For instance standard malloc()/free() implementation
On 09/23/16 09:23, Sean Paul wrote:
> On Thu, Sep 22, 2016 at 2:04 PM, Jyri Sarha wrote:
>> On 09/22/16 09:18, Daniel Vetter wrote:
>>> On Wed, Sep 21, 2016 at 06:36:28AM -0700, Sean Paul wrote:
>>>> Also reorder alphabetically and fix up drm_flip_work header.
>
Dave,
Please ignore this pull request. I'll send another soon.
The "drm/tilcdc: Add atomic and crtc headers to crtc.c" is already
coming trough drm-misc.
Best regards,
Jyri
On 09/23/16 00:37, Jyri Sarha wrote:
> Hi Dave,
> Please pull these collected fixes and cleanups from
drm/tilcdc: implement palette loading for rev1
drm/tilcdc: fix parsing of some DT properties
Daniel Schultz (2):
drm/tilcdc: Add revision handling for FB_CEILING
drm/tilcdc: Correct misspelling in error message
Jyri Sarha (17):
drm/tilcdc: Remove obsolete
On 10/03/16 18:45, Bartosz Golaszewski wrote:
> Due to some potential tweaks for the da850 LCDC (for example: the
> required memory bandwith settings) we need a separate compatible
> for the IP present on the da850 boards.
>
> Suggested-by: Sekhar Nori
> Signed-off-by: Bartosz Golaszewski
On 09/29/16 19:43, Bartosz Golaszewski wrote:
> Some architectures don't use the common clock framework and don't
> implement all the clk interfaces for every clock. This is the case
> for da850-lcdk where clk_set_rate() only works for PLL0 and PLL1.
>
> Trying to set the clock rate for the LCDC
Remove obsolete drm_connector_register() call from tda998x_bind(). All
connectors are registered when drm_dev_register() is called by the
master drm_device driver.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/i2c/tda998x_drv.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers
patch is just a cleanup, but depends on earlier ones.
Best regards,
Jyri
[1] https://patchwork.kernel.org/patch/9322771/
Jyri Sarha (4):
drm/tilcdc: Remove obsolete drm_connector_register() calls
drm/i2c: tda998x: Remove obsolete drm_connector_register() call
drm/tilcdc: Stop using struct
Stop using struct drm_driver load() callback. The load() callback
should not be used anymore. Instead the drm_device is allocated with
drm_dev_alloc() and registered with drm_dev_register() only after the
driver is completely initialized.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc
Use unload to handle initialization failures instead of complex goto
label mess. To do this the initialization sequence needed slight
reordering and some unload functions needed to become conditional.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 91
Remove obsolete drm_connector_register() calls from tilcdc_panel.c and
tilcdc_tfp410.c. All connectors are registered when drm_dev_register()
is called.
Signed-off-by: Jyri Sarha
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 --
drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 2 --
2 files changed, 4
On 09/23/16 14:47, Sean Paul wrote:
> On Fri, Sep 23, 2016 at 3:52 AM, Daniel Schultz
> wrote:
>> When 'component_bind_all' fails it should not try to unbind components
>> in the error handling. This will produce a null pointer kernel panic when
>> no component exist.
>>
>> This patch changes
/tilcdc: mark symbols static where possible
Daniel Schultz (1):
drm/tilcdc: fix wrong error handling
Jyri Sarha (1):
drm/tilcdc: Remove "default" from blue-and-red-wiring property binding
Markus Elfring (1):
drm/tilcdc: Return directly after a failed kfree_
On 09/25/16 10:16, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:397:12: warning: no previous prototype
> for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:402:13: warning: no previous prototype
On 09/25/16 10:16, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:142:29: warning: no previous
> prototype for 'tilcdc_get_overlay' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:198:13: warning: no
On 09/27/16 18:29, Bartosz Golaszewski wrote:
> Some architectures don't use the common clock framework and don't
> implement all the clk interfaces for every clock. This is the case
> for da850-lcdk where clk_set_rate() only works for PLL0 and PLL1.
>
> Trying to set the clock rate for the LCDC
On 09/28/16 15:41, Bartosz Golaszewski wrote:
> Some architectures don't use the common clock framework and don't
> implement all the clk interfaces for every clock. This is the case
> for da850-lcdk where clk_set_rate() only works for PLL0 and PLL1.
>
> Trying to set the clock rate for the LCDC
ted by the datasheet.
>
> Signed-off-by: Bartosz Golaszewski
After testing I'll send this as fixes pull req for tilcdc 4.10.
Reviewed-by: Jyri Sarha
> ---
> v1 -> v2:
> - add a check to see if the RASTER_ENABLE bit is set before clearing it
>
> drivers/gpu/drm/tilcdc
Hi Dave,
Please pull this tilcdc fix for v4.10. The tagged fix has been rebased
on top of my previous pull request tag (tilcdc-4.10).
Thanks,
Jyri
The following changes since commit 0186fcce896d3cb6fb690ed8b4405c9c1b76977a:
drm/tilcdc: fix parsing of some DT properties (2016-11-30 14:20:16
eck for vrefresh and last_vblank being valid is
redundant, as they should now always be valid if the crtc is
enabled. If they are not a division by zero waning is quite
appropriate.
Signed-off-by: Jyri Sarha <jsa...@ti.com>
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 27 --
ch.
The first patch changes tda998x pdata, so if there are any out of tree
users of tda998x-driver the out of tree code needs to be updated.
Jyri Sarha (3):
drm/i2c: tda998x: Improve tda998x_configure_audio() audio related
pdata
drm/i2c: tda998x: Register ASoC hdmi-codec and add audio D
1 - 100 of 1283 matches
Mail list logo
