[PATCH v6 03/23] modetest: Sort command line arguments

2013-06-14 Thread Laurent Pinchart
The current mostly random sort order hinders code readability. Sort the options alphabetically in the code, and by group in the help message. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Jani Nikula jani.nik...@intel.com --- tests/modetest/modetest.c | 49

[PATCH v6 05/23] modetest: Add a command line parameter to drop master after mode set

2013-06-14 Thread Laurent Pinchart
If the -d parameter is specified, modetest will drop master permissions after setting the mode. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/modetest

[PATCH v6 06/23] modetest: Retrieve all resources in one go

2013-06-14 Thread Laurent Pinchart
Instead of retrieving resources as they are needed, retrieve them all (except property blobs) in one go at startup. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 408 +- 1 file changed, 261 insertions

[PATCH v6 08/23] modetest: Add a command line parameter to set properties

2013-06-14 Thread Laurent Pinchart
The -w parameter can be used to set a property value from the command line, using the target object ID and the property name. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 108 +- 1 file changed, 106

[PATCH v6 09/23] modetest: Allow specifying plane position

2013-06-14 Thread Laurent Pinchart
Extend the -P option to allow specifying the plane x and y offsets. The position is optional, if not specified the plane will be positioned at the center of the screen as before. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 67

[PATCH v6 10/23] modetest: Print the plane ID when setting up a plane

2013-06-14 Thread Laurent Pinchart
As modetest automatically selects an unused plan, providing the plane ID allows modifying plane properties for the selected planes. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v6 11/23] modetest: Remove the -m argument

2013-06-14 Thread Laurent Pinchart
The argument isn't used, remove it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 7f7a3a2..89bfc53 100644

[PATCH v6 12/23] modetest: Create a device structure

2013-06-14 Thread Laurent Pinchart
Instead of passing the device fd and resources as global variables group them in a device structure and pass it explictly to all functions that need it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 201

[PATCH v6 13/23] modetest: Compute CRTC pipe number as needed

2013-06-14 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index cfcb989..a1a683f 100644 --- a/tests

[PATCH v6 14/23] modetest: Remove the struct connector_arg encoder field

2013-06-14 Thread Laurent Pinchart
The field is no needed, make it a local variable where used. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index

[PATCH v6 15/23] modetest: Store the crtc in the connector_arg structure

2013-06-14 Thread Laurent Pinchart
This prepares the code for the split in separate functions of CRTC and planes setup. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 58 ++- 1 file changed, 37 insertions(+), 21 deletions(-) diff --git

[PATCH v6 16/23] modetest: Store the mode in the crtc structure

2013-06-14 Thread Laurent Pinchart
This prepares the code for the split in separate functions of CRTC and planes setup. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/modetest/modetest.c b/tests

[PATCH v6 18/23] modetest: Split mode setting and plane setup

2013-06-14 Thread Laurent Pinchart
There's not reason to require setting a mode to test planes. Split the two operations. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 104 -- 1 file changed, 72 insertions(+), 32 deletions(-) diff

[PATCH v6 17/23] modetest: Give the CRTC ID to the -P option

2013-06-14 Thread Laurent Pinchart
Planes are associated with CRTCs, not connectors. Don't try to be too clever, use the CRTC ID in the -P option. This prepares for splitting CRTC and planes setup. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 32

[PATCH v6 19/23] modetest: Rename struct connector_arg to struct pipe_arg

2013-06-14 Thread Laurent Pinchart
This prepares the code for handling multiple connectors in a single pipeline in a cloned configuration. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 162 -- 1 file changed, 85 insertions(+), 77

[PATCH v6 20/23] modetest: Support pipes with multiple connectors

2013-06-14 Thread Laurent Pinchart
The -s argument can now take a list of connectors. Configure all of them in cloned mode using a single CRTC. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 211 ++ 1 file changed, 157 insertions(+), 54

[PATCH v6 21/23] modetest: Try all possible encoders for a connector

2013-06-14 Thread Laurent Pinchart
When building the pipeline, instead of using only the encoders attached to a connector, take all possible encoders into account to locate a CRTC. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/modetest.c | 35 +-- 1 file

[PATCH v6 22/23] modetest: Fix line stride in SMPTE YUV packet pattern generator

2013-06-14 Thread Laurent Pinchart
The line stride passed to the function is expressed in bytes, there's no need to multiply it by 2. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/buffers.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/modetest

[PATCH v6 23/23] modetest: Allocate NV buffers large enough for the two planes

2013-06-14 Thread Laurent Pinchart
Multiple the image height by 1.5 for NV12/NV21 and by 2 for NV16/NV61 to make room for the chroma plane. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- tests/modetest/buffers.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/tests

Re: [PATCH 0/3] drm/cma: use prim helpers instead GEM CMA specific dma_buf functionality

2013-06-18 Thread Laurent Pinchart
| 5 +- include/drm/drmP.h | 2 + include/drm/drm_gem_cma_helper.h | 13 +- 4 files changed, 56 insertions(+), 255 deletions(-) -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [PATCH v3 1/3] drm: add prime helpers

2013-06-18 Thread Laurent Pinchart
, + 0600); Why do you use 0600 instead of the flags passed by the caller ? +} +EXPORT_SYMBOL(drm_gem_prime_export); -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [PATCH v3 1/3] drm: add prime helpers

2013-06-18 Thread Laurent Pinchart
Hi Aaron, On Tuesday 18 June 2013 16:28:15 Aaron Plattner wrote: On 06/18/2013 04:08 PM, Laurent Pinchart wrote: Hi Aaron, A bit late, but here's a small question. On Tuesday 15 January 2013 12:47:42 Aaron Plattner wrote: Instead of reimplementing all of the dma_buf functionality

Re: [PATCH v3] drm: Renesas R-Car Display Unit DRM driver

2013-06-18 Thread Laurent Pinchart
Hello Adam, Ping ? Daniel, would it help getting the driver in v3.11 if I resubmit it now with a get_modes operation that just returns 0 ? On Friday 14 June 2013 16:03:19 Daniel Vetter wrote: On Fri, Jun 14, 2013 at 02:54:04AM +0200, Laurent Pinchart wrote: On Friday 07 June 2013 10:50:55

Re: [PATCH 4/4] drm: Constify the pretty-print functions

2013-06-18 Thread Laurent Pinchart
, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm: Remove some unused stuff from drm_plane

2013-06-18 Thread Laurent Pinchart
Hello, On Wednesday 08 May 2013 15:52:10 Laurent Pinchart wrote: On Wednesday 08 May 2013 16:40:54 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com There's a bunch of unused members inside drm_plane, bloating the size of the structure needlessly

[PATCH] drm/prime: Honor requested file flags when exporting a buffer

2013-06-18 Thread Laurent Pinchart
The DRM PRIME API passes file flags to the driver for the exported buffer. Honor them instead of hardcoding 0600. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/drm_prime.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] drm/shmobile: Enable compilation on all ARM platforms

2013-06-19 Thread Laurent Pinchart
This is required to support multi-arch kernels. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/shmobile/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig

[PATCH] drm: Improve manual IRQ installation documentation

2013-06-19 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- Documentation/DocBook/drm.tmpl | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl index f9df3b8..738b727 100644

[PATCH] drm/shmobile: Drop usage of removed drm_plane enabled field

2013-06-19 Thread Laurent Pinchart
The enabled field has been removed from struct drm_plane. Don't use it in the driver. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/shmobile/shmob_drm_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This fixes a compilation error

Re: [PATCH] drm: Improve manual IRQ installation documentation

2013-06-20 Thread Laurent Pinchart
Hi Thierry, On Thursday 20 June 2013 12:10:47 Thierry Reding wrote: On Wed, Jun 19, 2013 at 02:00:45PM +0200, Laurent Pinchart wrote: Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- Documentation/DocBook/drm.tmpl | 14 -- 1 file changed, 8

[GIT PULL FOR v3.11] shmob-drm patches

2013-06-20 Thread Laurent Pinchart
://linuxtv.org/pinchartl/fbdev.git drm/shmob for you to fetch changes up to 227c1fb28c7d01ccbd9203e42734c06b470d1744: drm/shmobile: Enable compilation on all ARM platforms (2013-06-20 10:07:14 +0200) Laurent Pinchart (4): drm/shmobile

Re: [PATCH] drm: Improve manual IRQ installation documentation

2013-06-20 Thread Laurent Pinchart
Hi Thierry, On Thursday 20 June 2013 12:40:26 Thierry Reding wrote: On Thu, Jun 20, 2013 at 12:17:25PM +0200, Laurent Pinchart wrote: On Thursday 20 June 2013 12:10:47 Thierry Reding wrote: On Wed, Jun 19, 2013 at 02:00:45PM +0200, Laurent Pinchart wrote: Signed-off-by: Laurent Pinchart

[PATCH v2] drm: Improve manual IRQ installation documentation

2013-06-22 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- Documentation/DocBook/drm.tmpl | 118 - 1 file changed, 70 insertions(+), 48 deletions(-) Changes since v1: - Document manual IRQ registration diff --git a/Documentation

[PATCH 0/2] Documentation improvements

2013-06-22 Thread Laurent Pinchart
Hello, Here are two patches that improve the DRM documentation by documenting the KMS property API, and removing an outdated note about the i915 driver. Laurent Pinchart (2): drm/doc: Remove outdated note about i915 driver not behaving properly drm/doc: Document the KMS property API

[PATCH 1/2] drm/doc: Remove outdated note about i915 driver not behaving properly

2013-06-22 Thread Laurent Pinchart
From: Laurent Pinchart laurent.pinch...@ideasonboard.com The i915 driver has been fixed not to modify the mode argument of the encoder mode_fixup operation. Remove the related comment from the documentation. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Documentation

[PATCH 2/2] drm/doc: Document the KMS property API

2013-06-22 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- Documentation/DocBook/drm.tmpl | 143 + 1 file changed, 143 insertions(+) diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl index cea420d..9d4bb06

[PATCH v2 0/2] Documentation improvements

2013-06-22 Thread Laurent Pinchart
Hello, Here are two patches that improve the DRM documentation by documenting the KMS property API, and removing an outdated note about the i915 driver. Changes since v1: - Fixed typos in patch 2/2 Laurent Pinchart (2): drm/doc: Remove outdated note about i915 driver not behaving properly

[PATCH v2 1/2] drm/doc: Remove outdated note about i915 driver not behaving properly

2013-06-22 Thread Laurent Pinchart
From: Laurent Pinchart laurent.pinch...@ideasonboard.com The i915 driver has been fixed not to modify the mode argument of the encoder mode_fixup operation. Remove the related comment from the documentation. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Alex

[PATCH v2 2/2] drm/doc: Document the KMS property API

2013-06-22 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- Documentation/DocBook/drm.tmpl | 143 + 1 file changed, 143 insertions(+) diff --git a/Documentation/DocBook/drm.tmpl b

Re: [PATCH 2/2] drm/doc: Document the KMS property API

2013-06-22 Thread Laurent Pinchart
. I'll fix them in v2. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 08/23] modetest: Add a command line parameter to set properties

2013-06-27 Thread Laurent Pinchart
Hi Ville, Thank you for the review. On Monday 24 June 2013 18:08:37 Ville Syrjälä wrote: On Fri, Jun 14, 2013 at 11:34:42PM +0200, Laurent Pinchart wrote: The -w parameter can be used to set a property value from the command line, using the target object ID and the property name

Re: [PATCH v6 00/23] modetest enhancements

2013-06-27 Thread Laurent Pinchart
Hi Jerome, Marek, On Friday 14 June 2013 23:34:34 Laurent Pinchart wrote: Hello, Here's the sixth (and hopefully final) version of my modeset enhancements patch set. Beside various cleanups, these patches allow dropping master after mode set, configuring more than two pipes and planes

Re: [PATCH] gpu/host1x: Remove DRIVER_BUS_PLATFORM from driver_features

2013-06-27 Thread Laurent Pinchart
Hi Thierry, On Wednesday 29 May 2013 12:50:40 Thierry Reding wrote: On Wed, May 29, 2013 at 07:44:34AM +0200, Laurent Pinchart wrote: From: Laurent Pinchart laurent.pinch...@ideasonboard.com DRIVER_BUS_PLATFORM is not a DRM driver feature flag, it must not be set in the driver's

Re: [PATCH v6 08/23] modetest: Add a command line parameter to set properties

2013-06-27 Thread Laurent Pinchart
On Thursday 27 June 2013 11:31:48 Ville Syrjälä wrote: On Thu, Jun 27, 2013 at 10:10:43AM +0200, Laurent Pinchart wrote: On Monday 24 June 2013 18:08:37 Ville Syrjälä wrote: On Fri, Jun 14, 2013 at 11:34:42PM +0200, Laurent Pinchart wrote: The -w parameter can be used to set a property

[PATCH 01/24] drm/rcar-du: Add missing alpha plane register definitions

2013-06-27 Thread Laurent Pinchart
Several alpha plane register definitions are missing, add them. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_regs.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_regs.h b

[PATCH 00/24] R-Car DU DRM support for R8A7790

2013-06-27 Thread Laurent Pinchart
that as an excuse to skip reviewing them :-)). Laurent Pinchart (24): drm/rcar-du: Add missing alpha plane register definitions drm/rcar-du: Use devm_ioremap_resource() drm/rcar-du: Add platform module device table drm/rcar-du: Don't ignore rcar_du_crtc_create() return value drm/rcar-du: Support per

[PATCH 03/24] drm/rcar-du: Add platform module device table

2013-06-27 Thread Laurent Pinchart
The platform device id driver data field points to a device information structure that only contains a (currently empty) features field for now. Support for additional model-dependent features will be added later. Only the R8A7779 variant is currently supported. Signed-off-by: Laurent Pinchart

[PATCH 04/24] drm/rcar-du: Don't ignore rcar_du_crtc_create() return value

2013-06-27 Thread Laurent Pinchart
Handle error cases correctly. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du

[PATCH 05/24] drm/rcar-du: Support per-CRTC clock and IRQ

2013-06-27 Thread Laurent Pinchart
Some of the DU revisions use one clock and IRQ per CRTC instead of one clock and IRQ per device. Retrieve the correct clock and register the correct IRQ for each CRTC. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 120

[PATCH 06/24] drm/rcar-du: Fix buffer pitch alignment

2013-06-27 Thread Laurent Pinchart
The DU requires a 16 pixels pitch alignement. Make sure dumb buffers are allocated with the correct pitch, and validate the pitch when creating frame buffers. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- drivers/gpu

[PATCH 07/24] drm/rcar-du: Clarify comment regarding plane Y source coordinate

2013-06-27 Thread Laurent Pinchart
The R8A7790 DU documentation contains further information regarding the plane Y source coordinate. Update the comment accordingly. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 9 ++--- 1 file changed, 6 insertions

[PATCH 08/24] drm/rcar-du: Split LVDS encoder and connector

2013-06-27 Thread Laurent Pinchart
This prepares for the encoders rework. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/Makefile | 1 + drivers/gpu/drm/rcar-du/rcar_du_lvds.c| 120 +-- drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c | 129

[PATCH 09/24] drm/rcar-du: Split VGA encoder and connector

2013-06-27 Thread Laurent Pinchart
This prepares for the encoders rework. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/Makefile | 3 +- drivers/gpu/drm/rcar-du/rcar_du_vga.c| 86 + drivers/gpu/drm/rcar-du/rcar_du_vga.h| 2

[PATCH 10/24] drm/rcar-du: Merge LVDS and VGA encoder code

2013-06-27 Thread Laurent Pinchart
Create a single rcar_du_encoder structure that implements a KMS encoder. The current implementation is straightforward and only configures CRTC output routing. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/Makefile | 3

[PATCH 12/24] drm/rcar-du: Create rcar_du_planes structure

2013-06-27 Thread Laurent Pinchart
Move the plane-related fields of struct rcar_du_device to their own structure. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 11 +-- drivers/gpu/drm/rcar-du/rcar_du_plane.h | 17 +++-- 2 files changed

[PATCH 11/24] drm/rcar-du: Rename platform data fields to match what they describe

2013-06-27 Thread Laurent Pinchart
The struct rcar_du_encoder_data encoder::field describes the encoder type, and the rcar_du_encoder_lvds_data and rcar_du_encoder_vga_data structures describe connector properties. Rename them accordingly. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu

[PATCH 13/24] drm/rcar-du: Rename rcar_du_plane_(init|register) to rcar_du_planes_*

2013-06-27 Thread Laurent Pinchart
The functions initialize or register all planes, rename them accordingly. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 4 ++-- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 4 ++-- drivers/gpu/drm/rcar-du/rcar_du_plane.h | 5

[PATCH 14/24] drm/rcar-du: Introduce CRTCs groups

2013-06-27 Thread Laurent Pinchart
resources. Introduce a new rcar_du_group driver-specific object, without any real counterpart in the DU documentation, that models those semi-global resources. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/Makefile| 1 + drivers/gpu

[PATCH 15/24] drm/rcar-du: Use dynamic number of CRTCs instead of CRTCs array size

2013-06-27 Thread Laurent Pinchart
The rcar_du_device structure contains a field that stores the number of CRTCs, use it instead of the CRTCs array size. This prepares the driver to support a variable number of CRTCs. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du

[PATCH 16/24] drm/rcar-du: Remove register definitions for the second channel

2013-06-27 Thread Laurent Pinchart
Channels are accessed through a global channel memory offset, there's no need to define register addresses for the second channel. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_regs.h | 9 - 1 file changed, 9 deletions

[PATCH 17/24] drm/rcar-du: Move output routing configuration to group

2013-06-27 Thread Laurent Pinchart
Output routing is configured in group registers, move the corresponding code from rcar_du_crtc.c to rcar_du_group.c. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 21 + drivers/gpu/drm/rcar-du

[PATCH 18/24] drm/rcar-du: Add support for the R8A7790 DU

2013-06-27 Thread Laurent Pinchart
The DU revision in the R8A7790 SoC uses one IRQ and clock per CRTC. Add a corresponding entry in the module platform ID table. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 +++ drivers/gpu/drm/rcar-du/rcar_du_regs.h

[PATCH 19/24] drm/rcar-du: Fix buffer pitch alignment for R8A7790 DU

2013-06-27 Thread Laurent Pinchart
The R8A7790 DU seems to require a 128 bytes pitch alignment, even though the documentation only mentions a 16 pixels alignement as for the R8A7779 DU. Make this configurable through a device flag. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar

[PATCH 20/24] drm/rcar-du: Add support for multiple groups

2013-06-27 Thread Laurent Pinchart
The R8A7790 DU has 3 CRTCs, split in two groups. Support them. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 25 ++- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 ++ drivers/gpu/drm/rcar-du/rcar_du_drv.h

[PATCH 21/24] drm/rcar-du: Add support for DEFR8 register

2013-06-27 Thread Laurent Pinchart
The R8A7790 DU has a new extended function control register. Support it. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 + drivers/gpu/drm/rcar-du/rcar_du_group.c | 2 ++ 3

[PATCH 22/24] drm/rcar-du: Rework output routing support

2013-06-27 Thread Laurent Pinchart
be connected to the valid outputs, and the type of in-SoC encoder for the output. Platform data then specifies external encoders and the output they are connected to. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c| 6

[PATCH 23/24] drm/rcar-du: Configure RGB output routing to DPAD0

2013-06-27 Thread Laurent Pinchart
The R8A7790 DU variant has a single RGB output called DPAD0 that can be fed with the output of DU0, DU1 or DU2. Making the routing configurable. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 5 drivers/gpu/drm/rcar

[PATCH 24/24] drm/rcar-du: Add internal LVDS encoder support

2013-06-27 Thread Laurent Pinchart
The R8A7790 includes two internal LVDS encoders. Support them in the DU driver. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/Kconfig | 7 ++ drivers/gpu/drm/rcar-du/Makefile | 4 +- drivers/gpu/drm/rcar-du

Re: [PATCH v2] drm/gem: add mutex lock when using drm_gem_mmap_obj

2013-06-27 Thread Laurent Pinchart
drm_gem_mmap_obj() is called with mutex lock or not. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com CC: Rob Clark robdcl...@gmail.com

Re: [PATCH 02/24] drm/rcar-du: Use devm_ioremap_resource()

2013-07-01 Thread Laurent Pinchart
Hi Sergei, On Thursday 27 June 2013 17:04:45 Sergei Shtylyov wrote: On 27-06-2013 13:49, Laurent Pinchart wrote: Replace the devm_request_mem_region() and devm_ioremap_nocache() calls with devm_ioremap_resource(). Signed-off-by: Laurent Pinchart laurent.pinchart+rene

Re: [ANNOUNCE] libdrm 2.4.46

2013-07-02 Thread Laurent Pinchart
? -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/6] DRM: Unified VMA Offset Manager

2013-07-02 Thread Laurent Pinchart
include/drm/drm_vma_manager.h -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [ANNOUNCE] libdrm 2.4.46

2013-07-03 Thread Laurent Pinchart
Hi Dave, On Wednesday 03 July 2013 10:17:34 Dave Airlie wrote: On Wed, Jul 3, 2013 at 9:55 AM, Laurent Pinchart wrote: On Tuesday 02 July 2013 18:22:01 Dave Airlie wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Release because I want the cursor ioctls released, also haswell

Re: [PATCH v2 0/3] drm/cma: use prime helpers instead GEM CMA specific dma_buf functionality

2013-07-03 Thread Laurent Pinchart
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com By the way, between the initial version of the GEM CMA PRIME patch and the version that got merged in v3.10, commit 011c2282c74db120f01a8414edc66c3f217f5511 (drm: prime: fix refcounting on the dmabuf import error path) was introduced

[PATCH 0/2] R-Car DU DRM fixes for v3.11

2013-07-04 Thread Laurent Pinchart
Hello, Here are two small fixes to the R-Car DU DRM driver. They have previously been posted as part of the larger R-Car DU DRM support for R8A7790 series, and Daniel Vetter rightfully noticed that they should be applied to v3.11. Laurent Pinchart (2): drm/rcar-du: Don't ignore

[PATCH 1/2] drm/rcar-du: Don't ignore rcar_du_crtc_create() return value

2013-07-04 Thread Laurent Pinchart
Handle error cases correctly. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du

[PATCH 2/2] drm/rcar-du: Fix buffer pitch alignment

2013-07-04 Thread Laurent Pinchart
The DU requires a 16 pixels pitch alignement. Make sure dumb buffers are allocated with the correct pitch, and validate the pitch when creating frame buffers. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- drivers/gpu

Re: [PATCH] drm: cma: fix refcounting on the dmabuf import error path

2013-07-05 Thread Laurent Pinchart
...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/drm_gem_cma_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c index ce06397..3f3a12b

Re: [PATCH 0/2] R-Car DU DRM fixes for v3.11

2013-07-05 Thread Laurent Pinchart
Hi Dave, On Thursday 04 July 2013 20:05:49 Laurent Pinchart wrote: Hello, Here are two small fixes to the R-Car DU DRM driver. They have previously been posted as part of the larger R-Car DU DRM support for R8A7790 series, and Daniel Vetter rightfully noticed that they should be applied

Re: [PATCH v2 0/3] drm/cma: use prime helpers instead GEM CMA specific dma_buf functionality

2013-07-05 Thread Laurent Pinchart
Hi Joonyoung, On Friday 05 July 2013 15:30:25 Joonyoung Shim wrote: On 07/05/2013 02:38 PM, Dave Airlie wrote: On Thu, Jul 4, 2013 at 5:14 PM, Joonyoung Shim wrote: On 07/04/2013 07:11 AM, Laurent Pinchart wrote: On Friday 28 June 2013 14:24:43 Joonyoung Shim wrote: Hello

Re: [PATCH] drm/rcar-du: Add missing dependency on CMA

2013-07-10 Thread Laurent Pinchart
-Car Display Unit - depends on DRM ARM + depends on DRM ARM CMA select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER select DRM_GEM_CMA_HELPER Shouldn't we instead make DRM_GEM_CMA_HELPER depend on CMA ? -- Regards, Laurent Pinchart

Re: [PATCH] drm/rcar-du: Add missing dependency on CMA

2013-07-10 Thread Laurent Pinchart
On Wednesday 10 July 2013 12:07:24 Mark Brown wrote: On Wed, Jul 10, 2013 at 12:54:40PM +0200, Laurent Pinchart wrote: On Wednesday 10 July 2013 11:52:14 Mark Brown wrote: config DRM_RCAR_DU tristate DRM Support for R-Car Display Unit - depends on DRM ARM + depends

Re: [PATCH] drm/prime: remove cargo-cult locking from map_sg helper

2013-07-10 Thread Laurent Pinchart
); if (!IS_ERR(sgt)) { @@ -182,7 +180,6 @@ static struct sg_table *drm_gem_map_dma_buf(struct dma_buf_attachment *attach, } } - mutex_unlock(obj-dev-struct_mutex); return sgt; } -- Regards, Laurent Pinchart ___ dri-devel

[PATCH 0/2] GEM CMA PRIME fixes for v3.11

2013-07-10 Thread Laurent Pinchart
merged at the same time). Laurent Pinchart (2): drm/rcar-du: Use the GEM PRIME helpers drm/shmobile: Use the GEM PRIME helpers drivers/gpu/drm/rcar-du/rcar_du_drv.c| 9 +++-- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 9 +++-- 2 files changed, 14 insertions(+), 4 deletions

[PATCH 1/2] drm/rcar-du: Use the GEM PRIME helpers

2013-07-10 Thread Laurent Pinchart
The GEM CMA PRIME import/export helpers have been removed in favor of generic GEM PRIME helpers with GEM CMA low-level operations. Fix the driver accordingly. Reported-by: Mark Brown broo...@sirena.org.uk Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu

[PATCH 2/2] drm/shmobile: Use the GEM PRIME helpers

2013-07-10 Thread Laurent Pinchart
The GEM CMA PRIME import/export helpers have been removed in favor of generic GEM PRIME helpers with GEM CMA low-level operations. Fix the driver accordingly. Reported-by: Mark Brown broo...@sirena.org.uk Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu

Re: [PATCH] drm: remove FASYNC support

2013-07-10 Thread Laurent Pinchart
the removal of dev-buf_asnyc assignment in drm_setup to this patch here. v4: Actually git add ... tsk. Cc: Dave Airlie airl...@linux.ie Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Rob Clark robdcl...@gmail.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Acked

Re: [PATCH] drm: don't call -firstopen for KMS drivers

2013-07-11 Thread Laurent Pinchart
the complexity of the drm core - driver interface a notch. v2: Don't forget to update DocBook. Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- Documentation/DocBook/drm.tmpl | 2 ++ drivers/gpu/drm/drm_fops.c | 3 ++- 2

Re: [PATCH] drm/prime: remove cargo-cult locking from map_sg helper

2013-07-11 Thread Laurent Pinchart
it. This should also help Maarten's work to eventually pin the backing storage more dynamically by preventing locking inversions around dev-struct_mutex. v2: Add analysis for recently added cma helper prime code. Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Maarten Lankhorst

Re: [PATCH 0/2][RFC] CDFv2 for VExpress HDLCD DVI output support

2013-07-17 Thread Laurent Pinchart
has apparently changed so we'll have to adapt to it. As to the HDLCD driver - there is some work going on converting it to DRM/KMS and upstreaming as such, using CDF if it's available by that time as well. -- Regards, Laurent Pinchart ___ dri-devel

[GIT PULL FOR v3.11] SH Mobile DRM and R-Car DU DRM fixes

2013-07-17 Thread Laurent Pinchart
-07-17 15:44:01 +0200) Laurent Pinchart (2): drm/shmobile: Use the GEM PRIME helpers drm/rcar-du: Use the GEM PRIME helpers drivers/gpu/drm/rcar-du/rcar_du_drv.c| 9 +++-- drivers/gpu/drm/shmobile/shmob_drm_drv.c

CFP for Graphics and Display uConf at LPC 2013

2013-07-17 Thread Laurent Pinchart
the microconference, please feel free to contact us. Looking forward to seeing everyone in New Orleans. -- Thanks in advance, Jesse Barker (jesse 'dot' barker 'at' arm 'dot' com) Laurent Pinchart (laurent 'dot' pinchart 'at' ideasonboard 'dot' com) ___ dri-devel

Re: [PATCH] drm: don't call -firstopen for KMS drivers

2013-07-22 Thread Laurent Pinchart
do in lastclose. There was already a paragraph present talking about restoring properties, I've simply extended that one. Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

Re: [PATCH 13/20] drm/gem: create drm_gem_dumb_destroy

2013-07-23 Thread Laurent Pinchart
for kms drivers which don't use GEM for backing storage, but it does decently simplify matters for gem drivers. Cc: Inki Dae inki@samsung.com Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Intel Graphics Development intel-...@lists.freedesktop.org Cc: Ben Skeggs skeg

[PATCH v2 01/23] drm/rcar-du: Add missing alpha plane register definitions

2013-07-31 Thread Laurent Pinchart
Several alpha plane register definitions are missing, add them. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_regs.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_regs.h b

[PATCH v2 00/23] R-Car DU DRM support for R8A7790

2013-07-31 Thread Laurent Pinchart
. Laurent Pinchart (23): drm/rcar-du: Add missing alpha plane register definitions drm/rcar-du: Use devm_ioremap_resource() drm/rcar-du: Add platform module device table drm/rcar-du: Support per-CRTC clock and IRQ drm/rcar-du: Clarify comment regarding plane Y source coordinate drm/rcar

[PATCH v2 02/23] drm/rcar-du: Use devm_ioremap_resource()

2013-07-31 Thread Laurent Pinchart
Replace the devm_request_mem_region() and devm_ioremap_nocache() calls with devm_ioremap_resource(). Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions

[PATCH v2 03/23] drm/rcar-du: Add platform module device table

2013-07-31 Thread Laurent Pinchart
The platform device id driver data field points to a device information structure that only contains a (currently empty) features field for now. Support for additional model-dependent features will be added later. Only the R8A7779 variant is currently supported. Signed-off-by: Laurent Pinchart

[PATCH v2 05/23] drm/rcar-du: Clarify comment regarding plane Y source coordinate

2013-07-31 Thread Laurent Pinchart
The R8A7790 DU documentation contains further information regarding the plane Y source coordinate. Update the comment accordingly. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 9 ++--- 1 file changed, 6 insertions

[PATCH v2 06/23] drm/rcar-du: Split LVDS encoder and connector

2013-07-31 Thread Laurent Pinchart
This prepares for the encoders rework. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/gpu/drm/rcar-du/Makefile | 1 + drivers/gpu/drm/rcar-du/rcar_du_lvds.c| 120 +-- drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c | 130

<    1   2   3   4   5   6   7   8   9   10   >