From: Sam Ravnborg
The uctrl driver is only relevant for the Sparcbook 3 machine,
and with sun4m support removed this driver is no logner relevant.
Signed-off-by: Sam Ravnborg
Cc: "David S. Miller"
Cc: Arnd Bergmann
Cc: Andreas Larsson
---
drivers/sbus/char/Kconfig | 8 -
dr
From: Sam Ravnborg
Drop sun4d specific support. Not used by LEON.
Signed-off-by: Sam Ravnborg
Cc: "David S. Miller"
Cc: Arnd Bergmann
Cc: Andreas Larsson
---
arch/sparc/include/asm/io-unit.h | 59
arch/sparc/include/asm/obio.h| 226 ---
From: Sam Ravnborg
sparc_config were used to handle the differences between the machines.
With only LEON supported sparc_config is no longer required.
Refactor the time code a litte as some parts are obsolete and other
parts are only used when SMP is not enabled.
Signed-off-by: Sam Ravnborg
From: Sam Ravnborg
Drop the sun4m specific handling and the patching that
takes place in sun4d and LEON.
Signed-off-by: Sam Ravnborg
Cc: "David S. Miller"
Cc: Arnd Bergmann
Cc: Andreas Larsson
---
arch/sparc/kernel/entry.S | 98 -
From: Sam Ravnborg
Remove the most obvious parts of sun4* support from head_32.S.
Use a single print if a sun4* machine is detected thus restricting
boots to LEON machines.
Signed-off-by: Sam Ravnborg
Cc: "David S. Miller"
Cc: Arnd Bergmann
Cc: Andreas Larsson
---
arch/sparc/kern
ed-off-by: Arnd Bergmann
Looks good. I sometimes looks at sparc patches so I looked at this one.
Reviewed-by: Sam Ravnborg
Hi Aradhya,
On Tue, Nov 07, 2023 at 01:17:03AM +0530, Aradhya Bhatia wrote:
> Hi Sam,
>
> Thank you for the suggestion!
>
> On 06-Nov-23 18:08, Sam Ravnborg wrote:
> > Hi Aradhya,
> >
> > On Tue, Oct 31, 2023 at 12:58:46AM +0530, Aradhya Bhatia wrote:
> &
Hi Aradhya,
On Tue, Oct 31, 2023 at 12:58:46AM +0530, Aradhya Bhatia wrote:
> With new connector model, tc358767 will not create the connector, when
> DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and display-controller driver will
> rely on format negotiation to setup the encoder format.
>
> Add the mis
Hi Tomi,
> From c13c691bd8826b978325575be9a87f577b83b86b Mon Sep 17 00:00:00 2001
> From: Tomi Valkeinen
> Date: Mon, 14 Aug 2023 13:02:23 +0300
> Subject: [PATCH] drm/bridge: tc358768: fix 'Add DRM_BRIDGE_ATTACH_NO_CONNECTOR
> support'
>
> Signed-off-by: Tomi Valkeinen
> ---
> drivers/gpu/dr
> I queued it to drm-misc-next this morning.
Thanks Boris!
Sam
d ffb uses their own imageblit and friends, but this is nicely
handled in the patches.
I also like how you managed to handle the compat case.
All are:
Reviewed-by: Sam Ravnborg
Sam
ck can be:
> > > * standard: data is launched on the rising edge
> > > * inverted: data is launched on the falling edge
> > >
> > > Some panels may need the inverted option to be used so let's support
> > > this DRM flag.
> > >
> > >
"%s %s, using %u KiB of video
> memory\n",
> | ^~~~
>
> Reported-by: Randy Dunlap
> Closes:
> https://lore.kernel.org/lkml/ccc63065-2976-88ef-1211-731330bf2...@infradead.org/
> Signed-off-by: Thomas Zimmermann
> Fixes: 701d2054fa31 (&q
On Fri, Jul 28, 2023 at 08:35:41PM +0200, Sam Ravnborg wrote:
> Hi Thomas,
>
> On Fri, Jul 28, 2023 at 06:39:43PM +0200, Thomas Zimmermann wrote:
> > Most fbdev drivers operate on I/O memory. And most of those use the
> > default implementations for file I/O and console
t this sorted out now where the impact is "only" in
drm.
All 4 patches are:
Reviewed-by: Sam Ravnborg
Hi Helge,
On Fri, Jul 28, 2023 at 08:46:59PM +0200, Helge Deller wrote:
> On 7/28/23 18:39, Thomas Zimmermann wrote:
> > Most fbdev drivers operate on I/O memory.
>
> Just nitpicking here:
> What is I/O memory?
> Isn't it either memory, or I/O ?
> I mean, I would never think of the cfb* draw func
Hi Thomas,
On Fri, Jul 28, 2023 at 06:39:43PM +0200, Thomas Zimmermann wrote:
> Most fbdev drivers operate on I/O memory. And most of those use the
> default implementations for file I/O and console drawing. Convert all
> these low-hanging fruits to the fb_ops initializer macro and Kconfig
> token
that
> the drivers already use.
I have browsed all patches - they all looks good.
Reviewed-by: Sam Ravnborg
On Tue, Jul 25, 2023 at 09:53:16PM +0200, Javier Martinez Canillas wrote:
> Thomas Zimmermann writes:
>
> > Hi
> >
>
> [...]
>
> >>
> >> Yes. I meant to move drivers/video/logo/ to drivers/fbdev/core/logo and to
> >> source its Kconfig from drivers/fbdev/core/Kconfig, since it now depends
> >>
Hi Javier,
> >> > menuconfig LOGO
> >> > bool "Bootup logo"
> >> > - depends on FB || SGI_NEWPORT_CONSOLE
> >> > + depends on FB_CORE || SGI_NEWPORT_CONSOLE
> >> > help
> >> > Enable and select frame buffer bootup logos.
> >>
> >> Should then move this option to driver
623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC
> panels")
> Signed-off-by: Gaosheng Cui
Looks good, thanks for the update.
Reviewed-by: Sam Ravnborg
Hi Gaosheng,
On Mon, Jul 24, 2023 at 10:00:34PM +0800, Gaosheng Cui wrote:
> The mipi_dsi_device_register_full() returns an ERR_PTR() on failure,
> we should use IS_ERR() to check the return value.
>
> By the way, use dev_err_probe instead of dev_err to print the error code.
>
> Fixes: 623a3531e9
nfig dependency to avoid this.
>
> Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight device")
> Signed-off-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
I expect that someone else with drm-misc rights apply the patch.
Sam
Hi Keith,
On Fri, Jul 21, 2023 at 07:57:24PM +0800, Keith Zhao wrote:
> >> +
> >> +struct vs_crtc_funcs {
> >> + void (*enable)(struct device *dev, struct drm_crtc *crtc);
> >> + void (*disable)(struct device *dev, struct drm_crtc *crtc);
> >> + bool (*mode_fixup)(struct device *dev,
> >>
Hi Ying Liu,
On Tue, Jul 18, 2023 at 09:00:25AM +, Ying Liu wrote:
> > > + if (IS_ERR(dsi->regmap)) {
> > > + ret = PTR_ERR(dsi->regmap);
> > > + DRM_DEV_ERROR(dev, "failed to get block ctrl regmap:
> > %d\n", ret);
> >
> > Could you use dev_err_probe here instead?
>
> M
; Signed-off-by: Geert Uytterhoeven
Simpler - nice.
Reviewed-by: Sam Ravnborg
I expect someone else to pick it up.
Sam
ers need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring
Acked-by: Sam Ravnborg
Hi Gaosheng,
On Fri, Jul 14, 2023 at 09:48:18AM +0800, Gaosheng Cui wrote:
> The mipi_dsi_device_register_full() returns an ERR_PTR() on failure,
> we should use IS_ERR() to check the return value.
Correct - so the code is indeed wrong.
Can you update it so we print the error code as this can be
Hi Thomas,
On Tue, Jul 11, 2023 at 08:24:40AM +0200, Thomas Zimmermann wrote:
> Hi Sam
>
> Am 10.07.23 um 19:19 schrieb Sam Ravnborg:
> > Hi Thomas,
> >
> > On Mon, Jul 10, 2023 at 02:50:04PM +0200, Thomas Zimmermann wrote:
> > > Remove the unused flags FB
Hi Thomas,
On Mon, Jul 10, 2023 at 02:50:04PM +0200, Thomas Zimmermann wrote:
> Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT from
> fbdev and drivers, as briefly discussed at [1]. Both flags were maybe
> useful when fbdev had special handling for driver modules. With
> commit 376
Hi Aradhya,
On Tue, Jun 06, 2023 at 01:51:39PM +0530, Aradhya Bhatia wrote:
> With new connector model, sii902x will not create the connector, when
> DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and SoC driver will rely on format
> negotiation to setup the encoder format.
>
> Support format negotiations
t
> b6d5ffce11dd ("drm/panel-simple: Non-eDP panels don't need "HPD" handling")
> whatever is left in this driver is just assigned and never used.
> Drop the remaining parts.
>
> Signed-off-by: Marek Vasut
> ---
> Cc: Daniel Vetter
> Cc: David Airlie
rt for AUO T215HVN01")
> Signed-off-by: Marek Vasut
> ---
> Cc: Daniel Vetter
> Cc: David Airlie
> Cc: Neil Armstrong
> Cc: Sam Ravnborg
> Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Sam Ravnborg
: e5e30dfcf3db ("drm: panel: simple: Defer unprepare delay till next
> prepare to shorten it")
> Signed-off-by: Marek Vasut
Looks OK,
Reviewed-by: Sam Ravnborg
It looks like prepared_time is not used anymore.
Could you dig a little into this while you are in the waiting area.
ice
> ARM: dts: exynos/i9100: Fix LCD screen's physical size
The series looks good.
The first two patches are:
Reviewed-by: Sam Ravnborg
The third patch are:
Acked-by: Sam Ravnborg
(I was not sure if I could/should stamp it r-b, so decided for the a-b).
Sam
Hi all,
On Thu, Jul 06, 2023 at 02:25:16PM -0700, Doug Anderson wrote:
> Hi,
>
> On Tue, Jul 4, 2023 at 12:47 AM Linus Walleij
> wrote:
> >
> > On Thu, Jun 1, 2023 at 5:55 PM Doug Anderson wrote:
> > > On Thu, May 25, 2023 at 2:32 AM Cong Yang
> > > wrote:
> > > >
> > > > The Starry-ili9882 is
nomefb: Generate deferred I/O ops
> fbdev/ssd1307fb: Select FB_SYS_HELPERS_DEFERRED
> fbdev/ssd1307fb: Generate deferred I/O ops
> fbdev/xen-fbfront: Select FB_SYS_HELPERS_DEFERRED
> fbdev/xen-fbfront: Generate deferred I/O ops
Browsed the full series - nice reduction in complexity all over.
Everything looked good so:
Reviewed-by: Sam Ravnborg
On Thu, Jul 06, 2023 at 05:08:51PM +0200, Thomas Zimmermann wrote:
> Use the existing generator macros to create deferred-I/O helpers
> for ssd1307fb and set them in the fb_ops structure. Functions
> for damage handling on memory ranges and areas are provided by
> the driver.
>
> Ssd1307fb's imple
Hi Daniel,
On Wed, Jul 05, 2023 at 03:07:31PM +0100, Daniel Thompson wrote:
> On Tue, Jul 04, 2023 at 07:07:31PM +0200, Sam Ravnborg wrote:
> > Hi Daniel,
> >
> > > > @@ -200,8 +200,8 @@ static int led_bl_probe(struct platform_device
> > > > *pdev)
>
Hi Paul,
On Mon, Jul 03, 2023 at 11:47:14PM +0200, Paul Cercueil wrote:
> Register a backlight device to be able to switch between all the gamma
> levels.
>
> Signed-off-by: Paul Cercueil
> ---
> drivers/gpu/drm/panel/panel-samsung-ld9040.c | 40
> 1 file changed, 40 insert
M070JVHG33")
> > Signed-off-by: Markus Niebel
> > Signed-off-by: Alexander Stein
Reviewed-by: Sam Ravnborg
I hope someone else will pick it up.
Sam
Hi Paul,
On Wed, Jul 05, 2023 at 04:38:05PM +0200, Paul Cercueil wrote:
> Hi Neil,
>
> Le mercredi 05 juillet 2023 à 15:57 +0200, Neil Armstrong a écrit :
> > On 03/07/2023 23:47, Paul Cercueil wrote:
> > > Register a backlight device to be able to switch between all the
> > > gamma
> > > levels.
Hi Daniel,
> > @@ -200,8 +200,8 @@ static int led_bl_probe(struct platform_device *pdev)
> > props.type = BACKLIGHT_RAW;
> > props.max_brightness = priv->max_brightness;
> > props.brightness = priv->default_brightness;
> > - props.power = (priv->default_brightness > 0) ? FB_BLANK_POW
Hi Mohammed,
On Tue, Jul 04, 2023 at 07:19:04PM +0530, Mohammad Faiz Abbas Rizvi wrote:
> Hi Liviu,
>
> On 6/29/2023 3:21 PM, Liviu Dudau wrote:
> > Hi Faiz,
> >
> > Thanks for the patch and for addressing what was at some moment on my "nice
> > to
> > improve / cleanup" list. Sorry for the dela
Hi Julius.
Thanks for posting this. I few nits in the following where you as the
author decide what to ignore and what to update.
Sam
On Sat, Jul 01, 2023 at 02:08:03PM +0200, Julius Zint wrote:
> The Apple Studio Display does not have any physical buttons and the only
> way to get or s
> Closes:
> https://lore.kernel.org/dri-devel/c525adc9-6623-4660-8718-e0c931156...@roeck-us.net/
> Suggested-by: Arnd Bergmann
> Fixes: 4eec0b3048fc ("arch/sparc: Implement fb_is_primary_device() in source
> file")
> Cc: "David S. Miller"
> Cc: Helge D
Hi Manikandan,
On Tue, Jun 13, 2023 at 12:34:23PM +0530, Manikandan Muralidharan wrote:
> - XLCDC in SAM9X7 has different sets of registers and additional
> configuration bits when compared to previous HLCDC IP. Read/write
> operation on the controller registers is now separated using the
> XLCDC
Hi Manikandan,
On Tue, Jun 13, 2023 at 12:34:20PM +0530, Manikandan Muralidharan wrote:
> Add the LCD controller layer definition and descriptor structure for SAM9X7
> for the following layers,
> - Base Layer
> - Overlay1 Layer
> - Overlay2 Layer
> - High End Overlay
>
> Signed-off-by: Manikandan
On Fri, Jun 23, 2023 at 08:50:19PM +0300, Laurent Pinchart wrote:
> Hi Geert,
>
> Thank you for the patch.
>
> On Thu, Jun 22, 2023 at 11:21:51AM +0200, Geert Uytterhoeven wrote:
> > Add DT support, by:
> > 1. Creating a panel bridge from DT, and attaching it to the encoder,
> > 2. Replacing
pe
>
> Signed-off-by: Fabio Estevam
> Fixes: 41bcceb4de9c ("drm/panel: simple: Add support for Innolux AT043TN24")
Looks good.
Reviewed-by: Sam Ravnborg
I expect someone else to pick it up.
Sam
> ---
> Changes since v1:
> - Pass Fixes tag (Neil).
>
> d
Hi Simon,
On Tue, Jun 20, 2023 at 07:01:59PM +, Simon Ser wrote:
> On Tuesday, June 20th, 2023 at 20:58, Sam Ravnborg wrote:
>
> > On Tue, Jun 20, 2023 at 05:55:09PM +, Simon Ser wrote:
> >
> > > This adds more information to the hotplug uevent and lets user
d not occur before.
Asking as I have not really worked with the hotplug stuff.
The code change looks fine - no comment there.
And if there are no user space worries then:
Reviewed-by: Sam Ravnborg
Sam
>
> Signed-off-by: Simon Ser
> Cc: Dmitry Baryshkov
> Cc: Paul Cercueil
tor. This function has nothing to do with
> connected/disconnected: it merely sends a notification that a
> connector's property has changed (e.g. HDCP, privacy screen, etc).
>
> Signed-off-by: Simon Ser
> Cc: Manasi Navare
> Cc: Sam Ravnborg
> Cc: Harry Wentland
> Cc:
Hi Miquel,
On Fri, Jun 16, 2023 at 06:45:24PM +0200, Miquel Raynal wrote:
> From: Thomas Weber
>
> Add support for the Mitsubishi AA084XE01 panel which is an 8.4 inch XGA
> TFT-LCD module for industrial use.
>
> Link: https://www.mouser.fr/datasheet/2/274/aa084xe01_e-364171.pdf
> Signed-off-by:
> > make: *** [Makefile:1978: modpost] Error 2
> >
> > V2: Order alphabetically
> >
> > Signed-off-by: Sui Jingfeng
>
> The patch looks good to me. But I need an ACK from someone else to
> apply to drm-misc-next.
Reviewed-by: Sam Ravnborg
gt; + dw_mipi_dsi_mode_set(dsi, &dsi->mode);
> + if (dsi->slave)
> + dw_mipi_dsi_mode_set(dsi->slave, &dsi->mode);
> +}
> +
> static void dw_mipi_dsi_bridge_mode_set(struct drm_bridge *bridge,
> const struct drm_display_mode *mode,
> const struct drm_display_mode
> *adjusted_mode)
> {
> struct dw_mipi_dsi *dsi = bridge_to_dsi(bridge);
>
> - dw_mipi_dsi_mode_set(dsi, adjusted_mode);
> - if (dsi->slave)
> - dw_mipi_dsi_mode_set(dsi->slave, adjusted_mode);
> + /* Store the display mode for later use in pre_enable callback */
> + memcpy(&dsi->mode, adjusted_mode, sizeof(dsi->mode));
> }
Use drm_mode_copy here.
With this fixed:
Reviewed-by: Sam Ravnborg
On Thu, Jun 15, 2023 at 10:19:00PM +0200, Marek Vasut wrote:
> This bridge seems to need the HSE packet, otherwise the image is
> shifted up and corrupted at the bottom. This makes the bridge
> work with Samsung DSIM on i.MX8MM and i.MX8MP.
>
> Signed-off-by: Marek Vasut
R
; Signed-off-by: Marek Vasut
Reviewed-by: Sam Ravnborg
definitions.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Sam Ravnborg
On Thu, Jun 15, 2023 at 10:18:59PM +0200, Marek Vasut wrote:
> Switch the bridge driver over to atomic ops. No functional change.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Sam Ravnborg
(I hope one day all bridge drivers are converted to atomic ops...)
> ---
> Cc: Andrzej Hajd
re_enable, moving
> the register programming into enable assures it can transmit commands.
>
> Signed-off-by: Marek Vasut
I was about to complain that the use of .enable is deprecated, but the
following patch fixes this.
So:
Reviewed-by: Sam Ravnborg
> ---
> Cc: Andrzej Hajda
> Cc:
On Thu, Jun 15, 2023 at 10:16:35PM +0200, Marek Vasut wrote:
> None of these four bits are bitfields, use BIT() macro and treat
> them as bits. No functional change.
>
> Signed-off-by: Marek Vasut
I always find FLD_VAL() hard to follow.
Reviewed-by: Sam Ravnborg
> ---
> Cc: A
Hi Linus.
On Thu, Jun 15, 2023 at 10:21:38PM +0200, Linus Walleij wrote:
> The DRM panel core already keeps track of if the panel is already
> prepared so do not reimplement this.
>
> Signed-off-by: Linus Walleij
Reviewed-by: Sam Ravnborg
It would be good to rip it out for a
owsed the patch, but it was impossible for me to review in
details due to the massive changes.
But the final result looks good!
With the static added as the robot noticed:
Reviewed-by: Sam Ravnborg
m/panel: simple: Add Powertip PH800480T013 panel")
> Signed-off-by: Marek Vasut
I do not know PowerTip, but the patch looks fine.
Reviewed-by: Sam Ravnborg
> ---
> Cc: Daniel Vetter
> Cc: David Airlie
> Cc: Neil Armstrong
> Cc: Sam Ravnborg
> Cc: dri-devel@lists.
Hi Sandor,
On Thu, Jun 15, 2023 at 09:38:13AM +0800, Sandor Yu wrote:
> Add a new DRM DisplayPort bridge driver for Candence MHDP8501
> used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort
> standards according embedded Firmware running in the uCPU.
>
> For iMX8MQ SOC, the DisplayPort
On Thu, Jun 15, 2023 at 01:22:17AM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Jun 13, 2023 at 08:56:30AM +0200, Miquel Raynal wrote:
> > Hi Michael,
> >
> > michael.rie...@wolfvision.net wrote on Tue, 13 Jun 2023 08:15:26 +0200:
> >
> > > Hi Miquel,
> > >
> > > On 6/9/23 16:59, Miquel Ra
code instead of deleting it then they have my blessing, but without
>a proper fix the old code isn't useful.
>
> I'll list this as "Fixing" the code that made the old code start
> failing. There's not lots of reason to bring this back any further
> than that.
>
> Fixes: 102e80d1fa2c ("drm/bridge: ps8640: Use atomic variants of
> drm_bridge_funcs")
> Signed-off-by: Douglas Anderson
Thanks for fixing this!
Change looks good, and I like that it deletes stuff.
Reviewed-by: Sam Ravnborg
ffer cleanup
> fbdev/radeonfb: Use hardware device as backlight parent
> fbdev/rivafb: Reorder backlight and framebuffer init/cleanup
> fbdev/rivafb: Use hardware device as backlight parent
> fbdev/sh7760fb: Use fb_dbg() in sh7760fb_get_color_info()
> fbdev/sh7760fb: Output mess
Hi Thomas,
On Mon, Jun 12, 2023 at 04:07:59PM +0200, Thomas Zimmermann wrote:
> The driver's backlight code requires the framebuffer to be
> registered. Therefore reorder the cleanup calls for both data
> structures. The init calls are already in the correct order.
>
> Signed-off-by: Thomas Zimme
The device had already been removed at this point.
> Move the call into fb_device_destroy().
>
> Declare the helpers in the new internal header file fb_internal.h, as
> they are only used within the fbdev core module.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
Hi Liu Ying.
On Mon, Jun 12, 2023 at 03:55:30PM +0800, Liu Ying wrote:
> When disabling overlay plane in mxsfb_plane_overlay_atomic_update(),
> overlay plane's framebuffer pointer is NULL. So, dereferencing it would
> cause a kernel Oops(NULL pointer dereferencing). Fix the issue by
> disabling
nt fb_device_create(struct fb_info *fb_info);
> void fb_device_destroy(struct fb_info *fb_info);
> +#else
> +static inline int fb_device_create(struct fb_info *fb_info)
> +{
> + get_device(fb_info->device); // as in device_add()
> +
> + return 0;
> +}
>
log of general boiler plate code.
I briefly looked into the use of regmap for the spi communication,
but it did not look like it supported the bit9 stuff.
I did not stare enough to add a reviewd by, but the approach is fine
and it is good to detech issues early.
Acked-by: Sam Ravnborg
>
On Fri, Jun 09, 2023 at 04:59:50PM +0200, Miquel Raynal wrote:
> This panel from Emerging Display Technologies Corporation features an
> ST7789V2 panel inside which is almost identical to what the Sitronix
> panel driver supports.
>
> In practice, the module physical size is specific, and experime
> move all the panel-specific information into a dedicated structure that
> is available as platform data.
>
> There is no functional change.
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Sam Ravnborg
On Fri, Jun 09, 2023 at 04:59:47PM +0200, Miquel Raynal wrote:
> The LCD controller supports RGB444, RGB565 and RGB888. The value that is
> written in the COLMOD register indicates using RGB888, so let's clearly
> specify the in-use bus format.
Confused.
MEDIA_BUS_FMT_RGB666_1X18 assumes 6 bits pe
= spi_setup(spi);
> + if (ret < 0) {
> + dev_err(&spi->dev, "spi_setup failed: %d\n", ret);
> + return ret;
> + }
Use dev_err_probe().
With this change:
Reviewed-by: Sam Ravnborg
> +
> drm_panel_init(&ctx->panel, &spi->dev, &st7789v_drm_funcs,
> DRM_MODE_CONNECTOR_DPI);
>
> --
> 2.34.1
refix (as it is usually done).
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> b/drivers/gp
x27;s support
> this DRM flag.
>
> Signed-off-by: Miquel Raynal
Hi Miquel,
the patch is:
Reviewed-by: Sam Ravnborg
I hope someone else can pick it up and apply it to drm-misc as
my drm-misc setup is hopelessly outdated atm.
Sam
> ---
>
> Hello, this change was t
lobal variable fb_class, which is only shared internally
> within the fbdev core module.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
> ---
> drivers/video/fbdev/core/fb_internal.h | 1 +
> drivers/video/fbdev/core/fbcon.c | 1
.
With or without this move:
Reviewed-by: Sam Ravnborg
> ---
> drivers/video/fbdev/core/Makefile | 1 +
> drivers/video/fbdev/core/fb_devfs.c| 484 +
> drivers/video/fbdev/core/fb_internal.h | 6 +
> drivers/video/fbdev/core/fbmem.c | 4
ange to use proc_remove is not really documented.
But code looks ok.
I am not fan that we have introduced a few globals again.
But it looks like the way to go for now.
>
> Signed-off-by: Thomas Zimmermann
With an improved changelog:
Reviewed-by: Sam Ravnborg
> ---
> drivers/video/fbdev/
Hi Thomas,
On Mon, Jun 05, 2023 at 04:48:08PM +0200, Thomas Zimmermann wrote:
> Move the logic to create and destroy fbdev devices into the new
> helpers fb_device_create() and fb_device_destroy().
>
> There was a call to fb_cleanup_device() in do_unregister_framebuffer()
> that was too late. The
PL-2.0-or-later copyright, while fbmem.c is GPL-2.0.
>
> Signed-off-by: Thomas Zimmermann
Some nits that you decide what to do with.
Reviewed-by: Sam Ravnborg
I do not get why they are moved out in separate files.
I guess the picture will materialize later.
Sam
> ---
> driver
uch. It is only a token within the internal list of known devices.
> The PM functions do not refer to any of the device's properties or its
> type.
>
> Signed-off-by: Thomas Zimmermann
> Cc: "Rafael J. Wysocki"
> Cc: Pavel Machek
> Cc: linux...@vger.kernel.or
Hi Michael.
> >
> >Fixes a bug in the backlight driver and prepares fbdev for making
> >struct fb_info.dev optional.
>
> I only see a rename from fbdev to dev...
>
> Is there missing code?
>
> Would a fixes: be useful?
>
> M
>
> >@@ -35,7 +35,7 @@ static int gpio_backlight_check_fb(struct
>
Hi Thomas,
> > > - if (helper->funcs->fb_dirty) {
> > > - drm_fb_helper_memory_range_to_clip(info, pos, ret,
> > > &damage_area);
> > > - drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1,
> > > - drm_rect_width(&damage_area),
> > > -
drivers/gpu/drm/drm_fb_helper.c| 107 -
> drivers/gpu/drm/i915/Kconfig | 1 +
> drivers/gpu/drm/i915/display/intel_fbdev.c | 14 +--
> include/drm/drm_fb_helper.h| 39
> 5 files changed, 9 insertions(+), 155 deletions(-)
Nice diffstat!
Assuming there is a good explanation on the dirty check:
Reviewed-by: Sam Ravnborg
bdev-generic and i915 need them. Both will be updated to implement
> damage handling by themselves and the exported functions will be removed.
>
> v4:
> * update interfaces
>
> Signed-off-by: Thomas Zimmermann
Assuming there is a good answer why there is no dirty ch
I/O helpers
> drm/tegra: Use regular fbdev I/O helpers
These are all:
Acked-by: Sam Ravnborg
Hi Thomas,
On Wed, May 24, 2023 at 11:21:50AM +0200, Thomas Zimmermann wrote:
> Implement dedicated fbdev helpers for framebuffer I/O instead
> of using DRM's helpers. Use an fbdev generator macro for
> deferred I/O to create the fbdev callbacks. i915 was the only
> caller of the DRM helpers, so r
pers directly within each DRM fbdev emulation,
> we can eventually remove DRM's wrapper functions entirely.
>
> v4:
> * use initializer macros for struct fb_ops
> v2:
> * use FB_IO_HELPERS option
>
> Signed-off-by: Thomas Zimmermann
> Cc: Russell King
Acked-by: Sam Ravnborg
so maybe it is just me.
And everything looks consistent, so OK.
With the white space issues fixed:
Reviewed-by: Sam Ravnborg
lify
> fbdev's driver configs.
>
> v3:
> * fix select statement (Jingfeng)
>
> Signed-off-by: Thomas Zimmermann
I like these, thanks.
Reviewed-by: Sam Ravnborg
& charmask) * (w * vc->vc_font.height));
When browsing the code I noticed another use of vc->vc_font.data.
bit_putcs_{un}aligned() access vc->vc_font.data too, so I wonder if
bit_putcs() should also check for vc->vc_font.data?
bit_putcs() is the only user of bit_putcs_{un}aligned.
The actual patch here looks good from a quick browsing around, but I
cannot claim I did a review. But you have my:
Acked-by: Sam Ravnborg
Sam
Hi Thomas,
On Mon, May 15, 2023 at 11:40:23AM +0200, Thomas Zimmermann wrote:
> Use the regular fbdev helpers for framebuffer I/O instead of DRM's
> helpers. Armada does not use damage handling, so DRM's fbdev helpers
> are mere wrappers around the fbdev code.
>
> By using fbdev helpers directly
Hi Thomas,
On Mon, May 15, 2023 at 11:40:24AM +0200, Thomas Zimmermann wrote:
> Use the regular fbdev helpers for framebuffer I/O instead of DRM's
> helpers. Exynos does not use damage handling, so DRM's fbdev helpers
> are mere wrappers around the fbdev code.
>
> By using fbdev helpers directly
On Fri, May 12, 2023 at 02:02:31PM +0200, Javier Martinez Canillas wrote:
> This is a leftover from an early iteration of the driver when it was still
> named ssd1307 instead of ssd130x. Change it for consistency with the rest.
>
> Signed-off-by: Javier Martinez Canillas
Revi
Hi Thomas,
> >
> > Nice cleanup.
> >
> > From one of the patches:
> >
> > > +config DRM_ARMADA_FBDEV_EMULATION
> > > + bool
> > > + depends on DRM_ARMADA
> > > + select FB_CFB_COPYAREA
> > > + select FB_CFB_FILLRECT
> > > + select FB_CFB_IMAGEBLIT
> >
> > This seems like a
101 - 200 of 2141 matches
Mail list logo
