[PATCH v6 00/35] component: Make into an aggregate bus

2022-01-27 Thread Stephen Boyd
ops that takes the aggregate device - Convert all drivers in the tree to use the aggregate driver approach - Allow one aggregate driver to be used for multiple aggregate devices [1] https://lore.kernel.org/r/20210508074118.1621729-1-swb...@chromium.org Stephen Boyd (35): component: Replace

Re: [PATCH] drm/msm/dp: add connector type to enhance debug messages

2022-01-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-24 14:44:52) > DP driver is a generic driver which supports both eDP and DP. > For debugging purpose it is required to have capabilities to > differentiate message are generated from eDP or DP. This patch > add connector type into debug messages for this purpose. > >

Re: [PATCH] drm/msm/dp: always add fail-safe mode into connector mode list

2022-01-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-24 13:24:25) > > On 1/24/2022 1:04 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-01-24 12:46:10) > >> Some of DP link compliant test expects to return fail-safe mode > >> if prefer detailed timing mode can not be supported by

Re: [PATCH] drm/msm/dp: always add fail-safe mode into connector mode list

2022-01-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-24 12:46:10) > Some of DP link compliant test expects to return fail-safe mode > if prefer detailed timing mode can not be supported by mainlink's > lane and rate after link training. Therefore add fail-safe mode > into connector mode list as backup mode. This patch

Re: [PATCH v3 01/10] clk: Add Kunit tests for rate

2022-01-21 Thread Stephen Boyd
Quoting Daniel Latypov (2022-01-20 21:25:03) > On Thu, Jan 20, 2022 at 8:34 PM Stephen Boyd wrote: > > > > Quoting Daniel Latypov (2022-01-20 13:56:39) > > > On Thu, Jan 20, 2022 at 1:31 PM Stephen Boyd wrote: > > > KUnit doesn't have hard technical limitation

Re: [PATCH v3 2/3] drm/msm/dpu: simplify clocks handling

2022-01-21 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-20 23:37:45) > On Fri, 21 Jan 2022 at 07:30, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2022-01-19 14:16:15) > > > diff --git a/drivers/gpu/drm/msm/msm_io_utils.c > > > b/drivers/gpu/drm/msm/msm_io_utils.c > > &g

Re: [PATCH v3 01/10] clk: Add Kunit tests for rate

2022-01-20 Thread Stephen Boyd
Quoting Daniel Latypov (2022-01-20 13:56:39) > On Thu, Jan 20, 2022 at 1:31 PM Stephen Boyd wrote: > > I was thinking this would be more generic so that one file tests clk.c > > and all the code in there, but I guess there may be config dependencies > > like CONFIG_OF that w

Re: [PATCH v3 2/3] drm/msm/dpu: simplify clocks handling

2022-01-20 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-19 14:16:15) > diff --git a/drivers/gpu/drm/msm/msm_io_utils.c > b/drivers/gpu/drm/msm/msm_io_utils.c > index 7b504617833a..5533c87c7158 100644 > --- a/drivers/gpu/drm/msm/msm_io_utils.c > +++ b/drivers/gpu/drm/msm/msm_io_utils.c > @@ -5,6 +5,8 @@ > * Author:

Re: [PATCH v3 01/10] clk: Add Kunit tests for rate

2022-01-20 Thread Stephen Boyd
Quoting Maxime Ripard (2022-01-20 06:34:08) > Let's test various parts of the rate-related clock API with the kunit > testing framework. > > Cc: kunit-...@googlegroups.com > Suggested-by: Stephen Boyd > Signed-off-by: Maxime Ripard > --- This is great! Thanks for doing

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-19 Thread Stephen Boyd
1st arg cell > - description: 2nd arg cell > > With this change, some examples need updating so that the bracketing of > property values matches the schema. [..] > Signed-off-by: Rob Herring > --- Acked-by: Stephen Boyd

Re: [PATCH v18 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-18 Thread Stephen Boyd
anges in v17: > -- remove core_initialized checking before execute attention_cb() > > Changes in v18: > -- remove core_initialized checking at dp_pm_suspend > > Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon > Chipsets") > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-14 Thread Stephen Boyd
Quoting Yong Wu (2022-01-14 23:39:52) > On Fri, 2022-01-14 at 15:30 -0600, Stephen Boyd wrote: > > > > This sounds more correct to me. I'm not an expert on runtime PM > > though > > as I always have to read the code to remember how it works. if the > > device

Re: [PATCH v17 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-14 16:58:32) > @@ -1363,14 +1368,14 @@ static int dp_pm_suspend(struct device *dev) > if (dp_power_clk_status(dp->power, DP_CTRL_PM)) > dp_ctrl_off_link_stream(dp->ctrl); > > + dp_display_host_phy_exit(dp); > + > +

Re: [PATCH v15 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-14 14:28:52) > > On 1/14/2022 1:41 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-01-14 13:11:47) > >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > >> b/drivers/gpu/drm/msm/dp/dp_display.c > >> index 7cc4d21..7c

Re: [PATCH v2 1/3] clk: Introduce a clock request API

2022-01-14 Thread Stephen Boyd
Quoting Maxime Ripard (2022-01-14 08:15:56) > On Thu, Jan 13, 2022 at 01:44:25PM -0800, Stephen Boyd wrote: > > > > I don't see a problem with re-evaluating the rate every time we call > > clk_set_rate_range(). That's probably the bug that I can't recall. Can > >

Re: [PATCH v2 1/3] clk: Introduce a clock request API

2022-01-14 Thread Stephen Boyd
Quoting Maxime Ripard (2022-01-14 08:15:56) > On Thu, Jan 13, 2022 at 01:44:25PM -0800, Stephen Boyd wrote: > > > > > I don't see a problem with re-evaluating the rate every time we call > > clk_set_rate_range(). That's probably the bug that I can't recall. Can > &g

Re: [PATCH v15 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-14 13:11:47) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 7cc4d21..7cd6222 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -696,12 +699,9 @@ static int

Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-14 Thread Stephen Boyd
Quoting Yong Wu (2022-01-14 01:06:31) > On Wed, 2022-01-12 at 20:25 -0800, Stephen Boyd wrote: > > > > > > [2.654526] [ cut here ] > > > [2.68] refcount_t: addition on 0; use-after-free. > > > > > > After this pa

Re: [PATCH v14 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-14 09:54:31) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 7cc4d21..2616f7b 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -372,21 +373,38 @@ static int

Re: [PATCH v13 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-13 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-13 15:53:36) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 7cc4d21..b3c5404 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -83,6 +83,7 @@ struct

Re: [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-13 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-13 14:14:27) > > On 1/13/2022 1:52 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-01-13 12:44:16) > >> On 1/13/2022 11:47 AM, Stephen Boyd wrote: > >>> Quoting Kuogee Hsieh (2022-01-13 09:51:42) > >>&

Re: [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-13 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-13 12:44:16) > > On 1/13/2022 11:47 AM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-01-13 09:51:42) > >> On 1/12/2022 8:13 PM, Stephen Boyd wrote: > >>>>>> - if (dp->usbpd->orientation == ORIEN

Re: [PATCH v2 1/3] clk: Introduce a clock request API

2022-01-13 Thread Stephen Boyd
Quoting Maxime Ripard (2022-01-12 03:46:52) > Hi Stephen, > > Thanks for your answer > > On Tue, Jan 11, 2022 at 07:37:15PM -0800, Stephen Boyd wrote: > > Sorry for being super delayed on response here. I'm buried in other > > work. +Jerome for exclusive clk API. >

Re: [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-13 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-13 09:51:42) > > On 1/12/2022 8:13 PM, Stephen Boyd wrote: > >>>> - if (dp->usbpd->orientation == ORIENTATION_CC2) > >>>> - flip = true; > >>>> + dp_power_init(dp->power,

Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-12 Thread Stephen Boyd
Quoting Yong Wu (2022-01-12 01:09:19) > On Tue, 2022-01-11 at 16:27 -0800, Stephen Boyd wrote: > > ---8<--- > > diff --git a/drivers/base/component.c b/drivers/base/component.c > > index 64ad7478c67a..97f253a41bdf 100644 > > --- a/drivers/base/component.c >

Re: [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-12 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-12 14:17:54) > > On 1/12/2022 12:00 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-01-11 10:43:23) > >> Current DP drivers have regulators, clocks, irq and phy are grouped > >> together within a function and exec

Re: [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

2022-01-12 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-11 10:43:23) > Current DP drivers have regulators, clocks, irq and phy are grouped > together within a function and executed not in a symmetric manner. > This increase difficulty of code maintenance and limited code scalability. > This patch divides the driver life

Re: [PATCH v2 1/3] clk: Introduce a clock request API

2022-01-11 Thread Stephen Boyd
Sorry for being super delayed on response here. I'm buried in other work. +Jerome for exclusive clk API. Quoting Maxime Ripard (2021-09-14 02:35:13) > It's not unusual to find clocks being shared across multiple devices > that need to change the rate depending on what the device is doing at a >

Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-11 Thread Stephen Boyd
Quoting Yong Wu (2022-01-11 04:22:23) > Hi Stephen, > > Thanks for helping update here. > > On Thu, 2022-01-06 at 13:45 -0800, Stephen Boyd wrote: > > Use an aggregate driver instead of component ops so that we can get > > proper driver probe ordering of the ag

Re: [PATCH 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-07 Thread Stephen Boyd
Quoting Rob Clark (2022-01-06 10:14:46) > From: Rob Clark > > System suspend uses pm_runtime_force_suspend(), which cheekily bypasses > the runpm reference counts. This doesn't actually work so well when the > GPU is active. So add a reasonable delay waiting for the GPU to become > idle. Maybe

Re: [PATCH v5 03/32] component: Move struct aggregate_device out to header file

2022-01-07 Thread Stephen Boyd
Quoting Jani Nikula (2022-01-07 05:07:59) > On Thu, 06 Jan 2022, Stephen Boyd wrote: > > This allows aggregate driver writers to use the device passed to their > > probe/remove/shutdown functions properly instead of treating it as an > > opaque pointer. > > You say it

Re: [RFC PATCH 2/7] drm/msm/dp: support attaching bridges to the DP encoder

2022-01-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-06 18:01:27) > Currently DP driver will allocate panel bridge for eDP panels. > Simplify this code to just check if there is any next bridge in the > chain (be it a panel bridge or regular bridge). Rename panel_bridge > field to next_bridge accordingly. > >

Re: [RFC PATCH 1/7] drm/msm/dp: fix panel bridge attachment

2022-01-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-06 18:01:26) > In commit 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display > enable and disable") the DP driver received a drm_bridge instance, which > is always attached to the encoder as a root bridge. However it conflicts > with the panel_bridge

Re: [RFC PATCH 0/7] Simplify and correct msm/dp bridge implementation

2022-01-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-06 18:01:25) > I noticed that commit 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for > display > enable and disable") conflicts with the panel-edp (panel bridge) > support. Both bridges will try to attach directly to the drm encoder > itself. I started

Re: [PATCH v4 5/5] drm/msm/dpu: move VBIF blocks handling to dpu_rm

2022-01-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-05 15:10:31) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > index bf4d72356a12..2301ac114920 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > @@ -78,6 +78,10

Re: [PATCH v4 4/5] drm/msm/dpu: stop embedding dpu_hw_blk into dpu_hw_intf

2022-01-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-05 15:10:30) > Now as dpu_hw_intf is not hanled by dpu_rm_get_assigned_resources, there s/hanled/handled/ > is no point in embedding the (empty) struct dpu_hw_blk into dpu_hw_intf > (and using typecasts between dpu_hw_blk and dpu_hw_intf). Drop it and > use

Re: [PATCH v4 4/5] drm/msm/dpu: stop embedding dpu_hw_blk into dpu_hw_intf

2022-01-06 Thread Stephen Boyd
ntf directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4 3/5] drm/msm/dpu: get INTF blocks directly rather than through RM

2022-01-06 Thread Stephen Boyd
m outside of RM and use them directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4 2/5] drm/msm/dpu: add DSPP blocks teardown

2022-01-06 Thread Stephen Boyd
y Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4 1/5] drm/msm/dpu: drop unused lm_max_width from RM

2022-01-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-05 15:10:27) > No code uses lm_max_width from resource manager, so drop it. Instead of > calculating the lm_max_width, code can use max_mixer_width field from > the hw catalog. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2] drm/msm: reduce usage of round_pixclk callback

2022-01-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-05 23:06:56) > The round_pixclk() callback returns different rate only on MDP4 in HDMI > (DTV) case. Stop using this callback in other cases to simplify > mode_valid callbacks. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4] drm/msm/dp: populate connector of struct dp_panel

2022-01-06 Thread Stephen Boyd
ul kernel crash trace commit text > -- remove renaming dp_display parameter to dp > > Changes in V4: > -- add more details to commit text > > Fixes: 7948fe12d47 ("drm/msm/dp: return correct edid checksum after corrupted > edid checksum read") > Signee-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-06 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-06 09:14:56) > @@ -1189,12 +1190,20 @@ static int dp_ctrl_link_train_2(struct > dp_ctrl_private *ctrl, > > *training_step = DP_TRAINING_2; > > - if (drm_dp_tps3_supported(ctrl->panel->dpcd)) > + if (drm_dp_tps4_supported(ctrl->panel->dpcd)) { > +

Re: [PATCH v3] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-06 Thread Stephen Boyd
is should be } else { > pattern = DP_TRAINING_PATTERN_2; > + state_ctrl_bit = 2; > + } > > - ret = dp_catalog_ctrl_set_pattern(ctrl->catalog, pattern); > + ret = dp_catalog_ctrl_set_pattern_state_bit(ctrl->catalog, > state_ctrl_bit); > if (ret) > return ret; > With that fixed Reviewed-by: Stephen Boyd

[PATCH v5 32/32] component: Remove component_master_ops and friends

2022-01-06 Thread Stephen Boyd
The struct is unused now so drop it along with the functions that use it. Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/componen

[PATCH v5 30/32] ASoC: codecs: wcd938x: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- sound/soc/codecs/wcd938x.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 52de7d14b139..f44f5d41bfdb 100644 -

[PATCH v5 31/32] component: Get rid of drm_of_component_probe()

2022-01-06 Thread Stephen Boyd
There aren't any users anymore so drop it. Cc: Laurent Pinchart Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/drm

[PATCH v5 29/32] sound: hdac: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
socki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- sound/hda/hdac_component.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/sound/hda/hdac_component.c b/sound/hda/hdac_component.c index bb37e7e0bd79..9e

[PATCH v5 28/32] fbdev: omap2: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/video/fbdev/omap2/omapfb/dss/dss.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c index a6b1c1598040..f1

[PATCH v5 27/32] power: supply: ab8500: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
ael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/power/supply/ab8500_charger.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/po

[PATCH v5 26/32] mei: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Bergmann Cc: Greg Kroah-Hartman Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Cc: Alexander Usyskin Signed-off-by: Stephen Boyd --- drivers/misc/mei/hdcp/mei_hdcp.c | 22 +- drivers/misc/mei/pxp/mei_px

[PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/iommu/mtk_iommu.c| 14 +- drivers/iommu/mtk_iommu.h| 6 -- drivers/iommu/mtk_iommu_v1.c | 14 +- 3 files changed, 22 insertions(+), 12 deletions(-) diff --git

[PATCH v5 24/32] drm/vc4: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/vc4/vc4_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 16abc3a3d601..82a44ebf9

[PATCH v5 23/32] drm/tilcdc: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_d

[PATCH v5 21/32] drm/sti: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
ana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/sti/sti_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c index c7efb43b83ee..b277cc679154 100644 --- a/drivers/gpu/drm/sti/sti_d

[PATCH v5 22/32] drm/sun4i: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/sun4i/sun4i_drv.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c index 54

[PATCH v5 20/32] drm/rockchip: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchi

[PATCH v5 18/32] drm/meson: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/meson/meson_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c index 7f41a33592c8..3028f2a45

[PATCH v5 19/32] drm/omap: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/omapdrm/dss/dss.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c index d6a5862b4dbf..9328d97f1

[PATCH v5 17/32] drm/mediatek: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index ae

[PATCH v5 16/32] drm/mcde: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
ana Kannan Tested-by: Linus Walleij Signed-off-by: Stephen Boyd --- drivers/gpu/drm/mcde/mcde_drv.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c index 5b5afc6aaf8e..1652f9e06

[PATCH v5 15/32] drm/ingenic: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 25 +-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-dr

[PATCH v5 14/32] drm/imx: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/imx/imx-drm-core.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index cb685fe2039b..9e28bb163

[PATCH v5 13/32] drm/exynos: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drive

[PATCH v5 12/32] drm/kirin: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 20 --- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_dr

[PATCH v5 11/32] drm/etnaviv: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
socki" Cc: Rob Clark Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 7d

[PATCH v5 10/32] drm/armada: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
ana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/armada/armada_drv.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c index 8e3e98f13db4..b3559363ea43 100644 --- a/drive

[PATCH v5 08/32] drm/arm/hdlcd: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/arm/hdlcd_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c index 479c2422a2e0..5c03eb98d814 100644 --- a/drive

[PATCH v5 05/32] drm/of: Add a drm_of_aggregate_probe() API

2022-01-06 Thread Stephen Boyd
c: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/drm_of.c | 85 +++- include/drm/drm_of.h | 12 ++ 2 files changed, 78 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_

[PATCH v5 09/32] drm/malidp: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
: Laurent Pinchart Cc: Liviu Dudau Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/arm/malidp_drv.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git

[PATCH v5 07/32] drm/komeda: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
; Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- .../gpu/drm/arm/display/komeda/komeda_drv.c | 20 --- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/disp

[PATCH v5 06/32] drm/msm: Migrate to aggregate driver

2022-01-06 Thread Stephen Boyd
shutdown hooks are called. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/msm/msm_drv.c | 46 +++ 1 file changed, 25 insertions(+), 21 deletions(-) diff --git

[PATCH v5 04/32] component: Add {bind, unbind}_component() ops that take aggregate device

2022-01-06 Thread Stephen Boyd
l King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 14 +++--- include/linux/component.h | 22 ++ 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/base/component.c b/drivers/base/component.c index dc38a8939ae6..e9

[PATCH v5 03/32] component: Move struct aggregate_device out to header file

2022-01-06 Thread Stephen Boyd
: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 15 --- include/linux/component.h | 19 --- 2 files changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/base/component.c b/drivers/base/component.c index eec82caeae5e..dc38a8939

[PATCH v5 02/32] component: Introduce the aggregate bus_type

2022-01-06 Thread Stephen Boyd
in the correct order. Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Laurent Pinchart Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 471 -- include/linux/compone

[PATCH v5 01/32] component: Replace most references to 'master' with 'aggregate device'

2022-01-06 Thread Stephen Boyd
and register with the component framework. Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Laurent Pinchart Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 242 +++--- inc

[PATCH v5 00/32] component: Make into an aggregate bus

2022-01-06 Thread Stephen Boyd
aggregate driver to be used for multiple aggregate devices [1] https://lore.kernel.org/r/20210508074118.1621729-1-swb...@chromium.org Stephen Boyd (32): component: Replace most references to 'master' with 'aggregate device' component: Introduce the aggregate bus_type component: Move struct

Re: [PATCH v4 01/34] component: Introduce struct aggregate_device

2022-01-05 Thread Stephen Boyd
Quoting Greg Kroah-Hartman (2021-12-21 01:29:59) > > @@ -471,9 +477,17 @@ int component_master_add_with_match(struct device > > *parent, > > if (!master) > > return -ENOMEM; > > > > + id = ida_alloc(_ida, GFP_KERNEL); > > + if (id < 0) { > > +

Re: [PATCH v4 01/34] component: Introduce struct aggregate_device

2022-01-05 Thread Stephen Boyd
Quoting Greg Kroah-Hartman (2021-12-21 01:28:10) > On Thu, Dec 02, 2021 at 02:26:59PM -0800, Stephen Boyd wrote: > > Replace 'struct master' with 'struct aggregate_device' and then rename > > 'master' to 'adev' everywhere in the code. While we're here, put a > > struct device

Re: [v1 1/2] dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties

2022-01-05 Thread Stephen Boyd
Quoting Rajeev Nandan (2021-12-30 01:24:35) > Add 10nm dsi phy tuning properties for phy drive strength and > phy drive level adjustemnt. s/adjustemnt/adjustment/ Please add the details about parasitics and eye shape tuning to this commit text. > > Signed-off-by: Rajeev Nandan > --- >

Re: [PATCH v2 3/3] drm/msm: move msm_readl/_writel to msm_drv.h

2022-01-05 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd Any chance this can go further and replace msm_readl/msm_writel with readl/writel directly?

Re: [PATCH v2 2/3] drm/msm: drop dbgname argument from msm_ioremap*()

2022-01-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-05 15:26:59) > msm_ioremap() functions take additional argument dbgname which is now > unused. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 1/3] drm/msm: drop register logging support

2022-01-05 Thread Stephen Boyd
Rob imported freedreno tools into mesa. All this makes > DRM_MSM_REGISTER_LOGGING irrelevant now, so it can be dropped. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm/dp: Simplify dp_debug_init() and dp_debug_get()

2022-01-05 Thread Stephen Boyd
Quoting Christophe JAILLET (2021-12-22 11:33:47) > dp_debug_init() always returns 0. So, make it a void function and simplify > the only caller accordingly. > > While at it remove a useless 'rc' initialization in dp_debug_get() > > Signed-off-by: Christophe JAILLET > ---

Re: [PATCH v2] drm/msm/dp: populate connector of struct dp_panel

2022-01-05 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-12-29 11:17:02) > There is kernel crashed due to unable to handle kernel NULL > pointer dereference of dp_panel->connector while running DP link > layer compliance test case 4.2.2.6 (EDID Corruption Detection). Can you explain how we get into that situation? Like "We

Re: [PATCH] drm/msm/dp: stop link training after link training 2 failed

2022-01-05 Thread Stephen Boyd
is failed so that next > link training 1 can start freshly. This patch fixes link compliance > test case 4.3.1.13 (Source Device Link Training EQ Fallback Test). > > Fixes: 2e0adc765d88 ("drm/msm/dp: do not end dp link training until video is > ready") > Signed-off-by: K

Re: [PATCH v2] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2022-01-05 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-12-29 10:15:45) > diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.h > b/drivers/gpu/drm/msm/dp/dp_catalog.h > index 6965afa..7dea101 100644 > --- a/drivers/gpu/drm/msm/dp/dp_catalog.h > +++ b/drivers/gpu/drm/msm/dp/dp_catalog.h > @@ -94,7 +94,7 @@ void

Re: [PATCH] drm/msm/dp: Fix a potential double free in an error handling path

2022-01-05 Thread Stephen Boyd
d-off-by: Christophe JAILLET > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 0/2] Use "ref" clocks from firmware for DSI PLL VCO parent

2021-12-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-12-15 12:02:37) > On 14/12/2021 22:46, Marijn Suijten wrote: > > Hi all, > > > > On 2021-09-18 16:40:38, Marijn Suijten wrote: > >> On 2021-09-14 14:44:01, Stephen Boyd wrote: > >>> Quoting Marijn Suijten (2021-09-11 06:

Re: [PATCH] drm/msm/dp: remove unneeded variable

2021-12-15 Thread Stephen Boyd
Quoting cgel@gmail.com (2021-12-15 00:55:54) > From: Changcheng Deng > > Remove unneeded variable used to store return value. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- Reviewed-by: Stephen Boyd

Re: [PATCH 2/2] drm/msm/dpu: add dpu_plane_atomic_print_state

2021-12-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-12-15 08:09:12) > Implement plane's atomic_print_state() callback, printing DPU-specific > plane state: blending stage, SSPP and multirect mode and index. > > Signed-off-by: Dmitry Baryshkov > --- Same const comment applies here Reviewed-by: Stephen Boyd

Re: [PATCH 1/2] drm/msm/dpu: add dpu_crtc_atomic_print_state

2021-12-15 Thread Stephen Boyd
> + struct dpu_crtc_state *cstate = to_dpu_crtc_state(state); const? Then we know at a glance that this isn't changing the state. Reviewed-by: Stephen Boyd

Re: [PATCH] drm/msm: Don't use autosuspend for display

2021-12-15 Thread Stephen Boyd
about why it's not a good idea to use autosuspend for display things. Then this commit can be dug out of the history and someone new can quickly understand the reasoning behind it. Just saying it's not a good idea doesn't really help. > > Signed-off-by: Rob Clark > --- Reviewed-by: Stephen Boyd

Re: [PATCH v7 2/2] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-12-09 13:35:07) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 0766752..cfbc5e4 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -83,6 +83,7 @@ struct

[PATCH] drm/bridge: ti-sn65dsi86: Set max register for regmap

2021-12-14 Thread Stephen Boyd
Set the maximum register to 0xff so we can dump the registers for this device in debugfs. Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver") Cc: Rob Clark Cc: Douglas Anderson Cc: Laurent Pinchart Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/ti-s

Re: [PATCH v4 00/34] component: Make into an aggregate bus

2021-12-13 Thread Stephen Boyd
Quoting Daniel Vetter (2021-12-07 10:22:15) > On Thu, Dec 02, 2021 at 02:26:58PM -0800, Stephen Boyd wrote: > > This series is from discussion we had on reordering the device lists for > > drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put > > the

Re: [PATCH v4 14/14] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2021-12-09 Thread Stephen Boyd
Quoting Sean Paul (2021-11-04 20:04:31) > From: Sean Paul > > This patch adds HDCP 1.x support to msm DP connectors using the new HDCP $ git grep "This patch" -- Documentation/process/ > helpers. > > Cc: Stephen Boyd > Cc: Abhinav Kumar > Signed-o

Re: [PATCH v5] drm/msm/dp: dp_link_parse_sink_count() return immediately if aux read failed

2021-12-09 Thread Stephen Boyd
his patch as stand alone patch > > Changes in v5: > -- rebase on msm-next branch > > Signed-off-by: Kuogee Hsieh > Remove this newline please. > Reviewed-by: Stephen Boyd > Tested-by: Stephen Boyd > --- > drivers/gpu/drm/msm/dp/dp_display.c | 12

Re: [PATCH v6] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-09 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-12-08 12:36:24) > Current DP drivers have regulators, clocks, irq and phy are grouped > together within a function and executed not in a symmetric manner. > This increase difficulty of code maintenance and limited code scalability. > This patch divided the driver life

Re: [PATCH v3] drm/bridge: sn65dsi86: defer if there is no dsi host

2021-12-07 Thread Stephen Boyd
sed in the conversion to attach dsi host at > probe time. > > Fixes: c3b75d4734cb ("drm/bridge: sn65dsi86: Register and attach our DSI > device at probe") > Signed-off-by: Rob Clark > Reviewed-by: Doug Anderson > --- Reviewed-by: Stephen Boyd One more nit below > v2:

<    1   2   3   4   5   6   7   8   9   10   >