Re: [REGRESSION]: acpi/nouveau: Hardware unavailable upon resume or suspend fails

2023-11-10 Thread Kai-Heng Feng
Hi Hans, On Fri, Nov 10, 2023 at 2:19 PM Hans de Goede wrote: > > Hi All, > > On 11/10/23 07:09, Kai-Heng Feng wrote: > > Hi Owen, > > > > On Fri, Nov 10, 2023 at 5:55 AM Owen T. Heisler wrote: > >> > >> #regzbot introduced: 89c290ea758911e660

Re: [REGRESSION]: acpi/nouveau: Hardware unavailable upon resume or suspend fails

2023-11-09 Thread Kai-Heng Feng
Hi Owen, On Fri, Nov 10, 2023 at 5:55 AM Owen T. Heisler wrote: > > #regzbot introduced: 89c290ea758911e660878e26270e084d862c03b0 > #regzbot link: https://gitlab.freedesktop.org/drm/nouveau/-/issues/273 > #regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=218124 Thanks for the bug

Re: [PATCH 1/2] drm/amdgpu: Reset GPU on S0ix when device supports BOCO

2023-03-29 Thread Kai-Heng Feng
On Wed, Mar 29, 2023 at 9:23 PM Mario Limonciello wrote: > > > On 3/29/23 04:59, Kai-Heng Feng wrote: > > When the power is lost due to ACPI power resources being turned off, the > > driver should reset the GPU so it can work anew. > > > > First, _PR3 support o

Re: [PATCH 1/2] drm/amdgpu: Reset GPU on S0ix when device supports BOCO

2023-03-29 Thread Kai-Heng Feng
On Wed, Mar 29, 2023 at 9:21 PM Alex Deucher wrote: > > On Wed, Mar 29, 2023 at 6:00 AM Kai-Heng Feng > wrote: > > > > When the power is lost due to ACPI power resources being turned off, the > > driver should reset the GPU so it can work anew. > > > > Fir

[PATCH 2/2] drm/amdgpu: Remove ASPM workaround on VI and NV

2023-03-29 Thread Kai-Heng Feng
Since the original issue is resolved by a new fix, the ASPM workaround can be dropped. Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 15 --- drivers/gpu/drm/amd/amdgpu/nv.c| 2 +- drivers

[PATCH 1/2] drm/amdgpu: Reset GPU on S0ix when device supports BOCO

2023-03-29 Thread Kai-Heng Feng
is supported for the GFX slot. Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default") Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1885 Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2458 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp

[PATCH v2] drm/amdgpu/nv: Apply ASPM quirk on Intel ADL + AMD Navi

2023-03-15 Thread Kai-Heng Feng
ntel Alder Lake based systems"), to workaround the issue on Navi cards too. Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default") Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2458 Reviewed-by: Alex Deucher Signed-off-by: Kai-Heng Feng --- v2: - Rename the quirk f

[PATCH] drm/amdgpu/nv: Apply ASPM quirk on Intel ADL + AMD Navi

2023-03-13 Thread Kai-Heng Feng
ntel Alder Lake based systems"), to workaround the issue on Navi cards too. Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default") Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2458 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-24 Thread Kai-Heng Feng
On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula wrote: > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > dGFX so external monitors are routed to dGFX, and more monitors can be > > supported as r

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-24 Thread Kai-Heng Feng
On Sat, Aug 20, 2022 at 1:01 AM Karol Herbst wrote: > > On Thu, Aug 18, 2022 at 2:09 PM Lukas Wunner wrote: > > > > On Tue, Aug 16, 2022 at 11:06:18AM +0300, Jani Nikula wrote: > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > > On mobile workstations

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-17 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 7:59 PM Ville Syrjälä wrote: [snipped] > I had a quick trawl through some Windows stuff for this and > it does seem to do a few extra checks: > - platform must be TGL-H (nothing else has the DPin stuff I guess) > - OpRegion header must indicate dGPU presence Is the dGPU

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 9:49 AM Karol Herbst wrote: > > On Wed, Aug 17, 2022 at 3:18 AM Kai-Heng Feng > wrote: > > > > On Wed, Aug 17, 2022 at 2:50 AM Karol Herbst wrote: > > > > > > On Tue, Aug 16, 2022 at 4:53 AM Kai-Heng Feng > > > wrote: >

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 2:50 AM Karol Herbst wrote: > > On Tue, Aug 16, 2022 at 4:53 AM Kai-Heng Feng > wrote: > > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > dGFX so external monitors are routed to dGFX, and more monitors can

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 2:36 AM Lyude Paul wrote: > > On Tue, 2022-08-16 at 14:24 -0400, Lyude Paul wrote: > > On Tue, 2022-08-16 at 19:29 +0800, Kai-Heng Feng wrote: > > > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > > > wrote: > > > > > &g

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 2:24 AM Lyude Paul wrote: > > On Tue, 2022-08-16 at 19:29 +0800, Kai-Heng Feng wrote: > > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > > wrote: > > > > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > > On mobile work

[PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-15 Thread Kai-Heng Feng
document 632107. Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_acpi.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c index e78430001f077..3bd5930e2769b

[PATCH] drm/amdgpu: Ensure HDA function is suspended before ASIC reset

2022-04-07 Thread Kai-Heng Feng
o noirq callback, so it's called after HDA function is in D3. Fixes: daf8de0874ab5b ("drm/amdgpu: always reset the asic in suspend (v2)") Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) di

Re: [PATCH] vgaarb: Use ACPI HID name to find integrated GPU

2021-09-22 Thread Kai-Heng Feng
On Sat, Sep 18, 2021 at 12:55 AM Bjorn Helgaas wrote: > > On Fri, Sep 17, 2021 at 11:49:45AM +0800, Kai-Heng Feng wrote: > > On Fri, Sep 17, 2021 at 12:38 AM Bjorn Helgaas wrote: > > > > > > [+cc Huacai, linux-pci] > > > > > > On Wed, May 1

Re: [PATCH] vgaarb: Use ACPI HID name to find integrated GPU

2021-09-16 Thread Kai-Heng Feng
On Fri, Sep 17, 2021 at 12:38 AM Bjorn Helgaas wrote: > > [+cc Huacai, linux-pci] > > On Wed, May 19, 2021 at 09:57:23PM +0800, Kai-Heng Feng wrote: > > Commit 3d42f1ddc47a ("vgaarb: Keep adding VGA device in queue") assumes > > the first device is an integra

[PATCH] drm/i915/audio: Use BIOS provided value for RKL HDA link

2021-09-05 Thread Kai-Heng Feng
driver") Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_audio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c index 532237588511..4e0f96bf6158 100644 --- a/

[PATCH v3] drm/i915/dp: Use max params for panels < eDP 1.4

2021-08-20 Thread Kai-Heng Feng
/gitlab.freedesktop.org/drm/intel/-/issues/3714 Fixes: 2bbd6dba84d4 ("drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure") Fixes: a5c936add6a2 ("drm/i915/dp: Use slow and wide link training for everything") Suggested-by:

[PATCH v2] drm/i915/dp: Use max params for panels < eDP 1.4

2021-08-18 Thread Kai-Heng Feng
2bbd6dba84d4 ("drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure") Fixes: a5c936add6a2 ("drm/i915/dp: Use slow and wide link training for everything") Suggested-by: Ville Syrjälä Signed-off-by: Kai-Heng Feng --- d

Re: [Intel-gfx] [PATCH v2] fbdev/efifb: Release PCI device's runtime PM ref during FB destroy

2021-08-10 Thread Kai-Heng Feng
On Tue, Aug 10, 2021 at 10:49 PM Alex Deucher wrote: > > On Tue, Aug 10, 2021 at 4:36 AM Imre Deak wrote: > > > > Hi Kai-Heng, Alex, > > > > could you add your ack if the fix looks ok and you're ok if I push it to > > the i915 tree? > > > >

[PATCH] drm/i915/dp: Use max params for older panels

2021-08-04 Thread Kai-Heng Feng
eDP again and fall back to the old max strategy on failure") Fixes: a5c936add6a2 ("drm/i915/dp: Use slow and wide link training for everything") Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_dp.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) d

[PATCH] drm/amdgpu/acp: Make PM domain really work

2021-07-20 Thread Kai-Heng Feng
gLink: https://bugs.launchpad.net/bugs/1920674 Fixes: 25030321ba28 ("drm/amd: add pm domain for ACP IP sub blocks") Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 49 + 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/amd/

Re: [PATCH v4] drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

2021-06-15 Thread Kai-Heng Feng
On Fri, Jun 4, 2021 at 11:57 PM Kai-Heng Feng wrote: > > On Thu, May 20, 2021 at 2:58 PM Kai-Heng Feng > wrote: > > > > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > > to discrete GFX after S3. This is not desirable, because userspace will

Re: [PATCH v4] drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

2021-06-04 Thread Kai-Heng Feng
On Thu, May 20, 2021 at 2:58 PM Kai-Heng Feng wrote: > > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > to discrete GFX after S3. This is not desirable, because userspace will > treat connected display as a new one, losing display settings. > > The

[PATCH v4] drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

2021-05-20 Thread Kai-Heng Feng
/1460040732-31417-4-git-send-email-animesh.ma...@intel.com/ Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_acpi.c | 19 +++ drivers/gpu/drm/i915/display/intel_acpi.h | 3 +++ drivers/gpu/drm/i915/display/intel_opregion.c | 3 +++ 3 files changed, 25

[PATCH] vgaarb: Use ACPI HID name to find integrated GPU

2021-05-19 Thread Kai-Heng Feng
od, so use that as predicate to find integrated GPU. If the new strategy doesn't work, fallback to use the first device as boot VGA. Signed-off-by: Kai-Heng Feng --- drivers/gpu/vga/vgaarb.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/vga/

Re: [PATCH v3] drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

2021-05-14 Thread Kai-Heng Feng
On Wed, May 12, 2021 at 2:19 AM Ville Syrjälä wrote: > > On Mon, Apr 26, 2021 at 11:24:10PM +0800, Kai-Heng Feng wrote: > > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > > to discrete GFX after S3. This is not desirable, because userspace will &

Re: [PATCH v3] drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

2021-05-10 Thread Kai-Heng Feng
On Mon, Apr 26, 2021 at 11:24 PM Kai-Heng Feng wrote: > > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > to discrete GFX after S3. This is not desirable, because userspace will > treat connected display as a new one, losing display settings. > > The

Re: [PATCH v2] drm/radeon/dpm: Disable sclk switching on Oland when two 4K 60Hz monitors are connected

2021-05-10 Thread Kai-Heng Feng
On Fri, Apr 30, 2021 at 12:57 PM Kai-Heng Feng wrote: > > Screen flickers rapidly when two 4K 60Hz monitors are in use. This issue > doesn't happen when one monitor is 4K 60Hz (pixelclock 594MHz) and > another one is 4K 30Hz (pixelclock 297MHz). > > The issue is

Re: [PATCH] drm/radeon/si_dpm: Fix SMU power state load

2021-05-09 Thread Kai-Heng Feng
C_PERFORMANCE_LEVELS_PER_SWSTATE instead of > SISLANDS_MAX_SMC_PERFORMANCE_LEVELS_PER_SWSTATE - 1. > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1583 > Fixes: 96e27e8d919e ("drm/radeon/si_dpm: Replace one-element array with > flexible-array in struct SISLANDS_SMC_SWSTAT

[PATCH v2] drm/radeon/dpm: Disable sclk switching on Oland when two 4K 60Hz monitors are connected

2021-04-29 Thread Kai-Heng Feng
indication, we found that the issue occurs when sclk is too low. So resolve the issue by disabling sclk switching when there are two monitors requires high pixelclock (> 297MHz). v2: - Only apply the fix to Oland. Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/radeon/radeon.h| 1 +

[PATCH] drm/radeon/dpm: Disable sclk switching when two 4K 60Hz monitors are connected

2021-04-29 Thread Kai-Heng Feng
igh". Following the lead, we found that the issue only occurs when sclk is too low. So resolve the issue by disabling sclk switching when there are two monitors that requires high pixelclock (> 297MHz). Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/radeon/radeon.h| 1 + drivers/gpu/drm

[PATCH v3] drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

2021-04-26 Thread Kai-Heng Feng
the function into intel_modeset_init_hw(). v2: - Forward declare struct pci_dev. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3113 References: https://lore.kernel.org/intel-gfx/1460040732-31417-4-git-send-email-animesh.ma...@intel.com/ Signed-off-by: Kai-Heng Feng --- drivers/gpu

Re: [PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops

2021-04-26 Thread Kai-Heng Feng
On Fri, Apr 23, 2021 at 8:41 PM Ville Syrjälä wrote: > > On Fri, Apr 23, 2021 at 12:46:54PM +0800, Kai-Heng Feng wrote: > > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > > to discrete GFX after S3. This is not desirable, because userspace will &

Re: [PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops

2021-04-26 Thread Kai-Heng Feng
On Fri, Apr 23, 2021 at 3:35 PM Jani Nikula wrote: > > On Fri, 23 Apr 2021, Kai-Heng Feng wrote: > > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > > to discrete GFX after S3. This is not desirable, because userspace will > > treat connec

[PATCH v2] drm/amdgpu: Register VGA clients after init can no longer fail

2021-04-26 Thread Kai-Heng Feng
o register VGA clients that early, so solve the issue by putting them after all the goto cleanups. v2: - Remove redundant vga_switcheroo cleanup in failed: label. Fixes: 4192f7b57689 ("drm/amdgpu: unmap register bar on device init failure") Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm

[PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops

2021-04-22 Thread Kai-Heng Feng
://gitlab.freedesktop.org/drm/intel/-/issues/3113 References: https://lore.kernel.org/intel-gfx/1460040732-31417-4-git-send-email-animesh.ma...@intel.com/ Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_acpi.c | 17 + drivers/gpu/drm/i915/display/intel_acpi.h | 3 +++ drivers

[PATCH] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops

2021-04-22 Thread Kai-Heng Feng
References: https://lore.kernel.org/intel-gfx/1460040732-31417-4-git-send-email-animesh.ma...@intel.com/ Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_acpi.c | 17 + drivers/gpu/drm/i915/display/intel_acpi.h | 2 ++ drivers/gpu/drm/i915/i915_drv.c | 5

[PATCH] drm/amdgpu: Register VGA clients after init can no longer fail

2021-04-21 Thread Kai-Heng Feng
o register VGA clients that early, so solve the issue by putting them after all the goto cleanups. Fixes: 4192f7b57689 ("drm/amdgpu: unmap register bar on device init failure") Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 26 +++--- 1 fi

[PATCH] drm/i915/dp: Use slow and wide link training for everything

2021-04-20 Thread Kai-Heng Feng
/-/issues/272 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_dp.c | 59 +++-- 1 file changed, 5 insertions(+), 54 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 52ea09fc5e70..4ad12dde5938 100644

Re: [PATCH] efifb: Fix runtime pm calls for non PCI efifb device

2021-04-20 Thread Kai-Heng Feng
> ---[ end trace 17d8da630bf8ff77 ]--- > > Kernel panic - not syncing: Attempted to kill init! exitcode=0x000b > > -->8 > > > > Fix the issue by checking for non-NULL efifb_pci_dev before dereferencing > > for runtime pm calls in probe and remove routin

[PATCH] drm/i915/dp: Use slow and wide link training for DPCP rev < 1.4

2021-04-14 Thread Kai-Heng Feng
med the new strategy doesn't introduce regression on XPS 9380. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3384 References: https://gitlab.freedesktop.org/drm/intel/-/issues/272 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_dp.c | 10 +- 1 file changed

[PATCH] efifb: Check efifb_pci_dev before using it

2021-04-13 Thread Kai-Heng Feng
On some platforms like Hyper-V and RPi4 with UEFI firmware, efifb is not a PCI device. So make sure efifb_pci_dev is found before using it. Fixes: a6c0fd3d5a8b ("efifb: Ensure graphics device for efifb stays at PCI D0") BugLink: https://bugs.launchpad.net/bugs/1922403 Signed-off-by

Re: [PATCH] efifb: Ensure graphics device for efifb stays at PCI D0

2021-02-21 Thread Kai-Heng Feng
On Mon, Feb 1, 2021 at 11:21 PM Alex Deucher wrote: > > On Sat, Jan 30, 2021 at 6:27 AM Kai-Heng Feng > wrote: > > > > We are seeing root ports on some desktop boards support D3cold for > > discrete graphics card. So when efifb is in use while graphics device >

[PATCH] efifb: Ensure graphics device for efifb stays at PCI D0

2021-01-30 Thread Kai-Heng Feng
won't be runtime suspended, to keep efifb work all the time. Signed-off-by: Kai-Heng Feng --- drivers/video/fbdev/efifb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c index e57c00824965..19edd7206409 100644 --- a/drivers/video/fbdev

Re: [PATCH 1/2] drm/i915/dpcd_bl: Skip testing control capability with force DPCD quirk

2020-10-08 Thread Kai-Heng Feng
AUX_SET_CAP, that should be enough for us to control > it. Does the proper fix include dropping DP_QUIRK_FORCE_DPCD_BACKLIGHT entirely? Kai-Heng > > > On Wed, 2020-10-07 at 14:58 +0800, Kai-Heng Feng wrote: >> HP DreamColor panel needs to be controlled via AUX interface. How

[PATCH 1/2] drm/i915/dpcd_bl: Skip testing control capability with force DPCD quirk

2020-10-07 Thread Kai-Heng Feng
-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c index acbd7eb66cbe

Re: [PATCH] drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible 13t-aw100

2020-10-07 Thread Kai-Heng Feng
> On Apr 8, 2020, at 15:22, Jani Nikula wrote: > > On Tue, 07 Apr 2020, Kai-Heng Feng wrote: >>> On Mar 27, 2020, at 19:03, Kai-Heng Feng >>> wrote: >>> >>> Hi, >>> >>>> On Mar 23, 2020, at 13:35, Kai-Heng Feng >&

[PATCH 2/2] drm/dp: HP DreamColor panel brigntness fix

2020-10-07 Thread Kai-Heng Feng
HP DreamColor panel, which is used by new HP ZBook Studio, needs to use DPCD to control brightness. Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/drm_dp_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index

Re: [PATCH] drm/i915: Force DPCD backlight mode for HP CML 2020 system

2020-10-07 Thread Kai-Heng Feng
> On Apr 8, 2020, at 15:23, Jani Nikula wrote: > > On Tue, 07 Apr 2020, Kai-Heng Feng wrote: >> There's another Samsung OLED panel needs to use DPCD aux interface to >> control backlight. > > Acked-by: Jani Nikula David, Can you please merge th

Re: [PATCH v6] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-09-29 Thread Kai-Heng Feng
Hi Jani, > On Jul 10, 2020, at 23:48, Kai-Heng Feng wrote: > > > >> On Jun 30, 2020, at 16:37, Kai-Heng Feng wrote: >> >> >>> On Jun 10, 2020, at 15:55, Kai-Heng Feng >>> wrote: >>> >>> On HP 800 G4 DM, if HDMI cable isn'

Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444

2020-09-02 Thread Kai-Heng Feng
> On Sep 1, 2020, at 03:48, Ville Syrjälä wrote: > > On Thu, Aug 27, 2020 at 01:04:54PM +0800, Kai Heng Feng wrote: >> Hi Ville, >> >>> On Aug 27, 2020, at 12:24 AM, Ville Syrjälä >>> wrote: >>> >>> On Wed, Aug 26, 2020 at 01:21:15P

Re: [PATCH] drm/radeon: Reset ASIC if suspend is not managed by platform firmware

2020-09-02 Thread Kai-Heng Feng
> On Sep 2, 2020, at 00:30, Alex Deucher wrote: > > On Tue, Sep 1, 2020 at 12:21 PM Kai-Heng Feng > wrote: >> >> >> >>> On Sep 1, 2020, at 22:19, Alex Deucher wrote: >>> >>> On Tue, Sep 1, 2020 at 3:32 AM Kai-Heng Feng >>>

Re: [PATCH] drm/radeon: Reset ASIC if suspend is not managed by platform firmware

2020-09-01 Thread Kai-Heng Feng
> On Sep 1, 2020, at 22:19, Alex Deucher wrote: > > On Tue, Sep 1, 2020 at 3:32 AM Kai-Heng Feng > wrote: >> >> Suspend with s2idle or by the following steps cause screen frozen: >> # echo devices > /sys/power/pm_test >> # echo freez

[PATCH] drm/radeon: Reset ASIC if suspend is not managed by platform firmware

2020-09-01 Thread Kai-Heng Feng
Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/radeon/radeon_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c index 266e3cbbd09b..df823b9ad79f 100644 --- a/drivers/gpu/drm/radeon/radeon_device.c +++ b/d

Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444

2020-08-27 Thread Kai Heng Feng
Hi Ville, > On Aug 27, 2020, at 12:24 AM, Ville Syrjälä > wrote: > > On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: >> LSPCON only supports 8 bpc for RGB/YCbCr444. >> >> Set the correct bpp otherwise it renders blank screen. > > Hm

[PATCH] drm/radeon: Prefer lower feedback dividers

2020-08-26 Thread Kai-Heng Feng
iginal fix. Fixes: 2e26ccb119bd ("drm/radeon: prefer lower reference dividers") BugLink: https://bugs.launchpad.net/bugs/1791312 BugLink: https://bugs.launchpad.net/bugs/1861554 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/radeon/radeon_display.c | 2 +- 1 file changed, 1 inse

[PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444

2020-08-26 Thread Kai-Heng Feng
LSPCON only supports 8 bpc for RGB/YCbCr444. Set the correct bpp otherwise it renders blank screen. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2195 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_lspcon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH v6] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-07-14 Thread Kai-Heng Feng
> On Jun 30, 2020, at 16:37, Kai-Heng Feng wrote: > > >> On Jun 10, 2020, at 15:55, Kai-Heng Feng wrote: >> >> On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port >> becomes useless and never responds to cable hotplugging: >>

Re: [PATCH v6] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-07-01 Thread Kai-Heng Feng
> On Jun 10, 2020, at 15:55, Kai-Heng Feng wrote: > > On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port > becomes useless and never responds to cable hotplugging: > [3.031904] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon > [3.031945] [

[PATCH v6] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-06-11 Thread Kai-Heng Feng
the lspcon chip on the system only gets powered after the cable is plugged. Consilidate lspcon_init() into lspcon_resume() to dynamically init lspcon chip, and make HDMI port work. Signed-off-by: Kai-Heng Feng --- v6: - Rebase on latest for-linux-next. v5: - Consolidate lspcon_resume

Re: [PATCH v5] drm/i915: Init lspcon chip dynamically

2020-06-08 Thread Kai-Heng Feng
> On May 6, 2020, at 18:28, Kai-Heng Feng wrote: > > On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port > becomes useless and never responds to cable hotplugging: > [3.031904] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon > [3.031945] [

[PATCH v5] drm/i915: Init lspcon chip dynamically

2020-05-07 Thread Kai-Heng Feng
the lspcon chip on the system only gets powered after the cable is plugged. Consolidate lspcon_init() into lspcon_resume() to dynamically init lspcon chip, and make HDMI port work. Closes: https://gitlab.freedesktop.org/drm/intel/issues/203 Signed-off-by: Kai-Heng Feng --- v5: - Consolidate

[PATCH 1/1] drm/nouveau: Use generic helper to check _PR3 presence

2020-04-23 Thread Kai-Heng Feng
Replace nouveau_pr3_present() in favor of a more generic one, pci_pr3_present(). Also the presence of upstream bridge _PR3 doesn't need to go hand in hand with device's _DSM, so check _PR3 before _DSM. Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/nouveau/nouveau_acpi.c | 44

[PATCH] drm/i915: Force DPCD backlight mode for HP CML 2020 system

2020-04-08 Thread Kai-Heng Feng
There's another Samsung OLED panel needs to use DPCD aux interface to control backlight. Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/drm_dp_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index c6fbe6e6bc9d

Re: [PATCH] drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible 13t-aw100

2020-04-07 Thread Kai-Heng Feng
> On Mar 27, 2020, at 19:03, Kai-Heng Feng wrote: > > Hi, > >> On Mar 23, 2020, at 13:35, Kai-Heng Feng wrote: >> >> There's another OLED panel needs to use DPCD aux interface to control >> backlight. >> >> BugLink: https://bugs.launchpad.

Re: [PATCH] drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible 13t-aw100

2020-03-30 Thread Kai-Heng Feng
Hi, > On Mar 23, 2020, at 13:35, Kai-Heng Feng wrote: > > There's another OLED panel needs to use DPCD aux interface to control > backlight. > > BugLink: https://bugs.launchpad.net/bugs/1860303 > Signed-off-by: Kai-Heng Feng Would it be possible to review this? I'd l

[PATCH] drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible 13t-aw100

2020-03-23 Thread Kai-Heng Feng
There's another OLED panel needs to use DPCD aux interface to control backlight. BugLink: https://bugs.launchpad.net/bugs/1860303 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/drm_dp_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu

Re: [PATCH v4] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-03-11 Thread Kai-Heng Feng
> On Feb 15, 2020, at 01:56, Kai-Heng Feng wrote: > > On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port > becomes useless and never responds to cable hotplugging: > [3.031904] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon

[PATCH v4] drm/i915: Init lspcon after HPD in intel_dp_detect()

2020-02-17 Thread Kai-Heng Feng
the lspcon chip on the system in question only gets powered after the cable is plugged. So let's call lspcon_init() dynamically to properly initialize the lspcon chip and make HDMI port work. Signed-off-by: Kai-Heng Feng --- v4: - Trust VBT in intel_infoframe_init(). - Init lspcon in intel_dp_detect

Re: [PATCH v3] drm/i915: Re-init lspcon after HPD if lspcon probe failed

2020-01-07 Thread Kai-Heng Feng
Hi Jani, > On Dec 24, 2019, at 16:42, Kai-Heng Feng wrote: > > On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port > becomes useless and never responds to cable hotplugging: > [3.031904] [drm:lspcon_init [i915]] *ERROR* Failed to probe lspcon

[PATCH] drm/i915: Re-init lspcon after HPD if lspcon probe failed

2019-12-24 Thread Kai-Heng Feng
the lspcon chip on the system in question only gets powered after the cable is plugged. So let's call lspcon_init() dynamically to properly initialize the lspcon chip and make HDMI port work. Closes: https://gitlab.freedesktop.org/drm/intel/issues/203 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm

Re: [PATCH v2] drm/i915: Re-init lspcon after HPD if lspcon probe failed

2019-12-24 Thread Kai-Heng Feng
> On Dec 24, 2019, at 01:36, Jani Nikula wrote: > > On Tue, 24 Dec 2019, Kai-Heng Feng wrote: >> On HP 800 G4 DM, if HDMI cable isn't plugged before boot, the HDMI port >> becomes useless and never responds to cable hotplugging: >> [3.031904] [drm:lspcon_

[PATCH v2] drm/i915: Re-init lspcon after HPD if lspcon probe failed

2019-12-24 Thread Kai-Heng Feng
the lspcon chip on the system in question only gets powered after the cable is plugged. So let's call lspcon_init() dynamically to properly initialize the lspcon chip and make HDMI port work. Signed-off-by: Kai-Heng Feng --- v2: - Move lspcon_init() inside of intel_dp_hpd_pulse(). drivers/gpu/drm

[PATCH v3] drm/i915: Re-init lspcon after HPD if lspcon probe failed

2019-12-24 Thread Kai-Heng Feng
the lspcon chip on the system in question only gets powered after the cable is plugged. So let's call lspcon_init() dynamically to properly initialize the lspcon chip and make HDMI port work. Closes: https://gitlab.freedesktop.org/drm/intel/issues/203 Signed-off-by: Kai-Heng Feng --- v3: - Make sure

Re: [PATCH] drm/edid: Add 6 bpc quirk for SDC panel in Lenovo G50

2019-10-08 Thread Kai-Heng Feng
> On Jun 6, 2019, at 16:04, Kai-Heng Feng wrote: > > Hi, > > at 11:30, Kai-Heng Feng wrote: > >> Another panel that needs 6BPC quirk. > > Please include this patch if possible. Another gentle ping. > > Kai-Heng > >> >> BugLink: htt

[PATCH] drm/amd/display: Restore backlight brightness after system resume

2019-09-02 Thread Kai-Heng Feng
(Stoney Ridge) and Dell Latitude 5495 (Raven Ridge). Cc: Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH] drm/amdgpu: Add APTX quirk for Dell Latitude 5495

2019-08-28 Thread Kai-Heng Feng
Needs ATPX rather than _PR3 to really turn off the dGPU. This can save ~5W when dGPU is runtime-suspended. Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c b

Re: [PATCH] drm/amdgpu: Apply flags after amdgpu_device_ip_init()

2019-08-17 Thread Kai-Heng Feng
at 21:33, Deucher, Alexander wrote: Thanks for finding this! I think the attached patch should fix the issue and it's much less invasive. Yes it also fix the issue, please add by tested-by: Tested-by: Kai-Heng Feng I took this more or less future proof approach because I think this won’t

[PATCH] drm/amdgpu: Apply flags after amdgpu_device_ip_init()

2019-08-15 Thread Kai-Heng Feng
issue. [1] https://lore.kernel.org/lkml/3eb0e920-31d7-4c91-a360-dbfb4417a...@canonical.com/ Fixes: 005440066f92 ("drm/amdgpu: enable gfxoff again on raven series (v2)") Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 589 + drivers/gpu/

[Regression] "drm/amdgpu: enable gfxoff again on raven series (v2)"

2019-08-08 Thread Kai-Heng Feng
Hi, After commit 005440066f92 ("drm/amdgpu: enable gfxoff again on raven series (v2)”), browsers on Raven Ridge systems cause serious corruption like this: https://launchpadlibrarian.net/436319772/Screenshot%20from%202019-08-07%2004-20-34.png Firmwares for Raven Ridge is up-to-date.

Re: [Regression] "drm/amdgpu: enable gfxoff again on raven series (v2)"

2019-08-08 Thread Kai-Heng Feng
at 14:29, Huang, Ray wrote: -Original Message- From: Kai-Heng Feng Sent: Thursday, August 08, 2019 1:45 AM To: Huang, Ray Cc: Deucher, Alexander ; Koenig, Christian ; Zhou, David(ChunMing) ; amd-gfx list ; dri-devel@lists.freedesktop.org; LKML ; Anthony Wong Subject: Re: [Regression

Re: [Regression] "drm/amdgpu: enable gfxoff again on raven series (v2)"

2019-08-08 Thread Kai-Heng Feng
: 0x VBIOS version: 113-RAVEN-103 Kai-Heng Thanks, Ray From: Kai-Heng Feng Sent: Wednesday, August 7, 2019 8:50 PM To: Huang, Ray Cc: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); amd-gfx list; dri-devel@lists.freedesktop.org; LKML; Anthony Wong Subject: [Regression

Re: OLED panel brightness support

2019-07-30 Thread Kai-Heng Feng
at 16:26, Jani Nikula wrote: On Tue, 23 Jul 2019, Kai-Heng Feng wrote: Hi, Currently, OLED panel brightness [1] is not supported. As a general statement this is not true, and not backed up by the referenced bug. We just don't know how brightness is controlled on that particular laptop

Re: OLED panel brightness support

2019-07-26 Thread Kai-Heng Feng
at 00:03, wrote: -Original Message- From: Daniel Vetter On Behalf Of Daniel Vetter Sent: Wednesday, July 24, 2019 6:49 AM To: Kai-Heng Feng Cc: dri-devel@lists.freedesktop.org; Anthony Wong; Limonciello, Mario Subject: Re: OLED panel brightness support [EXTERNAL EMAIL] On Tue, Jul

OLED panel brightness support

2019-07-23 Thread Kai-Heng Feng
Hi, Currently, OLED panel brightness [1] is not supported. We have a similar Dell system that also affect by lack of OLED brightness support. I’ve investigated both kernel and user space but I haven’t found a good general solution yet. Dell systems use EDID descriptor 4 as Dell specific

Re: [PATCH] drm/edid: Add 6 bpc quirk for SDC panel in Lenovo G50

2019-06-06 Thread Kai-Heng Feng
Hi, at 11:30, Kai-Heng Feng wrote: Another panel that needs 6BPC quirk. Please include this patch if possible. Kai-Heng BugLink: https://bugs.launchpad.net/bugs/1819968 Cc: # v4.8+ Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions

[PATCH] drm/edid: Add 6 bpc quirk for SDC panel in Lenovo G50

2019-04-02 Thread Kai-Heng Feng
Another panel that needs 6BPC quirk. BugLink: https://bugs.launchpad.net/bugs/1819968 Cc: # v4.8+ Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 990b1909f9d7

[PATCH] drm/edid: Add 6 bpc quirk for BOE panel in HP Pavilion 15-n233sl

2018-10-03 Thread Kai-Heng Feng
There's another panel that reports "DFP 1.x compliant TMDS" but it supports 6bpc instead of 8 bpc. Apply 6 bpc quirk for the panel to fix it. BugLink: https://bugs.launchpad.net/bugs/1794387 Cc: # v4.8+ Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file

[PATCH] drm/edid: Add 6 bpc quirk for SDC panel in Lenovo B50-80

2018-08-23 Thread Kai-Heng Feng
Another panel that reports "DFP 1.x compliant TMDS" but it supports 6bpc instead of 8 bpc. Apply 6 bpc quirk for the panel to fix it. BugLink: https://bugs.launchpad.net/bugs/1788308 Cc: # v4.8+ Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3

[PATCH] drm/edid: Add 6 bpc quirk for CPT panel in Asus UX303LA

2018-02-18 Thread Kai-Heng Feng
fall back to 18 bpp when sink capability is unknown"") BugLink: https://bugs.launchpad.net/bugs/1749420 Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b

[PATCH] drm/amdgpu: add new device to use atpx quirk

2018-02-09 Thread Kai-Heng Feng
The affected system (0x0813) is pretty similar to another one (0x0812), it also needs to use ATPX power control. Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/d