Re: [PATCH 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels

2019-12-15 Thread Sam Ravnborg
Hi Heiko. > > The idea was that if a write returned an error then do not even attempt > > more writes. So if a write fails we do not loose the original error > > code, assuming subsequent write would also fail. > > Shouldn't the code above do exactly that? ... Because it's like > > ret =

Re: [PATCH 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels

2019-12-15 Thread Heiko Stuebner
Hi Sam, Am Sonntag, 15. Dezember 2019, 09:29:16 CET schrieb Sam Ravnborg: > Hi Heiko. > > > Am Samstag, 14. Dezember 2019, 09:17:30 CET schrieb Sam Ravnborg: > > > > +#define dsi_generic_write_seq(dsi, cmd, seq...) do { > > > > \ > > > > + static const u8 d[] = {

Re: [PATCH 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels

2019-12-15 Thread Sam Ravnborg
Hi Heiko. > Am Samstag, 14. Dezember 2019, 09:17:30 CET schrieb Sam Ravnborg: > > > +#define dsi_generic_write_seq(dsi, cmd, seq...) do { > > > \ > > > + static const u8 d[] = { seq }; \ > > > + int ret;

Re: [PATCH 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels

2019-12-14 Thread Heiko Stübner
Hi Sam, thanks for the thorough review :-) Am Samstag, 14. Dezember 2019, 09:17:30 CET schrieb Sam Ravnborg: > > +#define dsi_generic_write_seq(dsi, cmd, seq...) do { > > \ > > + static const u8 d[] = { seq }; \ > > + int ret;

Re: [PATCH 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels

2019-12-14 Thread Sam Ravnborg
Hi Heiko. Thanks for another nice panel driver patch. There are some changes in drm-misc-next so the patch applies but it no longer builds. Please fix. drm_panel now includes support for backlight - see other drivers. Please look into the possibility to use the drm_panel supported backlight for

[PATCH 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels

2019-12-09 Thread Heiko Stuebner
From: Heiko Stuebner Base on the somewhat similar Rocktech driver but adapted for panel-specific init of the XPP055C272. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile| 1 +