Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-09 Thread Noralf Trønnes
Den 09.10.2017 11.06, skrev Daniel Thompson: On 06/10/17 19:01, Noralf Trønnes wrote: Den 03.10.2017 11.04, skrev Daniel Vetter: On Tue, Oct 03, 2017 at 09:51:49AM +0100, Daniel Thompson wrote: On 03/10/17 09:03, Daniel Vetter wrote: On Mon, Oct 02, 2017 at 12:00:54PM +0300, Jani Nikula

Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-09 Thread Daniel Thompson
On 06/10/17 19:01, Noralf Trønnes wrote: Den 03.10.2017 11.04, skrev Daniel Vetter: On Tue, Oct 03, 2017 at 09:51:49AM +0100, Daniel Thompson wrote: On 03/10/17 09:03, Daniel Vetter wrote: On Mon, Oct 02, 2017 at 12:00:54PM +0300, Jani Nikula wrote: On Mon, 02 Oct 2017, Daniel Thompson

Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-06 Thread Noralf Trønnes
Den 03.10.2017 11.04, skrev Daniel Vetter: On Tue, Oct 03, 2017 at 09:51:49AM +0100, Daniel Thompson wrote: On 03/10/17 09:03, Daniel Vetter wrote: On Mon, Oct 02, 2017 at 12:00:54PM +0300, Jani Nikula wrote: On Mon, 02 Oct 2017, Daniel Thompson wrote: So I'm

Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-03 Thread Daniel Vetter
On Tue, Oct 03, 2017 at 09:51:49AM +0100, Daniel Thompson wrote: > On 03/10/17 09:03, Daniel Vetter wrote: > > On Mon, Oct 02, 2017 at 12:00:54PM +0300, Jani Nikula wrote: > > > On Mon, 02 Oct 2017, Daniel Thompson wrote: > > > > So I'm coming to this patchset cold but

Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-03 Thread Daniel Thompson
On 03/10/17 09:03, Daniel Vetter wrote: On Mon, Oct 02, 2017 at 12:00:54PM +0300, Jani Nikula wrote: On Mon, 02 Oct 2017, Daniel Thompson wrote: So I'm coming to this patchset cold but can you explain *why* something wants to call of_find_backlight_by_node() when

Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-03 Thread Daniel Vetter
On Mon, Oct 02, 2017 at 12:00:54PM +0300, Jani Nikula wrote: > On Mon, 02 Oct 2017, Daniel Thompson wrote: > > So I'm coming to this patchset cold but can you explain *why* something > > wants to call of_find_backlight_by_node() when there is no backlight > > support

Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-02 Thread Jani Nikula
On Mon, 02 Oct 2017, Daniel Thompson wrote: > On 02/10/17 09:49, Jani Nikula wrote: >> On Mon, 02 Oct 2017, Daniel Thompson wrote: >>> On 01/10/17 18:26, Meghana Madhyastha wrote: -#ifdef CONFIG_OF +#if defined CONFIG_OF &&

Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-02 Thread Daniel Thompson
On 02/10/17 09:49, Jani Nikula wrote: On Mon, 02 Oct 2017, Daniel Thompson wrote: On 01/10/17 18:26, Meghana Madhyastha wrote: -#ifdef CONFIG_OF +#if defined CONFIG_OF && IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) The above comments are more important but why does

Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-02 Thread Jani Nikula
On Mon, 02 Oct 2017, Daniel Thompson wrote: > So I'm coming to this patchset cold but can you explain *why* something > wants to call of_find_backlight_by_node() when there is no backlight > support enabled. Why isn't the code that called is conditional on >

Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-02 Thread Jani Nikula
On Mon, 02 Oct 2017, Daniel Thompson wrote: > On 01/10/17 18:26, Meghana Madhyastha wrote: >> -#ifdef CONFIG_OF >> +#if defined CONFIG_OF && IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) > > The above comments are more important but why does this mix defined and >

Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-01 Thread Daniel Thompson
On 02/10/17 06:58, Daniel Thompson wrote: On 01/10/17 18:26, Meghana Madhyastha wrote: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) as part of the if directive for the function declaration of of_find_backlight_by_node in order to avoid module dependency errors. Module dependency errors? Does

Re: [PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-01 Thread Daniel Thompson
On 01/10/17 18:26, Meghana Madhyastha wrote: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) as part of the if directive for the function declaration of of_find_backlight_by_node in order to avoid module dependency errors. Module dependency errors? Does you mean mean use of undefined symbols?

[PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

2017-10-01 Thread Meghana Madhyastha
Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) as part of the if directive for the function declaration of of_find_backlight_by_node in order to avoid module dependency errors. Signed-off-by: Meghana Madhyastha --- Changes in v7: -This patch did not exist in v6.