Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V9)

2009-12-26 Thread Luca Tettamanti
2009/12/25 Rafał Miłecki zaj...@gmail.com: W dniu 24 grudnia 2009 23:19 użytkownik Luca Tettamanti kronos...@gmail.com napisał: 2009/12/24 Rafał Miłecki zaj...@gmail.com: W dniu 24 grudnia 2009 17:32 użytkownik Luca Tettamanti kronos...@gmail.com napisał: I think it would be safer to execute

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V9)

2009-12-25 Thread Rafał Miłecki
W dniu 24 grudnia 2009 23:19 użytkownik Luca Tettamanti kronos...@gmail.com napisał: 2009/12/24 Rafał Miłecki zaj...@gmail.com: W dniu 24 grudnia 2009 17:32 użytkownik Luca Tettamanti kronos...@gmail.com napisał: I think it would be safer to execute that code in the IH (or in a tasklet, which

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V9)

2009-12-24 Thread Luca Tettamanti
Il Tue, Dec 22, 2009 at 11:06:16PM +0100, Rafał Miłecki ha scritto: V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM on older hardware (IRQs, mode_fixup, dpms) V6: use separate dynpm

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V9)

2009-12-24 Thread Rafał Miłecki
W dniu 24 grudnia 2009 17:32 użytkownik Luca Tettamanti kronos...@gmail.com napisał: Il Tue, Dec 22, 2009 at 11:06:16PM +0100, Rafał Miłecki ha scritto: V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V9)

2009-12-24 Thread Luca Tettamanti
2009/12/24 Rafał Miłecki zaj...@gmail.com: W dniu 24 grudnia 2009 17:32 użytkownik Luca Tettamanti kronos...@gmail.com napisał: I think it would be safer to execute that code in the IH (or in a tasklet, which is guaranteed to run after the handler); the only problem I see is that

[PATCH] drm/radeon/kms: add dynamic engine reclocking (V9)

2009-12-22 Thread Rafał Miłecki
V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM on older hardware (IRQs, mode_fixup, dpms) V6: use separate dynpm module parameter V7: drop RADEON_ prefix, set minimum mode for dpms off

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V8)

2009-12-20 Thread Rafał Miłecki
W dniu 18 grudnia 2009 19:42 użytkownik Rafał Miłecki zaj...@gmail.com napisał: V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM on older hardware (IRQs, mode_fixup, dpms) V6: use

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V6)

2009-12-18 Thread Rafał Miłecki
W dniu 18 grudnia 2009 01:08 użytkownik Alex Deucher alexdeuc...@gmail.com napisał: 2009/12/17 Rafał Miłecki zaj...@gmail.com: W dniu 17 grudnia 2009 06:43 użytkownik Alex Deucher alexdeuc...@gmail.com napisał: 2009/12/16 Rafał Miłecki zaj...@gmail.com: V2: reorganize functions, fix

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V6)

2009-12-18 Thread Rafał Miłecki
W dniu 18 grudnia 2009 01:08 użytkownik Alex Deucher alexdeuc...@gmail.com napisał: 2009/12/17 Rafał Miłecki zaj...@gmail.com: W dniu 17 grudnia 2009 06:43 użytkownik Alex Deucher alexdeuc...@gmail.com napisał: 2009/12/16 Rafał Miłecki zaj...@gmail.com: V2: reorganize functions, fix

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V6)

2009-12-18 Thread Jerome Glisse
On Thu, Dec 17, 2009 at 03:02:51AM +0100, Rafał Miłecki wrote: V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM on older hardware (IRQs, mode_fixup, dpms) V6: use separate dynpm

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V6)

2009-12-18 Thread Rafał Miłecki
W dniu 18 grudnia 2009 13:24 użytkownik Jerome Glisse gli...@freedesktop.org napisał: I think it would be better to change : RADEON_PM_ACTION_NONE - PM_NONE ... We already know we are in the radeon module so this is redundant to put it in the name again. And i don't think PM_NONE will conflict

[PATCH] drm/radeon/kms: add dynamic engine reclocking (V7)

2009-12-18 Thread Rafał Miłecki
V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM on older hardware (IRQs, mode_fixup, dpms) V6: use separate dynpm module parameter V7: drop RADEON_ prefix, set minimum mode for dpms off

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V6)

2009-12-18 Thread Jerome Glisse
On Fri, Dec 18, 2009 at 02:30:34PM +0100, Rafał Miłecki wrote: W dniu 18 grudnia 2009 13:24 użytkownik Jerome Glisse gli...@freedesktop.org napisał: I think it would be better to change : RADEON_PM_ACTION_NONE - PM_NONE ... We already know we are in the radeon module so this is redundant

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V6)

2009-12-18 Thread Rafał Miłecki
W dniu 18 grudnia 2009 15:18 użytkownik Jerome Glisse gli...@freedesktop.org napisał: On Fri, Dec 18, 2009 at 02:30:34PM +0100, Rafał Miłecki wrote: W dniu 18 grudnia 2009 13:24 użytkownik Jerome Glisse gli...@freedesktop.org napisał: I think it would be better to change :

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V7)

2009-12-18 Thread Alex Deucher
2009/12/18 Rafał Miłecki zaj...@gmail.com: V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM on older hardware (IRQs, mode_fixup, dpms) V6: use separate dynpm module parameter V7:

[PATCH] drm/radeon/kms: add dynamic engine reclocking (V8)

2009-12-18 Thread Rafał Miłecki
V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM on older hardware (IRQs, mode_fixup, dpms) V6: use separate dynpm module parameter V7: drop RADEON_ prefix, set minimum mode for dpms off

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V6)

2009-12-17 Thread Sedat Dilek
v6 runs fine on rv515. Thanks Rafal. --- Speedup in 3D: Running Anholt's openarena benchmark demo --- $ openarena +exec anholt 21 | egrep -e '[0-9]+ frames' NEW: 840 frames 10.2 seconds 82.1 fps 4.0/12.2/56.0/5.4 ms OLD: 840 frames 37.4 seconds 22.4 fps 15.0/44.6/97.0/13.4 ms Even playing a

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V6)

2009-12-17 Thread Rafał Miłecki
W dniu 17 grudnia 2009 06:43 użytkownik Alex Deucher alexdeuc...@gmail.com napisał: 2009/12/16 Rafał Miłecki zaj...@gmail.com: V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM on

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V6)

2009-12-17 Thread Alex Deucher
2009/12/17 Rafał Miłecki zaj...@gmail.com: W dniu 17 grudnia 2009 06:43 użytkownik Alex Deucher alexdeuc...@gmail.com napisał: 2009/12/16 Rafał Miłecki zaj...@gmail.com: V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (v5)

2009-12-16 Thread Nezmer
--Forwarded to list-- Good job. Card: 01:00.0 VGA compatible controller: ATI Technologies Inc M92 [Mobility Radeon HD 4500 Series] How to: 1)Blacklist radeon module at startup (distro-specific). 2) Add this to /etc/rc.local (might be distro-specific) : modprobe -r -v radeon modprobe -v radeon

Fwd: [PATCH] drm/radeon/kms: add dynamic engine reclocking (v5)

2009-12-16 Thread Rafał Miłecki
Nezmer tested my patch, I let myself forward his results :) -- Wiadomość przekazana dalej -- Od: nez...@allurelinux.org Data: 16 grudnia 2009 14:27 Temat: Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (v5) Do: Rafał Miłecki zaj...@gmail.com On Wed, Dec 16, 2009

[PATCH] drm/radeon/kms: add dynamic engine reclocking (V6)

2009-12-16 Thread Rafał Miłecki
V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM on older hardware (IRQs, mode_fixup, dpms) V6: use separate dynpm module parameter Tested on my M82==RV620 and my new M96==RV730. Also

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V6)

2009-12-16 Thread Rafał Miłecki
W dniu 17 grudnia 2009 03:02 użytkownik Rafał Miłecki zaj...@gmail.com napisał: V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM on older hardware (IRQs, mode_fixup, dpms) V6: use

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V6)

2009-12-16 Thread Alex Deucher
2009/12/16 Rafał Miłecki zaj...@gmail.com: V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM on older hardware (IRQs, mode_fixup, dpms) V6: use separate dynpm module parameter Tested

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (v3)

2009-12-15 Thread Rafał Miłecki
2009/12/14 Sedat Dilek sedat.di...@googlemail.com: # cat /sys/kernel/debug/dri/*/radeon_pm_info engine clock: 391500 kHz memory clock: 297000 kHz engine clock: 391500 kHz memory clock: 297000 kHz Thanks you for testing! After some additional testing I've noticed I hit similar issue. My GPU

[PATCH] drm/radeon/kms: add dynamic engine reclocking (v4)

2009-12-15 Thread Rafał Miłecki
drm/radeon/kms: add dynamic engine reclocking (v4) V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs Fixed issue when reclocking didn't happen due to lack of IRQ. Also due to last patch enabling pm on

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (v4)

2009-12-15 Thread Alex Deucher
2009/12/15 Rafał Miłecki zaj...@gmail.com: drm/radeon/kms: add dynamic engine reclocking (v4) V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs Fixed issue when reclocking didn't happen due to

[PATCH] drm/radeon/kms: add dynamic engine reclocking (v5)

2009-12-15 Thread Rafał Miłecki
V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM in older hardware (IRQs, mode_fixup, dpms) This should be applied on top of 0001-drm-radeon-kms-init-pm-on-all-chipsets.patch [1] (thanks

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (v3)

2009-12-14 Thread Sedat Dilek
Addendum Up-/Downclocking: # cat /sys/module/radeon/parameters/dynclks -1 Value of -1 means dynamic clocking (dynclks) is not set. Two options to activate dynamic clocking: [1] At modprobe-time: (tested in runlevel-3: booted with nomodeset): # modprobe -r -v radeon --- unload kernel-module #

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (v3)

2009-12-13 Thread Sedat Dilek
Hi, I tried v3 of the radeon PM patch from [1]. Here my feeback: # lspci -nnvv | grep VGA controller 01:00.0 VGA compatible controller [0300]: ATI Technologies Inc M52 [Mobility Radeon X1300] [1002:714a] (prog-if 00 [VGA controller]) # mount -t debugfs none /sys/kernel/debug/ # ln -s

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (v2)

2009-12-12 Thread Rafał Miłecki
W dniu 10 grudnia 2009 01:54 użytkownik Rafał Miłecki zaj...@gmail.com napisał: Thanks Jerome for your patience and help :) I guess this should be signed-off-by-you as well when we finally get final version of patch. No many comments here, so I'll post new version in this thread, should not

[PATCH] drm/radeon/kms: add dynamic engine reclocking (v2)

2009-12-09 Thread Rafał Miłecki
Thanks Jerome for your patience and help :) I guess this should be signed-off-by-you as well when we finally get final version of patch. -- Rafał 0001-drm-radeon-kms-add-dynamic-engine-reclocking-v2.patch Description: Binary data

[PATCH] drm/radeon/kms: add dynamic engine reclocking

2009-12-03 Thread Rafał Miłecki
Someone willing to review? -- Rafał 0001-drm-radeon-kms-add-dynamic-engine-reclocking.patch Description: Binary data -- Join us December 9, 2009 for the Red Hat Virtual Experience, a free event focused on

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking

2009-12-03 Thread Jerome Glisse
On Thu, Dec 03, 2009 at 02:56:39PM +0100, Rafał Miłecki wrote: Someone willing to review? I don't think this how we want to do thing, see my previous mail. To sumup -create workqueue with timeout -function which do the clock change and takes all lock necessary -function call from IRQ which

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking

2009-12-03 Thread Matthew Garrett
On Thu, Dec 03, 2009 at 09:56:40PM +0100, Jerome Glisse wrote: -create workqueue with timeout -function which do the clock change and takes all lock necessary -function call from IRQ which call the previous function This is difficult. ATOM sleeps. We could pass a parameter in the ATOM block