Re: [PATCH 00/23] drm: introduce drm_zalloc

2007-08-30 Thread Christoph Hellwig
On Thu, Aug 30, 2007 at 12:20:32PM -0400, Kristian H?gsberg wrote: The wrappers aren't useless the drm alloc/free passes in a memory space for debugging purposes so we can track memory abuse when developing, Do we ever use that, though? Having to pass in the pointer, the size and the

Re: [PATCH 00/23] drm: introduce drm_zalloc

2007-08-30 Thread Kristian Høgsberg
On Tue, 2007-08-28 at 21:50 +0100, Dave Airlie wrote: On Tue, 28 Aug 2007, Christoph Hellwig wrote: On Mon, Aug 27, 2007 at 10:57:50PM +0200, [EMAIL PROTECTED] wrote: Hello, As there are many places in drm code where drm_alloc + memset is used this patch series introduces

Re: [PATCH 00/23] drm: introduce drm_zalloc

2007-08-30 Thread Dave Airlie
Note the slab has a memory tracking feature that accounts memory to callers of the allocator. IF that's not enough for you please help improving the common code instead of inventing your own. Christoph that code was written over 6-7 years ago, feel free to provide a patch for it to use the

[PATCH 00/23] drm: introduce drm_zalloc

2007-08-28 Thread m . kozlowski
Hello, As there are many places in drm code where drm_alloc + memset is used this patch series introduces drm_zalloc and also makes use of drm_calloc where needed. Most of these patches save some bytes so the benefit is a few kB saved (gcc 4.1.2) with patch applied. Also some small

Re: [PATCH 00/23] drm: introduce drm_zalloc

2007-08-28 Thread Christoph Hellwig
On Mon, Aug 27, 2007 at 10:57:50PM +0200, [EMAIL PROTECTED] wrote: Hello, As there are many places in drm code where drm_alloc + memset is used this patch series introduces drm_zalloc and also makes use of drm_calloc where needed. Most of these patches save some bytes so the benefit is

Re: [PATCH 00/23] drm: introduce drm_zalloc

2007-08-28 Thread Dave Airlie
On Tue, 28 Aug 2007, Christoph Hellwig wrote: On Mon, Aug 27, 2007 at 10:57:50PM +0200, [EMAIL PROTECTED] wrote: Hello, As there are many places in drm code where drm_alloc + memset is used this patch series introduces drm_zalloc and also makes use of drm_calloc where needed. Most of