[PATCH] drm: fix amdkfd use-after-free GP fault

2017-11-13 Thread Randy Dunlap
From: Randy Dunlap Fix GP fault caused by dev_info() reference to a struct device* after the device has been freed (use after free). kfd_chardev_exit() frees the device so 'kfd_device' should not be used after calling kfd_chardev_exit(). To reproduce, just load the module

[PATCH] drm/amd/display/dc/dce110/dce110_mem_input_v: use swap macro in program_size_and_rotation

2017-11-13 Thread Gustavo A. R. Silva
Make use of the swap macro instead of _manually_ swapping values and remove unnecessary variable swap. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva ---

Re: [PATCH 10/10] gpu: host1x: Optionally block when acquiring channel

2017-11-13 Thread Dmitry Osipenko
On 07.11.2017 18:29, Dmitry Osipenko wrote: > On 07.11.2017 16:11, Mikko Perttunen wrote: >> On 05.11.2017 19:14, Dmitry Osipenko wrote: >>> On 05.11.2017 14:01, Mikko Perttunen wrote: Add an option to host1x_channel_request to interruptibly wait for a free channel. This allows IOCTLs

[PATCH] drm/i915: Fix false-positive assert_rpm_wakelock_held in i915_pmic_bus_access_notifier v2

2017-11-13 Thread Hans de Goede
assert_rpm_wakelock_held is triggered from i915_pmic_bus_access_notifier even though it gets unregistered on (runtime) suspend, this is caused by a race happening under the following circumstances: intel_runtime_pm_put does: atomic_dec(_priv->pm.wakeref_count);

[PATCH] drm/amd/display/dc/core/dc_resource: use swap macro in rect_swap_helper

2017-11-13 Thread Gustavo A. R. Silva
Make use of the swap macro instead of _manually_ swapping values and remove unnecessary variable temp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva ---

[PATCH 0/1] drm/i915: Fix false-positive assert_rpm_wakelock_held in i915_pmic_bus_access_notifier v2

2017-11-13 Thread Hans de Goede
Hi, This is a resend of the first patch of my 3 patch "drm/i915: Misc. PMIC bus access notifier fixes" series for some reason I'm not having any luck with the CI with this series (I believe I'm just hitting glitches) so I'm splitting it up and see if I can see which patch (if any) makes the CI

Re: [PATCH 1/2] lib/rbtree,drm/mm: Add rbtree_replace_node_cached()

2017-11-13 Thread Davidlohr Bueso
On 2017-11-09 13:24, Chris Wilson wrote: Add a variant of rbtree_replace_node() that maintains the leftmost cached of struct rbtree_root_cached when replacing nodes within the rbtree. As drm_mm is the only rb_replace_node() being used on an interval tree, the mistake looks fairly

Re: [PATCH] drm/stm: ltdc: add clut mode support

2017-11-13 Thread Peter Rosin
On 2017-11-10 17:12, Philippe CORNU wrote: > Hi Peter, > > On 11/07/2017 05:34 PM, Peter Rosin wrote: >> On 2017-11-07 16:53, Philippe CORNU wrote: >>> + Peter >>> >>> Hi Peter, >>> >>> CLUT support on STM32 has been removed thanks to your clean up patch >> >> Support is a bit strong for what I

Re: [PATCH 10/10] gpu: host1x: Optionally block when acquiring channel

2017-11-13 Thread Dmitry Osipenko
On 11.11.2017 00:15, Dmitry Osipenko wrote: > On 07.11.2017 18:29, Dmitry Osipenko wrote: >> On 07.11.2017 16:11, Mikko Perttunen wrote: >>> On 05.11.2017 19:14, Dmitry Osipenko wrote: On 05.11.2017 14:01, Mikko Perttunen wrote: > Add an option to host1x_channel_request to interruptibly

[PATCH] uapi: fix linux/kfd_ioctl.h userspace compilation errors

2017-11-13 Thread Dmitry V. Levin
Consistently use types provided by via to fix the following linux/kfd_ioctl.h userspace compilation errors: /usr/include/linux/kfd_ioctl.h:236:2: error: unknown type name 'uint64_t' uint64_t va_addr; /* to KFD */ /usr/include/linux/kfd_ioctl.h:237:2: error: unknown type name 'uint32_t'

[Bug 103678] gdm couldn't start with Vega RX 56 video card

2017-11-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103678 --- Comment #17 from Christian König --- (In reply to mikhail.v.gavrilov from comment #16) > It seems that the intel driver is culprit here. Ah, of course. Yeah X prefers any driver over the Vesa driver, so when the

[PATCH v2 1/2] drm: rcar-du: Share plane atomic check code between Gen2 and Gen3

2017-11-13 Thread Laurent Pinchart
The plane atomic check implementation is identical on Gen2 (DU planes) and Gen3 (VSP planes), but two separate functions exist as they operate on different data structures. Refactor the code to share the implementation. Signed-off-by: Laurent Pinchart

[PATCH v2 0/2] R-Car DU: Clip planes to screen boundaries

2017-11-13 Thread Laurent Pinchart
Hello, This patch series fixes support for planes that cross the screen boundaries. The KMS API supports such a configuration, but the DU and VSP hardware doesn't. This leads to different kind of dispay artifacts or hangs. The series starts with a bit of refactoring to share existing code and

[PATCH v2 2/2] drm: rcar-du: Clip planes to screen boundaries

2017-11-13 Thread Laurent Pinchart
Unlike the KMS API, the hardware doesn't support planes exceeding the screen boundaries or planes being located fully off-screen. We need to clip plane coordinates to support the use case. Fortunately the DRM core offers the drm_plane_helper_check_state() helper that valides the scaling factor

Re: [Intel-gfx] [PATCH 0/7] Add Plane Color Properties

2017-11-13 Thread Daniel Stone
Hi Uma, On 10 November 2017 at 08:37, Shankar, Uma wrote: >>This is missing documentation on how plane colour management interacts with >>CRTC colour management. Is it a step before CRTC colour management is >>applied, or does it bypass CRTC colour management, or ... ? >>

Re: [PATCH] drm/stm: ltdc: add clut mode support

2017-11-13 Thread Philippe CORNU
Hi Peter, On 11/12/2017 01:31 PM, Peter Rosin wrote: > On 2017-11-10 17:12, Philippe CORNU wrote: >> Hi Peter, >> >> On 11/07/2017 05:34 PM, Peter Rosin wrote: >>> On 2017-11-07 16:53, Philippe CORNU wrote: + Peter Hi Peter, CLUT support on STM32 has been removed thanks

[PATCH] fbcon: Initialize ops->info early

2017-11-13 Thread Thierry Reding
From: Thierry Reding During console takeover, which happens for all DRM/KMS setups using the fbdev helpers, fbcon_startup() is called before fbcon_init() and as a result con2fb_acquire_newinfo() will not be called (info->fbcon_par was set to non-NULL in fbcon_startup()) to

[PATCH 1/2] drm/ttm: make unlocking in ttm_bo_cleanup_refs optional v2

2017-11-13 Thread Christian König
Needed for the next patch. v2: actually predicate all unlocks Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 59 +--- 1 file changed, 33 insertions(+), 26 deletions(-) diff --git

[PATCH 2/2] drm/ttm: optimize ttm_mem_evict_first v4

2017-11-13 Thread Christian König
Deleted BOs with the same reservation object can be reaped even if they can't be reserved. v2: rebase and we still need to remove/add the BO from/to the LRU. v3: fix remove/add one more time, cleanup the logic a bit v4: we should still check if the eviction is valuable Signed-off-by: Christian

[Bug 103443] [CI] igt@kms_setmode@[clone-exclusive-crtc | invalid-clone-exclusive-crtc] - warn - no modes for connector 76

2017-11-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103443 --- Comment #2 from Marta Löfstedt --- Here is another test that produce WARN only where there a no modes available https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3335/shard-glkb2/igt@kms_sysfs_edid_timing.html --

Re: [PATCH libdrm 0/4] Dynamicly disable suites and tets.

2017-11-13 Thread Michel Dänzer
On 12/11/17 10:35 AM, Christian König wrote: > A few comments on the code: > >> +/* Validate bo size is bit bigger then the request domain */ >> +static inline bool amdgpu_bo_validate_bo_size(struct amdgpu_device >> *adev, >> +                      unsigned long size, u32 domain) > Drop the

[Bug 103443] [CI] igt@kms_setmode@[clone-exclusive-crtc | invalid-clone-exclusive-crtc] - warn - no modes for connector 76

2017-11-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103443 --- Comment #3 from Marta Löfstedt --- here also: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3331/shard-glkb2/i...@testdisplay.html -- You are receiving this mail because: You are the assignee for the

[PATCH/RFC 2/2] drm: rcar-du: Allow importing non-contiguous dma-buf with VSP

2017-11-13 Thread Laurent Pinchart
When the DU sources its frames from a VSP, it performs no memory access and thus has no requirements on imported dma-buf memory types. In particular the DU could import a physically non-contiguous buffer that would later be mapped contiguously through the VSP IOMMU. This use case isn't supported

[PATCH/RFC 1/2] drm: rcar-du: Set the DMA coherent mask for the DU device

2017-11-13 Thread Laurent Pinchart
The DU DMA address space is limited to 32 bits, so the DMA coherent mask should be set accordingly. The DMA mapping implementation will transparently map high memory buffers to 32-bit addresses through an IOMMU when present (or through bounce buffers otherwise, which isn't a supported use case as

[PATCH/RFC 0/2] R-Car DU: Support importing non-contiguous dma-buf with VSP

2017-11-13 Thread Laurent Pinchart
Hello everybody, This patch series fixes two issues related to dma-buf import for the Renesas R-Car DU when the imported buffer is either not physically contiguous or located in high memory. Both cases require the use of an IOMMU to remap the buffers contiguously and in 32-bit DMA space. On Gen2

Re: [PATCH/RFC 2/2] drm: rcar-du: Allow importing non-contiguous dma-buf with VSP

2017-11-13 Thread Liviu Dudau
On Mon, Nov 13, 2017 at 12:32:28PM +0200, Laurent Pinchart wrote: > When the DU sources its frames from a VSP, it performs no memory access > and thus has no requirements on imported dma-buf memory types. In > particular the DU could import a physically non-contiguous buffer that > would later be

[PATCH] MAINTAINERS: change maintainer for Rockchip drm drivers

2017-11-13 Thread Mark Yao
For personal reasons, Mark Yao will leave rockchip, can not continue maintain drm/rockchip, Sandy Huang will take over the drm/rockchip. Cc: Sandy Huang Cc: Heiko Stuebner Signed-off-by: Mark Yao --- MAINTAINERS | 2 +- 1 file

Re: [PATCH/RFC 1/2] drm: rcar-du: Set the DMA coherent mask for the DU device

2017-11-13 Thread Liviu Dudau
On Mon, Nov 13, 2017 at 12:32:27PM +0200, Laurent Pinchart wrote: > The DU DMA address space is limited to 32 bits, so the DMA coherent mask > should be set accordingly. The DMA mapping implementation will > transparently map high memory buffers to 32-bit addresses through an > IOMMU when present

[Bug 99801] Rx480 doesn't output properly onto z27q at 5120x2880

2017-11-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99801 Matthew Treinish changed: What|Removed |Added Attachment #129571|0 |1 is

[Bug 99801] Rx480 doesn't output properly onto z27q at 5120x2880

2017-11-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99801 Matthew Treinish changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [PATCH 1/2] drm/vc4: Account for interrupts in flight

2017-11-13 Thread Eric Anholt
Stefan Schake writes: > Synchronously disable the IRQ to make the following cancel_work_sync > invocation effective. > > An interrupt in flight could enqueue further overflow mem work. As we > free the binner BO immediately following vc4_irq_uninstall this caused > a NULL

Re: [GIT PULL] exynos-drm-next

2017-11-13 Thread Dave Airlie
On 26 October 2017 at 11:37, Inki Dae wrote: > Hi Dave, > >Improving Exynos DRM HDMI and Mixer drivers and also adding >HDMI audio support. > >Please kindly let me know if there is any problem. > >Ps. we are reviewing IPP v2 driver[1] which controls post

[Bug 103700] Displayport link status failed on resume from suspend on eDP on RX580 with Asus GL702ZC

2017-11-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103700 --- Comment #2 from dwagner --- This bug could be the same as https://bugs.freedesktop.org/show_bug.cgi?id=103277 - but since I have only one display connected to the GPU - which stays off after resume (and then the system

[radeon-alex:upstream-4.14-drm-next-amd-dc-staging-chrome 1/16] drivers/gpu//drm/amd/amdgpu/amdgpu_ttm.c:967:2: error: implicit declaration of function 'ttm_populate_and_map_pages'

2017-11-13 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git upstream-4.14-drm-next-amd-dc-staging-chrome head: 4448b9a68413462529d018050cd246bc33957bd6 commit: a9aa2210cd8aadeea91c845a0a05510d2a91ffa6 [1/16] FORKLIFT: amd: copy amd folder as is from dave airlie tree config:

[Bug 101978] [bisected] war thunder performance reduced by ~28%

2017-11-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101978 --- Comment #7 from higu...@gmx.net --- >Also, there are amdgpu kernel driver changes lined up for 4.14 that might help. Updates to 4.14 and i fail to see any improvement, sclk is still low, performance is still very low for what this card is

Re: [PATCH/RFC 2/2] drm: rcar-du: Allow importing non-contiguous dma-buf with VSP

2017-11-13 Thread Laurent Pinchart
Hi Liviu, On Monday, 13 November 2017 13:53:14 EET Liviu Dudau wrote: > On Mon, Nov 13, 2017 at 12:32:28PM +0200, Laurent Pinchart wrote: > > When the DU sources its frames from a VSP, it performs no memory access > > and thus has no requirements on imported dma-buf memory types. In > >

Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-13 Thread Eric Anholt
Stefan Schake writes: > The overflow mem work callback vc4_overflow_mem_work reenables its > associated interrupt upon completion. To ensure all interrupts are disabled > when we return from vc4_irq_uninstall, we need to disable it again if > cancel_work_sync indicated

[radeon-alex:upstream-4.14-drm-next-amd-dc-staging-chrome 1/16] drivers/gpu//drm/amd/amdgpu/amdgpu_ttm.c:967:9: error: implicit declaration of function 'ttm_populate_and_map_pages'; did you mean 'vmem

2017-11-13 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git upstream-4.14-drm-next-amd-dc-staging-chrome head: 4448b9a68413462529d018050cd246bc33957bd6 commit: a9aa2210cd8aadeea91c845a0a05510d2a91ffa6 [1/16] FORKLIFT: amd: copy amd folder as is from dave airlie tree config: arm64-allyesconfig

Re: [PATCH 2/2] drm/ttm: optimize ttm_mem_evict_first v4

2017-11-13 Thread Chunming Zhou
On 2017年11月13日 17:54, Christian König wrote: Deleted BOs with the same reservation object can be reaped even if they can't be reserved. v2: rebase and we still need to remove/add the BO from/to the LRU. v3: fix remove/add one more time, cleanup the logic a bit v4: we should still check if the

Re: drivers/gpu/drm/bridge/lvds-encoder.c broken in mainline

2017-11-13 Thread Archit Taneja
On 11/14/2017 02:33 AM, Eric Anholt wrote: Lothar Waßmann writes: Hi, On Wed, 08 Nov 2017 10:18:03 -0800 Eric Anholt wrote: Lothar Waßmann writes: Hi, drivers/gpu/drm/bridge/lvds-encoder.c driver is currently dysfunctional due to:

[Bug 103726] GPU crashes freezing the system and weird rendering issues on CAYMAN

2017-11-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103726 Bug ID: 103726 Summary: GPU crashes freezing the system and weird rendering issues on CAYMAN Product: Mesa Version: unspecified Hardware: Other OS: All

[PATCH] drm/tilcdc: uninitialized variable in tilcdc_get_overlay()

2017-11-13 Thread Dan Carpenter
The code seems to assume that of_fdt_unflatten_tree() sets "overlay" to NULL on error but actually it could be uninitialized. Fixes: 4e7221580223 ("drm/tilcdc: Add DRM_TILCDC_SLAVE_COMPAT for ti,tilcdc,slave binding support") Signed-off-by: Dan Carpenter diff --git

[PATCH] OMAPFB: prevent buffer underflow in omapfb_parse_vram_param()

2017-11-13 Thread Dan Carpenter
We cap the upper bound of "fbnum" but we also need to check for negatives or make the type unsigned. Signed-off-by: Dan Carpenter diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c index

Re: [Intel-gfx] [PATCH] drm/debugfs: Fix framebuffer debugfs file init

2017-11-13 Thread Dave Airlie
On 14 November 2017 at 09:12, Noralf Trønnes wrote: > The introduction of: drm/framebuffer: Add framebuffer debugfs file > broke vgem. That patch assumed that all drivers had initialized the > dev->mode_config.fb_lock mutex which happens in drm_mode_config_init(). > vgem

Re: [PATCH] drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU

2017-11-13 Thread Inki Dae
2017년 11월 13일 23:28에 Marek Szyprowski 이(가) 쓴 글: > Hi Inki, > > On 2017-11-13 02:24, Inki Dae wrote: >> Hi Marek, >> >> 2017년 11월 10일 16:35에 Marek Szyprowski 이(가) 쓴 글: >>> Dear Inki, >>> >>> On 2017-11-10 04:04, Inki Dae wrote: 2017년 11월 01일 01:28에 Marek Szyprowski 이(가) 쓴 글: > When no

[Bug 102358] WarThunder freezes at start, with activated vsync (vblank_mode=2)

2017-11-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102358 Thomas Hellström changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH] drm/atomic-helper: Calculate normalized zpos values

2017-11-13 Thread Ville Syrjälä
On Mon, Nov 13, 2017 at 02:48:20PM +0100, Thierry Reding wrote: > From: Thierry Reding > > kerneldoc for drm_plane_create_zpos_property() says that the DRM core > will automatically calculate the normalized zpos values, but it won't > currently do so. Modify the atomic

Re: [PATCH] drm/vblank: Fix vblank timestamp debugs

2017-11-13 Thread Arnd Bergmann
On Mon, Nov 13, 2017 at 4:02 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > We're currently calling ktime_to_timespec64() on stack garbage > hence the debug output for vblank timestamps also contains garbage. > Let's assing

[Bug 197851] Resume from suspend sometimes results in black screen on Radeon R5

2017-11-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=197851 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

[PATCH 4.9 79/87] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally

2017-11-13 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz commit 651e4769ba2a9f20c4b8a823ae2727bf7fa9c9f0 upstream. In chasing down issues with EDID probing, I found some duplicated but incomplete logic used to

[PATCH 4.9 81/87] drm/bridge: adv7511: Re-write the i2c address before EDID probing

2017-11-13 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz commit 3587c856675c45809010c2cee5b21096f6e8e938 upstream. I've found that by just turning the chip on and off via the POWER_DOWN register, I end up getting

[PATCH 4.9 80/87] drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID

2017-11-13 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: John Stultz commit 4226d9b127cf4758ba0e07931b3f0d59f1b1a50c upstream. Thus this patch changes the EDID probing logic so that we re-use the __adv7511_power_on/off()

Re: [PATCH libdrm 0/4] Dynamicly disable suites and tets.

2017-11-13 Thread Christian König
Am 13.11.2017 um 12:32 schrieb Michel Dänzer: On 12/11/17 10:35 AM, Christian König wrote: A few comments on the code: +/* Validate bo size is bit bigger then the request domain */ +static inline bool amdgpu_bo_validate_bo_size(struct amdgpu_device *adev, +                      unsigned long

[PATCH] drm/atomic-helper: Calculate normalized zpos values

2017-11-13 Thread Thierry Reding
From: Thierry Reding kerneldoc for drm_plane_create_zpos_property() says that the DRM core will automatically calculate the normalized zpos values, but it won't currently do so. Modify the atomic helpers to behave as documented. Signed-off-by: Thierry Reding

Re: [PATCH/RFC 0/2] R-Car DU: Support importing non-contiguous dma-buf with VSP

2017-11-13 Thread Kieran Bingham
Hi Laurent, On 13/11/17 10:32, Laurent Pinchart wrote: > Hello everybody, > > This patch series fixes two issues related to dma-buf import for the Renesas > R-Car DU when the imported buffer is either not physically contiguous or > located in high memory. > > Both cases require the use of an

Re: [PATCH 2/3] backlight: max8925_bl: fix device-tree node lookup

2017-11-13 Thread Daniel Thompson
On 13/11/17 10:20, Johan Hovold wrote: Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. To make things worse, the parent mfd node was also prematurely freed, while the child

[Bug 197841] lg 25um58-P monitor wrong refresh rate with rx 460

2017-11-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=197841 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

[PATCH] drm/vblank: Fix vblank timestamp debugs

2017-11-13 Thread Ville Syrjala
From: Ville Syrjälä We're currently calling ktime_to_timespec64() on stack garbage hence the debug output for vblank timestamps also contains garbage. Let's assing something to the ktime_t first before we go converting it to a timespec. While at it micro-optimize

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-13 Thread Daniel Thompson
On 13/11/17 10:20, Johan Hovold wrote: Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. To make things worse, the parent mfd node was also prematurely freed. Note that the nodes

RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver

2017-11-13 Thread Chen, Horace
Reivewed-by: Horace Chen -Original Message- From: Liu, Monk Sent: Monday, November 13, 2017 11:43 AM To: Chen, Horace ; Colin King ; Deucher, Alexander ; Koenig, Christian

Re: [PATCH libdrm 0/4] Dynamicly disable suites and tets.

2017-11-13 Thread Andrey Grodzovsky
On 11/13/2017 10:27 AM, Christian König wrote: Am 13.11.2017 um 15:57 schrieb Andrey Grodzovsky: On 11/13/2017 07:39 AM, Christian König wrote: Am 13.11.2017 um 12:32 schrieb Michel Dänzer: On 12/11/17 10:35 AM, Christian König wrote: A few comments on the code: +/* Validate bo size is

Re: [PATCH] drm: fix amdkfd use-after-free GP fault

2017-11-13 Thread Oded Gabbay
On Sat, Nov 11, 2017 at 8:16 AM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix GP fault caused by dev_info() reference to a struct device* > after the device has been freed (use after free). > kfd_chardev_exit() frees the device so 'kfd_device'

Re: Regression in Linux next-20171113 with fbdev timer conversion

2017-11-13 Thread Bartlomiej Zolnierkiewicz
On Monday, November 13, 2017 09:07:14 AM Tony Lindgren wrote: > Hi, Hi Tony, > Looks like next-20171113 now has a NULL pointe dereference with commit > 6c78935777d1 ("video: fbdev: Convert timers to use timer_setup()"). > > See the error below, any ideas? S

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-13 Thread Jose Abreu
Hi Ville, On 13-11-2017 17:04, Ville Syrjala wrote: > > + if (to_match->picture_aspect_ratio) > + match_flags |= DRM_MODE_MATCH_ASPECT_RATIO; > + > Maybe "if (to_match->picture_aspect_ratio != HDMI_PICTURE_ASPECT_NONE && to_match->picture_aspect_ratio !=

[drm-intel:drm-intel-next-queued 6/6] intel_device_info.c:undefined reference to `__udivdi3'

2017-11-13 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: dab91783338bd3dd42638f89b5f7e34c57773207 commit: dab91783338bd3dd42638f89b5f7e34c57773207 [6/6] drm/i915: expose command stream timestamp frequency to userspace config: i386-defconfig (attached as .config) compiler:

[PATCH 3/3] backlight: tps65217_bl: fix device-tree node lookup

2017-11-13 Thread Johan Hovold
Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. This would only cause trouble if the child node is missing while there is an unrelated node named "backlight" elsewhere in the tree.

[PATCH] video: fbdev: atmel_lcdfb: fix display-timings lookup

2017-11-13 Thread Johan Hovold
Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. To make things worse, the parent display node was also prematurely freed. Note that the display and timings node references are never

[PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-13 Thread Johan Hovold
Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. To make things worse, the parent mfd node was also prematurely freed. Note that the nodes returned from the two calls to

Re: [PATCH] uapi: fix linux/kfd_ioctl.h userspace compilation errors

2017-11-13 Thread Oded Gabbay
On Mon, Nov 13, 2017 at 2:35 AM, Dmitry V. Levin wrote: > Consistently use types provided by via > to fix the following linux/kfd_ioctl.h userspace compilation errors: > > /usr/include/linux/kfd_ioctl.h:236:2: error: unknown type name 'uint64_t' > uint64_t va_addr; /* to

Re: [PATCH 07/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

2017-11-13 Thread Jose Abreu
On 13-11-2017 17:04, Ville Syrjala wrote: > From: Ville Syrjälä > > If the user mode would specify an aspect ratio other than 4:3 or 16:9 > we now silently ignore it. Maybe a better apporoach is to return an > error? Let's try that. > > Also we must be careful

Re: [PATCH 08/10] video/hdmi: Reject illegal picture aspect ratios

2017-11-13 Thread Jose Abreu
On 13-11-2017 17:04, Ville Syrjala wrote: > From: Ville Syrjälä > > AVI infoframe can only carry none, 4:3, or 16:9 picture aspect > ratios. Return an error if the user asked for something different. > > Cc: Shashank Sharma > Cc: "Lin,

Re: [PATCH] fbcon: Initialize ops->info early

2017-11-13 Thread Bartlomiej Zolnierkiewicz
On Monday, November 13, 2017 10:45:46 AM Thierry Reding wrote: > From: Thierry Reding > > During console takeover, which happens for all DRM/KMS setups using the > fbdev helpers, fbcon_startup() is called before fbcon_init() and as a > result con2fb_acquire_newinfo() will not

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

2017-11-13 Thread Ville Syrjälä
On Mon, Nov 13, 2017 at 06:13:37PM +, Jose Abreu wrote: > Hi Ville, > > On 13-11-2017 17:04, Ville Syrjala wrote: > > > > + if (to_match->picture_aspect_ratio) > > + match_flags |= DRM_MODE_MATCH_ASPECT_RATIO; > > + > > > > Maybe "if (to_match->picture_aspect_ratio != >

Re: [PATCH v5 04/12] drm/framebuffer: Add framebuffer debugfs file

2017-11-13 Thread Noralf Trønnes
Den 11.11.2017 19.55, skrev Chris Wilson: Quoting Noralf Trønnes (2017-11-07 19:13:40) Add debugfs file that dumps info about the framebuffers and its planes. Also dump info about any connected gem object(s). This isn't too hot for non-modesetting drm drivers. And isn't this growing a

Re: [PATCH 07/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

2017-11-13 Thread Ville Syrjälä
On Mon, Nov 13, 2017 at 06:30:47PM +, Jose Abreu wrote: > > > On 13-11-2017 17:04, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > If the user mode would specify an aspect ratio other than 4:3 or 16:9 > > we now silently ignore it. Maybe a better

[radeon-alex:amd-staging-drm-next 2749/2876] sound/soc/amd/raven/pci-acp3x.c:58:8: error: implicit declaration of function 'pci_enable_msi'

2017-11-13 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: eee12cc2150b932ee52ccf89de611a7ba030eb90 commit: 0bd599b1f523598c05f13a4a562884e82a378c2c [2749/2876] ASoC: AMD: enable ACP3x drivers build config: blackfin-allyesconfig (attached as .config) compiler:

[Bug 102800] DRI_PRIME regression- radeon: Failed to allocate virtual address for buffer

2017-11-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102800 --- Comment #11 from higu...@gmx.net --- just tested kernel 4.14.0 (without the above patch) and it still fails i will apply the patch again, as a workaround -- You are receiving this mail because: You are the assignee for the

[PULL] drm-misc-fixes

2017-11-13 Thread Sean Paul
Hi Dave, Here's the previous PR plus the rockchip fix that snuck in. drm-misc-fixes-2017-11-13: Driver Changes: - qxl: Use a shadow bo as primary and blit to it to fix flicker (Gerd) - rockchip: Convert psr spinlock to mutex (Emil) Cc: Emil Renner Berthing Cc: Gerd Hoffmann

[drm-intel:drm-intel-next-queued 6/6] drivers/gpu/drm/i915/intel_device_info.c:345: undefined reference to `__udivdi3'

2017-11-13 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: dab91783338bd3dd42638f89b5f7e34c57773207 commit: dab91783338bd3dd42638f89b5f7e34c57773207 [6/6] drm/i915: expose command stream timestamp frequency to userspace config: i386-randconfig-s0-201746 (attached as .config)

Re: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver

2017-11-13 Thread Alex Deucher
On Mon, Nov 13, 2017 at 9:40 AM, Chen, Horace wrote: > Reivewed-by: Horace Chen Applied. thanks! Alex > > -Original Message- > From: Liu, Monk > Sent: Monday, November 13, 2017 11:43 AM > To: Chen, Horace ; Colin King >

Re: linux-next: manual merge of the devicetree tree with the drm tree

2017-11-13 Thread Jyri Sarha
On 11/13/17 20:43, Frank Rowand wrote: > Hi Jyri, > > On 11/13/17 07:40, Jyri Sarha wrote: >> On 11/13/17 07:58, Stephen Rothwell wrote: >>> Hi all, >>> >>> On Mon, 30 Oct 2017 20:37:56 + Mark Brown wrote: Today's linux-next merge of the devicetree tree got a

Re: [PATCH libdrm 0/4] Dynamicly disable suites and tets.

2017-11-13 Thread Christian König
Am 13.11.2017 um 15:57 schrieb Andrey Grodzovsky: On 11/13/2017 07:39 AM, Christian König wrote: Am 13.11.2017 um 12:32 schrieb Michel Dänzer: On 12/11/17 10:35 AM, Christian König wrote: A few comments on the code: +/* Validate bo size is bit bigger then the request domain */ +static

[PATCH 2/3] backlight: max8925_bl: fix device-tree node lookup

2017-11-13 Thread Johan Hovold
Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. To make things worse, the parent mfd node was also prematurely freed, while the child backlight node was leaked. Fixes: 47ec340cb8e2

Re: [PATCH 08/10] drm/tegra: Implement dynamic channel allocation model

2017-11-13 Thread Dmitry Osipenko
On 07.11.2017 15:29, Mikko Perttunen wrote: > On 05.11.2017 19:43, Dmitry Osipenko wrote: >> On 05.11.2017 14:01, Mikko Perttunen wrote: >>> In the traditional channel allocation model, a single hardware channel >>> was allocated for each client. This is simple from an implementation >>>

[PATCH 09/10] video/hdmi: Constify 'buffer' to the unpack functions

2017-11-13 Thread Ville Syrjala
From: Ville Syrjälä The unpack functions just read from the passed in buffer, so make it const. Cc: Thierry Reding Cc: Hans Verkuil Cc: linux-me...@vger.kernel.org Signed-off-by: Ville Syrjälä

[PATCH 02/10] drm/edid: Allow HDMI infoframe without VIC or S3D

2017-11-13 Thread Ville Syrjala
From: Ville Syrjälä Appedix F of HDMI 2.0 says that some HDMI sink may fail to switch from 3D to 2D mode in a timely fashion if the source simply stops sending the HDMI infoframe. The suggested workaround is to keep sending the infoframe even when strictly not

[PATCH 03/10] drm/modes: Introduce drm_mode_match()

2017-11-13 Thread Ville Syrjala
From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modes.c | 134

[PATCH 05/10] drm/edid: Fix up edid_cea_modes[] formatting

2017-11-13 Thread Ville Syrjala
From: Ville Syrjälä Fix up a bunch of bad indentation and insconsistent comments in edid_cea_modes[]. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_edid.c | 84 +++--- 1 file changed,

[PATCH 00/10] drm/edid: Infoframe cleanups and fixes

2017-11-13 Thread Ville Syrjala
From: Ville Syrjälä This series tries to fix some issues with HDMI infoframes. In particular we can currently send a bogus picture aspect ratio in the infoframe. I included stuff to to make the infoframe unpakc more robust, evne though we don't (yet) use it in drm.

[PATCH 04/10] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

2017-11-13 Thread Ville Syrjala
From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[PATCH 01/10] video/hdmi: Allow "empty" HDMI infoframes

2017-11-13 Thread Ville Syrjala
From: Ville Syrjälä HDMI 2.0 Appendix F suggest that we should keep sending the infoframe when switching from 3D to 2D mode, even if the infoframe isn't strictly necessary (ie. not needed to transmit the VIC or stereo information). This is a workaround against some

[PATCH] drm/tilcdc: Remove obsolete "ti, tilcdc, slave" dts binding support

2017-11-13 Thread Jyri Sarha
This patch removes DRM_TILCDC_SLAVE_COMPAT option for supporting the obsolete "ti,tilcdc,slave" device tree binding. The new of_graph based binding - that is widely used in other drm driver too - has been supported since Linux v4.2. Maintaining the the backwards dts conversion code in 0the

Re: [PATCH 3/3] backlight: tps65217_bl: fix device-tree node lookup

2017-11-13 Thread Daniel Thompson
On 13/11/17 10:20, Johan Hovold wrote: Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its children. This would only cause trouble if the child node is missing while there is an unrelated node

Re: [PATCH] drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU

2017-11-13 Thread Marek Szyprowski
Hi Inki, On 2017-11-13 02:24, Inki Dae wrote: Hi Marek, 2017년 11월 10일 16:35에 Marek Szyprowski 이(가) 쓴 글: Dear Inki, On 2017-11-10 04:04, Inki Dae wrote: 2017년 11월 01일 01:28에 Marek Szyprowski 이(가) 쓴 글: When no IOMMU is available, all GEM buffers allocated by Exynos DRM driver are contiguous,

Re: [PATCH libdrm 0/4] Dynamicly disable suites and tets.

2017-11-13 Thread Andrey Grodzovsky
On 11/13/2017 07:39 AM, Christian König wrote: Am 13.11.2017 um 12:32 schrieb Michel Dänzer: On 12/11/17 10:35 AM, Christian König wrote: A few comments on the code: +/* Validate bo size is bit bigger then the request domain */ +static inline bool amdgpu_bo_validate_bo_size(struct

[Bug 103697] [regression] shared memory size 64k -> 32k?

2017-11-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103697 --- Comment #2 from O Heid --- I checked back with AMD and they say that there is hardware support for 64kB shared memory. This actually gets exposed in OpenCL and ROCm/HC. The 2016 AMD GCN3 manual wrongly states it is

Re: linux-next: manual merge of the devicetree tree with the drm tree

2017-11-13 Thread Jyri Sarha
On 11/13/17 07:58, Stephen Rothwell wrote: > Hi all, > > On Mon, 30 Oct 2017 20:37:56 + Mark Brown wrote: >> >> Today's linux-next merge of the devicetree tree got a conflict in: >> >> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c >> >> between commit: >> >>

[PATCH libdrm v2] amdgpu: Add memory over allocation test.

2017-11-13 Thread Andrey Grodzovsky
Allocates 1 TB of memory. Test is disabled by default since it's triggers OOM killer. v2: FIx the test to only alloc the BO and assert if return value not equal to -ENOMEM and remove test disable on start. Signed-off-by: Andrey Grodzovsky --- tests/amdgpu/bo_tests.c

[PATCH 10/10] video/hdmi: Pass buffer size to infoframe unpack functions

2017-11-13 Thread Ville Syrjala
From: Ville Syrjälä To make sure the infoframe unpack functions don't end up examining stack garbage or oopsing, let's pass in the size of the buffer. Cc: Thierry Reding Cc: Hans Verkuil Cc:

[PATCH 08/10] video/hdmi: Reject illegal picture aspect ratios

2017-11-13 Thread Ville Syrjala
From: Ville Syrjälä AVI infoframe can only carry none, 4:3, or 16:9 picture aspect ratios. Return an error if the user asked for something different. Cc: Shashank Sharma Cc: "Lin, Jia" Cc: Akashdeep Sharma

  1   2   >