Re: [PATCH v2 10/18] drm/sun4i: mixer: Read id from DT

2018-07-11 Thread Chen-Yu Tsai
On Wed, Jul 11, 2018 at 3:10 PM, Jernej Škrabec wrote: > Dne sreda, 11. julij 2018 ob 05:11:56 CEST je Chen-Yu Tsai napisal(a): >> On Wed, Jul 11, 2018 at 4:35 AM, Jernej Skrabec > wrote: >> > Currently, TCON supports 2 ways to match TCON with engine (mixer in this >> > case). Old way is to just

[PATCH 17/17] drm/armada: add plane colorspace properties

2018-07-11 Thread Russell King
Use the DRM standard plane properties for specifying the YUV colour encoding parameter. Our colour range is fixed at limited range. Since we are transitioning to atomic modeset, we need to explicitly add handling of these properties to our atomic_set_property() method, but once the transition is

[PATCH 03/20] drm/armada: provide pitches from armada_drm_plane_calc_addrs()

2018-07-11 Thread Russell King
Provide the framebuffer pitches from armada_drm_plane_calc_addrs() as well as the base addresses for each plane. Since this is now about more than just addresses, rename to armada_drm_plane_calc(). Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_overlay.c | 8 drivers/gp

Re: [PATCH v2 1/1] drm/panel: Add support for Olimex LCD-OLinuXino panel

2018-07-11 Thread Stefan Mavrodiev
On 07/10/2018 01:32 PM, Thierry Reding wrote: On Mon, Jun 25, 2018 at 09:44:35AM +0300, Stefan Mavrodiev wrote: This patch adds Olimex Ltd. LCD-OLinuXino bridge panel driver. The panel is used with different LCDs (currently from 480x272 to 1280x800). Small EEPROM chip is used for identificatio

[PATCH v2 00/18] Allwinner R40 HDMI refactoring

2018-07-11 Thread Jernej Skrabec
This series fixes several issues found in R40 HDMI patch series after it was applied. Conversation can be found here: http://lists.infradead.org/pipermail/linux-arm-kernel/2018-June/586011.html Patches are based on latest linux-next (next-20180710) and are ordered in such way that they don't break

[PATCH 02/20] drm/armada: pass plane state into armada_drm_plane_calc_addrs()

2018-07-11 Thread Russell King
armada_drm_plane_calc_addrs() gets all its information from the plane state, so it makes sense to pass the plane state pointer down into this function, rather than extracting the information in identical ways, sometimes a couple of layers up. Signed-off-by: Russell King --- drivers/gpu/drm/armad

[PATCH v2 08/18] ARM: dts: sun8i: r40: Add mixer ids to TCON TOP

2018-07-11 Thread Jernej Skrabec
sun4i-drm DT binding, second paragraph of the first section says: For all connections between components up to the TCONs in the display pipeline, when there are multiple components of the same type at the same depth, the local endpoint ID must be the same as the remote component's index. Add mixe

[PATCH 10/20] drm/armada: unhook dpms state from armada_drm_crtc_update()

2018-07-11 Thread Russell King
Explicitly pass in the desired enable/disable state into armada_drm_crtc_update() rather than having it use the DPMS state stored in our crtc structure. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --

[PATCH 20/20] drm/armada: remove obsolete fb unreferencing kfifo and workqueue

2018-07-11 Thread Russell King
Remove the obsolete fb unreferencing system that is no longer used since we've transitioned to atomic modeset. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_drm.h | 7 --- drivers/gpu/drm/armada/armada_drv.c | 35 --- 2 files changed, 42 delet

[PATCH v2 14/18] ARM: dts: sun8i: r40: Remove fallback compatible for TCON TV

2018-07-11 Thread Jernej Skrabec
A83T and R40 TCON TV are very similar. However, R40 TCON TV is wired differently, which makes it incompatible with A83T TCON TV. Because of that, remove fallback A83T TCON TV compatible. Fixes: 05a43a262d03 ("ARM: dts: sun8i: r40: Add HDMI pipeline") Reviewed-by: Chen-Yu Tsai Signed-off-by: Jer

[PATCH 03/17] drm/armada: move mode set vblank handling and disable/enable

2018-07-11 Thread Russell King
Move the mode set vblank handling and controller enable/disable to the prepare() and commit() callbacks. This will be needed when we move to mode_set_nofb() as we should not enable the controller without the plane coordinates and location having been properly updated. Signed-off-by: Russell King

Re: [PATCH 16/17] drm/sun4i: tcon-top: Remove mux configuration at probe time

2018-07-11 Thread Jernej Škrabec
Dne torek, 10. julij 2018 ob 18:09:26 CEST je Chen-Yu Tsai napisal(a): > On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec wrote: > > Now that R40 TCON migrated to runtime mux configuration, old code can be > > removed. > > > > Signed-off-by: Jernej Skrabec > > --- > > > > drivers/gpu/drm/sun4i/

[PATCH 15/20] drm/armada: switch overlay plane to atomic modeset

2018-07-11 Thread Russell King
Switch the overlay plane away from the transitional helpers and legacy methods, and use atomic helpers instead to implement the legacy set_plane ioctl methods. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c| 89 - drivers/gpu/drm/armada/armada_crtc.h

Re: [PATCH v2 1/1] drm/panel: Add support for Olimex LCD-OLinuXino panel

2018-07-11 Thread Stefan Mavrodiev
On 07/10/2018 04:27 PM, Greg Kroah-Hartman wrote: On Tue, Jul 10, 2018 at 04:08:54PM +0300, Stefan Mavrodiev wrote: On 07/10/2018 01:32 PM, Thierry Reding wrote: +MODULE_AUTHOR("Stefan Mavrodiev "); +MODULE_DESCRIPTION("LCD-OLinuXino driver"); +MODULE_LICENSE("GPL v2"); This seems to contrad

[PATCH v2 09/18] drm/sun4i: mixer: Order includes alphabetically

2018-07-11 Thread Jernej Skrabec
Includes are not alphabetically ordered. Reorder them. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c index ee8febb25903..aa81b98

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

2018-07-11 Thread Marek Vasut
On 07/10/2018 11:06 AM, Stefan Agner wrote: > On 16.06.2018 01:32, Marek Vasut wrote: >> On 06/16/2018 12:42 AM, Leonard Crestez wrote: >>> On Fri, 2018-06-15 at 23:36 +0200, Marek Vasut wrote: On 06/15/2018 10:58 PM, Leonard Crestez wrote: > On Fri, 2018-06-15 at 16:47 -0300, Fabio Esteva

[PATCH] drm: gma500: Changed __attribute__((packed)) to __packed

2018-07-11 Thread Eames Trinh
Signed-off-by: Eames Trinh --- drivers/gpu/drm/gma500/intel_bios.h | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/gma500/intel_bios.h b/drivers/gpu/drm/gma500/intel_bios.h index 978ae4b25e82..e0ccf1d19a4d 100644 --- a/d

[PATCH 14/17] drm/armada: move CBSH properties into overlay plane state

2018-07-11 Thread Russell King
Move the contrast, brightness, and saturation properties to the overlay plane state structure, and call our overlay commit function to update the hardware via the planes atomic_update() method. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.h| 2 +- drivers/gpu/drm/arma

[PATCH 11/17] drm/armada: use old_state for update tracking in atomic_update()

2018-07-11 Thread Russell King
Rather than tracking the register state, we can now check the previous state and decide which registers need updating from that since the old plane state indicates the previous state which was programmed into the hardware. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c|

[PATCH 04/17] drm/armada: use core of primary update_plane for mode set

2018-07-11 Thread Russell King
Use the core of the update_plane method to configure the primary plane within mode_set() rather than duplicating this code. This moves us closer to the same code structure that the atomic modeset transitional helpers will use. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c

[PATCH v2 01/18] dt-bindings: display: sun4i-drm: Add R40 display engine compatible

2018-07-11 Thread Jernej Skrabec
R40 has pretty unique display pipeline. It supports two outputs at the same time. Possible outputs: - 1x HDMI, - 2x TV output - 1x VGA, - 1x MIPI DSI and - 2x LCD outputs That is the biggest number of possible outputs from all Allwinner SoC. Because of that, add new compatible for it. Reviewed-b

[PATCH v2 05/18] drm/sun4i: tcon: Release node when traversing of graph

2018-07-11 Thread Jernej Skrabec
Function sun4i_tcon_find_engine_traverse() doesn't release node if it needs to traverse of graph deeper than 1 level. Fix this by calling of_node_put(). Fixes: 49836b11fe71 ("drm/sun4i: tcon: Generalize engine search algorithm") Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- driv

[PATCH 1/3] drm/armada: fix compare_of() for LCD controllers

2018-07-11 Thread Russell King
The DT node passed for LCD controllers is the "port" node within the parent device. Detect this and compare the parent node. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/armada/armada_

[PATCH 10/17] drm/armada: remove temporary crtc state

2018-07-11 Thread Russell King
Now that we have the CRTC using the atomic modeset transitional helper, there is no need to build a temporary crtc state anymore - we can use the CRTC atomic state directly. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH v2 04/18] drm/sun4i: tcon-top: Cleanup clock handling

2018-07-11 Thread Jernej Skrabec
There is no need to acquire reference to clock just to get its name. This commit just cleans up the code. There is no functional change. Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_tcon_top.c | 48 ++ 1 file changed, 11 insert

[PATCH v2 13/18] drm/sun4i: tcon: Add support for R40 TCON

2018-07-11 Thread Jernej Skrabec
R40 TV TCON is basically the same as on A83T. However, it needs special handling, because it has to set up TCON TOP muxes at runtime. Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 40 ++ 1 file changed, 40 insertions

[PATCH 04/20] drm/armada: push interlace calculation into armada_drm_plane_calc()

2018-07-11 Thread Russell King
Push the interlaced frame calculation down into armada_drm_plane_calc() which needs to apply the same correction for both the overlay and primary planes. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_overlay.c | 16 +++--- drivers/gpu/drm/armada/armada_plane.c | 38

[PATCH 0/3] Finish Armada DRM DT support

2018-07-11 Thread Russell King - ARM Linux
Finish Armada DRM support for DT, finally allowing mainline kernels to use this driver unimpeded. arch/arm/boot/dts/dove-cubox.dts | 43 +++ drivers/gpu/drm/armada/Makefile | 3 +++ drivers/gpu/drm/armada/armada_drv.c | 29 ++--- drivers/gpu/

[PATCH v2 11/18] drm/sun4i: tcon-top: Add helpers for mux switching

2018-07-11 Thread Jernej Skrabec
We want to be able to set TCON TOP muxes at runtime. Add helpers for that. Old, static configuration of muxes at probe time is preserved for now. It will be removed when R40 TCON starts using them. Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_tcon_top

[PATCH v2 12/18] drm/sun4i: tcon: Add another way for matching mixers with tcon

2018-07-11 Thread Jernej Skrabec
Till now, new way of matching engines with TCONs was reading their respective ids and match them by those ids. However, with introduction of TCON TOP, that might not be so straightforward anymore. - there might be more TCONs that engines (mixers) - TCON ids might have non-consecutive ids Workaroun

[PATCH v2 15/18] ARM: dts: sun8i: r40: Add missing TCON-TOP - TCON connections

2018-07-11 Thread Jernej Skrabec
Current R40 is missing some graph connections between TCON TOP and TCONs. Add them. Fixes: 05a43a262d03 ("ARM: dts: sun8i: r40: Add HDMI pipeline") Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- .../boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 20 - arch/arm/boot/dts/sun8i

[PATCH 16/17] drm/armada: remove crtc YUV colourspace properties

2018-07-11 Thread Russell King
Remove the unused CRTC colourspace properties - userspace does not make use of these. In any case, these are not a property of the CRTC, since they demonstrably only affect the video (overlay) plane, irrespective of the format of the graphics (primary) plane. Signed-off-by: Russell King --- dri

drm/msm/mdp5: negative x/y in cursor move

2018-07-11 Thread Carsten Behling
Hi, modesetting X11 driver may provide negative x/y cordinates in mdp5_crtc_cursor_move(...) call when rotation is enabled. Because of static int mdp5_crtc_cursor_move(struct drm_crtc *crtc, int x, int y) { ... mdp5_crtc->cursor.x = x = max(x, 0); mdp5_crtc->cursor.y = y = max(y, 0); ... } x/y

[PATCH 14/20] drm/armada: switch primary plane to atomic modeset

2018-07-11 Thread Russell King
Switch the primary plane away from the transitional helpers, and use the atomic helpers instead to implement the legacy set_plane ioctl call for this plane. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 116 +- drivers/gpu/drm/armada/arma

[PATCH 01/20] drm/armada: move armada_drm_mode_config_funcs to armada_drv.c

2018-07-11 Thread Russell King
Move the armada_drm_mode_config_funcs to armada_drv.c, since this now has less to do with FBs than it does with general mode configuration. In doing so, we need to make armada_fb_create() visible to armada_drv.c, which reveals a function name clash with armada_fbdev.c. Rename the version in armada

[PATCH 12/20] drm/armada: enable atomic modeset support

2018-07-11 Thread Russell King
Enable atomic modeset helpers, and internal DRM use of atomic modeset with armada-drm. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 7 +++ drivers/gpu/drm/armada/armada_drv.c | 5 - 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH 00/17] Transition Armada DRM planes to atomic state

2018-07-11 Thread Russell King - ARM Linux
Convert Armada planes to use the transitional atomic modeset helpers. This series depends on recently previously posted Armada DRM patches, and "drm: add missing ctx argument to plane transitional helpers" in drm-misc's next branch. This is part of a larger series finishing the conversion, which i

[PATCH 13/20] drm/armada: switch legacy modeset to atomic modeset

2018-07-11 Thread Russell King
Switch the legacy set_config() method to use the atomic modeset helper, which allows us to get rid of the legacy dpms, prepare, commit, mode_set, mode_set_base and disable helper methods. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 103 +

[PATCH 06/17] drm/armada: reset all atomic state during driver initialisation

2018-07-11 Thread Russell King
Reset the atomic state of any converted components during driver initialisation to ensure that we have the atomic state initialised for any component converted to atomic modeset. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --g

[PATCH 18/20] drm/armada: remove unnecessary armada_ovl_plane structure

2018-07-11 Thread Russell King
We no longer need a private plane structure, so get rid of it. Use the drm_plane structure directly. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_overlay.c | 34 + 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/arm

[PATCH 08/17] drm/armada: convert page_flip to use primary plane atomic_update()

2018-07-11 Thread Russell King
page_flip requests happen asynchronously, so we can't wait on the vblank event before returning to userspace, as the transitional plane update helper would do. Craft our own implementation that keeps the asynchronous behaviour of this request, while making use of the atomic infrastructure for the

Re: [PATCH] kernel.h: Add for_each_if()

2018-07-11 Thread NeilBrown
On Tue, Jul 10 2018, Daniel Vetter wrote: > On Mon, Jul 09, 2018 at 04:30:01PM -0700, Andrew Morton wrote: >> On Mon, 9 Jul 2018 18:25:09 +0200 Daniel Vetter >> wrote: >> >> > To avoid compilers complainig about ambigious else blocks when putting >> > an if condition into a for_each macro one

Re: [PATCH v2 10/18] drm/sun4i: mixer: Read id from DT

2018-07-11 Thread Jernej Škrabec
Dne sreda, 11. julij 2018 ob 05:11:56 CEST je Chen-Yu Tsai napisal(a): > On Wed, Jul 11, 2018 at 4:35 AM, Jernej Skrabec wrote: > > Currently, TCON supports 2 ways to match TCON with engine (mixer in this > > case). Old way is to just traverse of graph backwards and compare node > > pointer. New

[PATCH 09/17] drm/armada: convert overlay plane to atomic state

2018-07-11 Thread Russell King
The overlay plane support updates asynchronously to the request, but the drm_plane_helper_update() transitional helper waits for a vblank event before releasing the framebuffer. Using the transitional helper would make the call block, which would introduce a performance regression. Convert the ov

[PATCH v2 10/18] drm/sun4i: mixer: Read id from DT

2018-07-11 Thread Jernej Skrabec
Currently, TCON supports 2 ways to match TCON with engine (mixer in this case). Old way is to just traverse of graph backwards and compare node pointer. New way is to match TCON and engine by their respective ids. All SoCs with DE2 enabled till now used the old way, which means mixer id was never u

[PATCH 05/20] drm/armada: move sync signal polarity to mode_set_nofb() method

2018-07-11 Thread Russell King
For atomic modeset, we need to set the sync signal polarities from the CRTC state structure rather than the legacy mode structure stored in CRTC. In any case, we should update this from our mode_set_nofb() method, rather than the commit() method. Move it there, and ensure that armada_drm_crtc_upd

[PATCH 17/20] drm/armada: update primary framebuffer parameters on mode change

2018-07-11 Thread Russell King
The framebuffer base address and toggling mode needs to be updated when the interlaced flag for mode changes is updated. Arrange to reprogram these parameters when only the mode has changed. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_plane.c | 6 -- 1 file changed, 4 inse

[PATCH 02/17] drm/armada: add rectangle helpers

2018-07-11 Thread Russell King
Add helpers to convert rectangle width/height and x/y to register values. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c| 8 +++- drivers/gpu/drm/armada/armada_hw.h | 15 +++ drivers/gpu/drm/armada/armada_overlay.c | 7 +++ 3 files changed, 21

[PATCH 06/20] drm/armada: update debug in armada_drm_crtc_mode_set_nofb()

2018-07-11 Thread Russell King
Update debug to use KMS level, and print the mode using the standard format for mode lines, but print the adjusted CRTC parameters as that's what we will be programming for. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 19 +-- 1 file changed, 9 insertion

[PATCH v2 18/18] dt-bindings: display: sun4i-drm: Fix order of DW HDMI PHY compatibles

2018-07-11 Thread Jernej Skrabec
They are currently sorted alphabetically. However, they should be sorted by release date of the family and then alphabetically. Fixes: 03c35dbf73e0 ("dt-bindings: display: sun4i-drm: Add description of A64 HDMI PHY") Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- Documentation/de

[PATCH 07/20] drm/armada: clean up SPU_ADV_REG

2018-07-11 Thread Russell King
Rather than writing all bits of SPU_ADV_REG on modeset, only write what we need to change, and initialise the register in the variant initialisation. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_510.c | 5 - drivers/gpu/drm/armada/armada_crtc.c | 11 --- drivers/gp

[PATCH 08/20] drm/armada: handle atomic modeset crtc events

2018-07-11 Thread Russell King
Prepare handling for atomic modeset CRTC events. Currently, using the transition helpers, CRTC events do not exist, but once we switch to proper atomic modeset, they have to be handled. We queue an event for the next vblank in two places: - armada_drm_crtc_atomic_flush() provided we aren't doing

[PATCH 07/17] drm/armada: convert primary plane to atomic state

2018-07-11 Thread Russell King
Convert the primary plane as a whole to use its atomic state and the transitional helpers. The CRTC is also switched to use the transitional helpers for mode_set() and mode_set_base(). Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 308 +--

[PATCH 13/17] drm/armada: move plane works to overlay

2018-07-11 Thread Russell King
Only overlay makes use of these now, so move these to the overlay code. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.h| 2 -- drivers/gpu/drm/armada/armada_overlay.c | 12 drivers/gpu/drm/armada/armada_plane.c | 6 -- 3 files changed, 8 insertions(+

[PATCH v2 06/18] dt-bindings: display: sun4i-drm: Add R40 TV TCON description

2018-07-11 Thread Jernej Skrabec
TCON description is expanded with R40 TV TCON compatible. It is a bit special, because it is connected to TCON TOP instead directly to mixer and it needs special handling. Reviewed-by: Chen-Yu Tsai Acked-by: Rob Herring Signed-off-by: Jernej Skrabec --- Documentation/devicetree/bindings/displa

Re: [PATCH] drm/tinydrm: Fix doc build warnings

2018-07-11 Thread Daniel Vetter
On Tue, Jul 10, 2018 at 06:31:15PM +0200, Noralf Trønnes wrote: > > Den 10.07.2018 18.18, skrev David Lechner: > > On 07/10/2018 10:05 AM, Noralf Trønnes wrote: > > > include/drm/tinydrm/tinydrm.h:34: warning: Function parameter or > > > member 'fb_dirty' not described in 'tinydrm_device' > > > dr

Re: [PATCH 1/3 v4] ARM: dts: Modernize the Vexpress PL111 integration

2018-07-11 Thread Sudeep Holla
On 09/07/18 08:52, Linus Walleij wrote: > The Versatile Express was submitted with the actual display > bridges unconnected (but defined in the device tree) and > mock "panels" encoded in the device tree node of the PL111 > controller. > > This doesn't even remotely describe the actual Versatile

[PATCH v2 02/18] drm/sun4i: Add R40 display engine compatible

2018-07-11 Thread Jernej Skrabec
R40 has versatile display pipeline. It supports two simultanious outputs on various outputs (TVE, VGA, HDMI, MIPI DSI, LCD). Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun4i_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sun4i/su

Re: [PATCH 1/4] drm/vkms: Add functions to map GEM backing storage

2018-07-11 Thread Haneen Mohammed
On Tue, Jul 10, 2018 at 09:12:36AM +0100, Chris Wilson wrote: > Quoting Haneen Mohammed (2018-07-09 16:44:26) > > +struct page **get_pages(struct vkms_gem_object *vkms_obj) > > +{ > > + struct drm_gem_object *gem_obj = &vkms_obj->gem; > > + struct page **pages = vkms_obj->pages; > > + >

[PATCH 16/20] drm/armada: update planes after the dumb frame is complete

2018-07-11 Thread Russell King
Write out the plane updates after the dumb frame has completed, but just before the blank period. This allows all the plane updates to be performed in a flicker-free non-tearing manner. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 46 +--

[PATCH 09/20] drm/armada: push responsibility for clock management to backend

2018-07-11 Thread Russell King
Push responsibility for managing the clock during DPMS down into the variant backend, rather than the CRTC layer having knowledge of its state. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_510.c | 19 +++ drivers/gpu/drm/armada/armada_crtc.c | 19 ++-

Re: drm/msm/mdp5: negative x/y in cursor move

2018-07-11 Thread Carsten Behling
I found the solution: ROI has to be recalculated for negative x/y indicating using the lower/right corner of the cursor buffer. Further, MDP5_LM_CURSOR_XY_SRC_Y and MDP5_LM_CURSOR_XY_SRC_X mus be calculated for the hotspot: Index: kernel-source/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c ===

[PATCH 19/20] drm/armada: remove unnecessary armada_plane structure

2018-07-11 Thread Russell King
We no longer require a private armada_plane structure, so eliminate it, and use the drm_plane structure directly. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 6 +++--- drivers/gpu/drm/armada/armada_crtc.h | 7 --- drivers/gpu/drm/armada/armada_plane.c | 17 +++-

[PATCH v2 03/18] ARM: dts: sun8i: r40: Remove fallback display engine compatible

2018-07-11 Thread Jernej Skrabec
R40 has pretty unique display pipeline. Because of that, H3 display engine compatible fallback should be removed. Fixes: 05a43a262d03 ("ARM: dts: sun8i: r40: Add HDMI pipeline") Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- arch/arm/boot/dts/sun8i-r40.dtsi | 3 +-- 1 file changed

[PATCH 15/17] drm/armada: move colorkey properties into overlay plane state

2018-07-11 Thread Russell King
Move the overlay plane colorkey properties into the plane state, keeping the existing driver behaviour to avoid breaking userspace. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_overlay.c | 251 +--- 1 file changed, 132 insertions(+), 119 deletions(-)

Re: [linux-sunxi] Re: [PATCH 16/17] drm/sun4i: tcon-top: Remove mux configuration at probe time

2018-07-11 Thread Jernej Škrabec
Dne torek, 10. julij 2018 ob 18:18:43 CEST je Jernej Škrabec napisal(a): > Dne torek, 10. julij 2018 ob 18:09:26 CEST je Chen-Yu Tsai napisal(a): > > On Sat, Jul 7, 2018 at 1:51 AM, Jernej Skrabec > > wrote: > > > Now that R40 TCON migrated to runtime mux configuration, old code can be > > > remo

[PATCH 05/17] drm/armada: merge armada_drm_gra_plane_regs() into only caller

2018-07-11 Thread Russell King
armada_drm_gra_plane_regs() is now only ever called from within armada_drm_primary_update_state(), so merge it into this function. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 55 1 file changed, 24 insertions(+), 31 deletions(-) di

Re: [PATCH 4/4] drm/vkms: subclass CRTC state

2018-07-11 Thread Haneen Mohammed
On Tue, Jul 10, 2018 at 10:10:46AM +0200, Daniel Vetter wrote: > On Mon, Jul 09, 2018 at 06:48:36PM +0300, Haneen Mohammed wrote: > > Subclass CRTC state struct to enable storing driver's private > > state. This patch only adds the base drm_crtc_state struct and > > the atomic functions that handle

[PATCH 12/17] drm/armada: move primary plane to separate file

2018-07-11 Thread Russell King
Split out the primary plane support; this is now entirely separate from the CRTC support. Signed-off-by: Russell King --- drivers/gpu/drm/armada/Makefile | 2 +- drivers/gpu/drm/armada/armada_crtc.c| 273 + drivers/gpu/drm/armada/armada_crtc.h| 10 -

[PATCH v2 16/18] ARM: dts: sun8i: r40: Disable TCONs by default.

2018-07-11 Thread Jernej Skrabec
R40 has 4 TCONs, but only 2 of them can receive some kind of output at the same time. Let's disable them by default, so only those which are really connected on board can be enabled in board dts file. Reviewed-by: Chen-Yu Tsai Signed-off-by: Jernej Skrabec --- arch/arm/boot/dts/sun8i-r40-banana

[PATCH 01/17] drm/armada: clean up armada_drm_crtc_page_flip()

2018-07-11 Thread Russell King
drm_mode_page_flip_ioctl() already takes care of checking the framebuffer format, and also assigns primary->fb after a successful call to this handler. These are both redundant, and can be removed. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 12 1 file ch

[PATCH 2/3] drm/armada: add OF reserved memory support

2018-07-11 Thread Russell King
Existing Armada DRM makes use of reserved memory for allocating contiguous screen buffers, which currently prevents its use with DT systems. Add support for this for DT systems. Signed-off-by: Russell King --- drivers/gpu/drm/armada/Makefile | 3 +++ drivers/gpu/drm/armada/armada_drv.c |

Re: [PATCH V3] drm/vkms: Add vblank events simulated by hrtimers

2018-07-11 Thread Daniel Vetter
On Tue, Jul 10, 2018 at 10:48:57PM -0300, Rodrigo Siqueira wrote: > This commit adds regular vblank events simulated through hrtimers, which > is a feature required by VKMS to mimic real hardware. Additionally, all > the vblank event send after pageflip is kept in the atomic_flush > function. > >

[PATCH 00/20] Finish Armada DRM transition to atomic modeset

2018-07-11 Thread Russell King - ARM Linux
This series finishes the transition of Armada DRM to atomic modeset. drivers/gpu/drm/armada/armada_510.c | 24 +- drivers/gpu/drm/armada/armada_crtc.c| 506 ++-- drivers/gpu/drm/armada/armada_crtc.h| 30 +- drivers/gpu/drm/armada/armada_drm.h | 12 +-

[PATCH v2 17/18] drm/sun4i: tcon-top: Remove mux configuration at probe time

2018-07-11 Thread Jernej Skrabec
Now that R40 TCON migrated to runtime mux configuration, old code can be removed. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_tcon_top.c | 76 +- 1 file changed, 1 insertion(+), 75 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c b/driv

Re: [PATCH v4 0/9] xen: dma-buf support for grant device

2018-07-11 Thread Boris Ostrovsky
On 07/02/2018 09:12 AM, Oleksandr Andrushchenko wrote: > On 07/02/2018 11:20 AM, Juergen Gross wrote: >> On 02/07/18 09:10, Oleksandr Andrushchenko wrote: >>> Hello, Boris, Juergen! >>> >>> Do you think I can re-base the series (which already has >>> all required R-b's from Xen community) onto the

[PATCH v2 07/18] drm/sun4i: DW HDMI: Release nodes if error happens during CRTC search

2018-07-11 Thread Jernej Skrabec
If error happens in sun8i_dw_hdmi_find_possible_crtcs(), nodes are not released with of_node_put() before returning. Fix that by calling of_node_put() when necessary. While on it, clean up the code by using of_graph_get_remote_node() which also lowers number of cases where error handling has to be

[PATCH 11/20] drm/armada: implement atomic_enable()/atomic_disable() methods

2018-07-11 Thread Russell King
Implement the atomic_enable()/atomic_disable() methods used by the atomic modeset helpers. atomic_disable() will need some transitional code during conversion to ensure proper ordering is maintained. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 71 +

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread Takashi Iwai
On Tue, 10 Jul 2018 13:21:00 +0200, Takashi Iwai wrote: > > > revert the fix of amdgpu suspend issue, audio issue also can be observed. > > Did you check the behavior with the single AMD GPU hardware? > If confirmed, we can forget about vga_switcheroo. ... and taking a look back at the recent ch

[Bug 107183] Enabling Glamor takes half a second

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107183 Michel Dänzer changed: What|Removed |Added Attachment #140548|text/x-log |text/plain mime type|

Re: [PATCH V2 1/5] drm/vkms: Add dumb operations

2018-07-11 Thread Daniel Vetter
On Thu, Jul 05, 2018 at 11:21:19PM +0300, Haneen Mohammed wrote: > On Thu, Jun 21, 2018 at 09:16:13AM -0300, Rodrigo Siqueira wrote: > > VKMS currently does not handle dumb data, and as a consequence, it does > > not provide mechanisms for handling gem. This commit adds the necessary > > support fo

[Bug 107183] Enabling Glamor takes half a second

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107183 --- Comment #1 from Michel Dänzer --- FWIW, this only takes a few milliseconds on my systems. You'd have to profile where the time is spent on your system, but it's more likely somewhere between glamor and Mesa / LLVM than in the kernel. -- Yo

Re: [PATCH V2 3/5] drm/vkms: Add atomic helpers functions

2018-07-11 Thread Daniel Vetter
On Thu, Jun 21, 2018 at 09:16:41AM -0300, Rodrigo Siqueira wrote: > This patch adds the struct drm_crtc_helper_funcs with simple > atomic_check and atomic_enable functions. > > Signed-off-by: Rodrigo Siqueira > --- > drivers/gpu/drm/vkms/vkms_crtc.c | 18 ++ > 1 file changed, 18

Re: [PATCH V2 4/5] drm/vkms: Add connectors helpers

2018-07-11 Thread Daniel Vetter
On Thu, Jun 21, 2018 at 09:17:09AM -0300, Rodrigo Siqueira wrote: > This patch adds the struct drm_connector_helper_funcs with some > necessary hooks. Additionally, it also adds some missing hooks at > drm_connector_funcs. > > Signed-off-by: Rodrigo Siqueira > --- > drivers/gpu/drm/vkms/vkms_drv

Re: [PATCH V2 5/5] drm/vkms: Add plane helper struct

2018-07-11 Thread Daniel Vetter
On Thu, Jun 21, 2018 at 09:17:25AM -0300, Rodrigo Siqueira wrote: > This patch adds the struct drm_plane_helper_funcs and the required atomic > hooks. > > Signed-off-by: Rodrigo Siqueira > --- > drivers/gpu/drm/vkms/vkms_plane.c | 18 ++ > 1 file changed, 18 insertions(+) > > di

Re: [PATCH 1/3] vulkan: Define new VK_MESA_query_timestamp extension [v2]

2018-07-11 Thread Pekka Paalanen
On Tue, 10 Jul 2018 11:02:23 -0700 "Keith Packard" wrote: > Pekka Paalanen writes: > > > On Sat, 23 Jun 2018 12:13:53 -0500 > > Jason Ekstrand wrote: > > > >> I haven't thought through this comment all that hard but would it make > >> sense to have three timestamps, CPU, GPU, CPU so that yo

Re: [PATCH] drm: gma500: Changed __attribute__((packed)) to __packed

2018-07-11 Thread Daniel Vetter
On Tue, Jul 10, 2018 at 03:00:21PM +0200, Eames Trinh wrote: > Signed-off-by: Eames Trinh Applied, thanks. -Daniel > --- > drivers/gpu/drm/gma500/intel_bios.h | 38 > ++--- > 1 file changed, 19 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/gma

[PATCH] drm/nouveau/hwmon: potential uninitialized variables

2018-07-11 Thread Dan Carpenter
Smatch complains that "value" can be uninitialized when kstrtol() returns -ERANGE. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c index 44178b4c3599..08a1ab6b150d 100644 --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c ++

Re: [PATCH] [v2] drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m

2018-07-11 Thread Maxime Ripard
On Mon, Jul 09, 2018 at 06:05:55PM +0200, Arnd Bergmann wrote: > Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module results in > a link error, as we try to access a symbol from the sun8i_tcon_top.ko module: > > ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun8i-drm-hdmi.

[Bug 107139] [CI] KBL-G Hades Canyon doesn't survive igt@gem_exec_suspend@basic-s4-devices

2018-07-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107139 Tomi Sarvela changed: What|Removed |Added Assignee|intel-gfx-bugs@lists.freede |dri-devel@lists.freedesktop

Re: [PATCH v2 00/18] Allwinner R40 HDMI refactoring

2018-07-11 Thread Maxime Ripard
On Tue, Jul 10, 2018 at 10:34:53PM +0200, Jernej Skrabec wrote: > This series fixes several issues found in R40 HDMI patch series after > it was applied. Conversation can be found here: > http://lists.infradead.org/pipermail/linux-arm-kernel/2018-June/586011.html > > Patches are based on latest li

Re: [PATCH v2 00/18] Allwinner R40 HDMI refactoring

2018-07-11 Thread Chen-Yu Tsai
On Wed, Jul 11, 2018 at 4:30 PM, Maxime Ripard wrote: > On Tue, Jul 10, 2018 at 10:34:53PM +0200, Jernej Skrabec wrote: >> This series fixes several issues found in R40 HDMI patch series after >> it was applied. Conversation can be found here: >> http://lists.infradead.org/pipermail/linux-arm-kern

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread jimqu
On 2018年07月11日 15:19, Takashi Iwai wrote: On Tue, 10 Jul 2018 13:21:00 +0200, Takashi Iwai wrote: revert the fix of amdgpu suspend issue, audio issue also can be observed. Did you check the behavior with the single AMD GPU hardware? If confirmed, we can forget about vga_switcheroo. ... and t

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-11 Thread Michal Hocko
On Tue 10-07-18 19:20:20, Leon Romanovsky wrote: > On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wrote: > > On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > > > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > > > > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > > > > T

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread Takashi Iwai
On Wed, 11 Jul 2018 10:41:38 +0200, jimqu wrote: > > > > On 2018年07月11日 15:19, Takashi Iwai wrote: > > On Tue, 10 Jul 2018 13:21:00 +0200, > > Takashi Iwai wrote: > >>> revert the fix of amdgpu suspend issue, audio issue also can be observed. > >> Did you check the behavior with the single AMD G

Re: [PATCH 1/3 v4] ARM: dts: Modernize the Vexpress PL111 integration

2018-07-11 Thread Liviu Dudau
On Tue, Jul 10, 2018 at 10:46:03AM +0100, Sudeep Holla wrote: > > > On 09/07/18 08:52, Linus Walleij wrote: > > The Versatile Express was submitted with the actual display > > bridges unconnected (but defined in the device tree) and > > mock "panels" encoded in the device tree node of the PL111 >

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread jimqu
On 2018年07月11日 17:04, Takashi Iwai wrote: On Wed, 11 Jul 2018 10:41:38 +0200, jimqu wrote: On 2018年07月11日 15:19, Takashi Iwai wrote: On Tue, 10 Jul 2018 13:21:00 +0200, Takashi Iwai wrote: revert the fix of amdgpu suspend issue, audio issue also can be observed. Did you check the behavior

Re: [PATCH v2 2/4] drm/arm/malidp: Implemented the size validation for AFBC framebuffers

2018-07-11 Thread Liviu Dudau
On Tue, Jul 10, 2018 at 02:18:55PM +0100, Ayan Kumar Halder wrote: > AFBC buffers include additional metadata which increases the required > allocation size. Implement the appropriate size validation and sanity > checking for AFBC buffers. > Added malidp specific function for framebuffer creation.

Re: [PATCH v2 00/18] Allwinner R40 HDMI refactoring

2018-07-11 Thread Maxime Ripard
On Wed, Jul 11, 2018 at 10:41:54AM +0200, Jernej Škrabec wrote: > Dne sreda, 11. julij 2018 ob 10:30:36 CEST je Maxime Ripard napisal(a): > > On Tue, Jul 10, 2018 at 10:34:53PM +0200, Jernej Skrabec wrote: > > > This series fixes several issues found in R40 HDMI patch series after > > > it was appl

Re: [PATCH v2 3/4] drm/arm/malidp: Set the AFBC register bits if the framebuffer has AFBC modifier

2018-07-11 Thread Liviu Dudau
On Tue, Jul 10, 2018 at 02:18:56PM +0100, Ayan Kumar Halder wrote: > Added the AFBC decoder registers for DP500 , DP550 and DP650. > These registers control the processing of AFBC buffers. It controls various > features like AFBC decoder enable, lossless transformation and block split > as well as

  1   2   3   >