[PATCH 1/2] drm/amd: Replace ttm_bo_reference with ttm_bo_get

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1

[PATCH 2/2] Replace ttm_bo_unref with ttm_bo_put

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL.

[PATCH] drm/bochs: Replace ttm_bo_unref with ttm_bo_put

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL.

Re: [PATCH 1/2] drm/amd: Replace ttm_bo_reference with ttm_bo_get

2018-07-31 Thread Christian König
Am 31.07.2018 um 08:11 schrieb Thomas Zimmermann: The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann amdgpu patches should

Re: [PATCH] drm/amdgpu/pm: Fix potential Spectre v1

2018-07-31 Thread Christian König
Am 30.07.2018 um 22:14 schrieb Alex Deucher: On Mon, Jul 30, 2018 at 5:55 AM, Michel Dänzer wrote: On 2018-07-24 10:53 PM, Alex Deucher wrote: On Mon, Jul 23, 2018 at 12:32 PM, Gustavo A. R. Silva wrote: idx can be indirectly controlled by user-space, hence leading to a potential

[PATCH 1/2] drm/nouveau: Replace ttm_bo_reference with ttm_bo_get

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/nouveau_bo.h | 7 ++- 1 file changed, 6

[PATCH 2/2] drm/nouveau: Replace ttm_bo_unref with ttm_bo_put

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL.

RE: [PATCH v6 01/35] drm: hdcp2.2 authentication msg definitions

2018-07-31 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Ramalingam C >Sent: Saturday, July 14, 2018 8:45 AM >To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; >dan...@ffwll.ch; seanp...@chromium.org; Winkler, Tomas >;

[PATCH 2/2] drm/virtio: Replace ttm_bo_unref with ttm_bo_put

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL.

[PATCH 0/2] Clean-up TTM BOref-counting interface

2018-07-31 Thread Thomas Zimmermann
This patchset replaces ttm_bo_{reference/unref} with ttm_bo_{get,put}, which follow Linux' conventions for ref-counting functions. Thomas Zimmermann (2): drm/virtio: Replace ttm_bo_reference with ttm_bo_get drm/virtio: Replace ttm_bo_unref with ttm_bo_put

[PATCH 1/2] drm/virtio: Replace ttm_bo_reference with ttm_bo_get

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 2 +- 1 file changed, 1

[PATCH] staging/vboxvideo: Replace ttm_bo_unref with ttm_bo_put

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL.

[PATCH] drm/qxl: Replace ttm_bo_unref with ttm_bo_put

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL.

Re: [PATCH 2/2] drm/scheduler: stop setting rq to NULL

2018-07-31 Thread Christian König
Am 30.07.2018 um 22:51 schrieb Andrey Grodzovsky: On 07/30/2018 09:30 AM, Nayan Deshmukh wrote: On Mon, Jul 30, 2018 at 4:33 PM Christian König > wrote: We removed the redundancy of having an extra scheduler field, so we can't set the rq

[PATCH 2/2] drm/radeon: Replace ttm_bo_unref with ttm_bo_put

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL.

[PATCH 1/2] drm/radeon: Replace ttm_bo_reference with ttm_bo_get

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/radeon_object.c | 2 +- 1 file changed, 1

[PATCH 0/2] Clean-up TTM BO ref-counting interface

2018-07-31 Thread Thomas Zimmermann
This patchset replaces ttm_bo_{reference/unref} with ttm_bo_{get,put}, which follow Linux' conventions for ref-counting functions. Thomas Zimmermann (2): Replace ttm_bo_reference with ttm_bo_get drm/vmwgfx: Replace ttm_bo_unref with ttm_bo_put drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 11

[PATCH 2/2] drm/vmwgfx: Replace ttm_bo_unref with ttm_bo_put

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL.

[PATCH 1/2] Replace ttm_bo_reference with ttm_bo_get

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 5 +++--

[PATCH] drm/mgag200: Replace ttm_bo_unref with ttm_bo_put

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL.

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-07-31 Thread Philipp Zabel
On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: > Adding lcdif nodes to a power domain currently does work, it results in > black/corrupted screens or hangs. While the driver does enable runtime > pm it does not deal correctly with the block being unpowered. > > Ensure power is on when

Re: [PATCH] drm/bridge/ti-sn65dsi86: Fix implicit declaration to drm_mode_connector_attach_encoder

2018-07-31 Thread Sean Paul
On Tue, Jul 31, 2018 at 09:51:16AM +0530, spa...@codeaurora.org wrote: > On 2018-07-30 23:12, Sean Paul wrote: > > This function name was changed to drm_connector_attach_encoder(). > > Unfortunately this driver was posted on the list before that change, and > > applied after > > > > Fixes:

[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

2018-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106175 --- Comment #23 from tempel.jul...@gmail.com --- If I bought Vega, Raven Ridge or, in the future, Navi, I'd be really annoyed by this bug because I had to turn off page flipping, resulting in unacceptable tearing. :( Could we please get an

Re: [PATCH 2/2] drm/scheduler: stop setting rq to NULL

2018-07-31 Thread Andrey Grodzovsky
Change is Reviewed-by: Andrey Grodzovsky Andrey On 07/31/2018 02:50 AM, Christian König wrote: Am 30.07.2018 um 22:51 schrieb Andrey Grodzovsky: On 07/30/2018 09:30 AM, Nayan Deshmukh wrote: On Mon, Jul 30, 2018 at 4:33 PM Christian König >

Re: [PATCH 3/4] drm/scheduler: add new function to get least loaded sched

2018-07-31 Thread Nayan Deshmukh
I will take care of that in v2. On Tue, Jul 31, 2018 at 4:57 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 31.07.2018 um 12:37 schrieb Nayan Deshmukh: > > The function selects the run queue from the rq_list with the > > least load. The load is decided by the number of jobs

Re: [PATCH 4/4] drm/scheduler: move idle entities to scheduler with less load

2018-07-31 Thread Christian König
Am 31.07.2018 um 12:37 schrieb Nayan Deshmukh: This is the first attempt to move entities between schedulers to have dynamic load balancing. We just move entities with no jobs for now as moving the ones with jobs will lead to other compilcations like ensuring that the other scheduler does not

Re: [PATCH 1/1] drm/dp: Add debufs support for DP dpcd log

2018-07-31 Thread Sean Paul
On Tue, Jul 31, 2018 at 05:39:26AM -0700, Tejas Upadhyay wrote: > Patch adds support for debugging DisplayPort : > > * All dpcd read/write transactions are logged > * Logging done per AUX interface > * Use following command to to list AUX transactions: Hi Tejas, Thanks for your patch. We already

Re: [PATCH] drm: Convert drm_atomic_helper_suspend/resume()

2018-07-31 Thread Liviu Dudau
Hi Souptick, On Tue, Jul 31, 2018 at 12:31:37AM +0530, Souptick Joarder wrote: > convert drm_atomic_helper_suspend/resume() to use > drm_mode_config_helper_suspend/resume(). > > With this conversion, drm_fbdev_cma_set_suspend_unlocked() > will left with no consumer. So this function can be

Re: [PATCH 2/2] drm/nouveau: Prevent redundant connector probes from ACPI

2018-07-31 Thread kbuild test robot
/commits/Lyude-Paul/drm-nouveau-Print-debug-message-on-ACPI-probe-event/20180731-150343 config: arm-multi_v7_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O

[PATCH 1/4] drm/scheduler: add a list of run queues to the entity

2018-07-31 Thread Nayan Deshmukh
These are the potential run queues on which the jobs from this entity can be scheduled. We will use this to do load balancing. Signed-off-by: Nayan Deshmukh --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 8 include/drm/gpu_scheduler.h | 7 ++- 2 files changed, 14

[PATCH 3/4] drm/scheduler: add new function to get least loaded sched

2018-07-31 Thread Nayan Deshmukh
The function selects the run queue from the rq_list with the least load. The load is decided by the number of jobs in a scheduler. Signed-off-by: Nayan Deshmukh --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 26 ++ 1 file changed, 26 insertions(+) diff --git

[PATCH 4/4] drm/scheduler: move idle entities to scheduler with less load

2018-07-31 Thread Nayan Deshmukh
This is the first attempt to move entities between schedulers to have dynamic load balancing. We just move entities with no jobs for now as moving the ones with jobs will lead to other compilcations like ensuring that the other scheduler does not remove a job from the current entity while we are

[PATCH 0/4] drm/scheduler: add dynamic balancing

2018-07-31 Thread Nayan Deshmukh
This is the my first attempt to include dynamic balancing as part of the scheduler. I have tried to handle the easy cases first to get the basic implementation running. Please share your thoughts!! *** BLURB HERE *** Nayan Deshmukh (4): drm/scheduler: add a list of run queues to the entity

[PATCH 2/4] drm/scheduler: add counter for total jobs in scheduler

2018-07-31 Thread Nayan Deshmukh
Signed-off-by: Nayan Deshmukh --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 3 +++ include/drm/gpu_scheduler.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index

[PATCH] drm/amd/display: add missing void parameter to dc_create_transfer_func

2018-07-31 Thread Colin King
From: Colin Ian King Add a missing void parameter to function dc_create_transfer_func, fixes sparse warning: warning: non-ANSI function declaration of function 'dc_create_transfer_func' Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/core/dc_surface.c | 2 +- 1 file changed,

Re: [PATCH v3 2/2] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set

2018-07-31 Thread Bartlomiej Zolnierkiewicz
On Thursday, July 19, 2018 12:16:01 PM Thomas Zimmermann wrote: > If the console is unlocked during registration, the console subsystem > generates significant amounts of warnings, which obfuscate actual > debugging messages. Setting ignore_console_lock_warning while debugging > console

Re: [PATCH v3 1/2] console: Replace #if 0 with atomic var 'ignore_console_lock_warning'

2018-07-31 Thread Bartlomiej Zolnierkiewicz
On Thursday, July 19, 2018 12:16:00 PM Thomas Zimmermann wrote: > The macro WARN_CONSOLE_UNLOCKED prints a warning when a thread enters > the console's critical section without having acquired the console > lock. The console lock can be ignored when debugging the console using > printk, but this

Re: [PATCH] fb: amifb: fix build warnings when not builtin

2018-07-31 Thread Bartlomiej Zolnierkiewicz
On Friday, July 27, 2018 09:16:42 AM Geert Uytterhoeven wrote: > Hi Randy, > > On Fri, Jul 27, 2018 at 2:00 AM Randy Dunlap wrote: > > From: Randy Dunlap > > > > Fix build warning when built as a loadable module. > > amifb_setup() and amifb_setup_mcap() are only needed when the driver > > is

Re: [PATCH] media: omap2: omapfb: fix boolreturn.cocci warnings

2018-07-31 Thread Bartlomiej Zolnierkiewicz
On Thursday, July 26, 2018 01:57:00 AM kbuild test robot wrote: > From: kbuild test robot > > drivers/video/fbdev/omap2/omapfb/omapfb-main.c:290:9-10: WARNING: return of > 0/1 in function 'cmp_var_to_colormode' with return type bool > > Return statements in functions returning bool should use

Re: [PATCH] media: omap2: omapfb: fix bugon.cocci warnings

2018-07-31 Thread Bartlomiej Zolnierkiewicz
On Thursday, July 26, 2018 01:57:00 AM kbuild test robot wrote: > From: kbuild test robot > > drivers/video/fbdev/omap2/omapfb/dss/dss_features.c:895:2-5: WARNING: Use > BUG_ON instead of if condition followed by BUG. > Please make sure the condition has no side effects (see conditional BUG_ON

Re: [PATCH] media: omap2: omapfb: fix ifnullfree.cocci warnings

2018-07-31 Thread Bartlomiej Zolnierkiewicz
On Thursday, July 26, 2018 01:57:00 AM kbuild test robot wrote: > From: kbuild test robot > > drivers/video/fbdev/omap2/omapfb/dss/core.c:141:2-26: WARNING: NULL check > before some freeing functions is not needed. > > NULL check before some freeing functions is not needed. > > Based on

[Bug 107367] [regression, bisected] Games freeze the PC with newest AMD Staging DRM Next Kernel

2018-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107367 Christian König changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[PATCH 3/3] drm/ttm: clean up non-x86 definitions on ttm_tt

2018-07-31 Thread Huang Rui
All non-x86 definitions are moved to ttm_set_memory header, so remove it from ttm_tt.c. Signed-off-by: Huang Rui --- drivers/gpu/drm/ttm/ttm_tt.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c

[PATCH 2/3] drm/ttm: Add ttm_set_pages_wc and ttm_set_pages_uc helper

2018-07-31 Thread Huang Rui
These two helpers will be used on set page caching. Signed-off-by: Huang Rui --- include/drm/ttm/ttm_set_memory.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/include/drm/ttm/ttm_set_memory.h b/include/drm/ttm/ttm_set_memory.h index a70723c..7c492b4 100644 ---

[PATCH 1/3] drm/ttm: fix missed conversion of set_pages_array_uc

2018-07-31 Thread Huang Rui
This patch fixed the error when do not configure CONFIG_X86, otherwise, below error will be encountered. All errors (new ones prefixed by >>): drivers/gpu/drm/ttm/ttm_page_alloc_dma.c: In function 'ttm_set_pages_caching': >> drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:272:7: error: implicit

Re: [PATCH 4/4] drm/scheduler: move idle entities to scheduler with less load

2018-07-31 Thread Nayan Deshmukh
On Tue, Jul 31, 2018 at 5:02 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 31.07.2018 um 12:37 schrieb Nayan Deshmukh: > > This is the first attempt to move entities between schedulers to > > have dynamic load balancing. We just move entities with no jobs for > > now as

Re: [PATCH] drm/amd/display: add missing void parameter to dc_create_transfer_func

2018-07-31 Thread Harry Wentland
On 2018-07-31 06:42 AM, Colin King wrote: > From: Colin Ian King > > Add a missing void parameter to function dc_create_transfer_func, fixes > sparse warning: > > warning: non-ANSI function declaration of function 'dc_create_transfer_func' > > Signed-off-by: Colin Ian King Reviewed-by: Harry

[Bug 200695] Blank screen on RX 580 with amdgpu.dc=1 enabled (no displays detected)

2018-07-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200695 --- Comment #2 from Claude Heiland-Allen (cla...@mathr.co.uk) --- Created attachment 277637 --> https://bugzilla.kernel.org/attachment.cgi?id=277637=edit dmesg after boot with amdgpu.dc=0 drm.debug=6 -- You are receiving this mail because:

[Bug 200695] Blank screen on RX 580 with amdgpu.dc=1 enabled (no displays detected)

2018-07-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200695 --- Comment #1 from Claude Heiland-Allen (cla...@mathr.co.uk) --- Created attachment 277635 --> https://bugzilla.kernel.org/attachment.cgi?id=277635=edit dmesg after replugging monitor with amdgpu.dc=1 amdgpu.dc_log=1 drm.debug=6 -- You are

Re: SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implementation)

2018-07-31 Thread Linus Torvalds
On Tue, Jul 31, 2018 at 10:49 AM Linus Torvalds wrote: > > So the re-use might initialize the fields lazily, not necessarily using a > ctor. In particular, the pattern that nf_conntrack uses looks like it is safe. If you have a well-defined refcount, and use "atomic_inc_not_zero()" to guard

[Bug 107390] [BISECTED] EDID read failure breaks display mirroring

2018-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107390 --- Comment #9 from Harry Wentland --- That commit is correct. I don't think we should revert it. That said I don't quite understand why it leads to issues. Are you able to take another set of kernel logs from amd-staging-drm-next, both with

Re: [PATCH 1/2] drm/vkms: Subclass plane state

2018-07-31 Thread Sean Paul
On Sat, Jul 28, 2018 at 12:11:08PM +0300, Haneen Mohammed wrote: > Subclass plane state struct to enable storing driver's private > state. This patch only adds the base drm_plane_state struct and > the atomic functions that handle it. > > Signed-off-by: Haneen Mohammed Reviewed-by: Sean Paul

Re: [PATCH 2/2] drm/vkms: Implement CRC debugfs API

2018-07-31 Thread Sean Paul
On Sat, Jul 28, 2018 at 12:11:53PM +0300, Haneen Mohammed wrote: > This patch implement the necessary functions to compute and add CRCs > entries: > > - Implement the set_crc_source() callback. > - Compute CRC using crc32 on the visible part of the framebuffer. > - Use ordered workqueue per

[Bug 200695] Blank screen on RX 580 with amdgpu.dc=1 enabled (no displays detected)

2018-07-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200695 --- Comment #3 from Claude Heiland-Allen (cla...@mathr.co.uk) --- Created attachment 277639 --> https://bugzilla.kernel.org/attachment.cgi?id=277639=edit Xorg.0.log with amdgpu=1 -- You are receiving this mail because: You are watching the

[Bug 107367] [regression, bisected] Games freeze the PC with newest AMD Staging DRM Next Kernel

2018-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107367 --- Comment #11 from Gregor Münch --- Will do if I find a way to reproduce it. Seems like some other reports are about exact the same error message and random freezes. -- You are receiving this mail because: You are the assignee for the

[PATCH v3] drm/nouveau: Fix potential memory access error in debugfs_pstate_get/set()

2018-07-31 Thread Lyude Paul
nouveau_debugfs(drm) will never be NULL, because we're taking the value of the potentially null device pointer and adding to it so it isn't 0x0. So, check if drm is NULL instead. Signed-off-by: Lyude Paul Cc: Karol Herbst --- Changes since v2: - Also fix nouveau_debugfs_pstate_set()

[GIT PULL] hdlcd fixes for drm-next

2018-07-31 Thread Liviu Dudau
Hi Dave, I managed to loose track of a few patches for HDLCD while focusing on Mali DP and found them again when investigating an issue with the way HDLCD behaves on teardown. They can go into drm-next for one of the v4.19-rcX if you're not going to do another pull request before the merge

[bug report] drm/amd/display: Read AUX channel even if only status byte is returned

2018-07-31 Thread Dan Carpenter
[ Potential security issue, if I'm reading the code correctly. I don't really know the code and I haven't looked at the larger context. -dan ] Hello Leo (Sunpeng) Li, The patch edf6ffe4f47e: "drm/amd/display: Read AUX channel even if only status byte is returned" from Jun 26, 2018, leads to

RE: [PATCH v6 09/35] drm/i915: Initialize HDCP2.2 and its MEI interface

2018-07-31 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Saturday, July 14, 2018 8:45 AM >To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; >dan...@ffwll.ch; seanp...@chromium.org; Winkler, Tomas >; Usyskin, Alexander ; >Shankar, Uma >Cc: Sharma, Shashank ; C, Ramalingam >

Re: [RFC 1/3] drm: Add colorspace property

2018-07-31 Thread Adam Jackson
On Tue, 2018-07-24 at 21:15 +0530, Uma Shankar wrote: > --- a/include/uapi/drm/drm_mode.h > +++ b/include/uapi/drm/drm_mode.h > @@ -209,6 +209,17 @@ > #define DRM_MODE_CONTENT_PROTECTION_DESIRED 1 > #define DRM_MODE_CONTENT_PROTECTION_ENABLED 2 > > +enum extended_colorimetry { > +

[Bug 198745] Blank screen on RX 580 with AMDGPU Display Core enabled

2018-07-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198745 Claude Heiland-Allen (cla...@mathr.co.uk) changed: What|Removed |Added CC|

[Bug 200695] Blank screen on RX 580 with amdgpu.dc=1 enabled (no displays detected)

2018-07-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200695 --- Comment #5 from Claude Heiland-Allen (cla...@mathr.co.uk) --- Created attachment 277643 --> https://bugzilla.kernel.org/attachment.cgi?id=277643=edit xorg.conf -- You are receiving this mail because: You are watching the assignee of the

[Bug 200695] Blank screen on RX 580 with amdgpu.dc=1 enabled (no displays detected)

2018-07-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200695 --- Comment #4 from Claude Heiland-Allen (cla...@mathr.co.uk) --- Created attachment 277641 --> https://bugzilla.kernel.org/attachment.cgi?id=277641=edit Xorg.0.log with amdgpu.dc=0 -- You are receiving this mail because: You are watching the

Re: [bug report] drm/amd/display: Read AUX channel even if only status byte is returned

2018-07-31 Thread Leo Li
On 2018-07-31 02:24 PM, Dan Carpenter wrote: [ Potential security issue, if I'm reading the code correctly. I don't really know the code and I haven't looked at the larger context. -dan ] Hello Leo (Sunpeng) Li, The patch edf6ffe4f47e: "drm/amd/display: Read AUX channel even if only

[Bug 198745] Blank screen on RX 580 with AMDGPU Display Core enabled

2018-07-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198745 Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) changed: What|Removed |Added CC|

[Bug 200695] New: Blank screen on RX 580 with amdgpu.dc=1 enabled (no displays detected)

2018-07-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200695 Bug ID: 200695 Summary: Blank screen on RX 580 with amdgpu.dc=1 enabled (no displays detected) Product: Drivers Version: 2.5 Kernel Version: 4.18.0-rc7 Hardware: All

Sleeping from invalid context in udlfb

2018-07-31 Thread Mikulas Patocka
BTW when using the udlfb driver as a console, I've got this warning. vt_console_print takes a spinlock and then calls the framebuffer driver that sleeps. The question is - whose fault is this? Could the console code somehow be told to print characters without holding a spinlock? Or does it

Re: [PATCH 1/2] drm/scheduler: Add job dependency trace.

2018-07-31 Thread Christian König
Am 31.07.2018 um 16:56 schrieb Andrey Grodzovsky: During debug sessions I encountered a need to trace back a job dependecy a few steps back to the first failing job. This trace helpped me a lot. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König for the series. ---

[Bug 107277] Raven: pci_pm_suspend takes over 1 second

2018-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107277 --- Comment #14 from Paul Menzel --- For the record, bug #100941 [1] is the same for radeon (like Fusion devices). [1]: https://bugs.freedesktop.org/show_bug.cgi?id=100941 -- You are receiving this mail because: You are the assignee for the

Re: [PATCH 3/4] drm/scheduler: add new function to get least loaded sched

2018-07-31 Thread Christian König
Am 31.07.2018 um 12:37 schrieb Nayan Deshmukh: The function selects the run queue from the rq_list with the least load. The load is decided by the number of jobs in a scheduler. Signed-off-by: Nayan Deshmukh --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 26 ++ 1

[PATCH 2/2] drm/amdgpu: Add job pipe sync dependecy trace

2018-07-31 Thread Andrey Grodzovsky
It's useful to trace any dependency a job has on prevoius jobs. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c| 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 24 2 files changed, 29 insertions(+) diff --git

[PATCH 1/2] drm/scheduler: Add job dependency trace.

2018-07-31 Thread Andrey Grodzovsky
During debug sessions I encountered a need to trace back a job dependecy a few steps back to the first failing job. This trace helpped me a lot. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 8 ++-- drivers/gpu/drm/scheduler/gpu_scheduler_trace.h |

Re: [PATCH v3 1/2] console: Replace #if 0 with atomic var 'ignore_console_lock_warning'

2018-07-31 Thread Steven Rostedt
On Thu, 19 Jul 2018 12:16:00 +0200 Thomas Zimmermann wrote: > The macro WARN_CONSOLE_UNLOCKED prints a warning when a thread enters > the console's critical section without having acquired the console > lock. The console lock can be ignored when debugging the console using > printk, but this

[Bug 100941] Improve time to suspend on Radeon HD 6310

2018-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100941 --- Comment #5 from Paul Menzel --- For the record, bug #107277 [1] is the same for amdgpu (like Raven devices. [1]: https://bugs.freedesktop.org/show_bug.cgi?id=107277 -- You are receiving this mail because: You are the assignee for the

Re: SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implementation)

2018-07-31 Thread Linus Torvalds
On Tue, Jul 31, 2018 at 10:36 AM Christopher Lameter wrote: > > If there is refcounting going on then why use SLAB_TYPESAFE_BY_RCU? .. because the object can be accessed (by RCU) after the refcount has gone down to zero, and the thing has been released. That's the whole and only point of

RE: [PATCH v6 11/35] drm/i915: Enable and Disable of HDCP2.2

2018-07-31 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Saturday, July 14, 2018 8:45 AM >To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; >dan...@ffwll.ch; seanp...@chromium.org; Winkler, Tomas >; Usyskin, Alexander ; >Shankar, Uma >Cc: Sharma, Shashank ; C, Ramalingam >

[Bug 107390] [BISECTED] EDID read failure breaks display mirroring

2018-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107390 --- Comment #11 from Alex Deucher --- (In reply to dwagner from comment #10) > (In reply to Harry Wentland from comment #9) > > That commit is correct. I don't think we should revert it. That said I don't > > quite understand why it leads to

RE: [PATCH v2 01/23] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT

2018-07-31 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Tuesday, July 31, 2018 2:07 PM >To: intel-...@lists.freedesktop.org >Cc: Navare, Manasi D ; dri- >de...@lists.freedesktop.org; Jani Nikula ; Ville >Syrjala ; Srivatsa, Anusha >; Singh, Gaurav K >Subject: [PATCH v2 01/23] drm/dp: Add DP

[radeon-alex:amd-staging-drm-next 690/717] drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:272:7: error: implicit declaration of function 'set_pages_array_uc'; did you mean 'ttm_set_pages_array_uc'?

2018-07-31 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: 5bb19d15d8f29153cdb83ceb9ccc78dce4cd31e4 commit: b6fde54f62b2e7da0ce5361746ddb81f52bfe6d9 [690/717] drm/ttm: clean up non-x86 definitions on ttm_page_alloc_dma config: ia64-allmodconfig (attached as .config)

[PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-07-31 Thread Manasi Navare
According to Display Stream compression spec 1.2, the picture parameter set metadata is sent from source to sink device using the DP Secondary data packet. An infoframe is formed for the PPS SDP header and PPS SDP payload bytes. This patch adds helpers to fill the PPS SDP header and PPS SDP

[PATCH v2 00/23] Display Stream Compression enabling on eDP/DP

2018-07-31 Thread Manasi Navare
Cc: dri-devel@lists.freedesktop.org VESA has developed an industry standard Display Stream Compression(DSC) for interoperable, visually lossless compression over display links to address the needs for higher resolution displays. This patch series enables DSC on Gen 10 eDP and Gen 11 eDP/DP

[PATCH v2 06/23] drm/dp: Define payload size for DP SDP PPS packet

2018-07-31 Thread Manasi Navare
DP 1.4 spec defines DP secondary data packet for DSC picture parameter set. This patch defines its payload size according to the DP 1.4 specification. Signed-off-by: Manasi Navare Cc: dri-devel@lists.freedesktop.org Cc: Gaurav K Singh Cc: Jani Nikula Cc: Ville Syrjala Cc: Anusha Srivatsa

[Bug 107390] [BISECTED] EDID read failure breaks display mirroring

2018-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107390 --- Comment #10 from dwagner --- (In reply to Harry Wentland from comment #9) > That commit is correct. I don't think we should revert it. That said I don't > quite understand why it leads to issues. Isn't it strange that dc_link_detect goes on

Re: [PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-07-31 Thread Chris Wilson
Quoting Manasi Navare (2018-07-31 22:07:06) > + /* PPS 4 */ > + pps_sdp->pps_payload.pps_4 = (u8)((dsc_cfg->bits_per_pixel & > + DSC_PPS_BPP_HIGH_MASK) >> > + DSC_PPS_MSB_SHIFT) | To avoid overhanging

[Bug 107152] GPU fault detected: 146 / VM_CONTEXT1_PROTECTION_FAULT / ring gfx timeout

2018-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107152 --- Comment #4 from dwagner --- Saw this kind of crash (still with the latest amd-staging-drm-next kernel) three times in a row today, just by playing a specific video immediately after rebooting and starting X11 with mpv, before the 10 minute

[Bug 107152] GPU fault detected: 146 / VM_CONTEXT1_PROTECTION_FAULT / ring gfx timeout

2018-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107152 --- Comment #5 from dwagner --- Just in case somebody aims at reproducing this with mpv, this is the content of the .config/mpv/mpv.conf file in use: audio-device='alsa/iec958:CARD=Generic,DEV=0' audio-delay=0.2 fs=no vo=gpu gpu-api=auto

RE: [PATCH 01/23] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT

2018-07-31 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Monday, July 30, 2018 7:13 PM >To: intel-...@lists.freedesktop.org >Cc: ville.syrj...@linux.intel.com; jani.nik...@linux.intel.com; Srivatsa, >Anusha >; Singh, Gaurav K ; >Navare, Manasi D ; dri- >de...@lists.freedesktop.org >Subject:

[PATCH v2 08/23] drm/dsc: Define VESA Display Stream Compression Capabilities

2018-07-31 Thread Manasi Navare
From: Gaurav K Singh This defines all the DSC parameters as per the VESA DSC spec that will be required for DSC encoder/decoder v4 (From Manasi) * Add the DSC_MUX_WORD_SIZE constants (Manasi) v3 (From Manasi) * Remove the duplicate define (Suggested By:Harry Wentland) v2: Define this struct

[PATCH v2 03/23] drm/dp: DRM DP helper/macros to get DP sink DSC parameters

2018-07-31 Thread Manasi Navare
This patch adds inline functions and helpers for obtaining DP sink's supported DSC parameters like DSC sink support, eDP compressed BPP supported, maximum slice count supported by the sink devices, DSC line buffer bit depth supported on DP sink, DSC sink maximum color depth by parsing

[PATCH v2 09/23] drm/dsc: Define Rate Control values that do not change over configurations

2018-07-31 Thread Manasi Navare
From: "Srivatsa, Anusha" DSC has some Rate Control values that remain constant across all configurations. These are as per the DSC standard. v3: * Define them in drm_dsc.h as they are DSC constants (Manasi) v2: * Add DP_DSC_ prefix (Jani Nikula) Cc: dri-devel@lists.freedesktop.org Cc: Manasi

[PATCH v2 14/23] drm/dsc: Define the DSC 1.1 and 1.2 Line Buffer depth constants

2018-07-31 Thread Manasi Navare
From: Gaurav K Singh DSC specification defines linebuf_depth which contains the line buffer bit depth used to generate the bitstream. These values are defined as per Table 4.1 in DSC 1.2 spec v2 (From Manasi): * Rename as MAX_LINEBUF_DEPTH for DSC 1.1 and DSC 1.2 Cc:

[PATCH v2 07/23] drm/dsc: Define Display Stream Compression PPS infoframe

2018-07-31 Thread Manasi Navare
This patch defines a new header file for all the DSC 1.2 structures and creates a structure for PPS infoframe which will be used to send picture parameter set secondary data packet for display stream compression. All the PPS infoframe syntax elements are taken from DSC 1.2 specification from VESA.

[PATCH v2 01/23] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT

2018-07-31 Thread Manasi Navare
This patch defines the DP DSC receiver capability size that gives total number of DP DSC DPCD registers. This also adds a missing #defines for DP DSC support missed in the commit id (ab6a46ea6842ce "Add DPCD definitions for DP 1.4 DSC feature") v3: * MIN_SLICE_WIDTH = 2560 (Anusha) * Define

Re: [PATCH] drm/amdgpu/pm: Fix potential Spectre v1

2018-07-31 Thread Alex Deucher
On Tue, Jul 31, 2018 at 2:46 AM, Christian König wrote: > Am 30.07.2018 um 22:14 schrieb Alex Deucher: >> >> On Mon, Jul 30, 2018 at 5:55 AM, Michel Dänzer wrote: >>> >>> On 2018-07-24 10:53 PM, Alex Deucher wrote: On Mon, Jul 23, 2018 at 12:32 PM, Gustavo A. R. Silva wrote:

RE: [PATCH v2 03/23] drm/dp: DRM DP helper/macros to get DP sink DSC parameters

2018-07-31 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Tuesday, July 31, 2018 2:07 PM >To: intel-...@lists.freedesktop.org >Cc: Navare, Manasi D ; Singh, Gaurav K >; dri-devel@lists.freedesktop.org; Jani Nikula >; Ville Syrjala ; >Srivatsa, Anusha >Subject: [PATCH v2 03/23] drm/dp: DRM DP

[ANNOUNCE] libdrm 2.4.93

2018-07-31 Thread Marek Olšák
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Christian König (1): amdgpu: make sure to set CLOEXEC on duplicated FDs Emil Velikov (10): xf86drm: drmGetDevice2: error out if the fd has unknown subsys xf86drm: introduce drm_device_has_rdev() helper xf86drm: Fold

Re: [radeon-alex:amd-staging-drm-next 690/717] drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:272:7: error: implicit declaration of function 'set_pages_array_uc'; did you mean 'ttm_set_pages_array_uc'?

2018-07-31 Thread Huang Rui
On Wed, Aug 01, 2018 at 06:59:47AM +0800, kbuild test robot wrote: > tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next > head: 5bb19d15d8f29153cdb83ceb9ccc78dce4cd31e4 > commit: b6fde54f62b2e7da0ce5361746ddb81f52bfe6d9 [690/717] drm/ttm: clean up > non-x86 definitions

[PATCH 0/2] drm/amdgpu: Clean-up TTM BO ref-counting interface

2018-07-31 Thread Thomas Zimmermann
This patchset replaces ttm_bo_{reference/unref} with ttm_bo_{get,put}, which follow Linux' conventions for ref-counting functions. v2: * use prefix drm/amdgpu Thomas Zimmermann (2): drm/amdgpu: Replace ttm_bo_reference with ttm_bo_get drm/amdgpu: Replace ttm_bo_unref with ttm_bo_put

[PATCH 2/2] drm/amdgpu: Replace ttm_bo_unref with ttm_bo_put

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL.

[PATCH 1/2] drm/amdgpu: Replace ttm_bo_reference with ttm_bo_get

2018-07-31 Thread Thomas Zimmermann
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. v2: * changed prefix to drm/amdgpu Signed-off-by: Thomas Zimmermann ---

  1   2   >