Re: [RESEND PATCH v5 0/3] drm/atmel-hlcdc: bus-width override support

2018-08-03 Thread Boris Brezillon
On Fri, 3 Aug 2018 09:23:05 +0200 Peter Rosin wrote: > Hi! > > This is perhaps not a true resend in that these three patches were > originally in a larger series [1], and the series have been rebased > to v4.18-rc6. However, I did ask that these three patches should be > considered separately.

[Bug 107459] Atomically set gamma ramps are not applied until TTY switch

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107459 Michel Dänzer changed: What|Removed |Added CC||harry.wentl...@amd.com --- Comment #2

[Bug 107465] Weird resolution

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107465 Bug ID: 107465 Summary: Weird resolution Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium

[Bug 107465] Weird resolution

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107465 --- Comment #1 from Germano Massullo --- Created attachment 140947 --> https://bugs.freedesktop.org/attachment.cgi?id=140947=edit Xorg.0.log -- You are receiving this mail because: You are the assignee for the

[Bug 107465] System does not recognize native screen resolution

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107465 Michel Dänzer changed: What|Removed |Added Attachment #140947|text/x-log |text/plain mime type|

Re: [PATCH v3] gpu/drm/exynos: Convert drm_atomic_helper_suspend/resume()

2018-08-03 Thread Marek Szyprowski
Hi, On 2018-08-02 17:51, Souptick Joarder wrote: > On Thu, Aug 2, 2018 at 7:08 PM, Marek Szyprowski > wrote: >> On 2018-08-02 15:21, Souptick Joarder wrote: >>> convert drm_atomic_helper_suspend/resume() to use >>> drm_mode_config_helper_suspend/resume(). >>> >>> exynos_drm_fbdev_suspend/resume

[RFC PATCH v1 0/5] Add pardata bus + tinydrm driver

2018-08-03 Thread Sam Ravnborg
This is an RFC - to get some responses on the overall design. The code builds but has not yet been tested on any HW. Before investing more time into this I would like some feedback if this is the right way forward or a different design should be pursued. The problem to solve is that I have a

[PATCH 2/3] dt-bindings: tegra: update PMC DT binding with io pads control

2018-08-03 Thread Venkat Reddy Talla
NVIDIA Tegra124 and later SoCs support the multi-voltage level and low power state of some of its IO pads. The IO pads can work in the voltage of the 1.8V and 3.3V of IO voltage from IO power rail sources. When IO interfaces are not used then IO pads can be configure in low power state to reduce

[GIT PULL] TDA998x I2C driver development updates

2018-08-03 Thread Russell King
Hi David, The following changes since commit 4da1d4c751c9b1b713c13043bad7c4d27cd1418c: Merge commit 'refs/for-upstream/mali-dp' of git://linux-arm.org/linux-ld into drm-next (2018-07-06 10:02:13 +1000) are available in the git repository at: git://git.armlinux.org.uk/~rmk/linux-arm.git

[PATCH v4] gpu/drm/exynos: Convert drm_atomic_helper_suspend/resume()

2018-08-03 Thread Souptick Joarder
convert drm_atomic_helper_suspend/resume() to use drm_mode_config_helper_suspend/resume(). exynos_drm_fbdev_suspend/resume can be removed as drm_mode_config_helper_suspend/resume has implement the same in generic way. Remove suspend_state from exynos_drm_private struct as it is no more useful.

[PATCH] drm/i915/kvmgt: Fix potential Spectre v1

2018-08-03 Thread Gustavo A. R. Silva
info.index can be indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: drivers/gpu/drm/i915/gvt/kvmgt.c:1232 intel_vgpu_ioctl() warn: potential spectre issue 'vgpu->vdev.region' [r]

Re: [PATCH] drm/nouveau/secboot/acr: fix memory leak

2018-08-03 Thread Gustavo A. R. Silva
Hi all, Friendly ping! Who can take this? Thanks -- Gustavo On 07/24/2018 08:27 AM, Gustavo A. R. Silva wrote: > In case memory resources for *bl_desc* were allocated, release > them before return. > > Addresses-Coverity-ID: 1472021 ("Resource leak") > Fixes: 0d466901552a

[PATCH v3] gpu/drm/exynos: Convert drm_atomic_helper_suspend/resume()

2018-08-03 Thread Souptick Joarder
convert drm_atomic_helper_suspend/resume() to use drm_mode_config_helper_suspend/resume(). exynos_drm_fbdev_suspend/resume can be removed as drm_mode_config_helper_suspend/resume has implement the same in generic way. Remove suspend_state from exynos_drm_private struct as it is no more useful.

Re: [PATCHv3] lib/ratelimit: Lockless ratelimiting

2018-08-03 Thread Dmitry Safonov
Hi Steven, Thanks for your reply, On Wed, 2018-08-01 at 21:48 -0400, Steven Rostedt wrote: > I'm just catching up from my vacation. What about making rs->missed > into an atomic, and have: > > if (!raw_spin_trylock_irqsave(>lock, flags)) { > atomic_inc(>missed); >

Re: [PATCH 4/4] drm/meson: convert to the new canvas module

2018-08-03 Thread Maxime Jourdan
2018-08-02 15:01 GMT+02:00 Jerome Brunet : > What I don't like is precisely that you need to expose this 'struct ops' to > the > consumer. I would prefer an API for this (it can be a 1:1 mapping). The canvas > should remain some abstract object you get from DT. > > IMO, this is the same as a

[PATCH v1 2/5] pardata: new bus for parallel data access

2018-08-03 Thread Sam Ravnborg
The pardata supports implement a simple bus for devices that are connected using a parallel bus driven by GPIOs. The is often used in combination with simple displays that is often seen in older embedded designs. There is a demand for this support also in the linux kernel for HW designs that uses

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-08-03 Thread Leonard Crestez
On Thu, 2018-08-02 at 13:06 +0200, Stefan Agner wrote: > On 02.08.2018 12:17, Philipp Zabel wrote: > > On Tue, 2018-07-31 at 12:17 +, Leonard Crestez wrote: > > > On Tue, 2018-07-31 at 13:54 +0200, Philipp Zabel wrote: > > > > On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: > > > > >

Re: [PATCH 4/4] drm/meson: convert to the new canvas module

2018-08-03 Thread Jerome Brunet
On Thu, 2018-08-02 at 14:34 +0200, Maxime Jourdan wrote: > Hi Jerome, > > 2018-08-02 10:39 GMT+02:00 Jerome Brunet : > > I looks like the consumer of your 'canvas' devices must know how the canvas > > device is organized internally. Maybe something better can be done ? > > > > Your canvas driver

[PATCH -next] drm/vkms: Fix the error handling in vkms_init()

2018-08-03 Thread Wei Yongjun
In the drm_vblank_init() error handling case, platform device unregister is missing. This patch fix it. Fixes: 3a0709928b17 ("drm/vkms: Add vblank events simulated by hrtimers") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/vkms/vkms_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH V4 0/8] backlight: qcom-wled: Support for QCOM wled driver

2018-08-03 Thread Daniel Thompson
On Fri, Aug 03, 2018 at 12:49:34PM +0530, kgu...@codeaurora.org wrote: > Hi Bjorn, > Can you please help review this patch series ? > > Pavel, Rob, Daniel reviewed the series except the "auto string detection" > patch. I did take a glance at the last patch... but in the end decided to wait for

Re: [RESEND PATCH v5 2/3] dt-bindings: display: atmel: optional video-interface of endpoints

2018-08-03 Thread jacopo mondi
Hi Peter! On Fri, Aug 03, 2018 at 09:23:07AM +0200, Peter Rosin wrote: > With bus-type/bus-width properties in the endpoint nodes, the video- > interface of the connection can be specified for cases where the > heuristic fails to select the correct output mode. This can happen > e.g. if not all

Re: [PATCH] drm/vc4: Fix the "no scaling" case on multi-planar YUV formats

2018-08-03 Thread Boris Brezillon
On Fri, 27 Jul 2018 13:55:03 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > When there's no scaling requested ->is_unity should be true no matter > > the format. > > > > Also, when no scaling is requested and we have a multi-planar YUV > > format, we should leave ->y_scaling[0] to

Re: [RESEND PATCH v5 2/3] dt-bindings: display: atmel: optional video-interface of endpoints

2018-08-03 Thread Laurent Pinchart
Hi Peter, (CC'ing Sakari Ailus) On Friday, 3 August 2018 11:40:02 EEST Peter Rosin wrote: > On 2018-08-03 10:11, jacopo mondi wrote: > > On Fri, Aug 03, 2018 at 09:23:07AM +0200, Peter Rosin wrote: > >> With bus-type/bus-width properties in the endpoint nodes, the video- > >> interface of the

[PATCH v1 4/5] dt-bindings: add winstar,wg160160 display bindings

2018-08-03 Thread Sam Ravnborg
The winstar display uses the pardata binding. Signed-off-by: Sam Ravnborg --- .../bindings/display/winstar,wg160160.txt | 53 ++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/winstar,wg160160.txt diff --git

[PATCH] drm/i915/gvt: fix memory leak in intel_vgpu_ioctl()

2018-08-03 Thread Yi Wang
The 'sparse' variable may leak when return in function intel_vgpu_ioctl(), and this patch fixes this. Signed-off-by: Yi Wang Reviewed-by: Jiang Biao --- drivers/gpu/drm/i915/gvt/kvmgt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c

[PATCH 1/3] soc/tegra: pmc: set IO pad power state and voltage via pinctrl fw

2018-08-03 Thread Venkat Reddy Talla
The IO pins of Tegra SoCs are grouped for common control of IO interface like setting voltage signal levels and power state of the interface. These groups are referred to as IO pads.The power state and voltage control of IO pins can be done at IO pads level. Tegra SoCs support powering down IO

Re: [PATCH 4/4] drm/meson: convert to the new canvas module

2018-08-03 Thread Maxime Jourdan
Hi Jerome, 2018-08-02 10:39 GMT+02:00 Jerome Brunet : > I looks like the consumer of your 'canvas' devices must know how the canvas > device is organized internally. Maybe something better can be done ? > > Your canvas driver could provide a consumer API, for example: > meson_canvas_get(): to

Re: [PATCH v3] gpu/drm/exynos: Convert drm_atomic_helper_suspend/resume()

2018-08-03 Thread Souptick Joarder
On Thu, Aug 2, 2018 at 7:08 PM, Marek Szyprowski wrote: > Hi, > > On 2018-08-02 15:21, Souptick Joarder wrote: >> convert drm_atomic_helper_suspend/resume() to use >> drm_mode_config_helper_suspend/resume(). >> >> exynos_drm_fbdev_suspend/resume can be removed >> as

Re: [RFC PATCH v1 0/5] Add pardata bus + tinydrm driver

2018-08-03 Thread Miguel Ojeda
Hi Sam, On Thu, Aug 2, 2018 at 9:39 PM, Sam Ravnborg wrote: > This is an RFC - to get some responses on the overall design. > The code builds but has not yet been tested on any HW. > Before investing more time into this I would like some feedback > if this is the right way forward or a different

[PATCH v1 3/5] tinydrm: add support for parallel data displays

2018-08-03 Thread Sam Ravnborg
Utilising the pardata bus/driver add support for displays connected to a parallel data bus. There is no specific protocol implemented, but the display is tied to the tinydrm pipe. Only monochrome displays supported using the XRGB format. Signed-off-by: Sam Ravnborg ---

[PATCH 3/3] drm/tegra: sor: change io pad power state using new pmc api

2018-08-03 Thread Venkat Reddy Talla
Added support in PMC driver to configure the power state and voltage level of the IO pads from client driver via pincontrol framework, because of this tegra_io_pad_power_disable() and tegra_io_pad_power_enable() deprecated, to change power state of SOR io pads using new pmc apis. Signed-off-by:

Re: [RFC PATCH v1 0/6] Resolve unwanted DMA backing with IOMMU

2018-08-03 Thread Dmitry Osipenko
On Friday, 27 July 2018 20:16:53 MSK Dmitry Osipenko wrote: > On Friday, 27 July 2018 20:03:26 MSK Jordan Crouse wrote: > > On Fri, Jul 27, 2018 at 05:02:37PM +0100, Robin Murphy wrote: > > > On 27/07/18 15:10, Dmitry Osipenko wrote: > > > >On Friday, 27 July 2018 12:03:28 MSK Will Deacon wrote: >

[PATCH v1 5/5] tinydrm: add winstar wg160160 driver

2018-08-03 Thread Sam Ravnborg
Add driver for the winstar wg160160 display. The driver utilises pardata-dbi that again utilise the pardata subsystem. Signed-off-by: Sam Ravnborg --- MAINTAINERS| 5 + drivers/gpu/drm/tinydrm/Kconfig| 10 ++ drivers/gpu/drm/tinydrm/Makefile | 1 +

Re: [PATCH v2] gpu/drm/exynos: Convert drm_atomic_helper_suspend/resume()

2018-08-03 Thread Souptick Joarder
On Thu, Aug 2, 2018 at 12:17 PM, Marek Szyprowski wrote: > Hi Souptick, > > On 2018-08-02 08:25, Souptick Joarder wrote: >> On Thu, Jul 26, 2018 at 9:24 PM, Souptick Joarder >> wrote: >>> convert drm_atomic_helper_suspend/resume() to use >>> drm_mode_config_helper_suspend/resume(). >>> >>>

Re: [PATCH] drm: Convert drm_atomic_helper_suspend/resume()

2018-08-03 Thread Souptick Joarder
On Wed, Aug 1, 2018 at 12:11 AM, Souptick Joarder wrote: > On Tue, Jul 31, 2018 at 4:04 PM, Liviu Dudau wrote: >> Hi Souptick, >> >> On Tue, Jul 31, 2018 at 12:31:37AM +0530, Souptick Joarder wrote: >>> convert drm_atomic_helper_suspend/resume() to use >>>

Re: [PATCH 4/4] drm/meson: convert to the new canvas module

2018-08-03 Thread Jerome Brunet
On Wed, 2018-08-01 at 20:51 +0200, Maxime Jourdan wrote: > This removes the meson_canvas files within the meson/drm layer > and makes use of the new canvas module that is referenced in the dts. > > Canvases can be used by different IPs and modules, and it is as such > preferable to rely on a

[PATCH v1 1/5] dt-bindings: add parallel data bus (pardata)

2018-08-03 Thread Sam Ravnborg
The parallel data bus is a simple parallel bus that may be used to drive displays. It is mostly used in simple embedded systems but is also used in some desings utilising Linux. Signed-off-by: Sam Ravnborg --- .../bindings/pardata/parallel-data-bus.txt | 60 ++ 1

Re: [PATCH] drm/msm/adreno: Remove VLA usage

2018-08-03 Thread Kees Cook
On Fri, Jun 29, 2018 at 2:20 PM, Jordan Crouse wrote: > On Fri, Jun 29, 2018 at 11:48:18AM -0700, Kees Cook wrote: >> In the quest to remove all stack VLA usage from the kernel[1], this >> switches to using a kasprintf()ed buffer. Return paths are updated >> to free the allocation. >> >> [1] >>

Re: [PATCH] gpu/drm/hisilicon: Convert drm_atomic_helper_suspend/resume()

2018-08-03 Thread Souptick Joarder
On Thu, Jul 26, 2018 at 1:37 PM, Souptick Joarder wrote: > On Thu, Jul 19, 2018 at 9:34 PM, Souptick Joarder > wrote: >> convert drm_atomic_helper_suspend/resume() to use >> drm_mode_config_helper_suspend/resume(). >> >> Fixed one sparse warning by making hibmc_drm_interrupt >> static. >> >>

Re: [RESEND PATCH v5 3/3] drm/atmel-hlcdc: support bus-width (12/16/18/24) in endpoint nodes

2018-08-03 Thread jacopo mondi
Hi Peter, On Fri, Aug 03, 2018 at 09:23:08AM +0200, Peter Rosin wrote: > This beats the heuristic that the connector is involved in what format > should be output for cases where this fails. > > E.g. if there is a bridge that changes format between the encoder and the > connector, or if some of

Re: [RESEND PATCH v5 2/3] dt-bindings: display: atmel: optional video-interface of endpoints

2018-08-03 Thread jacopo mondi
On Fri, Aug 03, 2018 at 10:40:02AM +0200, Peter Rosin wrote: > On 2018-08-03 10:11, jacopo mondi wrote: > > Hi Peter! > > > > On Fri, Aug 03, 2018 at 09:23:07AM +0200, Peter Rosin wrote: > >> With bus-type/bus-width properties in the endpoint nodes, the video- > >> interface of the connection can

[Bug 107465] System does not recognize native screen resolution

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107465 Germano Massullo changed: What|Removed |Added Summary|Weird resolution|System does not recognize

[Bug 107465] Weird resolution

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107465 --- Comment #2 from Germano Massullo --- Created attachment 140948 --> https://bugs.freedesktop.org/attachment.cgi?id=140948=edit dmesg -- You are receiving this mail because: You are the assignee for the

[PATCH] drm/scheduler: select the least loaded sched during entity init

2018-08-03 Thread Nayan Deshmukh
Instead of assigning entity to the first scheduler in the list assign it to the least loaded scheduler. Signed-off-by: Nayan Deshmukh --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c

[PATCH v2 3/5] drm/vc4: Use drm_atomic_helper_check_plane_state() to simplify the logic

2018-08-03 Thread Boris Brezillon
drm_atomic_helper_check_plane_state() takes care of checking the scaling capabilities and calculating the clipped X/Y offsets for us. Rely on this function instead of open-coding the logic. Incidentally, it seems to fix a problem we had with negative X/Y positioning of YUV planes.

[PATCH v2 4/5] drm/vc4: Move ->offsets[] adjustment out of setup_clipping_and_scaling()

2018-08-03 Thread Boris Brezillon
The offset adjustment depends on the framebuffer modified, so let's just move this operation in the DRM_FORMAT_MOD_LINEAR case inside vc4_plane_mode_set(). This we'll be able to fix offset calculation for DRM_FORMAT_MOD_BROADCOM_VC4_T_TILED and DRM_FORMAT_MOD_BROADCOM_SANDXXX. Signed-off-by:

Re: [PATCH v5 08/11] media: vsp1: Add support for extended display list headers

2018-08-03 Thread Kieran Bingham
Hi Laurent, On 02/08/18 15:39, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. Thank you for (hopefully the last) review on this series :) > On Tuesday, 17 July 2018 23:35:50 EEST Kieran Bingham wrote: >> From: Kieran Bingham >> >> Extended display list headers allow pre

[Bug 107432] Periodic complete system lockup with Vega M and Kernel 4.18-rc6+

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107432 --- Comment #6 from Michel Dänzer --- Well, https://bugs.freedesktop.org/attachment.cgi?id=140903 definitely shows an amdgpu issue exacerbating the memory pressure situation — it tries to allocate 4M of physically contiguous memory. My patch

Re: [PATCH v1 06/15] drm/mediatek: add memory mode for RDMA

2018-08-03 Thread CK Hu
Hi, Stu: On Thu, 2018-08-02 at 19:36 +0800, Stu Hsieh wrote: > Hi, CK: > > On Wed, 2018-07-25 at 10:40 +0800, CK Hu wrote: > > Hi, Stu: > > > > On Tue, 2018-07-24 at 16:17 +0800, Stu Hsieh wrote: > > > This patch add memory mode for RDMA > > > > > > If use RDMA to read data from memory, it

Re: [PATCH 5/5] drm/vc4: Fix negative X/Y positioning of planes using T_TILES modifier

2018-08-03 Thread Boris Brezillon
On Fri, 27 Jul 2018 13:46:31 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > From: Eric Anholt > > > > X/Y positioning of T-format buffers is quite tricky and the current > > implementation was failing to position a plane using this format > > correctly when the X, Y or both X and Y

[PATCH v2 1/5] drm/vc4: Fix TILE_Y_OFFSET definitions

2018-08-03 Thread Boris Brezillon
From: Eric Anholt Y_OFFSET field starts at bit 8 not 7. Signed-off-by: Eric Anholt Signed-off-by: Boris Brezillon --- Changes in v2: - None --- drivers/gpu/drm/vc4/vc4_regs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_regs.h

[PATCH v2 2/5] drm/vc4: Define missing PITCH0_SINK_PIX field

2018-08-03 Thread Boris Brezillon
From: Eric Anholt This is needed to support X/Y negative placement of planes using T-format buffers. Signed-off-by: Eric Anholt Signed-off-by: Boris Brezillon --- Changes in v2: - Fixed typo in commit subject line --- drivers/gpu/drm/vc4/vc4_regs.h | 4 1 file changed, 4 insertions(+)

[PATCH v2 5/5] drm/vc4: Fix X/Y positioning of planes using T_TILES modifier

2018-08-03 Thread Boris Brezillon
X/Y positioning of T-format buffers is quite tricky and the current implementation was failing to position a plane using this format correctly when the CRTC X, Y or both X and Y offsets were negative. It was also failing when the SRC X/Y offsets were != 0. Signed-off-by: Boris Brezillon

Re: [PATCH v5 10/11] media: vsp1: Support Interlaced display pipelines

2018-08-03 Thread Kieran Bingham
On 02/08/18 23:44, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 17 July 2018 23:35:52 EEST Kieran Bingham wrote: >> From: Kieran Bingham >> >> Calculate the top and bottom fields for the interlaced frames and >> utilise the extended display list command

Re: [PATCH v6 2/3] dt-bindings: display: atmel: optional video-interface of endpoints

2018-08-03 Thread Sakari Ailus
Hi Peter, Thanks for cc'ing me. On Fri, Aug 03, 2018 at 12:11:23PM +0200, Peter Rosin wrote: > With bus-type/bus-width properties in the endpoint nodes, the video- > interface of the connection can be specified for cases where the > heuristic fails to select the correct output mode. This can

Re: [PATCH v1] drm/kms/crtc: Improving the func drm_mode_setcrtc

2018-08-03 Thread Maarten Lankhorst
Op 03-08-18 om 13:43 schreef Satendra Singh Thakur: > Following changes are done to this func: > 1. The declaration of plane and it's assignment plane = crtc->primary > are only used when mode_valid is set. Therefore, moved it inside > the if(mode_valid) statement. > > 2. The declaration of

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-03 Thread Emil Velikov
Hi all, Sharing some ideas on the topic. Personally I'm neither for, nor against this patch. On 24 July 2018 at 09:22, Robert Foss wrote: > From: Tomasz Figa > > There is no particular reason to prevent userspace for using this IOCTL, > considering that it already has access to other,

[PATCH] drm/scheduler: fix timeout worker setup for out of order job completions

2018-08-03 Thread Lucas Stach
drm_sched_job_finish() is a work item scheduled for each finished job on a unbound system workqueue. This means the workers can execute out of order with regard to the real hardware job completions. If this happens queueing a timeout worker for the first job on the ring mirror list is wrong, as

[PATCH] drm/scheduler: Remove entity->rq NULL check

2018-08-03 Thread Christian König
That is superflous now. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 85908c7f913e..65078dd3c82c 100644 ---

Re: [PATCH] drm/scheduler: fix setting the priorty for entities

2018-08-03 Thread Christian König
Am 03.08.2018 um 03:08 schrieb Dieter Nützel: Hello Christian, AMD guys, this one _together_ with these series [PATCH 1/7] drm/amdgpu: use new scheduler load balancing for VMs https://lists.freedesktop.org/archives/amd-gfx/2018-August/024802.html on top of amd-staging-drm-next 53d5f1e4a6d9

Re: [PATCH v5 2/2] dt-bindings: Add Truly NT35597 panel bindings

2018-08-03 Thread Linus Walleij
On Fri, Aug 3, 2018 at 4:49 AM Abhinav Kumar wrote: > From: "abhin...@codeaurora.org" > > Add the device tree bindings for Truly NT35597 panel. > This panel supports both single DSI and dual DSI. I do not think this is a panel but a panel driver that can be used with several physical panels.

Re: [PATCH] drm/scheduler: select the least loaded sched during entity init

2018-08-03 Thread Nayan Deshmukh
Ah...you are correct. We will reschedule on the first job push. I didn't take that into account. Let's drop this patch then. Thanks, Nayan On Fri, Aug 3, 2018, 4:12 PM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 03.08.2018 um 09:06 schrieb Nayan Deshmukh: > > Instead of

[Bug 105463] [r600g] 3047 piglit failures, 75 crashes, 15 warnings on ppc (PCIe, ppc64, mesa-18.0.0)

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105463 erhar...@mailbox.org changed: What|Removed |Added See Also||https://bugs.freedesktop.or

[Bug 107448] [r600g] 2 of 5 piglit sanity tests fail (PCIe, ppc64, mesa-18.1.5)

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107448 erhar...@mailbox.org changed: What|Removed |Added See Also||https://bugs.freedesktop.or

Re: [PATCH] drm/scheduler: select the least loaded sched during entity init

2018-08-03 Thread Christian König
Am 03.08.2018 um 09:06 schrieb Nayan Deshmukh: Instead of assigning entity to the first scheduler in the list assign it to the least loaded scheduler. I thought about that as well, but then abandoned the idea. The reason is that we are going to reassign the rq when the first job is pushed to

Re: [PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-03 Thread Linus Walleij
On Fri, Aug 3, 2018 at 4:49 AM Abhinav Kumar wrote: Hi Abhinav, > From: "abhin...@codeaurora.org" > > Add support for Truly NT35597 panel used > in MSM reference platforms. > > This panel supports both single DSI and dual DSI > modes. > > However, this patch series adds support only for > dual

Re: [PATCH] drm/msm/adreno: Remove VLA usage

2018-08-03 Thread Rob Clark
On Thu, Aug 2, 2018 at 7:24 PM, Kees Cook wrote: > On Fri, Jun 29, 2018 at 2:20 PM, Jordan Crouse wrote: >> On Fri, Jun 29, 2018 at 11:48:18AM -0700, Kees Cook wrote: >>> In the quest to remove all stack VLA usage from the kernel[1], this >>> switches to using a kasprintf()ed buffer. Return

Re: [PATCH 2/2] drm/scheduler: stop setting rq to NULL

2018-08-03 Thread Nayan Deshmukh
On Thu, Aug 2, 2018, 8:09 PM Andrey Grodzovsky wrote: > > > On 08/02/2018 02:43 AM, Nayan Deshmukh wrote: > > Hi Andrey, > > Good catch. I guess since both Christian and I were working on it > parallelly we didn't catch this problem. > > If it is only causing a problem in push_job then we can

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-03 Thread Emil Velikov
Hi Martin, On 1 August 2018 at 15:24, Martin Fuzzey wrote: > Hi, > > I am running into the same problem using etnaviv on i.MX6 under Android 8.1 > > The mesa etnaviv code uses CREATE_DUMB / MAP_DUMB for the scanout buffers > and is called from the surfaceflinger process. > > But, under Android

[Bug 107448] [r600g] 2 of 5 piglit sanity tests fail (PCIe, ppc64, mesa-18.1.5)

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107448 --- Comment #5 from erhar...@mailbox.org --- Created attachment 140950 --> https://bugs.freedesktop.org/attachment.cgi?id=140950=edit html-summary from 'pigllit run sanity' (18.0.5) Same test failures with mesa 18.0.5. So I guess it's piglit

Re: [PATCH v1] gpu: host1x: Ignore clients initialization failure

2018-08-03 Thread Thierry Reding
On Wed, Aug 01, 2018 at 06:08:07PM +0300, Dmitry Osipenko wrote: > From time to time new bugs are popping up, causing some host1x client to > fail its initialization. Currently a single clients initialization failure > causes whole host1x device registration to fail, as a result a single DRM >

Re: [PATCH 2/2] drm/scheduler: stop setting rq to NULL

2018-08-03 Thread Andrey Grodzovsky
On 08/03/2018 08:12 AM, Nayan Deshmukh wrote: On Thu, Aug 2, 2018, 8:09 PM Andrey Grodzovsky mailto:andrey.grodzov...@amd.com>> wrote: On 08/02/2018 02:43 AM, Nayan Deshmukh wrote: Hi Andrey, Good catch. I guess since both Christian and I were working on it parallelly

Re: [PATCH] drm/scheduler: fix timeout worker setup for out of order job completions

2018-08-03 Thread Christian König
Am 03.08.2018 um 16:09 schrieb Lucas Stach: Hi Christian, Am Freitag, den 03.08.2018, 15:51 +0200 schrieb Christian König: Hi Lucas, thanks a lot for taking care of that, but there is one thing you have missed: It is perfectly possible that the job is the last one on the list and

[PATCH v2] drm/scheduler: fix timeout worker setup for out of order job completions

2018-08-03 Thread Lucas Stach
drm_sched_job_finish() is a work item scheduled for each finished job on a unbound system workqueue. This means the workers can execute out of order with regard to the real hardware job completions. If this happens queueing a timeout worker for the first job on the ring mirror list is wrong, as

Re: [PATCH 2/2] drm/scheduler: stop setting rq to NULL

2018-08-03 Thread Andrey Grodzovsky
On 08/03/2018 10:06 AM, Christian König wrote: Am 02.08.2018 um 16:11 schrieb Andrey Grodzovsky: On 08/02/2018 02:47 AM, Nayan Deshmukh wrote: On Thu, Aug 2, 2018 at 12:12 PM Christian König > wrote: Am 02.08.2018 um 00:25 schrieb Andrey

Re: [PATCH] drm/scheduler: fix timeout worker setup for out of order job completions

2018-08-03 Thread Christian König
Hi Lucas, thanks a lot for taking care of that, but there is one thing you have missed: It is perfectly possible that the job is the last one on the list and list_next_entry() doesn't test for that, e.g. it never return NULL. BTW: There are also quite a lot of other things we could

Re: [PATCH 2/2] drm/scheduler: stop setting rq to NULL

2018-08-03 Thread Nayan Deshmukh
On Fri, Aug 3, 2018 at 7:17 PM Andrey Grodzovsky wrote: > > > On 08/03/2018 08:12 AM, Nayan Deshmukh wrote: > > > > On Thu, Aug 2, 2018, 8:09 PM Andrey Grodzovsky > wrote: > >> >> >> On 08/02/2018 02:43 AM, Nayan Deshmukh wrote: >> >> Hi Andrey, >> >> Good catch. I guess since both Christian

Re: [PATCH 2/2] drm/scheduler: stop setting rq to NULL

2018-08-03 Thread Christian König
Am 02.08.2018 um 16:11 schrieb Andrey Grodzovsky: On 08/02/2018 02:47 AM, Nayan Deshmukh wrote: On Thu, Aug 2, 2018 at 12:12 PM Christian König > wrote: Am 02.08.2018 um 00:25 schrieb Andrey Grodzovsky: > Thinking again about this change

Re: [PATCH] drm/scheduler: fix timeout worker setup for out of order job completions

2018-08-03 Thread Lucas Stach
Hi Christian, Am Freitag, den 03.08.2018, 15:51 +0200 schrieb Christian König: > Hi Lucas, > > thanks a lot for taking care of that, but there is one thing you have  > missed: > > It is perfectly possible that the job is the last one on the list and  > list_next_entry() doesn't test for that,

Re: [RFC PATCH v1 0/6] Resolve unwanted DMA backing with IOMMU

2018-08-03 Thread Robin Murphy
On 02/08/18 19:24, Dmitry Osipenko wrote: On Friday, 27 July 2018 20:16:53 MSK Dmitry Osipenko wrote: On Friday, 27 July 2018 20:03:26 MSK Jordan Crouse wrote: On Fri, Jul 27, 2018 at 05:02:37PM +0100, Robin Murphy wrote: On 27/07/18 15:10, Dmitry Osipenko wrote: On Friday, 27 July 2018

Re: [PATCH v5 1/2] drm/panel: Add support for Truly NT35597 panel

2018-08-03 Thread kbuild test robot
-ci/linux/commits/Abhinav-Kumar/drm-panel-Add-support-for-Truly-NT35597-panel/20180803-114716 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/gpu/drm/panel

[RFC PATCH] drm/panel: panel_cmds_set_1[] can be static

2018-08-03 Thread kbuild test robot
Fixes: fe3734f91d5e ("drm/panel: Add support for Truly NT35597 panel") Signed-off-by: kbuild test robot --- panel-truly-nt35597.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c

Re: [PATCH] drm/msm/dpu: enable cursor plane on dpu

2018-08-03 Thread Sean Paul
On Thu, Aug 02, 2018 at 04:24:44PM +0530, Sravanthi Kollukuduru wrote: > Reserve DMA pipe for cursor plane and attach it to the > crtc during the initialization. > > Signed-off-by: Sravanthi Kollukuduru Hi Sravanthi, Thanks for sending this. I have a few comments, mostly based off my own cursor

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-03 Thread Sean Paul
On Thu, Aug 02, 2018 at 08:09:51AM -0300, Gustavo Padovan wrote: > Hi Haneen, > > On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > > This patch implement the necessary functions to compute and add CRCs > > entries: > > > > - Implement the set_crc_source() callback. > > -

Re: [PATCH 2/2] drm/scheduler: stop setting rq to NULL

2018-08-03 Thread Christian König
Am 03.08.2018 um 16:54 schrieb Andrey Grodzovsky: [SNIP] > > Second of all, even after we removed the entity from rq in > drm_sched_entity_flush to terminate any subsequent submissions > > to the queue the other thread doing push job can just acquire again a >

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-03 Thread Sean Paul
On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > This patch implement the necessary functions to compute and add CRCs > entries: > > - Implement the set_crc_source() callback. > - Compute CRC using crc32 on the visible part of the framebuffer. > - Use ordered workqueue per

Re: [RFC PATCH v1 0/6] Resolve unwanted DMA backing with IOMMU

2018-08-03 Thread Jordan Crouse
On Fri, Aug 03, 2018 at 04:43:41PM +0100, Robin Murphy wrote: > On 02/08/18 19:24, Dmitry Osipenko wrote: > >On Friday, 27 July 2018 20:16:53 MSK Dmitry Osipenko wrote: > >>On Friday, 27 July 2018 20:03:26 MSK Jordan Crouse wrote: > >>>On Fri, Jul 27, 2018 at 05:02:37PM +0100, Robin Murphy wrote:

Re: [RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-08-03 Thread Emil Velikov
On 3 August 2018 at 16:06, Martin Fuzzey wrote: > Hi Emil, > > On 03/08/18 14:35, Emil Velikov wrote: >> >> Hi Martin, >> >> On 1 August 2018 at 15:24, Martin Fuzzey >> wrote: >> >> Let's start with the not-so obvious question: >> Why does one open the imx as render node? >> >> Of the top of my

[PATCH] drm/i915: Add detection of changing of edid on between suspend and resume

2018-08-03 Thread Gwan-gyeong Mun
The hotplug detection routine of i915 uses drm_helper_hpd_irq_event(). This helper can detect changing of status of connector, but it can not detect changing of edid. Following scenario requires detection of changing of edid. 1) plug display device to a connector 2) system suspend 3) unplug

[PATCH] drm/i915: Fix typo in i915_drm_resume()

2018-08-03 Thread Gwan-gyeong Mun
Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/i915_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 18a45e7a3d7c..64e0ea4bef67 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++

[Bug 107152] GPU fault detected: 146 / VM_CONTEXT1_PROTECTION_FAULT / ring gfx timeout

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107152 --- Comment #8 from Andrey Grodzovsky --- dwanger, i think you already have all the trace tools installed from previous debug sessions so this should be quick for you - Update to latest kernel from

Re: [PATCH v2] drm/scheduler: fix timeout worker setup for out of order job completions

2018-08-03 Thread Christian König
Am 03.08.2018 um 16:29 schrieb Lucas Stach: drm_sched_job_finish() is a work item scheduled for each finished job on a unbound system workqueue. This means the workers can execute out of order with regard to the real hardware job completions. If this happens queueing a timeout worker for the

[Bug 107432] Periodic complete system lockup with Vega M and Kernel 4.18-rc6+

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107432 --- Comment #7 from Robert Strube --- (In reply to Michel Dänzer from comment #6) > Well, https://bugs.freedesktop.org/attachment.cgi?id=140903 definitely shows > an amdgpu issue exacerbating the memory pressure situation — it tries to >

Re: [PATCH v2] drm/scheduler: fix timeout worker setup for out of order job completions

2018-08-03 Thread Lucas Stach
Am Montag, den 06.08.2018, 14:57 +0200 schrieb Christian König: > Am 03.08.2018 um 16:29 schrieb Lucas Stach: > > drm_sched_job_finish() is a work item scheduled for each finished job on > > a unbound system workqueue. This means the workers can execute out of order > > with regard to the real

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-03 Thread Gustavo Padovan
On Fri, Aug 03, 2018 at 12:42:15PM -0400, Sean Paul wrote: > On Thu, Aug 02, 2018 at 08:09:51AM -0300, Gustavo Padovan wrote: > > Hi Haneen, > > > > On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > > > This patch implement the necessary functions to compute and add CRCs > > >

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-03 Thread Sean Paul
On Fri, Aug 03, 2018 at 10:36:05PM +0300, Haneen Mohammed wrote: > On Fri, Aug 03, 2018 at 12:53:36PM -0400, Sean Paul wrote: > > On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > > > This patch implement the necessary functions to compute and add CRCs > > > entries: > > > > > >

Re: [PATCH] drm/vkms: Release pages_lock before return

2018-08-03 Thread Sean Paul
On Fri, Aug 03, 2018 at 11:11:42PM +0300, Haneen Mohammed wrote: > Release pages_lock before return when vkms_obj->vaddr is NULL. > This patch fixes: 6c234fe37c57 ("drm/vkms: Implement CRC debugfs API"). > > Signed-off-by: Haneen Mohammed Thanks for fixing this up. Pushed to drm-misc-next.

[Bug 107152] GPU fault detected: 146 / VM_CONTEXT1_PROTECTION_FAULT / ring gfx timeout

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107152 --- Comment #10 from dwagner --- (In reply to Andrey Grodzovsky from comment #8) > dwanger, i think you already have all the trace tools installed from > previous debug sessions so this should be quick for you Yes, and I tried really hard (with

[Bug 91880] Radeonsi on Grenada cards (r9 390) exceptionally unstable and poorly performing

2018-08-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91880 --- Comment #204 from tkdestroyer2+bugs-freedesk...@gmail.com --- (In reply to iburnth3playb00k from comment #203) > (In reply to chris from comment #188) > > I suffered pretty much all of the issue listed in this thread for many weeks > > since

Re: [PATCH v5 2/2] dt-bindings: Add Truly NT35597 panel bindings

2018-08-03 Thread abhinavk
Hi Linus Thanks for your valuable comments. Yes, we agree with your comments here and will address them. Some details below on how we will take care of it. Thanks Abhinav On 2018-08-03 04:20, Linus Walleij wrote: On Fri, Aug 3, 2018 at 4:49 AM Abhinav Kumar wrote: From:

  1   2   >