Re: [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-22 Thread Mike Rapoport
On Mon, Nov 19, 2018 at 11:15:15PM +0530, Souptick Joarder wrote: > On Mon, Nov 19, 2018 at 9:56 PM Mike Rapoport wrote: > > > > On Mon, Nov 19, 2018 at 08:43:09PM +0530, Souptick Joarder wrote: > > > Hi Mike, > > > > > > On Sat, Nov 17, 2018 at 8:07 PM Matthew Wilcox > > > wrote: > > > > > > >

[PATCHv5 4/6] drm/omap: fix incorrect union usage

2018-11-22 Thread Sebastian Reichel
The DSI encoder sets dssdev->ops->dsi.set_config, which is stored at the same offset as dssdev->ops->hdmi.set_hdmi_mode. The code in omap_encoder only checks if dssdev->ops->hdmi.set_hdmi_mode is NULL. Due to the way union works, it won't be NULL if dsi.set_config is set. This means dsi_set_config

WARNING in vkms_plane_duplicate_state

2018-11-22 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:92b419289cee Merge tag 'riscv-for-linus-4.20-rc4' of git:/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17ed377b40 kernel config: https://syzkaller.appspot.com/x/.config?x=73e2bc0cb6463446

[PATCH 0/3] drm: Add panel support for PDA 91-00156-A0

2018-11-22 Thread Eugen.Hristev
Hello, This patch series adds support for PDA (Precision Design Associates, Inc.) vendor, and for the PDA 91-00156-A0 simple panel, together with the bindings. The series is on top of http://anongit.freedesktop.org/git/drm/drm.git drm-next branch. Cristian Birsan (1): dt-bindings: drm/panel:

[PATCH v2 2/9] drm/msm/mdp4: allocate blank_cursor_no with MSM_BO_SCANOUT flag

2018-11-22 Thread Jonathan Marek
For allocation in contiguous memory when the GPU has MMU but not mdp4. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c

Re: [PATCH 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-22 Thread Vivek Gautam
Hi Tomasz, Jordan, On 11/21/2018 9:18 AM, Tomasz Figa wrote: Hi Jordan, Vivek, On Wed, Nov 21, 2018 at 12:41 AM Jordan Crouse wrote: On Tue, Nov 20, 2018 at 03:24:37PM +0530, Vivek Gautam wrote: dma_map_sg() expects a DMA domain. However, the drm devices have been traditionally using

Re: [PATCH 0/9] Use vm_insert_range

2018-11-22 Thread Boris Ostrovsky
On 11/21/18 1:24 AM, Souptick Joarder wrote: > On Thu, Nov 15, 2018 at 9:09 PM Souptick Joarder wrote: >> Previouly drivers have their own way of mapping range of >> kernel pages/memory into user vma and this was done by >> invoking vm_insert_page() within a loop. >> >> As this pattern is common

Re: [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-22 Thread Matthew Wilcox
On Wed, Nov 21, 2018 at 04:19:11AM -0700, William Kucharski wrote: > Could you add a line to the description explicitly stating that a failure > to insert any page in the range will fail the entire routine, something > like: > > > * This allows drivers to insert range of kernel pages they've

Re: [PATCH v3] drm/rockchip: update cursors asynchronously through atomic.

2018-11-22 Thread Michael Zoran
On Fri, 2018-11-23 at 11:27 +0900, Tomasz Figa wrote: > > The point here is not about setting and resetting the plane->fb > pointer. It's about what happens inside > drm_atomic_set_fb_for_plane(). > > It calls drm_framebuffer_get() for the new fb and > drm_framebuffer_put() for the old fb. In

[PATCH v2 6/9] drm/msm/adreno: add a2xx

2018-11-22 Thread Jonathan Marek
derived from the a3xx driver and tested on the following hardware: imx51-zii-rdu1 (a200 with 128kb gmem) imx53-qsrb (a200) msm8060-tenderloin (a220) Signed-off-by: Jonathan Marek Reviewed-by: Jordan Crouse --- v2: -fail when MMU is not present (instead of just a warning, matches a3xx) -removed

Re: [PATCH] drm/ast: change resolution may cause screen blurred

2018-11-22 Thread Jean Delvare
On Wed, 3 Oct 2018 14:57:47 +0800, Y.C. Chen wrote: > From: "Y.C. Chen" > > The value of pitches is not correct while calling mode_set. > The issue we found so far on following system: > - Debian8 with XFCE Desktop > - Ubuntu with KDE Desktop > - SUSE15 with KDE Desktop > > Signed-off-by: Y.C.

[PATCH v2 7/9] drm/msm: implement a2xx mmu

2018-11-22 Thread Jonathan Marek
A2XX has its own very simple MMU. Added a msm_use_mmu() function because we can't rely on iommu_present to decide to use MMU or not. Signed-off-by: Jonathan Marek --- v2: -tlb flush from cpu every time the page table is updated -keep missing MMU error path, in case MMU init fails -small

RE: [PATCH 4/5] drm: rcar-du: Add R8A7744 support

2018-11-22 Thread Fabrizio Castro
Hello Laurent, > From: Laurent Pinchart > Sent: 15 October 2018 23:25 > Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support > > Hi Fabrizio, > > Thank you for the patch. > > On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote: > > From: Biju Das > > > > Add support for the

[PATCH] drm/amd/display/amdgpu_dm/amdgpu_dm.c: Remove duplicate header

2018-11-22 Thread Brajeswar Ghosh
Remove dm_services_types.h which is included more than once Signed-off-by: Brajeswar Ghosh --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH v2] drm: set is_master to 0 upon drm_new_set_master() failure

2018-11-22 Thread Sergio Correia
When drm_new_set_master() fails, set is_master to 0, to prevent a possible NULL pointer deref. Here is a problematic flow: we check is_master in drm_is_current_master(), then proceed to call drm_lease_owner() passing master. If we do not restore is_master status when drm_new_set_master() fails,

[PATCH] drm/amd/display: Remove duplicate header

2018-11-22 Thread Brajeswar Ghosh
Remove dce/dce_mem_input.h which is included more than once Signed-off-by: Brajeswar Ghosh --- drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c

[PATCHv5 1/6] drm/omap: use DRM_DEBUG_DRIVER instead of CORE

2018-11-22 Thread Sebastian Reichel
This macro is only used by omapdrm, which should print debug messages using the DRIVER category instead of the default CORE category. Acked-by: Pavel Machek Tested-by: Tony Lindgren Tested-by: Pavel Machek Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_drv.h | 4 ++-- 1

Re: [PATCH 0/9] Use vm_insert_range

2018-11-22 Thread Boris Ostrovsky
On 11/21/18 2:56 PM, Souptick Joarder wrote: > On Thu, Nov 22, 2018 at 1:08 AM Boris Ostrovsky > wrote: >> On 11/21/18 1:24 AM, Souptick Joarder wrote: >>> On Thu, Nov 15, 2018 at 9:09 PM Souptick Joarder >>> wrote: Previouly drivers have their own way of mapping range of kernel

[PATCH] drm/amd/amdgpu: Remove duplicate header

2018-11-22 Thread Brajeswar Ghosh
Remove gca/gfx_8_0_sh_mask.h which is included more than once Signed-off-by: Brajeswar Ghosh --- drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c b/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c index

[PATCH] drm/amd/amdkfd: Remove duplicate header

2018-11-22 Thread Brajeswar Ghosh
Remove gca/gfx_8_0_enum.h which is included more than once Signed-off-by: Brajeswar Ghosh --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_vi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_vi.c

[PATCH 2/3] dt-bindings: drm/panel: simple: add support for PDA 91-00156-A0

2018-11-22 Thread Eugen.Hristev
From: Cristian Birsan PDA 91-00156-A0 5.0 is a 5.0" WVGA TFT LCD panel. This panel with backlight is found in PDA 5" LCD screen (TM5000 series or AC320005-5). Adding Device Tree bindings for this panel. Signed-off-by: Cristian Birsan ---

[PATCH v3] drm/ast: fixed reading monitor EDID not stable issue

2018-11-22 Thread Y.C. Chen
From: "Y.C. Chen" v1: over-sample data to increase the stability with some specific monitors v2: refine to avoid infinite loop v3: remove un-necessary "volatile" declaration Signed-off-by: Y.C. Chen --- drivers/gpu/drm/ast/ast_mode.c | 34 -- 1 file changed, 28

[PATCHv5 0/6] omapdrm: DSI command mode panel support

2018-11-22 Thread Sebastian Reichel
Hi, Here is another round of the DSI command mode panel patchset integrating the feedback from PATCHv4. The patches are based on 4.20-rc1 + fixes from Laurent and Tony. I dropped the patches for OMAP3 support (it needs a workaround for a hardware bug) and for automatic display rotation. They

[PATCH 3/3] drm/panel: simple: add support for PDA 91-00156-A0 panel

2018-11-22 Thread Eugen.Hristev
PDA 91-00156-A0 5.0 is a 5.0" WVGA TFT LCD panel. This panel with backlight is found in PDA 5" LCD screen (TM5000 series or AC320005-5). Signed-off-by: Eugen Hristev --- drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff --git

[PATCH v2 4/9] drm/msm: use contiguous vram for MSM_BO_SCANOUT when possible

2018-11-22 Thread Jonathan Marek
Makes it possible to have MMU for GPU but not display. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/msm_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index d97f6ecb0531..6657453a3a58 100644 ---

[PATCHv5 2/6] drm/omap: populate DSI platform bus earlier

2018-11-22 Thread Sebastian Reichel
After the changes from 4.20 the DSI encoder tries to find the attached panel before populating the DSI bus. If the panel is not found -EPROBE_DEFER is returned, so the DSI bus is never populated and the panel never added. Fix this by populating the DSI bus before searching for the video sink in

Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-22 Thread Kishon Vijay Abraham I
Hi Maxime, On 21/11/18 3:41 PM, Maxime Ripard wrote: > Hi Kishon, > > On Tue, Nov 20, 2018 at 11:02:34AM +0530, Kishon Vijay Abraham I wrote: +static int cdns_dphy_config_from_opts(struct phy *phy, +struct phy_configure_opts_mipi_dphy *opts, +

[PATCH 1/3] dt-bindings: add vendor prefix for PDA Precision Design Associates, Inc.

2018-11-22 Thread Eugen.Hristev
Precision Design Associates, Inc. (PDA) manufactures standard and custom capacitive touch screens, LCD's embedded controllers and custom embedded software. They specialize in industrial, rugged and outdoor applications. Website: http://www.pdaatl.com/ Signed-off-by: Eugen Hristev ---

ASPEED graphics card: ast_pci_probe causes RCU stalls

2018-11-22 Thread poza
Hi, we have on-board ASPEED Graphics card on PCIe. kernel version: 4.16 I select following drive to enable ast graphics support. Symbol: DRM_AST [=y]

[PATCH] drm/amd/amdgpu: Remove duplicate header

2018-11-22 Thread Brajeswar Ghosh
Remove drm/drm_fb_helper.h which is included more than once Signed-off-by: Brajeswar Ghosh --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h index

[PATCH v2 3/9] drm/msm/mdp4: add lcdc-align-lsb flag to control lane alignment

2018-11-22 Thread Jonathan Marek
Controls which of the 8 lanes are used for 6 bit color. Signed-off-by: Jonathan Marek --- .../gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 22 --- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c

[PATCH] drm/pl111: add of_node_put()

2018-11-22 Thread Yangtao Li
of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init() doesn't do that, so fix it. Signed-off-by: Yangtao Li --- drivers/gpu/drm/pl111/pl111_vexpress.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCHv5 5/6] drm/omap: add framedone interrupt support

2018-11-22 Thread Sebastian Reichel
This prepares framedone interrupt handling for manual display update support. Acked-by: Pavel Machek Tested-by: Tony Lindgren Tested-by: Pavel Machek Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_crtc.c | 50 +

Re: [PATCH] drm: restore is_master upon failure in drm_new_set_master()

2018-11-22 Thread Sergio Correia
On Wed, Nov 21, 2018 at 6:55 AM Daniel Vetter wrote: > > On Sun, Nov 18, 2018 at 08:57:20PM -0300, Sergio Correia wrote: > > When drm_new_set_master() fails, we restore the old master, however we may > > have changed the is_master flag to 1, before failing, and it may be the > > case it was 0

Re: [linux-sunxi] [PATCH] drm/sun4i: wait on implicit fence before display

2018-11-22 Thread Jernej Škrabec
Hi, Dne ponedeljek, 19. november 2018 ob 15:33:11 CET je Qiang Yu napisal(a): > Render like lima will attach a fence to the framebuffer > dma_buf, display like sun4i should wait it finish before > show the framebuffer. Otherwise tearing will be observed. Please resend this patch to all emails

[PATCH] drm/meson: add support for 1080p25 mode

2018-11-22 Thread Christian Hewitt
This essential mode for PAL users is missing, so add it. Signed-off-by: Christian Hewitt --- drivers/gpu/drm/meson/meson_venc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c index acbbad3..ab16046 100644 ---

[PATCH v3] drm/rockchip: update cursors asynchronously through atomic.

2018-11-22 Thread Helen Koike
Hi Tomasz, On 11/20/18 4:48 AM, Tomasz Figa wrote: > Hi Helen, > > On Tue, Nov 20, 2018 at 4:08 AM Helen Koike wrote: >> >> From: Enric Balletbo i Serra >> >> Add support to async updates of cursors by using the new atomic >> interface for that. >> >> Signed-off-by: Enric Balletbo i Serra >>

[PATCHv5 6/6] drm/omap: add support for manually updated displays

2018-11-22 Thread Sebastian Reichel
This adds the required infrastructure for manually updated displays, such as DSI command mode panels. While those panels often support partial updates we currently always do a full refresh. The display will be refreshed when something calls the dirty callback, such as libdrm's drmModeDirtyFB().

[PATCHv5 3/6] drm/omap: don't check dispc timings for DSI

2018-11-22 Thread Sebastian Reichel
While most display types only forward their VM to the DISPC, this is not true for DSI. DSI calculates the VM for DISPC based on its own, but it's not identical. Actually the DSI VM is not even a valid DISPC VM making this check fail. Let's restore the old behaviour and avoid checking the DISPC VM

Re: [PATCH v5 08/12] dt-bindings: mediatek: Change the binding for mmsys clocks

2018-11-22 Thread Matthias Brugger
On 21/11/2018 17:46, Stephen Boyd wrote: > Quoting Rob Herring (2018-11-19 11:15:16) >> On Sun, Nov 18, 2018 at 11:12 AM Matthias Brugger >> wrote: >>> On 11/17/18 12:15 AM, Rob Herring wrote: On Fri, Nov 16, 2018 at 01:54:45PM +0100, matthias@kernel.org wrote: > -#clock-cells

RE: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support

2018-11-22 Thread Fabrizio Castro
Hello Laurent, > From: linux-renesas-soc-ow...@vger.kernel.org > On Behalf Of Laurent Pinchart > Sent: 17 October 2018 07:52 > Subject: Re: [PATCH v2 3/5] drm: rcar-du: Add r8a77470 support > > Hi Fabrizio, > > Thank you for the patch. > > On Tuesday, 16 October 2018 19:58:59 EEST Fabrizio

Re: [PATCH 0/9] Use vm_insert_range

2018-11-22 Thread Souptick Joarder
On Thu, Nov 22, 2018 at 1:08 AM Boris Ostrovsky wrote: > > On 11/21/18 1:24 AM, Souptick Joarder wrote: > > On Thu, Nov 15, 2018 at 9:09 PM Souptick Joarder > > wrote: > >> Previouly drivers have their own way of mapping range of > >> kernel pages/memory into user vma and this was done by > >>

[PATCH v2 1/9] drm/msm/mdp4: only use lut_clk on mdp4.2+

2018-11-22 Thread Jonathan Marek
Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c index ae25d763cd8c..8f765f284d11 100644 ---

Re: [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-22 Thread William Kucharski
> On Nov 21, 2018, at 5:35 AM, Matthew Wilcox wrote: > > It's probably better to be more explicit and answer Randy's question: > > * If we fail to insert any page into the vma, the function will return > * immediately leaving any previously-inserted pages present. Callers > * from the mmap

Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic.

2018-11-22 Thread Kuehling, Felix
On 2018-10-22 1:23 p.m., Arun KS wrote: > Remove managed_page_count_lock spinlock and instead use atomic > variables. > > Suggested-by: Michal Hocko > Suggested-by: Vlastimil Babka > Signed-off-by: Arun KS Acked-by: Felix Kuehling Regards,   Felix > > --- > As discussed here, >

[PATCH v2 5/9] drm/msm: add headless gpu device (for imx5)

2018-11-22 Thread Jonathan Marek
This patch allows using drm/msm without qcom display hardware. This is especially useful for iMX5 hardware, which has a a2xx GPU but uses the imx-drm driver for display. Signed-off-by: Jonathan Marek --- v2: added commit message and removed unnecessary comment drivers/gpu/drm/msm/Kconfig

Re: [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-22 Thread William Kucharski
Could you add a line to the description explicitly stating that a failure to insert any page in the range will fail the entire routine, something like: > * This allows drivers to insert range of kernel pages they've allocated > * into a user vma. This is a generic function which drivers can use >

Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic.

2018-11-22 Thread Guo Ren
On Mon, Oct 22, 2018 at 10:53:22PM +0530, Arun KS wrote: > Remove managed_page_count_lock spinlock and instead use atomic > variables. > > Suggested-by: Michal Hocko > Suggested-by: Vlastimil Babka > Signed-off-by: Arun KS > > --- > As discussed here, >

Re: [PATCH v2 8/9] phy: Add Cadence D-PHY support

2018-11-22 Thread Kishon Vijay Abraham I
Hi, On 21/11/18 7:17 PM, Maxime Ripard wrote: > Hi Kishon, > > On Wed, Nov 21, 2018 at 03:59:43PM +0530, Kishon Vijay Abraham I wrote: >> On 21/11/18 3:41 PM, Maxime Ripard wrote: >>> Hi Kishon, >>> >>> On Tue, Nov 20, 2018 at 11:02:34AM +0530, Kishon Vijay Abraham I wrote: >> +static int

Re: [[PATCH v2]] drm/ast: fixed reading monitor EDID not stable issue

2018-11-22 Thread 陳雅正
Hi Dave, Thanks for your feedback. No issue found actually if I remove "volatile" on my platform. In my experience, if the value is volatile, adding "volatile" will be safer and no harm, that is why I add it by default. If you think it is not necessary, it's ok for me to remove it. Regards, Y.C.

[PATCH v2 8/9] drm/msm/mdp5: add config for msm8917

2018-11-22 Thread Jonathan Marek
Add the mdp5_cfg_hw entry for MDP5 version v1.15 found on msm8917. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 86 1 file changed, 86 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c

[PATCH v2 9/9] drm/msm: set priv->kms to NULL before uninit

2018-11-22 Thread Jonathan Marek
otherwise, priv->kms is non-NULL and msm_drm_uninit will cause a panic. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/msm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 5d7304b5f399..fd5769e4c42a 100644 ---

Re: [PATCH] drm/dp_mst: Skip validating ports during destruction, just ref

2018-11-22 Thread Daniel Vetter
On Tue, Nov 13, 2018 at 11:47 PM Lyude Paul wrote: > > Jerry Zuo pointed out a rather obscure hotplugging issue that it seems I > accidentally introduced into DRM two years ago. > > Pretend we have a topology like this: > > |- DP-1: mst_primary >|- DP-4: active display >|- DP-5:

Re: [PATCH 0/9] drm: remove deprecated functions

2018-11-22 Thread Daniel Vetter
On Wed, Nov 21, 2018 at 08:21:29PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Wednesday, 21 November 2018 11:42:33 EET Daniel Vetter wrote: > > On Thu, Nov 15, 2018 at 11:38:35PM +0100, Linus Walleij wrote: > > > On Thu, Nov 15, 2018 at 11:17 PM Fernando Ramos wrote: > > >> One of the

[PATCH v3 2/3] drm/msm/dpu: Integrate interconnect API in MDSS

2018-11-22 Thread Sravanthi Kollukuduru
The interconnect framework is designed to provide a standard kernel interface to control the settings of the interconnects on a SoC. The interconnect API uses a consumer/provider-based model, where the providers are the interconnect buses and the consumers could be various drivers. MDSS is one

Re: [PATCH] drm/sun4i: wait on implicit fence before display

2018-11-22 Thread Daniel Vetter
On Thu, Nov 22, 2018 at 09:44:17AM +0800, Qiang Yu wrote: > Render like lima will attach a fence to the framebuffer > dma_buf, display like sun4i should wait it finish before > show the framebuffer. Otherwise tearing will be observed. > > Signed-off-by: Qiang Yu Thanks for submitting this fix,

Re: [PATCH] drm: Merge drm_info.c into drm_debugfs.c

2018-11-22 Thread Daniel Vetter
On Wed, Nov 21, 2018 at 10:35:10PM +0100, Daniel Vetter wrote: > Ever since > > commit cb6458f97b53d7f73043206c18014b3ca63ac345 > Author: Daniel Vetter > Date: Thu Aug 8 15:41:34 2013 +0200 > > drm: remove procfs code, take 2 > > Having the code shared between procfs and debugfs in the

[Xen-devel][PATCH 2/3] drm/xen-front: Use Xen common shared buffer implementation

2018-11-22 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Use page directory based shared buffer implementation now available as common code for Xen frontend drivers. Signed-off-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/Kconfig | 1 + drivers/gpu/drm/xen/Makefile | 1 -

[Xen-devel][PATCH 1/3] xen: Introduce shared buffer helpers for page directory...

2018-11-22 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko based frontends. Currently the frontends which implement similar code for sharing big buffers between frontend and backend are para-virtualized DRM and sound drivers. Both define the same way to share grant references of a data buffer with the corresponding backend

[Xen-devel][PATCH 3/3] ALSA: xen-front: Use Xen common shared buffer implementation

2018-11-22 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Use page directory based shared buffer implementation now available as common code for Xen frontend drivers. Signed-off-by: Oleksandr Andrushchenko --- sound/xen/Kconfig | 1 + sound/xen/Makefile | 1 - sound/xen/xen_snd_front.c

Re: [PATCH v2] drm: set is_master to 0 upon drm_new_set_master() failure

2018-11-22 Thread Daniel Vetter
On Thu, Nov 22, 2018 at 02:33:29AM -0300, Sergio Correia wrote: > When drm_new_set_master() fails, set is_master to 0, to prevent a > possible NULL pointer deref. > > Here is a problematic flow: we check is_master in drm_is_current_master(), > then proceed to call drm_lease_owner() passing

Re: [PATCH] drm/meson: Fixes for drm_crtc_vblank_on/off support

2018-11-22 Thread Neil Armstrong
On 21/11/2018 18:15, Neil Armstrong wrote: > Since Linux 4.17, calls to drm_crtc_vblank_on/off are mandatory, and we get > a warning when ctrc is disabled : > " driver forgot to call drm_crtc_vblank_off()" > > But, the vsync IRQ was not totally disabled due the transient hardware > state and

[PATCH] drm/sched: revert "fix timeout handling v2"

2018-11-22 Thread Christian König
This reverts commit 0efd2d2f68cd5dbddf4ecd974c33133257d16a8e. It's still causing problems for V3D. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 31 +-- 1 file changed, 1 insertion(+), 30 deletions(-) diff --git

Re: [PATCH 01/15] drm/vblank: Allow dynamic per-crtc max_vblank_count

2018-11-22 Thread Daniel Vetter
On Wed, Nov 21, 2018 at 06:46:57PM +0200, Ville Syrjälä wrote: > On Wed, Nov 21, 2018 at 05:22:49PM +0100, Daniel Vetter wrote: > > On Wed, Nov 21, 2018 at 5:16 PM Ville Syrjälä > > wrote: > > > > > > On Wed, Nov 21, 2018 at 04:19:36PM +0100, Daniel Vetter wrote: > > > > On Wed, Nov 21, 2018 at

[Bug 107823] [amdgpu/displayport] Blackscreen on native resolution

2018-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107823 --- Comment #19 from Jan Burgmeier --- Hi, the video looks good. I don't know why you do not see the error. I am unable to get a picture after boot because the says "Frequency out of range". At the start of next week I will retest and give

[PATCH v3 1/3] drm/msm/dpu: clean up references of DPU custom bus scaling

2018-11-22 Thread Sravanthi Kollukuduru
Since the upstream interconnect bus framework has landed upstream, the existing references of custom bus scaling needs to be cleaned up. Changes in v2: - Fixed build error due to partial clean up Changes in v3: - Condense multiple lines into a single line (Sean Paul)

Re: [PATCH] drm/prime: Fix drm_gem_prime_mmap() stack use

2018-11-22 Thread Daniel Vetter
On Wed, Nov 21, 2018 at 07:02:15PM +0100, Noralf Trønnes wrote: >drivers/gpu/drm/drm_prime.c: In function 'drm_gem_prime_mmap': > >> drivers/gpu/drm/drm_prime.c:688:1: warning: the frame size of 1592 bytes > >> is larger than 1024 bytes [-Wframe-larger-than=] > > Fix by allocating on the

[PATCH v3 0/3] Use interconnect API in MDSS on SDM845

2018-11-22 Thread Sravanthi Kollukuduru
The interconnect API provides an interface for consumer drivers to express their bandwidth needs in the SoC. This data is aggregated and the on-chip interconnect hardware is configured to the appropriate power/performance profile. MDSS is one of the interconnect consumers which uses the

[PATCH v3 3/3] dt-bindings: msm/disp: Introduce interconnect bindings for MDSS on SDM845

2018-11-22 Thread Sravanthi Kollukuduru
Add interconnect properties such as interconnect provider specifier , the edge source and destination ports which are required by the interconnect API to configure interconnect path for MDSS. Changes in v2: - none Changes in v3: - Remove common property definitions (Rob Herring)

Re: [PATCH] drm/fb-helper/generic: Only restore when in use

2018-11-22 Thread Daniel Vetter
On Wed, Nov 21, 2018 at 05:56:42PM +0100, Noralf Trønnes wrote: > On drm_driver->last_close the generic fbdev emulation will restore fbdev > regardless of it being used or not. This is a problem for e-ink displays > which don't want to be overwritten with zeroes when DRM userspace closes. > >

[PATCH v3 0/3] drm/connector: Provide generic support for underscan

2018-11-22 Thread Boris Brezillon
Hello, This is an attempt at providing generic support for underscan connector props. We already have 3 drivers defining the same underscan, underscan vborder and underscan hborder properties (amd, radeon and nouveau) and I am about to add a new one, hence my proposal to put the prop parsing code

[PATCH v3 1/3] drm/connector: Add generic underscan properties

2018-11-22 Thread Boris Brezillon
We have 3 drivers defining the "underscan", "underscan hborder" and "underscan vborder" properties (radeon, amd and nouveau) and we are about to add the same kind of thing in VC4. Define generic underscan props and add new fields to the drm_connector state so that the property parsing logic can

Re: [PATCH v8 1/7] mm, devm_memremap_pages: Mark devm_memremap_pages() EXPORT_SYMBOL_GPL

2018-11-22 Thread Michal Hocko
On Tue 20-11-18 15:12:54, Dan Williams wrote: > devm_memremap_pages() is a facility that can create struct page entries > for any arbitrary range and give drivers the ability to subvert core > aspects of page management. > > Specifically the facility is tightly integrated with the kernel's memory

[PATCH v3 3/3] drm/vc4: Attach underscan props to the HDMI connector

2018-11-22 Thread Boris Brezillon
Now that the plane code takes the underscan setup into account, we can safely attach the underscan props to the HDMI connector. We also take care of filling AVI infoframes correctly to expose the top/botton/left/right bar. Note that these underscan props match pretty well the

[PATCH v3 2/3] drm/vc4: Take underscan setup into account when updating planes

2018-11-22 Thread Boris Brezillon
Applying an underscan setup is just a matter of scaling all planes appropriately and adjusting the CRTC X/Y offset to account for the horizontal and vertical border. Create an vc4_plane_underscan_adj() function doing that and call it from vc4_plane_setup_clipping_and_scaling() so that we are

Re: [PATCH 7/7] drm/syncobj: use the timeline point in drm_syncobj_find_fence

2018-11-22 Thread Christian König
Am 22.11.18 um 07:52 schrieb zhoucm1: On 2018年11月15日 19:12, Christian König wrote: Implement finding the right timeline point in drm_syncobj_find_fence. Signed-off-by: Christian König ---   drivers/gpu/drm/drm_syncobj.c | 10 +-   1 file changed, 9 insertions(+), 1 deletion(-) diff

[PULL] drm-intel-fixes

2018-11-22 Thread Joonas Lahtinen
Hi Dave, Here's the -fixes for 4.20-rc4. Stuck backlight/flickering fix for DSI screen and GPU hang fix for SNB are the main user visible ones. Then two more fixes to prevent GPU hangs in more rare scenarios. Regards, Joonas *** drm-intel-fixes-2018-11-22: - Fix for fastboot DSI panel boot

Re: [PATCH 2/2] gpu/i915: use HMM mirror for userptr buffer object.

2018-11-22 Thread Joonas Lahtinen
Hi Jerome, Bit late reply, but here goes :) We're working quite hard to avoid pinning any pages unless they're in the GPU page tables. And when they are in the GPU page tables, they must be pinned for whole of that duration, for the reason that our GPUs can not take a fault. And to avoid

[PATCH] drm/sched: revert "fix timeout handling v2" v2

2018-11-22 Thread Christian König
This reverts commit 0efd2d2f68cd5dbddf4ecd974c33133257d16a8e. It's still causing problems for V3D. v2: keep rearming the timeout. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 27 +-- 1 file changed, 1 insertion(+), 26 deletions(-) diff

[Bug 108832] Cursor flickering on switching between cursor types

2018-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108832 Bug ID: 108832 Summary: Cursor flickering on switching between cursor types Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [alsa-devel] [Xen-devel][PATCH 3/3] ALSA: xen-front: Use Xen common shared buffer implementation

2018-11-22 Thread Takashi Iwai
On Thu, 22 Nov 2018 11:02:30 +0100, Oleksandr Andrushchenko wrote: > > @@ -214,12 +221,19 @@ static void stream_clear(struct > xen_snd_front_pcm_stream_info *stream) > stream->out_frames = 0; > atomic_set(>hw_ptr, 0); > xen_snd_front_evtchnl_pair_clear(stream->evt_pair); > -

[Bug 102637] Radeon 9600 Pro (Mac Version) shows funky colours on console and X (ppc64)

2018-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102637 erhar...@mailbox.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Xen-devel][PATCH 2/3] drm/xen-front: Use Xen common shared buffer implementation

2018-11-22 Thread Daniel Vetter
On Thu, Nov 22, 2018 at 12:02:29PM +0200, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Use page directory based shared buffer implementation > now available as common code for Xen frontend drivers. > > Signed-off-by: Oleksandr Andrushchenko > --- >

[PATCH 2/2] drm/atomic-helper: WARN if fake_commit->hw_done is not completed as expected

2018-11-22 Thread Ville Syrjala
From: Ville Syrjälä For real commits we WARN if ->hw_done hasn't been completed by the time drm_atomic_helper_commit_cleanup_done() is called. Let's do the same for the fake commit. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic_helper.c | 4 +++- 1 file changed, 3 insertions(+),

[PATCH 1/2] drm/atomic-helper: Complete fake_commit->flip_done potentially earlier

2018-11-22 Thread Ville Syrjala
From: Ville Syrjälä Consider the following scenario: 1. nonblocking enable crtc 2. wait for the event 3. nonblocking disable crtc On i915 this can lead to a spurious -EBUSY from step 3 on account of non-enabled planes getting the fake_commit in step 1 and we don't complete the fake_commit->

Re: [PATCH AUTOSEL 4.9 08/17] drm/edid: Add 6 bpc quirk for BOE panel.

2018-11-22 Thread Sasha Levin
On Wed, Nov 21, 2018 at 10:33:18AM +0100, Daniel Vetter wrote: On Wed, Nov 21, 2018 at 10:31 AM Daniel Vetter wrote: On Tue, Nov 13, 2018 at 12:52:14AM -0500, Sasha Levin wrote: > From: "Lee, Shawn C" > > [ Upstream commit 922dceff8dc1fb4dafc9af78139ba65671408103 ] > > BOE panel (ID: 0x0771)

[Bug 201763] amdgpu: [powerplay] VBIOS did not find boot engine clock value in dependency table. Using Memory DPM level 0!

2018-11-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201763 --- Comment #2 from Michel Dänzer (mic...@daenzer.net) --- From the dmesg output, it looks like the AMD GPU is powered off most of the time. Do the freezes happen when you explicitly use it for something, e.g. for a game via DRI_PRIME=1? -- You

Re: [PATCH v8 1/7] mm, devm_memremap_pages: Mark devm_memremap_pages() EXPORT_SYMBOL_GPL

2018-11-22 Thread Christoph Hellwig
On Thu, Nov 22, 2018 at 02:30:13PM +0100, Michal Hocko wrote: > Whoever needs a wrapper around arch_add_memory can do so because this > symbol has no restriction for the usage. arch_add_memory is not exported, and it really should not be. ___ dri-devel

Re: [Intel-gfx] [PATCH 1/3] mm: Check if mmu notifier callbacks are allowed to fail

2018-11-22 Thread Chris Wilson
Quoting Daniel Vetter (2018-11-22 16:51:04) > Just a bit of paranoia, since if we start pushing this deep into > callchains it's hard to spot all places where an mmu notifier > implementation might fail when it's not allowed to. Most callers could handle the failure correctly. It looks like the

[Bug 108832] Cursor flickering on switching between cursor types

2018-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108832 --- Comment #1 from Dieter Nützel --- Maybe duplicate of Bug #106175. Can you please verify if patch from comment #55, attachment 142558 solve it? -- You are receiving this mail because: You are the assignee for the

Re: [PATCH 2/2] gpu/i915: use HMM mirror for userptr buffer object.

2018-11-22 Thread Daniel Vetter
On Thu, Nov 22, 2018 at 03:59:50PM +0200, Joonas Lahtinen wrote: > Hi Jerome, > > Bit late reply, but here goes :) > > We're working quite hard to avoid pinning any pages unless they're in > the GPU page tables. And when they are in the GPU page tables, they must > be pinned for whole of that

Re: [PATCH 1/2] drm/atomic-helper: Complete fake_commit->flip_done potentially earlier

2018-11-22 Thread Maarten Lankhorst
Op 22-11-18 om 15:34 schreef Ville Syrjala: > From: Ville Syrjälä > > Consider the following scenario: > 1. nonblocking enable crtc > 2. wait for the event > 3. nonblocking disable crtc > > On i915 this can lead to a spurious -EBUSY from step 3 on > account of non-enabled planes getting the

[PATCH v2] drm/meson: Fixes for drm_crtc_vblank_on/off support

2018-11-22 Thread Neil Armstrong
Since Linux 4.17, calls to drm_crtc_vblank_on/off are mandatory, and we get a warning when ctrc is disabled : " driver forgot to call drm_crtc_vblank_off()" But, the vsync IRQ was not totally disabled due the transient hardware state and specific interrupt line, thus adding proper IRQ masking

[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

2018-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106175 --- Comment #60 from Brandon Wright --- > There are larger problems within amdgpu_dm's commit tail that if addressed > should resolve this issue for compton I'd imagine. Honestly, I don't care about compton. I don't think you realize the

Re: [PATCH v8 1/7] mm, devm_memremap_pages: Mark devm_memremap_pages() EXPORT_SYMBOL_GPL

2018-11-22 Thread Christoph Hellwig
On Thu, Nov 22, 2018 at 05:38:58PM +0100, Christoph Hellwig wrote: > On Thu, Nov 22, 2018 at 02:30:13PM +0100, Michal Hocko wrote: > > Whoever needs a wrapper around arch_add_memory can do so because this > > symbol has no restriction for the usage. > > arch_add_memory is not exported, and it

Re: [PATCH] drm/prime: Fix drm_gem_prime_mmap() stack use

2018-11-22 Thread Noralf Trønnes
Den 22.11.2018 10.06, skrev Daniel Vetter: On Wed, Nov 21, 2018 at 07:02:15PM +0100, Noralf Trønnes wrote: drivers/gpu/drm/drm_prime.c: In function 'drm_gem_prime_mmap': drivers/gpu/drm/drm_prime.c:688:1: warning: the frame size of 1592 bytes is larger than 1024 bytes

[Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows

2018-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106175 --- Comment #59 from bmil...@gmail.com --- (In reply to Nicholas Kazlauskas from comment #58) > (In reply to Brandon Wright from comment #55) > > Created attachment 142558 [details] [review] [review] > > Patch that "fixes" the problem. > > > >

[PATCH 0/3] RFC: mmu notifier debug checks

2018-11-22 Thread Daniel Vetter
Hi all, We're having some good fun with the i915 mmu notifier (it deadlocks), and I think it'd be very useful to have a bunch more runtime debug checks to catch screw-ups. I'm also working on some lockdep improvements in gpu code (better annotations and stuff like that). Together with this

[PATCH 3/3] mm, notifier: Add a lockdep map for invalidate_range_start

2018-11-22 Thread Daniel Vetter
This is a similar idea to the fs_reclaim fake lockdep lock. It's fairly easy to provoke a specific notifier to be run on a specific range: Just prep it, and then munmap() it. A bit harder, but still doable, is to provoke the mmu notifiers for all the various callchains that might lead to them.

[PATCH 1/3] mm: Check if mmu notifier callbacks are allowed to fail

2018-11-22 Thread Daniel Vetter
Just a bit of paranoia, since if we start pushing this deep into callchains it's hard to spot all places where an mmu notifier implementation might fail when it's not allowed to. Cc: Andrew Morton Cc: Michal Hocko Cc: "Christian König" Cc: David Rientjes Cc: Daniel Vetter Cc: "Jérôme Glisse"

  1   2   >