Re: [PATCH 3/6] firmware: qcom: scm: add support to restore secure config

2019-06-16 Thread Bjorn Andersson
On Sun 16 Jun 06:29 PDT 2019, Brian Masney wrote: > From: Rob Clark > > Add support to restore the secure configuration that is needed by the > On Chip MEMory (OCMEM) that is present on some Snapdragon devices. > > Signed-off-by: Rob Clark > [masn...@onstation.org: ported to latest kernel;

Re: [PATCH v3 0/6] ARM: qcom: working Nexus 5 display support

2019-06-16 Thread Bjorn Andersson
On Fri 31 May 02:46 PDT 2019, Brian Masney wrote: > This patch series adds working display support to the LG Nexus 5 > (hammerhead) phone. > > Changes since v2: > - Dropped two drm/msm bug fix patches that have been merged separately. > - New patch: 'add support for per-CRTC max_vblank_count on

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #62 from Richard Thier --- Tested both versions and both work for me. Performance gain when using HyperZ is around 5-10% for me (that is sometimes just 2-4 FPS, sometimes more). gb_pipes are reported as 1 now as it should be. --

Re: [PATCH 1/6] dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) bindings

2019-06-16 Thread Bjorn Andersson
On Sun 16 Jun 06:29 PDT 2019, Brian Masney wrote: > Add device tree bindings for the On Chip Memory (OCMEM) that is present > on some Qualcomm Snapdragon SoCs. > > Signed-off-by: Brian Masney > --- > .../bindings/soc/qcom/qcom,ocmem.yaml | 66 +++ > 1 file changed, 66

Re: [PATCH 6/6] drm/msm/gpu: add ocmem init/cleanup functions

2019-06-16 Thread Bjorn Andersson
On Sun 16 Jun 06:29 PDT 2019, Brian Masney wrote: > The files a3xx_gpu.c and a4xx_gpu.c have ifdefs for the OCMEM support > that was missing upstream. Add two new functions (adreno_gpu_ocmem_init > and adreno_gpu_ocmem_cleanup) that removes some duplicated code. We also > need to change the ifdef

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 Alex Deucher changed: What|Removed |Added Attachment #144438|text/x-log |text/plain mime type|

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #60 from Richard Thier --- Created attachment 144559 --> https://bugs.freedesktop.org/attachment.cgi?id=144559=edit Fix variant 1 (delegate to r300 init) Added a possible drm patch for kernel source tree. This version is the one

Re: [PATCH 5/6] soc: qcom: add OCMEM driver

2019-06-16 Thread Bjorn Andersson
On Sun 16 Jun 06:29 PDT 2019, Brian Masney wrote: > From: Rob Clark > > The OCMEM driver handles allocation and configuration of the On Chip > MEMory that is present on some Snapdragon SoCs. > > Devices which have OCMEM do not have GMEM inside the GPU core, so the > GPU must instead use OCMEM

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #61 from Richard Thier --- Created attachment 144560 --> https://bugs.freedesktop.org/attachment.cgi?id=144560=edit Fix variant 2 (special case pipe number for 0x5a62) Added the second fix variation I've imagined. I am still

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #63 from cosiek...@o2.pl --- (In reply to Richard Thier from comment #58) > Also there was one time where things were working for me before changes but > I do not know what the pipe value was back then. So yes, there is SOME > chance

[Bug 110674] Crashes / Resets From AMDGPU / Radeon VII

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110674 --- Comment #40 from Alex Deucher --- Please attach your full dmesg output. Are you passing any parameters to the driver? -- You are receiving this mail because: You are the assignee for the

Re: [PATCH 4/6] firmware: qcom: scm: add OCMEM lock/unlock interface

2019-06-16 Thread Bjorn Andersson
On Sun 16 Jun 06:29 PDT 2019, Brian Masney wrote: > From: Rob Clark > > Add support for the OCMEM lock/unlock interface that is needed by the > On Chip MEMory (OCMEM) that is present on some Snapdragon devices. > > Signed-off-by: Rob Clark > [masn...@onstation.org: ported to latest kernel;

Re: [RFC v2 01/11] OPP: Don't overwrite rounded clk rate

2019-06-16 Thread Rajendra Nayak
On 6/17/2019 9:20 AM, Viresh Kumar wrote: On 14-06-19, 10:57, Viresh Kumar wrote: Hmm, so this patch won't break anything and I am inclined to apply it again :) Does anyone see any other issues with it, which I might be missing ? I have updated the commit log a bit more to clarify on

Re: [RFC v2 01/11] OPP: Don't overwrite rounded clk rate

2019-06-16 Thread Rajendra Nayak
On 6/17/2019 9:47 AM, Viresh Kumar wrote: On 17-06-19, 09:37, Rajendra Nayak wrote: On 6/17/2019 9:20 AM, Viresh Kumar wrote: On 14-06-19, 10:57, Viresh Kumar wrote: Hmm, so this patch won't break anything and I am inclined to apply it again :) Does anyone see any other issues with it,

Re: [RFC v2 00/11] DVFS in the OPP core

2019-06-16 Thread Viresh Kumar
On 20-03-19, 15:19, Rajendra Nayak wrote: > This is a v2 of the RFC posted earlier by Stephen Boyd [1] > > As part of v2 I still follow the same approach of dev_pm_opp_set_rate() > API using clk framework to round the frequency passed and making it > accept 0 as a valid frequency indicating the

Re: [PATCH 44/59] drm/mediatek: Use drm_atomic_helper_wait_for_fences

2019-06-16 Thread CK Hu
Hi, Daniel: On Fri, 2019-06-14 at 22:36 +0200, Daniel Vetter wrote: > If we use the gem fb helper as the prepare_fb hook, plus the > drm_prime.c import helpers now automatically setting obj->resv, we can > use the shared helpers to wait for fences instead of rolling our own. > Note that this

Re: [PATCH 6/6] drm/msm/gpu: add ocmem init/cleanup functions

2019-06-16 Thread Brian Masney
Hi Bjorn, On Sun, Jun 16, 2019 at 11:06:33AM -0700, Bjorn Andersson wrote: > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > > b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > > index 6f7f4114afcf..e0a9409c8a32 100644 > > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > > +++

Re: [RFC v2 01/11] OPP: Don't overwrite rounded clk rate

2019-06-16 Thread Viresh Kumar
On 17-06-19, 09:37, Rajendra Nayak wrote: > > > On 6/17/2019 9:20 AM, Viresh Kumar wrote: > > On 14-06-19, 10:57, Viresh Kumar wrote: > > > Hmm, so this patch won't break anything and I am inclined to apply it > > > again :) > > > > > > Does anyone see any other issues with it, which I might

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #64 from Marek Olšák --- rs400, which includes rc400, is not r400. It's r300. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

Re: [RFC PATCH] drm/panfrost: Add support for mapping BOs on GPU page faults

2019-06-16 Thread Tomeu Vizoso
On Fri, 14 Jun 2019 at 23:22, Rob Herring wrote: > > On Wed, Jun 12, 2019 at 6:55 AM Tomeu Vizoso wrote: > > > > On Mon, 10 Jun 2019 at 19:06, Rob Herring wrote: > > > > > > The midgard/bifrost GPUs need to allocate GPU memory which is allocated > > > on GPU page faults and not pinned in

Re: [PATCH 19/59] drm/mtk: Drop drm_gem_prime_export/import

2019-06-16 Thread CK Hu
Hi, Daniel: On Fri, 2019-06-14 at 22:35 +0200, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. Reviewed-by: CK Hu > > Signed-off-by: Daniel Vetter > Cc: CK Hu > Cc: Philipp Zabel > Cc: Matthias Brugger > Cc:

Re: [PATCH v3, 19/27] drm/mediatek: add function to background color input select for ovl/ovl_2l direct link

2019-06-16 Thread CK Hu
Hi, Yongqiang: On Wed, 2019-06-05 at 19:42 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add function to background color input select for ovl/ovl_2l > direct link > for ovl/ovl_2l direct link usecase, we need set background color > input select for these

[Bug 102646] Screen flickering under amdgpu-experimental [buggy auto power profile]

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102646 --- Comment #94 from magist3r --- Created attachment 144565 --> https://bugs.freedesktop.org/attachment.cgi?id=144565=edit proposed fix FINALLY!!! I fixed the issue. A small patch with a fix is in the attachment. Feel free to suggest a

Re: [PATCH v3, 26/27] drm/mediatek: add clock property check before get it

2019-06-16 Thread CK Hu
Hi, Yongqiang: On Wed, 2019-06-05 at 19:43 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add clock property check before get it In the binding document [1], clock is required property. In this patch, you change it to optional property. I think you should change

linux-next: manual merge of the drm-intel tree with the pci tree

2019-06-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_drv.h between commit: 151f4e2bdc7a ("docs: power: convert docs to ReST and rename to *.rst") from the pci tree and commit: 1bf676cc2dba ("drm/i915: move and rename i915_runtime_pm")

Re: [PATCH 11/59] drm/arm: Drop drm_gem_prime_export/import

2019-06-16 Thread james qian wang (Arm Technology China)
On Fri, Jun 14, 2019 at 10:35:27PM +0200, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter > Cc: "James (Qian) Wang" > Cc: Liviu Dudau > Cc: Brian Starkey > --- >

Re: linux-next: manual merge of the drm-misc tree with the amdgpu tree

2019-06-16 Thread Stephen Rothwell
Hi all, On Wed, 12 Jun 2019 11:46:15 +1000 Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/amd/display/dc/dce/dce_audio.c > > between commit: > > c7c7192c56d2 ("drm/amd/display: add audio related regs") > >

Re: [PATCH v3, 27/27] drm/mediatek: add support for mediatek SOC MT8183

2019-06-16 Thread CK Hu
Hi, Yongqiang: On Wed, 2019-06-05 at 19:43 +0800, yongqiang@mediatek.com wrote: > From: Yongqiang Niu > > This patch add support for mediatek SOC MT8183 > 1.ovl_2l share driver with ovl > 2.rdma1 share drive with rdma0, but fifo size is different > 3.add mt8183 mutex private data, and mmsys

[Bug 110926] on Centos 6.10

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110926 Bug ID: 110926 Summary: on Centos 6.10 Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: blocker

Re: [RFC v2 02/11] OPP: Make dev_pm_opp_set_rate() with freq=0 as valid

2019-06-16 Thread Rajendra Nayak
On 6/14/2019 12:02 PM, Viresh Kumar wrote: On 20-03-19, 15:19, Rajendra Nayak wrote: For devices with performance state, we use dev_pm_opp_set_rate() to set the appropriate clk rate and the performance state. We do need a way to *remove* the performance state vote when we idle the device and

Re: [PATCH 13/59] drm/etnaviv: Drop drm_gem_prime_export/import

2019-06-16 Thread Christian Gmeiner
Am Fr., 14. Juni 2019 um 22:36 Uhr schrieb Daniel Vetter : > > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. > > Signed-off-by: Daniel Vetter Reviewed-by: Christian Gmeiner > Cc: Lucas Stach > Cc: Russell King > Cc: Christian

[PATCH] drm/komeda: Adds power management support

2019-06-16 Thread Lowry Li (Arm Technology China)
Adds runtime and system power management support in KMS kernel driver. Depends on: - https://patchwork.freedesktop.org/series/61650/ - https://patchwork.freedesktop.org/series/60083/ Signed-off-by: Lowry Li (Arm Technology China) --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +

Re: [EXTERNAL] Re: [PATCH 1/1] drm/bochs: Fix connector leak during driver unload

2019-06-16 Thread Gerd Hoffmann
On Mon, Jun 17, 2019 at 11:20:34AM +1000, Sam Bobroff wrote: > On Tue, May 21, 2019 at 10:10:29AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > The bug is in the driver, so ... > > > > > Bisecting the issue for commits to drivers/gpu/drm/bochs/ points to: > > > 6579c39594ae ("drm/bochs: atomic:

Re: [PATCH libdrm 2/2] meson.build: Fix meson script on FreeBSD

2019-06-16 Thread Emil Velikov
On Mon, 3 Jun 2019 at 08:41, Niclas Zeising wrote: > > FreeBSD requires sys/types.h for sys/sysctl.h, add it as part of the > includes when checking for headers. > Instead of splitting out the check for sys/sysctl.h from the other > header checks, just add sys/types.h to all header checks. > If

[PATCH libdrm v2 3/4] meson: normal shell will do

2019-06-16 Thread Emil Velikov
As tweaked with previous patch - bash is not required. Any shell will do Signed-off-by: Emil Velikov --- amdgpu/meson.build| 2 +- etnaviv/meson.build | 2 +- exynos/meson.build| 2 +- freedreno/meson.build | 2 +- intel/meson.build | 14 +++--- libkms/meson.build|

[PATCH libdrm v2 2/4] *symbols-check: use normal shell over bash

2019-06-16 Thread Emil Velikov
None of the tests are bash specific. Tested with bash, zsh, dash, mksh and ksh. Signed-off-by: Emil Velikov --- amdgpu/amdgpu-symbol-check | 2 +- etnaviv/etnaviv-symbol-check | 2 +- exynos/exynos-symbol-check | 2 +- freedreno/freedreno-symbol-check | 2 +-

[PATCH libdrm v2 4/4] meson.build: Fix meson script on FreeBSD

2019-06-16 Thread Emil Velikov
From: Niclas Zeising FreeBSD requires sys/types.h for sys/sysctl.h, add it as part of the includes when checking for headers. Instead of splitting out the check for sys/sysctl.h from the other header checks, just add sys/types.h to all header checks. v2 [Emil] - add inline comment - drop

[PATCH libdrm v2 1/4] meson.build: Fix typo

2019-06-16 Thread Emil Velikov
From: Niclas Zeising Reviewed-by: Emil Velikov --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index be768afa..64f0d5b1 100644 --- a/meson.build +++ b/meson.build @@ -248,7 +248,7 @@ if prog_xslt.found() endif with_man_pages =

[PATCH 5/6] soc: qcom: add OCMEM driver

2019-06-16 Thread Brian Masney
From: Rob Clark The OCMEM driver handles allocation and configuration of the On Chip MEMory that is present on some Snapdragon SoCs. Devices which have OCMEM do not have GMEM inside the GPU core, so the GPU must instead use OCMEM to be functional. Since currently the GPU is the only OCMEM user

[PATCH 2/6] dt-bindings: display: msm: gmu: add optional ocmem property

2019-06-16 Thread Brian Masney
Some A3xx and A4xx Adreno GPUs do not have GMEM inside the GPU core and must use the On Chip MEMory (OCMEM) in order to be functional. Add the optional ocmem property to the Adreno Graphics Management Unit bindings. Signed-off-by: Brian Masney ---

[PATCH 4/6] firmware: qcom: scm: add OCMEM lock/unlock interface

2019-06-16 Thread Brian Masney
From: Rob Clark Add support for the OCMEM lock/unlock interface that is needed by the On Chip MEMory (OCMEM) that is present on some Snapdragon devices. Signed-off-by: Rob Clark [masn...@onstation.org: ported to latest kernel; minor reformatting.] Signed-off-by: Brian Masney --- Rob's last

[PATCH 6/6] drm/msm/gpu: add ocmem init/cleanup functions

2019-06-16 Thread Brian Masney
The files a3xx_gpu.c and a4xx_gpu.c have ifdefs for the OCMEM support that was missing upstream. Add two new functions (adreno_gpu_ocmem_init and adreno_gpu_ocmem_cleanup) that removes some duplicated code. We also need to change the ifdef check for CONFIG_MSM_OCMEM to CONFIG_QCOM_OCMEM now that

[PATCH 3/6] firmware: qcom: scm: add support to restore secure config

2019-06-16 Thread Brian Masney
From: Rob Clark Add support to restore the secure configuration that is needed by the On Chip MEMory (OCMEM) that is present on some Snapdragon devices. Signed-off-by: Rob Clark [masn...@onstation.org: ported to latest kernel; minor reformatting.] Signed-off-by: Brian Masney --- Rob's last

[PATCH 1/6] dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) bindings

2019-06-16 Thread Brian Masney
Add device tree bindings for the On Chip Memory (OCMEM) that is present on some Qualcomm Snapdragon SoCs. Signed-off-by: Brian Masney --- .../bindings/soc/qcom/qcom,ocmem.yaml | 66 +++ 1 file changed, 66 insertions(+) create mode 100644

[PATCH 0/6] qcom: add OCMEM support

2019-06-16 Thread Brian Masney
This patch series adds support for Qualcomm's On Chip MEMory (OCMEM) that is needed in order to support some A3xx and A4xx based GPUs upstream. This is based on Rob Clark's patch series that he submitted in October 2015 and I am resubmitting updated patches with his permission. This was tested

Re: [PATCH 1/2] drm/rockchip: Properly adjust to a true clock in adjusted_mode

2019-06-16 Thread Heiko Stübner
Am Samstag, 15. Juni 2019, 00:47:29 CEST schrieb Douglas Anderson: > When fixing up the clock in vop_crtc_mode_fixup() we're not doing it > quite correctly. Specifically if we've got the true clock 26667 Hz, > we'll perform this calculation: >26667 / 1000 => 26 > > Later when we

[PATCH v2 00/28] drivers: Consolidate device lookup helpers

2019-06-16 Thread Suzuki K Poulose
We have device iterators to find a particular device matching a criteria for a given bus/class/driver. i.e, {bus,class,driver}_find_device() APIs. The matching criteria is a function pointer for the APIs. Often the lookup is based on a generic property of a device (e.g, name, fwnode, of node

[PATCH v2 06/28] drivers: Add generic helper to match by of_node

2019-06-16 Thread Suzuki K Poulose
Add a helper to match device by the of_node. This will be later used to provide wrappers to the device iterators for {bus/class/driver}_find_device(). Convert other users to reuse this new helper. Cc: Alan Tull Cc: Andrew Lunn Cc: Daniel Vetter Cc: David Airlie Cc: "David S. Miller" Cc:

[PATCH] drm/amd: fix hotplug race at startup

2019-06-16 Thread Young Xiao
We should check mode_config_initialized flag in amdgpu_hotplug_work_func. See commit 7f98ca454ad3 ("drm/radeon: fix hotplug race at startup") for details. Signed-off-by: Young Xiao <92siuy...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-16 Thread Joseph Kogut
Add device tree node for mali gpu on Odroid XU3 SoCs. Signed-off-by: Joseph Kogut --- .../boot/dts/exynos5422-odroidxu3-common.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi

Re: [PATCH] staging: fbtft: Fix checkpatch ERROR: space prohibited before that close parenthesis ')'

2019-06-16 Thread Shobhit Kukreti
On Sat, Jun 15, 2019 at 07:33:02PM +0200, Greg Kroah-Hartman wrote: > On Thu, Jun 13, 2019 at 07:32:28PM -0700, Shobhit Kukreti wrote: > > Cleaned up code to resolve the checkpatch error > > ERROR: space prohibited before that close parenthesis ')' > > from the file: > > > > fbtft/fbtft-bus.c >

[PATCH 1/2] dt-bindings: gpu: add Exynos Mali vendor specifics

2019-06-16 Thread Joseph Kogut
Document vendor specific compatible string for Mali gpus on Exynos SoCs. Signed-off-by: Joseph Kogut --- Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt

Re: [PATCH 06/22] mm: factor out a devm_request_free_mem_region helper

2019-06-16 Thread John Hubbard
On 6/13/19 2:43 AM, Christoph Hellwig wrote: > Keep the physical address allocation that hmm_add_device does with the > rest of the resource code, and allow future reuse of it without the hmm > wrapper. > > Signed-off-by: Christoph Hellwig > --- > include/linux/ioport.h | 2 ++ >

Re: [EXT] Re: [PATCH 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-16 Thread Robert Chiras
On Vi, 2019-06-14 at 10:39 -0300, Fabio Estevam wrote: > Caution: EXT Email > > On Fri, Jun 14, 2019 at 10:29 AM Robert Chiras > wrote: > > > > > The GPIO is active high, and the above sequence was received from > > the > > panel vendor in the following form: > > SET_RESET_PIN(1); > >  

Re: [PATCH] drm/nouveau/dmem: missing mutex_lock in error path

2019-06-16 Thread Ralph Campbell
On 6/13/19 5:49 PM, John Hubbard wrote: On 6/13/19 5:11 PM, Ralph Campbell wrote: In nouveau_dmem_pages_alloc(), the drm->dmem->mutex is unlocked before calling nouveau_dmem_chunk_alloc(). Reacquire the lock before continuing to the next page. Signed-off-by: Ralph Campbell --- I found this

[PATCH v2 17/28] drivers: Introduce bus_find_device_by_of_node() helper

2019-06-16 Thread Suzuki K Poulose
Add a wrapper to bus_find_device() to search for a device by the of_node pointer, reusing the generic match function. Also convert the existing users to make use of the new helper. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: dri-devel@lists.freedesktop.org Cc: David Airlie Cc: Daniel Vetter

[PATCH v2] drm/nouveau/dmem: missing mutex_lock in error path

2019-06-16 Thread Ralph Campbell
In nouveau_dmem_pages_alloc(), the drm->dmem->mutex is unlocked before calling nouveau_dmem_chunk_alloc() as shown when CONFIG_PROVE_LOCKING is enabled: [ 1294.871933] = [ 1294.876656] WARNING: bad unlock balance detected! [ 1294.881375] 5.2.0-rc3+ #5 Not

Re: [PATCH libdrm 2/2] meson.build: Fix meson script on FreeBSD

2019-06-16 Thread Niclas Zeising
On 2019-06-16 15:16, Emil Velikov wrote: On Mon, 3 Jun 2019 at 08:41, Niclas Zeising wrote: FreeBSD requires sys/types.h for sys/sysctl.h, add it as part of the includes when checking for headers. Instead of splitting out the check for sys/sysctl.h from the other header checks, just add

[PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-16 Thread Joseph Kogut
Add device tree node for mali gpu on Odroid XU3 SoCs. Signed-off-by: Joseph Kogut --- Changes v1 -> v2: - Use interrupt name ordering from binding doc - Specify a single clock for GPU node - Add gpu opp table - Fix warnings from IRQ_TYPE_NONE .../boot/dts/exynos5422-odroidxu3-common.dtsi | 26

Re: [PATCH libdrm v2 2/4] *symbols-check: use normal shell over bash

2019-06-16 Thread Niclas Zeising
On 2019-06-16 15:23, Emil Velikov wrote: None of the tests are bash specific. Tested with bash, zsh, dash, mksh and ksh. Signed-off-by: Emil Velikov Tested-by: Niclas Zeising Reviewed-by: Niclas Zeising --- amdgpu/amdgpu-symbol-check | 2 +- etnaviv/etnaviv-symbol-check | 2

[PATCH 0/2] MSM8998 MTP Display

2019-06-16 Thread Jeffrey Hugo
Since we are trying to get the GPU and display hardware in the SoC supported, it would be nice to be able to put the output on the integrated panel for the reference platform. To do so, we need support in the Truly driver to support the specific panel variant for the MSM8998 MTP. This series

Re: Cleanup of -Wunused-const-variable in drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c

2019-06-16 Thread Nick Desaulniers
On Fri, Jun 14, 2019 at 2:43 AM Jani Nikula wrote: > No opinion on the said variables above, but, FWIW, personally I think > it's fine to add the cflags to supress warnings locally where needed in > order to be able to achieve the greater goal of removing the cflags > globally. I think there's

[PATCH] drm/msm/dpu: Fix Wunused-const-variable

2019-06-16 Thread Nathan Huckleberry
Clang produces the following warning drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:477:32: warning: unused variable 'dpu_format_map_tile' [-Wunused-const-variable] static const struct dpu_format dpu_format_map_tile[] = { ^ drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c:602:32: warning: unused

Re: [PATCH v2] drm: radeon: add a missing break in evergreen_cs_handle_reg

2019-06-16 Thread Mathieu Malaterre
On Thu, Jan 17, 2019 at 9:40 PM Mathieu Malaterre wrote: > > In commit dd220a00e8bd ("drm/radeon/kms: add support for streamout v7") > case statements were added without a terminating break statement. This > commit adds the missing break. This was discovered during a compilation > with W=1. > >

Re: [PATCH] drm/nouveau/dmem: missing mutex_lock in error path

2019-06-16 Thread John Hubbard
On 6/14/19 10:39 AM, Ralph Campbell wrote: > On 6/13/19 5:49 PM, John Hubbard wrote: >> On 6/13/19 5:11 PM, Ralph Campbell wrote: ... >> Actually, the pre-existing code is a little concerning. Your change preserves >> the behavior, but it seems questionable to be doing a "return 0" (whether >> via

Re: Cleanup of -Wunused-const-variable in drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c

2019-06-16 Thread Nick Desaulniers
On Thu, Jun 13, 2019 at 1:50 PM Sean Paul wrote: > > On Thu, Jun 13, 2019 at 4:13 PM Nathan Huckleberry wrote: > > > > Hey all, > > > > I'm looking into cleaning up ignored warnings in the kernel so we can > > remove compiler flags to ignore warnings. > > > > There are several unused variables

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #57 from cosiek...@o2.pl --- 4.14.124: 1 quad pipes, 1 z pipes initialized. 4.19.49: 1 quad pipes, 1 z pipes initialized. 4.20.17: 1 quad pipes, 1 z pipes initialized. 5.0.21: 1 quad pipes, 1 z pipes initialized. 5.1.8: 1 quad pipes,

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #56 from Richard Thier --- (In reply to cosiekvfj from comment #54) > Created attachment 144558 [details] > dmesg log > > [ 14.303343] [drm] radeon: 1 quad pipes, 1 z pipes initialized. This is really interesting! It tells us

Re: [linux-sunxi] [PATCH v6 5/6] drm: sun4i: Add support for enabling DDC I2C bus to sun8i_dw_hdmi glue

2019-06-16 Thread Ondřej Jirman
Hi Jernej, On Sun, Jun 16, 2019 at 01:05:13PM +0200, Jernej Škrabec wrote: > Hi Ondrej! > > Dne ponedeljek, 27. maj 2019 ob 18:22:36 CEST je megous via linux-sunxi > napisal(a): > > From: Ondrej Jirman > > > > Orange Pi 3 board requires enabling a voltage shifting circuit via GPIO > > for the

Re: [PATCH 1/2] dt-bindings: gpu: add Exynos Mali vendor specifics

2019-06-16 Thread Krzysztof Kozlowski
On Fri, Jun 14, 2019 at 01:31:43PM -0700, Joseph Kogut wrote: > Document vendor specific compatible string for Mali gpus on Exynos SoCs. > > Signed-off-by: Joseph Kogut > --- > Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-16 Thread Krzysztof Kozlowski
On Fri, Jun 14, 2019 at 04:57:19PM -0700, Joseph Kogut wrote: > Add device tree node for mali gpu on Odroid XU3 SoCs. > > Signed-off-by: Joseph Kogut > --- > > Changes v1 -> v2: > - Use interrupt name ordering from binding doc > - Specify a single clock for GPU node > - Add gpu opp table > -

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #54 from cosiek...@o2.pl --- Created attachment 144558 --> https://bugs.freedesktop.org/attachment.cgi?id=144558=edit dmesg log [ 14.303343] [drm] radeon: 1 quad pipes, 1 z pipes initialized. -- You are receiving this mail

Re: [PATCH v4 10/12] drm/modes: Parse overscan properties

2019-06-16 Thread Noralf Trønnes
Den 15.06.2019 17.40, skrev Noralf Trønnes: > > > Den 14.06.2019 14.13, skrev Maxime Ripard: >> Properly configuring the overscan properties might be needed for the >> initial setup of the framebuffer for display that still have overscan. >> Let's allow for more properties on the kernel

[Bug 110117] Waking from Suspend causes screen to appear with grey static (like a TV with no signal)

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110117 --- Comment #13 from Alexey Shindin --- I can confirm this behavior at Ubuntu 18.04.2 LTS with Acer PH517-61 notebook. The minor addition is that the issue concerns only the built-in display. In two display configuration after wake up the

Re: [linux-sunxi] [PATCH v6 5/6] drm: sun4i: Add support for enabling DDC I2C bus to sun8i_dw_hdmi glue

2019-06-16 Thread Jernej Škrabec
Hi Ondrej! Dne ponedeljek, 27. maj 2019 ob 18:22:36 CEST je megous via linux-sunxi napisal(a): > From: Ondrej Jirman > > Orange Pi 3 board requires enabling a voltage shifting circuit via GPIO > for the DDC bus to be usable. > > Add support for hdmi-connector node's optional ddc-en-gpios

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #55 from Richard Thier --- (In reply to Dieter Nützel from comment #53) > If you do NOT 'make mrproper' and change only radeon/amdgpu stuff it should > only take some minutes (seconds) on your system/CPU. I was dumb-enough that

Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

2019-06-16 Thread Yrjan Skrimstad
On Thu, Jun 13, 2019 at 09:57:24AM -0400, Alex Deucher wrote: > The patch is fine and I can apply it (I don't think there are any > restrictions on sleeping in sysfs), but this code only gets executed > when you actually read the power status from the card (e.g., via sysfs > or debugfs).

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #58 from Richard Thier --- I still have some dmesg logs around from my other debugging session and in every one of those I get 3 pipes despite different kernel versions from 4.4 to latest 5.x Also looking at git blame I can see

[Bug 110897] HyperZ is broken for r300 (bad z for some micro and macrotiles?)

2019-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110897 --- Comment #59 from Richard Thier --- > the glitches are the same (I know about some already), > everything works that worked before... I was kinda hoping maybe some glitches I know can go away if the init code does the r300_init but that is