Re: [RFC] Staging: fbtft: Typo in

2019-07-25 Thread Greg KH
On Sun, Jul 21, 2019 at 08:54:39PM +0200, Christophe JAILLET wrote: > Hi, > > looking at the code in 'drivers/staging/fbtft/fb_pcd8544.c', there seems to > be some typos. > > At the end of the file, we can find: > > FBTFT_REGISTER_DRIVER(DRVNAME, "philips,pdc8544", ); > ... >

Re: AMD Drivers

2019-07-25 Thread Enrico Weigelt, metux IT consult
On 24.07.19 16:17, Gilberto Nunes wrote: Hi, crossposting to dri-devel, as it smells like a problem w/ amdgpu driver. CPU - AMD A12-9720P RADEON R7, 12 COMPUTE CORES 4C+8G GPU - Wani [Radeon R5/R6/R7 Graphics] (amdgpu) Network Interface card: 01:00.1 Ethernet controller: Realtek Semiconductor

Re: linux-next: Tree for Jul 24 (amdgpu)

2019-07-25 Thread Randy Dunlap
On 7/23/19 9:57 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190723: > on i386: CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.o ../drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hwseq.c: In function ‘dcn20_init_hw’:

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

2019-07-25 Thread Vincenzo Frascino
Hi Will and Andrey, On 24/07/2019 15:20, Will Deacon wrote: > On Wed, Jul 24, 2019 at 04:16:49PM +0200, Andrey Konovalov wrote: >> On Wed, Jul 24, 2019 at 4:02 PM Will Deacon wrote: >>> On Tue, Jul 23, 2019 at 08:03:29PM +0200, Andrey Konovalov wrote: On Tue, Jul 23, 2019 at 7:59 PM Andrey

Re: [PATCH] mm/hmm: replace hmm_update with mmu_notifier_range

2019-07-25 Thread Jason Gunthorpe
On Wed, Jul 24, 2019 at 09:48:55PM +0200, Christoph Hellwig wrote: > On Wed, Jul 24, 2019 at 04:21:55PM -0300, Jason Gunthorpe wrote: > > If we change the register to keep the hlist sorted by address then we > > can do a targetted 'undo' of past starts terminated by address > > less-than

Re: kernel panic: stack is corrupted in pointer

2019-07-25 Thread John Fastabend
Dmitry Vyukov wrote: > On Tue, Jul 23, 2019 at 7:26 PM John Fastabend > wrote: > > > > Dmitry Vyukov wrote: > > > On Wed, Jul 17, 2019 at 10:58 AM syzbot > > > wrote: > > > > > > > > Hello, > > > > > > > > syzbot found the following crash on: > > > > > > > > HEAD commit:1438cde7 Add

Re: [PATCH] mm/hmm: replace hmm_update with mmu_notifier_range

2019-07-25 Thread Jason Gunthorpe
On Wed, Jul 24, 2019 at 08:59:10PM +0200, Michal Hocko wrote: > On Wed 24-07-19 20:56:17, Michal Hocko wrote: > > On Wed 24-07-19 15:08:37, Jason Gunthorpe wrote: > > > On Wed, Jul 24, 2019 at 07:58:58PM +0200, Michal Hocko wrote: > > [...] > > > > Maybe new users have started relying on a new

Re: [PATCH] mm/hmm: replace hmm_update with mmu_notifier_range

2019-07-25 Thread Jason Gunthorpe
On Wed, Jul 24, 2019 at 09:05:53AM +0200, Christoph Hellwig wrote: > Looks good: > > Reviewed-by: Christoph Hellwig > > One comment on a related cleanup: > > > list_for_each_entry(mirror, >mirrors, list) { > > int rc; > > > > - rc =

Re: [PATCH] mm/hmm: replace hmm_update with mmu_notifier_range

2019-07-25 Thread Jason Gunthorpe
On Wed, Jul 24, 2019 at 05:33:05PM +0200, Christoph Hellwig wrote: > On Wed, Jul 24, 2019 at 12:28:58PM -0300, Jason Gunthorpe wrote: > > Humm. Actually having looked this some more, I wonder if this is a > > problem: > > What a mess. > > Question: do we even care for the non-blocking events?

Re: [PATCH] mm/hmm: replace hmm_update with mmu_notifier_range

2019-07-25 Thread Jason Gunthorpe
On Wed, Jul 24, 2019 at 07:58:58PM +0200, Michal Hocko wrote: > On Wed 24-07-19 12:28:58, Jason Gunthorpe wrote: > > On Wed, Jul 24, 2019 at 09:05:53AM +0200, Christoph Hellwig wrote: > > > Looks good: > > > > > > Reviewed-by: Christoph Hellwig > > > > > > One comment on a related cleanup: > >

[PATCH] fbdev: sm712fb: Use dev_get_drvdata

2019-07-25 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/video/fbdev/sm712fb.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c index

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

2019-07-25 Thread Andrey Konovalov
On Wed, Jul 24, 2019 at 4:02 PM Will Deacon wrote: > > Hi Andrey, > > On Tue, Jul 23, 2019 at 08:03:29PM +0200, Andrey Konovalov wrote: > > On Tue, Jul 23, 2019 at 7:59 PM Andrey Konovalov > > wrote: > > > > > > === Overview > > > > > > arm64 has a feature called Top Byte Ignore, which allows

Re: [PATCH RESEND] drm: Switch to use DEVFREQ_GOV_SIMPLE_ONDEMAND constant

2019-07-25 Thread Chanwoo Choi
On 19. 7. 25. 오후 12:52, Yue Hu wrote: > From: Yue Hu > > Since governor name is defined by DEVFREQ framework internally, use the > macro definition instead of using the name directly. > > Signed-off-by: Yue Hu > --- > drivers/gpu/drm/msm/msm_gpu.c | 3 ++- >

Re: amdgpu errors reported with kernel 5.2.2 (was Re: Problem with kernel major than 4.15.x)

2019-07-25 Thread Gilberto Nunes
Thanks Yann to redirect to the proper lists! --- Gilberto Nunes Ferreira (47) 3025-5907 (47) 99676-7530 - Whatsapp / Telegram Skype: gilberto.nunes36 Em qua, 24 de jul de 2019 às 11:59, Yann Droneaud escreveu: > > Hi, > > Le mercredi 24 juillet 2019 à 09:43 -0300, Gilberto Nunes a écrit : >

amdgpu errors reported with kernel 5.2.2 (was Re: Problem with kernel major than 4.15.x)

2019-07-25 Thread Yann Droneaud
Hi, Le mercredi 24 juillet 2019 à 09:43 -0300, Gilberto Nunes a écrit : > > Right now, I booted my laptop with kernel > Linux version 5.2.2-050202-generic (kernel@kathleen) (gcc version > 9.1.0 (Ubuntu 9.1.0-9ubuntu2)) #201907231250 SMP Tue Jul 23 12:53:21 > UTC 2019 > > The system boot slowly,

Re: [PATCH v19 11/15] IB/mlx4: untag user pointers in mlx4_get_umem_mr

2019-07-25 Thread Jason Gunthorpe
On Tue, Jul 23, 2019 at 07:58:48PM +0200, Andrey Konovalov wrote: > This patch is a part of a series that extends kernel ABI to allow to pass > tagged user pointers (with the top byte set to something else other than > 0x00) as syscall arguments. > > mlx4_get_umem_mr() uses provided user pointers

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

2019-07-25 Thread Will Deacon
On Wed, Jul 24, 2019 at 04:16:49PM +0200, Andrey Konovalov wrote: > On Wed, Jul 24, 2019 at 4:02 PM Will Deacon wrote: > > On Tue, Jul 23, 2019 at 08:03:29PM +0200, Andrey Konovalov wrote: > > > On Tue, Jul 23, 2019 at 7:59 PM Andrey Konovalov > > > wrote: > > > > > > > > === Overview > > > > >

Re: [PATCH 0/3] RFT: PL111 DRM conversion of nspire

2019-07-25 Thread Pawel Moll
On Wed, 2019-07-24 at 13:28 +0100, Linus Walleij wrote: > On Tue, Jul 23, 2019 at 8:10 PM Sam Ravnborg wrote: > > On Tue, Jul 23, 2019 at 03:37:52PM +0200, Linus Walleij wrote: > > Do we need to support arm,pl11x,tft-r0g0b0-pads before > > we can obsolete fbdev stuff? > > No I don't think so,

[PATCH v2] drm/panel: check failure cases in the probe func

2019-07-25 Thread Navid Emamdoost
The following function calls may fail and return NULL, so the null check is added. of_graph_get_next_endpoint of_graph_get_remote_port_parent of_graph_get_remote_port Update: Thanks to Sam Ravnborg, for suggession on the use of goto to avoid leaking endpoint. Signed-off-by: Navid Emamdoost ---

Re: [PATCH libdrm] libdrm: wrap new flexible syncobj query interface v2

2019-07-25 Thread Lionel Landwerlin
On 25/07/2019 10:52, Chunming Zhou wrote: v2: nit-picks fix Signed-off-by: Chunming Zhou Cc: Lionel Landwerlin Cc: Christian König For the xf86drm.[ch] part : Reviewed-by: Lionel Landwerlin I'll let someone from AMD look at the amdgpu bit. Thanks! -Lionel ---

[PATCH libdrm] libdrm: wrap new flexible syncobj query interface v2

2019-07-25 Thread Chunming Zhou
v2: nit-picks fix Signed-off-by: Chunming Zhou Cc: Lionel Landwerlin Cc: Christian König Reviewed-by: Christian König For the xf86drm.[ch] part : Reviewed-by: Lionel Landwerlin --- amdgpu/amdgpu-symbol-check | 1 + amdgpu/amdgpu.h| 18 ++ amdgpu/amdgpu_cs.c

Re: [PATCH libdrm] libdrm: wrap new flexible syncobj query interface v2

2019-07-25 Thread zhoucm1
Thank guys. Since I have write permission to libdrm mast, I need your help to push patch. -David On 2019年07月25日 16:11, Chunming Zhou wrote: v2: nit-picks fix Signed-off-by: Chunming Zhou Cc: Lionel Landwerlin Cc: Christian König Reviewed-by: Christian König For the xf86drm.[ch] part :

Re: [PATCH libdrm] libdrm: wrap new flexible syncobj query interface v2

2019-07-25 Thread zhoucm1
Thanks guys, since I have no write permission to libdrm, I need your help to push patch. -David On 2019年07月25日 16:11, Chunming Zhou wrote: v2: nit-picks fix Signed-off-by: Chunming Zhou Cc: Lionel Landwerlin Cc: Christian König Reviewed-by: Christian König For the xf86drm.[ch] part :

Recall: [PATCH libdrm] libdrm: wrap new flexible syncobj query interface v2

2019-07-25 Thread Zhou, David(ChunMing)
Zhou, David(ChunMing) would like to recall the message, "[PATCH libdrm] libdrm: wrap new flexible syncobj query interface v2". ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] Staging: fbtft: Fix GPIO handling

2019-07-25 Thread Greg KH
On Wed, Jul 17, 2019 at 11:41:37PM +0900, Jan Sebastian Götte wrote: > Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor > interface") breaks GPIO handling. In several places, checks to only set > a GPIO if it was configured ended up backwards. > I have tested this fix. The fixed

Re: [PATCH] mm/hmm: replace hmm_update with mmu_notifier_range

2019-07-25 Thread Jason Gunthorpe
On Tue, Jul 23, 2019 at 02:05:06PM -0700, Ralph Campbell wrote: > The hmm_mirror_ops callback function sync_cpu_device_pagetables() passes > a struct hmm_update which is a simplified version of struct > mmu_notifier_range. This is unnecessary so replace hmm_update with > mmu_notifier_range

[PATCH RESEND] drm: Switch to use DEVFREQ_GOV_SIMPLE_ONDEMAND constant

2019-07-25 Thread Yue Hu
From: Yue Hu Since governor name is defined by DEVFREQ framework internally, use the macro definition instead of using the name directly. Signed-off-by: Yue Hu --- drivers/gpu/drm/msm/msm_gpu.c | 3 ++- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 3 ++- 2 files changed, 4

Re: [PATCH v2] Staging: fbtft: Fix GPIO handling

2019-07-25 Thread Nicolas Saenz Julienne
On Thu, 2019-07-25 at 09:21 +0200, Greg KH wrote: > On Wed, Jul 17, 2019 at 11:41:37PM +0900, Jan Sebastian Götte wrote: > > Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor > > interface") breaks GPIO handling. In several places, checks to only set > > a GPIO if it was

[PATCH] drm: Switch to use DEVFREQ_GOV_SIMPLE_ONDEMAND constant

2019-07-25 Thread Yue Hu
From: Yue Hu Since governor name is defined by DEVFREQ framework internally, use the macro definition instead of using the name directly. Signed-off-by: Yue Hu --- drivers/gpu/drm/msm/msm_gpu.c | 3 ++- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 3 ++- 2 files changed, 4

Re: [PATCH libdrm] libdrm: wrap new flexible syncobj query interface

2019-07-25 Thread Lionel Landwerlin
On 24/07/2019 11:01, Chunming Zhou wrote: Signed-off-by: Chunming Zhou Cc: Lionel Landwerlin Cc: Christian König --- amdgpu/amdgpu-symbol-check | 1 + amdgpu/amdgpu.h| 18 ++ amdgpu/amdgpu_cs.c | 10 ++ include/drm/drm.h | 3 ++-

[PATCH libdrm] libdrm: wrap new flexible syncobj query interface v2

2019-07-25 Thread Chunming Zhou
v2: nit-picks fix Signed-off-by: Chunming Zhou Cc: Lionel Landwerlin Cc: Christian König --- amdgpu/amdgpu-symbol-check | 1 + amdgpu/amdgpu.h| 18 ++ amdgpu/amdgpu_cs.c | 10 ++ include/drm/drm.h | 3 ++- xf86drm.c | 15

Re: [PATCH libdrm] libdrm: wrap new flexible syncobj query interface v2

2019-07-25 Thread Koenig, Christian
Am 25.07.19 um 10:02 schrieb Lionel Landwerlin: > On 25/07/2019 10:52, Chunming Zhou wrote: >> v2: nit-picks fix >> >> Signed-off-by: Chunming Zhou >> Cc: Lionel Landwerlin >> Cc: Christian König > > > For the xf86drm.[ch] part : Reviewed-by: Lionel Landwerlin > > > I'll let someone from AMD

Re: [PATCH v2 2/3] dt-bindings: display: sii902x: Change audio mclk binding

2019-07-25 Thread Benjamin Gaignard
Le lun. 22 juil. 2019 à 18:06, Olivier Moysan a écrit : > > As stated in SiL9022/24 datasheet, master clock is not required for I2S. > Make mclk property optional in DT bindings. > > Fixes: 3f18021f43a3 ("dt-bindings: display: sii902x: Add HDMI audio bindings") > Applied on drm-misc-next. Thanks,

Re: [PATCH v2 3/3] drm/bridge: sii902x: make audio mclk optional

2019-07-25 Thread Benjamin Gaignard
Le lun. 22 juil. 2019 à 18:06, Olivier Moysan a écrit : > > The master clock on i2s bus is not mandatory, > as sii902X internal PLL can be used instead. > Make use of mclk optional. Applied on drm-misc-next. Thanks, Benjamin > > Signed-off-by: Olivier Moysan > Reviewed-by: Jyri Sarha >

Re: [PATCH v2 1/3] drm/bridge: sii902x: fix missing reference to mclk clock

2019-07-25 Thread Benjamin Gaignard
Le lun. 22 juil. 2019 à 18:06, Olivier Moysan a écrit : > > Add devm_clk_get call to retrieve reference to master clock. > > Fixes: ff5781634c41 ("drm/bridge: sii902x: Implement HDMI audio support") > > Signed-off-by: Olivier Moysan > Reviewed-by: Jyri Sarha > Acked-by: Andrzej Hajda --- >

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 Yann HN (a...@21xayah.com) changed: What|Removed |Added CC||a...@21xayah.com ---

Recall: [PATCH libdrm] libdrm: wrap new flexible syncobj query interface v2

2019-07-25 Thread Zhou, David(ChunMing)
Zhou, David(ChunMing) would like to recall the message, "[PATCH libdrm] libdrm: wrap new flexible syncobj query interface v2". ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 111042] Installer ends with WARNING: amdgpu dkms failed for running kernel

2019-07-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111042 freedesk...@fractalyse.info changed: What|Removed |Added Resolution|--- |FIXED

Re: [PATCH] drm/stm: attach gem fence to atomic state

2019-07-25 Thread Benjamin Gaignard
Le ven. 19 juil. 2019 à 15:35, Philippe CORNU a écrit : > > Hi Lucas & Ahmad, > > Many thanks for your patch, > > Tested successfully on stm32mp157-dk2 (weston & drm). > > Acked-by: Philippe Cornu > Tested-by: Philippe Cornu Applied on drm-misc-next. Thanks, Benjamin > > Philippe :-) > > On

[PATCH] gpu: drm: qxl: Fix possible null-pointer dereferences in qxl_crtc_atomic_flush()

2019-07-25 Thread Jia-Ju Bai
In qxl_crtc_atomic_flush(), there is an if statement on line 376 to check whether crtc->state is NULL: if (crtc->state && crtc->state->event) When crtc->state is NULL and qxl_crtc_update_monitors_config() is call, qxl_crtc_update_monitors_config() uses crtc->state on line 326: if

Re: [PATCH v2 0/9] drm/tinydrm: Move mipi_dbi

2019-07-25 Thread Noralf Trønnes
Den 22.07.2019 12.43, skrev Noralf Trønnes: > This series ticks off the last tinydrm todo entry and moves out mipi_dbi > to be a core helper. > > It splits struct mipi_dbi into an interface part and a display pipeline > part (upload framebuffer over SPI). I also took the opportunity to > rename

Re: [PATCH] backlight: lms283gf05: Fix a typo in the description passed to 'devm_gpio_request_one()'

2019-07-25 Thread Daniel Thompson
On Wed, Jul 24, 2019 at 11:38:28PM +0200, Christophe JAILLET wrote: > The description passed to 'devm_gpio_request_one()' should be related to > LMS283GF05, not LMS285GF05. > > Signed-off-by: Christophe JAILLET Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/lms283gf05.c | 2 +-

[PATCH 2/3] drm/tinydrm: Rename folder to tiny

2019-07-25 Thread Noralf Trønnes
The drm in tinydrm is superfluous so rename to tiny. Suggested-by: Daniel Vetter Signed-off-by: Noralf Trønnes --- MAINTAINERS | 12 ++-- drivers/gpu/drm/Kconfig | 2 +- drivers/gpu/drm/Makefile | 2 +-

[PATCH 3/3] drm/gm12u320: Move driver to drm/tiny

2019-07-25 Thread Noralf Trønnes
Move the driver to the new haven for tiny DRM drivers. Cc: Hans de Goede Suggested-by: Daniel Vetter Signed-off-by: Noralf Trønnes --- MAINTAINERS | 2 +- drivers/gpu/drm/Kconfig | 2 -- drivers/gpu/drm/Makefile |

[PATCH 0/3] drm/tinydrm: Rename to drm/tiny

2019-07-25 Thread Noralf Trønnes
This is the final polish on tinydrm turning it into _the_ place for tiny DRM drivers. Noralf. Noralf Trønnes (3): drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM drm/tinydrm: Rename folder to tiny drm/gm12u320: Move driver to drm/tiny MAINTAINERS | 14

[PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-07-25 Thread Noralf Trønnes
This makes the tiny drivers visible by default without having to enable a knob. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Makefile| 2 +- drivers/gpu/drm/tinydrm/Kconfig | 37 +++-- 2 files changed, 22 insertions(+), 17 deletions(-) diff --git

[PATCH 0/1] This patch fixes connection detection for monitors w/o DDC.

2019-07-25 Thread Oleksandr Suvorov
Even in source code of this driver there is an author's description: /* * Even if we have an I2C bus, we can't assume that the cable * is disconnected if drm_probe_ddc fails. Some cables don't * wire the DDC pins, or the I2C bus might not be working at * all. */

[PATCH 1/1] drm/bridge: vga-dac: Fix detect of monitor connection

2019-07-25 Thread Oleksandr Suvorov
DDC and VGA channels are independent, and therefore we cannot decide whether the monitor is connected or not, depending on the information from the DDC. So the monitor should always be considered connected. Thus there is no reason to use connector detect callback for this driver. Fixes DRM error

Re: [RFC PATCH 01/11] devfreq: exynos-bus: Extract exynos_bus_profile_init()

2019-07-25 Thread Chanwoo Choi
2019년 7월 24일 (수) 오전 8:09, Artur Świgoń 님이 작성: > > This patch adds a new static function, exynos_bus_profile_init(), extracted > from exynos_bus_probe(). > > Signed-off-by: Artur Świgoń > --- > drivers/devfreq/exynos-bus.c | 106 --- > 1 file changed, 60

Re: [PATCH 0/3] drm/tinydrm: Rename to drm/tiny

2019-07-25 Thread Noralf Trønnes
Den 25.07.2019 14.06, skrev Daniel Vetter: > On Thu, Jul 25, 2019 at 12:51:29PM +0200, Noralf Trønnes wrote: >> This is the final polish on tinydrm turning it into _the_ place for tiny >> DRM drivers. >> >> Noralf. >> >> Noralf Trønnes (3): >> drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

Re: [RFC PATCH 02/11] devfreq: exynos-bus: Extract exynos_bus_profile_init_passive()

2019-07-25 Thread Chanwoo Choi
2019년 7월 24일 (수) 오전 8:07, Artur Świgoń 님이 작성: > > This patch adds a new static function, exynos_bus_profile_init_passive(), > extracted from exynos_bus_probe(). > > Signed-off-by: Artur Świgoń > --- > drivers/devfreq/exynos-bus.c | 70 +--- > 1 file changed, 42

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-25 Thread Christoph Hellwig
On Wed, Jul 24, 2019 at 07:38:07AM -0400, Laura Abbott wrote: > It's not just an optimization for Ion though. Ion was designed to > let the callers choose between system and multiple CMA heaps. Who cares about ion? That some out of tree android crap that should not be relevant for upstream

Re: [PATCH v3 0/4] backlight: Expose brightness curve type through sysfs

2019-07-25 Thread Lee Jones
On Mon, 22 Jul 2019, Matthias Kaehlcke wrote: > On Tue, Jul 09, 2019 at 12:00:03PM -0700, Matthias Kaehlcke wrote: > > Backlight brightness curves can have different shapes. The two main > > types are linear and non-linear curves. The human eye doesn't > > perceive linearly increasing/decreasing

Re: OLED panel brightness support

2019-07-25 Thread Daniel Vetter
On Thu, Jul 25, 2019 at 03:35:40PM +0800, Kai-Heng Feng wrote: > at 00:03, wrote: > > > > -Original Message- > > > From: Daniel Vetter On Behalf Of Daniel Vetter > > > Sent: Wednesday, July 24, 2019 6:49 AM > > > To: Kai-Heng Feng > > > Cc: dri-devel@lists.freedesktop.org; Anthony

Re: [PATCH] gpu: drm: qxl: Fix possible null-pointer dereferences in qxl_crtc_atomic_flush()

2019-07-25 Thread Daniel Vetter
On Thu, Jul 25, 2019 at 06:21:27PM +0800, Jia-Ju Bai wrote: > In qxl_crtc_atomic_flush(), there is an if statement on line 376 to > check whether crtc->state is NULL: > if (crtc->state && crtc->state->event) > > When crtc->state is NULL and qxl_crtc_update_monitors_config() is call, >

Re: [PATCH v2] backlight: rave-sp: don't touch initial state and register with correct device

2019-07-25 Thread Lee Jones
On Mon, 08 Jul 2019, Lucas Stach wrote: > This way the backlight can be referenced through its device node and > enabling/disabling can be managed through the panel driver. > > Signed-off-by: Lucas Stach > --- > drivers/video/backlight/rave-sp-backlight.c | 10 -- > 1 file changed, 8

Re: [PATCH 0/3] drm/tinydrm: Rename to drm/tiny

2019-07-25 Thread Daniel Vetter
On Thu, Jul 25, 2019 at 12:51:29PM +0200, Noralf Trønnes wrote: > This is the final polish on tinydrm turning it into _the_ place for tiny > DRM drivers. > > Noralf. > > Noralf Trønnes (3): > drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM > drm/tinydrm: Rename folder to tiny >

Re: [PATCH 1/1] drm/bridge: vga-dac: Fix detect of monitor connection

2019-07-25 Thread Daniel Vetter
On Thu, Jul 25, 2019 at 11:05:24AM +, Oleksandr Suvorov wrote: > DDC and VGA channels are independent, and therefore > we cannot decide whether the monitor is connected or not, > depending on the information from the DDC. > > So the monitor should always be considered connected. > Thus there

Re: Recall: [PATCH libdrm] libdrm: wrap new flexible syncobj query interface v2

2019-07-25 Thread Daniel Vetter
On Thu, Jul 25, 2019 at 08:34:39AM +, Zhou, David(ChunMing) wrote: > Zhou, David(ChunMing) would like to recall the message, "[PATCH libdrm] > libdrm: wrap new flexible syncobj query interface v2". This button doesn't work :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation

Re: [PATCH] drm/syncobj: extend syncobj query ability v2

2019-07-25 Thread Daniel Vetter
On Wed, Jul 24, 2019 at 07:48:23AM +, Koenig, Christian wrote: > Am 24.07.19 um 08:32 schrieb zhoucm1: > > > > > > On 2019年07月24日 03:20, Lionel Landwerlin wrote: > >> On 23/07/2019 17:21, Chunming Zhou wrote: > >>> user space needs a flexiable query ability. > >>> So that umd can get last

Re: [PATCH] drm/bridge: sii902x: add audio graph card support

2019-07-25 Thread Benjamin Gaignard
Le jeu. 11 juil. 2019 à 13:09, Jyri Sarha a écrit : > > On 03/07/2019 11:04, Olivier Moysan wrote: > > Implement get_dai_id callback of audio HDMI codec > > to support ASoC audio graph card. > > HDMI audio output has to be connected to sii902x port 3. > > get_dai_id callback maps this port to

Re: [PATCH v6 2/5] dma-buf: heaps: Add heap helpers

2019-07-25 Thread Christoph Hellwig
On Wed, Jul 24, 2019 at 11:20:31AM -0400, Andrew F. Davis wrote: > Well then lets think on this. A given buffer can have 3 owners states > (CPU-owned, Device-owned, and Un-owned). These are based on the caching > state from the CPU perspective. > > If a buffer is CPU-owned then we (Linux) can

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-25 Thread Christoph Hellwig
On Wed, Jul 24, 2019 at 10:08:54AM +0200, Benjamin Gaignard wrote: > CMA has made possible to get large regions of memories and to give some > priority on device allocating pages on it. I don't think that possible > with system > heap so I suggest to keep CMA heap if we want to be able to port a

Re: [RFC PATCH 04/11] devfreq: exynos-bus: Clean up code

2019-07-25 Thread Chanwoo Choi
2019년 7월 24일 (수) 오전 8:07, Artur Świgoń 님이 작성: > > This patch adds minor improvements to the exynos-bus driver. > > Signed-off-by: Artur Świgoń > --- > drivers/devfreq/exynos-bus.c | 49 > 1 file changed, 22 insertions(+), 27 deletions(-) > > diff --git

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-25 Thread Christoph Hellwig
On Wed, Jul 24, 2019 at 11:46:01AM -0400, Andrew F. Davis wrote: > https://patchwork.kernel.org/patch/10863957/ > > It's actually a more simple heap type IMHO, but the logic inside is > incompatible with the system/CMA heaps, if you move any of their code > into the core framework then this heap

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-25 Thread Christoph Hellwig
On Wed, Jul 24, 2019 at 11:46:24AM -0700, John Stultz wrote: > I'm still not understanding how this would work. Benjamin and Laura > already commented on this point, but for a simple example, with the > HiKey boards, the DRM driver requires contiguous memory for the > framebuffer, but the GPU can

Re: [PATCH v7 2/5] dma-buf: heaps: Add heap helpers

2019-07-25 Thread Christoph Hellwig
> +struct dma_buf *heap_helper_export_dmabuf( > + struct heap_helper_buffer *helper_buffer, > + int fd_flags) Indentation seems odd here as it doesn't follow any of the usual schools for multi-level prototypes. But maybe shortening some

Re: [RFC PATCH 03/11] devfreq: exynos-bus: Change goto-based logic to if-else logic

2019-07-25 Thread Chanwoo Choi
2019년 7월 24일 (수) 오전 8:08, Artur Świgoń 님이 작성: > > This patch improves code readability by changing the following construct: > > >if (cond) > >goto passive; > >foo(); > >goto out; > >passive: > >bar(); > >out: > > into this: > > >if (cond) > >bar(); > >else >

Re: [PATCH v7 3/5] dma-buf: heaps: Add system heap to dmabuf heaps

2019-07-25 Thread Christoph Hellwig
> +struct system_heap { > + struct dma_heap *heap; > +} sys_heap; It seems like this structure could be removed and if would improve the code flow. > +static struct dma_heap_ops system_heap_ops = { > + .allocate = system_heap_allocate, > +}; > + > +static int system_heap_create(void) >

Re: [PATCH v2 6/7] drm/panfrost: Add support for GPU heap allocations

2019-07-25 Thread Robin Murphy
Hi Rob, On 25/07/2019 02:10, Rob Herring wrote: [...] @@ -328,6 +427,18 @@ static irqreturn_t panfrost_mmu_irq_handler(int irq, void *data) access_type = (fault_status >> 8) & 0x3; source_id = (fault_status >> 16); + /* Page fault only */ +

Re: OLED panel brightness support

2019-07-25 Thread Sam Ravnborg
Hi Daniel. > > > The next question is, how do we change the brightness level for OLED > > displays? Is changing gamma value a good way to do it? > > There's no overall amplifier knob to set general brightness on these? I just looked up two random OLED controllers. They have a "Contrast" -

Re: [PATCH 4/7] drm/radeon: Fill out gem_object->resv

2019-07-25 Thread Daniel Vetter
On Tue, Jun 25, 2019 at 10:52:17PM +0200, Sam Ravnborg wrote: > On Tue, Jun 25, 2019 at 10:42:05PM +0200, Daniel Vetter wrote: > > That way we can ditch our gem_prime_res_obj implementation. Since ttm > > absolutely needs the right reservation object all the boilerplate is > > already there and we

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-25 Thread Benjamin Gaignard
Le jeu. 25 juil. 2019 à 14:52, Christoph Hellwig a écrit : > > On Wed, Jul 24, 2019 at 11:46:24AM -0700, John Stultz wrote: > > I'm still not understanding how this would work. Benjamin and Laura > > already commented on this point, but for a simple example, with the > > HiKey boards, the DRM

Re: [RFC PATCH 08/11] arm: dts: exynos: Add parents and #interconnect-cells to Exynos4412

2019-07-25 Thread Chanwoo Choi
2019년 7월 24일 (수) 오전 8:07, Artur Świgoń 님이 작성: > > This patch adds two fields tp the Exynos4412 DTS: > - parent: to declare connections between nodes that are not in a > parent-child relation in devfreq; > - #interconnect-cells: required by the interconnect framework. > > Please note that

[PATCH 0/4] RESEND: ditch gem_prime_res_obj hook

2019-07-25 Thread Daniel Vetter
Hi all, Resending this little patch series (everything else landed now), so that we can move forward with Gerd's series to embed a gem_bo in the ttm_bo (he rebased on top of this). Review/testing much appreciated. Thanks, Daniel Daniel Vetter (4): drm/radeon: Fill out gem_object->resv

[PATCH 1/4] drm/radeon: Fill out gem_object->resv

2019-07-25 Thread Daniel Vetter
That way we can ditch our gem_prime_res_obj implementation. Since ttm absolutely needs the right reservation object all the boilerplate is already there and we just have to wire it up correctly. Note that gem/prime doesn't care when we do this, as long as we do it before the bo is registered and

[PATCH 2/4] drm/nouveau: Fill out gem_object->resv

2019-07-25 Thread Daniel Vetter
That way we can ditch our gem_prime_res_obj implementation. Since ttm absolutely needs the right reservation object all the boilerplate is already there and we just have to wire it up correctly. Note that gem/prime doesn't care when we do this, as long as we do it before the bo is registered and

[PATCH 3/4] drm/amdgpu: Fill out gem_object->resv

2019-07-25 Thread Daniel Vetter
That way we can ditch our gem_prime_res_obj implementation. Since ttm absolutely needs the right reservation object all the boilerplate is already there and we just have to wire it up correctly. Note that gem/prime doesn't care when we do this, as long as we do it before the bo is registered and

Re: [RFC PATCH 03/11] devfreq: exynos-bus: Change goto-based logic to if-else logic

2019-07-25 Thread Chanwoo Choi
2019년 7월 25일 (목) 오후 9:56, Chanwoo Choi 님이 작성: > > 2019년 7월 24일 (수) 오전 8:08, Artur Świgoń 님이 작성: > > > > This patch improves code readability by changing the following construct: > > > > >if (cond) > > >goto passive; > > >foo(); > > >goto out; > > >passive: > > >bar(); > >

[PATCH 4/4] drm/prime: Ditch gem_prime_res_obj hook

2019-07-25 Thread Daniel Vetter
Everyone is just using gem_object->resv now. Acked-by: Gerd Hoffmann Cc: Gerd Hoffmann Reviewed-by: Emil Velikov Signed-off-by: Daniel Vetter Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul --- Documentation/gpu/todo.rst | 9 -

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-25 Thread Andrew F. Davis
On 7/25/19 8:50 AM, Christoph Hellwig wrote: > On Wed, Jul 24, 2019 at 11:46:01AM -0400, Andrew F. Davis wrote: >> https://patchwork.kernel.org/patch/10863957/ >> >> It's actually a more simple heap type IMHO, but the logic inside is >> incompatible with the system/CMA heaps, if you move any of

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-25 Thread Andrew F. Davis
On 7/25/19 8:48 AM, Christoph Hellwig wrote: > On Wed, Jul 24, 2019 at 07:38:07AM -0400, Laura Abbott wrote: >> It's not just an optimization for Ion though. Ion was designed to >> let the callers choose between system and multiple CMA heaps. > > Who cares about ion? That some out of tree

Re: [PATCH v3 2/7] drivers: Introduce device lookup variants by of_node

2019-07-25 Thread Lee Jones
On Tue, 23 Jul 2019, Suzuki K Poulose wrote: > Introduce wrappers for {bus/driver/class}_find_device() to > locate devices by its of_node. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: dri-devel@lists.freedesktop.org > Cc: David Airlie > Cc: Daniel Vetter > Cc:

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-25 Thread Christoph Hellwig
On Thu, Jul 25, 2019 at 09:47:11AM -0400, Andrew F. Davis wrote: > This is a central allocator, it is not tied to any one device. If we > knew the one device ahead of time we would just use the existing dma_alloc. > > We might be able to solve some of that with late mapping after all the >

Re: [PATCH 06/10] drm/tinydrm: Move tinydrm_spi_transfer()

2019-07-25 Thread Noralf Trønnes
Den 18.07.2019 14.14, skrev Noralf Trønnes: > > > Den 17.07.2019 21.48, skrev David Lechner: >> On 7/17/19 6:58 AM, Noralf Trønnes wrote: >>> This is only used by mipi-dbi drivers so move it there. >>> >>> The reason this isn't moved to the SPI subsystem is that it will in a >>> later patch

Re: [PATCH 0/3] drm/tinydrm: Rename to drm/tiny

2019-07-25 Thread Sam Ravnborg
Hi Noralf. On Thu, Jul 25, 2019 at 02:46:08PM +0200, Noralf Trønnes wrote: > > > Den 25.07.2019 14.06, skrev Daniel Vetter: > > On Thu, Jul 25, 2019 at 12:51:29PM +0200, Noralf Trønnes wrote: > >> This is the final polish on tinydrm turning it into _the_ place for tiny > >> DRM drivers. > >> >

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #20 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) --- I haven't been able to reproduce this on my setup yet with xf86-video-amdgpu on Arch's 5.2.2 kernel. I don't see anything really missing between that and staging that

[PULL] drm-misc-fixes

2019-07-25 Thread Sean Paul
Hi all, Substitute-Maarten here for another pull request. This week is pretty light, as you would expect. I merged a leftover nugget from drm-misc-next that didn't make -rc1 and am abusing covering for Maarten by sneaking in a handful of msm changes to avoid having to send 2 pulls.

[PATCH] drm/msm: Use generic bulk clock function

2019-07-25 Thread Jordan Crouse
Remove the homebrewed bulk clock get function and replace it with devm_clk_bulk_get_all(). Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- drivers/gpu/drm/msm/msm_drv.c | 40 --- drivers/gpu/drm/msm/msm_drv.h | 1

[PATCH] drm/msm: Annotate intentional switch statement fall throughs

2019-07-25 Thread Jordan Crouse
Explicitly mark intentional fall throughs in switch statements to keep -Wimplicit-fallthrough from complaining. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 + 3 files

Re: [PATCH v3 0/4] backlight: Expose brightness curve type through sysfs

2019-07-25 Thread Matthias Kaehlcke
On Thu, Jul 25, 2019 at 12:15:41PM +0100, Lee Jones wrote: > On Mon, 22 Jul 2019, Matthias Kaehlcke wrote: > > > On Tue, Jul 09, 2019 at 12:00:03PM -0700, Matthias Kaehlcke wrote: > > > Backlight brightness curves can have different shapes. The two main > > > types are linear and non-linear

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-25 Thread Benjamin Gaignard
Le jeu. 25 juil. 2019 à 16:33, Christoph Hellwig a écrit : > > On Thu, Jul 25, 2019 at 03:20:11PM +0200, Benjamin Gaignard wrote: > > > But that just means we need a flag that memory needs to be contiguous, > > > which totally makes sense at the API level. But CMA is not the only > > > source of

Re: [PATCH v6 2/5] dma-buf: heaps: Add heap helpers

2019-07-25 Thread Rob Clark
On Thu, Jul 25, 2019 at 5:41 AM Christoph Hellwig wrote: > > On Wed, Jul 24, 2019 at 11:20:31AM -0400, Andrew F. Davis wrote: > > Well then lets think on this. A given buffer can have 3 owners states > > (CPU-owned, Device-owned, and Un-owned). These are based on the caching > > state from the

Re: [PATCH 5/7] drm/amd/display: Use proper enum conversion functions

2019-07-25 Thread Li, Sun peng (Leo)
On 2019-07-18 11:16 p.m., Nathan Chancellor wrote: > On Wed, Jul 03, 2019 at 10:52:16PM -0700, Nathan Chancellor wrote: >> clang warns: >> >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_pp_smu.c:336:8: >> warning: implicit conversion from enumeration type 'enum smu_clk_type' >> to

[Bug 204181] NULL pointer dereference regression in amdgpu

2019-07-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #18 from Michel Dänzer (mic...@daenzer.net) --- (In reply to Yann HN from comment #17) > A friend suggested me to install some packages to enhance the GPU Support, > one of them was "xf86-video-amdgpu". > > Seams like that package

[PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support

2019-07-25 Thread Sam Ravnborg
There was no users left - so drop the code to support EARLY_FB_BLANK. This patch removes the support in backlight, and drop the notifier in fbmem. That EARLY_FB_BLANK is not used can be verified that no driver set any of: lcd_ops.early_set_power() lcd_ops.r_early_set_power() Noticed

Re: [PATCH 0/1] This patch fixes connection detection for monitors w/o DDC.

2019-07-25 Thread maxime.rip...@free-electrons.com
65;5603;1c On Thu, Jul 25, 2019 at 11:05:23AM +, Oleksandr Suvorov wrote: > > Even in source code of this driver there is an author's description: > /* > * Even if we have an I2C bus, we can't assume that the cable > * is disconnected if drm_probe_ddc fails. Some cables don't >

Re: [PATCH v3 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding

2019-07-25 Thread Torsten Duwe
On Mon, Jul 22, 2019 at 11:51:36AM -0700, Vasily Khoruzhick wrote: > On Mon, Jul 22, 2019 at 8:12 AM Torsten Duwe wrote: > > > > The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed > > for portable devices. > > > > Add a binding document for it. > > I believe you'll have to

[PATCH v3 6a/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding

2019-07-25 Thread Torsten Duwe
The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed for portable devices. Add a binding document for it. Signed-off-by: Icenowy Zheng Signed-off-by: Vasily Khoruzhick Reviewed-by: Rob Herring Signed-off-by: Torsten Duwe Reviewed-by: Laurent Pinchart ---

Re: [PATCH] drm/msm: Use generic bulk clock function

2019-07-25 Thread Stephen Boyd
Quoting Jordan Crouse (2019-07-25 09:53:55) > Remove the homebrewed bulk clock get function and replace it with > devm_clk_bulk_get_all(). > > Signed-off-by: Jordan Crouse > --- Reviewed-by: Stephen Boyd

  1   2   >