linux-next: build failure after merge of the drm-misc tree

2019-08-06 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/amd/amdgpu/amdgpu_object.c: In function 'amdgpu_bo_release_notify': drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:1245:28: error: 'struct ttm_buffer_object' has no member

[Bug 108641] Shader causes Interlaced dark lines on R600g in XCOM2

2019-08-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108641 steelwin...@gmail.com changed: What|Removed |Added Summary|Interlaced dark lines in|Shader causes Interlaced

[PATCH 1/3] drm: add gem ttm helpers

2019-08-06 Thread Gerd Hoffmann
Now with ttm_buffer_object being a subclass of drm_gem_object we can easily lookup ttm_buffer_object for a given drm_gem_object, which in turm allows to create common helper functions. This patch starts off with dump mmap helpers. Signed-off-by: Gerd Hoffmann ---

[PATCH 2/3] drm/vram: switch vram helpers to use the new ttm helpers.

2019-08-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/drm/drm_gem_vram_helper.h | 7 +-- drivers/gpu/drm/drm_gem_vram_helper.c | 48 --- .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +- drivers/gpu/drm/Kconfig | 1 + 4 files changed, 4

[PATCH 0/3] drm: add gem ttm helpers

2019-08-06 Thread Gerd Hoffmann
Gerd Hoffmann (3): drm: add gem ttm helpers drm/vram: switch vram helpers to use the new ttm helpers. drm/qxl: switch qxl to use the new ttm helpers. drivers/gpu/drm/qxl/qxl_drv.h | 4 +- drivers/gpu/drm/qxl/qxl_object.h | 5 --

[PATCH 3/3] drm/qxl: switch qxl to use the new ttm helpers.

2019-08-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.h| 4 +--- drivers/gpu/drm/qxl/qxl_object.h | 5 - drivers/gpu/drm/qxl/qxl_drv.c| 2 +- drivers/gpu/drm/qxl/qxl_dumb.c | 17 - drivers/gpu/drm/qxl/qxl_ioctl.c | 5 +++-- drivers/gpu/drm/qxl/Kconfig

Re: [PATCH 1/3] drm: add gem ttm helpers

2019-08-06 Thread Daniel Vetter
On Tue, Aug 06, 2019 at 03:34:52PM +0200, Gerd Hoffmann wrote: > Now with ttm_buffer_object being a subclass of drm_gem_object we can > easily lookup ttm_buffer_object for a given drm_gem_object, which in > turm allows to create common helper functions. This patch starts off > with dump mmap

Re: [PATCH v2 2/3] dt-bindings: display: amlogic,meson-vpu: convert to yaml

2019-08-06 Thread Neil Armstrong
Hi Rob, On 06/08/2019 17:08, Rob Herring wrote: > On Tue, Aug 6, 2019 at 6:44 AM Neil Armstrong wrote: >> >> Now that we have the DT validation in place, let's convert the device tree >> bindings for the Amlogic Display Controller over to YAML schemas. >> >> The original example has a leftover

[PATCH v3 1/3] drm: Add helper to compare edids.

2019-08-06 Thread Stanislav Lisovskiy
Many drivers would benefit from using drm helper to compare edid, rather than bothering with own implementation. v2: Added documentation for this function. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/drm_edid.c | 33 + include/drm/drm_edid.h | 9

Re: [PATCH v1 10/16] drm/panel: ili9322: move bus_flags to get_modes()

2019-08-06 Thread Linus Walleij
On Sun, Aug 4, 2019 at 10:17 PM Sam Ravnborg wrote: > To prepare the driver to receive drm_connector only in the get_modes() > callback, move bus_flags handling to ili9322_get_modes(). > > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Sam Ravnborg OK I don't see where this is going

[PATCH v3 0/3] Send a hotplug when edid changes

2019-08-06 Thread Stanislav Lisovskiy
This series introduce to drm a way to determine if something else except connection_status had changed during probing, which can be used by other drivers as well. Another i915 specific part uses this approach to determine if edid had changed without changing the connection status and send a

Re: [PATCH] drm/amd/powerplay: Zero initialize some variables

2019-08-06 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Aug 4, 2019 at 9:21 PM Quan, Evan wrote: > > Thanks Nathan. The patch is reviewed-by: Evan Quan > > > -Original Message- > > From: Nathan Chancellor > > Sent: Monday, August 05, 2019 4:37 AM > > To: Quan, Evan ; Deucher, Alexander > > ; Koenig, Christian

Re: [PATCH v2 2/3] dt-bindings: display: amlogic,meson-vpu: convert to yaml

2019-08-06 Thread Rob Herring
On Tue, Aug 6, 2019 at 6:44 AM Neil Armstrong wrote: > > Now that we have the DT validation in place, let's convert the device tree > bindings for the Amlogic Display Controller over to YAML schemas. > > The original example has a leftover "dmc" memory cell, that has been > removed in the yaml

Re: [RFC PATCH 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

2019-08-06 Thread Leonard Crestez
On 23.07.2019 15:21, Artur Świgoń wrote: > +static int exynos_bus_icc_aggregate(struct icc_node *node, u32 avg_bw, > + u32 peak_bw, u32 *agg_avg, u32 *agg_peak) > +{ > + *agg_peak = *agg_avg = peak_bw; > + > + return 0; > +} The only current provider

[PATCH 2/4 v3] drm/panel: simple: Add TI nspire panel bindings

2019-08-06 Thread Linus Walleij
Add bindings for the TI NSPIRE simple display panels. Cc: devicet...@vger.kernel.org Signed-off-by: Linus Walleij --- ChanegLog v2->v3: - Switch to GPL-2.0-only OR BSD-2-Clause license - Use a simple enum for the compatible - Use the new nifty panel-common.yaml, tested on linux-next ChangeLog

Re: [PATCH 1/2] drm: add cache support for arm64

2019-08-06 Thread Rob Clark
On Tue, Aug 6, 2019 at 1:48 AM Christoph Hellwig wrote: > > This goes in the wrong direction. drm_cflush_* are a bad API we need to > get rid of, not add use of it. The reason for that is two-fold: > > a) it doesn't address how cache maintaince actually works in most > platforms. When

Re: [PATCH v2 1/3] dt-bindings: display: amlogic,meson-dw-hdmi: convert to yaml

2019-08-06 Thread Rob Herring
On Tue, Aug 6, 2019 at 6:44 AM Neil Armstrong wrote: > > Now that we have the DT validation in place, let's convert the device tree > bindings for the Amlogic Synopsys DW-HDMI specifics over to YAML schemas. > > The original example and usage of clock-names uses a reversed "isfr" > and "iahb"

Re: [PATCH 2/4 v3] drm/panel: simple: Add TI nspire panel bindings

2019-08-06 Thread Rob Herring
On Tue, Aug 6, 2019 at 7:55 AM Linus Walleij wrote: > > Add bindings for the TI NSPIRE simple display panels. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Linus Walleij > --- > ChanegLog v2->v3: > - Switch to GPL-2.0-only OR BSD-2-Clause license > - Use a simple enum for the compatible >

[Bug 111307] critical fhghg

2019-08-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111307 Bug ID: 111307 Summary: critical fhghg Product: Mesa Version: 19.0 Hardware: Alpha OS: Linux (All) Status: NEW Severity: blocker Priority:

[PATCH v3 2/3] drm: Introduce change counter to drm_connector

2019-08-06 Thread Stanislav Lisovskiy
This counter will be used by drm_helper_probe_detect caller to determine if something else had changed except connection status, like for example edid. Hardware specific drivers are responsible for updating this counter when some change is detected to notify the drm part, which can trigger for

[PATCH v3 3/3] drm/i915: Send hotplug event if edid had changed.

2019-08-06 Thread Stanislav Lisovskiy
Added edid checking to dp and hdmi edid setting functions, which are called from detect hooks. The result currently is propagated to calling layer using drm_connector->change_counter(proposed by Daniel Vetter). drm_helper_hpd_irq_event and intel_encoder_hotplug are currently both responsible for

Re: [LKP] [drm/mgag200] 90f479ae51: vm-scalability.median -18.8% regression

2019-08-06 Thread Chen, Rong A
Hi, On 8/5/2019 6:25 PM, Thomas Zimmermann wrote: Hi Am 05.08.19 um 09:28 schrieb Rong Chen: Hi, On 8/5/19 3:02 PM, Feng Tang wrote: Hi Thomas, On Sun, Aug 04, 2019 at 08:39:19PM +0200, Thomas Zimmermann wrote: Hi I did some further analysis on this problem and found that the blinking

Re: [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-08-06 Thread Josh Poimboeuf
On Mon, Aug 05, 2019 at 09:29:53PM +0200, Sedat Dilek wrote: > On Wed, Jul 31, 2019 at 2:25 PM Sedat Dilek wrote: > > > > On Fri, Jul 26, 2019 at 9:30 PM Chris Wilson > > wrote: > > > > > > Quoting Thomas Gleixner (2019-07-26 20:18:32) > > > > On Fri, 26 Jul 2019, Chris Wilson wrote: > > > > >

Re: [PATCH v3 0/3] Send a hotplug when edid changes

2019-08-06 Thread Daniel Vetter
On Tue, Aug 06, 2019 at 03:55:48PM +0300, Stanislav Lisovskiy wrote: > This series introduce to drm a way to determine if something else > except connection_status had changed during probing, which > can be used by other drivers as well. Another i915 specific part > uses this approach to determine

[PATCH 4/4 v3] ARM: nspire: Move CLCD set-up to device tree

2019-08-06 Thread Linus Walleij
This moves the nspire over to using the device tree to set-up and probe the PL111 DRM driver and use the panels from the simple-panel drivers. Cc: Daniel Tang Cc: Fabian Vogt Tested-by: Fabian Vogt Acked-by: Sam Ravnborg Signed-off-by: Linus Walleij --- ChangeLog v2->v3: - Use single port

Re: [PATCH v3 0/3] Send a hotplug when edid changes

2019-08-06 Thread Lisovskiy, Stanislav
On Tue, 2019-08-06 at 15:51 +0200, Daniel Vetter wrote: > On Tue, Aug 06, 2019 at 03:55:48PM +0300, Stanislav Lisovskiy wrote: > > This series introduce to drm a way to determine if something else > > except connection_status had changed during probing, which > > can be used by other drivers as

Re: [PATCH v2] MAINTAINERS: update amdkfd maintainer

2019-08-06 Thread Alex Deucher
On Thu, Jul 4, 2019 at 12:58 PM Kuehling, Felix wrote: > > On 2019-07-04 2:32 a.m., Oded Gabbay wrote: > > I'm leaving the role of amdkfd maintainer. Therefore, update the relevant > > entry in the MAINTAINERS file with the name of the new maintainer. > > > > Good Luck! > > Thank you Oded! Thanks

[PATCH 5/8] dma-buf: further relax reservation_object_add_shared_fence

2019-08-06 Thread Christian König
Other cores don't busy wait any more and we removed the last user of checking the seqno for changes. Drop updating the number for shared fences altogether. Signed-off-by: Christian König --- drivers/dma-buf/reservation.c| 6 --

[PATCH 1/8] dma-buf: fix busy wait for new shared fences

2019-08-06 Thread Christian König
When reservation_object_add_shared_fence is replacing an old fence with a new one we should not drop the old one before the new one is in place. Otherwise other cores can busy wait for the new one to appear. Signed-off-by: Christian König --- drivers/dma-buf/reservation.c | 14 +++---

[PATCH 7/8] dma-buf: add reservation_object_fences helper

2019-08-06 Thread Christian König
Add a new helper to get a consistent set of pointers from the reservation object. While at it group all access helpers together in the header file. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c | 27 ++-- drivers/dma-buf/reservation.c | 60 ++

[PATCH 6/8] dma-buf: simplify reservation_object_get_fences_rcu a bit

2019-08-06 Thread Christian König
We can add the exclusive fence to the list after making sure we got a consistent state. Signed-off-by: Christian König --- drivers/dma-buf/reservation.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/dma-buf/reservation.c

[PATCH 3/8] drm/i915: stop using seqcount for fenc pruning

2019-08-06 Thread Christian König
After waiting for a reservation object use reservation_object_test_signaled_rcu to opportunistically prune the fences on the object. This allows removal of the seqcount handling in the reservation object. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 14

[PATCH 2/8] dma-buf: fix shared fence list handling in reservation_object_copy_fences

2019-08-06 Thread Christian König
Add some helpers to correctly allocate/free reservation_object_lists. Otherwise we might forget to drop dma_fence references on list destruction. Signed-off-by: Christian König --- drivers/dma-buf/reservation.c | 65 +-- 1 file changed, 46 insertions(+), 19

[PATCH 4/8] drm/i915: use new reservation_object_fences helper

2019-08-06 Thread Christian König
Instead of open coding the sequence loop use the new helper. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_busy.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_busy.c

[PATCH 8/8] dma-buf: nuke reservation_object seq number

2019-08-06 Thread Christian König
The only remaining use for this is to protect against setting a new exclusive fence while we grab both exclusive and shared. That can also be archived by looking if the exclusive fence has changed or not after completing the operation. Signed-off-by: Christian König ---

Re: [PATCH] gpu: drm: amd: powerplay: Remove logically dead code

2019-08-06 Thread Alex Deucher
On Mon, Aug 5, 2019 at 3:01 PM Hariprasad Kelam wrote: > > Result of pointer airthmentic is never null > > fix coverity defect:1451876 > > Signed-off-by: Hariprasad Kelam Applied. thanks! Alex > --- > drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 -- > 1 file changed, 2 deletions(-) > >

Re: [PATCH] gpu: drm: amd: display: dc: dcn20: Remove redudant condition

2019-08-06 Thread Alex Deucher
On Mon, Aug 5, 2019 at 3:01 PM Hariprasad Kelam wrote: > > Remove redudant codition "dsc_cfg->dc_dsc_cfg.num_slices_v". > > fixes coverity defect 1451853 > > Signed-off-by: Hariprasad Kelam > --- > drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PULL] drm-misc-next

2019-08-06 Thread Rob Herring
On Tue, Aug 6, 2019 at 1:34 AM Daniel Vetter wrote: > > On Tue, Aug 6, 2019 at 2:34 AM Dave Airlie wrote: > > > > On Sat, 3 Aug 2019 at 20:47, Maxime Ripard > > wrote: > > > > > > Hi Daniel, Dave, > > > > > > Here is the first (and pretty late) drm-misc-next PR. > > > > > > It's pretty big due

Re: [PATCH 1/2] drm: add cache support for arm64

2019-08-06 Thread Mark Rutland
On Tue, Aug 06, 2019 at 07:11:41AM -0700, Rob Clark wrote: > On Tue, Aug 6, 2019 at 1:48 AM Christoph Hellwig wrote: > > > > This goes in the wrong direction. drm_cflush_* are a bad API we need to > > get rid of, not add use of it. The reason for that is two-fold: > > > > a) it doesn't address

Re: [PULL] drm-misc-next

2019-08-06 Thread Daniel Vetter
On Tue, Aug 6, 2019 at 4:25 PM Rob Herring wrote: > > On Tue, Aug 6, 2019 at 1:34 AM Daniel Vetter wrote: > > > > On Tue, Aug 6, 2019 at 2:34 AM Dave Airlie wrote: > > > > > > On Sat, 3 Aug 2019 at 20:47, Maxime Ripard > > > wrote: > > > > > > > > Hi Daniel, Dave, > > > > > > > > Here is the

Re: [PATCH 1/2] drm: add cache support for arm64

2019-08-06 Thread Christoph Hellwig
On Tue, Aug 06, 2019 at 07:11:41AM -0700, Rob Clark wrote: > Agreed that drm_cflush_* isn't a great API. In this particular case > (IIUC), I need wb+inv so that there aren't dirty cache lines that drop > out to memory later, and so that I don't get a cache hit on > uncached/wc mmap'ing. So what

Re: [PULL] drm-misc-next

2019-08-06 Thread Daniel Vetter
On Tue, Aug 06, 2019 at 06:01:46PM +0200, Maxime Ripard wrote: > On Tue, Aug 06, 2019 at 10:33:53AM +1000, Dave Airlie wrote: > > On Sat, 3 Aug 2019 at 20:47, Maxime Ripard > > wrote: > > > > > > Hi Daniel, Dave, > > > > > > Here is the first (and pretty late) drm-misc-next PR. > > > > > > It's

Re: [PATCH v6 1/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-08-06 Thread Ira Weiny
On Sun, Aug 04, 2019 at 02:40:40PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > Provide a more capable variation of put_user_pages_dirty_lock(), > and delete put_user_pages_dirty(). This is based on the > following: > > 1. Lots of call sites become simpler if a bool is passed >

Re: [PULL] drm-misc-next

2019-08-06 Thread Maxime Ripard
On Tue, Aug 06, 2019 at 10:33:53AM +1000, Dave Airlie wrote: > On Sat, 3 Aug 2019 at 20:47, Maxime Ripard wrote: > > > > Hi Daniel, Dave, > > > > Here is the first (and pretty late) drm-misc-next PR. > > > > It's pretty big due to the lateness, but there's nothing really major > > showing up.

Re: [PATCH 6/6] drm: tiny: gdepaper: add driver for 2/3 color epaper displays

2019-08-06 Thread Noralf Trønnes
Hi Jan, A couple of drive by comments: Den 30.07.2019 15.48, skrev Jan Sebastian Götte: > These ePaper displays are made in b/w, b/w/red and b/w/yellow variations > by Good Display (www.e-paper-display.com) and sold on breakout boards by > waveshare (waveshare.com). > > This driver was tested

[PATCH] drm/syncobj: Add better overview documentation for syncobj (v2)

2019-08-06 Thread Jason Ekstrand
This patch only brings the syncobj documentation up-to-date for the original form of syncobj. It does not contain any information about the design of timeline syncobjs. v2: Incorporate feedback from Lionel and Christian: - Mention actual ioctl and flag names - Better language around reference

Re: [PATCH 1/2] drm: add cache support for arm64

2019-08-06 Thread Rob Clark
On Tue, Aug 6, 2019 at 9:23 AM Rob Clark wrote: > > On Tue, Aug 6, 2019 at 8:50 AM Christoph Hellwig wrote: > > > > On Tue, Aug 06, 2019 at 07:11:41AM -0700, Rob Clark wrote: > > > Agreed that drm_cflush_* isn't a great API. In this particular case > > > (IIUC), I need wb+inv so that there

Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Kuehling, Felix
On 2019-08-06 13:44, Jason Gunthorpe wrote: > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: >> The option is just used to select HMM mirror support and has a very >> confusing help text. Just pull in the HMM mirror code by default >> instead. >> >> Signed-off-by: Christoph

Re: [PATCH 1/3] drm: add gem ttm helpers

2019-08-06 Thread Sam Ravnborg
Hi Gerd. On Tue, Aug 06, 2019 at 03:34:52PM +0200, Gerd Hoffmann wrote: > Now with ttm_buffer_object being a subclass of drm_gem_object we can > easily lookup ttm_buffer_object for a given drm_gem_object, which in > turm allows to create common helper functions. This patch starts off > with dump

Re: [PATCH 1/3] drm: add gem ttm helpers

2019-08-06 Thread Sam Ravnborg
Hi Gerd. On Tue, Aug 06, 2019 at 03:34:52PM +0200, Gerd Hoffmann wrote: > Now with ttm_buffer_object being a subclass of drm_gem_object we can > easily lookup ttm_buffer_object for a given drm_gem_object, which in > turm allows to create common helper functions. This patch starts off > with dump

Re: [PATCH v12 0/6] HDCP2.2 Phase II

2019-08-06 Thread Ramalingam C
On 2019-08-01 at 17:11:13 +0530, Ramalingam C wrote: > Series adds the content_type support for HDCP2.2. Along with that uevent > is sent for each HDCP state change triggered within kernel. > > Pekka have completed the Weston DRM-backend review in >

[PATCH v8 3/4] drm: sun4i: Add support for enabling DDC I2C bus to sun8i_dw_hdmi glue

2019-08-06 Thread megous
From: Ondrej Jirman Orange Pi 3 board requires enabling a voltage shifting circuit via GPIO for the DDC bus to be usable. Add support for hdmi-connector node's optional ddc-en-gpios property to support this use case. Signed-off-by: Ondrej Jirman Reviewed-by: Jernej Skrabec ---

[PATCH v8 0/4] Add support for Orange Pi 3

2019-08-06 Thread megous
From: Ondrej Jirman This series implements support for Xunlong Orange Pi 3 board. There are only a few patches remaining. - ethernet support - just a DT change (patch 1) - HDMI support (patches 2-4) For some people, ethernet doesn't work after reboot because u-boot doesn't support AXP805 PMIC,

[PATCH v8 4/4] arm64: dts: allwinner: orange-pi-3: Enable HDMI output

2019-08-06 Thread megous
From: Ondrej Jirman Orange Pi 3 has a DDC_CEC_EN signal connected to PH2, that enables the DDC I2C bus voltage shifter. Before EDID can be read, we need to pull PH2 high. This is realized by the ddc-en-gpios property. Signed-off-by: Ondrej Jirman --- .../dts/allwinner/sun50i-h6-orangepi-3.dts

[PATCH v8 1/4] arm64: dts: allwinner: orange-pi-3: Enable ethernet

2019-08-06 Thread megous
From: Ondrej Jirman Orange Pi 3 has two regulators that power the Realtek RTL8211E. According to the phy datasheet, both regulators need to be enabled at the same time, but we can only specify a single phy-supply in the DT. This can be achieved by making one regulator depedning on the other via

[PATCH v8 2/4] dt-bindings: display: hdmi-connector: Support DDC bus enable

2019-08-06 Thread megous
From: Ondrej Jirman Some Allwinner SoC using boards (Orange Pi 3 for example) need to enable on-board voltage shifting logic for the DDC bus using a gpio to be able to access DDC bus. Use ddc-en-gpios property on the hdmi-connector to model this. Add binding documentation for optional

Re: [PATCH 1/2] drm: add cache support for arm64

2019-08-06 Thread Rob Clark
On Tue, Aug 6, 2019 at 8:50 AM Christoph Hellwig wrote: > > On Tue, Aug 06, 2019 at 07:11:41AM -0700, Rob Clark wrote: > > Agreed that drm_cflush_* isn't a great API. In this particular case > > (IIUC), I need wb+inv so that there aren't dirty cache lines that drop > > out to memory later, and

Re: [PATCH v3 0/3] Send a hotplug when edid changes

2019-08-06 Thread Daniel Vetter
On Tue, Aug 6, 2019 at 4:06 PM Lisovskiy, Stanislav wrote: > > On Tue, 2019-08-06 at 15:51 +0200, Daniel Vetter wrote: > > On Tue, Aug 06, 2019 at 03:55:48PM +0300, Stanislav Lisovskiy wrote: > > > This series introduce to drm a way to determine if something else > > > except connection_status

[PATCH] drm/amd/display: Add number of slices per line to DSC parameter validation

2019-08-06 Thread Harry Wentland
From: Nikola Cornij [why] Number of slices per line was mistakenly left out Cc: Hariprasad Kelam Signed-off-by: Nikola Cornij Signed-off-by: Harry Wentland Reviewed-by: Harry Wentland --- Thanks, Hariprasad, for your patch. The second condition should actually check for num_slices_h.

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

2019-08-06 Thread Will Deacon
On Wed, Jul 24, 2019 at 03:20:59PM +0100, Will Deacon wrote: > On Wed, Jul 24, 2019 at 04:16:49PM +0200, Andrey Konovalov wrote: > > On Wed, Jul 24, 2019 at 4:02 PM Will Deacon wrote: > > > On Tue, Jul 23, 2019 at 08:03:29PM +0200, Andrey Konovalov wrote: > > > > Should this go through the mm or

Re: [PATCH v2 01/34] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-08-06 Thread Ira Weiny
On Sun, Aug 04, 2019 at 03:48:42PM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > Provide a more capable variation of put_user_pages_dirty_lock(), > and delete put_user_pages_dirty(). This is based on the > following: > > 1. Lots of call sites become simpler if a bool is passed >

[PATCH] fence: checking for NULL pointer after dereferencing it.

2019-08-06 Thread Xinpeng Liu
drivers/dma-buf/dma-fence.c:131 in function dma_fence_signal_locked, if (WARN_ON(!fence)) should be before lockdep_assert_held(fence->lock); otherwise there is not any meaning. Signed-off-by: Xinpeng Liu --- drivers/dma-buf/dma-fence.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH 15/15] amdgpu: remove CONFIG_DRM_AMDGPU_USERPTR

2019-08-06 Thread Alex Deucher
On Tue, Aug 6, 2019 at 1:51 PM Kuehling, Felix wrote: > > On 2019-08-06 13:44, Jason Gunthorpe wrote: > > On Tue, Aug 06, 2019 at 07:05:53PM +0300, Christoph Hellwig wrote: > >> The option is just used to select HMM mirror support and has a very > >> confusing help text. Just pull in the HMM

Re: [PATCH 3/8] drm/i915: stop using seqcount for fenc pruning

2019-08-06 Thread Chris Wilson
Quoting Christian König (2019-08-06 16:01:29) > After waiting for a reservation object use > reservation_object_test_signaled_rcu > to opportunistically prune the fences on the object. > > This allows removal of the seqcount handling in the reservation object. > > Signed-off-by: Christian König

Re: [PATCH 2/8] dma-buf: fix shared fence list handling in reservation_object_copy_fences

2019-08-06 Thread Chris Wilson
Quoting Christian König (2019-08-06 16:01:28) > Add some helpers to correctly allocate/free reservation_object_lists. > > Otherwise we might forget to drop dma_fence references on list destruction. > > Signed-off-by: Christian König > --- > drivers/dma-buf/reservation.c | 65

Re: [PATCH 6/8] dma-buf: simplify reservation_object_get_fences_rcu a bit

2019-08-06 Thread Chris Wilson
Quoting Christian König (2019-08-06 16:01:32) > We can add the exclusive fence to the list after making sure we got > a consistent state. > > Signed-off-by: Christian König Reviewed-by: Chris Wilson -Chris ___ dri-devel mailing list

Xorg indefinitely hangs in kernelspace

2019-08-06 Thread Jaak Ristioja
Hello! I'm writing to report a crash in the QXL / DRM code in the Linux kernel. I originally filed the issue on LaunchPad and more details can be found there, although I doubt whether these details are useful. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1813620 I first experienced

[Bug 102646] Screen flickering under amdgpu-experimental [buggy auto power profile]

2019-08-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102646 --- Comment #101 from Maxim Ivanov --- (In reply to Ahzo from comment #97) > Created attachment 144950 [details] [review] > Patch to fix the problem > > TLDR: A script to reproduce and a patch to fix this problem are attached. > > The problem

Re: drm pull for v5.3-rc1

2019-08-06 Thread Matthew Wilcox
On Tue, Aug 06, 2019 at 11:50:42AM -0700, Linus Torvalds wrote: > In fact, I do note that a lot of the users don't actually use the > "void *private" argument at all - they just want the walker - and just > pass in a NULL private pointer. So we have things like this: > > > + if

Re: [PATCH 4/8] drm/i915: use new reservation_object_fences helper

2019-08-06 Thread Chris Wilson
Quoting Christian König (2019-08-06 16:01:30) > Instead of open coding the sequence loop use the new helper. I've missed something. What reservation_object_fences()? -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH 7/8] dma-buf: add reservation_object_fences helper

2019-08-06 Thread Chris Wilson
Quoting Christian König (2019-08-06 16:01:33) > Add a new helper to get a consistent set of pointers from the reservation > object. While at it group all access helpers together in the header file. Ah, needs to be earlier :) > +/** > + * reservation_object_fences - read consistent fence

[pull] amdgpu, amdkfd, radeon, ttm drm-next-5.4

2019-08-06 Thread Alex Deucher
Hi Dave, Daniel, The big updates here are support for new asics (navi14, navi12, arcturus). The following changes since commit 41a5a2a8531f95d18bb4efddea581ccb469e8ee5: drm/amd/display: init res_pool dccg_ref, dchub_ref with xtalin_freq (2019-07-18 14:12:08 -0500) are available in the Git

Re: drm pull for v5.3-rc1

2019-08-06 Thread Linus Torvalds
On Tue, Aug 6, 2019 at 12:38 AM Christoph Hellwig wrote: > > Seems like no one took this up. Below is a version which I think is > slightly better by also moving the mm_walk structure initialization > into the helpers, with an outcome of just a handful of added lines. Ack. Agreed, I think

Re: [PATCH] drm/panfrost: Add "compute shader only" hint

2019-08-06 Thread Rob Herring
On Tue, Aug 6, 2019 at 1:53 PM Alyssa Rosenzweig wrote: > > Midgard contains two job slots capable of compute jobs, JS1 and JS2. As > an optimization, it is preferable to schedule compute-only workloads to > JS2, although compute jobs are functionally able to be scheduled to JS1 > (barring an

Re: [PATCH] drm/panfrost: Add "compute shader only" hint

2019-08-06 Thread Rob Herring
On Tue, Aug 6, 2019 at 2:11 PM Alyssa Rosenzweig wrote: > > > Why don't we just go ahead and enable JS2? > > It's not obvious to me when it actually needs to be enabled. Besides the > errata, it's only when... device_nr=1 for a compute-only job in kbase? > > I'm afraid I don't know nearly enough

Re: [PATCH 1/8] dma-buf: fix busy wait for new shared fences

2019-08-06 Thread Chris Wilson
Quoting Christian König (2019-08-06 16:01:27) > When reservation_object_add_shared_fence is replacing an old fence with a new > one we should not drop the old one before the new one is in place. > > Otherwise other cores can busy wait for the new one to appear. I see. The reader will see a

Re: [PATCH] drm/amd/display: Add number of slices per line to DSC parameter validation

2019-08-06 Thread Alex Deucher
On Tue, Aug 6, 2019 at 1:45 PM Harry Wentland wrote: > > From: Nikola Cornij > > [why] > Number of slices per line was mistakenly left out > > Cc: Hariprasad Kelam > Signed-off-by: Nikola Cornij > Signed-off-by: Harry Wentland > Reviewed-by: Harry Wentland Acked-by: Alex Deucher > --- > >

Re: [PATCH 5/8] dma-buf: further relax reservation_object_add_shared_fence

2019-08-06 Thread Chris Wilson
Quoting Christian König (2019-08-06 16:01:31) > Other cores don't busy wait any more and we removed the last user of checking > the seqno for changes. Drop updating the number for shared fences altogether. > > Signed-off-by: Christian König > --- > drivers/dma-buf/reservation.c

Re: [PATCH 8/8] dma-buf: nuke reservation_object seq number

2019-08-06 Thread Chris Wilson
Quoting Christian König (2019-08-06 16:01:34) > The only remaining use for this is to protect against setting a new exclusive > fence while we grab both exclusive and shared. That can also be archived by > looking if the exclusive fence has changed or not after completing the > operation. > >

[PATCH AUTOSEL 4.14 10/25] drm/bridge: lvds-encoder: Fix build error while CONFIG_DRM_KMS_HELPER=m

2019-08-06 Thread Sasha Levin
From: YueHaibing [ Upstream commit f4cc743a98136df3c3763050a0e8223b52d9a960 ] If DRM_LVDS_ENCODER=y but CONFIG_DRM_KMS_HELPER=m, build fails: drivers/gpu/drm/bridge/lvds-encoder.o: In function `lvds_encoder_probe': lvds-encoder.c:(.text+0x155): undefined reference to

[PATCH AUTOSEL 4.19 28/32] drm/exynos: fix missing decrement of retry counter

2019-08-06 Thread Sasha Levin
From: Colin Ian King [ Upstream commit 1bbbab097a05276e312dd2462791d32b21ceb1ee ] Currently the retry counter is not being decremented, leading to a potential infinite spin if the scalar_reads don't change state. Addresses-Coverity: ("Infinite loop") Fixes: 280e54c9f614 ("drm/exynos: scaler:

[PATCH AUTOSEL 4.14 17/25] drm/vgem: fix cache synchronization on arm/arm64

2019-08-06 Thread Sasha Levin
From: Rob Clark [ Upstream commit 7e9e5ead55beacc6b3fb90b0de6e7cf55a69 ] drm_cflush_pages() is no-op on arm/arm64. But instead we can use dma_sync API. Fixes failures w/ vgem_test. Acked-by: Daniel Vetter Signed-off-by: Rob Clark Signed-off-by: Sean Paul Link:

[PATCH AUTOSEL 4.19 11/32] drm/bridge: lvds-encoder: Fix build error while CONFIG_DRM_KMS_HELPER=m

2019-08-06 Thread Sasha Levin
From: YueHaibing [ Upstream commit f4cc743a98136df3c3763050a0e8223b52d9a960 ] If DRM_LVDS_ENCODER=y but CONFIG_DRM_KMS_HELPER=m, build fails: drivers/gpu/drm/bridge/lvds-encoder.o: In function `lvds_encoder_probe': lvds-encoder.c:(.text+0x155): undefined reference to

[PATCH AUTOSEL 4.19 21/32] drm/vgem: fix cache synchronization on arm/arm64

2019-08-06 Thread Sasha Levin
From: Rob Clark [ Upstream commit 7e9e5ead55beacc6b3fb90b0de6e7cf55a69 ] drm_cflush_pages() is no-op on arm/arm64. But instead we can use dma_sync API. Fixes failures w/ vgem_test. Acked-by: Daniel Vetter Signed-off-by: Rob Clark Signed-off-by: Sean Paul Link:

[PATCH AUTOSEL 4.19 27/32] drm: msm: Fix add_gpu_components

2019-08-06 Thread Sasha Levin
From: Jeffrey Hugo [ Upstream commit 9ca7ad6c7706edeae331c1632d0c63897418ebad ] add_gpu_components() adds found GPU nodes from the DT to the match list, regardless of the status of the nodes. This is a problem, because if the nodes are disabled, they should not be on the match list because

[PATCH AUTOSEL 5.2 51/59] drm/exynos: fix missing decrement of retry counter

2019-08-06 Thread Sasha Levin
From: Colin Ian King [ Upstream commit 1bbbab097a05276e312dd2462791d32b21ceb1ee ] Currently the retry counter is not being decremented, leading to a potential infinite spin if the scalar_reads don't change state. Addresses-Coverity: ("Infinite loop") Fixes: 280e54c9f614 ("drm/exynos: scaler:

[PATCH AUTOSEL 4.19 16/32] drm/amdgpu: fix a potential information leaking bug

2019-08-06 Thread Sasha Levin
From: Wang Xiayang [ Upstream commit 929e571c04c285861e0bb049a396a2bdaea63282 ] Coccinelle reports a path that the array "data" is never initialized. The path skips the checks in the conditional branches when either of callback functions, read_wave_vgprs and read_wave_sgprs, is not registered.

[PATCH AUTOSEL 5.2 22/59] drm/bridge: lvds-encoder: Fix build error while CONFIG_DRM_KMS_HELPER=m

2019-08-06 Thread Sasha Levin
From: YueHaibing [ Upstream commit f4cc743a98136df3c3763050a0e8223b52d9a960 ] If DRM_LVDS_ENCODER=y but CONFIG_DRM_KMS_HELPER=m, build fails: drivers/gpu/drm/bridge/lvds-encoder.o: In function `lvds_encoder_probe': lvds-encoder.c:(.text+0x155): undefined reference to

[PATCH AUTOSEL 5.2 37/59] drm/vgem: fix cache synchronization on arm/arm64

2019-08-06 Thread Sasha Levin
From: Rob Clark [ Upstream commit 7e9e5ead55beacc6b3fb90b0de6e7cf55a69 ] drm_cflush_pages() is no-op on arm/arm64. But instead we can use dma_sync API. Fixes failures w/ vgem_test. Acked-by: Daniel Vetter Signed-off-by: Rob Clark Signed-off-by: Sean Paul Link:

[PATCH AUTOSEL 5.2 31/59] drm/amdgpu: fix error handling in amdgpu_cs_process_fence_dep

2019-08-06 Thread Sasha Levin
From: Christian König [ Upstream commit 67d0859e2758ef992fd32499747ce4b1038a63c0 ] We always need to drop the ctx reference and should check for errors first and then dereference the fence pointer. Signed-off-by: Christian König Reviewed-by: Chunming Zhou Signed-off-by: Alex Deucher

[PATCH AUTOSEL 5.2 32/59] drm/amdgpu: fix a potential information leaking bug

2019-08-06 Thread Sasha Levin
From: Wang Xiayang [ Upstream commit 929e571c04c285861e0bb049a396a2bdaea63282 ] Coccinelle reports a path that the array "data" is never initialized. The path skips the checks in the conditional branches when either of callback functions, read_wave_vgprs and read_wave_sgprs, is not registered.

[PATCH AUTOSEL 5.2 23/59] drm/bridge: tc358764: Fix build error

2019-08-06 Thread Sasha Levin
From: YueHaibing [ Upstream commit e1ae72a21e5f0d1846e26e3f5963930664702071 ] If CONFIG_DRM_TOSHIBA_TC358764=y but CONFIG_DRM_KMS_HELPER=m, building fails: drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x228): undefined reference to `drm_atomic_helper_connector_reset'

[PATCH AUTOSEL 5.2 49/59] drm: msm: Fix add_gpu_components

2019-08-06 Thread Sasha Levin
From: Jeffrey Hugo [ Upstream commit 9ca7ad6c7706edeae331c1632d0c63897418ebad ] add_gpu_components() adds found GPU nodes from the DT to the match list, regardless of the status of the nodes. This is a problem, because if the nodes are disabled, they should not be on the match list because

[PATCH AUTOSEL 5.2 30/59] drm/amd/powerplay: fix null pointer dereference around dpm state relates

2019-08-06 Thread Sasha Levin
From: Evan Quan [ Upstream commit 479156f2e5540077377a823eaf5a4263bd329063 ] DPM state relates are not supported on the new SW SMU ASICs. But still it's not OK to trigger null pointer dereference on accessing them. Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Signed-off-by: Alex

[PATCH AUTOSEL 5.2 29/59] drm/amdkfd: Fix byte align on VegaM

2019-08-06 Thread Sasha Levin
From: Kent Russell [ Upstream commit d65848657c3da5c0d4b685f823d0230f151ab34e ] This was missed during the addition of VegaM support Reviewed-by: Alex Deucher Signed-off-by: Kent Russell Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

Re: [PATCH v6 1/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-08-06 Thread John Hubbard
On 8/6/19 10:40 AM, Ira Weiny wrote: > On Sun, Aug 04, 2019 at 02:40:40PM -0700, john.hubb...@gmail.com wrote: >> From: John Hubbard >> >> Provide a more capable variation of put_user_pages_dirty_lock(), >> and delete put_user_pages_dirty(). This is based on the >> following: >> >> 1. Lots of

Re: [PATCH] drm/panfrost: Add errata descriptions from kbase

2019-08-06 Thread Rob Herring
On Tue, Aug 6, 2019 at 2:25 PM Alyssa Rosenzweig wrote: > > While newer kbase include only the numbers of errata, older kbase > releases included one-line descriptions for each errata, which is useful > for those working on the driver. Import these descriptions. Most are > from kbase verbatim; a

[PATCH AUTOSEL 4.14 22/25] drm: msm: Fix add_gpu_components

2019-08-06 Thread Sasha Levin
From: Jeffrey Hugo [ Upstream commit 9ca7ad6c7706edeae331c1632d0c63897418ebad ] add_gpu_components() adds found GPU nodes from the DT to the match list, regardless of the status of the nodes. This is a problem, because if the nodes are disabled, they should not be on the match list because

Re: [PATCH v3 hmm 10/11] drm/amdkfd: use mmu_notifier_put

2019-08-06 Thread Kuehling, Felix
On 2019-08-06 19:15, Jason Gunthorpe wrote: > From: Jason Gunthorpe > > The sequence of mmu_notifier_unregister_no_release(), > mmu_notifier_call_srcu() is identical to mmu_notifier_put() with the > free_notifier callback. > > As this is the last user of those APIs, converting it means we can

[PATCH] drm/i915/gvt: Fix use-after-free in intel_vgpu_create_workload

2019-08-06 Thread Gustavo A. R. Silva
kmem_cache_free() frees *workload*, hence there is a use-after-free bug when calling function gvt_vgpu_err(). Fix this by storing the value of workload->wa_ctx.indirect_ctx.guest_gma and workload->wa_ctx.per_ctx.guest_gma into automatic variable guest_gma before freeing *workload*, for its

  1   2   >