Re: [PATCH -next] drm/dp-mst: Fix unused variable warning

2019-10-15 Thread Shaokun Zhang
Please ignore this mail. I will resend it again. Thanks On 2019/10/14 15:41, Shaokun Zhang wrote: > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c > b/drivers/gpu/drm/drm_dp_mst_topology.c > index 9364e4f42975..95e63309 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers

[PATCH -next] drm/dp-mst: Fix unused variable warning

2019-10-15 Thread Shaokun Zhang
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 9364e4f42975..95e63309 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -4184,8 +4184,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs); struct d

Re: [Intel-gfx] [PATCH] drm/i915: Don't disable interrupts independently of the lock

2019-10-15 Thread Sebastian Andrzej Siewior
On 2019-10-10 21:30:35 [+0100], Chris Wilson wrote: > > | spin_lock_irq(&rq->engine->active.lock); > > | list_del(&rq->sched.link); > > | spin_unlock_irq(&rq->engine->active.lock); > > | > > | spin_lock_irq(&rq->lock); > > | i915_request_mark_complete(rq); >

[RESEND][PATCH -next] drm/dp-mst: Fix unused variable warning

2019-10-15 Thread Shaokun Zhang
drivers/gpu/drm/drm_dp_mst_topology.c: In function ‘drm_atomic_get_mst_topology_state’: drivers/gpu/drm/drm_dp_mst_topology.c:4187:21: warning: unused variable ‘dev’ [-Wunused-variable] struct drm_device *dev = mgr->dev; ^ Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_m

[PATCH] drm/msm/a5xx: Fix barrier usage in set_preempt_state()

2019-10-15 Thread Davidlohr Bueso
Because it is not a Rmw operation, atomic_set() is never serialized, and therefore the 'upgradable' smp_mb__{before,after}_atomic() calls that order the write to preempt_state are completely bogus. This patch replaces these with smp_mb(), which seems like the original intent of when the code was w

[PATCH v3 0/2] Add initial support for slimport anx7625

2019-10-15 Thread Xin Ji
Hi all, The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device. This is the initial version, any mistakes, please let me know, I will fix it in the next series. Thanks, Xin Xin Ji (2): dt

[PATCH v3 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-10-15 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K. You can add support to your board with binding. Example: anx7625_bridge: encoder@58 { compatible = "analogix,anx7625"; reg = <0x

[PATCH v3 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-10-15 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. The ANX7625 can support both USB Type-C PD feature and MIPI DSI/DPI to DP feature. This driver only enabled MIPI DSI/DPI to DP feature. Signed-off-by: Xin Ji -

Re: [PATCH v3] drm/bridge: dw-hdmi: Restore audio when setting a mode

2019-10-15 Thread Neil Armstrong
On 08/10/2019 12:21, Cheng-Yi Chiang wrote: > From: Daniel Kurtz > > When setting a new display mode, dw_hdmi_setup() calls > dw_hdmi_enable_video_path(), which disables all hdmi clocks, including > the audio clock. > > We should only (re-)enable the audio clock if audio was already enabled > wh

Re: [PATCH v2 1/4] drm/komeda: Add a new helper drm_color_ctm_s31_32_to_qm_n()

2019-10-15 Thread james qian wang (Arm Technology China)
On Mon, Oct 14, 2019 at 11:48:38PM -0400, Ilia Mirkin wrote: > On Mon, Oct 14, 2019 at 9:16 PM james qian wang (Arm Technology China) > wrote: > > On Mon, Oct 14, 2019 at 11:58:48AM -0400, Ilia Mirkin wrote: > > > On Fri, Oct 11, 2019 at 1:43 AM james qian wang (Arm Technology China) > > > wrote:

Re: [PATCH v2 1/4] drm/komeda: Add a new helper drm_color_ctm_s31_32_to_qm_n()

2019-10-15 Thread Mihail Atanassov
On Tuesday, 15 October 2019 02:16:11 BST james qian wang (Arm Technology China) wrote: > On Mon, Oct 14, 2019 at 11:58:48AM -0400, Ilia Mirkin wrote: > > On Fri, Oct 11, 2019 at 1:43 AM james qian wang (Arm Technology China) > > wrote: > > > > > > Add a new helper function drm_color_ctm_s31_32_to

[PATCH 2/3 v2] drm/panel: Add DT bindings for Sony ACX424AKP

2019-10-15 Thread Linus Walleij
This adds device tree bindings for the Sony ACX424AKP panel. Let's use YAML. Cc: devicet...@vger.kernel.org Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Suggest a stand-alone YAML bindings file for DSI panels in a separate patch, and use that to reference the boolean "enforce-video-mo

[PATCH 1/3 v2] drm/panel: Add generic DSI panel YAML bindings

2019-10-15 Thread Linus Walleij
This adds a starting point for processing and defining generic bindings used by DSI panels. We just define one single bool property to force the panel into video mode for now. Cc: devicet...@vger.kernel.org Suggested-by: Rob Herring Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - New patch

[PATCH 3/3 v2] drm/panel: Add driver for Sony ACX424AKP panel

2019-10-15 Thread Linus Walleij
The Sony ACX424AKP is a command/videomode DSI panel for mobile devices. It is used on the ST-Ericsson HREF520 reference design. We support video mode by default, but it is possible to switch the panel into command mode by using the bool property "dsi-command-mode". Signed-off-by: Linus Walleij --

Re: [PATCH v4 2/4] drm/komeda: Add drm_lut_to_fgamma_coeffs()

2019-10-15 Thread Brian Starkey
Hi James, On Tue, Oct 15, 2019 at 02:10:53AM +, james qian wang (Arm Technology China) wrote: > This function is used to convert drm 3dlut to komeda HW required 1d curve This is a 1D LUT, not a 3D LUT Cheers, -Brian > coeffs values. > > Signed-off-by: james qian wang (Arm Technology China

Re: [PATCH v2 08/15] drm/fbconv: Add plane-state check and update

2019-10-15 Thread kbuild test robot
option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/DRM-fbconv-helpers-for-converting-fbdev-drivers/20191015-152231 config: mips-allmodconfig (attached as .config) compiler: mips

[Bug 111968] Navi10 null pointer dereference in kernel 5.4 while running Vulkan CTS

2019-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111968 --- Comment #5 from Christian König --- This patch is already on the fixes branch for a while. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-

Re: [PATCH v2 12/15] drm/fbconv: Add helper documentation

2019-10-15 Thread kbuild test robot
option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/DRM-fbconv-helpers-for-converting-fbdev-drivers/20191015-152231 reproduce: make htmldocs If you fix the issue, kindly add fol

Re: [PATCH V6 3/8] backlight: qcom-wled: Add new properties for PMI8998

2019-10-15 Thread kgunda
On 2019-10-01 20:42, Dan Murphy wrote: Kiran On 9/30/19 1:39 AM, Kiran Gunda wrote: Update the bindings with the new properties used for PMI8998. Signed-off-by: Kiran Gunda Reviewed-by: Bjorn Andersson Reviewed-by: Rob Herring Acked-by: Daniel Thompson --- .../bindings/leds/backlight/qco

Re: [PATCH v4 2/4] drm/komeda: Add drm_lut_to_fgamma_coeffs()

2019-10-15 Thread james qian wang (Arm Technology China)
On Tue, Oct 15, 2019 at 08:29:52AM +, Brian Starkey wrote: > Hi James, > > On Tue, Oct 15, 2019 at 02:10:53AM +, james qian wang (Arm Technology > China) wrote: > > This function is used to convert drm 3dlut to komeda HW required 1d curve > > This is a 1D LUT, not a 3D LUT > Thank you B

Re: [PATCH v2 1/4] drm/komeda: Add a new helper drm_color_ctm_s31_32_to_qm_n()

2019-10-15 Thread james qian wang (Arm Technology China)
On Tue, Oct 15, 2019 at 08:21:44AM +, Mihail Atanassov wrote: > On Tuesday, 15 October 2019 02:16:11 BST james qian wang (Arm Technology > China) wrote: > > On Mon, Oct 14, 2019 at 11:58:48AM -0400, Ilia Mirkin wrote: > > > On Fri, Oct 11, 2019 at 1:43 AM james qian wang (Arm Technology China)

[PATCH] drm/komeda: Adds output-color format support

2019-10-15 Thread Lowry Li (Arm Technology China)
Sets output color format according to the connector formats and display supported formats. Default value is RGB444 and only force YUV format which must be YUV. Signed-off-by: Lowry Li (Arm Technology China) --- .../drm/arm/display/komeda/d71/d71_component.c | 14 +- .../gpu/drm/arm/

Re: [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2019-10-15 Thread Dan Carpenter
[ These are automated text from the 0-day bot -dan ] Hi Xin, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Xin-Ji/dt-bindings-drm-bridge-anx7625-MIPI-to-DP-transmitter-binding/20191014-043019 If you fix the issue, kindly add following

Re: [PATCH] kernel-doc: rename the kernel-doc directive 'functions' to 'specific'

2019-10-15 Thread Thomas Zimmermann
Hi Am 14.10.19 um 22:48 schrieb tim.b...@sony.com: > > >> -Original Message- >> From: Jani Nikula on October 13, 2019 11:00 PM >> On Sun, 13 Oct 2019, Changbin Du wrote: >>> The 'functions' directive is not only for functions, but also works for >>> structs/unions. So the name is mislea

[drm-intel:drm-intel-next-queued 1/1] drivers/gpu/drm/i915/i915_irq.c:2283 icp_irq_handler() error: uninitialized symbol 'tc_port_hotplug_long_detect'.

2019-10-15 Thread Dan Carpenter
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: 53448aed7b805cf36ecc59ed5fe8e53815ce4fe8 commit: 53448aed7b805cf36ecc59ed5fe8e53815ce4fe8 [1/1] drm/i915/ehl: Port C's hotplug interrupt is associated with TC1 bits If you fix the issue, kindly add following tag Reporte

[PATCH v3 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-10-15 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K. You can add support to your board with binding. Example: anx7625_bridge: encoder@58 { compatible = "analogix,anx7625"; reg = <0x

[PATCH v3 0/2] Add initial support for slimport anx7625

2019-10-15 Thread Xin Ji
Hi all, The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device. This is the initial version, any mistakes, please let me know, I will fix it in the next series. Thanks, Xin Xin Ji (2): dt-

Re: [PATCH] drm/komeda: Adds output-color format/depth support

2019-10-15 Thread Lowry Li (Arm Technology China)
Hi Brian, On Mon, Sep 30, 2019 at 10:36:27AM +, Brian Starkey wrote: > On Fri, Sep 27, 2019 at 02:22:24AM +, james qian wang (Arm Technology > China) wrote: > > On Wed, Sep 25, 2019 at 09:48:11AM +, Brian Starkey wrote: > > > Hi James, > > > > > > On Tue, Sep 24, 2019 at 02:13:27AM +0

Re: [PATCH V3 1/7] mdev: class id support

2019-10-15 Thread Cornelia Huck
On Fri, 11 Oct 2019 16:15:51 +0800 Jason Wang wrote: > Mdev bus only supports vfio driver right now, so it doesn't implement > match method. But in the future, we may add drivers other than vfio, > the first driver could be virtio-mdev. This means we need to add > device class id support in bus m

Re: [PATCH V3 2/7] mdev: bus uevent support

2019-10-15 Thread Cornelia Huck
On Fri, 11 Oct 2019 16:15:52 +0800 Jason Wang wrote: > This patch adds bus uevent support for mdev bus in order to allow > cooperation with userspace. > > Signed-off-by: Jason Wang > --- > drivers/vfio/mdev/mdev_driver.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-15 Thread Cornelia Huck
On Fri, 11 Oct 2019 16:15:54 +0800 Jason Wang wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside md

[PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2019-10-15 Thread Jacopo Mondi
References: A reference to the v1 cover letter, with some background on the CMM is available here: https://lkml.org/lkml/2019/6/6/583 v2: https://lore.kernel.org/linux-renesas-soc/20190706140746.29132-10-jacopo+rene...@jmondi.org/ v3: https://lore.kernel.org/linux-renesas-soc/20190825135154.11488-1

[PATCH v5 1/8] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation

2019-10-15 Thread Jacopo Mondi
Add device tree bindings documentation for the Renesas R-Car Display Unit Color Management Module. CMM is the image enhancement module available on each R-Car DU video channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- .../

[PATCH v5 3/8] drm: rcar-du: Add support for CMM

2019-10-15 Thread Jacopo Mondi
Add a driver for the R-Car Display Unit Color Correction Module. In most of Gen3 SoCs, each DU output channel is provided with a CMM unit to perform image enhancement and color correction. Add support for CMM through a driver that supports configuration of the 1-dimensional LUT table. More advanc

[PATCH v5 4/8] drm: rcar-du: kms: Initialize CMM instances

2019-10-15 Thread Jacopo Mondi
Implement device tree parsing to collect the available CMM instances described by the 'renesas,cmms' property. Associate CMMs with CRTCs and store a mask of active CMMs in the DU group for later enablement. Enforce the probe and suspend/resume ordering of DU and CMM by creating a stateless device

[PATCH v5 5/8] drm: rcar-du: crtc: Control CMM operations

2019-10-15 Thread Jacopo Mondi
Implement CMM handling in the crtc begin and enable atomic callbacks, and enable CMM unit through the Display Extensional Functions register at group setup time. Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 79 + drivers/gpu/drm/rcar-du/rcar_d

[PATCH v5 6/8] drm: rcar-du: crtc: Register GAMMA_LUT properties

2019-10-15 Thread Jacopo Mondi
Enable the GAMMA_LUT KMS property using the framework helpers to register the property and set the associated gamma table maximum size. Reviewed-by: Kieran Bingham Reviewed-by: Ulrich Hecht Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c |

[PATCH v5 2/8] dt-bindings: display, renesas,du: Document cmms property

2019-10-15 Thread Jacopo Mondi
Document the newly added 'cmms' property which accepts a list of phandle and channel index pairs that point to the CMM units available for each Display Unit output video channel. Reviewed-by: Rob Herring Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi ---

[PATCH v5 7/8] arm64: dts: renesas: Add CMM units to Gen3 SoCs

2019-10-15 Thread Jacopo Mondi
Add CMM units to Renesas R-Car Gen3 SoC that support it, and reference them from the Display Unit they are connected to. Sort the 'vsps', 'renesas,cmm' and 'status' properties in the DU unit consistently in all the involved DTS. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a779

[PATCH v5 8/8] drm: rcar-du: kms: Expand comment in vsps parsing routine

2019-10-15 Thread Jacopo Mondi
Expand comment in the 'vsps' parsing routine to specify the LIF channel index defaults to 0 in case the second cell of the property is not specified to remain compatible with older DT bindings. Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/rcar-du/rcar_du_kms.c |

[PATCH] drm/komeda: Dump SC_ENH_* registers from scaler block

2019-10-15 Thread Mihail Atanassov
Signed-off-by: Mihail Atanassov --- .../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c index c3d29c0b

[PATCH] drm/omapdrm: Fix trivial spelling

2019-10-15 Thread Kieran Bingham
Fix trivial spelling identified while examining the code. s/supprted./supported./ Signed-off-by: Kieran Bingham --- drivers/gpu/drm/omapdrm/omap_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c b/drivers/gpu/drm/omapdrm/omap

Re: [PATCH 4/7] drm/meson: plane: add support for AFBC mode for OSD1 plane

2019-10-15 Thread Brian Starkey
Hi Neil, On Fri, Oct 11, 2019 at 02:07:01PM +0200, Neil Armstrong wrote: > On 11/10/2019 12:56, Brian Starkey wrote: > > Hi, > > > > On Fri, Oct 11, 2019 at 11:14:43AM +0200, Neil Armstrong wrote: > >> Hi Brian, > >> > >> On 11/10/2019 10:41, Brian Starkey wrote: > >>> Hi Neil, > >>> > >>> On Thu

Re: [PATCH] drm: Funnel drm logs to tracepoints

2019-10-15 Thread Joonas Lahtinen
Quoting Sean Paul (2019-10-10 23:48:08) > From: Sean Paul > > *Record scratch* You read that subject correctly, I bet you're wondering > how we got here. At least hear me out before you flame :-) > > For a long while now, we (ChromeOS) have been struggling getting any > value out of user feedbac

[PATCH 2/3] drm/meson: add RDMA module driver

2019-10-15 Thread Neil Armstrong
The VPU embeds a "Register DMA" that can write a sequence of registers on the VPU AHB bus, either manually or triggered by an internal IRQ event like VSYNC or a line input counter. The initial implementation handles a single channel (over 8), triggered by the VSYNC irq and does not handle the RDMA

[PATCH 1/3] drm/meson: add RDMA register bits defines

2019-10-15 Thread Neil Armstrong
The Amlogic VPU embeds a "Register DMA" that can write a sequence of registers on the VPU AHB bus, either manually or triggered by an internal IRQ event like VSYNC or a line input counter. This adds the register defines. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_registers.h

[PATCH 0/3] drm/meson: implement RDMA for AFBC reset on vsync

2019-10-15 Thread Neil Armstrong
The VPU embeds a "Register DMA" that can write a sequence of registers on the VPU AHB bus, either manually or triggered by an internal IRQ event like VSYNC or a line input counter. The initial implementation handles a single channel (over 8), triggered by the VSYNC irq and does not handle the RDMA

[PATCH 3/3] drm/meson: use RDMA to reconfigure AFBC on vsync

2019-10-15 Thread Neil Armstrong
The VPU embeds a "Register DMA" that can write a sequence of registers on the VPU AHB bus, either manually or triggered by an internal IRQ event like VSYNC or a line input counter. The RDMA is used here to reset and program the AFBC decoder unit on each vsync without involving the interrupt handle

Re: [PATCH v5 1/8] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation

2019-10-15 Thread Kieran Bingham
Hi Jacopo, On 15/10/2019 11:46, Jacopo Mondi wrote: > Add device tree bindings documentation for the Renesas R-Car Display > Unit Color Management Module. > > CMM is the image enhancement module available on each R-Car DU video > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded). > LGT

Re: [PATCH 4/7] drm/meson: plane: add support for AFBC mode for OSD1 plane

2019-10-15 Thread Neil Armstrong
On 15/10/2019 13:18, Brian Starkey wrote: > Hi Neil, > > On Fri, Oct 11, 2019 at 02:07:01PM +0200, Neil Armstrong wrote: >> On 11/10/2019 12:56, Brian Starkey wrote: >>> Hi, >>> >>> On Fri, Oct 11, 2019 at 11:14:43AM +0200, Neil Armstrong wrote: Hi Brian, On 11/10/2019 10:41, Brian

Re: [PATCH v5 3/8] drm: rcar-du: Add support for CMM

2019-10-15 Thread Kieran Bingham
Hi Jacopo, On 15/10/2019 11:46, Jacopo Mondi wrote: > Add a driver for the R-Car Display Unit Color Correction Module. > > In most of Gen3 SoCs, each DU output channel is provided with a CMM unit > to perform image enhancement and color correction. > > Add support for CMM through a driver that s

Re: [PATCH] kernel-doc: rename the kernel-doc directive 'functions' to 'specific'

2019-10-15 Thread Matthew Wilcox
On Tue, Oct 15, 2019 at 11:25:53AM +0200, Thomas Zimmermann wrote: > > My preference would be to use 'symbols'. I tried to come up with something > > but 'symbols' is better than anything I came up with. > > Maybe 'interfaces' or 'artifacts'. The term 'symbols' is just as > imprecise as 'function

Re: [PATCH 1/3 v2] drm/panel: Add generic DSI panel YAML bindings

2019-10-15 Thread Rob Herring
On Tue, Oct 15, 2019 at 3:28 AM Linus Walleij wrote: > > This adds a starting point for processing and defining generic > bindings used by DSI panels. We just define one single bool > property to force the panel into video mode for now. > > Cc: devicet...@vger.kernel.org > Suggested-by: Rob Herrin

Re: [PATCH] drm: Funnel drm logs to tracepoints

2019-10-15 Thread Thomas Zimmermann
Hi Am 10.10.19 um 22:48 schrieb Sean Paul: > From: Sean Paul > > *Record scratch* You read that subject correctly, I bet you're wondering > how we got here. At least hear me out before you flame :-) > > For a long while now, we (ChromeOS) have been struggling getting any > value out of user fee

Re: [PATCH] kernel-doc: rename the kernel-doc directive 'functions' to 'specific'

2019-10-15 Thread Thomas Zimmermann
Hi Am 15.10.19 um 13:54 schrieb Matthew Wilcox: > On Tue, Oct 15, 2019 at 11:25:53AM +0200, Thomas Zimmermann wrote: >>> My preference would be to use 'symbols'. I tried to come up with something >>> but 'symbols' is better than anything I came up with. >> >> Maybe 'interfaces' or 'artifacts'. Th

Re: [PATCH V3 1/7] mdev: class id support

2019-10-15 Thread Jason Wang
On 2019/10/15 下午6:26, Cornelia Huck wrote: On Fri, 11 Oct 2019 16:15:51 +0800 Jason Wang wrote: Mdev bus only supports vfio driver right now, so it doesn't implement match method. But in the future, we may add drivers other than vfio, the first driver could be virtio-mdev. This means we need

Re: [PATCH V3 2/7] mdev: bus uevent support

2019-10-15 Thread Jason Wang
On 2019/10/15 下午6:27, Cornelia Huck wrote: On Fri, 11 Oct 2019 16:15:52 +0800 Jason Wang wrote: This patch adds bus uevent support for mdev bus in order to allow cooperation with userspace. Signed-off-by: Jason Wang --- drivers/vfio/mdev/mdev_driver.c | 8 1 file changed, 8 ins

Re: [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-15 Thread Jason Wang
On 2019/10/15 下午6:41, Cornelia Huck wrote: On Fri, 11 Oct 2019 16:15:54 +0800 Jason Wang wrote: Currently, except for the create and remove, the rest of mdev_parent_ops is designed for vfio-mdev driver only and may not help for kernel mdev driver. With the help of class id, this patch introd

[PATCH v4] dt-bindings: display: Convert stm32 display bindings to json-schema

2019-10-15 Thread Benjamin Gaignard
Convert the STM32 display binding to DT schema format using json-schema. Split the original bindings in two yaml files: - one for display controller (ltdc) - one for DSI controller Signed-off-by: Benjamin Gaignard --- changes in v4: - describe interruptions items - remove unit address from port p

Re: [PATCH v2 14/15] staging/mgakms: Import matroxfb driver source code

2019-10-15 Thread Thomas Zimmermann
Hi Am 15.10.19 um 13:48 schrieb Ville Syrjälä: > On Mon, Oct 14, 2019 at 04:04:15PM +0200, Thomas Zimmermann wrote: >> Only code is being copied, no functional changes are made. >> >> Signed-off-by: Thomas Zimmermann >> --- >> drivers/staging/mgakms/g450_pll.c | 539 +a > > ... > >

Re: [PATCH v5 7/8] arm64: dts: renesas: Add CMM units to Gen3 SoCs

2019-10-15 Thread Kieran Bingham
Hi Jacopo, On 15/10/2019 11:46, Jacopo Mondi wrote: > Add CMM units to Renesas R-Car Gen3 SoC that support it, and reference them > from the Display Unit they are connected to. > > Sort the 'vsps', 'renesas,cmm' and 'status' properties in the DU unit > consistently in all the involved DTS. > Go

[Bug 111763] ring_gfx hangs/freezes on Navi gpus

2019-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111763 --- Comment #12 from shahul --- I am working on Navi10 RX5700 I am facing below issue when i run unigine-heaven benchmark [drm:amdgpu_dm_atomic_commit_tail [amdgpu]] *ERROR* Waiting for fences timed out! [drm:amdgpu_job_timedout [amdgpu]] *E

Re: [PATCH v5 8/8] drm: rcar-du: kms: Expand comment in vsps parsing routine

2019-10-15 Thread Kieran Bingham
Hi Jacopo, On 15/10/2019 11:46, Jacopo Mondi wrote: > Expand comment in the 'vsps' parsing routine to specify the LIF > channel index defaults to 0 in case the second cell of the property > is not specified to remain compatible with older DT bindings. Reviewed-by: Kieran Bingham > Reviewed-by:

Re: [PATCH v5 5/8] drm: rcar-du: crtc: Control CMM operations

2019-10-15 Thread Kieran Bingham
Hi Jacopo, On 15/10/2019 11:46, Jacopo Mondi wrote: > Implement CMM handling in the crtc begin and enable atomic callbacks, > and enable CMM unit through the Display Extensional Functions Extensional ? Perhaps this should just be Display Extension Functions? Wow - that's actually what they call

Re: [PATCH v5 3/8] drm: rcar-du: Add support for CMM

2019-10-15 Thread Kieran Bingham
Hi Jacopo, One minor additional catch here: On 15/10/2019 12:53, Kieran Bingham wrote: > Hi Jacopo, >> + >> +/* >> + * rcar_cmm_lut_write() - Scale the DRM LUT table entries to hardware >> precision >> + *and write to the CMM registers. >> + * @rcmm: Pointer to the CMM dev

Re: [PATCH] kernel-doc: rename the kernel-doc directive 'functions' to 'specific'

2019-10-15 Thread Jani Nikula
On Tue, 15 Oct 2019, Matthew Wilcox wrote: > On Tue, Oct 15, 2019 at 11:25:53AM +0200, Thomas Zimmermann wrote: >> > My preference would be to use 'symbols'. I tried to come up with something >> > but 'symbols' is better than anything I came up with. >> >> Maybe 'interfaces' or 'artifacts'. The

Re: [PATCH v9 0/8] drm/i915/dp: Support for DP HDR outputs

2019-10-15 Thread Ville Syrjälä
On Fri, Sep 20, 2019 at 07:06:27PM +0300, Ville Syrjälä wrote: > On Thu, Sep 19, 2019 at 10:53:03PM +0300, Gwan-gyeong Mun wrote: > > Support for HDR10 video was introduced in DisplayPort 1.4. > > On GLK+ platform, in order to use DisplayPort HDR10, we need to support > > BT.2020 colorimetry and HD

Re: [PATCH v5 3/8] drm: rcar-du: Add support for CMM

2019-10-15 Thread Jacopo Mondi
Hi Kieran, thanks for review On Tue, Oct 15, 2019 at 12:53:55PM +0100, Kieran Bingham wrote: > Hi Jacopo, > > On 15/10/2019 11:46, Jacopo Mondi wrote: > > Add a driver for the R-Car Display Unit Color Correction Module. > > > > In most of Gen3 SoCs, each DU output channel is provided with a CMM un

Re: [PATCH v5 5/8] drm: rcar-du: crtc: Control CMM operations

2019-10-15 Thread Jacopo Mondi
Hi Kieran, On Tue, Oct 15, 2019 at 02:15:35PM +0100, Kieran Bingham wrote: > Hi Jacopo, > > On 15/10/2019 11:46, Jacopo Mondi wrote: > > Implement CMM handling in the crtc begin and enable atomic callbacks, > > and enable CMM unit through the Display Extensional Functions > > Extensional ? > > Per

[PATCH] drm: Add LT-tunable PHY repeater mode operations

2019-10-15 Thread Siqueira, Rodrigo
LT-tunable PHY Repeaters can operate in two different modes: transparent (default) and non-transparent. The value 0x55 specifies the transparent mode, and 0xaa represents the non-transparent; this commit adds these two values as definitions. Cc: Abdoulaye Berthe Cc: Harry Wentland Cc: Leo Li Cc

[PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

2019-10-15 Thread Fabio Estevam
Booting the adreno driver on a imx53 board leads to the following error message: adreno 3000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels As the "qcom,gpu-pwrlevels" property is optional and never present on i.MX5, turn the message into debug level instead. Signed-o

Re: [PATCH] drm: Add LT-tunable PHY repeater mode operations

2019-10-15 Thread Ville Syrjälä
On Tue, Oct 15, 2019 at 01:40:12PM +, Siqueira, Rodrigo wrote: > LT-tunable PHY Repeaters can operate in two different modes: transparent > (default) and non-transparent. The value 0x55 specifies the transparent > mode, and 0xaa represents the non-transparent; this commit adds these > two value

[PATCH] drm/nouveau/disp/gv100: make gv100_disp_core_mthd_{base,sor} static

2019-10-15 Thread Ben Dooks
The gv100_disp_core_mthd_{base,sor} are not used outside of the file they are defined in, so make them static to avoid the following sparse warning: drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c:27:1: warning: symbol 'gv100_disp_core_mthd_base' was not declared. Should it be static? driver

Re: [PATCH v5 1/8] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation

2019-10-15 Thread Geert Uytterhoeven
Hi Jacopo, On Tue, Oct 15, 2019 at 12:44 PM Jacopo Mondi wrote: > Add device tree bindings documentation for the Renesas R-Car Display > Unit Color Management Module. > > CMM is the image enhancement module available on each R-Car DU video > channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M exclud

Re: [PATCH 0/4] treewide: fix interrupted release

2019-10-15 Thread Daniel Vetter
On Mon, Oct 14, 2019 at 06:13:26PM +0200, Johan Hovold wrote: > On Mon, Oct 14, 2019 at 10:48:47AM +0200, Daniel Vetter wrote: > > On Fri, Oct 11, 2019 at 11:36:33AM +0200, Johan Hovold wrote: > > > On Thu, Oct 10, 2019 at 03:50:43PM +0200, Daniel Vetter wrote: > > > > On Thu, Oct 10, 2019 at 03:13

[PATCH] drm/nouveau/hwmon: fix use of integer as a pointer

2019-10-15 Thread Ben Dooks
The special_groups[] in nouveau_hwmon_init() is an array of pointers, so use NULL instead of '0' as the initialiser. Fixes the following sparse warning: drivers/gpu/drm/nouveau/nouveau_hwmon.c:744:29: warning: Using plain integer as NULL pointer Signed-off-by: Ben Dooks --- Cc: Ben Skeggs Cc:

[Bug 111980] Rebbot and shutdown doesn't work on specific hardware

2019-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111980 --- Comment #3 from Tim Cuthbertson --- This morning, my kernel was upgraded to version 5.3.6-arch1-1-ARCH dated Oct 11. The problem persists. -- You are receiving this mail because: You are the assignee for the bug.___

Re: [PATCH] drm: Generalized NV Block Linear DRM format mod

2019-10-15 Thread Daniel Vetter
On Mon, Oct 14, 2019 at 03:13:21PM -0700, James Jones wrote: > Builds upon the existing NVIDIA 16Bx2 block linear > format modifiers by adding more "fields" to the > existing parameterized > DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK format modifier > macro that allow fully defining a unique-across- > all-N

[PATCH] drm/syncobj: include for drm_timeout_abs_to_jiffies

2019-10-15 Thread Ben Dooks (Codethink)
Include for drm_timeout_abs_to_jiffies definiton to fix the following sparse warning: drivers/gpu/drm/drm_syncobj.c:1019:13: warning: symbol 'drm_timeout_abs_to_jiffies' was not declared. Should it be static? Signed-off-by: Ben Dooks --- Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul

Re: [PATCH v5 3/8] drm: rcar-du: Add support for CMM

2019-10-15 Thread Kieran Bingham
On 15/10/2019 14:33, Jacopo Mondi wrote: > Hi Kieran, thanks for review >>> +config DRM_RCAR_CMM >>> + bool "R-Car DU Color Management Module (CMM) Support" >>> + depends on DRM && OF >>> + depends on DRM_RCAR_DU >> >> >> DRM_RCAR_DU already depends on both DRM && OF, so I wonder if those

[Bug 112008] eDP -> Dual Channel LVDS bridge unable to accept any modelines: Corrupt display!

2019-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=112008 --- Comment #4 from Alex Deucher --- Can you use git bisect the issue and find the exact commit that broke it or narrow down when the regression happened? E.g., working in 4.17-rc3 and broken in 4.17-rc4? -- You are receiving this mail becaus

Re: [PATCH] drm: Add LT-tunable PHY repeater mode operations

2019-10-15 Thread Harry Wentland
On 2019-10-15 9:40 a.m., Siqueira, Rodrigo wrote: > LT-tunable PHY Repeaters can operate in two different modes: transparent > (default) and non-transparent. The value 0x55 specifies the transparent > mode, and 0xaa represents the non-transparent; this commit adds these > two values as definitions.

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-15 Thread Andy Shevchenko
On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf Trønnes wrote: > spi-bcm2835 can handle >64kB buffers now so there is no need to check > ->max_dma_len. The tinydrm_spi_max_transfer_size() max_len argument is > not used by any callers, so not needed. > > Then we have the spi_max module parameter.

Re: [PATCH v2 00/15] DRM fbconv helpers for converting fbdev drivers

2019-10-15 Thread Daniel Vetter
Hi Thomas, On Mon, Oct 14, 2019 at 04:04:01PM +0200, Thomas Zimmermann wrote: > (was: DRM driver for fbdev devices) > > This is version 2 of the fbdev conversion helpers. It's more or less a > rewrite of the original patchset. > > The fbdev subsystem is considered legacy and will probably be rem

[PATCH 06/15] drm/dp: Read AUX read interval from DPCD

2019-10-15 Thread Thierry Reding
From: Thierry Reding Store the AUX read interval from DPCD, so that it can be used to wait for the durations given in the specification during link training. Signed-off-by: Thierry Reding --- include/drm/drm_dp_helper.h | 33 + 1 file changed, 33 insertions(+)

[PATCH 01/15] drm/dp: Sort includes alphabetically

2019-10-15 Thread Thierry Reding
From: Thierry Reding Keeping the list sorted alphabetically makes it much easier to determine where to add new includes. Signed-off-by: Thierry Reding --- include/drm/drm_dp_helper.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/include/d

[PATCH 05/15] drm/dp: Add drm_dp_alternate_scrambler_reset_cap() helper

2019-10-15 Thread Thierry Reding
From: Thierry Reding Add a helper to check if the sink supports the eDP alternate scrambler reset value of 0xfffe. Signed-off-by: Thierry Reding --- include/drm/drm_dp_helper.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h

[PATCH 07/15] drm/dp: Do not busy-loop during link training

2019-10-15 Thread Thierry Reding
From: Thierry Reding Use microsecond sleeps for the clock recovery and channel equalization delays during link training. The duration of these delays can be from 100 us up to 16 ms. It is rude to busy-loop for that amount of time. While at it, also convert to standard coding style by putting the

[PATCH 02/15] drm/dp: Remove a gratuituous blank line

2019-10-15 Thread Thierry Reding
From: Thierry Reding It's idiomatic to check the return value of a function call immediately after the function call, without any blank lines in between, to make it more obvious that the two lines belong together. v2: fix outdated commit message (Philipp Zabel) Signed-off-by: Thierry Reding --

[PATCH 00/15] drm/dp: Move drm_dp_link helpers to Tegra DRM

2019-10-15 Thread Thierry Reding
From: Thierry Reding Hi, Following up on the discussion about the usefulness of the drm_dp_link helpers, here's a new series that adds a couple of new DPCD parser functions and then pushes the drm_dp_link helpers down into drivers. For most drivers this was pretty easy to do since they didn't he

[PATCH 08/15] drm/dp: Use drm_dp_aux_rd_interval()

2019-10-15 Thread Thierry Reding
From: Thierry Reding Make use of the newly added drm_dp_aux_rd_interval() helper in existing DP link training helpers. v2: drop stale sentence from commit message (Philipp Zabel) Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_dp_helper.c | 26 +++--- 1 file changed,

[PATCH 04/15] drm/dp: Add drm_dp_channel_coding_supported() helper

2019-10-15 Thread Thierry Reding
From: Thierry Reding Add a helper to check whether the sink supports ANSI 8B/10B channel coding capability as specified in ANSI X3.230-1994, clause 11. Signed-off-by: Thierry Reding --- include/drm/drm_dp_helper.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/drm/drm_dp_he

[PATCH 10/15] drm/bridge: analogix-anx78xx: Avoid drm_dp_link helpers

2019-10-15 Thread Thierry Reding
From: Thierry Reding During the discussion of patches that enhance the drm_dp_link helpers it was concluded that these helpers aren't very useful to begin with. Start pushing the equivalent code into individual drivers to ultimately remove them. Signed-off-by: Thierry Reding --- drivers/gpu/dr

[PATCH 03/15] drm/dp: Add drm_dp_fast_training_cap() helper

2019-10-15 Thread Thierry Reding
From: Thierry Reding Add a helper that checks for the fast training capability given the DPCD receiver capabilities blob. Signed-off-by: Thierry Reding --- include/drm/drm_dp_helper.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_he

[PATCH 12/15] drm/bridge: tc358767: Use DP nomenclature

2019-10-15 Thread Thierry Reding
From: Thierry Reding The DP specification uses the term "default framing" instead of "non- enhanced framing". Reviewed-by: Andrzej Hajda Signed-off-by: Thierry Reding --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/brid

[PATCH 15/15] drm/tegra: Move drm_dp_link helpers to Tegra DRM

2019-10-15 Thread Thierry Reding
From: Thierry Reding During the discussion of patches that enhance the drm_dp_link helpers it was concluded that these helpers aren't very useful to begin with. After all other drivers have been converted not to use these helpers anymore, move these helpers into the last remaining user: Tegra DRM

[PATCH 13/15] drm/msm: edp: Avoid drm_dp_link helpers

2019-10-15 Thread Thierry Reding
From: Thierry Reding During the discussion of patches that enhance the drm_dp_link helpers it was concluded that these helpers aren't very useful to begin with. Start pushing the equivalent code into individual drivers to ultimately remove them. Signed-off-by: Thierry Reding --- drivers/gpu/dr

[PATCH 11/15] drm/bridge: tc358767: Avoid drm_dp_link helpers

2019-10-15 Thread Thierry Reding
From: Thierry Reding During the discussion of patches that enhance the drm_dp_link helpers it was concluded that these helpers aren't very useful to begin with. Start pushing the equivalent code into individual drivers to ultimately remove them. Signed-off-by: Thierry Reding --- drivers/gpu/dr

[PATCH 09/15] drm/dp: Add helper to get post-cursor adjustments

2019-10-15 Thread Thierry Reding
From: Thierry Reding If the transmitter supports pre-emphasis post cursor2 the sink will request adjustments in a similar way to how it requests adjustments to the voltage swing and pre-emphasis settings. Add a helper to extract these adjustments on a per-lane basis from the DPCD link status. R

[PATCH 14/15] drm/rockchip: Avoid drm_dp_link helpers

2019-10-15 Thread Thierry Reding
From: Thierry Reding During the discussion of patches that enhance the drm_dp_link helpers it was concluded that these helpers aren't very useful to begin with. Start pushing the equivalent code into individual drivers to ultimately remove them. Signed-off-by: Thierry Reding --- drivers/gpu/dr

  1   2   >