[PATCH v5 3/8] ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on stm32429-disco board

2020-05-25 Thread dillon . minfei
From: dillon min Enable the ltdc & ili9341, gyro l3gd20 on stm32429-disco board. Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f429-disco.dts | 48 +++ 1 file changed, 48 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429-disco.dts

Re: [PATCH v4 4/5] dt: bindings: brcmnand: add v2.1 and v2.2 support

2020-05-25 Thread Miquel Raynal
Álvaro Fernández Rojas wrote on Sun, 24 May 2020 21:13:41 +: > Thanks for merging the patches :). > > BTW, is there something wrong with patch 5? > I can see patches 1-4 applied in > https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/log/?h=nand/next, > but I can’t see patch

[PATCH v5 4/8] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2020-05-25 Thread dillon . minfei
From: dillon min Add documentation for "ilitek,ili9341" panel. Signed-off-by: dillon min --- .../bindings/display/panel/ilitek,ili9341.yaml | 69 ++ 1 file changed, 69 insertions(+) create mode 100644

Re: [PATCH v4 1/2] mtd: rawnand: brcmnand: fix hamming oob layout

2020-05-25 Thread Miquel Raynal
On Tue, 2020-05-12 at 07:57:32 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > First 2 bytes are used in large-page nand. > > Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops") > Cc: sta...@vger.kernel.org > Signed-off-by: Álvaro Fernández Rojas Applied to

[PATCH v5 6/8] drm/panel: Add ilitek ili9341 panel driver

2020-05-25 Thread dillon . minfei
From: dillon min This driver combine tiny/ili9341.c mipi_dbi_interface driver with mipi_dpi_interface driver, can support ili9341 with serial mode or parallel rgb interface mode by register configuration. Changes since V3: accoding to Linus Walleij's suggestion. 1 add more

Re: MIPI DSI, DBI, and tinydrm drivers

2020-05-25 Thread Paul Cercueil
Hi Noralf, Le dim. 24 mai 2020 à 19:46, Noralf Trønnes a écrit : Den 24.05.2020 18.13, skrev Paul Cercueil: Hi list, I'd like to open a discussion about the current support of MIPI DSI and DBI panels. Both are standards from the MIPI alliance, both are communication protocols

Re: [PATCH v5 07/13] soc: mediatek: cmdq: add write_s function

2020-05-25 Thread Dennis-YC Hsieh
Hi Mattias, Thanks for your comment. On Sat, 2020-05-16 at 20:14 +0200, Matthias Brugger wrote: > > On 08/03/2020 11:52, Dennis YC Hsieh wrote: > > add write_s function in cmdq helper functions which > > writes value contains in internal register to address > > with large dma access support. >

Re: [PATCH v5 13/13] soc: mediatek: cmdq: add set event function

2020-05-25 Thread Dennis-YC Hsieh
Hi Matthias, Thanks for your comment. On Sat, 2020-05-16 at 20:32 +0200, Matthias Brugger wrote: > > On 08/03/2020 11:52, Dennis YC Hsieh wrote: > > Add set event function in cmdq helper functions to set specific event. > > > > Signed-off-by: Dennis YC Hsieh > > Reviewed-by: CK Hu > > --- >

Re: [PATCH v4 1/5] mtd: rawnand: brcmnand: rename v4 registers

2020-05-25 Thread Miquel Raynal
On Fri, 2020-05-22 at 12:15:20 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > These registers are also used on v3.3. > > Signed-off-by: Álvaro Fernández Rojas > Reviewed-by: Miquel Raynal > Acked-by: Florian Fainelli Applied to

[PATCH v5 1/8] ARM: dts: stm32: Add dma config for spi5

2020-05-25 Thread dillon . minfei
From: dillon min Enable spi5's dma configuration. for graphics data output to ilitek ili9341 panel via mipi dbi interface Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f429.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429.dtsi

Re: MIPI DSI, DBI, and tinydrm drivers

2020-05-25 Thread Paul Cercueil
Hi Daniel, Le dim. 24 mai 2020 à 20:35, Daniel Vetter a écrit : On Sun, May 24, 2020 at 7:46 PM Noralf Trønnes wrote: Den 24.05.2020 18.13, skrev Paul Cercueil: > Hi list, > > I'd like to open a discussion about the current support of MIPI DSI and > DBI panels. > > Both are

[PATCH v2 0/4] drm/etnaviv: Tidy up clocks handling

2020-05-25 Thread Lubomir Rintel
Hi, please consider applying patches that are chained to this message. They make getting/enabling the clocks in the etnaviv driver slightly nicer, first two also fix potential problems. Compared to v1, patch 2/4 was fixed and patch 3/4 was added. As it was pointed out in response to v1, the

[PATCH v5 8/8] spi: flags 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' can't be coexit with 'SPI_3WIRE' mode

2020-05-25 Thread dillon . minfei
From: dillon min since chip spi driver need get the transfer direction by 'tx_buf' and 'rx_buf' of 'struct spi_transfer' in 'SPI_3WIRE' mode. so, we need bypass 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' feature in 'SPI_3WIRE' mode Signed-off-by: dillon min --- drivers/spi/spi.c |

Re: MIPI DSI, DBI, and tinydrm drivers

2020-05-25 Thread Paul Cercueil
Le dim. 24 mai 2020 à 22:14, Noralf Trønnes a écrit : Den 24.05.2020 21.54, skrev Paul Cercueil: Hi Noralf, Le dim. 24 mai 2020 à 19:46, Noralf Trønnes a écrit : Den 24.05.2020 18.13, skrev Paul Cercueil: Hi list, I'd like to open a discussion about the current support of

[PATCH v5 6/8] drm/panel: Add ilitek ili9341 panel driver

2020-05-25 Thread dillon . minfei
From: dillon min This driver combine tiny/ili9341.c mipi_dbi_interface driver with mipi_dpi_interface driver, can support ili9341 with serial mode or parallel rgb interface mode by register configuration. Changes since V3: accoding to Linus Walleij's suggestion. 1 add more

[PATCH v2 3/4] drm/etnaviv: Make the "core" clock mandatory

2020-05-25 Thread Lubomir Rintel
It is always present. It was documented as mandatory prior to commit 90aeca875f8a ("dt-bindings: display: Convert etnaviv to json-schema"). Signed-off-by: Lubomir Rintel --- Changes since v1: - Add this patch --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v4 2/5] mtd: rawnand: brcmnand: fix CS0 layout

2020-05-25 Thread Miquel Raynal
On Fri, 2020-05-22 at 12:15:21 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > Only v3.3-v5.0 have a different CS0 layout. > Controllers before v3.3 use the same layout for every CS. > > Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB > NAND controller") >

[PATCH v1 1/4] gpu: host1x: Optimize BOs usage when firewall is enabled

2020-05-25 Thread Dmitry Osipenko
We don't need to hold and pin original BOs of the gathers in a case of enabled firewall because in this case gather's content is copied and the copy is used by the executed job. Signed-off-by: Dmitry Osipenko --- drivers/gpu/host1x/job.c | 14 -- 1 file changed, 12 insertions(+), 2

[PATCH v5 5/8] clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate, fix duplicated ltdc clock register to 'clk_core' case ltdc's clock turn off by clk_disable_unused()

2020-05-25 Thread dillon . minfei
From: dillon min ltdc set clock rate crashed 'post_div_data[]''s pll_num is PLL_I2S, PLL_SAI (number is 1,2). but, as pll_num is offset of 'clks[]' input to clk_register_pll_div(), which is FCLK, CLK_LSI, defined in 'include/dt-bindings/clock/stm32fx-clock.h' so, this is a null

[PATCH v5 0/8] Enable ili9341 and l3gd20 on stm32f429-disco

2020-05-25 Thread dillon . minfei
From: dillon min V5's update based on Mark Brown's suggestion, use 'SPI_MASTER_MUST_RX' for SPI_SIMPLEX_RX mode on stm32 spi controller. V5: 1 instead of add send dummy data out under SIMPLEX_RX mode, add flags 'SPI_CONTROLLER_MUST_TX' for stm32 spi driver 2 bypass 'SPI_CONTROLLER_MUST_TX'

Re: [PATCH v4 2/2] mtd: rawnand: brcmnand: improve hamming oob layout

2020-05-25 Thread Miquel Raynal
On Tue, 2020-05-12 at 07:57:33 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > The current code generates 8 oob sections: > S11-5 > ECC 6-8 > S29-15 > S316-21 > ECC 22-24 > S425-31 > S532-37 > ECC 38-40 > S641-47 > S748-53 > ECC 54-56 > S857-63 >

[PATCH v5 7/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4

2020-05-25 Thread dillon . minfei
From: dillon min in l3gd20 driver startup, there is a setup failed error return from stm32 spi driver " [2.687630] st-gyro-spi spi0.0: supply vdd not found, using dummy regulator [2.696869] st-gyro-spi spi0.0: supply vddio not found, using dummy regulator [

Re: [PATCH v5 09/13] soc: mediatek: cmdq: add write_s value function

2020-05-25 Thread Dennis-YC Hsieh
Hi Matthias, Thanks for your comment. On Sat, 2020-05-16 at 20:20 +0200, Matthias Brugger wrote: > > On 08/03/2020 11:52, Dennis YC Hsieh wrote: > > add write_s function in cmdq helper functions which > > writes a constant value to address with large dma > > access support. > > > >

[PATCH v2 2/4] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-25 Thread Lubomir Rintel
There might be good reasons why the getting a clock failed. To treat the clocks as optional we're specifically only interested in ignoring -ENOENT, and devm_clk_get_optional() does just that. Note that this preserves the original behavior of all clocks being optional. The binding document

[PATCH v2 1/4] drm/etnaviv: Fix error path on failure to enable bus clk

2020-05-25 Thread Lubomir Rintel
Since commit 65f037e8e908 ("drm/etnaviv: add support for slave interface clock") the reg clock is enabled before the bus clock and we need to undo its enablement on error. Fixes: 65f037e8e908 ("drm/etnaviv: add support for slave interface clock") Signed-off-by: Lubomir Rintel ---

Re: MIPI DSI, DBI, and tinydrm drivers

2020-05-25 Thread Paul Cercueil
Hi Sam, Le dim. 24 mai 2020 à 22:06, Sam Ravnborg a écrit : Hi Paul. On Sun, May 24, 2020 at 06:13:16PM +0200, Paul Cercueil wrote: Hi list, I'd like to open a discussion about the current support of MIPI DSI and DBI panels. Both are standards from the MIPI alliance, both are

[PATCH v5 0/8] Enable ili9341 and l3gd20 on stm32f429-disco

2020-05-25 Thread dillon . minfei
From: dillon min V5's update based on Mark Brown's suggestion, use 'SPI_MASTER_MUST_RX' for SPI_SIMPLEX_RX mode on stm32 spi controller. V5: 1 instead of add send dummy data out under SIMPLEX_RX mode, add flags 'SPI_CONTROLLER_MUST_TX' for stm32 spi driver 2 bypass 'SPI_CONTROLLER_MUST_TX'

[PATCH v1 0/4] Minor improvements for Host1x driver

2020-05-25 Thread Dmitry Osipenko
Hello, This series contains some minor improvements for the Host1x driver which I picked up from an older local git branch. I selected the less invasive and most relevant patches and added one new patch that dumps the push buffer state, a day ago it helped me to debug SMMU driver issue that is

[PATCH v2 4/4] drm/etnaviv: Simplify clock enable/disable

2020-05-25 Thread Lubomir Rintel
All the NULL checks are pointless, clk_*() routines already deal with NULL just fine. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 53 ++- 1 file changed, 19 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c

Re: [PATCH v5 10/13] soc: mediatek: cmdq: export finalize function

2020-05-25 Thread Dennis-YC Hsieh
Hi Matthias, Thanks for your comment. On Sat, 2020-05-16 at 20:22 +0200, Matthias Brugger wrote: > > On 08/03/2020 11:52, Dennis YC Hsieh wrote: > > Export finalize function to client which helps append eoc and jump > > command to pkt. Let client decide call finalize or not. > > > >

[PATCH v5 1/8] ARM: dts: stm32: Add dma config for spi5

2020-05-25 Thread dillon . minfei
From: dillon min Enable spi5's dma configuration. for graphics data output to ilitek ili9341 panel via mipi dbi interface Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f429.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429.dtsi

Re: [PATCH v5 06/13] soc: mediatek: cmdq: add assign function

2020-05-25 Thread Dennis-YC Hsieh
Hi Matthias, Thanks for your comment. On Sat, 2020-05-16 at 19:59 +0200, Matthias Brugger wrote: > > On 08/03/2020 11:52, Dennis YC Hsieh wrote: > > Add assign function in cmdq helper which assign constant value into > > internal register by index. > > > > Signed-off-by: Dennis YC Hsieh > >

Re: [PATCH v4 4/5] dt: bindings: brcmnand: add v2.1 and v2.2 support

2020-05-25 Thread Miquel Raynal
Miquel Raynal wrote on Sun, 24 May 2020 21:25:50 +0200: > On Fri, 2020-05-22 at 12:15:23 UTC, > =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > > Added brcm,brcmnand-v2.1 and brcm,brcmnand-v2.2 as possible compatible > > strings to support brcmnand controllers v2.1 and v2.2. > > > >

[PATCH v5 8/8] spi: flags 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' can't be coexit with 'SPI_3WIRE' mode

2020-05-25 Thread dillon . minfei
From: dillon min since chip spi driver need get the transfer direction by 'tx_buf' and 'rx_buf' of 'struct spi_transfer' in 'SPI_3WIRE' mode. so, we need bypass 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' feature in 'SPI_3WIRE' mode Signed-off-by: dillon min --- drivers/spi/spi.c |

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-25 Thread Lubomir Rintel
Cc += robh On Wed, May 20, 2020 at 04:04:39PM +0200, Lucas Stach wrote: > Am Mittwoch, den 20.05.2020, 15:38 +0200 schrieb Lubomir Rintel: > > On Thu, May 14, 2020 at 09:53:08AM +0100, Russell King - ARM Linux admin > > wrote: > > > On Thu, May 14, 2020 at 10:40:58AM +0200, Lucas Stach wrote: >

MIPI DSI, DBI, and tinydrm drivers

2020-05-25 Thread Paul Cercueil
Hi list, I'd like to open a discussion about the current support of MIPI DSI and DBI panels. Both are standards from the MIPI alliance, both are communication protocols between a LCD controller and a LCD panel, they generally both use the same commands (DCS), the main difference is that DSI

Re: MIPI DSI, DBI, and tinydrm drivers

2020-05-25 Thread Paul Cercueil
Le dim. 24 mai 2020 à 23:24, Noralf Trønnes a écrit : Den 24.05.2020 22.42, skrev Paul Cercueil: Le dim. 24 mai 2020 à 22:14, Noralf Trønnes a écrit : Den 24.05.2020 21.54, skrev Paul Cercueil: Hi Noralf, Le dim. 24 mai 2020 à 19:46, Noralf Trønnes a écrit : Den

Re: [PATCH v4 4/5] dt: bindings: brcmnand: add v2.1 and v2.2 support

2020-05-25 Thread Miquel Raynal
On Fri, 2020-05-22 at 12:15:23 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > Added brcm,brcmnand-v2.1 and brcm,brcmnand-v2.2 as possible compatible > strings to support brcmnand controllers v2.1 and v2.2. > > Signed-off-by: Álvaro Fernández Rojas > Acked-by: Florian Fainelli

[PATCH] video: fbdev: pxafb: Use correct return value for pxafb_probe()

2020-05-25 Thread Tiezhu Yang
When call function devm_platform_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Signed-off-by: Tiezhu Yang --- drivers/video/fbdev/pxafb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/pxafb.c

[PATCH v1 4/4] gpu: host1x: debug: Dump push buffer state

2020-05-25 Thread Dmitry Osipenko
When job hangs and there is a memory error pointing at channel's push buffer, it is very handy to know the push buffer's state. This patch makes the push buffer's state to be dumped into KMSG in addition to the job's gathers. Signed-off-by: Dmitry Osipenko --- drivers/gpu/host1x/hw/debug_hw.c |

[PATCH v5 4/8] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2020-05-25 Thread dillon . minfei
From: dillon min Add documentation for "ilitek,ili9341" panel. Signed-off-by: dillon min --- .../bindings/display/panel/ilitek,ili9341.yaml | 69 ++ 1 file changed, 69 insertions(+) create mode 100644

[PATCH v1 3/4] gpu: host1x: debug: Fix multiple channels emitting messages simultaneously

2020-05-25 Thread Dmitry Osipenko
Once channel's job is hung, it dumps the channel's state into KMSG before tearing down the offending job. If multiple channels hang at once, then they dump messages simultaneously, making the debug info unreadable, and thus, useless. This patch adds mutex which allows only one channel to emit

Re: [PATCH v4 5/5] mtd: rawnand: brcmnand: support v2.1-v2.2 controllers

2020-05-25 Thread Miquel Raynal
On Fri, 2020-05-22 at 12:15:24 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > v2.1: tested on Netgear DGND3700v1 (BCM6368) > v2.2: tested on Netgear DGND3700v2 (BCM6362) > > Signed-off-by: Álvaro Fernández Rojas > Acked-by: Florian Fainelli Applied to

Re: [PATCH v4 4/5] dt: bindings: brcmnand: add v2.1 and v2.2 support

2020-05-25 Thread Álvaro Fernández Rojas
Thanks for merging the patches :). BTW, is there something wrong with patch 5? I can see patches 1-4 applied in https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/log/?h=nand/next, but I can’t see patch 5. Best regards, Álvaro. De: Miquel Raynal

Re: [PATCH v5 0/6] Support DRM bridges on NVIDIA Tegra

2020-05-25 Thread Dmitry Osipenko
18.04.2020 20:06, Dmitry Osipenko пишет: > Hello, > > This series adds initial support for the DRM bridges to NVIDIA Tegra DRM > driver. This is required by newer device-trees where we model the LVDS > encoder bridge properly. > > Changelog: > > v5: - Added new patches that make

Re: [PATCH v4] mtd: rawnand: brcmnand: correctly verify erased pages

2020-05-25 Thread Miquel Raynal
On Tue, 2020-05-12 at 08:24:51 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > The current code checks that the whole OOB area is erased. > This is a problem when JFFS2 cleanmarkers are added to the OOB, since it will > fail due to the usable OOB bytes not being 0xff. > Correct this by

[PATCH v5 2/8] ARM: dts: stm32: Add pin map for ltdc & spi5 on stm32f429-disco board

2020-05-25 Thread dillon . minfei
From: dillon min This patch adds the pin configuration for ltdc and spi5 controller on stm32f429-disco board. Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 67 ++ 1 file changed, 67 insertions(+) diff --git

Re: [PATCH v4 3/5] mtd: rawnand: brcmnand: rename page sizes

2020-05-25 Thread Miquel Raynal
On Fri, 2020-05-22 at 12:15:22 UTC, =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= wrote: > Current pages sizes apply to controllers after v3.4 > > Signed-off-by: Álvaro Fernández Rojas > Acked-by: Florian Fainelli Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git

Re: [PATCH v2] linux/bits.h: adjust GENMASK_INPUT_CHECK() check

2020-05-25 Thread Rikard Falkeborn
On Fri, May 22, 2020 at 07:50:19PM +0100, Emil Velikov wrote: > Hi Rikard, > > > On 2020/05/19, Rikard Falkeborn wrote: > > + Andrew et al who recieved mail from the build robot this morning about > > the same issue. > > > > On Tue, May 19, 2020 at 10:14:52PM +0100, Emil Velikov wrote: > > >

[PATCH v5 2/8] ARM: dts: stm32: Add pin map for ltdc & spi5 on stm32f429-disco board

2020-05-25 Thread dillon . minfei
From: dillon min This patch adds the pin configuration for ltdc and spi5 controller on stm32f429-disco board. Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 67 ++ 1 file changed, 67 insertions(+) diff --git

[PATCH v5 3/8] ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on stm32429-disco board

2020-05-25 Thread dillon . minfei
From: dillon min Enable the ltdc & ili9341, gyro l3gd20 on stm32429-disco board. Signed-off-by: dillon min --- arch/arm/boot/dts/stm32f429-disco.dts | 48 +++ 1 file changed, 48 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429-disco.dts

[PATCH v5 5/8] clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate, fix duplicated ltdc clock register to 'clk_core' case ltdc's clock turn off by clk_disable_unused()

2020-05-25 Thread dillon . minfei
From: dillon min ltdc set clock rate crashed 'post_div_data[]''s pll_num is PLL_I2S, PLL_SAI (number is 1,2). but, as pll_num is offset of 'clks[]' input to clk_register_pll_div(), which is FCLK, CLK_LSI, defined in 'include/dt-bindings/clock/stm32fx-clock.h' so, this is a null

Re: [PATCH v5 12/13] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api

2020-05-25 Thread Dennis-YC Hsieh
Hi Matthias, Thanks for your comment. On Sat, 2020-05-16 at 20:30 +0200, Matthias Brugger wrote: > > On 08/03/2020 11:52, Dennis YC Hsieh wrote: > > Add clear parameter to let client decide if > > event should be clear to 0 after GCE receive it. > > > > Signed-off-by: Dennis YC Hsieh > > ---

[PATCH v5 7/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4

2020-05-25 Thread dillon . minfei
From: dillon min in l3gd20 driver startup, there is a setup failed error return from stm32 spi driver " [2.687630] st-gyro-spi spi0.0: supply vdd not found, using dummy regulator [2.696869] st-gyro-spi spi0.0: supply vddio not found, using dummy regulator [

[PATCH] drm/panfrost: Fix runtime PM imbalance in panfrost_perfcnt_enable_locked

2020-05-25 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. For all error paths after pm_runtime_get_sync(), things are the same. Signed-off-by: Dinghao Liu ---

[PATCH] drm/i915/selftests: Fix runtime PM imbalance on error

2020-05-25 Thread Dinghao Liu
When drm_dev_init() returns an error code, a pairing runtime PM usage counter decrement is needed to keep the counter balanced. For error paths after this call, things are the same. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 + 1 file changed, 1

Re: [PATCH v5 09/13] soc: mediatek: cmdq: add write_s value function

2020-05-25 Thread Dennis-YC Hsieh
On Sun, 2020-05-24 at 20:13 +0200, Matthias Brugger wrote: > > On 24/05/2020 19:31, Dennis-YC Hsieh wrote: > > Hi Matthias, > > > > Thanks for your comment. > > > > On Sat, 2020-05-16 at 20:20 +0200, Matthias Brugger wrote: > >> > >> On 08/03/2020 11:52, Dennis YC Hsieh wrote: > >>> add

Re: [PATCH] drm: rcar-du: Fix build error

2020-05-25 Thread Daniel G
Hi Laurent, On Fri, 22 May 2020 at 22:24, Laurent Pinchart wrote: > > Hi Daniel, > > Thank you for the patch. > > On Mon, May 18, 2020 at 10:16:46PM +0200, Daniel Gomez wrote: > > Select DRM_KMS_HELPER dependency. > > > > Build error when DRM_KMS_HELPER is not selected: > > > >

[PATCH v1 2/4] gpu: host1x: Put gather's BO on pinning error

2020-05-25 Thread Dmitry Osipenko
This patch fixes gather's BO refcounting on a pinning error. Gather's BO won't be leaked now if something goes wrong. Signed-off-by: Dmitry Osipenko --- drivers/gpu/host1x/job.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/host1x/job.c

Re: [PATCH v5 10/13] soc: mediatek: cmdq: export finalize function

2020-05-25 Thread Matthias Brugger
On 25/05/2020 02:23, Chun-Kuang Hu wrote: > Hi, Matthias: > > Matthias Brugger 於 2020年5月17日 週日 上午2:22寫道: >> >> >> >> On 08/03/2020 11:52, Dennis YC Hsieh wrote: >>> Export finalize function to client which helps append eoc and jump >>> command to pkt. Let client decide call finalize or not.

Re: [PATCH v2 01/16] video: amba-clcd: use devm_of_find_backlight

2020-05-25 Thread Linus Walleij
On Mon, May 18, 2020 at 12:16 PM Sam Ravnborg wrote: > Hi Linus. > > On Mon, May 18, 2020 at 10:10:12AM +0200, Linus Walleij wrote: > > On Sun, May 17, 2020 at 9:01 PM Sam Ravnborg wrote: > > > > > Look up backlight device using devm_of_find_backlight(). > > > This simplifies the code and

Re: [PATCH 20/21] drm/tv200: Use GEM CMA object functions

2020-05-25 Thread Linus Walleij
On Fri, May 22, 2020 at 3:53 PM Thomas Zimmermann wrote: > The tve200 driver uses the default implementation for CMA functions. The > DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. > All remaining operations are provided by CMA GEM object functions. > > Signed-off-by:

Re: [PATCH v5 4/8] dt-bindings: display: panel: Add ilitek ili9341 panel bindings

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 5:46 AM wrote: > From: dillon min > > Add documentation for "ilitek,ili9341" panel. > > Signed-off-by: dillon min This looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list

Re: [PATCH v1 1/2] drm/vblank: use drm_* functions for logging

2020-05-25 Thread Thomas Zimmermann
Hi Am 23.05.20 um 09:12 schrieb Sam Ravnborg: > Replace all DRM_* logging functions with their drm_ counterparts. > checkpatch emits a few "quoted string split across lines", > which is left as is. The strings was already split in the original code > base and it would not increase readability to

Re: [PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-25 Thread Thomas Zimmermann
Hi Sam Am 22.05.20 um 19:48 schrieb Sam Ravnborg: > Hi Thomas. > > On Fri, May 22, 2020 at 03:52:26PM +0200, Thomas Zimmermann wrote: >> Rename the macro to DRM_GEM_CMA_DRIVER_OPS to align with SHMEM >> helpers. > This part is fine, I like that the naming is somehow consistent. > >> An internal

Re: [PATCH v5 09/13] soc: mediatek: cmdq: add write_s value function

2020-05-25 Thread Matthias Brugger
On 25/05/2020 04:27, Dennis-YC Hsieh wrote: > > On Sun, 2020-05-24 at 20:13 +0200, Matthias Brugger wrote: >> >> On 24/05/2020 19:31, Dennis-YC Hsieh wrote: >>> Hi Matthias, >>> >>> Thanks for your comment. >>> >>> On Sat, 2020-05-16 at 20:20 +0200, Matthias Brugger wrote: On

Re: [PATCH] drm: drm_fourcc: add NV15, Q410, Q401 YUV formats

2020-05-25 Thread Jonas Karlman
Hi, On 2020-05-15 15:37, Brian Starkey wrote: > Hi Ben, > > On Wed, May 06, 2020 at 03:41:26PM +0100, Ben Davis wrote: >> Hi all, any feedback on this patch? >> Thanks, Ben >> On Wed, Apr 22, 2020 at 12:13:49PM +0100, Ben Davis wrote: >>> DRM_FORMAT_NV15 is a 2 plane format suitable for linear

Re: [PATCH 12/21] drm/mcde: Use GEM CMA object functions

2020-05-25 Thread Linus Walleij
On Fri, May 22, 2020 at 3:52 PM Thomas Zimmermann wrote: > The mcde driver uses the default implementation for CMA functions. The > DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. > All remaining operations are provided by CMA GEM object functions. > > Signed-off-by:

Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4

2020-05-25 Thread Mark Brown
On Sat, May 23, 2020 at 09:35:06AM +0800, dillon min wrote: > - if (ctlr->flags & (SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX)) { > + if ((ctlr->flags & (SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX)) > && > + !(msg->spi->mode & SPI_3WIRE)) { >

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-05-25 Thread Andrey Grodzovsky
Ping on the question bellow Andrey On 5/20/20 10:50 AM, Andrey Grodzovsky wrote: On 5/20/20 8:46 AM, Daniel Vetter wrote: On Wed, May 20, 2020 at 02:19:08PM +0300, Pekka Paalanen wrote: On Tue, 19 May 2020 10:37:12 -0400 Andrey Grodzovsky wrote: Thanks for the summary, does put things in

Re: [PATCH v1 0/2] drm: update drm_vblank logging

2020-05-25 Thread Thomas Zimmermann
Hi Sam Am 23.05.20 um 09:12 schrieb Sam Ravnborg: > Replace all logging functions in vblank with their drm_ counterparts. > As cocinelle and I are not yet good friends this was a pure mechanical > replacement. > > It adds more lines because the added argument required some more lines > to be

Re: [PATCH 05/21] drm/atmel-hlcdc: Use GEM CMA object functions

2020-05-25 Thread Thomas Zimmermann
Hi Am 22.05.20 um 20:08 schrieb Sam Ravnborg: > Hi Thomas. > > On Fri, May 22, 2020 at 03:52:30PM +0200, Thomas Zimmermann wrote: >> The atmel-hlcdc driver uses the default implementation for CMA functions. The >> DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. >> All

Re: MIPI DSI, DBI, and tinydrm drivers

2020-05-25 Thread Noralf Trønnes
Den 24.05.2020 20.35, skrev Daniel Vetter: > On Sun, May 24, 2020 at 7:46 PM Noralf Trønnes wrote: >> >> >> >> Den 24.05.2020 18.13, skrev Paul Cercueil: >>> Hi list, >>> >>> I'd like to open a discussion about the current support of MIPI DSI and >>> DBI panels. >>> >>> Both are standards from

Re: [PATCH v2] drm/fourcc: Add bayer formats and modifiers

2020-05-25 Thread Sakari Ailus
Hi Niklas, Thank you for the update. On Fri, May 22, 2020 at 01:52:01AM +0200, Niklas Söderlund wrote: > Bayer formats are used with cameras and contain green, red and blue > components, with alternating lines of red and green, and blue and green > pixels in different orders. For each block of

Re: [PATCH v5 10/13] soc: mediatek: cmdq: export finalize function

2020-05-25 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年5月25日 週一 下午4:38寫道: > > > > On 25/05/2020 02:23, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > Matthias Brugger 於 2020年5月17日 週日 上午2:22寫道: > >> > >> > >> > >> On 08/03/2020 11:52, Dennis YC Hsieh wrote: > >>> Export finalize function to client which helps

Re: [PATCH v2 01/16] video: amba-clcd: use devm_of_find_backlight

2020-05-25 Thread Sam Ravnborg
Hi Linus. > For this driver (drivers/video/fbdev/amba-clcd.c) there are zero > users after the merge window (all users moved over to DRM) so > I plan to retire it completely. Sounds like a brilliant plan. Sam ___ dri-devel mailing list

[Bug 201957] amdgpu: ring gfx timeout

2020-05-25 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 udo (udo...@xs4all.nl) changed: What|Removed |Added CC||udo...@xs4all.nl --- Comment

Re: [PATCH 12/21] drm/mcde: Use GEM CMA object functions

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 2:51 PM Thomas Zimmermann wrote: > Am 25.05.20 um 13:36 schrieb Linus Walleij: > > On Fri, May 22, 2020 at 3:52 PM Thomas Zimmermann > > wrote: > > > >> The mcde driver uses the default implementation for CMA functions. The > >> DRM_GEM_CMA_DRIVER_OPS macro now sets

Re: [PATCH 12/21] drm/mcde: Use GEM CMA object functions

2020-05-25 Thread Thomas Zimmermann
Hi Am 25.05.20 um 15:08 schrieb Linus Walleij: > On Mon, May 25, 2020 at 2:51 PM Thomas Zimmermann wrote: >> Am 25.05.20 um 13:36 schrieb Linus Walleij: >>> On Fri, May 22, 2020 at 3:52 PM Thomas Zimmermann >>> wrote: >>> The mcde driver uses the default implementation for CMA functions.

Re: [PATCH v2] drm: add docs for standard CRTC properties

2020-05-25 Thread Pekka Paalanen
On Thu, 21 May 2020 11:09:31 + Simon Ser wrote: > This patch adds docs for the ACTIVE and MODE_ID CRTC properties. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Ville Syrjala > Cc: Pekka Paalanen > Cc: Michel Dänzer > Cc: Daniel Stone > --- > > Thanks for the review Daniel!

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-05-25 Thread Pekka Paalanen
On Mon, 25 May 2020 16:28:04 +0200 Daniel Vetter wrote: > On Wed, May 20, 2020 at 10:50:41AM -0400, Andrey Grodzovsky wrote: > > > > On 5/20/20 8:46 AM, Daniel Vetter wrote: > > > On Wed, May 20, 2020 at 02:19:08PM +0300, Pekka Paalanen wrote: > > > > On Tue, 19 May 2020 10:37:12 -0400 > >

Re: [PATCH] drm: fix setting of plane_mask in pan_display_atomic() function for linux-4.4

2020-05-25 Thread Ville Syrjälä
On Mon, May 25, 2020 at 04:34:28PM +0200, Daniel Vetter wrote: > On Sat, May 23, 2020 at 11:49:07AM +0800, chenxb_99...@126.com wrote: > > From: Xuebing Chen > > > > The provides drm_for_each_plane_mask macro and > > plane_mask is defined as bitmask of plane indices, such as > > 1< > in

Re: [RFC 02/17] dma-fence: basic lockdep annotations

2020-05-25 Thread Daniel Vetter
On Tue, May 12, 2020 at 11:04 AM Chris Wilson wrote: > > Quoting Daniel Vetter (2020-05-12 09:59:29) > > Design is similar to the lockdep annotations for workers, but with > > some twists: > > > > - We use a read-lock for the execution/worker/completion side, so that > > this explicit

Re: [PATCH v2] drm/doc: device hot-unplug for userspace

2020-05-25 Thread Daniel Vetter
On Mon, May 25, 2020 at 09:51:30AM -0400, Andrey Grodzovsky wrote: > On 5/25/20 8:46 AM, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > Set up the expectations on how hot-unplugging a DRM device should look like > > to > > userspace. > > > > Written by Daniel Vetter's request and

Re: Adaptive Sync enabling in Xorg Modesetting driver

2020-05-25 Thread uday kiran pichika
Hi Daniel, We are trying to enable this feature in the Modesetting driver based on AMD DDX driver as a reference. Do you have any pointers to make this work ? Thanks Uday Kiran On Mon, May 25, 2020 at 8:45 PM Daniel Vetter wrote: > On Mon, May 25, 2020 at 07:01:21PM +0530, uday kiran pichika

Re: [PATCH 07/21] drm/hisilicon/kirin: Use GEM CMA object functions

2020-05-25 Thread Thomas Zimmermann
Hi Emil Am 22.05.20 um 20:11 schrieb Emil Velikov: > Hi Thomas, > > On Fri, 22 May 2020 at 14:53, Thomas Zimmermann wrote: >> >> The kirin driver uses the default implementation for CMA functions; except >> for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets >> these

Re: [PATCH 12/21] drm/mcde: Use GEM CMA object functions

2020-05-25 Thread Thomas Zimmermann
Hi Am 25.05.20 um 13:36 schrieb Linus Walleij: > On Fri, May 22, 2020 at 3:52 PM Thomas Zimmermann wrote: > >> The mcde driver uses the default implementation for CMA functions. The >> DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. >> All remaining operations are

Adaptive Sync enabling in Xorg Modesetting driver

2020-05-25 Thread uday kiran pichika
Hello, Am working on enabling the Adaptive sync feature as part of the Xorg/Modesetting DDX driver by taking the reference of AMD DDX Driver (xf86-video-amdgpu). Below is the commit which i submitted. https://gitlab.freedesktop.org/pichika/xserver/-/commit/682565a645bda7371cc3731ee805cc4a0ace80db

Re: Adaptive Sync enabling in Xorg Modesetting driver

2020-05-25 Thread Daniel Vetter
On Mon, May 25, 2020 at 07:01:21PM +0530, uday kiran pichika wrote: > Hello, > > Am working on enabling the Adaptive sync feature as part of the > Xorg/Modesetting DDX driver by taking the reference of AMD DDX Driver > (xf86-video-amdgpu). Below is the commit which i submitted. >

Re: [PATCH v5 6/8] drm/panel: Add ilitek ili9341 panel driver

2020-05-25 Thread Linus Walleij
On Mon, May 25, 2020 at 5:46 AM wrote: > From: dillon min > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > with mipi_dpi_interface driver, can support ili9341 with serial > mode or parallel rgb interface mode by register configuration. > > Changes since V3: > >

Re: [PATCH 15/21] drm/rcar-du: Use GEM CMA object functions

2020-05-25 Thread Thomas Zimmermann
Hi Am 22.05.20 um 22:12 schrieb Laurent Pinchart: > Hi Thomas, > > Thank you for the patch. > > On Fri, May 22, 2020 at 03:52:40PM +0200, Thomas Zimmermann wrote: >> The rcar-du driver uses the default implementation for CMA functions; >> except for the .dumb_create callback. The

Re: [PATCH v2] drm/doc: device hot-unplug for userspace

2020-05-25 Thread Andrey Grodzovsky
On 5/25/20 8:46 AM, Pekka Paalanen wrote: From: Pekka Paalanen Set up the expectations on how hot-unplugging a DRM device should look like to userspace. Written by Daniel Vetter's request and largely based on his comments in IRC and from

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-05-25 Thread Daniel Vetter
On Wed, May 20, 2020 at 10:50:41AM -0400, Andrey Grodzovsky wrote: > > On 5/20/20 8:46 AM, Daniel Vetter wrote: > > On Wed, May 20, 2020 at 02:19:08PM +0300, Pekka Paalanen wrote: > > > On Tue, 19 May 2020 10:37:12 -0400 > > > Andrey Grodzovsky wrote: > > > > > > > Thanks for the summary, does

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-05-25 Thread Daniel Vetter
On Fri, May 22, 2020 at 12:54:32PM +0300, Pekka Paalanen wrote: > On Wed, 20 May 2020 16:19:00 +0200 > Daniel Vetter wrote: > > > On Wed, May 20, 2020 at 3:20 PM Simon Ser wrote: > > > > > > On Wednesday, May 20, 2020 2:55 PM, Daniel Vetter wrote: > > > > > > > Maybe we should add an

Re: MIPI DSI, DBI, and tinydrm drivers

2020-05-25 Thread Neil Armstrong
Hi, On 24/05/2020 21:50, Paul Cercueil wrote: > Hi Daniel, > > Le dim. 24 mai 2020 à 20:35, Daniel Vetter a écrit : >> On Sun, May 24, 2020 at 7:46 PM Noralf Trønnes wrote: >>> >>> >>> >>>  Den 24.05.2020 18.13, skrev Paul Cercueil: >>>  > Hi list, >>>  > >>>  > I'd like to open a discussion

Re: Adaptive Sync enabling in Xorg Modesetting driver

2020-05-25 Thread uday kiran pichika
Thanks Michel.. sorry if my description is not clear. Yes I have used with glxgears in fullscreen mode and also a simple glxapp which actually opens in fullscreen by default. In both the cases, the issue is same. Just wanted to know if AMD has done anything different apart from the

Re: [RESEND PATCH] drm/vc4: hdmi: Silence pixel clock error on -EPROBE_DEFER

2020-05-25 Thread Daniel Vetter
On Sun, May 24, 2020 at 07:28:59PM -0600, James Hilliard wrote: > If the vc4 hdmi driver loads before the pixel clock is available we > see a spurious "*ERROR* Failed to get pixel clock" error. > > Signed-off-by: James Hilliard > --- > no response in over 2 weeks Thanks for poking again, not

Re: Adaptive Sync enabling in Xorg Modesetting driver

2020-05-25 Thread Simon Ser
On Monday, May 25, 2020 5:15 PM, Daniel Vetter wrote: > On Mon, May 25, 2020 at 07:01:21PM +0530, uday kiran pichika wrote: > > > Hello, > > Am working on enabling the Adaptive sync feature as part of the > > Xorg/Modesetting DDX driver by taking the reference of AMD DDX Driver > >

Re: [PATCH] drm/vkms: Don't warn hrtimer_forward_now failure.

2020-05-25 Thread Daniel Vetter
On Mon, May 25, 2020 at 11:38:49PM +0900, Tetsuo Handa wrote: > Commit 3a0709928b172a41 ("drm/vkms: Add vblank events simulated by > hrtimers") introduced ret_overrun variable. And that variable was an > unused-but-set-variable until commit 09ef09b4ab95dc40 ("drm/vkms: > WARN when

[PATCH v2] drm/doc: device hot-unplug for userspace

2020-05-25 Thread Pekka Paalanen
From: Pekka Paalanen Set up the expectations on how hot-unplugging a DRM device should look like to userspace. Written by Daniel Vetter's request and largely based on his comments in IRC and from https://lists.freedesktop.org/archives/dri-devel/2020-May/265484.html . Signed-off-by: Pekka

  1   2   >