[PULL] nouveau-fixes 5.8

2020-06-01 Thread Ben Skeggs
Just two fixes here, one for HDMI2 modesetting failures, another for a race with the audio driver. Thanks, Ben. The following changes since commit dc455f4c888365595c0a13da445e092422d55b8d: drm/nouveau/dispnv50: fix runtime pm imbalance on error (2020-05-22 11:13:53 +1000) are available in

Re: [RFC PATCH v5 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-06-01 Thread Sylwester Nawrocki
Cc: Rob, devicetree ML On 29.05.2020 18:31, Sylwester Nawrocki wrote: > Add documentation for new optional properties in the exynos bus nodes: > samsung,interconnect-parent, #interconnect-cells. > These properties allow to specify the SoC interconnect structure which > then allows the

Re: [Linux-stm32] [PATCH v8 08/10] drm: stm: dw-mipi-dsi: let the bridge handle the HW version check

2020-06-01 Thread Adrian Ratiu
On Fri, 29 May 2020, Philippe CORNU wrote: Hi Adrian, and thank you very much for the patchset. Thank you also for having tested it on STM32F769 and STM32MP1. Sorry for the late response, Yannick and I will review it as soon as possible and we will keep you posted. Note: Do not hesitate to

Re: [RFC PATCH v5 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-06-01 Thread Sylwester Nawrocki
Hi Chanwoo, On 31.05.2020 02:01, Chanwoo Choi wrote: > On Sat, May 30, 2020 at 1:32 AM Sylwester Nawrocki > wrote: >> >> Add documentation for new optional properties in the exynos bus nodes: >> samsung,interconnect-parent, #interconnect-cells. >> These properties allow to specify the SoC

[PATCH 3/7] drm: bridge: cadence: initial support for MHDP DP bridge driver

2020-06-01 Thread sandor . yu
From: Sandor Yu This adds initial support for MHDP DP bridge driver. Basic DP functions are supported, that include: -Video mode set on-the-fly -Cable hotplug detect -MAX support resolution to 3096x2160@60fps -Support DP audio -EDID read via AUX Signed-off-by: Sandor Yu ---

[PATCH 2/7] drm: bridge: cadence: Create cadence fold

2020-06-01 Thread sandor . yu
From: Sandor Yu Create new directory drm/bridge/cadence. Cadence MHDP DP and HDMI bridge dirver will added later. drm/rockchip/cdn-dp-reg.c will separate to three files. - cdns-mhdp-common.c: Provide basic MHDP register read/write via mailbox. public firmware load, event, edid and HPD

[PATCH 6/7] drm: imx: mhdp: Initial support for i.MX8MQ MHDP HDMI

2020-06-01 Thread sandor . yu
From: Sandor Yu Add initial support for i.MX8MQ MHDP HDMI. Add MHDP HDMI PHY configuration. The features are same as mhdp hdmi bridge driver. Signed-off-by: Sandor Yu --- drivers/gpu/drm/imx/mhdp/Kconfig | 5 +- drivers/gpu/drm/imx/mhdp/Makefile | 2 +-

[PATCH 1/7] drm/rockchip: prepare common code for cdns and rk dpi/dp driver

2020-06-01 Thread sandor . yu
From: Sandor Yu - Extracted common fields from cdn_dp_device to a new cdns_mhdp_device structure which will be used by two separate drivers later on. - Moved some datatypes (audio_format, audio_info, vic_pxl_encoding_format, video_info) from cdn-dp-core.c to cdn-dp-reg.h. - Changed prefixes

[PATCH 5/7] drm: bridge: cadence: Initial support for MHDP HDMI bridge driver

2020-06-01 Thread sandor . yu
From: Sandor Yu This adds initial support for cadence MHDP HDMI bridge driver. Basic HDMI functions are supported, that include: -Video mode set on-the-fly -Cable hotplug detect -MAX support resolution to 3096x2160@60fps -HDMI audio -AV infoframe -EDID read -SCDC read Signed-off-by:

[PATCH 7/7] dt-bindings: display: Document Cadence MHDP HDMI/DP bindings

2020-06-01 Thread sandor . yu
From: Sandor Yu Document the bindings used for the Cadence MHDP HDMI/DP bridge. Signed-off-by: Sandor Yu --- .../bindings/display/bridge/cdns,mhdp.yaml| 46 +++ .../devicetree/bindings/display/imx/mhdp.yaml | 59 +++ 2 files changed, 105 insertions(+) create

[PATCH 4/7] drm: imx: mhdp: initial support for i.MX8MQ MHDP Displayport

2020-06-01 Thread sandor . yu
From: Sandor Yu Initial support for i.MX8MQ MHDP Displayport. Add MHDP DP PHY configutation. The features are same as MHDP DP bridge driver. Signed-off-by: Sandor Yu --- drivers/gpu/drm/imx/Kconfig | 1 + drivers/gpu/drm/imx/Makefile| 1 +

[PATCH 0/7] Initial support for Cadence MHDP(HDMI/DP)

2020-06-01 Thread sandor . yu
From: Sandor Yu The patch set initial support for Cadence MHDP(HDMI/DP) drm bridge driver and iMX8MQ HDMI/DP. The first patch drm/rockchip: prepare common code for cdns and rk dpi/dp driver is from the link https://patchwork.kernel.org/patch/10788309/ that still in reviewing. Files in

[PATCH v1 5/6] dt-bindings: panel: add LOGIC Technologies panels

2020-06-01 Thread Sam Ravnborg
Add support for the following panels from LOGIC Technologies, Inc: - LTTD800480070-L2RT - LTTD800480070-L6WH-RT The LTTD800480 L2RT is discontinued, but it may be used in existing products. Both panels are dumb panels that matches the panel-simple binding. Signed-off-by: Sam Ravnborg Cc: Søren

Re: [PATCH v3] drm/exynos: Remove dev_err() on platform_get_irq() failure

2020-06-01 Thread Inki Dae
20. 5. 21. 오후 11:22에 Tamseel Shams 이(가) 쓴 글: > platform_get_irq() will call dev_err() itself on failure, > so there is no need for the driver to also do this. > This is detected by coccinelle. Picked it up. Thanks, Inki Dae > > Signed-off-by: Tamseel Shams > --- > - Changes since v2: > *

Re: [PATCH] drm/exynos: Properly propagate return value in drm_iommu_attach_device()

2020-06-01 Thread Inki Dae
20. 5. 22. 오후 3:03에 Marek Szyprowski 이(가) 쓴 글: > Propagate the proper error codes from the called functions instead of > unconditionally returning 0. > Picked it up. Thanks, Inki Dae > Reported-by: kbuild test robot > Signed-off-by: Marek Szyprowski > --- >

Re: [RFC PATCH v5 0/6] Exynos: Simple QoS for exynos-bus using interconnect

2020-06-01 Thread Sylwester Nawrocki
Cc: Rob, devicetree ML On 29.05.2020 18:31, Sylwester Nawrocki wrote: > This patchset adds interconnect API support for the Exynos SoC "samsung, > exynos-bus" compatible devices, which already have their corresponding > exynos-bus driver in the devfreq subsystem. Complementing the devfreq

[PATCH v1 4/6] drm: panel-simple: add Hitachi 3.5" QVGA panel

2020-06-01 Thread Sam Ravnborg
This panel is used on evaluation boards for Atmel at91sam9261 and at91sam6263. Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-simple.c | 29 1 file changed, 29 insertions(+) diff --git

[PATCH v1 2/6] drm: panel-simple: add Seiko 70WVW2T 7" simple panel

2020-06-01 Thread Sam Ravnborg
The Seiko 70WVW2T is a discontinued product, but may be used somewhere. Tested on a proprietary product. Signed-off-by: Sam Ravnborg Cc: Søren Andersen Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-simple.c | 28 1 file changed, 28

[PATCH v1 0/6] drm: add a few simple panels

2020-06-01 Thread Sam Ravnborg
Push a few patches that has been sitting in my tree for far too long time. Adds a few more panels to panel-simple, including documentation of the compatible. I have added the last few people that added new panels to panel-simple to the cc list, in the hope to speed up the review process a little.

[PATCH v1 1/6] dt-bindings: panel: add Seiko 70WVW2T 7" panel

2020-06-01 Thread Sam Ravnborg
Add compatible for Seiko Instruments 7" TFT LCD. This panel is a dumb panel that matches the panel-simple binding. Signed-off-by: Sam Ravnborg Cc: Søren Andersen Cc: Thierry Reding Cc: Sam Ravnborg --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2

[PATCH v1 6/6] drm: panel-simple: add LOGIC Technologies panels

2020-06-01 Thread Sam Ravnborg
Add support for the following panels from LOGIC Technologies, Inc: - LTTD800480070-L2RT - LTTD800480070-L6WH-RT The LTTD800480 L2RT is discontinued, but it may be used by existing products. Signed-off-by: Søren Andersen Signed-off-by: Sam Ravnborg Cc: Søren Andersen Cc: Thierry Reding Cc:

[PATCH v1 3/6] dt-bindings: panel: add Hitachi 3,5" QVGA panel

2020-06-01 Thread Sam Ravnborg
This panel is used on evaluation boards for Atmel at91sam9261 and at91sam6263. The panel is named: TX09D71VM1CCA The panel is a dumb panel that matches the panel-simple binding Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam Ravnborg ---

Re: [RFC PATCH v5 3/6] PM / devfreq: exynos-bus: Add registration of interconnect child device

2020-06-01 Thread Sylwester Nawrocki
Cc: Rob, devicetree ML On 31.05.2020 01:57, Chanwoo Choi wrote: > On Sat, May 30, 2020 at 1:33 AM Sylwester Nawrocki > wrote: >> >> This patch adds registration of a child platform device for the exynos >> interconnect driver. It is assumed that the interconnect provider will >> only be needed

Re: Dynamically change enumeration list of DRM enumeration property

2020-06-01 Thread Pekka Paalanen
On Mon, 1 Jun 2020 09:22:27 +0530 Yogish Kulkarni wrote: > Hi, > > For letting DRM clients to select output encoding: > Sink can support certain display timings with high output bit-depths using > multiple output encodings, e.g. sink can support a particular timing with > RGB 10-bit, YCbCr422

Re: [RFC PATCH v5 2/6] interconnect: Add generic interconnect driver for Exynos SoCs

2020-06-01 Thread Sylwester Nawrocki
Cc: Rob, devicetree ML On 31.05.2020 02:13, Chanwoo Choi wrote: > On Sat, May 30, 2020 at 1:34 AM Sylwester Nawrocki > wrote: >> >> This patch adds a generic interconnect driver for Exynos SoCs in order >> to provide interconnect functionality for each "samsung,exynos-bus" >> compatible device.

Re: next-20200515: Xorg killed due to "OOM"

2020-06-01 Thread Michal Hocko
On Sun 31-05-20 14:16:01, Pavel Machek wrote: > On Thu 2020-05-28 14:07:50, Michal Hocko wrote: > > On Thu 28-05-20 14:03:54, Pavel Machek wrote: > > > On Thu 2020-05-28 11:05:17, Michal Hocko wrote: > > > > On Tue 26-05-20 11:10:54, Pavel Machek wrote: > > > > [...] > > > > > [38617.276517]

[PATCH v3 12/13] backlight: as3711_bl: introduce backlight_is_blank()

2020-06-01 Thread Sam Ravnborg
Replaces the open-coded checks of the state, with the backlight_is_blank() helper. This increases readability of the code and aling the functionality across the drivers. Futhermore drop the debug prints in update_status(). If we need debug printing then we can add it to the backlight core.

[PATCH v3 03/13] backlight: improve backlight_ops documentation

2020-06-01 Thread Sam Ravnborg
Improve the documentation for backlight_ops and adapt it to kernel-doc style. v2: - Add intro for each field (Daniel) Signed-off-by: Sam Ravnborg Reviewed-by: Daniel Thompson Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 59

[PATCH v3 08/13] backlight: remove the unused backlight_bl driver

2020-06-01 Thread Sam Ravnborg
The backlight_bl driver required initialization using struct generic_bl_info. As there are no more references to this struct there is no users left. So it is safe to delete the driver. Signed-off-by: Sam Ravnborg Reviewed-by: Daniel Thompson Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han

[PATCH v3 10/13] backlight: add overview and update existing doc

2020-06-01 Thread Sam Ravnborg
Add overview chapter to backlight.c. Update existing kernel-doc to follow a more consistent style and drop kernel-doc for deprecated functions. v2: - Sevaral editorial corrections that makes reading much easier (Daniel) - Spelling fixes (Daniel) - updated intro chapter with a little

[PATCH v3 06/13] backlight: document inline functions in backlight.h

2020-06-01 Thread Sam Ravnborg
Add documentation for the inline functions in backlight.h v2: - Fix spelling (Daniel) Signed-off-by: Sam Ravnborg Reviewed-by: Daniel Thompson Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 16 1 file changed, 16 insertions(+) diff --git

[PATCH v3 01/13] backlight: refactor fb_notifier_callback()

2020-06-01 Thread Sam Ravnborg
Increase readability of fb_notifier_callback() by removing a few indent levels. No functional change. Signed-off-by: Sam Ravnborg Reviewed-by: Daniel Thompson Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 43 +++-- 1 file

[PATCH v3 13/13] backlight: use backlight_is_blank() in all backlight drivers

2020-06-01 Thread Sam Ravnborg
Replaces the open-coded checks of the state etc., with the backlight_is_blank() helper. This increases readability of the code and align the functionality across the drivers. v3: - Dropped as3711_bl, it will be modified in another patch v2: - Fixed so changelog is readable Signed-off-by:

[PATCH v3 02/13] backlight: add backlight_is_blank()

2020-06-01 Thread Sam Ravnborg
The backlight support has two properties that express the state: - power - state It is un-documented and easy to get wrong. Add backlight_is_blank() helper to make it simpler for drivers to get the check of the state correct. A lot of drivers also includes checks for fb_blank. This check is

[PATCH v3 0/16] backlight updates

2020-06-01 Thread Sam Ravnborg
v3: - Dropped video patch that was reviewd and thus applied - Updated kernel-doc so all fields now have a short intro - Improved readability in a lot of places, thanks to review feedback from Daniel - thanks! - Added better intro to backlight - Added acks Several other smaller changes

[PATCH v3 05/13] backlight: improve backlight_device documentation

2020-06-01 Thread Sam Ravnborg
Improve the documentation for backlight_device and adapt it to kernel-doc style. v2: - Add short intro to all fields (Daniel) - Updated description of update_lock (Daniel) Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 72

[PATCH v3 04/13] backlight: improve backlight_properties documentation

2020-06-01 Thread Sam Ravnborg
Improve the documentation for backlight_properties and adapt it to kernel-doc style. v2: - Added into for each field (Daniel) - Re-written some parts to explain what to do, rather than what not to do. Partly based on suggestions from the review (Daniel) Signed-off-by: Sam Ravnborg

[PATCH v3 07/13] backlight: document enums in backlight.h

2020-06-01 Thread Sam Ravnborg
Add kernel-doc documentation for the backlight enums v2: - Add intro to each enum member (Daniel) Except backlight type as line lenght was too long. The generated HTML is the same. Signed-off-by: Sam Ravnborg Reviewed-by: Daniel Thompson Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo

[PATCH v3 11/13] backlight: wire up kernel-doc documentation

2020-06-01 Thread Sam Ravnborg
Include backlight so the documentation is now generated with make htmldocs and friends. Signed-off-by: Sam Ravnborg Reviewed-by: Daniel Thompson Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Jonathan Corbet ---

[PATCH v3 09/13] backlight: drop extern from prototypes

2020-06-01 Thread Sam Ravnborg
No need to put "extern" in front of prototypes. While touching the prototypes adjust indent to follow the kernel style. Signed-off-by: Sam Ravnborg Reviewed-by: Daniel Thompson Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 35

[PATCH] Revert "drm/msm/dpu: add support for clk and bw scaling for display"

2020-06-01 Thread Rob Clark
From: Rob Clark This is causing multiple armv7 missing do_div() errors, so lets drop it for now. This reverts commit 04d9044f6c577948609c03b4e33b8fbc8b87c4b1. Cc: Kalyan Thota Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 106 +++---

Re: inux-next: build failure after merge of the drm-msm tree

2020-06-01 Thread Dave Airlie
On Tue, 2 Jun 2020 at 08:15, Stephen Rothwell wrote: > > Hi Dave, > > On Fri, 29 May 2020 14:10:56 +1000 Stephen Rothwell > wrote: > > > > On Tue, 26 May 2020 14:08:41 +1000 Stephen Rothwell > > wrote: > > > > > > On Tue, 19 May 2020 15:09:55 +1000 Stephen Rothwell > > > wrote: > > > > > >

Re: [PATCH v3 4/6] drm: Add Generic USB Display driver

2020-06-01 Thread Alan Stern
On Tue, Jun 02, 2020 at 12:12:07AM +, Peter Stuge wrote: ... > The way I read composite_setup() after try_fun_setup: it calls f->setup() > when available, and that can return < 0 to stall. > > I expect that composite_setup() and thus f->setup() run when the > SETUP packet has arrived, thus

[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-06-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 yao...@protonmail.com changed: What|Removed |Added CC||yao...@protonmail.com ---

[Bug 208011] [amdgpu][Navi10} Kernel crashes during SteamVR

2020-06-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208011 --- Comment #2 from farmb...@googlemail.com --- I am on Mesa 20.1.0. -- You are receiving this mail because: You are watching the assignee of the bug. ___ dri-devel mailing list

Re: [BUG][AMD tahiti xt][amdgpu] broken dpm

2020-06-01 Thread Alex Deucher
On Mon, Jun 1, 2020 at 7:49 AM wrote: > > Hi, > > updated my amd-staging-drm-next branch yesterday: the GPU fans do not reduce > their rpm anymore. I checked the kernel log (attached) and I noticed: > > [drm:0xa036d50d] *ERROR* si_set_sw_state failed > > Is the fix already known or shall

[Bug 208011] [amdgpu][Navi10} Kernel crashes during SteamVR

2020-06-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208011 --- Comment #3 from Alex Deucher (alexdeuc...@gmail.com) --- Probably best to file a mesa issue. The kernel driver is just the bearer of bad news. https://gitlab.freedesktop.org/groups/mesa/-/issues -- You are receiving this mail because: You

[Bug 208011] [amdgpu][Navi10} Kernel crashes during SteamVR

2020-06-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208011 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: Current drm-tip doesn’t build with gcc10 - error in amdgpu_amdkfd_gpuvm.c

2020-06-01 Thread Alex Deucher
On Sun, May 31, 2020 at 9:46 AM Yurii Kolesnykov wrote: > > Originally reported by jghodd[1] in linux-drm-tip-git AUR package [2], also > reported on drm/amd on Freedesktop GitLab [3]. > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: In function > ‘amdgpu_amdkfd_gpuvm_free_memory_of_gpu’:

[PATCH v3] drm: drm_fourcc: add NV15, Q410, Q401 YUV formats

2020-06-01 Thread Ben Davis
DRM_FORMAT_NV15 is a 2 plane format suitable for linear and 16x16 block-linear memory layouts (DRM_FORMAT_MOD_SAMSUNG_16_16_TILE). The format is similar to P010 with 4:2:0 sub-sampling but has no padding between components. Instead, luminance and chrominance samples are grouped into 4s so that

Re: [PATCH v3 02/13] backlight: add backlight_is_blank()

2020-06-01 Thread Peter Ujfalusi
On 01/06/2020 9.51, Sam Ravnborg wrote: > The backlight support has two properties that express the state: > - power > - state > > It is un-documented and easy to get wrong. > Add backlight_is_blank() helper to make it simpler > for drivers to get the check of the state correct. > > A lot of

Re: [PATCH v3 13/13] backlight: use backlight_is_blank() in all backlight drivers

2020-06-01 Thread Peter Ujfalusi
On 01/06/2020 9.52, Sam Ravnborg wrote: > Replaces the open-coded checks of the state etc., > with the backlight_is_blank() helper. > This increases readability of the code and align > the functionality across the drivers. Reviewed-by: Peter Ujfalusi > v3: > - Dropped as3711_bl, it will be

[PATCH] drm: document how user-space should use link-status

2020-06-01 Thread Simon Ser
Describe what a "BAD" link-status means for user-space and how it should handle it. The logic described has been implemented in igt [1]. [1]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/commit/fbe61f529737191d0920521946a575bd55f00fbe Signed-off-by: Simon Ser Cc: Daniel Vetter Cc:

Re: [PATCH 0/2] video: fbdev: fix error handling, convert to pin_user_pages*()

2020-06-01 Thread Andy Shevchenko
On Mon, Jun 1, 2020 at 8:10 PM John Hubbard wrote: > > On 2020-06-01 03:35, Andy Shevchenko wrote: > > On Mon, Jun 1, 2020 at 1:00 AM John Hubbard wrote: > >> On 2020-05-31 14:11, Andy Shevchenko wrote: > >>> ... > >>> JFYI, we have history.git starting from v0.01. > >>> > >> OK, thanks for

Re: [PATCH 1/3] drm/arm: Kconfig annotate drivers as COMPILE_TEST

2020-06-01 Thread Liviu Dudau
Hi Emil, On Wed, May 20, 2020 at 12:54:17AM +0100, Emil Velikov wrote: > On Mon, 18 May 2020 at 12:10, Liviu Dudau wrote: > > > > On Sun, May 17, 2020 at 08:36:53PM +0100, Emil Velikov wrote: > > > Add the COMPILE_TEST conditional, so that people can at least build test > > > the drivers. > > >

Re: [PATCH 0/2] video: fbdev: fix error handling, convert to pin_user_pages*()

2020-06-01 Thread John Hubbard
On 2020-06-01 10:25, Andy Shevchenko wrote: On Mon, Jun 1, 2020 at 8:10 PM John Hubbard wrote: On 2020-06-01 03:35, Andy Shevchenko wrote: On Mon, Jun 1, 2020 at 1:00 AM John Hubbard wrote: On 2020-05-31 14:11, Andy Shevchenko wrote: ... JFYI, we have history.git starting from

Re: [PATCH v3] drm/fourcc: document modifier uniqueness requirements

2020-06-01 Thread Brian Starkey
Sorry for commenting on the obsolete v1 - that'll teach me for reading my backlog chronologically. On Thu, May 28, 2020 at 02:38:36PM +, Simon Ser wrote: > There have suggestions to bake pitch alignment, address alignement, > contiguous memory or other placement (hidden VRAM, GTT/BAR, etc) >

Re: [PATCH] drm/atomic-helper: reset vblank on crtc reset

2020-06-01 Thread Liviu Dudau
On Wed, May 27, 2020 at 11:53:32AM +0200, Daniel Vetter wrote: > Only when vblanks are supported ofc. > > Some drivers do this already, but most unfortunately missed it. This > opens up bugs after driver load, before the crtc is enabled for the > first time. syzbot spotted this when loading vkms

Re: [PATCH v3 4/6] drm: Add Generic USB Display driver

2020-06-01 Thread Noralf Trønnes
Hi Peter, Den 30.05.2020 00.45, skrev Peter Stuge: > Hi Noralf, > > Noralf Trønnes wrote: >> This adds a generic USB display driver with the intention that it can be >> used with future USB interfaced low end displays/adapters. > > Fun! > > >> The Linux gadget device driver will serve as the

Re: [PATCH 0/2] video: fbdev: fix error handling, convert to pin_user_pages*()

2020-06-01 Thread John Hubbard
On 2020-06-01 03:35, Andy Shevchenko wrote: On Mon, Jun 1, 2020 at 1:00 AM John Hubbard wrote: On 2020-05-31 14:11, Andy Shevchenko wrote: ... JFYI, we have history.git starting from v0.01. OK, thanks for that note. According to that history.git [1], then: drivers/video/pvr2fb.c had

Re: [PATCH v3 13/13] backlight: use backlight_is_blank() in all backlight drivers

2020-06-01 Thread Sam Ravnborg
On Mon, Jun 01, 2020 at 03:28:01PM +0300, Peter Ujfalusi wrote: > > > On 01/06/2020 9.52, Sam Ravnborg wrote: > > Replaces the open-coded checks of the state etc., > > with the backlight_is_blank() helper. > > This increases readability of the code and align > > the functionality across the

Re: [PATCH] video: uvesafb: use true,false for bool variables

2020-06-01 Thread Bartlomiej Zolnierkiewicz
Hi, On 4/22/20 9:18 AM, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/video/fbdev/uvesafb.c:48:12-17: WARNING: Assignment of 0/1 to > bool variable > drivers/video/fbdev/uvesafb.c:1827:3-13: WARNING: Assignment of 0/1 to > bool variable >

[BUG][AMD tahiti xt][amdgpu] broken dpm

2020-06-01 Thread sylvain . bertrand
Hi, updated my amd-staging-drm-next branch yesterday: the GPU fans do not reduce their rpm anymore. I checked the kernel log (attached) and I noticed: [drm:0xa036d50d] *ERROR* si_set_sw_state failed Is the fix already known or shall I start to bisect? (no rebase on linux master: should

[Bug 208011] New: [amdgpu][Navi10} Kernel crashes during SteamVR

2020-06-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208011 Bug ID: 208011 Summary: [amdgpu][Navi10} Kernel crashes during SteamVR Product: Drivers Version: 2.5 Kernel Version: 5.5.18 Hardware: x86-64 OS: Linux Tree:

Re: [PATCH v3] drm/fourcc: document modifier uniqueness requirements

2020-06-01 Thread Neil Armstrong
On 29/05/2020 15:56, Daniel Stone wrote: > Hi Alex, > > On Fri, 29 May 2020 at 14:29, Alex Deucher wrote: >> On Fri, May 29, 2020 at 4:59 AM Simon Ser wrote: >>> OK. In this case I think it's fine to make the DMA-BUF import fail, as >>> we've suggested on IRC. The more-or-less planned fix for

[PATCH] drm/i915/panel: Reduce race window between bl_update_status and bl_enable

2020-06-01 Thread Sean Paul
From: Sean Paul If the backlight is updated while the panel is being enabled, the value from userspace (which is stored in panel->backlight.device->props.brightness) can be replaced by the hardware's minimum level. There's really no good way to tell if this is happening in enable_backlight()

Re: [PATCH v3 05/13] backlight: improve backlight_device documentation

2020-06-01 Thread Daniel Thompson
On Mon, Jun 01, 2020 at 08:51:59AM +0200, Sam Ravnborg wrote: > Improve the documentation for backlight_device and > adapt it to kernel-doc style. > > v2: > - Add short intro to all fields (Daniel) > - Updated description of update_lock (Daniel) I like the update... but it doesn't cover what

Re: [PATCH] drm/fourcc: document modifier uniqueness requirements

2020-06-01 Thread Simon Ser
> > > + * Users see modifiers as opaque tokens they can check for equality and > > > + * intersect. Users musn't need to know to reason about the modifier > > > value > > > + * (i.e. users are not expected to extract information out of the > > > modifier). > > > + * > > Doesn't this conflict

Re: [PATCH v3] drm/fourcc: document modifier uniqueness requirements

2020-06-01 Thread Alex Deucher
On Fri, May 29, 2020 at 11:03 AM Daniel Stone wrote: > > On Fri, 29 May 2020 at 15:36, Alex Deucher wrote: > > On Fri, May 29, 2020 at 10:32 AM Daniel Stone wrote: > > > On Fri, 29 May 2020 at 15:29, Alex Deucher wrote: > > > > Maybe I'm over thinking this. I just don't want to get into a > >

Re: [PATCH v3 10/13] backlight: add overview and update existing doc

2020-06-01 Thread Daniel Thompson
On Mon, Jun 01, 2020 at 08:52:04AM +0200, Sam Ravnborg wrote: > Add overview chapter to backlight.c. > Update existing kernel-doc to follow a more consistent > style and drop kernel-doc for deprecated functions. > > v2: > - Sevaral editorial corrections that makes reading > much easier

Re: [PATCH 0/2] video: fbdev: fix error handling, convert to pin_user_pages*()

2020-06-01 Thread Andy Shevchenko
On Mon, Jun 1, 2020 at 1:00 AM John Hubbard wrote: > On 2020-05-31 14:11, Andy Shevchenko wrote: > > ... > > JFYI, we have history.git starting from v0.01. > > > OK, thanks for that note. According to that history.git [1], > then: drivers/video/pvr2fb.c had get_user_pages_fast() support added

Re: [PATCH v3 12/13] backlight: as3711_bl: introduce backlight_is_blank()

2020-06-01 Thread Daniel Thompson
On Mon, Jun 01, 2020 at 08:52:06AM +0200, Sam Ravnborg wrote: > Replaces the open-coded checks of the state, with the > backlight_is_blank() helper. This increases readability > of the code and aling the functionality across the drivers. > > Futhermore drop the debug prints in update_status(). >

Re: [PATCH] drm/fourcc: document modifier uniqueness requirements

2020-06-01 Thread Brian Starkey
On Wed, May 27, 2020 at 10:55:34AM +0200, Daniel Vetter wrote: > On Wed, May 27, 2020 at 08:52:00AM +, Simon Ser wrote: > > There have suggestions to bake pitch alignment, address alignement, > > contiguous memory or other placement (hidden VRAM, GTT/BAR, etc) > > constraints into modifiers.

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-06-01 Thread Pekka Paalanen
On Thu, 28 May 2020 16:45:45 +0200 Daniel Vetter wrote: > On Thu, May 28, 2020 at 03:27:57PM +0300, Pekka Paalanen wrote: ... > > Hmm. Maybe Wayland compositors should ignore all EGL import failures > > that happen after the wl_buffer has been created (which implies that > > the dmabuf has

Re: [PATCH] video: fbdev: pxafb: Use correct return value for pxafb_probe()

2020-06-01 Thread Bartlomiej Zolnierkiewicz
On 5/25/20 9:11 AM, Tiezhu Yang wrote: > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > to check the return value and return PTR_ERR() if failed. > > Signed-off-by: Tiezhu Yang Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards,

Re: [PATCH] drivers/video: cleanup coding style in video a bit

2020-06-01 Thread Bartlomiej Zolnierkiewicz
On 4/27/20 10:05 AM, Bernard Zhao wrote: > Eliminate the magic numbers, add vender infoframe size macro > like other hdmi modules. > > Signed-off-by: Bernard Zhao Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R

Re: [PATCH v3] console: newport_con: fix an issue about leak related system resources

2020-06-01 Thread Bartlomiej Zolnierkiewicz
On 4/23/20 6:42 PM, Dejin Zheng wrote: > A call of the function do_take_over_console() can fail here. > The corresponding system resources were not released then. > Thus add a call of iounmap() and release_mem_region() > together with the check of a failure predicate. and also > add

Re: [trivial PATCH] video: fbdev: Use IS_BUILTIN

2020-06-01 Thread Bartlomiej Zolnierkiewicz
On 5/5/20 1:29 AM, Joe Perches wrote: > IS_BUILTIN can be use to replace various initializations > like #if CONFIG_ int val = 1; #else int val = 0; #endif > so do so. > > Signed-off-by: Joe Perches Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, --

Re: [PATCH] video: pxafb: Fix the function used to balance a 'dma_alloc_coherent()' call

2020-06-01 Thread Bartlomiej Zolnierkiewicz
On 4/29/20 10:45 AM, Christophe JAILLET wrote: > 'dma_alloc_coherent()' must be balanced by a call to 'dma_free_coherent()' > not 'dma_free_wc()'. > The correct dma_free_ function is already used in the error handling path > of the probe function. > > Fixes: 77e196752bdd ("[ARM] pxafb: allow

Re: [PATCH v1] video: fbdev: sm712fb: fix an issue about iounmap for a wrong address

2020-06-01 Thread Bartlomiej Zolnierkiewicz
On 4/22/20 6:07 PM, Dejin Zheng wrote: > the sfb->fb->screen_base is not save the value get by iounmap() when > the chip id is 0x720. so iounmap() for address sfb->fb->screen_base > is not right. > > Fixes: 1461d6672864854 ("staging: sm7xxfb: merge sm712fb with fbdev") > CC: Andy Shevchenko >

Re: [PATCH] omapfb/dss: fix comparison to bool warning

2020-06-01 Thread Bartlomiej Zolnierkiewicz
On 4/22/20 9:19 AM, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c:461:15-32: WARNING: > Comparison to bool > drivers/video/fbdev/omap2/omapfb/dss/dispc.c:891:5-35: WARNING: > Comparison of 0/1 to bool variable > > Signed-off-by: Jason

Re: [PATCH v3 04/13] backlight: improve backlight_properties documentation

2020-06-01 Thread Daniel Thompson
On Mon, Jun 01, 2020 at 08:51:58AM +0200, Sam Ravnborg wrote: > Improve the documentation for backlight_properties and > adapt it to kernel-doc style. > > v2: > - Added into for each field (Daniel) > - Re-written some parts to explain what to do, rather > than what not to do. > Partly

[PATCH v3] drm/doc: device hot-unplug for userspace

2020-06-01 Thread Pekka Paalanen
From: Pekka Paalanen Set up the expectations on how hot-unplugging a DRM device should look like to userspace. Written by Daniel Vetter's request and largely based on his comments in IRC and from https://lists.freedesktop.org/archives/dri-devel/2020-May/265484.html . A related Wayland protocol

Re: inux-next: build failure after merge of the drm-msm tree

2020-06-01 Thread Stephen Rothwell
Hi Dave, On Fri, 29 May 2020 14:10:56 +1000 Stephen Rothwell wrote: > > On Tue, 26 May 2020 14:08:41 +1000 Stephen Rothwell > wrote: > > > > On Tue, 19 May 2020 15:09:55 +1000 Stephen Rothwell > > wrote: > > > > > > After merging the drm-msm tree, today's linux-next build (arm > > >

Re: [PATCH v1 6/6] drm: panel-simple: add LOGIC Technologies panels

2020-06-01 Thread Doug Anderson
Hi, On Mon, Jun 1, 2020 at 1:33 AM Sam Ravnborg wrote: > > +static const struct drm_display_mode logictechno_lttd800480070_l6wh_rt_mode > = { > + .clock = 33000, > + .hdisplay = 800, > + .hsync_start = 800 + 154, > + .hsync_end = 800 + 154 + 3, > + .htotal = 800 +

Re: [PATCH v1 4/6] drm: panel-simple: add Hitachi 3.5" QVGA panel

2020-06-01 Thread Doug Anderson
Hi, On Mon, Jun 1, 2020 at 1:33 AM Sam Ravnborg wrote: > > This panel is used on evaluation boards for Atmel at91sam9261 and > at91sam6263. > > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-simple.c | 29 >

Re: [PATCH v1 2/6] drm: panel-simple: add Seiko 70WVW2T 7" simple panel

2020-06-01 Thread Doug Anderson
Hi, On Mon, Jun 1, 2020 at 1:33 AM Sam Ravnborg wrote: > > The Seiko 70WVW2T is a discontinued product, but may be used somewhere. > Tested on a proprietary product. > > Signed-off-by: Sam Ravnborg > Cc: Søren Andersen > Cc: Thierry Reding > Cc: Sam Ravnborg > --- >

Re: [PATCH v3 4/6] drm: Add Generic USB Display driver

2020-06-01 Thread Peter Stuge
Hi Noralf, Thanks a lot for going into more detail. Noralf Trønnes wrote: > > Several Linux/DRM internals have "leaked" into the USB protocol - this > > should be avoided if you want device implementations other than your > > gadget, because those internals can change within Linux in the future,

Re: [PATCH v3 4/6] drm: Add Generic USB Display driver

2020-06-01 Thread Peter Stuge
Hi Alan, Alan Stern wrote: > > The way I read composite_setup() after try_fun_setup: it calls f->setup() > > when available, and that can return < 0 to stall. > > > > I expect that composite_setup() and thus f->setup() run when the > > SETUP packet has arrived, thus before the data packet