[PATCH 3/4] drm/etnaviv: show loadavg in debugfs

2020-07-10 Thread Christian Gmeiner
Might be helpful to see the loadavg in debugfs. Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c index

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-07-10 Thread Andrzej Hajda
On 07.07.2020 06:14, Dmitry Torokhov wrote: > On Thu, Jul 02, 2020 at 08:57:55AM +0200, Andrzej Hajda wrote: >> On 30.06.2020 20:00, Dmitry Torokhov wrote: >>> On Tue, Jun 30, 2020 at 8:42 AM Andrzej Hajda wrote: On 30.06.2020 10:59, Grygorii Strashko wrote: > Hi > > On

Re: [PATCH v2] drm/bridge/synopsys: dsi: allow LP commands in video mode

2020-07-10 Thread Philippe CORNU
On 7/8/20 4:08 PM, Yannick Fertre wrote: > From: Antonio Borneo > > Current code only sends LP commands in command mode. > > Allows sending LP commands also in video mode by setting the > proper flag in DSI_VID_MODE_CFG. > > Signed-off-by: Antonio Borneo > --- >

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-07-10 Thread Mark Brown
On Fri, Jul 10, 2020 at 09:42:49AM +0200, Andrzej Hajda wrote: > But the provider does not know if *get is called in probe context or > not, so it is not able to differentiate it. > So the whole idea is for me suspicious/wrong. Kind of proof: > 1. If you insist that provider's EPROBE_ERROR

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #57 from Anthony Ruhier (anthony.ruh...@gmail.com) --- To give some precision about the kernel version range, I'm staying on 5.6.19 for a while, which doesn't have the issue. It's pretty bad though, as it's EOL. Only the 5.7 branch

[Bug 208513] Radeon RX480 graphics freeze with RIP: 0010:amdgpu_dm_atomic_commit_tail+0x273/0x1100 [amdgpu]

2020-07-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208513 --- Comment #1 from Jure Repinc (jlp.b...@gmail.com) --- Created attachment 290205 --> https://bugzilla.kernel.org/attachment.cgi?id=290205=edit dmesg -- You are receiving this mail because: You are watching the assignee of the bug.

[Bug 208513] New: Radeon RX480 graphics freeze with RIP: 0010:amdgpu_dm_atomic_commit_tail+0x273/0x1100 [amdgpu]

2020-07-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208513 Bug ID: 208513 Summary: Radeon RX480 graphics freeze with RIP: 0010:amdgpu_dm_atomic_commit_tail+0x273/0x1100 [amdgpu] Product: Drivers Version: 2.5 Kernel

[PATCH v2 1/2] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-07-10 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu

[PATCH v2] drm/msm: handle for EPROBE_DEFER for of_icc_get

2020-07-10 Thread Jonathan Marek
Check for errors instead of silently not using icc if the msm driver probes before the interconnect driver. Allow ENODATA for ocmem path, as it is optional and this error is returned when "gfx-mem" path is provided but not "ocmem". Remove the WARN_ON in msm_gpu_cleanup because INIT_LIST_HEAD

Re: [PATCH v4 3/7] drm: msm: a6xx: set gpu freq through hfi

2020-07-10 Thread Jonathan Marek
On 7/9/20 4:00 PM, Akhil P Oommen wrote: Newer targets support changing gpu frequency through HFI. So use that wherever supported instead of the legacy method. It was already using HFI on newer targets. Don't break it in one commit then fix it in the next. Signed-off-by: Akhil P Oommen

Re: [PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline

2020-07-10 Thread Jian-Hong Pan
Hi Maxime, Thanks for your version 4 patch again. I took the patches and applied them upon next-20200708. I make system cold reboot to multi-user target and the text console shows on the screen. Then, I simply hot re-plug the HDMI cable on HDMI0 port, I not only lose the text console on the

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-10 Thread Steev Klimaszewski
On 7/9/20 10:17 PM, Steev Klimaszewski wrote: On 7/9/20 10:12 PM, Steev Klimaszewski wrote: On 7/9/20 9:14 PM, Doug Anderson wrote: Hi, On Thu, Jul 9, 2020 at 6:38 PM Doug Anderson wrote: Hi, On Thu, Jul 9, 2020 at 6:19 PM Steev Klimaszewski wrote: Hi Doug, I've been testing 5.8

Re: [PATCH 2/4] drm/etnaviv: add loadavg accounting

2020-07-10 Thread Lucas Stach
Hi Christian, Am Freitag, den 10.07.2020, 09:41 +0200 schrieb Christian Gmeiner: > The GPU has an idle state register where each bit represents the idle > state of a sub-GPU component like FE or TX. Sample this register > every 10ms and calculate a simple moving average over the sub-GPU >

Re: [PATCH] drm/bridge/synopsys: dsi: add support for non-continuous HS clock

2020-07-10 Thread Philippe CORNU
On 7/1/20 9:42 PM, Yannick Fertre wrote: > From: Antonio Borneo > > Current code enables the HS clock when video mode is started or to > send out a HS command, and disables the HS clock to send out a LP > command. This is not what DSI spec specify. > > Enable HS clock either in command and

Re: [PATCH] drm/fb-helper: Fix vt restore

2020-07-10 Thread Thomas Zimmermann
Hi Daniel, this patch might not be enougth. I started Xorg and then did 'kill -9' on the Xorg process. Xorg went away, but the console did not come back. Best regards Thomas Am 23.06.20 um 17:54 schrieb Daniel Vetter: > In the past we had a pile of hacks to orchestrate access between fbdev >

[Bug 208513] Radeon RX480 graphics freeze with RIP: 0010:amdgpu_dm_atomic_commit_tail+0x273/0x1100 [amdgpu]

2020-07-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208513 --- Comment #2 from Jure Repinc (jlp.b...@gmail.com) --- Created attachment 290207 --> https://bugzilla.kernel.org/attachment.cgi?id=290207=edit Xorg.0.log -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH] drm/drm_fb_helper: fix fbdev with sparc64

2020-07-10 Thread Thomas Zimmermann
Hi Am 09.07.20 um 21:30 schrieb Sam Ravnborg: > Mark reported that sparc64 would panic while booting using qemu. > Mark bisected this to a patch that introduced generic fbdev emulation to > the bochs DRM driver. > Mark pointed out that a similar bug was fixed before where > the sys helpers was

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 Stratos Zolotas (str...@gmail.com) changed: What|Removed |Added CC||str...@gmail.com

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #55 from Stratos Zolotas (str...@gmail.com) --- (In reply to Paul Menzel from comment #54) > Thank you for your report. How quickly can you reproduce it? If you could > bisect the issue to pinpoint the culprit commit between 5.7.5

Re: [PATCH 0/4] Add support for GPU load values

2020-07-10 Thread Lucas Stach
Hi Christian, Am Freitag, den 10.07.2020, 09:41 +0200 schrieb Christian Gmeiner: > This patch series add support for loadavg values for GPU > sub-components. I am adding a SMA algorithm as I was not > really sure if EWMA would be a good fit for this use case. 1 second is a pretty long window in

Re: [PATCH 0/4] Add support for GPU load values

2020-07-10 Thread Christian Gmeiner
Hoi Lucas Am Fr., 10. Juli 2020 um 10:31 Uhr schrieb Lucas Stach : > > Hi Christian, > > Am Freitag, den 10.07.2020, 09:41 +0200 schrieb Christian Gmeiner: > > This patch series add support for loadavg values for GPU > > sub-components. I am adding a SMA algorithm as I was not > > really sure if

Re: [PATCH v3 07/14] drm/panfrost: rename error labels in device_init

2020-07-10 Thread Steven Price
On 09/07/2020 15:03, Clément Péron wrote: Rename goto labels in device_init it will be easier to maintain. Reviewed-by: Alyssa Rosenzweig Signed-off-by: Clément Péron Nice clean up, thanks. As you noted this needs rebasing as the "regulator init" message has gone. Reviewed-by: Steven

Re: [PATCH v3 08/14] drm/panfrost: move devfreq_init()/fini() in device

2020-07-10 Thread Steven Price
On 09/07/2020 15:03, Clément Péron wrote: Later we will introduce devfreq probing regulator if they are present. As regulator should be probe only one time we need to get this logic in the device_init(). panfrost_device is already taking care of devfreq_resume() and devfreq_suspend(), so it's

Re: [PATCH] drm/vc4/vc4_hdmi: fill ASoC card owner

2020-07-10 Thread Stefan Wahren
Hi Marek, Am 02.07.20 um 08:58 schrieb Marek Szyprowski: > On 01.07.2020 20:49, Stefan Wahren wrote: >> Am 01.07.20 um 09:39 schrieb Marek Szyprowski: >>> card->owner is a required property and since commit 81033c6b584b ("ALSA: >>> core: Warn on empty module") a warning is issued if it is empty.

Re: fbconsole needs more parameter validations.

2020-07-10 Thread Greg Kroah-Hartman
On Fri, Jul 10, 2020 at 02:56:58PM +0900, Tetsuo Handa wrote: > Hello. > > While trying to debug > https://syzkaller.appspot.com/bug?extid=017265e8553724e514e8 , > I noticed that a crash can happen without opening /dev/ttyXX . > > For example, while a driver which syzbot is reporting accepts

[PATCH 2/4] drm/etnaviv: add loadavg accounting

2020-07-10 Thread Christian Gmeiner
The GPU has an idle state register where each bit represents the idle state of a sub-GPU component like FE or TX. Sample this register every 10ms and calculate a simple moving average over the sub-GPU component idle states with a total observation time frame of 1s. This provides us with a

[PATCH 0/4] Add support for GPU load values

2020-07-10 Thread Christian Gmeiner
This patch series add support for loadavg values for GPU sub-components. I am adding a SMA algorithm as I was not really sure if EWMA would be a good fit for this use case. Christian Gmeiner (4): drm/etnaviv: add simple moving average (SMA) drm/etnaviv: add loadavg accounting drm/etnaviv:

[PATCH 4/4] drm/etnaviv: export loadavg via perfmon

2020-07-10 Thread Christian Gmeiner
Make it possible to access the sub-GPU component load value from user space with the perfmon infrastructure. Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 79 +++ 1 file changed, 79 insertions(+) diff --git

[PATCH 1/4] drm/etnaviv: add simple moving average (SMA)

2020-07-10 Thread Christian Gmeiner
This adds a SMA algorithm inspired by Exponentially weighted moving average (EWMA) algorithm found in the kernel. Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/etnaviv/etnaviv_sma.h | 53 +++ 1 file changed, 53 insertions(+) create mode 100644

Re: [PATCH] drm/bridge/synopsys: dsi: allow sending longer LP commands

2020-07-10 Thread Philippe CORNU
On 7/1/20 4:31 PM, Yannick Fertre wrote: > From: Antonio Borneo > > Current code does not properly computes the max length of LP > commands that can be send during H or V sync, and rely on static > values. > Limiting the max LP length to 4 byte during the V-sync is overly > conservative. > >

Re: KASAN: use-after-free Read in drm_gem_object_release

2020-07-10 Thread Dan Carpenter
On Fri, Jul 10, 2020 at 04:24:03PM +0800, butt3rflyh4ck wrote: > I report a bug (in linux-5.8.0-rc4) found by syzkaller. > > kernel config: > https://github.com/butterflyhack/syzkaller-fuzz/blob/master/v5.8.0-rc4.config > > I test the reproducer and crash too. > > In the drm_em_vram_t()

[PATCH v3 03/14] drm/panfrost: don't use pfdevfreq.busy_count to know if hw is idle

2020-07-10 Thread Clément Péron
This use devfreq variable that will be lock with spinlock in future patches. We should either introduce a function to access this one but as devfreq is optional let's just remove it. Reviewed-by: Steven Price Reviewed-by: Alyssa Rosenzweig Signed-off-by: Clément Péron ---

Re: [PATCH] drm/vc4: dsi: Only register our component once a DSI device is attached

2020-07-10 Thread Maxime Ripard
Hi Eric, On Tue, Jul 07, 2020 at 09:48:45AM -0700, Eric Anholt wrote: > On Tue, Jul 7, 2020 at 3:26 AM Maxime Ripard wrote: > > > > If the DSI driver is the last to probe, component_add will try to run all > > the bind callbacks straight away and return the error code. > > > > However, since we

[PATCH v3 01/14] drm/panfrost: avoid static declaration

2020-07-10 Thread Clément Péron
This declaration can be avoided so change it. Reviewed-by: Steven Price Reviewed-by: Alyssa Rosenzweig Signed-off-by: Clément Péron --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 38 ++--- 1 file changed, 18 insertions(+), 20 deletions(-) diff --git

[PATCH v14 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP

2020-07-10 Thread Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/Kconfig |9 + drivers/gpu/drm/bridge/analogix/Makefile |1 +

Re: [PATCH v4 05/16] pwm: lpss: Use pwm_lpss_apply() when restoring state on resume

2020-07-10 Thread Andy Shevchenko
On Wed, Jul 08, 2020 at 11:14:21PM +0200, Hans de Goede wrote: > Before this commit a suspend + resume of the LPSS PWM controller > would result in the controller being reset to its defaults of > output-freq = clock/256, duty-cycle=100%, until someone changes > to the output-freq and/or duty-cycle

[PATCH v3 08/14] drm/panfrost: move devfreq_init()/fini() in device

2020-07-10 Thread Clément Péron
Later we will introduce devfreq probing regulator if they are present. As regulator should be probe only one time we need to get this logic in the device_init(). panfrost_device is already taking care of devfreq_resume() and devfreq_suspend(), so it's not totally illogic to move the

[PATCH v3 11/14] arm64: defconfig: Enable devfreq cooling device

2020-07-10 Thread Clément Péron
Devfreq cooling device framework is used in Panfrost to throttle GPU in order to regulate its temperature. Enable this driver for ARM64 SoC. Reviewed-by: Alyssa Rosenzweig Signed-off-by: Clément Péron --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v14 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter DT schema

2020-07-10 Thread Xin Ji
anx7625: MIPI to DP transmitter DT schema Signed-off-by: Xin Ji Reviewed-by: Rob Herring --- .../bindings/display/bridge/analogix,anx7625.yaml | 95 ++ 1 file changed, 95 insertions(+) create mode 100644

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-10 Thread Steev Klimaszewski
Hi, On 7/9/20 11:12 PM, Doug Anderson wrote: root@c630:~# bus=$(i2cdetect -l | grep sn65 | sed 's/i2c-\([0-9]*\).*$/\1/') root@c630:~# i2cdump ${bus} 0x50 i > edid WARNING! This program can confuse your I2C bus, cause data loss and worse! I will probe file /dev/i2c-16, address 0x50, mode i2c

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-10 Thread Steev Klimaszewski
On 7/9/20 10:12 PM, Steev Klimaszewski wrote: On 7/9/20 9:14 PM, Doug Anderson wrote: Hi, On Thu, Jul 9, 2020 at 6:38 PM Doug Anderson wrote: Hi, On Thu, Jul 9, 2020 at 6:19 PM Steev Klimaszewski wrote: Hi Doug, I've been testing 5.8 and linux-next on the Lenovo Yoga C630, and with

Re: [PATCH v3 0/6] Generic USB Display driver

2020-07-10 Thread Lubomir Rintel
Hello, On 29 May 2020 Noralf Trønnes wrote: ... > This series adds a USB host driver and a device/gadget driver to achieve > that. > > The reason for calling it 'Generic' is so anyone can make a USB > display/adapter against this driver, all that's needed is to add a USB > vid:pid. I have done a

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-10 Thread Steev Klimaszewski
On 7/9/20 9:14 PM, Doug Anderson wrote: Hi, On Thu, Jul 9, 2020 at 6:38 PM Doug Anderson wrote: Hi, On Thu, Jul 9, 2020 at 6:19 PM Steev Klimaszewski wrote: Hi Doug, I've been testing 5.8 and linux-next on the Lenovo Yoga C630, and with this patch applied, there is really bad banding

[PATCH v3 04/14] drm/panfrost: introduce panfrost_devfreq struct

2020-07-10 Thread Clément Péron
Introduce a proper panfrost_devfreq to deal with devfreq variables. Reviewed-by: Steven Price Reviewed-by: Alyssa Rosenzweig Signed-off-by: Clément Péron --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 76 - drivers/gpu/drm/panfrost/panfrost_devfreq.h | 20 +-

[PATCH v3 14/14] [DO NOT MERGE] arm64: dts: allwinner: force GPU regulator to be always

2020-07-10 Thread Clément Péron
Signed-off-by: Clément Péron --- arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts index 3f7ceeb1a767..14257f7476b8 100644

[PATCH v3 13/14] [DO NOT MERGE] arm64: dts: allwinner: h6: Add GPU OPP table

2020-07-10 Thread Clément Péron
Add an Operating Performance Points table for the GPU to enable Dynamic Voltage & Frequency Scaling on the H6. The voltage range is set with minival voltage set to the target and the maximal voltage set to 1.2V. This allow DVFS framework to work properly on board with fixed regulator.

Re: [PATCH v4 04/16] pwm: lpss: Add range limit check for the base_unit register value

2020-07-10 Thread Andy Shevchenko
On Thu, Jul 09, 2020 at 04:33:50PM +0200, Hans de Goede wrote: > On 7/9/20 4:21 PM, Andy Shevchenko wrote: > > On Thu, Jul 09, 2020 at 03:23:13PM +0200, Hans de Goede wrote: ... > > You can use clamp_val(). > > I did not know about that, that will work nicely I will switch to clamp_val > for

Re: [PATCH v4 06/16] pwm: lpss: Correct get_state result for base_unit == 0

2020-07-10 Thread Andy Shevchenko
On Wed, Jul 08, 2020 at 11:14:22PM +0200, Hans de Goede wrote: > The datasheet specifies that programming the base_unit part of the > ctrl register to 0 results in a contineous low signal. > > Adjust the get_state method to reflect this by setting pwm_state.period > to 1 and duty_cycle to 0. ...

Re: [PATCH 11/20] Documentation: leds/ledtrig-transient: eliminate duplicated word

2020-07-10 Thread Jacek Anaszewski
On 7/7/20 8:04 PM, Randy Dunlap wrote: Drop the doubled word "for". Signed-off-by: Randy Dunlap Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jacek Anaszewski Cc: Pavel Machek Cc: Dan Murphy Cc: linux-l...@vger.kernel.org --- Documentation/leds/ledtrig-transient.rst |2 +- 1

[PATCH] DRM PANEL DRIVERS: Replace HTTP links with HTTPS ones

2020-07-10 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

[PATCH v3 10/14] drm/panfrost: add regulators to devfreq

2020-07-10 Thread Clément Péron
Some OPP tables specify voltage for each frequency. Devfreq can handle these regulators but they should be get only 1 time to avoid issue and know who is in charge. If OPP table is probe don't init regulator. Reviewed-by: Steven Price Reviewed-by: Alyssa Rosenzweig Signed-off-by: Clément Péron

[PATCH] drm/i915/selftests: Fix compare functions provided for sorting

2020-07-10 Thread Sudeep Holla
Both cmp_u32 and cmp_u64 are comparing the pointers instead of the value at those pointers. This will result in incorrect/unsorted list. Fix it by deferencing the pointers before comparison. Cc: Chris Wilson Cc: Mika Kuoppala Signed-off-by: Sudeep Holla ---

[PATCH v3 12/14] arm64: dts: allwinner: h6: Add cooling map for GPU

2020-07-10 Thread Clément Péron
Add a simple cooling map for the GPU. Reviewed-by: Alyssa Rosenzweig Signed-off-by: Clément Péron --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 22 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi

Re: [RFC] Host1x/TegraDRM UAPI (sync points)

2020-07-10 Thread Dmitry Osipenko
08.07.2020 13:06, Mikko Perttunen пишет: > On 7/7/20 2:06 PM, Dmitry Osipenko wrote: >> 02.07.2020 15:10, Mikko Perttunen пишет: >>> Ok, so we would have two kinds of syncpoints for the job; one >>> for kernel job tracking; and one that userspace can >>> manipulate as it wants to. >>> >>> Could we

[PATCH v2 2/2] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-07-10 Thread Enric Balletbo i Serra
Convert mtk_dpi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chun-Kuang Hu --- Changes in v2: - Maintain error message when attach to bridge fails. (Boris)

fbconsole needs more parameter validations.

2020-07-10 Thread Tetsuo Handa
Hello. While trying to debug https://syzkaller.appspot.com/bug?extid=017265e8553724e514e8 , I noticed that a crash can happen without opening /dev/ttyXX . For example, while a driver which syzbot is reporting accepts screen with var.xres = var.yres = 0 (and a crash is not visible until trying

Re: [RESEND PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder

2020-07-10 Thread Enric Balletbo i Serra
Hi again, On 8/7/20 17:12, Enric Balletbo i Serra wrote: > Hi Boris, > > Thank you to spend some time to review the patches. > > On 1/7/20 13:41, Boris Brezillon wrote: >> On Mon, 18 May 2020 19:39:09 +0200 >> Enric Balletbo i Serra wrote: >> >>> The mtk_dpi driver uses an empty implementation

RE: [PATCH v2] drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs

2020-07-10 Thread Angelo Ribeiro
Hi Philippe, From: Philippe CORNU Date: Thu, Jul 09, 2020 at 08:56:10 > > On 7/8/20 7:08 PM, Angelo Ribeiro wrote: > > Hi, > > > > Is this patch good to go? > > @dan...@ffwll.ch, @Philippe CORNU > > > > Was already tested by @Yannick FERTRE > > and @Adrian Pop > > on > >

[PATCH v3 07/14] drm/panfrost: rename error labels in device_init

2020-07-10 Thread Clément Péron
Rename goto labels in device_init it will be easier to maintain. Reviewed-by: Alyssa Rosenzweig Signed-off-by: Clément Péron --- drivers/gpu/drm/panfrost/panfrost_device.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git

[PATCH v3 00/14] Add regulator devfreq support to Panfrost

2020-07-10 Thread Clément Péron
Hi, This serie cleans and adds regulator support to Panfrost devfreq. This is mostly based on comment for the freshly introduced lima devfreq. We need to add regulator support because on Allwinner the GPU OPP table defines both frequencies and voltages. First patches [01-07] should not change

RE: [PATCH 14/20] Documentation: misc/xilinx_sdfec: eliminate duplicated word

2020-07-10 Thread Dragan Cvetic
> -Original Message- > From: Randy Dunlap > Sent: Tuesday 7 July 2020 19:04 > To: linux-ker...@vger.kernel.org > Cc: Randy Dunlap ; Jonathan Corbet ; > linux-...@vger.kernel.org; linux- > m...@vger.kernel.org; Mike Rapoport ; Jens Axboe > ; linux-bl...@vger.kernel.org; Jason > Wessel

[PATCH v3 05/14] drm/panfrost: use spinlock instead of atomic

2020-07-10 Thread Clément Péron
Convert busy_count to a simple int protected by spinlock. Reviewed-by: Steven Price Reviewed-by: Alyssa Rosenzweig Signed-off-by: Clément Péron --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 43 +++-- drivers/gpu/drm/panfrost/panfrost_devfreq.h | 9 - 2 files changed,

Re: [PATCH v4 04/16] pwm: lpss: Add range limit check for the base_unit register value

2020-07-10 Thread Andy Shevchenko
On Wed, Jul 08, 2020 at 11:14:20PM +0200, Hans de Goede wrote: > When the user requests a high enough period ns value, then the > calculations in pwm_lpss_prepare() might result in a base_unit value of 0. > > But according to the data-sheet the way the PWM controller works is that > each input

[PATCH v3 09/14] drm/panfrost: dynamically alloc regulators

2020-07-10 Thread Clément Péron
We will later introduce regulators managed by OPP. Only alloc regulators when it's needed. This also help use to release the regulators only when they are allocated. Reviewed-by: Steven Price Reviewed-by: Alyssa Rosenzweig Signed-off-by: Clément Péron ---

Re: [PATCH v4 04/16] pwm: lpss: Add range limit check for the base_unit register value

2020-07-10 Thread Andy Shevchenko
On Thu, Jul 09, 2020 at 03:23:13PM +0200, Hans de Goede wrote: > On 7/9/20 2:53 PM, Andy Shevchenko wrote: > > On Wed, Jul 08, 2020 at 11:14:20PM +0200, Hans de Goede wrote: > > > When the user requests a high enough period ns value, then the > > > calculations in pwm_lpss_prepare() might result

[PATCH v3 02/14] drm/panfrost: clean headers in devfreq

2020-07-10 Thread Clément Péron
Don't include not required headers and sort them. Reviewed-by: Steven Price Reviewed-by: Alyssa Rosenzweig Signed-off-by: Clément Péron --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

[PATCH v2 0/2] Convert mtk-dpi to drm_bridge API

2020-07-10 Thread Enric Balletbo i Serra
The mtk-dpi driver still uses the drm_encoder API which is now somewhat deprecated. We started to move all the Mediatek drivers to the drm_bridge API, like we did for the mtk-dsi driver [1], this is another small step to be able to fully convert the DRM Mediatek drivers to the drm_bridge API. A

Re: [PATCH v3 00/14] Add regulator devfreq support to Panfrost

2020-07-10 Thread Clément Péron
Hi, On Thu, 9 Jul 2020 at 16:03, Clément Péron wrote: > > Hi, > > This serie cleans and adds regulator support to Panfrost devfreq. > This is mostly based on comment for the freshly introduced lima > devfreq. > > We need to add regulator support because on Allwinner the GPU OPP > table defines

[PATCH v14 0/2] Add initial support for slimport anx7625

2020-07-10 Thread Xin Ji
Hi all, The following series add support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device. This is the v14 version, any mistakes, please let me know, I will fix it in the next series. Change history: v14: Fix comments from

[PATCH v3 06/14] drm/panfrost: properly handle error in probe

2020-07-10 Thread Clément Péron
Introduce a boolean to know if opp table has been added. With this, we can call panfrost_devfreq_fini() in case of error and release what has been initialised. Reviewed-by: Steven Price Reviewed-by: Alyssa Rosenzweig Signed-off-by: Clément Péron ---

Re: [PATCH] efi: avoid error message when booting under Xen

2020-07-10 Thread Bartlomiej Zolnierkiewicz
[ added EFI Maintainer & ML to Cc: ] Hi, On 7/9/20 11:17 AM, Jürgen Groß wrote: > On 28.06.20 10:50, Jürgen Groß wrote: >> Ping? >> >> On 10.06.20 16:10, Juergen Gross wrote: >>> efifb_probe() will issue an error message in case the kernel is booted >>> as Xen dom0 from UEFI as EFI_MEMMAP won't

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 Duncan (1i5t5.dun...@cox.net) changed: What|Removed |Added Kernel Version|5.7-rc1 - 5.7 - 5.8-rc1+|5.7-rc1 - 5.7 - 5.8-rc4+

Re: KASAN: use-after-free Read in drm_gem_object_release

2020-07-10 Thread Greg KH
On Fri, Jul 10, 2020 at 04:24:03PM +0800, butt3rflyh4ck wrote: > I report a bug (in linux-5.8.0-rc4) found by syzkaller. Great! But can you also submit a fix for this as well? We are drowning in syzkaller reports and just throwing them at us doesn't really help anyone here anymore. thanks,

Re: [PATCH 2/4] drm/etnaviv: add loadavg accounting

2020-07-10 Thread Christian Gmeiner
Hoi Lucas, Am Fr., 10. Juli 2020 um 10:19 Uhr schrieb Lucas Stach : > > Hi Christian, > > Am Freitag, den 10.07.2020, 09:41 +0200 schrieb Christian Gmeiner: > > The GPU has an idle state register where each bit represents the idle > > state of a sub-GPU component like FE or TX. Sample this

Re: [PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline

2020-07-10 Thread Stefan Wahren
Hi Maxime, Am 08.07.20 um 19:41 schrieb Maxime Ripard: > Hi everyone, > > Here's a (pretty long) series to introduce support in the VC4 DRM driver > for the display pipeline found in the BCM2711 (and thus the RaspberryPi 4). > > The main differences are that there's two HDMI controllers and that

[PATCH][next] drm/amdgpu: fix spelling mistake "Falied" -> "Failed"

2020-07-10 Thread Colin King
From: Colin Ian King There is a spelling mistake in a DRM_ERROR error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

Re: [PATCH] staging: android: ion: Skip sync if not mapped

2020-07-10 Thread Greg Kroah-Hartman
On Tue, Jul 07, 2020 at 08:43:30PM -0700, John Stultz wrote: > On Fri, Jul 3, 2020 at 12:03 AM Greg Kroah-Hartman > wrote: > > On Tue, Apr 21, 2020 at 10:05:44AM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Apr 20, 2020 at 01:03:39PM -0700, John Stultz wrote: > > > > The dmabuf heaps have been

Re: [PATCH v7 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-07-10 Thread Andrzej Hajda
On 07.07.2020 10:25, Vinay Simha B N wrote: > Andrzej, > > Please suggest. > > In general it should be in the reverse-order RESX then STBY, But > As per the spec Datasheet Power off sequence is this Page 149, Section > Power Supply On and Off Sequence > > regulators > STBY > RESX > >

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #54 from Paul Menzel (pmenzel+bugzilla.kernel@molgen.mpg.de) --- (In reply to Stratos Zolotas from comment #53) > Don't know if it helps. I'm getting a similar issue on Opensuse Tumbleweed > with kernel 5.7.7. Reverting to kernel

Re: [PATCH v7 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-10 Thread Jim Quinlan
Hi Christoph, I'm sending all commits to since most of them are PCI related. I don't send all patches to linux-ker...@vger.kernel.org since I've read it is overused. The --cc list is generated by get_maintainer.pl. IIRC, in a previous discussion you said you preferred NOT to get the entire

Re: [PATCH] drm/fb-helper: Fix vt restore

2020-07-10 Thread Thomas Zimmermann
Hi Am 10.07.20 um 14:38 schrieb Daniel Vetter: > On Fri, Jul 10, 2020 at 1:31 PM Thomas Zimmermann wrote: >> >> Hi Daniel, >> >> this patch might not be enougth. I started Xorg and then did 'kill -9' >> on the Xorg process. Xorg went away, but the console did not come back. > > Hm don't you

Re: [PATCH 0/4] Add support for GPU load values

2020-07-10 Thread Christian Gmeiner
Hi Lucas, Am Fr., 10. Juli 2020 um 10:44 Uhr schrieb Christian Gmeiner : > > Hoi Lucas > > Am Fr., 10. Juli 2020 um 10:31 Uhr schrieb Lucas Stach > : > > > > Hi Christian, > > > > Am Freitag, den 10.07.2020, 09:41 +0200 schrieb Christian Gmeiner: > > > This patch series add support for loadavg

Re: [PATCH] drm/fb-helper: Fix vt restore

2020-07-10 Thread Daniel Vetter
On Fri, Jul 10, 2020 at 1:31 PM Thomas Zimmermann wrote: > > Hi Daniel, > > this patch might not be enougth. I started Xorg and then did 'kill -9' > on the Xorg process. Xorg went away, but the console did not come back. Hm don't you need to reset your terminal to text mode in that case first?

Re: [PATCH] efi: avoid error message when booting under Xen

2020-07-10 Thread Ard Biesheuvel
On Fri, 10 Jul 2020 at 16:38, Jürgen Groß wrote: > > On 10.07.20 15:27, Ard Biesheuvel wrote: > > On Fri, 10 Jul 2020 at 13:17, Bartlomiej Zolnierkiewicz > > wrote: > >> > >> > >> [ added EFI Maintainer & ML to Cc: ] > >> > >> Hi, > >> > >> On 7/9/20 11:17 AM, Jürgen Groß wrote: > >>> On

Re: [PATCH v2 2/2] video: fbdev: amifb: add FIXMEs about {put,get}_user() failures

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 6/2/20 2:03 PM, Geert Uytterhoeven wrote: > On Tue, Jun 2, 2020 at 1:52 PM Bartlomiej Zolnierkiewicz > wrote: >> Since we lack the hardware (or proper emulator setup) for >> testing needed changes add FIXMEs to document the issues >> (so at least they are not forgotten). >> >> Cc: Al Viro

Re: [PATCH][next] fbdev/fb.h: Use struct_size() helper in kzalloc()

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 6/17/20 7:56 PM, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > > Signed-off-by: Gustavo A. R.

Re: [PATCH v3] video: fbdev: ssd1307fb: Added support to Column offset

2020-07-10 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel ML to Cc: ] Hi, Sorry for the delay. On 5/13/20 8:48 PM, Rodrigo Alencar wrote: > From: Rodrigo Rolim Mendes de Alencar > > This patch provides support for displays like VGM128064B0W10, > which requires a column offset of 2, i.e., its segments starts > in SEG2 and ends in

Re: [PATCH v8 2/5] driver core: add deferring probe reason to devices_deferred property

2020-07-10 Thread Greg Kroah-Hartman
On Thu, Jul 02, 2020 at 03:44:21PM +0200, Andrzej Hajda wrote: > /sys/kernel/debug/devices_deferred property contains list of deferred devices. > This list does not contain reason why the driver deferred probe, the patch > improves it. > The natural place to set the reason is dev_err_probe

Re: [PATCH][next] fbcon: Use array3_size() helper in scr_memcpyw()

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 6/16/20 1:15 AM, Gustavo A. R. Silva wrote: > Use array3_size() helper instead of the open-coded version in scr_memcpyw() > and scr_memsetw(). These sorts of multiplication factors need to be wrapped > in array3_size(). > > This issue was found with the help of Coccinelle and, audited and

Re: [PATCH v2 1/2] video: fbdev: amifb: add FIXME about dead APUS support

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 6/2/20 2:03 PM, Geert Uytterhoeven wrote: > On Tue, Jun 2, 2020 at 1:50 PM Bartlomiej Zolnierkiewicz > wrote: >> On 5/14/20 10:21 PM, Geert Uytterhoeven wrote: >>> These #ifdefs are relics from APUS (Amiga Power-Up System), which >>> added a PPC board. APUS support was killed off a long

Re: [PATCH] video: fbdev: savage: fix memory leak on error handling path in probe

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 6/19/20 6:21 PM, Evgeny Novikov wrote: > savagefb_probe() calls savage_init_fb_info() that can successfully > allocate memory for info->pixmap.addr but then fail when > fb_alloc_cmap() fails. savagefb_probe() goes to label failed_init and > does not free allocated memory. It is not valid to

Re: [PATCH] omapfb: dss: Fix max fclk divider for omap36xx

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 6/30/20 8:26 PM, Adam Ford wrote: > The drm/omap driver was fixed to correct an issue where using a > divider of 32 breaks the DSS despite the TRM stating 32 is a valid > number. Through experimentation, it appears that 31 works, and > it is consistent with the value used by the drm/omap

Re: [PATCH][next] fbdev/fb.h: Use struct_size() helper in kzalloc()

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 6/20/20 1:27 PM, Sam Ravnborg wrote: > Hi Gustavo. > > On Wed, Jun 17, 2020 at 12:56:47PM -0500, Gustavo A. R. Silva wrote: >> Make use of the struct_size() helper instead of an open-coded version >> in order to avoid any potential type mistakes. >> >> This code was detected with the help of

Re: [PATCH] video: fbdev: neofb: fix memory leak in neo_scan_monitor()

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 6/30/20 9:54 PM, Evgeny Novikov wrote: > neofb_probe() calls neo_scan_monitor() that can successfully allocate a > memory for info->monspecs.modedb and proceed to case 0x03. There it does > not free the memory and returns -1. neofb_probe() goes to label > err_scan_monitor, thus, it does not

Re: [PATCH] omapfb: fix multiple reference count leaks due to pm_runtime_get_sync

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 6/14/20 5:05 AM, Aditya Pakki wrote: > On calling pm_runtime_get_sync() the reference count of the device > is incremented. In case of failure, decrement the > reference count before returning the error. > > Signed-off-by: Aditya Pakki Applied to drm-misc-next tree, thanks. Best regards,

Re: [PATCH] fbdev: da8xx-fb: go to proper label on error handling paths in probe

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 7/2/20 6:05 PM, Evgeny Novikov wrote: > fb_probe() can successfully allocate a new frame buffer, but then fail > to perform some operations with regulator. In these cases fb_probe() > goes to label err_pm_runtime_disable where the frame buffer is not > released. The patch makes fb_probe() to

Re: [PATCH] fbdev: sm712fb: set error code in probe

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 7/6/20 5:53 PM, Evgeny Novikov wrote: > If smtcfb_pci_probe() does not detect a valid chip it cleans up > everything and returns 0. This can result in various bad things later. > The patch sets the error code on the corresponding path. > > Found by Linux Driver Verification project

[PATCH v2] efi: avoid error message when booting under Xen

2020-07-10 Thread Juergen Gross
efifb_probe() will issue an error message in case the kernel is booted as Xen dom0 from UEFI as EFI_MEMMAP won't be set in this case. Avoid that message by calling efi_mem_desc_lookup() only if EFI_MEMMAP is set. Fixes: 38ac0287b7f4 ("fbdev/efifb: Honour UEFI memory map attributes when mapping

[PATCH] drm/vkms: change the max cursor width/height

2020-07-10 Thread Melissa Wen
This change expands the coverage for the IGT kms_cursor_crc test, where the size varies between 64 and 512 for a square cursor. With this, in addition to the cursor 64x64, this patch enables the test of cursors with sizes: 128x128, 256x256, and 512x512. Signed-off-by: Melissa Wen ---

Re: [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-10 Thread Maarten Lankhorst
Op 09-07-2020 om 14:33 schreef Daniel Vetter: > Comes up every few years, gets somewhat tedious to discuss, let's > write this down once and for all. > > What I'm not sure about is whether the text should be more explicit in > flat out mandating the amdkfd eviction fences for long running compute

  1   2   >