[syzbot] KASAN: use-after-free Read in udl_get_urb_timeout

2022-08-22 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5b6a4bf680d6 Add linux-next specific files for 20220818 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=12341a3d08 kernel config: https://syzkaller.appspot.com/x/.config?x=ead6107a3bbe3c62

[RFC 08/10] cpuhp: Replace cpumask_any_but(cpu_online_mask, cpu)

2022-08-22 Thread Pingfan Liu
In a kexec quick reboot path, the dying cpus are still on cpu_online_mask. During the teardown of cpu, a subsystem needs to migrate its broker to a real online cpu. This patch replaces cpumask_any_but(cpu_online_mask, cpu) in a teardown procedure with cpumask_not_dying_but(cpu_online_mask, cpu).

[PATCH] subdev/clk: fix repeated words in comments

2022-08-22 Thread wangjianli
Delete the redundant word 'at'. Signed-off-by: wangjianli --- drivers/gpu/drm/nouveau/nvkm/subdev/clk/gm20b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gm20b.c b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/gm20b.c index

Re: vm binding interfaces and parallel with mmap

2022-08-22 Thread Dave Airlie
On Mon, 22 Aug 2022 at 17:05, Dave Airlie wrote: > > Hey, > > I've just been looking at the vm bind type interfaces and wanted to at > least document how we think the unmapping API should work. I know I've > talked on irc before about this, but wanted to solidify things a bit > more around what

Re: vm binding interfaces and parallel with mmap

2022-08-22 Thread Bas Nieuwenhuizen
On Mon, Aug 22, 2022 at 9:28 AM Dave Airlie wrote: > > On Mon, 22 Aug 2022 at 17:05, Dave Airlie wrote: > > > > Hey, > > > > I've just been looking at the vm bind type interfaces and wanted to at > > least document how we think the unmapping API should work. I know I've > > talked on irc before

Re: [PATCH v1 00/35] drm: Analog TV Improvements

2022-08-22 Thread Mateusz Kwiatkowski
Hi Maxime, I tried testing and reviewing your changes properly over the last weekend, but ultimately ran into this ("flip_done timed out" etc.) issue and was unable to mitigate it, at least so far. This seems to pop up every time I try to change modes in any way (either change the TV norm, or

Re: [PATCH 3/3] drm: rcar-du: fix DSI enable & disable sequence

2022-08-22 Thread Laurent Pinchart
Hi Tomi, On Mon, Aug 22, 2022 at 12:02:06PM +0300, Tomi Valkeinen wrote: > On 19/08/2022 04:34, Laurent Pinchart wrote: > > On Wed, Aug 17, 2022 at 04:28:03PM +0300, Tomi Valkeinen wrote: > >> From: Tomi Valkeinen > >> > >> The rcar crtc depends on the clock provided from the rcar DSI bridge. >

[PATCH v11 2/6] dt-bindings: display: imx: Add i.MX8qxp/qm PRG binding

2022-08-22 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Gasket. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v10->v11: * No change. v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: *

[PATCH v11 3/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPR channel binding

2022-08-22 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Prefetch Resolve Channel. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v10->v11: * No change. v9->v10: * Add Rob's R-b tag. v8->v9: * Reference 'interrupts-extended' schema instead of 'interrupts' to require an additional

[PATCH v11 4/6] drm/atomic: Avoid unused-but-set-variable warning on for_each_old_plane_in_state

2022-08-22 Thread Liu Ying
Artificially use 'plane' and 'old_plane_state' to avoid 'not used' warning. The precedent has already been set by other macros in the same file. Acked-by: Daniel Vetter Signed-off-by: Liu Ying --- v10->v11: * No change. v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7:

[PATCH v11 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2022-08-22 Thread Liu Ying
Add myself as the maintainer of the i.MX8qxp DPU DRM driver. Acked-by: Laurentiu Palcu Signed-off-by: Liu Ying --- v10->v11: * Rebase upon v6.0-rc1. v9->v10: * Add Laurentiu's A-b tag. v8->v9: * No change. v7->v8: * No change. v6->v7: * No change. v5->v6: * No change. v4->v5: * No change.

Re: [PATCH v5 4/4] drm/lcdif: switch to devm_drm_of_get_bridge

2022-08-22 Thread Alexander Stein
Hello Marek, Am Freitag, 19. August 2022, 16:08:52 CEST schrieb Marek Vasut: > The function "drm_of_find_panel_or_bridge" has been deprecated in > favor of "devm_drm_of_get_bridge". > > Switch to the new function and reduce boilerplate. > > Acked-by: Sam Ravnborg > Reviewed-by: Liu Ying >

vm binding interfaces and parallel with mmap

2022-08-22 Thread Dave Airlie
Hey, I've just been looking at the vm bind type interfaces and wanted to at least document how we think the unmapping API should work. I know I've talked on irc before about this, but wanted to solidify things a bit more around what is required vs what is a nice to have. My main

[PATCH v11 0/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2022-08-22 Thread Liu Ying
Hi, This is the v11 series to introduce i.MX8qm/qxp Display Processing Unit(DPU) DRM support. DPU is comprised of a blit engine for 2D graphics, a display controller and a command sequencer. Outside of DPU, optional prefetch engines can fetch data from memory prior to some DPU fetchunits of

[PATCH v11 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2022-08-22 Thread Liu Ying
This patch adds bindings for i.MX8qxp/qm Display Processing Unit. Reviewed-by: Rob Herring Signed-off-by: Liu Ying --- v10->v11: * No change. v9->v10: * No change. v8->v9: * No change. v7->v8: * No change. v6->v7: * Add Rob's R-b tag back. v5->v6: * Use graph schema. So, drop Rob's R-b tag

Re: [PATCH v1 00/35] drm: Analog TV Improvements

2022-08-22 Thread Maxime Ripard
Hi, On Sun, Aug 21, 2022 at 06:33:12PM +0200, Noralf Trønnes wrote: > Den 29.07.2022 18.34, skrev Maxime Ripard: > > Hi, > > > > Here's a series aiming at improving the command line named modes support, > > and more importantly how we deal with all the analog TV variants. > > > > The named

Re: [PATCH 3/3] drm: rcar-du: fix DSI enable & disable sequence

2022-08-22 Thread Tomi Valkeinen
Hi, On 19/08/2022 04:34, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Wed, Aug 17, 2022 at 04:28:03PM +0300, Tomi Valkeinen wrote: From: Tomi Valkeinen The rcar crtc depends on the clock provided from the rcar DSI bridge. When the DSI bridge is disabled, the clock is

Re: [PATCH v5 1/4] drm/lcdif: Clean up headers

2022-08-22 Thread Alexander Stein
Hello Marek, Am Freitag, 19. August 2022, 16:08:49 CEST schrieb Marek Vasut: > Drop unneeded headers, sort rest alphabetically, no functional change. > > Acked-by: Sam Ravnborg > Reviewed-by: Liu Ying > Reported-by: Liu Ying > Tested-by: Martyn Welch > Fixes: 9db35bb349a0e ("drm: lcdif: Add

Re: [PATCH] Prevent CPU deadlock with fbdev based consoles while printing scheduler warnings

2022-08-22 Thread Dave Airlie
Just adding Thomas in case he missed it. Dave. On Mon, 22 Aug 2022 at 15:41, Mika Penttilä wrote: > > Gentle ping, any concerns or suggestions on this topic or solution in general? > > Thanks, > Mika > > > On 2.8.2022 6.31, mpent...@redhat.com wrote: > > From: Mika Penttilä > > With some fbdev

[PATCH 2/2] drm/i915: Add DSC support to MST path

2022-08-22 Thread Stanislav Lisovskiy
Whenever we are not able to get enough timeslots for required PBN, let's try to allocate those using DSC, just same way as we do for SST. v2: Removed intel_dp_mst_dsc_compute_config and refactored intel_dp_dsc_compute_config to support timeslots as a parameter(Ville Syrjälä) v3: -

[PATCH 1/2] drm: Add missing DP DSC extended capability definitions.

2022-08-22 Thread Stanislav Lisovskiy
Adding DP DSC register definitions, we might need for further DSC implementation, supporting MST and DP branch pass-through mode. v2: - Fixed checkpatch comment warning v3: - Removed function which is not yet used(Jani Nikula) Signed-off-by: Stanislav Lisovskiy --- include/drm/display/drm_dp.h

[PATCH 0/2] Add DP MST DSC support to i915

2022-08-22 Thread Stanislav Lisovskiy
Currently we have only DSC support for DP SST. Stanislav Lisovskiy (2): drm: Add missing DP DSC extended capability definitions. drm/i915: Add DSC support to MST path drivers/gpu/drm/i915/display/intel_dp.c | 73 - drivers/gpu/drm/i915/display/intel_dp.h | 17 +++

Re: [PATCH v5 3/4] drm/lcdif: Clean up debug prints and comments

2022-08-22 Thread Marek Vasut
On 8/22/22 08:24, Alexander Stein wrote: Hi, [...] --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -203,7 +203,7 @@ static void lcdif_crtc_mode_set_nofb(struct lcdif_drm_private *lcdif, DRM_DEV_DEBUG_DRIVER(drm->dev, "Pixel clock: %dkHz (actual: %dkHz)\n",

Re: [PATCH v7 1/8] overflow: Move and add few utility macros into overflow

2022-08-22 Thread Jani Nikula
On Wed, 17 Aug 2022, Kees Cook wrote: > On Thu, Aug 18, 2022 at 01:07:29AM +0200, Andi Shyti wrote: >> Hi Kees, >> >> would you mind taking a look at this patch? > > Hi! Thanks for the heads-up! Thanks for your review. This actually reaffirms my belief that we need to get these macros out of

Re: [syzbot] KASAN: use-after-free Read in udl_get_urb_timeout

2022-08-22 Thread Takashi Iwai
On Mon, 22 Aug 2022 11:09:31 +0200, syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:5b6a4bf680d6 Add linux-next specific files for 20220818 > git tree: linux-next > console+strace: https://syzkaller.appspot.com/x/log.txt?x=12341a3d08 > kernel

Re: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX

2022-08-22 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:09PM +0300, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > The driver does not explicitly stop the video mode transmission when > disabling the output. While this doesn't seem to be causing any issues, > lets follow the steps

Re: [PATCH v2 3/4] drm: rcar-du: fix DSI enable & disable sequence

2022-08-22 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:11PM +0300, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > The rcar crtc depends on the clock provided from the rcar DSI bridge. > When the DSI bridge is disabled, the clock is stopped, which causes the > crtc disable to

Re: [PATCH v7 1/8] overflow: Move and add few utility macros into overflow

2022-08-22 Thread Andrzej Hajda
On 18.08.2022 02:12, Kees Cook wrote: On Thu, Aug 18, 2022 at 01:07:29AM +0200, Andi Shyti wrote: Hi Kees, would you mind taking a look at this patch? Hi! Thanks for the heads-up! Thanks, Andi On Tue, Aug 16, 2022 at 06:35:18PM +0900, Gwan-gyeong Mun wrote: It moves overflows_type

RE: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX

2022-08-22 Thread Biju Das
Hi Tomi, Thanks for the patch. > Subject: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX > > From: Tomi Valkeinen > > The driver does not explicitly stop the video mode transmission when > disabling the output. While this doesn't seem to be causing any issues, > lets follow the

Re: [PATCH v2 2/4] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Tomi Valkeinen
On 22/08/2022 16:20, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:10PM +0300, Tomi Valkeinen wrote: From: Tomi Valkeinen Improve the DSI shutdown procedure by clearing various bits that were set while enabling the DSI output. There has been no

[PATCH v2 3/4] drm: rcar-du: fix DSI enable & disable sequence

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen The rcar crtc depends on the clock provided from the rcar DSI bridge. When the DSI bridge is disabled, the clock is stopped, which causes the crtc disable to timeout. Also, while I have no issue with the enable, the documentation suggests to enable the DSI before the crtc

[PATCH v2 4/4] drm: rcar-du: lvds: Rename pclk enable/disable functions

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen Rename LVDS pclk enable/disable functions to match what we use for DSI. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 ++-- drivers/gpu/drm/rcar-du/rcar_lvds.c| 4 ++-- drivers/gpu/drm/rcar-du/rcar_lvds.h| 10 +- 3 files

[PATCH v2 2/4] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen Improve the DSI shutdown procedure by clearing various bits that were set while enabling the DSI output. There has been no clear issues caused by these, but it's safer to ensure that the features are disabled at the start of the next DSI enable. Signed-off-by: Tomi

[PATCH v2 0/4] drm: rcar-du: DSI fixes

2022-08-22 Thread Tomi Valkeinen
Hi, This is v2 of the third patch in an earlier series ("drm: rcar-du: fix DSI enable & disable sequence"). The first two patches have already been accepted. Changes in v2: - Split the patch into smaller pieces - Modify the pclk enable function names so that they match between LVDS and DSI. -

Re: [PATCH v6 1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-08-22 Thread Christian König
Am 20.08.22 um 09:32 schrieb Arunpravin Paneer Selvam: We are adding two new callbacks to ttm resource manager function to handle intersection and compatibility of placement and resources. v2: move the amdgpu and ttm_range_manager changes to separate patches (Christian) v3: rename

Re: [PATCH v2 4/4] drm: rcar-du: lvds: Rename pclk enable/disable functions

2022-08-22 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:12PM +0300, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Rename LVDS pclk enable/disable functions to match what we use for DSI. I'd explain here the rationale for the new names: The DU driver uses the rcar_lvds_clk_enable()

Re: [PATCH v2 4/4] drm: rcar-du: lvds: Rename pclk enable/disable functions

2022-08-22 Thread Tomi Valkeinen
On 22/08/2022 16:52, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:12PM +0300, Tomi Valkeinen wrote: From: Tomi Valkeinen Rename LVDS pclk enable/disable functions to match what we use for DSI. I'd explain here the rationale for the new names:

Re: [PATCH v2 2/4] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Laurent Pinchart
On Mon, Aug 22, 2022 at 04:49:02PM +0300, Tomi Valkeinen wrote: > On 22/08/2022 16:20, Laurent Pinchart wrote: > > Hi Tomi, > > > > Thank you for the patch. > > > > On Mon, Aug 22, 2022 at 04:05:10PM +0300, Tomi Valkeinen wrote: > >> From: Tomi Valkeinen > >> > >> Improve the DSI shutdown

Re: [PATCH v2 2/4] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:10PM +0300, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Improve the DSI shutdown procedure by clearing various bits that were > set while enabling the DSI output. There has been no clear issues caused > by these, but it's

Re: [PATCH 4/5] drm/msm: Use separate ASID for each set of pgtables

2022-08-22 Thread Robin Murphy
On 2022-08-21 19:19, Rob Clark wrote: From: Rob Clark Optimize TLB invalidation by using different ASID for each set of pgtables. There can be scenarios where multiple processes end up with the same ASID (such as >256 processes using the GPU), but this is harmless, it will only result in some

Re: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX

2022-08-22 Thread Tomi Valkeinen
Hi, On 22/08/2022 16:25, Biju Das wrote: Hi Tomi, Thanks for the patch. Subject: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX From: Tomi Valkeinen The driver does not explicitly stop the video mode transmission when disabling the output. While this doesn't seem to be

Re: [PATCH 0/2] Convert arm,versatile-sysreg to DT schema

2022-08-22 Thread Linus Walleij
On Wed, Aug 10, 2022 at 6:03 PM Rob Herring wrote: > This short series converts the arm,versatile-sysreg binding to DT schema. > The binding is already in use in examples which unsurprisingly needs a > fix with the schema added. Excellent, thanks! Reviewed-by: Linus Walleij I assume you will

Re: [PATCH 2/3] iommu/dma: Move public interfaces to linux/iommu.h

2022-08-22 Thread Robin Murphy
On 2022-08-22 12:21, Christoph Hellwig wrote: diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 70393fbb57ed..79cb6eb560a8 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -1059,4 +1059,40 @@ void iommu_debugfs_setup(void); static inline void

[PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen The driver does not explicitly stop the video mode transmission when disabling the output. While this doesn't seem to be causing any issues, lets follow the steps described in the documentation and add a rcar_mipi_dsi_stop_video() which stop the video mode transmission. This

Re: [PATCH v1 00/35] drm: Analog TV Improvements

2022-08-22 Thread Noralf Trønnes
Den 22.08.2022 09.48, skrev Maxime Ripard: > Hi, > > On Sun, Aug 21, 2022 at 06:33:12PM +0200, Noralf Trønnes wrote: >> Den 29.07.2022 18.34, skrev Maxime Ripard: >>> Hi, >>> >>> Here's a series aiming at improving the command line named modes support, >>> and more importantly how we deal with

Re: [PATCH v2,1/2] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

2022-08-22 Thread Nícolas F . R . A . Prado
On Mon, Aug 22, 2022 at 08:50:45PM +0800, xinlei.lee wrote: [..] > Hi Nícolas: > > Thanks for your careful review. > I will correct it in the next version: > 1. Modify key nouns in the description; > 2. Modify the label of jitao to Co-developed-by; To be clear, you shouldn't change jitao's

Re: [PATCH] drm/panel-edp: add AUO B133UAN02.1 panel entry

2022-08-22 Thread Johan Hovold
On Fri, Jul 22, 2022 at 11:48:40AM +0200, Johan Hovold wrote: > On Mon, Jul 11, 2022 at 09:52:02AM +0200, Johan Hovold wrote: > > Add an eDP panel entry for AUO B133UAN02.1. > > > > Due to lack of documentation, use the delay_200_500_e50 timings like > > some other AUO entries for now. > > > >

RE: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode TX

2022-08-22 Thread Biju Das
Hi, > Subject: Re: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode > TX > > Hi, > > On 22/08/2022 16:25, Biju Das wrote: > > Hi Tomi, > > > > Thanks for the patch. > > > >> Subject: [PATCH v2 1/4] drm: rcar-du: dsi: Properly stop video mode > >> TX > >> > >> From: Tomi Valkeinen >

[PATCH v3 2/5] drm: rcar-du: dsi: Properly stop video mode TX

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen The driver does not explicitly stop the video mode transmission when disabling the output. While this doesn't seem to be causing any issues, lets follow the steps described in the documentation and add a rcar_mipi_dsi_stop_video() which stop the video mode transmission. This

[PATCH v3 3/5] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen Improve the DSI shutdown procedure by clearing various bits that were set while enabling the DSI output. There has been no clear issues caused by these, but it's safer to ensure that the features are disabled at the start of the next DSI enable. Signed-off-by: Tomi

[PATCH v3 1/5] drm: rcar-du: lvds: Rename pclk enable/disable functions

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen The DU driver uses the rcar_lvds_clk_enable() and rcar_lvds_clk_disable() functions enable or disable the pixel clock generated by the LVDS encoder, as it requires that clock for proper DU operation. Rename the functions by replacing "clk" with "pclk" to make it clearer that

[PATCH v3 5/5] drm: rcar-du: dsi: Fix VCLKSET write

2022-08-22 Thread Tomi Valkeinen
From: Tomi Valkeinen rcar_mipi_dsi_startup() writes correct values to VCLKSET, but as it uses or-operation to add the new values to the current value in the register, it should first make sure the fields are cleared. Do this by using rcar_mipi_dsi_write() to write the VCLKSET_CKEN bit to

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-22 Thread Dmitry Baryshkov
On 17/08/2022 21:01, Kuogee Hsieh wrote: DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and crtc->active is set before pushing a new frame downstream. There is a rare case that user space display manager issue an extra screen update immediately

Re: [PATCH v4 2/6] clk: qcom: Allow custom reset ops

2022-08-22 Thread Dmitry Baryshkov
On 19/08/2022 19:40, Akhil P Oommen wrote: Allow soc specific clk drivers to specify a custom reset operation. We will use this in an upcoming patch to allow gpucc driver to specify a differet reset operation for cx_gdsc. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov -- With

[PATCH] drm/msm/dpu: drop unused variable from dpu_kms_mdp_snapshot()

2022-08-22 Thread Dmitry Baryshkov
Follow up the merge of address fields and drop the variable that became unused after the commit 9403f9a42c88 ("drm/msm/dpu: merge base_off with blk_off in struct dpu_hw_blk_reg_map"). Fixes: 9403f9a42c88 ("drm/msm/dpu: merge base_off with blk_off in struct dpu_hw_blk_reg_map") Signed-off-by:

Re: [RFC] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-22 Thread Dmitry Baryshkov
On 09/08/2022 22:40, Laurent Pinchart wrote: Hi Abhinav, Thank you for the patch. On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote: adv7533 bridge tries to dynamically switch lanes based on the mode by detaching and attaching the mipi dsi device. This approach is incorrect

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-22 Thread Abhinav Kumar
Hi Dmitry On 8/22/2022 9:18 AM, Dmitry Baryshkov wrote: On 17/08/2022 21:01, Kuogee Hsieh wrote: DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and crtc->active is set before pushing a new frame downstream. There is a rare case that user space

Re: [Intel-gfx] [PATCH v6 2/4] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-08-22 Thread Imre Deak
On Fri, Jul 22, 2022 at 02:51:41PM +0200, Andrzej Hajda wrote: > HPD event after fbdev unregistration can cause registration of deferred > fbdev which will not be unregistered later, causing use-after-free. > To avoid it HPD handling should be suspended before fbdev unregistration. > > It should

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-22 Thread Nicolas Dufresne
Le samedi 20 août 2022 à 08:10 +0800, Hsia-Jun Li a écrit : > > On 8/20/22 03:17, Nicolas Dufresne wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > > > > Le vendredi 19 août 2022 à

Re: [Intel-gfx] [PATCH v7 1/8] overflow: Move and add few utility macros into overflow

2022-08-22 Thread Andrzej Hajda
On 22.08.2022 16:05, Andrzej Hajda wrote: On 18.08.2022 02:12, Kees Cook wrote: On Thu, Aug 18, 2022 at 01:07:29AM +0200, Andi Shyti wrote: Hi Kees, would you mind taking a look at this patch? Hi! Thanks for the heads-up! Thanks, Andi On Tue, Aug 16, 2022 at 06:35:18PM +0900,

Re: [PATCH 4/5] drm/msm: Use separate ASID for each set of pgtables

2022-08-22 Thread Robin Murphy
On 2022-08-22 14:52, Robin Murphy wrote: On 2022-08-21 19:19, Rob Clark wrote: From: Rob Clark Optimize TLB invalidation by using different ASID for each set of pgtables.  There can be scenarios where multiple processes end up with the same ASID (such as >256 processes using the GPU), but

Re: [PATCH v3 5/5] drm: rcar-du: dsi: Fix VCLKSET write

2022-08-22 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 05:34:01PM +0300, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > rcar_mipi_dsi_startup() writes correct values to VCLKSET, but as it uses > or-operation to add the new values to the current value in the register, > it should first

Re: [PATCH v6 1/4] drm/i915/hpd: postpone HPD cancel work after last user suspension

2022-08-22 Thread Imre Deak
On Fri, Jul 22, 2022 at 02:51:40PM +0200, Andrzej Hajda wrote: > i915->hotplug.dig_port_work can be queued from intel_hpd_irq_handler > called by IRQ handler or by intel_hpd_trigger_irq called from dp_mst. > Since dp_mst is suspended after irq handler uninstall, a cleaner approach > is to cancel

Re: [PATCH v4 4/6] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-08-22 Thread Dmitry Baryshkov
On 19/08/2022 19:40, Akhil P Oommen wrote: Allow a consumer driver to poll for cx gdsc collapse through Reset framework. Signed-off-by: Akhil P Oommen --- (no changes since v3) Changes in v3: - Convert 'struct qcom_reset_ops cx_gdsc_reset' to 'static const' (Krzysztof) Changes in v2: -

Re: [PATCH v4 3/6] clk: qcom: gdsc: Add a reset op to poll gdsc collapse

2022-08-22 Thread Dmitry Baryshkov
On 19/08/2022 19:40, Akhil P Oommen wrote: Add a reset op compatible function to poll for gdsc collapse. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

[PATCH v3 0/5] drm: rcar-du: DSI fixes

2022-08-22 Thread Tomi Valkeinen
Changes to v2: - Move the LVDS patch to the beginning and improve the patch desc. - Write 0 to registers in rcar_mipi_dsi_shutdown instead of just clearing a bit. - Fix function names in "fix DSI enable & disable sequence" patch desc. - Add "drm: rcar-du: dsi: Fix VCLKSET write" Tomi Tomi

[PATCH 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

2022-08-22 Thread Sascha Hauer
This series adds support for 4k@30 to the rockchip HDMI controller. This has been tested on a rk3568 rock3a board. It should be possible to add 4k@60 support the same way, but it doesn't work for me, so let's add 4k@30 as a first step. Sascha Sascha Hauer (2): drm/rockchip: dw_hdmi: relax

[PATCH 1/2] drm/rockchip: dw_hdmi: relax mode_valid hook

2022-08-22 Thread Sascha Hauer
The driver checks if the pixel clock of the given mode matches an entry in the mpll config table. The frequencies in the mpll table are meant as a frequency range up to which the entry works, not as a frequency that must match the pixel clock. Return MODE_OK when the pixelclock is smaller than one

[PATCH 2/2] drm/rockchip: dw_hdmi: Add support for 4k@30 resolution

2022-08-22 Thread Sascha Hauer
This adds the PLL/phy settings to support higher resolutions like 4k@30. The values were taken from the Rockchip downstream Kernel. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 8 1 file changed, 8 insertions(+) diff --git

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-22 Thread Dmitry Baryshkov
On 22/08/2022 19:38, Abhinav Kumar wrote: Hi Dmitry On 8/22/2022 9:18 AM, Dmitry Baryshkov wrote: On 17/08/2022 21:01, Kuogee Hsieh wrote: DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and crtc->active is set before pushing a new frame

Re: [PATCH v2 2/4] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Tomi Valkeinen
On 22/08/2022 17:05, Laurent Pinchart wrote: On Mon, Aug 22, 2022 at 04:49:02PM +0300, Tomi Valkeinen wrote: On 22/08/2022 16:20, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Mon, Aug 22, 2022 at 04:05:10PM +0300, Tomi Valkeinen wrote: From: Tomi Valkeinen Improve the DSI

Re: [PATCH v2 2/4] drm: rcar-du: dsi: Improve DSI shutdown

2022-08-22 Thread Laurent Pinchart
On Mon, Aug 22, 2022 at 05:19:56PM +0300, Tomi Valkeinen wrote: > On 22/08/2022 17:05, Laurent Pinchart wrote: > > On Mon, Aug 22, 2022 at 04:49:02PM +0300, Tomi Valkeinen wrote: > >> On 22/08/2022 16:20, Laurent Pinchart wrote: > >>> Hi Tomi, > >>> > >>> Thank you for the patch. > >>> > >>> On

Re: [PATCH] drm/msm: De-open-code some CP_EVENT_WRITE

2022-08-22 Thread Dmitry Baryshkov
On 21/08/2022 18:54, Rob Clark wrote: From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [Freedreno] [PATCH v2.5] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-08-22 Thread Dmitry Baryshkov
On 15/07/2022 00:54, Abhinav Kumar wrote: On 7/12/2022 6:22 AM, Dmitry Baryshkov wrote: Currently the DSI driver has two separate paths: one if the next device in a chain is a bridge and another one if the panel is connected directly to the DSI host. Simplify the code path by using

Re: [PATCH] drm/msm/dpu: drop unused memory allocation

2022-08-22 Thread Abhinav Kumar
On 8/22/2022 10:24 AM, Dmitry Baryshkov wrote: Drop the dpu_cfg variable and corresponding kzalloc, which became unused after changing hw catalog to static configuration. Fixes: de7d480f5e8c ("drm/msm/dpu: make dpu hardware catalog static const") Reported-by: kernel test robot Reported-by:

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-22 Thread Dmitry Baryshkov
On 22/08/2022 20:32, Abhinav Kumar wrote: On 8/22/2022 9:49 AM, Dmitry Baryshkov wrote: On 22/08/2022 19:38, Abhinav Kumar wrote: Hi Dmitry On 8/22/2022 9:18 AM, Dmitry Baryshkov wrote: On 17/08/2022 21:01, Kuogee Hsieh wrote: DRM commit_tails() will disable downstream crtc/encoder/bridge

Re: [PATCH v2 8/9] dt-bindings: msm/dp: add missing properties

2022-08-22 Thread Dmitry Baryshkov
On 12/07/2022 02:16, Rob Herring wrote: On Sun, Jul 10, 2022 at 11:41:32AM +0300, Dmitry Baryshkov wrote: Document missing definitions for opp-table (DP controller OPPs), aux-bus (DP AUX BUS) and data-lanes (DP/eDP lanes mapping) properties. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry

[PATCH v3 2/3] dt-bindings: msm/dp: add missing properties

2022-08-22 Thread Dmitry Baryshkov
Document missing definitions for opp-table (DP controller OPPs), aux-bus (DP AUX BUS) and data-lanes (DP/eDP lanes mapping) properties. Reviewed-by: Stephen Boyd Acked-by: Krzysztof Kozlowski Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dp-controller.yaml | 12

[PATCH v3 1/3] dt-bindings: msm/dp: mark vdda supplies as deprecated

2022-08-22 Thread Dmitry Baryshkov
The commit 85936d4f3815 ("phy: qcom-qmp: add regulator_set_load to dp phy") moved setting regulator load to the DP PHY driver (QMP). Then, the commit 7516351bebc1 ("drm/msm/dp: delete vdda regulator related functions from eDP/DP controller") removed support for VDDA supplies from the DP controller

[PATCH v3 0/3] dt-bindings: msm/dp: cleanup Qualcomm DP and eDP bidndings

2022-08-22 Thread Dmitry Baryshkov
Fix several issues with the DP and eDP bindings on the Qualcomm platforms. While we are at it, fix several small issues with platform files declaring these controllers. Changes since v2: - Fixed commit message for the patch 1 to mention proper commit IDs. - Dropped dts patches which were picked

Re: [RESEND v6 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-08-22 Thread Melissa Wen
On 08/22, Igor Matheus Andrade Torrente wrote: > Hi Melissa, > > On 8/20/22 07:51, Melissa Wen wrote: > > On 08/19, Igor Torrente wrote: > > > Currently the blend function only accepts XRGB_ and ARGB_ > > > as a color input. > > > > > > This patch refactors all the functions related to

Re: [RESEND v6 6/9] drm: vkms: Refactor the plane composer to accept new formats

2022-08-22 Thread Melissa Wen
On 08/22, Igor Matheus Andrade Torrente wrote: > On 8/22/22 16:01, Melissa Wen wrote: > > On 08/22, Igor Matheus Andrade Torrente wrote: > > > Hi Melissa, > > > > > > On 8/20/22 07:51, Melissa Wen wrote: > > > > On 08/19, Igor Torrente wrote: > > > > > Currently the blend function only accepts

Re: [PATCH 4/7] drm/msm/dp: Add SDM845 DisplayPort instance

2022-08-22 Thread Dmitry Baryshkov
On 10/08/2022 06:50, Bjorn Andersson wrote: The Qualcomm SDM845 platform has a single DisplayPort controller, with the same design as SC7180, so add support for this by reusing the SC7180 definition. Signed-off-by: Bjorn Andersson Reviewed-by: Dmitry Baryshkov ---

Re: [PATCH v2 6/9] arm64: dts: qcom: sc7280: drop unused clocks from eDP node

2022-08-22 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-07-10 01:41:30) > The eDP node includes two clocks which are used by the eDP PHY rather > than eDP controller itself. Drop these clocks to remove extra difference > between eDP and DP controllers. > > Suggested-by: Stephen Boyd > Signed-off-by: Dmitry Baryshkov >

[PATCH] drm/tidss: Set max DMA segment size

2022-08-22 Thread Andrew Davis
We have no segment size limitations. Set to unlimited. Signed-off-by: Andrew Davis --- drivers/gpu/drm/tidss/tidss_dispc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c index dd3c6a606ae2..624545e4636c 100644 ---

Re: [PATCH] dma-buf: cma_heap: Check for device max segment size when attaching

2022-08-22 Thread kernel test robot
Hi Andrew, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.0-rc2 next-20220822] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH 0/4] Allow MMIO regions to be exported through dma-buf

2022-08-22 Thread Alex Williamson
On Thu, 18 Aug 2022 09:05:24 -0300 Jason Gunthorpe wrote: > On Wed, Aug 17, 2022 at 01:11:38PM -0300, Jason Gunthorpe wrote: > > dma-buf has become a way to safely acquire a handle to non-struct page > > memory that can still have lifetime controlled by the exporter. Notably > > RDMA can now

Re: [PATCH] drm/nouveau/hwmon: use simplified HWMON_CHANNEL_INFO macro

2022-08-22 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks! I will push this upstream in a moment On Mon, 2022-08-15 at 13:40 +0300, Beniamin Sandu wrote: > This makes the code look cleaner and easier to read. > > Signed-off-by: Beniamin Sandu > --- > drivers/gpu/drm/nouveau/nouveau_hwmon.c | 85

[PATCH] dma-buf: cma_heap: Check for device max segment size when attaching

2022-08-22 Thread Andrew Davis
Although there is usually not such a limitation (and when there is it is often only because the driver forgot to change the super small default), it is still correct here to break scatterlist element into chunks of dma_max_mapping_size(). This might cause some issues for users with misbehaving

[PATCH] drm: omapdrm: Improve check for contiguous buffers

2022-08-22 Thread Andrew Davis
While a scatter-gather table having only 1 entry does imply it is contiguous, it is a logic error to assume the inverse. Tables can have more than 1 entry and still be contiguous. Use a proper check here. Signed-off-by: Andrew Davis --- drivers/gpu/drm/omapdrm/omap_gem.c | 14 ++ 1

Re: [PATCH] drm: Move radeon and amdgpu Kconfig options into their directories

2022-08-22 Thread Randy Dunlap
Hi-- On 8/22/22 17:01, Andrew Davis wrote: > Most Kconfig options to enable a driver are in the Kconfig file > inside the relevant directory, move these two to the same. > > Signed-off-by: Andrew Davis > --- > drivers/gpu/drm/Kconfig| 42 -- >

Re: [PATCH -next] drm/bridge: Add missing clk_disable_unprepare() in analogix_dp_resume()

2022-08-22 Thread Brian Norris
Hi, On Wed, Aug 17, 2022 at 05:05:25PM -0700, Brian Norris wrote: > Hmm, actually I'm going to have to retract that now that I've given it > some more testing locally. I happen to have a system where I commonly > hit this error case, and I'm thinking commit 211f276ed3d9 is actually > wrong, and

[PATCH] drm/panfrost: Update io-pgtable API

2022-08-22 Thread Robin Murphy
Convert to io-pgtable's bulk {map,unmap}_pages() APIs, to help the old single-page interfaces eventually go away. Unmapping heap BOs still wants to be done a page at a time, but everything else can get the full benefit of the more efficient interface. Signed-off-by: Robin Murphy ---

[PATCH] drm: Move radeon and amdgpu Kconfig options into their directories

2022-08-22 Thread Andrew Davis
Most Kconfig options to enable a driver are in the Kconfig file inside the relevant directory, move these two to the same. Signed-off-by: Andrew Davis --- drivers/gpu/drm/Kconfig| 42 -- drivers/gpu/drm/amd/amdgpu/Kconfig | 22

Re: [PATCH] drm: Move radeon and amdgpu Kconfig options into their directories

2022-08-22 Thread Andrew Davis
On 8/22/22 7:06 PM, Randy Dunlap wrote: Hi-- On 8/22/22 17:01, Andrew Davis wrote: Most Kconfig options to enable a driver are in the Kconfig file inside the relevant directory, move these two to the same. Signed-off-by: Andrew Davis --- drivers/gpu/drm/Kconfig| 42

[PATCH 1/2] drm/panel: use 'select' for Ili9341 panel driver helpers

2022-08-22 Thread Randy Dunlap
Use 'select' instead of 'depends on' for DRM helpers for the Ilitek ILI9341 panel driver. This is what is done in the vast majority of other cases and this makes it possible to fix a build error with drm_mipi_dbi. Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver") Signed-off-by:

[PATCH 2/2] drm: fix drm_mipi_dbi build errors

2022-08-22 Thread Randy Dunlap
drm_mipi_dbi needs lots of DRM_KMS_HELPER support, so select that Kconfig symbol like it is done is most other uses, and the way that it was before MIPS_DBI was moved from tinydrm to its core location. Fixes these build errors: ld: drivers/gpu/drm/drm_mipi_dbi.o: in function `mipi_dbi_buf_copy':

Re: [Intel-gfx] [PATCH v6 3/4] drm/i915/display: add hotplug.suspended flag

2022-08-22 Thread Imre Deak
On Fri, Jul 22, 2022 at 02:51:42PM +0200, Andrzej Hajda wrote: > HPD events during driver removal can be generated by hardware and > software frameworks - drm_dp_mst, the former we can avoid by disabling > interrupts, the latter can be triggered by any drm_dp_mst transaction, > and this is too

Re: [PATCH v6 4/4] drm/i915/fbdev: do not create fbdev if HPD is suspended

2022-08-22 Thread Imre Deak
On Fri, Jul 22, 2022 at 02:51:43PM +0200, Andrzej Hajda wrote: > In case of deferred FB setup core can try to create new > framebuffer. Disallow it if hpd_suspended flag is set. > > Signed-off-by: Andrzej Hajda Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/display/intel_fbdev.c | 6

Re: [PATCH] drm/msm/dp: add atomic_check to bridge ops

2022-08-22 Thread Abhinav Kumar
On 8/22/2022 9:49 AM, Dmitry Baryshkov wrote: On 22/08/2022 19:38, Abhinav Kumar wrote: Hi Dmitry On 8/22/2022 9:18 AM, Dmitry Baryshkov wrote: On 17/08/2022 21:01, Kuogee Hsieh wrote: DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and

  1   2   >