Re: [PATCH] mm: fix hugetlb page unmap count balance issue

2023-06-07 Thread Andrew Morton
On Wed, 7 Jun 2023 13:53:10 -0700 Mike Kravetz wrote: > > > > BUGs aren't good. Can we please find a way to push this along? > > > > Have we heard anything from any udmabuf people? > > > > I have not heard anything. When this issue popped up, it took me by surprise. > > udmabuf maintainer

Re: [Freedreno] [PATCH v3 6/7] drm/msm/dsi: Add phy configuration for MSM8226

2023-06-07 Thread Luca Weiss
On Mittwoch, 7. Juni 2023 21:46:31 CEST Jeykumar Sankaran wrote: > On 6/1/2023 10:00 AM, Luca Weiss wrote: > > MSM8226 uses a modified PLL lock sequence compared to MSM8974, which is > > based on the function dsi_pll_enable_seq_m in the msm-3.10 kernel. > > > > Worth noting that the msm-3.10

Re: [RFC PATCH v2 12/13] drm/msm/dpu: add support for virtual planes

2023-06-07 Thread Abhinav Kumar
On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: Only several SSPP blocks support such features as YUV output or scaling, thus different DRM planes have different features. Properly utilizing all planes requires the attention of the compositor, who should prefer simpler planes to YUV-supporting

Re: [PATCH v3] drm/i915/mtl/gsc: Add a gsc_info debugfs

2023-06-07 Thread Teres Alexis, Alan Previn
On Mon, 2023-06-05 at 21:32 -0700, Ceraolo Spurio, Daniele wrote: > Add a new debugfs to dump information about the GSC. This includes: > > - the FW path and SW tracking status; > - the release, security and compatibility versions; > - the HECI1 status registers. > > Note that those are the same

[PATCH v2 00/10] drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together

2023-06-07 Thread Douglas Anderson
The big motivation for this patch series is mostly described in the patch ("drm/panel: Add a way for other devices to follow panel state"), but to quickly summarize here: for touchscreens that are connected to a panel we need the ability to power sequence the two device together. This is not a

[PATCH v2 01/10] dt-bindings: HID: i2c-hid: Add "panel" property to i2c-hid backed touchscreens

2023-06-07 Thread Douglas Anderson
As talked about in the patch ("drm/panel: Add a way for other devices to follow panel state"), touchscreens that are connected to panels are generally expected to be power sequenced together with the panel they're attached to. Today, nothing provides information allowing you to find out that a

[PATCH v2 02/10] drm/panel: Check for already prepared/enabled in drm_panel

2023-06-07 Thread Douglas Anderson
In a whole pile of panel drivers, we have code to make the prepare/unprepare/enable/disable callbacks behave as no-ops if they've already been called. It's silly to have this code duplicated everywhere. Add it to the core instead so that we can eventually delete it from all the drivers. Note: to

[PATCH v2 03/10] drm/panel: Add a way for other devices to follow panel state

2023-06-07 Thread Douglas Anderson
These days, it's fairly common to see panels that have touchscreens attached to them. The panel and the touchscreen can somewhat be thought of as totally separate devices and, historically, this is how Linux has treated them. However, treating them as separate isn't necessarily the best way to

[PATCH v2 04/10] of: property: fw_devlink: Add a devlink for panel followers

2023-06-07 Thread Douglas Anderson
Inform fw_devlink of the fact that a panel follower (like a touchscreen) is effectively a consumer of the panel from the purposes of fw_devlink. NOTE: this patch isn't required for correctness but instead optimizes probe order / helps avoid deferrals. Signed-off-by: Douglas Anderson --- Since

[PATCH v2 08/10] HID: i2c-hid: Support being a panel follower

2023-06-07 Thread Douglas Anderson
As talked about in the patch ("drm/panel: Add a way for other devices to follow panel state"), we really want to keep the power states of a touchscreen and the panel it's attached to in sync with each other. In that spirit, add support to i2c-hid to be a panel follower. This will let the i2c-hid

[PATCH v2 09/10] HID: i2c-hid: Do panel follower work on the system_wq

2023-06-07 Thread Douglas Anderson
Turning on an i2c-hid device can be a slow process. This is why i2c-hid devices use PROBE_PREFER_ASYNCHRONOUS. Unfortunately, when we're a panel follower the i2c-hid power up sequence now blocks the power on of the panel. Let's fix that by scheduling the work on the system_wq. Signed-off-by:

[PATCH v2 10/10] arm64: dts: qcom: sc7180: Link trogdor touchscreens to the panels

2023-06-07 Thread Douglas Anderson
Let's provide the proper link from the touchscreen to the panel on trogdor devices where the touchscreen support it. This allows the OS to power sequence the touchscreen more properly. For the most part, this is just expected to marginally improve power consumption while the screen is off.

[PATCH v2 05/10] HID: i2c-hid: Switch to SYSTEM_SLEEP_PM_OPS()

2023-06-07 Thread Douglas Anderson
The SYSTEM_SLEEP_PM_OPS() allows us to get rid of '#ifdef CONFIG_PM_SLEEP', as talked about in commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones"). This change is expected to have no functional effect. Signed-off-by: Douglas Anderson --- (no changes since v1)

[PATCH v2 07/10] HID: i2c-hid: Make suspend and resume into helper functions

2023-06-07 Thread Douglas Anderson
In a future patch we'd like to be able to call the current i2c-hid suspend and resume functions from times other than system suspend. Move the functions higher up in the file and have them take a "struct i2c_hid" to make this simpler. We'll then add tiny wrappers of the functions for use with

[PATCH v2 06/10] HID: i2c-hid: Rearrange probe() to power things up later

2023-06-07 Thread Douglas Anderson
In a future patch, we want to change i2c-hid not to necessarily power up the touchscreen during probe. In preparation for that, rearrange the probe function so that we put as much stuff _before_ powering up the device as possible. This change is expected to have no functional effect.

Re: [PATCH 22/30] fbdev/smscufx: Detect registered fb_info from refcount

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Detect registered instances of fb_info by reading the reference > counter from struct fb_info.read. Avoids looking at the dev field > and prepares fbdev for making struct fb_info.dev optional. > > Signed-off-by: Thomas Zimmermann > Cc: Steve Glendinning > --- >

Re: [PATCH 29/30] fbdev/core: Rework fb init code

2023-06-07 Thread Sam Ravnborg
Hi Thomas. On Mon, Jun 05, 2023 at 04:48:11PM +0200, Thomas Zimmermann wrote: > Init the class "graphics" before the rest of fbdev. Later steps, such > as the sysfs code, depend on the class. Also arrange the module's exit > code in reverse order. > > Unexport the global variable fb_class, which

RE: [PATCH v3] drm/i915: Fix a VMA UAF for multi-gt platform

2023-06-07 Thread Venkatesh Reddy, Sushma
Thank you, Nirmoy. We have verified it on Chrome. Tested-by: Sushma Venkatesh Reddy -Original Message- From: Das, Nirmoy Sent: Wednesday, June 7, 2023 1:11 AM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Das, Nirmoy ; Joonas Lahtinen ; Vivi, Rodrigo ;

[pull] amdgpu, radeon drm-fixes-6.4

2023-06-07 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.4. The following changes since commit 9561de3a55bed6bdd44a12820ba81ec416e705a7: Linux 6.4-rc5 (2023-06-04 14:04:27 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.4-2023-06-07 for you to

Re: [RFC PATCH v2 12/13] drm/msm/dpu: add support for virtual planes

2023-06-07 Thread Dmitry Baryshkov
On 08/06/2023 00:05, Abhinav Kumar wrote: On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: Only several SSPP blocks support such features as YUV output or scaling, thus different DRM planes have different features.  Properly utilizing all planes requires the attention of the compositor, who

Re: [PATCH net-next v6 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-06-07 Thread Rob Herring
On Thu, Jun 01, 2023 at 03:12:27PM -0700, Justin Chen wrote: > From: Florian Fainelli > > Add a binding document for the Broadcom ASP 2.0 Ethernet > controller. > > Reviewed-by: Conor Dooley > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > --- > v6 > - Moved compatible

Re: [PATCH 23/30] fbdev/tdfxfb: Set i2c adapter parent to hardware device

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the 3dfx hardware device from the Linux device hierarchy as > parent device of the i2c adapter. Aligns the driver with the rest > of the codebase and prepares fbdev for making struct fb_info.dev > optional. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by:

Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Move fbdev's file-I/O code into a separate file and contain it in > init and cleanup helpers. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- [...] > + > +#include #include here, the robot complained about:

[PATCH v3] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow

2023-06-07 Thread Su Hui
Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") Signed-off-by: Su Hui --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c

[PATCH v2] drm/logicvc: Kconfig: select REGMAP and REGMAP_MMIO

2023-06-07 Thread Sui Jingfeng
drm/logicvc driver is depend on REGMAP and REGMAP_MMIO, should select this two kconfig option, otherwise the driver failed to compile on platform without REGMAP_MMIO selected: ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/logicvc/logicvc-drm.ko] undefined! make[1]: ***

Re: [PATCH v2 08/10] HID: i2c-hid: Support being a panel follower

2023-06-07 Thread kernel test robot
/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20230607144931.v2.8.Ib1a98309c455cd7e26b931c69993d4fba33bbe15%40changeid patch subject: [PATCH v2 08/10] HID: i2c-hid: Support being a panel follower config: arc-randconfig-r021-20230607 (https://download.01.org/0day

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow

2023-06-07 Thread Su Hui
On 2023/6/7 22:03, Doug Anderson wrote: Hi, On Tue, Jun 6, 2023 at 6:25 PM Su Hui wrote: Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") Signed-off-by: Su Hui --- drivers/gpu/drm/bridge/ti-sn65dsi86.c

Re: [PATCH] accel/ivpu: Use struct_size()

2023-06-07 Thread Stanislaw Gruszka
On Thu, Jun 01, 2023 at 05:58:48PM +0200, Marco Pagani wrote: > > On 2023-05-29 15:28, Christophe JAILLET wrote: > > Use struct_size() instead of hand-writing it. It is less verbose, more > > robust and more informative. > > > > Signed-off-by: Christophe JAILLET > > Reviewed-by: Marco Pagani

Re: [PATCH] drm: gem: add an option for supporting the dma-coherent hardware.

2023-06-07 Thread Sui Jingfeng
Hi, On 2023/6/7 20:19, Maxime Ripard wrote: On Wed, Jun 07, 2023 at 06:30:01PM +0800, Sui Jingfeng wrote: On 2023/6/7 17:36, Paul Cercueil wrote: Hi Sui, Le mercredi 07 juin 2023 à 13:30 +0800, Sui Jingfeng a écrit : The single map_noncoherent member of struct drm_gem_dma_object may not

Re: [PATCH 5/5] accel/ivpu: Mark 64 kB contiguous areas as contiguous in PTEs

2023-06-07 Thread Stanislaw Gruszka
On Thu, May 18, 2023 at 08:17:02AM -0600, Jeffrey Hugo wrote: > On 5/18/2023 7:16 AM, Stanislaw Gruszka wrote: > > From: Karol Wachowski > > > > Whenever KMD maps region larger than 64kB that is both aligned and > > contiguous, set contiguous bit (52) in MMU PTE descriptor for each page > > in

Re: [PATCH v1 2/8] dt-bindings: display: panel: mipi-dbi-spi: add spi-3wire property

2023-06-07 Thread Rob Herring
On Wed, Jun 07, 2023 at 09:59:47PM +0200, Noralf Trønnes wrote: > > > On 6/7/23 13:55, Leonard Göhrs wrote: > > Some MIPI DBI panels support a three wire mode (clock, chip select, > > bidirectional data) that can be used to ask the panel if it is already set > > up by e.g. the bootloader and can

Re: [PATCH v1 1/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible

2023-06-07 Thread Rob Herring
On Wed, 07 Jun 2023 13:55:00 +0200, Leonard Göhrs wrote: > The Shineworld LH133K is a 1.3" 240x240px RGB LCD with a MIPI DBI > compatible SPI interface. > The initialization procedure is quite basic with the exception of > requiring inverted colors. > A basic mipi-dbi-cmd[1] script to get the

Re: [PATCH v1 2/8] dt-bindings: display: panel: mipi-dbi-spi: add spi-3wire property

2023-06-07 Thread Rob Herring
On Wed, 07 Jun 2023 13:55:01 +0200, Leonard Göhrs wrote: > Some MIPI DBI panels support a three wire mode (clock, chip select, > bidirectional data) that can be used to ask the panel if it is already set > up by e.g. the bootloader and can thus skip the initialization. > This enables a

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

2023-06-07 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert and Thomas, > Hi Thomas, > > On Wed, Jun 7, 2023 at 5:15 PM Thomas Zimmermann wrote: >> Am 07.06.23 um 10:48 schrieb Geert Uytterhoeven: >> > On Mon, Jun 5, 2023 at 4:48 PM Thomas Zimmermann >> > wrote: >> >> --- a/drivers/video/fbdev/Kconfig >> >> +++

Re: [PATCH v2 1/2] drm/msm/dpu: use PINGPONG_NONE to unbind INTF from PP

2023-06-07 Thread Dmitry Baryshkov
On Sun, 04 Jun 2023 06:13:07 +0300, Dmitry Baryshkov wrote: > Currently the driver passes the PINGPONG index to > dpu_hw_intf_ops::bind_pingpong_blk() callback and uses separate boolean > flag to tell whether INTF should be bound or unbound. Simplify this by > passing PINGPONG_NONE in case of

Re: [PATCH v6 00/12] SM63(50|75) DPU support

2023-06-07 Thread Dmitry Baryshkov
On Tue, 06 Jun 2023 14:43:51 +0200, Konrad Dybcio wrote: > v5 -> v6: > - Drop unnecessary items: level in bindings > - Use INTF_SC7180_MASK for 6375 to avoid enabling DPU_INTF_DATA_COMPRESS on > DPU6 > - Pick up tags > > v5: >

Re: [PATCH v17] drm/msm/dpu: add DSC blocks to the catalog of MSM8998

2023-06-07 Thread Dmitry Baryshkov
On 06/06/2023 23:11, Kuogee Hsieh wrote: From: Abhinav Kumar Some platforms have DSC blocks which have not been declared in the catalog. Complete DSC 1.1 support for all platforms by adding the missing blocks to MSM8998. Changes in v9: -- add MSM8998 and SC8180x to commit title Changes in

Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-07 Thread Dmitry Baryshkov
On 07/06/2023 17:42, Dan Carpenter wrote: On Tue, Jun 06, 2023 at 10:23:46PM +0200, Marijn Suijten wrote: @@ -359,8 +359,8 @@ static void dpu_encoder_phys_cmd_tearcheck_config( * frequency divided by the no. of rows (lines) in the LCDpanel. */ vsync_hz =

Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-07 Thread Dmitry Baryshkov
On Tue, 06 Jun 2023 11:33:03 +0300, Dan Carpenter wrote: > The "vsync_hz" variable is unsigned int so it can't be less > than zero. The dpu_kms_get_clk_rate() function used to return a u64 > but I previously changed it to return an unsigned long and zero on > error so it matches clk_get_rate().

Re: [PATCH v17] drm/msm/dpu: add DSC blocks to the catalog of MSM8998

2023-06-07 Thread Dmitry Baryshkov
On Tue, 06 Jun 2023 13:11:12 -0700, Kuogee Hsieh wrote: > Some platforms have DSC blocks which have not been declared in the catalog. > Complete DSC 1.1 support for all platforms by adding the missing blocks to > MSM8998. > > Changes in v9: > -- add MSM8998 and SC8180x to commit title > >

Re: [PATCH v6 00/12] SM63(50|75) DPU support

2023-06-07 Thread Dmitry Baryshkov
On 06/06/2023 15:43, Konrad Dybcio wrote: [skipped the changelog] --- Konrad Dybcio (12): dt-bindings: display/msm: dsi-controller-main: Add SM6350 dt-bindings: display/msm: dsi-controller-main: Add SM6375 dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375

Re: [v1] drm/xe/guc: Fix h2g_write usage of GUC_CTB_MSG_MAX_LEN

2023-06-07 Thread Teres Alexis, Alan Previn
On Fri, 2023-06-02 at 11:52 -0700, Alan Previn wrote: > In the ABI header, GUC_CTB_MSG_MIN_LEN is '1' because > GUC_CTB_HDR_LEN is 1. This aligns with H2G/G2H CTB specification > where all command formats are defined in units of dwords so that '1' > is a dword. Accordingly, GUC_CTB_MSG_MAX_LEN is

Re: [Intel-gfx] [PATCH] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-07 Thread Andi Shyti
Hi Dong, On Wed, Jun 07, 2023 at 12:03:50PM -0700, Zhanjun Dong wrote: > This attempts to avoid circular locking dependency between flush delayed work > and intel_gt_reset. > Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync > version for reset path, it is safe as the

Re: [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix

2023-06-07 Thread Sui Jingfeng
Hi, On 2023/6/7 03:49, Bjorn Helgaas wrote: Match the subject line style: $ git log --oneline drivers/pci/vgaarb.c f321c35feaee PCI/VGA: Replace full MIT license text with SPDX identifier d5109fe4d1ec PCI/VGA: Use unsigned format string to print lock counts 4e6c91847a7f PCI/VGA:

Re: [PATCH 0/5] drm/ssd130x: A few enhancements and cleanups

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi Javierm, > > I've read through the patches and they look correct to me. > > Reviewed-by: Thomas Zimmermann > Thanks a lot for your review! > But I had one question about the page size. You round up to multiples of > page_size in several places.

Re: [PATCH 05/30] fbdev/atyfb: Use hardware device as backlight parent

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the hardware device in struct fb_info.device as parent of the > backlight device. Aligns the driver with the rest of the codebase > and prepares fbdev for making struct fb_info.dev optional. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez

Re: [PATCH v2] drm/i915: Fix a VMA UAF for multi-gt platform

2023-06-07 Thread Nirmoy Das
On 6/6/2023 10:56 PM, Andi Shyti wrote: Hi Nirmoy, On Tue, Jun 06, 2023 at 10:27:55PM +0200, Nirmoy Das wrote: Ensure correct handling of closed VMAs on multi-gt platforms to prevent Use-After-Free. Currently, when GT0 goes idle, closed VMAs that are exclusively added to GT0's closed_vma

Re: [PATCH 08/30] fbdev/broadsheetfb: Call device_remove_file() with hardware device

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Call device_remove_file() with the same device that has been used > for device_create_file(), which is the hardware device stored in > struct fb_info.device. Prepares fbdev for making struct fb_info.dev > optional. > > Signed-off-by: Thomas Zimmermann > ---

Re: [PATCH 07/30] fbdev/aty128fb: Use hardware device as backlight parent

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the hardware device in struct fb_info.device as parent of the > backlight device. Aligns the driver with the rest of the codebase > and prepares fbdev for making struct fb_info.dev optional. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez

Re: [PATCH 00/30] fbdev: Make userspace interfaces optional

2023-06-07 Thread Geert Uytterhoeven
Hi Thomas, Thanks for your series! Over the past few days, I have been giving this some thought, that's why I am replying only now... On Mon, Jun 5, 2023 at 4:48 PM Thomas Zimmermann wrote: > Add the new config option FB_DEVICE. If enabled, fbdev provides > traditional userspace interfaces in

Re: [RESEND PATCH v2 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H

2023-06-07 Thread Raphael Gallais-Pou
On 6/7/23 08:31, Dario Binacchi wrote: > Add compatible to panel-simple for Rocktech Displays Limited > RK043FN48H 4.3" 480x272 LCD-TFT panel. > > Signed-off-by: Dario Binacchi > Acked-by: Conor Dooley Reviewed-by: Raphael Gallais-Pou Thanks, Raphaël

Re: [PATCH 01/30] backlight/bd6107: Compare against struct fb_info.device

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Struct bd6107_platform_data refers to a platform device within > the Linux device hierarchy. The test in bd6107_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix the test by comparing to struct fb_info.device.

Re: [PATCH 1/9] dt-bindings: display: Add yamls for JH7110 display subsystem

2023-06-07 Thread Krzysztof Kozlowski
On 02/06/2023 09:40, Keith Zhao wrote: > Add bindings for JH7110 display subsystem which > has a display controller verisilicon dc8200 > and an HDMI interface. > > Signed-off-by: Keith Zhao > --- > .../display/verisilicon/starfive-hdmi.yaml| 93 +++ >

Re: [PATCH 03/30] backlight/lv5207lp: Compare against struct fb_info.device

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Struct lv5207lp_platform_data refers to a platform device within > the Linux device hierarchy. The test in lv5207lp_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix the test by comparing to struct

Re: [PATCH 01/30] backlight/bd6107: Compare against struct fb_info.device

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Struct bd6107_platform_data refers to a platform device within > the Linux device hierarchy. The test in bd6107_backlight_check_fb() > compares it against the fbdev device in struct fb_info.dev, which > is different. Fix the test by comparing to struct fb_info.device.

Re: [PATCH 06/30] fbdev/aty128fb: Reorder backlight and framebuffer init/cleanup

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The driver's backlight code requires the framebuffer to be > registered. Therefore reorder the init and cleanup calls for > both data structures. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez

[PATCH v3] drm/i915: Fix a VMA UAF for multi-gt platform

2023-06-07 Thread Nirmoy Das
Ensure correct handling of closed VMAs on multi-gt platforms to prevent Use-After-Free. Currently, when GT0 goes idle, closed VMAs that are exclusively added to GT0's closed_vma link (gt->closed_vma) and subsequently freed by i915_vma_parked(), which assumes the entire GPU is idle. However, on

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-06-07 Thread Felix Richter
Hi Guys, so I checked, the kernel I am running has this commit (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git /commit/?id=08da182175db4c7f80850354849d95f2670e8cd9) applied already! https://github.com/ju6ge/linux/commit/917680e6056aa288cac288d3afd2745d372beb61u And the

Re: [PATCH 09/30] fbdev/ep93xx-fb: Alloc DMA memory from hardware device

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Pass the hardware device to the DMA helpers dma_alloc_wc(), dma_mmap_wc() > and dma_free_coherent(). The fbdev device that is currently being used is > a software device and does not provide DMA memory. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier

[PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO

2023-06-07 Thread Sui Jingfeng
Otherwise its failed to pass basic compile test on platform without REGMAP_MMIO selected by defconfig make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64- SYNCinclude/config/auto.conf.cmd Checking missing-syscalls for N32 CALLscripts/checksyscalls.sh Checking

Re: [PATCH v9 6/8] drm: Remove usage of deprecated DRM_DEBUG

2023-06-07 Thread Siddh Raman Pant
On Tue, 06 Jun 2023 20:27:06 +0530, Laurent Pinchart wrote: > Hi Siddh, > > Thank you for the patch. Anytime :) > > if (!ctx_entry) { > > - DRM_DEBUG("out of memory\n"); > > + drm_dbg_core(dev, "out of memory\n"); > > This message could also be dropped. Okay. >

[PATCH v9 5/8] drm: Remove usage of deprecated DRM_ERROR

2023-06-07 Thread Siddh Raman Pant
drm_print.h says DRM_ERROR is deprecated in favor of drm_err(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_bridge.c | 8 drivers/gpu/drm/drm_bufs.c | 8 drivers/gpu/drm/drm_client_modeset.c | 4 ++-- drivers/gpu/drm/drm_context.c| 4

[PATCH v9 3/8] drm: Remove usage of deprecated DRM_INFO

2023-06-07 Thread Siddh Raman Pant
drm_print.h says DRM_INFO is deprecated in favor of drm_info(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_client_modeset.c | 2 +- drivers/gpu/drm/drm_connector.c | 7 --- drivers/gpu/drm/drm_drv.c| 2 +- drivers/gpu/drm/drm_pci.c| 2 +- 4 files

[PATCH v10 8/9] drm: Remove usage of deprecated DRM_DEBUG_KMS in DRM core

2023-06-07 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_KMS is deprecated in favor of drm_dbg_kms(). Reviewed-by: Laurent Pinchart Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_client_modeset.c | 112 +++ drivers/gpu/drm/drm_color_mgmt.c | 4 +- drivers/gpu/drm/drm_connector.c

Re: [PATCH v9 0/8] drm: Remove usage of deprecated DRM_* macros

2023-06-07 Thread Siddh Raman Pant
On Tue, 06 Jun 2023 23:19:28 +0530, Laurent Pinchart wrote: > The idea would be to include the drm_print_deprecated.h header in > drivers that still use the deprecated macros. Yeah, what I meant was in a "first pass" kind of sense. > > Not every file can be seen at a case-by-case basis or by

[PATCH v10 5/9] drm: Remove usage of deprecated DRM_ERROR in DRM core

2023-06-07 Thread Siddh Raman Pant
drm_print.h says DRM_ERROR is deprecated in favor of drm_err(). Reviewed-by: Laurent Pinchart Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_bridge.c | 8 drivers/gpu/drm/drm_bufs.c | 8 drivers/gpu/drm/drm_client_modeset.c | 4 ++--

[PATCH v9 1/8] Revert "drm: mipi-dsi: Convert logging to drm_* functions."

2023-06-07 Thread Siddh Raman Pant
This reverts commit 1040e424353f5f4d39f6f3aa8723eb3bd6ea6446. It used an incorrect way to use drm_* functions. Only drm_device ptrs should be passed, but the mentioned commit passed mipi_dsi_host ptr. It worked by accident due to macro magic. Reported-by: Jani Nikula Reviewed-by: Jani Nikula

Re: [PATCH v9 8/8] drm: Remove usage of deprecated DRM_DEBUG_KMS

2023-06-07 Thread Siddh Raman Pant
On Tue, 06 Jun 2023 20:34:19 +0530, Laurent Pinchart wrote: > Hi Siddh, > > Thank you for the patch. Anytime :) > > - DRM_DEBUG_KMS("\n"); > > + drm_dbg_kms(dev, "\n"); > > This message is pretty useless, it could be dropped on top of this > series. Okay. > > - DRM_DEBUG_KMS("\n"); >

[PATCH v10 7/9] drm: Remove usage of deprecated DRM_DEBUG_DRIVER in DRM core

2023-06-07 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_DRIVER is deprecated. Thus, use newer drm_dbg_driver(). Also fix the deprecation comment in drm_print.h which mentions drm_dbg() instead of drm_dbg_driver(). Reviewed-by: Laurent Pinchart Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_mipi_dbi.c | 10

Re: [PATCH] drm/amdgpu: display/Kconfig: replace leading spaces with tab

2023-06-07 Thread Sui Jingfeng
https://cgit.freedesktop.org/amd/drm-amd/ This one has a long time with no update. On 2023/6/7 14:31, Sui Jingfeng wrote: Hi, On 2023/6/7 03:15, Alex Deucher wrote: Applied.  Thanks! Where is the official branch of drm/amdgpu, I can't find it on the internet. Sorry for asking this

Re: [PATCH 1/9] dt-bindings: display: Add yamls for JH7110 display subsystem

2023-06-07 Thread Maxime Ripard
On Tue, Jun 06, 2023 at 11:37:53PM +0100, Conor Dooley wrote: > On Wed, Jun 07, 2023 at 12:22:33AM +0200, Heiko Stübner wrote: > > Am Dienstag, 6. Juni 2023, 20:41:17 CEST schrieb Shengyu Qu: > > > > On Fri, Jun 02, 2023 at 03:40:35PM +0800, Keith Zhao wrote: > > > >> Add bindings for JH7110

Re: [RESEND PATCH v2 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H

2023-06-07 Thread Jagan Teki
On Wed, Jun 7, 2023 at 12:01 PM Dario Binacchi wrote: > > Add compatible to panel-simple for Rocktech Displays Limited > RK043FN48H 4.3" 480x272 LCD-TFT panel. > > Signed-off-by: Dario Binacchi > Acked-by: Conor Dooley > > --- Reviewed-by: Jagan Teki

Re: (subset) [RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board

2023-06-07 Thread Neil Armstrong
Hi, On Wed, 07 Jun 2023 08:31:33 +0200, Dario Binacchi wrote: > The series adds support for the display on the stm32f746-disco board, > along with a generic patch that adds the "bpp" parameter to the stm-drm > module. The intention is to allow users to size, within certain limits, > the memory

Re: [PATCH 04/30] fbdev/atyfb: Reorder backlight and framebuffer init/cleanup

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The driver's backlight code requires the framebuffer to be > registered. Therefore reorder the init and cleanup calls for > both data structures. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez

Re: [PATCH 1/9] dt-bindings: display: Add yamls for JH7110 display subsystem

2023-06-07 Thread Heiko Stübner
Am Mittwoch, 7. Juni 2023, 00:37:53 CEST schrieb Conor Dooley: > On Wed, Jun 07, 2023 at 12:22:33AM +0200, Heiko Stübner wrote: > > Am Dienstag, 6. Juni 2023, 20:41:17 CEST schrieb Shengyu Qu: > > > > On Fri, Jun 02, 2023 at 03:40:35PM +0800, Keith Zhao wrote: > > > >> Add bindings for JH7110

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

2023-06-07 Thread Geert Uytterhoeven
Hi Thomas, Thanks for your patch! On Mon, Jun 5, 2023 at 4:48 PM Thomas Zimmermann wrote: > Add Kconfig option CONFIG_FB_DEVICE and make the virtual fbdev > device optional. If the new option has not been selected, fbdev > does not create a files in devfs or sysfs. > > Most modern Linux systems

Re: [PATCH 2/2] drm: bridge: tc358767: give VSDELAY some positive value

2023-06-07 Thread Lucas Stach
Am Freitag, dem 02.06.2023 um 23:34 +0200 schrieb Marek Vasut: > On 6/2/23 21:15, Lucas Stach wrote: > > From: David Jander > > > > The documentation is not clear about how this delay works. > > Empirical tests have shown that with a VSDELAY of 0, the first > > scanline is not properly formatted

Re: [PATCH] drm/panel-edp: Add AUO B116XAB01.4 edp panel entry

2023-06-07 Thread Doug Anderson
Hi, On Wed, Jun 7, 2023 at 3:23 AM Laura Nao wrote: > > Add a panel entry for the AUO B116XAB01.4 edp panel, found in the Acer > Chromebook Spin 311 (CP311-3H) laptop. > > Signed-off-by: Laura Nao > --- > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow

2023-06-07 Thread Doug Anderson
Hi, On Tue, Jun 6, 2023 at 6:25 PM Su Hui wrote: > > Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. > > Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") > Signed-off-by: Su Hui > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- > 1 file changed, 1

Re: [PATCH V8 0/7] drm: bridge: samsung-dsim: Support variable clocking

2023-06-07 Thread Adam Ford
On Wed, Jun 7, 2023 at 8:27 AM Adam Ford wrote: > > On Wed, Jun 7, 2023 at 8:15 AM Rasmus Villemoes > wrote: > > > > On 26/05/2023 05.05, Adam Ford wrote: > > > This series fixes the blanking pack size and the PMS calculation. It then > > > adds support to allows the DSIM to dynamically DPHY

Re: [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-07 Thread Andi Shyti
On Tue, Jun 06, 2023 at 12:00:42PM +0200, Andi Shyti wrote: > From: Fei Yang > > To comply with the design that buffer objects shall have immutable > cache setting through out their life cycle, {set, get}_caching ioctl's > are no longer supported from MTL onward. With that change caching >

Re: [PATCH v2] drm/i915: Fix a VMA UAF for multi-gt platform

2023-06-07 Thread Andrzej Hajda
On 06.06.2023 22:27, Nirmoy Das wrote: Ensure correct handling of closed VMAs on multi-gt platforms to prevent Use-After-Free. Currently, when GT0 goes idle, closed VMAs that are exclusively added to GT0's closed_vma link (gt->closed_vma) and subsequently freed by i915_vma_parked(), which

[RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7

2023-06-07 Thread Dario Binacchi
Add pin configurations for using LTDC (LCD-tft Display Controller) on stm32f746-disco board. Signed-off-by: Dario Binacchi --- (no changes since v1) arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 35 ++ 1 file changed, 35 insertions(+) diff --git

[RESEND PATCH v2 3/6] ARM: dts: stm32: support display on stm32f746-disco board

2023-06-07 Thread Dario Binacchi
Add support to Rocktech RK043FN48H display on stm32f746-disco board. Signed-off-by: Dario Binacchi --- (no changes since v1) arch/arm/boot/dts/stm32f746-disco.dts | 51 +++ 1 file changed, 51 insertions(+) diff --git a/arch/arm/boot/dts/stm32f746-disco.dts

[RESEND PATCH v2 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H

2023-06-07 Thread Dario Binacchi
Add compatible to panel-simple for Rocktech Displays Limited RK043FN48H 4.3" 480x272 LCD-TFT panel. Signed-off-by: Dario Binacchi Acked-by: Conor Dooley --- Changes in v2: - Add 'Acked-by' tag of Conor Dooley. .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file

[RESEND PATCH v2 6/6] drm/stm: add an option to change FB bpp

2023-06-07 Thread Dario Binacchi
Boards that use the STM32F{4,7} series have limited amounts of RAM. The added parameter allows users to size, within certain limits, the memory footprint required by the framebuffer. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/stm/drv.c | 8 +++- 1 file

[RESEND PATCH v2 5/6] drm/panel: simple: add support for Rocktech RK043FN48H panel

2023-06-07 Thread Dario Binacchi
Add support for Rocktech RK043FN48H 4.3" (480x272) LCD-TFT panel. Signed-off-by: Dario Binacchi Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202306020343.jntwem0p-...@intel.com/ --- Changes in v2: - Fix build warning reported by kernel test robot. - Add

[RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board

2023-06-07 Thread Dario Binacchi
The series adds support for the display on the stm32f746-disco board, along with a generic patch that adds the "bpp" parameter to the stm-drm module. The intention is to allow users to size, within certain limits, the memory footprint required by the framebuffer. Changes in v2: - Add 'Acked-by'

[RESEND PATCH v2 1/6] ARM: dts: stm32: add ltdc support on stm32f746 MCU

2023-06-07 Thread Dario Binacchi
Add LTDC (Lcd-tft Display Controller) support. Signed-off-by: Dario Binacchi --- (no changes since v1) arch/arm/boot/dts/stm32f746.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi index

Re: [PATCH] drm/amdgpu: display/Kconfig: replace leading spaces with tab

2023-06-07 Thread Sui Jingfeng
Hi, On 2023/6/7 03:15, Alex Deucher wrote: Applied. Thanks! Where is the official branch of drm/amdgpu, I can't find it on the internet. Sorry for asking this silly question. Alex On Tue, Jun 6, 2023 at 9:33 AM Sui Jingfeng wrote: This patch replace the leading spaces with tab, make

Re: [RESEND PATCH v2 5/6] drm/panel: simple: add support for Rocktech RK043FN48H panel

2023-06-07 Thread Jagan Teki
On Wed, Jun 7, 2023 at 12:01 PM Dario Binacchi wrote: > > Add support for Rocktech RK043FN48H 4.3" (480x272) LCD-TFT panel. > > Signed-off-by: Dario Binacchi > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202306020343.jntwem0p-...@intel.com/ > > ---

Re: [RESEND PATCH v2 3/6] ARM: dts: stm32: support display on stm32f746-disco board

2023-06-07 Thread Jagan Teki
On Wed, Jun 7, 2023 at 12:01 PM Dario Binacchi wrote: > > Add support to Rocktech RK043FN48H display on stm32f746-disco board. > > Signed-off-by: Dario Binacchi > --- > > (no changes since v1) > > arch/arm/boot/dts/stm32f746-disco.dts | 51 +++ > 1 file changed, 51

Re: [PATCH 2/9] riscv: dts: starfive: jh7110: add dc controller node

2023-06-07 Thread Krzysztof Kozlowski
On 02/06/2023 09:40, Keith Zhao wrote: > Add the dc controller and hdmi node for the Starfive JH7110 SoC. > > Signed-off-by: Keith Zhao > --- > .../jh7110-starfive-visionfive-2.dtsi | 87 +++ > arch/riscv/boot/dts/starfive/jh7110.dtsi | 46 ++ > 2 files

Re: [PATCH v2] drm/i915: Fix a VMA UAF for multi-gt platform

2023-06-07 Thread Nirmoy Das
On 6/7/2023 8:20 AM, Andrzej Hajda wrote: On 06.06.2023 22:27, Nirmoy Das wrote: Ensure correct handling of closed VMAs on multi-gt platforms to prevent Use-After-Free. Currently, when GT0 goes idle, closed VMAs that are exclusively added to GT0's closed_vma link (gt->closed_vma) and

Re: [PATCH v9 8/8] drm: Remove usage of deprecated DRM_DEBUG_KMS

2023-06-07 Thread Jani Nikula
On Wed, 07 Jun 2023, Laurent Pinchart wrote: > Hi Jani, > > On Wed, Jun 07, 2023 at 12:39:44AM +0300, Jani Nikula wrote: >> On Tue, 06 Jun 2023, Laurent Pinchart wrote: >> > On Tue, Jun 06, 2023 at 04:15:22PM +0530, Siddh Raman Pant wrote: >> >> @@ -777,7 +793,7 @@ int

[PATCH v10 4/9] drm: Remove usage of deprecated DRM_NOTE in DRM core

2023-06-07 Thread Siddh Raman Pant
drm_print.h says DRM_NOTE is deprecated in favor of drm_notice(). Reviewed-by: Laurent Pinchart Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_displayid.c | 2 +- drivers/gpu/drm/drm_kms_helper_common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v10 3/9] drm: Remove usage of deprecated DRM_INFO in DRM core

2023-06-07 Thread Siddh Raman Pant
drm_print.h says DRM_INFO is deprecated in favor of drm_info(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_client_modeset.c | 2 +- drivers/gpu/drm/drm_connector.c | 7 --- drivers/gpu/drm/drm_drv.c| 2 +- drivers/gpu/drm/drm_pci.c| 2 +- 4 files

[PATCH v9 2/8] drm/print: Fix and add support for NULL as first argument in drm_* macros

2023-06-07 Thread Siddh Raman Pant
Comments say macros DRM_DEBUG_* are deprecated in favor of drm_dbg_*(NULL, ...), but they have broken support for it, as the macro will result in `(NULL) ? (NULL)->dev : NULL`. Thus, fix them by separating logic to get dev ptr in a new function, which will return the dev ptr if arg is not NULL.

[PATCH v9 4/8] drm: Remove usage of deprecated DRM_NOTE

2023-06-07 Thread Siddh Raman Pant
drm_print.h says DRM_NOTE is deprecated in favor of drm_notice(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_displayid.c | 2 +- drivers/gpu/drm/drm_kms_helper_common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_displayid.c

[PATCH v9 6/8] drm: Remove usage of deprecated DRM_DEBUG

2023-06-07 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG is deprecated in favor of drm_dbg_core(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_agpsupport.c | 4 +- drivers/gpu/drm/drm_bufs.c| 114 +++--- drivers/gpu/drm/drm_context.c | 14 ++-- drivers/gpu/drm/drm_dma.c

  1   2   3   >