Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-11-13 Thread Keith Zhao
On 2023/10/26 6:23, Dmitry Baryshkov wrote: > On 25/10/2023 13:39, Keith Zhao wrote: >> add hdmi driver as encoder and connect >> >> Signed-off-by: Keith Zhao >> --- >>   drivers/gpu/drm/verisilicon/Kconfig |   8 +- >>   drivers/gpu/drm/verisilicon/Makefile    |   1 + >>  

[PATCH] drm/scheduler: improve GPU scheduler documentation

2023-11-13 Thread Christian König
Start to improve the scheduler document. Especially document the lifetime of each of the objects as well as the restrictions around DMA-fence handling and userspace compatibility. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 126 - 1 file

Re: Fbdev issue after the drm updates 'drm-next-2023-10-31-1'

2023-11-13 Thread Christian Zigotzky
On 13 November 2023 at 01:48 pm, Geert Uytterhoeven wrote: Hi Christian, On Sun, Nov 12, 2023 at 3:23 PM Christian Zigotzky wrote: On 07 November 2023 at 09:36 am, Christian Zigotzky wrote: I have found out that fbdev no longer works with virtio-gpu-pci and virtio-vga. It is not a problem

Re: [PATCH 2/2] drm/virtio: Modify RESOURCE_GET_LAYOUT ioctl

2023-11-13 Thread Dmitry Osipenko
On 11/10/23 10:16, Julia Zhang wrote: > Modify RESOURCE_GET_LAYOUT ioctl to handle the use case that query > correct stride for guest linear resource before it is created. > > Signed-off-by: Julia Zhang > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 26 -- >

Re: [PATCH v2 6/6] drm/vs: Add hdmi driver

2023-11-13 Thread Dmitry Baryshkov
On Mon, 13 Nov 2023 at 14:11, Keith Zhao wrote: > > > > On 2023/10/26 6:23, Dmitry Baryshkov wrote: > > On 25/10/2023 13:39, Keith Zhao wrote: > >> add hdmi driver as encoder and connect > >> > >> Signed-off-by: Keith Zhao > >> --- > >> drivers/gpu/drm/verisilicon/Kconfig | 8 +- > >>

Re: [PATCH] drm/panel: boe-tv101wum-nl6: Fine tune Himax83102-j02 panel HFP and HBP

2023-11-13 Thread cong yang
Hi, On Sat, Nov 11, 2023 at 5:10 AM Doug Anderson wrote: > > Hi, > > On Fri, Nov 10, 2023 at 1:46 AM Cong Yang > wrote: > > > > The refresh reported by modotest is 60.46Hz, and the actual measurement > > s/modotets/modetest/ > > > is 60.01Hz, which is outside the expected tolerance. Adjust

Re: Fbdev issue after the drm updates 'drm-next-2023-10-31-1'

2023-11-13 Thread Geert Uytterhoeven
Hi Christian, On Sun, Nov 12, 2023 at 3:23 PM Christian Zigotzky wrote: > On 07 November 2023 at 09:36 am, Christian Zigotzky wrote: > > I have found out that fbdev no longer works with virtio-gpu-pci and > > virtio-vga. It is not a problem with the penguin logos. > > > > Could you please check

Re: [RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found

2023-11-13 Thread Javier Martinez Canillas
Andrew Worsley writes: Hello Andrew, > On Mon, 13 Nov 2023 at 20:18, Thomas Zimmermann wrote: >> Am 13.11.23 um 09:51 schrieb Javier Martinez Canillas: >> > Some DT platforms use EFI to boot and in this case the EFI Boot Services >> > may register a EFI_GRAPHICS_OUTPUT_PROTOCOL handle, that

Re: [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-13 Thread Danilo Krummrich
On 11/13/23 08:22, Christian König wrote: Am 10.11.23 um 17:57 schrieb Danilo Krummrich: On 11/10/23 09:50, Christian König wrote: [SNIP] Another issue Christian brought up is that something intended to be embeddable (a base class) shouldn't really have its own refcount. I think that's a

Re: [RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found

2023-11-13 Thread Andrew Worsley
On Mon, 13 Nov 2023 at 23:57, Javier Martinez Canillas wrote: > > Andrew Worsley writes: > > Hello Andrew, > > > On Mon, 13 Nov 2023 at 20:18, Thomas Zimmermann wrote: > >> Am 13.11.23 um 09:51 schrieb Javier Martinez Canillas: > >> > Some DT platforms use EFI to boot and in this case the EFI

Re: [PATCH 4/5] dt-bindings: gpu: samsung-g2d: constrain iommus and power-domains

2023-11-13 Thread Conor Dooley
On Sun, Nov 12, 2023 at 07:44:02PM +0100, Krzysztof Kozlowski wrote: > Provide specific constraints for iommus and power-domains, based on > current DTS. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention

2023-11-13 Thread Conor Dooley
On Sun, Nov 12, 2023 at 07:44:00PM +0100, Krzysztof Kozlowski wrote: > The Devicetree bindings coding convention, as used in most of the files > and expressed in Documentation/devicetree/bindings/example-schema.yaml, > expects "allOf:" block with if-statements after "required:" block. > >

Re: [PATCH 5/5] dt-bindings: gpu: samsung-scaler: constrain iommus and power-domains

2023-11-13 Thread Conor Dooley
On Sun, Nov 12, 2023 at 07:44:03PM +0100, Krzysztof Kozlowski wrote: > Provide specific constraints for iommus and power-domains, based on > current DTS. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Conor Dooley signature.asc Description: PGP signature

Re: [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-13 Thread Jani Nikula
On Mon, 13 Nov 2023, Heiner Kallweit wrote: > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. > Class-based device auto-detection is a legacy mechanism and shouldn't > be used in new code. So we can

Re: [PATCH 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

2023-11-13 Thread Heiner Kallweit
On 13.11.2023 13:17, Jani Nikula wrote: > On Mon, 13 Nov 2023, Heiner Kallweit wrote: >> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in >> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. >> Class-based device auto-detection is a legacy mechanism and

Re: [RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found

2023-11-13 Thread Andrew Worsley
On Mon, 13 Nov 2023 at 20:18, Thomas Zimmermann wrote: > > > > Am 13.11.23 um 09:51 schrieb Javier Martinez Canillas: > > Some DT platforms use EFI to boot and in this case the EFI Boot Services > > may register a EFI_GRAPHICS_OUTPUT_PROTOCOL handle, that will later be > > queried by the Linux

Re: [PATCH] drm/scheduler: improve GPU scheduler documentation

2023-11-13 Thread Danilo Krummrich
Hi Christian, On 11/13/23 13:38, Christian König wrote: Start to improve the scheduler document. Especially document the lifetime of each of the objects as well as the restrictions around DMA-fence handling and userspace compatibility. Thanks a lot for submitting this - it's very much

Re: [PATCH] drm/scheduler: improve GPU scheduler documentation

2023-11-13 Thread Christian König
Am 13.11.23 um 14:14 schrieb Danilo Krummrich: Hi Christian, On 11/13/23 13:38, Christian König wrote: Start to improve the scheduler document. Especially document the lifetime of each of the objects as well as the restrictions around DMA-fence handling and userspace compatibility. Thanks a

Re: [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes

2023-11-13 Thread Conor Dooley
On Sun, Nov 12, 2023 at 07:43:59PM +0100, Krzysztof Kozlowski wrote: > Compatibles should not use quotes in the bindings. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Conor Dooley Cheers… Conor. > --- > .../devicetree/bindings/gpu/samsung-rotator.yaml | 9 + > 1 file

Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties

2023-11-13 Thread Conor Dooley
On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote: > When number of clock varies between variants, the Devicetree bindings > coding convention expects to have widest constraints in top-level > definition of the properties and narrow them in allOf:if:then block. > > This is more

Re: [RFC][PATCH v5 0/6] drm/panic: Add a drm panic handler

2023-11-13 Thread nerdopolis
On Friday, November 3, 2023 10:53:24 AM EST Jocelyn Falempe wrote: > This introduces a new drm panic handler, which displays a message when a > panic occurs. > So when fbcon is disabled, you can still see a kernel panic. > > This is one of the missing feature, when disabling VT/fbcon in the

Re: [PATCH 4/5] accel/ivpu: Use dedicated work for job timeout detection

2023-11-13 Thread Jeffrey Hugo
On 11/13/2023 10:02 AM, Jacek Lawrynowicz wrote: From: Stanislaw Gruszka Change to use work for timeout detection. Needed for thread_irq conversion. Signed-off-by: Stanislaw Gruszka Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH v2 6/8] dt-bindings: reserved-memory: Add secure CMA reserved memory range

2023-11-13 Thread Rob Herring
On Sat, 11 Nov 2023 19:15:57 +0800, Yong Wu wrote: > Add a binding for describing the secure CMA reserved memory range. The > memory range also will be defined in the TEE firmware. It means the TEE > will be configured with the same address/size that is being set in this > DT node. > >

Re: [RFC PATCH v3 08/12] net: support non paged skb frags

2023-11-13 Thread Jakub Kicinski
On Sun, 12 Nov 2023 22:05:30 -0800 Mina Almasry wrote: > My issue here is that all these skb helpers call each other so I end > up having to move a lot of the unrelated skb helpers to this new > header (maybe that is acceptable but it feels weird). Splitting pp headers again is not an option, we

Re: [RFC PATCH v3 12/12] selftests: add ncdevmem, netcat for devmem TCP

2023-11-13 Thread Jakub Kicinski
On Sun, 12 Nov 2023 20:08:10 -0800 Mina Almasry wrote: > 1. For (b), would it be OK to implement a very minimal version of > queue_[stop|start]/queue_mem_[alloc|free], which I use for the sole > purpose of reposting buffers to an individual queue, and then later > whoever picks up your queue API

Re: [PATCH 2/5] accel/ivpu: Do not use irqsave in ivpu_ipc_dispatch

2023-11-13 Thread Jeffrey Hugo
On 11/13/2023 10:02 AM, Jacek Lawrynowicz wrote: From: Stanislaw Gruszka ivpu_ipc_dispatch is always called with irqs disabled. Add lockdep assertion and remove unneeded _irqsave/_irqrestore. Signed-off-by: Stanislaw Gruszka Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

[PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-13 Thread Imre Deak
The current way of calculating the pbn_div value, the link BW per each MTP slot, worked only for DP 1.4 link rates. Fix things up for UHBR rates calculating with the correct channel coding efficiency based on the link rate. On UHBR the resulting pbn_div value is not an integer (vs. DP 1.4 where

Re: [PATCH 3/5] accel/ivpu: Do not use cons->aborted for job_done_thread

2023-11-13 Thread Jeffrey Hugo
On 11/13/2023 10:02 AM, Jacek Lawrynowicz wrote: From: Stanislaw Gruszka This allow to simplify ivpu_ipc_receive() as now we do not have to process all messages in aborted state - they will be freed in ivpu_ipc_consumer_del(). Signed-off-by: Stanislaw Gruszka Signed-off-by: Jacek Lawrynowicz

Re: [PATCH] drm/i915: Initialize residency registers earlier

2023-11-13 Thread Teres Alexis, Alan Previn
On Mon, 2023-10-30 at 16:45 -0700, Belgaumkar, Vinay wrote: alan:skip > +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c > @@ -608,11 +608,13 @@ void intel_rc6_init(struct intel_rc6 *rc6) > /* Disable runtime-pm until we can save the GPU state with rc6 pctx */ > rpm_get(rc6); > > - if

Re: [PATCH v3] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Abhinav Singh
On 11/14/23 00:43, Abhinav Singh wrote: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not be directly dereferencing a rcu pointer. To get a normal (non

Re: [PATCH 1/5] accel/ivpu: Rename cons->rx_msg_lock

2023-11-13 Thread Jeffrey Hugo
On 11/13/2023 10:02 AM, Jacek Lawrynowicz wrote: From: Stanislaw Gruszka Now the cons->rx_msg_lock protects also 'abort' field so rename the lock. "protects also" -> "also protects" Signed-off-by: Stanislaw Gruszka Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

[PATCH v3] drm/i915: Skip pxp init if gt is wedged

2023-11-13 Thread Zhanjun Dong
The gt wedged could be triggered by missing guc firmware file, HW not working, etc. Once triggered, it means all gt usage is dead, therefore we can't enable pxp under this fatal error condition. v2: Updated commit message. v3: Updated return code check. Signed-off-by: Zhanjun Dong ---

Re: [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-13 Thread kernel test robot
Hi Imre, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Imre-Deak/drm-i915-dp-Fix-UHBR-link-M-N-values/20231114-043135 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link:

Incomplete stable drm/ast backport - screen freeze on boot

2023-11-13 Thread Keno Fischer
Greetings, When connected to a remote machine via the BMC KVM functionality, I am experiencing screen freezes on boot when using 6.5 stable, but not master. The BMC on the machine in question is an ASpeed AST2600. A quick bisect shows the problematic commit to be 2fb9667 ("drm/ast: report

Re: [PATCH v2 1/2] drm/bridge: Fix improper bridge init order with pre_enable_prev_first

2023-11-13 Thread Jagan Teki
On Tue, Aug 1, 2023 at 11:50 AM Dave Stevenson wrote: > > Hi Jagan > > My apologies for dropping the ball on this one, and thanks to Frieder > for the nudge. > > On Wed, 12 Apr 2023 at 07:25, Jagan Teki wrote: > > > > Hi Dave, > > > > Added Maxime, Laurent [which I thought I added before] > > >

Re: [PATCH] drm/i915: eliminate warnings

2023-11-13 Thread Rodrigo Vivi
On Mon, Nov 13, 2023 at 11:36:13AM +0800, heminhong wrote: > Current, the dewake_scanline variable is defined as unsigned int, > an unsigned int variable that is always greater than or equal to 0. > when _intel_dsb_commit function is called by intel_dsb_commit function, > the dewake_scanline

Re: [PATCH 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support

2023-11-13 Thread Heiko Stübner
Am Montag, 13. November 2023, 12:23:25 CET schrieb Heiner Kallweit: > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. > Class-based device auto-detection is a legacy mechanism and shouldn't > be used in

Re: [PATCH 0/3] pwm: Drop useless member "pwm" from struct pwm_device

2023-11-13 Thread Uwe Kleine-König
Hello, On Fri, Jul 28, 2023 at 04:58:21PM +0200, Uwe Kleine-König wrote: > there are only two users of struct pwm_device::pwm in the tree; both use > it for some dev_dbg output. While this number allows to identify the > PWM, it's not trivial, for example the data currently available in >

[PATCH drm-misc-next] drm/nouveau: use GPUVM common infrastructure

2023-11-13 Thread Danilo Krummrich
GPUVM provides common infrastructure to track external and evicted GEM objects as well as locking and validation helpers. Especially external and evicted object tracking is a huge improvement compared to the current brute force approach of iterating all mappings in order to lock and validate the

Re: [RFC PATCH v3 02/12] net: page_pool: create hooks for custom page providers

2023-11-13 Thread Jakub Kicinski
On Sun, 12 Nov 2023 19:28:52 -0800 Mina Almasry wrote: > My issue with this is that if the driver doesn't support dmabuf then > the driver will accidentally use the pp backed by the dmabuf, allocate > a page from it, then call page_address() on it or something, and > crash. > > Currently I avoid

[PATCH v3] drm: omapdrm: Improve check for contiguous buffers

2023-11-13 Thread Andrew Davis
While a scatter-gather table having only 1 entry does imply it is contiguous, it is a logic error to assume the inverse. Tables can have more than 1 entry and still be contiguous. Use a proper check here. Signed-off-by: Andrew Davis --- Changes from v2: - Double check that these multi-segment

Re: [Intel-gfx] [PATCH v3] drm/i915: Skip pxp init if gt is wedged

2023-11-13 Thread Teres Alexis, Alan Previn
On Mon, 2023-11-13 at 14:49 -0800, Zhanjun Dong wrote: > The gt wedged could be triggered by missing guc firmware file, HW not > working, etc. Once triggered, it means all gt usage is dead, therefore we > can't enable pxp under this fatal error condition. > > alan:skip alan: this looks good (as

Re: [PATCH 5/5] accel/ivpu: Use threaded IRQ to handle JOB done messages

2023-11-13 Thread Jeffrey Hugo
On 11/13/2023 10:02 AM, Jacek Lawrynowicz wrote: Remove job_done thread and replace it with generic callback based mechanism. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-13 Thread Wolfram Sang
> We're not in a hurry. It's just my experience with patch series' affecting > multiple subsystems that typically the decision was to apply the full > series via one tree. Also to avoid inquires from maintainers like: > Shall I take it or are you going to take it? > Of course there may be

linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Stephen Rothwell
Hi all, Commit 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgpeMaIL1m2Gt.pgp Description: OpenPGP digital signature

Re: [PATCH 4/4] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-13 Thread kernel test robot
Hi Imre, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Imre-Deak/drm-i915-dp-Fix-UHBR-link-M-N-values/20231114-043135 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link:

[PATCH drm-misc-next 1/2] drm/nouveau: implement 1:1 scheduler - entity relationship

2023-11-13 Thread Danilo Krummrich
Recent patches to the DRM scheduler [1][2] allow for a variable number of run-queues and add support for (shared) workqueues rather than dedicated kthreads per scheduler. This allows us to create a 1:1 relationship between a GPU scheduler and a scheduler entity, in order to properly support

[PATCH drm-misc-next 2/2] drm/nouveau: enable dynamic job-flow control

2023-11-13 Thread Danilo Krummrich
Make use of the scheduler's credit limit and scheduler job's credit count to account for the actual size of a job, such that we fill up the ring efficiently. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 3 ++- drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +-

linux-next: manual merge of the drm-misc tree with Linus' tree

2023-11-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/tests/drm_mm_test.c between commit: 2ba157983974 ("drm/tests: Fix incorrect argument in drm_test_mm_insert_range") from Linus' tree and commit: 078a5b498d6a ("drm/tests: Remove slow tests") from

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Stephen Rothwell
Hi Luben, On Mon, 13 Nov 2023 20:32:40 -0500 Luben Tuikov wrote: > > On 2023-11-13 20:08, Luben Tuikov wrote: > > On 2023-11-13 15:55, Stephen Rothwell wrote: > >> Hi all, > >> > >> Commit > >> > >> 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") > >> > >> is missing a Signed-off-by

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Luben Tuikov
On 2023-11-13 21:45, Stephen Rothwell wrote: > Hi Luben, > > On Mon, 13 Nov 2023 20:32:40 -0500 Luben Tuikov wrote: >> >> On 2023-11-13 20:08, Luben Tuikov wrote: >>> On 2023-11-13 15:55, Stephen Rothwell wrote: Hi all, Commit 0da611a87021 ("dma-buf: add

[V2] drm/panel: auo,b101uan08.3: Fine tune the panel power sequence

2023-11-13 Thread Xuxin Xiong
For "auo,b101uan08.3" this panel, it is stipulated in the panel spec that MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high. Fixes: 56ad624b4cb5("drm/panel: support for auo, b101uan08.3 wuxga dsi video mode panel") Signed-off-by: Xuxin Xiong ---

[PATCH v2 1/2] drm/i915/guc: Fix for potential false positives in GuC hang selftest

2023-11-13 Thread John . C . Harrison
From: John Harrison Noticed that the hangcheck selftest is submitting a non-preemptoble spinner. That means that even if the GuC does not die, the heartbeat will still kick in and trigger a reset. Which is rather defeating the purpose of the test - to verify that the heartbeat will kick in if

[PATCH v2 0/2] Selftest for FAST_REQUEST feature

2023-11-13 Thread John . C . Harrison
From: John Harrison Add a selftest to verify that the FAST_REQUEST mechanism (getting errors back from fire-and-forget H2G commands) is functional. Also fix up a potential false positive in the GuC hang selftest. v2: Fix some dumb over-complications and typos - review feedback from Daniele.

[PATCH v2 2/2] drm/i915/guc: Add a selftest for FAST_REQUEST errors

2023-11-13 Thread John . C . Harrison
From: John Harrison There is a mechanism for reporting errors from fire and forget H2G messages. This is the only way to find out about almost any error in the GuC backend submission path. So it would be useful to know that it is working. v2: Fix some dumb over-complications and a couple of

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Luben Tuikov
On 2023-11-13 15:55, Stephen Rothwell wrote: > Hi all, > > Commit > > 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") > > is missing a Signed-off-by from its committer. > In order to merge the scheduler changes necessary for the Xe driver, those changes were based on drm-tip,

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Luben Tuikov
On 2023-11-13 20:08, Luben Tuikov wrote: > On 2023-11-13 15:55, Stephen Rothwell wrote: >> Hi all, >> >> Commit >> >> 0da611a87021 ("dma-buf: add dma_fence_timestamp helper") >> >> is missing a Signed-off-by from its committer. >> > > In order to merge the scheduler changes necessary for the Xe

linux-next: build warning after merge of the drm-intel tree

2023-11-13 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/drm-kms-helpers:296: drivers/gpu/drm/display/drm_dp_mst_topology.c:5484: ERROR: Unexpected indentation. Documentation/gpu/drm-kms-helpers:296:

[PATCH] drm/amd/display: fix NULL dereference

2023-11-13 Thread José Pekkarinen
The following patch will fix a minor issue where a debug message is referencing an struct that has just being checked whether is null or not. This has been noticed by using coccinelle, in the following output: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c:540:25-29: ERROR: aconnector

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-13 Thread Stephen Rothwell
Hi Luben, BTW, cherry picking commits does not avoid conflicts - in fact it can cause conflicts if there are further changes to the files affected by the cherry picked commit in either the tree/branch the commit was cheery picked from or the destination tree/branch (I have to deal with these all

linux-next: manual merge of the drm-misc tree with Linus' tree

2023-11-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/accel/ivpu/ivpu_drv.c between commit: 828d63042aec ("accel/ivpu: Don't enter d0i3 during FLR") from Linus' tree and commit: 57c7e3e4800a ("accel/ivpu: Stop job_done_thread on suspend") from the drm-misc

linux-next: manual merge of the drm-misc tree with Linus' tree

2023-11-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/accel/ivpu/ivpu_ipc.c between commit: b0873eead1d1 ("accel/ivpu: Do not use wait event interruptible") from Linus' tree and commit: 57c7e3e4800a ("accel/ivpu: Stop job_done_thread on suspend") from the

linux-next: manual merge of the drm-misc tree with Linus' tree

2023-11-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/accel/ivpu/ivpu_job.c between commit: 6309727ef271 ("kthread: add kthread_stop_put") from Linus' tree and commit: 57c7e3e4800a ("accel/ivpu: Stop job_done_thread on suspend") from the drm-misc tree. I

Re: [PATCH] Revert "drm/sched: Define pr_fmt() for DRM using pr_*()"

2023-11-13 Thread Luben Tuikov
On 2023-11-11 06:33, Jani Nikula wrote: > On Sat, 11 Nov 2023, Luben Tuikov wrote: >> From Jani: >> The drm_print.[ch] facilities use very few pr_*() calls directly. The >> users of pr_*() calls do not necessarily include at >> all, and really don't have to. >> >> Even the ones that do include

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2023-11-13 Thread Alexander Stein
Hi Michael, Am Montag, 13. November 2023, 17:43:44 CET schrieb Michael Walle: > The FORCE_STOP_STATE bit is unsuitable to force the DSI link into LP-11 > mode. It seems the bridge internally queues DSI packets and when the > FORCE_STOP_STATE bit is cleared, they are sent in close succession >

[PATCH] mm/gup: Introduce pin_user_pages_fd() for pinning shmem/hugetlbfs file pages (v3)

2023-11-13 Thread Vivek Kasireddy
For drivers that would like to longterm-pin the pages associated with a file, the pin_user_pages_fd() API provides an option to not only pin the pages via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API currently works with files that belong to

Re: [PATCH] drm/sched: Define pr_fmt() for DRM using pr_*()

2023-11-13 Thread Luben Tuikov
Hi Jani, On 2023-11-10 07:40, Jani Nikula wrote: > On Thu, 09 Nov 2023, Luben Tuikov wrote: >> Define pr_fmt() as "[drm] " for DRM code using pr_*() facilities, especially >> when no devices are available. This makes it easier to browse kernel logs. > > Please do not merge patches before people

[PATCH v2] drm/i915: correct the input parameter on _intel_dsb_commit()

2023-11-13 Thread heminhong
Current, the dewake_scanline variable is defined as unsigned int, an unsigned int variable that is always greater than or equal to 0. when _intel_dsb_commit function is called by intel_dsb_commit function, the dewake_scanline variable may have an int value. So the dewake_scanline variable is

[V3] drm/panel: auo,b101uan08.3: Fine tune the panel power sequence

2023-11-13 Thread Xuxin Xiong
For "auo,b101uan08.3" this panel, it is stipulated in the panel spec that MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high. Fixes: 56ad624b4cb5 ("drm/panel: support for auo, b101uan08.3 wuxga dsi video mode panel") Signed-off-by: Xuxin Xiong --- Changes in V3: -

Re: [PATCH 09/10] drm/ast: Detect ast device type and config mode without ast device

2023-11-13 Thread Thomas Zimmermann
Hi Am 13.11.23 um 16:25 schrieb Jocelyn Falempe: On 13/11/2023 09:50, Thomas Zimmermann wrote: Return the ast chip and config in the detection function's parameters instead of storing them directly in the ast device instance. Signed-off-by: Thomas Zimmermann ---  

[PATCH] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Abhinav Singh
This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not be directly dereferencing a rcu pointer, rather we should be using rcu helper function rcu_dereferece()

Re: [PATCH] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Maarten Lankhorst
Hey, Den 2023-11-13 kl. 09:10, skrev Abhinav Singh: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not be directly dereferencing a rcu pointer, rather we

[RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found

2023-11-13 Thread Javier Martinez Canillas
Some DT platforms use EFI to boot and in this case the EFI Boot Services may register a EFI_GRAPHICS_OUTPUT_PROTOCOL handle, that will later be queried by the Linux EFI stub to fill the global struct screen_info data. The data is used by the Generic System Framebuffers (sysfb) framework to add a

[PATCH 1/2] drm/i915: Remove return type from i915_drm_client_remove_object

2023-11-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin There is no need to return anything in the version which was merged and also the implementation of the !CONFIG_PROC_FS wasn't returning anything, causing a build failure there. Signed-off-by: Tvrtko Ursulin Fixes: e4ae85e364fc ("drm/i915: Add ability for tracking buffer

[PATCH 2/2] drm/i915: Add __rcu annotation to cursor when iterating client objects

2023-11-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin __rcu annotation is needed to avoid the sparse warnings such as: .../i915_drm_client.c:92:9: sparse: sparse: incompatible types in comparison expression (different address spaces): .../i915_drm_client.c:92:9: sparse:struct list_head [noderef] __rcu *

Re: [PATCH] Fix failure of simpledrm probe when trying to grab FB from the EFI-based Framebuffer

2023-11-13 Thread Thomas Zimmermann
Hi Javier Am 12.11.23 um 11:35 schrieb Javier Martinez Canillas: Andrew Worsley writes: Hello Andrew, On Sat, 11 Nov 2023 at 20:10, Javier Martinez Canillas wrote: On Sat, 11 Nov 2023 at 15:30, Andrew Worsley wrote: The simpledrm.c does not call

Re: [PATCH 3/8] accel/ivpu: Stop job_done_thread on suspend

2023-11-13 Thread Stanislaw Gruszka
Hi On Mon, Nov 13, 2023 at 08:39:42AM +0100, Daniel Vetter wrote: > This conflicts with the kthread change in 6.7-rc1 6309727ef271 > ("kthread: add kthread_stop_put") > > Please double-check that the conflict resolution I've done in drm-tip > is correct and then ask drm-misc/accel maintainers to

Re: [RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found

2023-11-13 Thread Thomas Zimmermann
Am 13.11.23 um 09:51 schrieb Javier Martinez Canillas: Some DT platforms use EFI to boot and in this case the EFI Boot Services may register a EFI_GRAPHICS_OUTPUT_PROTOCOL handle, that will later be queried by the Linux EFI stub to fill the global struct screen_info data. The data is used by

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Simon Ser
On Monday, October 23rd, 2023 at 10:25, Simon Ser wrote: > > > > > > > > > > +An atomic commit with the flag DRM_MODE_PAGE_FLIP_ASYNC is > > > > > > > > > > allowed to > > > > > > > > > > +effectively change only the FB_ID property on any planes. > > > > > > > > > > No-operation changes > > >

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Simon Ser
On Monday, November 13th, 2023 at 10:38, Pekka Paalanen wrote: > On Mon, 13 Nov 2023 09:18:39 + > Simon Ser cont...@emersion.fr wrote: > > > On Monday, October 23rd, 2023 at 10:25, Simon Ser cont...@emersion.fr wrote: > > > > > > > > > > > > > > +An atomic commit with the flag > > > > >

Re: [PATCH v18 22/26] drm/shmem-helper: Don't free refcounted GEM

2023-11-13 Thread Boris Brezillon
On Mon, 30 Oct 2023 02:02:01 +0300 Dmitry Osipenko wrote: > Don't free refcounted shmem object to prevent use-after-free bug that > is worse than a memory leak. > > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/drm_gem_shmem_helper.c | 7 --- > 1 file changed, 4 insertions(+), 3

Re: [PATCH 4/5] accel/ivpu: Use dedicated work for job timeout detection

2023-11-13 Thread Jacek Lawrynowicz
Hi, On 10.11.2023 05:35, Jeffrey Hugo wrote: > On 11/7/2023 5:35 AM, Jacek Lawrynowicz wrote: >> From: Stanislaw Gruszka >> >> Change to use work for timeout detection. Needed for thread_irq >> conversion. >> >> Signed-off-by: Stanislaw Gruszka > > Missing SOB. Yeah, I've missed it. I will

[PATCH v2] drm/loongson: Add platform dependency

2023-11-13 Thread Jean Delvare
Only offer the Loongson DRM driver as an option on platforms where it makes sense. Signed-off-by: Jean Delvare Cc: Sui Jingfeng Cc: David Airlie Cc: Daniel Vetter --- Changes since v1: * Use the architecture dependencies suggested by Sui Jingfeng. drivers/gpu/drm/loongson/Kconfig |1 +

[PATCH 07/10] drm/ast: Partially implement POST without ast device instance

2023-11-13 Thread Thomas Zimmermann
We'll have to do some of the GPU POSTing for detecting the ast device type. Make this work without an instance of the ast device. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 2 +- drivers/gpu/drm/ast/ast_main.c | 2 +- drivers/gpu/drm/ast/ast_post.c | 73

[PATCH 10/10] drm/ast: Move detection code into PCI probe helper

2023-11-13 Thread Thomas Zimmermann
Detect device type and config mode in the PCI probe helper, but leave DRM device initialization where it is. Structures the driver probe and setup code into a detection and an initialization phase. A later patch can add branching to th device-initialization code. Each chip type can have it own

[PATCH 06/10] drm/ast: Enable MMIO without ast device instance

2023-11-13 Thread Thomas Zimmermann
We'll have to enable the MMIO access for detecting the ast device type. Make this work without an instance of the ast device. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 16 +--- drivers/gpu/drm/ast/ast_reg.h | 2 ++ 2 files changed, 11 insertions(+), 7

[PATCH 04/10] drm/ast: Add I/O helpers without ast device

2023-11-13 Thread Thomas Zimmermann
Implement I/O access in helpers that do now use an ast device instance, but the raw pointer to the I/O memory. We'll later need these helpers to detect the device type before allocating the ast device instance. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 73

[PATCH 08/10] drm/ast: Add enum ast_config_mode

2023-11-13 Thread Thomas Zimmermann
The config mode used to be a field in struct ast_device. Turn it into a named type. We'll need this for device detection. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

[PATCH 03/10] drm/ast: Retrieve I/O-memory ranges without ast device

2023-11-13 Thread Thomas Zimmermann
Read the I/O-memory ranges into local variables before setting them in the ast device instanace. We'll later need this to split detecting the device type from the creation of the ast device instance. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 17 +++-- 1

[PATCH 09/10] drm/ast: Detect ast device type and config mode without ast device

2023-11-13 Thread Thomas Zimmermann
Return the ast chip and config in the detection function's parameters instead of storing them directly in the ast device instance. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 104 ++--- 1 file changed, 57 insertions(+), 47 deletions(-) diff

[PATCH 05/10] drm/ast: Enable VGA without ast device instance

2023-11-13 Thread Thomas Zimmermann
We'll have to enable the VGA functionality for detecting the ast device type. Make this work without an instance of the ast device. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 29 - drivers/gpu/drm/ast/ast_reg.h | 9 +++-- 2 files

[PATCH 00/10] drm/ast: Detect device type before init

2023-11-13 Thread Thomas Zimmermann
Detecting the ast device's chipset type and configuration mode involves several registers, DT properties and possibly POSTing parts of the chip. It is preferable to do this before initializing the DRM driver, so that that each chip type can have an individual setup code. The patchset addresses

[PATCH 01/10] drm/ast: Turn ioregs_lock to modeset_lock

2023-11-13 Thread Thomas Zimmermann
The lock for the I/O registers is only relevant during mode-setting operations. It protects the registers from concurrent access from reading EDID information. Reduce lock coverage to mode setting, rename the lock and move it entirely into the mode-setting code. No functional changes, as the I/O

[PATCH 02/10] drm/ast: Rework I/O register setup

2023-11-13 Thread Thomas Zimmermann
There are three different ways of retrieving the I/O-memory ranges for AST devices: either from PCI BAR 1, from PCI BAR 2 or from PCI BAR 1 by 'guessing'. Make the respective code more readable by making each case self- contained. Also add error checking against the length of the PCI BARs.

Re: (subset) [PATCH v5 0/5] ppc, fbdev: Clean up fbdev mmap helper

2023-11-13 Thread Thomas Zimmermann
Am 13.11.23 um 03:45 schrieb Michael Ellerman: On Fri, 22 Sep 2023 10:04:54 +0200, Thomas Zimmermann wrote: Clean up and rename fb_pgprotect() to work without struct file. Then refactor the implementation for PowerPC. This change has been discussed at [1] in the context of refactoring fbdev's

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Simon Ser
On Monday, November 13th, 2023 at 10:41, Michel Dänzer wrote: > On 11/13/23 10:18, Simon Ser wrote: > > > On Monday, October 23rd, 2023 at 10:25, Simon Ser cont...@emersion.fr wrote: > > > > > > > > > > > > > > +An atomic commit with the flag > > > > > > > > > > > > DRM_MODE_PAGE_FLIP_ASYNC

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Michel Dänzer
On 11/13/23 10:47, Simon Ser wrote: > On Monday, November 13th, 2023 at 10:41, Michel Dänzer > wrote: > >> On 11/13/23 10:18, Simon Ser wrote: >> >>> On Monday, October 23rd, 2023 at 10:25, Simon Ser cont...@emersion.fr wrote: >>> > +An atomic commit with the flag

Re: [PATCH v18 24/26] drm/virtio: Attach shmem BOs dynamically

2023-11-13 Thread Boris Brezillon
On Mon, 30 Oct 2023 02:02:03 +0300 Dmitry Osipenko wrote: > Prepare for addition of memory shrinker support by attaching shmem pages > to host dynamically on first use. Previously the attachment vq command > wasn't fenced and there was no vq kick made in the BO creation code path, > hence the

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-11-13 Thread Pekka Paalanen
On Mon, 13 Nov 2023 09:44:15 + Simon Ser wrote: > On Monday, November 13th, 2023 at 10:38, Pekka Paalanen > wrote: > > > On Mon, 13 Nov 2023 09:18:39 + > > Simon Ser cont...@emersion.fr wrote: > > > > > On Monday, October 23rd, 2023 at 10:25, Simon Ser cont...@emersion.fr > > >

[PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: remove I2C_CLASS_DDC support

2023-11-13 Thread Heiner Kallweit
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

  1   2   >