Re: Flickering screen in Neverball on drm-radeon-testing

2010-06-02 Thread Mario Kleiner
, but maybe this points into the right direction? best, -mario * Mario Kleiner Max Planck Institute for Biological Cybernetics Spemannstr. 38 72076 Tuebingen Germany e-mail: mario.klei...@tuebingen.mpg.de office: +49 (0)7071/601

Re: Flickering screen in Neverball on drm-radeon-testing

2010-06-06 Thread Mario Kleiner
On Jun 4, 2010, at 7:27 PM, Michel Dänzer wrote: On Mit, 2010-06-02 at 16:38 +0200, Mario Kleiner wrote: I think your analysis is spot on. The ideal solution would probably be to make the kernel block in the command stream (CS) submission ioctl if the CS renders to (and from?) a buffer

Re: [Bug 28383] New: Cloned screens with different res/refresh cause problems with mesa demos since new dri2 vsync.

2010-06-08 Thread Mario Kleiner
On Jun 4, 2010, at 4:02 PM, dri-devel-requ...@lists.freedesktop.org wrote: Message: 2 Date: Fri, 4 Jun 2010 04:28:02 -0700 (PDT) From: bugzilla-dae...@freedesktop.org Subject: [Bug 28383] New: Cloned screens with different res/refresh cause problems with mesa demos since new dri2

DRM Vblank timestamping patches. 1st Try.

2010-10-24 Thread Mario Kleiner
Hi all, after obsessing over these for another month after xds 2010, this is the first version of my vblank timestamping patches that i'm not totally ashamed off. 1st patch modifies the drm vblank handling to maintain precise timestamps of when vblanks happen. It timestamps the end of each

[PATCH] drm-vblank: Always return true vblank count of scheduled vblank event.

2010-12-10 Thread Mario Kleiner
Original Message Subject: [PATCH] drm-vblank: Always return true vblank count of scheduled vblank event. Date: Fri, 10 Dec 2010 15:58:10 +0100 From: Mario Kleiner mario.klei...@tuebingen.mpg.de To: airl...@gmail.com CC: jbar...@virtuousgeek.org, k...@bitplanet.net, Mario

Re: [PATCH] drm-vblank: Always return true vblank count of scheduled vblank event.

2010-12-13 Thread Mario Kleiner
On Dec 10, 2010, at 6:45 PM, Jesse Barnes wrote: On Fri, 10 Dec 2010 16:00:19 +0100 Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: Original Message Subject: [PATCH] drm-vblank: Always return true vblank count of scheduled vblank event. Date: Fri, 10 Dec 2010 15:58:10

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-21 Thread Mario Kleiner
high level of precision and robustness in vblank counting and timestamping for neuro-science applications and similar stuff. thanks, -mario * Mario Kleiner Max Planck Institute for Biological Cybernetics Spemannstr. 38 72076

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-22 Thread Mario Kleiner
On Dec 22, 2010, at 6:23 PM, Jesse Barnes wrote: On Wed, 22 Dec 2010 05:36:13 +0100 Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: -- Message: 1 Date: Mon, 20 Dec 2010 19:23:40 -0800 From: Keith Packard kei

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-26 Thread Mario Kleiner
On Dec 26, 2010, at 3:53 PM, Andrew Lutomirski wrote: On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: There's a new drm module parameter for selecting the timeout: echo 50 /sys/module/drm/parameters/vblankoffdelay would set the timeout to 50 msecs

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-27 Thread Mario Kleiner
On Dec 27, 2010, at 12:16 PM, Ville Syrjälä wrote: On Mon, Dec 27, 2010 at 12:58:10AM +0100, Mario Kleiner wrote: 2. There are gpu's firing spurious vblank irq's as soon as you enable irq's You're sure this isn't simply a matter of the driver forgetting to ack the irq just before enabling

Re: [PATCH] drm/i915: Disable high-precision vblank timestamping

2011-01-23 Thread Mario Kleiner
Oops! Have missed that. Thanks for fixing it. Reviewed-by: Mario Kleiner mario.klei...@tuebingen.mpg.de * Mario Kleiner Max Planck Institute for Biological Cybernetics Spemannstr. 38 72076 Tuebingen Germany e-mail: mario.klei

[PATCH 1/3] drm/vblank: Use abs64(diff_ns) for s64 diff_ns instead of abs(diff_ns)

2011-02-20 Thread Mario Kleiner
Use of abs() wrongly wrapped diff_ns to 32 bit, which gives a 1/4000 probability of a missed vblank increment at each vblank irq reenable if the kms driver doesn't support high precision vblank timestamping. Not a big deal in practice, but let's make it nice. Signed-off-by: Mario Kleiner

[PATCH 2/3] drm/vblank: Use memory barriers optimized for atomic_t instead of generics.

2011-02-20 Thread Mario Kleiner
Documentation/atomic_ops.txt tells us that there are memory barriers optimized for atomic_inc and other atomic_t ops. Use these instead of smp_wmb(), and also to make the required memory barriers around vblank counter increments more explicit. Signed-off-by: Mario Kleiner mario.klei

[PATCH 3/3] drm/vblank: Enable precise vblank timestamps for interlaced and doublescan modes.

2011-02-20 Thread Mario Kleiner
Testing showed the current code can already handle doublescan video modes just fine. A trivial tweak makes it work for interlaced scanout as well. Tested and shown to be precise on Radeon rv530, r600 and Intel 945-GME. Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de --- drivers/gpu

Re: dri-devel Digest, Vol 12, Issue 16

2011-03-04 Thread Mario Kleiner
. Maybe a new ddx could check the (bumped) drm abi version number to decide if it should use the new or old method to protect against the new ddx on old kernel case? Add a ... Reviewed-by: Mario Kleiner mario.klei...@tuebingen.mpg.de ...and a big ... Acked-by: Mario Kleiner mario.klei

Re: dri-devel Digest, Vol 12, Issue 16

2011-03-04 Thread Mario Kleiner
On Mar 4, 2011, at 5:24 PM, Michel Dänzer wrote: On Fre, 2011-03-04 at 17:19 +0100, Mario Kleiner wrote: Maybe it would be even possible to slip the small kernel patch into 2.6.38-rc? It is rather a bugfix than a new feature. Not really. The vblank ioctl never pretended to support more than

Re: [PATCH] kernel/drm: vblank wait on crtc 1

2011-03-19 Thread Mario Kleiner
On Fri, 18 Mar 2011, Jesse Barnes wrote: I like the new param check, but I'd still prefer a new ioctl to abusing the old one. It's not abusing it but extending the interface in a backwards-compatible manner. Introducing a new one would result in two ioctls that essentially do the same

Re: [PATCH 2/3] drm: Warn if vblank state has become inconsistent.

2011-04-27 Thread Mario Kleiner
having the refcount non-zero there is not really a sign of inconsistency, so i'm not sure if a warning is appropriate there. -mario * Mario Kleiner Max Planck Institute for Biological Cybernetics Spemannstr. 38 72076 Tuebingen

Re: [PATCH 2/3] drm: Warn if vblank state has become inconsistent.

2011-04-28 Thread Mario Kleiner
On Apr 28, 2011, at 9:47 AM, Christopher James Halse Rogers wrote: On Wed, 2011-04-27 at 17:50 +0200, Mario Kleiner wrote: On Apr 27, 2011, at 10:58 AM, dri-devel-requ...@lists.freedesktop.org wrote: Message: 5 Date: Wed, 27 Apr 2011 10:38:14 +0200 From: Michel D?nzer mic...@daenzer.net

Re: [RFC] swap event handling fixes

2011-04-29 Thread Mario Kleiner
On Apr 29, 2011, at 11:37 PM, Jesse Barnes wrote: On Thu, 28 Apr 2011 13:27:18 -0700 Jesse Barnes jbar...@virtuousgeek.org wrote: I obviously failed to count the swap event structure size after adding and removing fields a few times, and didn't even account for padding. The end result is

Re: [PATCH] drm/radeon: make crtc number check in radeon_get_vblank_timestamp_kmsconsistent with other functions

2011-05-06 Thread Mario Kleiner
in all other functions that handle crtc Looks good to me. Mario, any reason why we should use the dev version rather than the rdev version? No, perfectly fine with me. Reviewed-by: Mario Kleiner mario.klei...@tuebingen.mpg.de Reviewed-by: Alex Deucher alexdeuc...@gmail.com Signed-off

Re: [PATCH v2 4/5] DRI2: Expose API to set drawable swap limit.

2011-09-14 Thread Mario Kleiner
On Sep 15, 2011, at 12:54 AM, Francisco Jerez wrote: Mario Kleiner mario.klei...@tuebingen.mpg.de writes: On Sep 14, 2011, at 6:02 PM, Keith Packard wrote: On Wed, 14 Sep 2011 10:05:29 -0500, Jesse Barnes jbar...@virtuousgeek.org wrote: Ah thanks Mario, I blame Keith. :p I agree we

Re: [PATCH v2 4/5] DRI2: Expose API to set drawable swap limit.

2011-10-06 Thread Mario Kleiner
On Oct 6, 2011, at 5:42 PM, Jesse Barnes wrote: On Thu, 15 Sep 2011 01:31:00 +0200 Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: On Sep 15, 2011, at 12:54 AM, Francisco Jerez wrote: Mario Kleiner mario.klei...@tuebingen.mpg.de writes: On Sep 14, 2011, at 6:02 PM, Keith Packard

Re: [PATCH 3/3] drm: do not sleep on vblank while holding a mutex

2011-10-28 Thread Mario Kleiner
* Mario Kleiner Max Planck Institute for Biological Cybernetics Spemannstr. 38 72076 Tuebingen Germany e-mail: mario.klei...@tuebingen.mpg.de office: +49 (0)7071/601-1623 fax:+49 (0)7071/601-616 www:http

Re: [PATCH 3/3] drm: do not sleep on vblank while holding a mutex

2011-10-28 Thread Mario Kleiner
On Oct 28, 2011, at 9:15 PM, Daniel Vetter wrote: On Fri, Oct 28, 2011 at 08:15:11PM +0200, Mario Kleiner wrote: be careful with vblank_refcount. I think it probably should stay atomic. The drm_vblank_put() is often used in interrupt handlers of the kms drivers where you don't want

Re: [RFC] Reduce idle vblank wakeups

2011-11-16 Thread Mario Kleiner
* Mario Kleiner Max Planck Institute for Biological Cybernetics Spemannstr. 38 72076 Tuebingen Germany e-mail: mario.klei...@tuebingen.mpg.de office: +49 (0)7071/601-1623 fax:+49 (0)7071/601-616 www:http

Re: [RFC] Reduce idle vblank wakeups

2011-11-16 Thread Mario Kleiner
On Nov 16, 2011, at 7:48 PM, Matthew Garrett wrote: On Wed, Nov 16, 2011 at 07:27:51PM +0100, Mario Kleiner wrote: It's not broken hardware, but fast ping-ponging it on and off can make the vblank counter and vblank timestamps unreliable for apps that need high timing precision, especially

Re: [RFC] Reduce idle vblank wakeups

2011-11-17 Thread Mario Kleiner
On Nov 17, 2011, at 3:19 AM, Matthew Garrett wrote: On Thu, Nov 17, 2011 at 01:26:37AM +0100, Mario Kleiner wrote: On Nov 16, 2011, at 7:48 PM, Matthew Garrett wrote: I'll admit that I'm struggling to understand the issue here. If the vblank counter is incremented at the time of vblank (which

Re: [PATCH 1/3] drm/radeon/kms: add some loop timeouts in pageflip code

2011-11-28 Thread Mario Kleiner
alexander.deuc...@amd.com Cc: sta...@kernel.org Cc: Mario Kleiner mario.klei...@tuebingen.mpg.de --- drivers/gpu/drm/radeon/evergreen.c |7 ++- drivers/gpu/drm/radeon/r100.c |7 ++- drivers/gpu/drm/radeon/rs600.c |7 ++- drivers/gpu/drm/radeon/rv770.c |7

[PATCH 1/2] drm/nouveau: Use drm_vblank_count_and_time() for pageflip completion events.

2012-02-15 Thread Mario Kleiner
Emit kms pageflip completion events with proper vblank count and timestamp for the vblank interval in which the pageflip completed. This makes the timestamps and counts consistent with what the OML_sync_control spec defines. Signed-off-by: Mario Kleiner mario.klei...@tuebingen.mpg.de --- drivers

[PATCH 2/2] nouveau: implement precise vblank timestamping

2012-02-15 Thread Mario Kleiner
timestamps (compliant to OML_sync_control spec) Kudos to Mario for his many helpful comments and testing. Signed-off-by: Lucas Stach d...@lynxeye.de Reviewed-by: Mario Kleiner mario.klei...@tuebingen.mpg.de Tested-by: Mario Kleiner mario.klei...@tuebingen.mpg.de --- drivers/gpu/drm/nouveau

Re: Flickering with page-flipping on Acer Iconia W500 (AMD C-50 APU)

2012-02-21 Thread Mario Kleiner
On 02/21/2012 09:07 PM, Alex Deucher wrote: On Wed, Feb 1, 2012 at 5:43 PM, Felix Kuehlingfelix.kuehl...@amd.com wrote: Following up on my message from Jan 19, now with a lot more hard data and a less intrusive modification. Still a prototype though. CC-ing DRI-devel and Mario Kleiner

Re: Flickering with page-flipping on Acer Iconia W500 (AMD C-50 APU)

2012-02-24 Thread Mario Kleiner
On Feb 24, 2012, at 10:20 PM, Felix Kuehling wrote: On 12-02-22 11:20 AM, Felix Kuehling wrote: On 12-02-21 07:49 PM, Mario Kleiner wrote: On 02/21/2012 09:07 PM, Alex Deucher wrote: [snip] The fix looks ok to me. Mario any thoughts? Reviewed-by: Alex Deucheralexdeuc...@gmail.com Hi

Re: Flickering with page-flipping on Acer Iconia W500 (AMD C-50 APU)

2012-02-28 Thread Mario Kleiner
On Feb 27, 2012, at 4:47 PM, Felix Kuehling wrote: On 12-02-24 11:38 PM, Mario Kleiner wrote: On Feb 24, 2012, at 10:20 PM, Felix Kuehling wrote: On 12-02-22 11:20 AM, Felix Kuehling wrote: On 12-02-21 07:49 PM, Mario Kleiner wrote: On 02/21/2012 09:07 PM, Alex Deucher wrote: [snip

Re: RFC: Change OML_sync_control UST to CLOCK_MONOTONIC

2012-06-14 Thread Mario Kleiner
Message: 2 Date: Thu, 14 Jun 2012 17:19:11 + (UTC) From: Joakim Plate elu...@ecce.se Subject: Re: RFC: Change OML_sync_control UST to CLOCK_MONOTONIC To: dri-devel@lists.freedesktop.org Message-ID: loom.20120614t191057...@post.gmane.org Content-Type: text/plain; charset=us-ascii

Re: [RFC 0/4] drm: add raw monotonic timestamp support (Imre Deak)

2012-10-05 Thread Mario Kleiner
On 05.10.12 15:37, intel-gfx-requ...@lists.freedesktop.org wrote: Today's Topics: 1. [RFC 0/4] drm: add raw monotonic timestamp support (Imre Deak) 2. [RFC 1/4] time: export getnstime_raw_and_real for DRM (Imre Deak) 3. [RFC 2/4] drm: make memset/calloc for _vblank_time more

Re: [RFC 1/4] time: export getnstime_raw_and_real for DRM

2012-10-08 Thread Mario Kleiner
On 08.10.12 13:35, Imre Deak wrote: On Sat, 2012-10-06 at 03:41 +0200, Mario Kleiner wrote: [...] But then Psychtoolbox checks each timestamp it gets from somewhere outside (OML_sync_control / INTEL_swap_events / ALSA audio timestamps, network receive timestamps, evdev, x11

Re: [PATCH 10/11] drm/omap: use drm_send_vblank_event() helper

2012-10-09 Thread Mario Kleiner
On 08.10.12 21:50, Rob Clark wrote: From: Rob Clark r...@ti.com Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_crtc.c | 31 ++- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/staging/omapdrm/omap_crtc.c

Re: [PATCH 10/11] drm/omap: use drm_send_vblank_event() helper

2012-10-12 Thread Mario Kleiner
On 10.10.12 13:03, Rob Clark wrote: On Tue, Oct 9, 2012 at 10:33 PM, Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: On 08.10.12 21:50, Rob Clark wrote: From: Rob Clark r...@ti.com Signed-off-by: Rob Clark r...@ti.com --- drivers/staging/omapdrm/omap_crtc.c | 31

Re: [PATCH 01/11] drm: add drm_send_vblank_event() helper

2012-10-12 Thread Mario Kleiner
On 11.10.12 16:19, Laurent Pinchart wrote: Hi Rob, Thanks for the patch. On Monday 08 October 2012 14:50:39 Rob Clark wrote: From: Rob Clark r...@ti.com ... Do you know why some drivers don't call drm_vblank_count_and_time() ? For instance nouveau sets the sequence to 0 and uses

Re: [PATCH 1/2] drm: use monotonic time in drm_calc_vbltimestamp_from_scanoutpos

2012-10-24 Thread Mario Kleiner
On 23.10.12 20:53, Imre Deak wrote: For measuring duration we want to avoid that our start/end timestamps jump, so use monotonic instead of real time for that. Signed-off-by: Imre Deak imre.d...@intel.com --- drivers/gpu/drm/drm_irq.c | 18 -- 1 file changed, 12

Re: [PATCH 1/2] drm: use monotonic time in drm_calc_vbltimestamp_from_scanoutpos

2012-10-25 Thread Mario Kleiner
On 25.10.12 12:28, Imre Deak wrote: On Thu, 2012-10-25 at 01:05 +0200, Mario Kleiner wrote: On 23.10.12 20:53, Imre Deak wrote: For measuring duration we want to avoid that our start/end timestamps jump, so use monotonic instead of real time for that. Signed-off-by: Imre Deak imre.d

Re: [PATCH] drm: reduce default drm vblank off delay to 50ms

2012-11-02 Thread Mario Kleiner
. Chris Wilson already gave me an off-list review for that patch series after i pinged him. Unfortunately a rather terse one, cited here: On Mon, 15 Oct 2012 16:46:52 +0200, Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: Hi Chris, can you please check merge at least the first two patches

Re: [PATCH] drm: reduce default drm vblank off delay to 50ms

2012-11-11 Thread Mario Kleiner
On 02.11.12 19:37, Jesse Barnes wrote: On Fri, 02 Nov 2012 06:56:57 +0100 Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: Jesse, thanks for cc'ing me, much appreciated :) Psychtoolbox should be fine with a 50 msecs vblank off delay. I think i tested with values somewhere between 50 - 100

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-01-22 Thread Mario Kleiner
On 22.01.13 09:31, Terje Bergström wrote: On 14.01.2013 18:06, Thierry Reding wrote: +static int tegra_dc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb, + struct drm_pending_vblank_event *event) +{ + struct tegra_framebuffer *newfb =

Re: [PATCH v2 4/5] drm/tegra: Implement VBLANK support

2013-01-22 Thread Mario Kleiner
On 22.01.13 19:39, Lucas Stach wrote: Am Dienstag, den 22.01.2013, 18:37 +0100 schrieb Mario Kleiner: On 14.01.13 17:05, Thierry Reding wrote: Implement support for the VBLANK IOCTL. Note that Tegra is somewhat special in this case because it doesn't use the generic IRQ support provided

Re: [PATCH v2 4/5] drm/tegra: Implement VBLANK support

2013-01-22 Thread Mario Kleiner
On 22.01.13 20:27, Jon Mayo wrote: On Tue, Jan 22, 2013 at 11:20 AM, Mario Kleiner mario.kleiner...@gmail.com wrote: On 22.01.13 19:39, Lucas Stach wrote: Am Dienstag, den 22.01.2013, 18:37 +0100 schrieb Mario Kleiner: On 14.01.13 17:05, Thierry Reding wrote: Implement support

Re: [PATCH v2 4/5] drm/tegra: Implement VBLANK support

2013-01-22 Thread Mario Kleiner
On 14.01.13 17:05, Thierry Reding wrote: Implement support for the VBLANK IOCTL. Note that Tegra is somewhat special in this case because it doesn't use the generic IRQ support provided by the DRM core (DRIVER_HAVE_IRQ) but rather registers one interrupt handler for each display controller.

Re: [PATCH v2 4/5] drm/tegra: Implement VBLANK support

2013-01-22 Thread Mario Kleiner
On 22.01.13 19:49, Jon Mayo wrote: On Tue, Jan 22, 2013 at 10:39 AM, Lucas Stach d...@lynxeye.de wrote: Am Dienstag, den 22.01.2013, 18:37 +0100 schrieb Mario Kleiner: On 14.01.13 17:05, Thierry Reding wrote: Implement support for the VBLANK IOCTL. Note that Tegra is somewhat special

Re: [PATCH 4/5] drm/tegra: Implement VBLANK support

2013-01-30 Thread Mario Kleiner
On 30.01.13 13:36, Daniel Vetter wrote: On Wed, Jan 30, 2013 at 9:34 AM, Thierry Reding thierry.red...@avionic-design.de wrote: On Tue, Jan 22, 2013 at 10:21:40AM -0800, Jon Mayo wrote: On Mon, Jan 14, 2013 at 7:55 AM, Thierry Reding thierry.red...@avionic-design.de wrote: Implement support

Re: [PATCH v2 5/5] drm/tegra: Implement page-flipping support

2013-02-15 Thread Mario Kleiner
On 02/11/2013 10:00 AM, Thierry Reding wrote: On Tue, Jan 22, 2013 at 06:27:24PM +0100, Mario Kleiner wrote: On 22.01.13 09:31, Terje Bergström wrote: On 14.01.2013 18:06, Thierry Reding wrote: +static int tegra_dc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb

Re: [PATCH v2 4/5] drm/tegra: Implement VBLANK support

2013-02-15 Thread Mario Kleiner
On 02/11/2013 10:13 AM, Thierry Reding wrote: On Tue, Jan 22, 2013 at 06:37:39PM +0100, Mario Kleiner wrote: On 14.01.13 17:05, Thierry Reding wrote: Implement support for the VBLANK IOCTL. Note that Tegra is somewhat special in this case because it doesn't use the generic IRQ support provided

Re: [PATCH v4 6/9] drm/tegra: Implement page-flipping support

2013-02-22 Thread Mario Kleiner
On 02/21/2013 03:35 PM, Thierry Reding wrote: All the necessary support bits like .mode_set_base() and VBLANK are now available, so page-flipping case easily be implemented on top. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de --- Changes in v3: - use drm_send_vblank_event() -

Re: [PATCH v4 6/9] drm/tegra: Implement page-flipping support

2013-02-28 Thread Mario Kleiner
On 02/25/2013 08:06 AM, Thierry Reding wrote: On Fri, Feb 22, 2013 at 05:13:47PM +0100, Mario Kleiner wrote: On 02/21/2013 03:35 PM, Thierry Reding wrote: All the necessary support bits like .mode_set_base() and VBLANK are now available, so page-flipping case easily be implemented on top

Re: BUG: sleeping function called from invalid context on 3.10.10-rt7

2013-09-23 Thread Mario Kleiner
? That the vblank timestamp needs to be an accurate measurement of a realtime event. Sleeping/servicing interrupts while reading the registers necessary to compute the timestamp would be bad too. (edit: which hopefully Mario Kleiner clarified in his reply) My point earlier was three-fold: 1. Don't

Re: [Intel-gfx] BUG: sleeping function called from invalid context on 3.10.10-rt7

2013-09-25 Thread Mario Kleiner
On 23.09.13 10:38, Ville Syrjälä wrote: On Sat, Sep 21, 2013 at 12:07:36AM +0200, Mario Kleiner wrote: On 09/17/2013 10:55 PM, Daniel Vetter wrote: On Tue, Sep 17, 2013 at 9:50 PM, Peter Hurley pe...@hurleysoftware.com wrote: On 09/11/2013 03:31 PM, Peter Hurley wrote: [+cc dri-devel

Re: [Intel-gfx] BUG: sleeping function called from invalid context on 3.10.10-rt7

2013-09-26 Thread Mario Kleiner
On 25.09.13 16:13, Steven Rostedt wrote: On Wed, 25 Sep 2013 06:32:10 +0200 Mario Kleiner mario.klei...@tuebingen.mpg.de wrote: But given the new situation, your proposal is great! If we push the clock readouts into the get_scanoutpos routine, we can make this robust without causing grief

Re: [Intel-gfx] BUG: sleeping function called from invalid context on 3.10.10-rt7

2013-09-26 Thread Mario Kleiner
On 25.09.13 09:49, Ville Syrjälä wrote: On Wed, Sep 25, 2013 at 06:32:10AM +0200, Mario Kleiner wrote: On 23.09.13 10:38, Ville Syrjälä wrote: On Sat, Sep 21, 2013 at 12:07:36AM +0200, Mario Kleiner wrote: On 09/17/2013 10:55 PM, Daniel Vetter wrote: On Tue, Sep 17, 2013 at 9:50 PM, Peter

Re: [Intel-gfx] BUG: sleeping function called from invalid context on 3.10.10-rt7

2013-10-12 Thread Mario Kleiner
On 10/11/2013 03:30 PM, Sebastian Andrzej Siewior wrote: On 10/11/2013 02:37 PM, Steven Rostedt wrote: On Fri, 11 Oct 2013 12:18:00 +0200 Sebastian Andrzej Siewior bige...@linutronix.de wrote: * Mario Kleiner | 2013-09-26 18:16:47 [+0200]: Good! I will do that. Thanks for clarifying the irq

Re: [PATCH 2/2] drm/nouveau: Queue hpd_work on (runtime) resume

2017-01-23 Thread Mario Kleiner
On 11/21/2016 05:50 PM, Hans de Goede wrote: We need to call drm_helper_hpd_irq_event() on resume to properly detect monitor connection / disconnection on some laptops, use hpd_work for this to avoid deadlocks. Hi, this seems to introduce a hang of nouveau in 4.10-rc if the gpu is runtime

[PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-10-28 Thread Mario Kleiner
On 10/28/2016 03:34 AM, Michel Dänzer wrote: > On 27/10/16 10:33 PM, Mike Lothian wrote: >> >> Just another gentle ping to see where you are with this? > > I haven't got a chance to look into this any further. > > Fwiw., as a proof of concept, the attached experimental patch does work as

[PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-09-08 Thread Mario Kleiner
-kms for correct prime sync during pageflipping under DRI3/Present. Should fix https://bugs.freedesktop.org/show_bug.cgi?id=95472 at least for page-flipped presentation. Suggested-by: Michel Dänzer Signed-off-by: Mario Kleiner Cc: Michel Dänzer Cc: Chris Wilson Cc: Daniel Vetter Cc: David

[PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-09-08 Thread Mario Kleiner
On 09/08/2016 08:30 AM, Chris Wilson wrote: > On Thu, Sep 08, 2016 at 02:14:43AM +0200, Mario Kleiner wrote: >> amdgpu-kms uses shared fences for its prime exported dmabufs, >> instead of an exclusive fence. Therefore we need to wait for >> all fences of the dmabuf reservat

Patches to go on top of Michels page_flip_target patches.

2016-09-17 Thread Mario Kleiner
Hi, testing on "simulated" pre-DCE4 radeon hw (via setting the module parameter radeon.use_pflipirq=0 to avoid use of pflip irqs) showed we need some adjustments on top of Michel's page_flip_target patches on these old asics. Patch 2/2: Essentially disabling the ability to flip anywhere in

[PATCH 2/2] drm/radeon: Prevent races on pre DCE4 between flip submission and completion.

2016-09-17 Thread Mario Kleiner
ere in vblank. Therefore delay the actual flip programming until after vblank on pre-AVIVO. Signed-off-by: Mario Kleiner --- drivers/gpu/drm/radeon/atombios_crtc.c | 4 ++-- drivers/gpu/drm/radeon/radeon_display.c | 17 ++--- drivers/gpu/drm/radeon/rv515.c | 3 ++- 3 fi

[PATCH 1/2] drm/radeon: Slightly more robust flip completion handling for < DCE-4

2016-09-17 Thread Mario Kleiner
threshold. This completion path is still prone to some races in corner cases, especially on pre-AVIVO hardware, so document them a bit better in the code comments. Signed-off-by: Mario Kleiner --- drivers/gpu/drm/radeon/radeon_display.c | 30 ++ 1 file changed, 22

[PATCH 4/6] drm/radeon: Provide page_flip_target hook

2016-09-17 Thread Mario Kleiner
Hi Michel, all your patches, both the already merged kernel bits in radeon/amdgpu and also all the userspace bits in libdrm/ati-ddx/amdgpu-ddx are all Reviewed-and-tested-by: Mario Kleiner I successfully tested with old/current userspace and the new userspace patches from your own libdrm/ati

[PATCH 18/28] drm: avoid uninitialized timestamp use in wait_vblank

2016-10-18 Thread Mario Kleiner
unt; > unsigned int seq; > > - if (WARN_ON(pipe >= dev->num_crtcs)) > + if (WARN_ON(pipe >= dev->num_crtcs)) { > + *vblanktime = (struct timeval) { 0 }; > return 0; > + } > > do { > seq = read_seqbegin(>seqlock); > Looks good to me. Reviewed-by: Mario Kleiner -mario

[PATCH 01/19] drm/core: Add drm_accurate_vblank_count, v4.

2016-04-25 Thread Mario Kleiner
gt; Changes since v1: > - Take vblank_time_lock and don't use drm_vblank_count_and_time. > Changes since v2: > - Don't return time of last vblank. > Changes since v3: > - Change pipe to unsigned int. (Ville) > - Remove unused documentation for tv_ret. (kbuild) > > Cc: Mario Kleiner >

[PATCH 07/14] drm/nouveau: use drm_crtc_send_vblank_event()

2016-04-25 Thread Mario Kleiner
On 04/14/2016 07:48 PM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Replace the legacy drm_send_vblank_event() with the new helper function. > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/nouveau/nouveau_display.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >

[PATCH 01/19] drm/core: Add drm_accurate_vblank_count, v5.

2016-04-25 Thread Mario Kleiner
is useful. > - Add a WARN_ON when get_vblank_timestamp is unavailable. > - Use drm_vblank_count. > > Cc: Mario Kleiner > Cc: Ville Syrjälä > Signed-off-by: Maarten Lankhorst > Reviewed-by: Ville Syrjälä #v4 > Acked-by: David Airlie #irc, v4 > --- > > Unfortunat

[PATCH 01/19] drm/core: Add drm_accurate_vblank_count, v5.

2016-04-28 Thread Mario Kleiner
Anyway, although i would have liked the stricter check and warning docs, the v4 patch is ok with me: Reviewed-by: Mario Kleiner -mario On 04/25/2016 08:32 AM, Maarten Lankhorst wrote: > This function is useful for gen2 intel devices which have no frame > counter, but need a way to det

[PATCH 4/5] drm/intel/dp: Try harder to get bpc of a DP sink if EDID doesn't tell.

2016-08-03 Thread Mario Kleiner
On 08/03/2016 08:09 AM, Daniel Vetter wrote: > On Wed, Aug 03, 2016 at 01:07:12PM +1000, Dave Airlie wrote: >> On 6 July 2016 at 20:05, Mario Kleiner wrote: >>> For DP sinks which don't expose color depth via EDID, use >>> the drm_dp_sink_bpc() helper to

[PATCH 4/5] drm/intel/dp: Try harder to get bpc of a DP sink if EDID doesn't tell.

2016-08-07 Thread Mario Kleiner
On 08/03/2016 02:03 PM, Mario Kleiner wrote: > On 08/03/2016 08:09 AM, Daniel Vetter wrote: >> On Wed, Aug 03, 2016 at 01:07:12PM +1000, Dave Airlie wrote: >>> On 6 July 2016 at 20:05, Mario Kleiner >>> wrote: >>>> For DP sinks which don't expose color depth

[PATCH 4/6] drm/radeon: Provide page_flip_target hook

2016-08-16 Thread Mario Kleiner
Hi Michel, sorry for the super-late reply, i was just catching up with all the mails and discussions, starting in June, leading to this patch set. Looks all pretty good. I'll look at this radeon patch and 2/6 for amdgpu later this week when i have a fresh brain and enough "obsessive

[PATCH 6/6] drm: Add DRM_MODE_PAGE_FLIP_TARGET_ABSOLUTE/RELATIVE flags v2

2016-08-16 Thread Mario Kleiner
Cc'ing Daniel Stone and Pekka Paalanen, because this relates to wayland. Wrt. having a new pageflip parameter struct, i wonder if it wouldn't make sense to then already prepare some space in it for specifying an absolute target time, e.g., in u64 microseconds? Or make this part of the atomic

"Fixes" for page flipping under PRIME on AMD & nouveau

2016-08-17 Thread Mario Kleiner
Hi, i spent some time playing with DRI3/Present + PRIME for testing how well it works for Optimus/Enduro style setups wrt. page flipping on the current kernel/mesa/xorg. I want page flipping, because neuroscience/medical applications need the reliable timing/timestamping and tear free

[PATCH 1/2] drm/nouveau: Fix pageflipping of PRIME imported scanout bo's.

2016-08-17 Thread Mario Kleiner
back to GTT, then unpinning again, so the followup pinning into VRAM will actually upload an up to date display buffer from dmabuf GTT backing store. During the pinning into GTT, we skip the actual data move from VRAM to GTT to avoid a needless bo copy of stale image data. Signed-off-by: Mario

[PATCH 2/2] drm/radeon: Fix pageflipping of PRIME imported scanout bo's.

2016-08-17 Thread Mario Kleiner
back to GTT, then unpinning again, so the followup pinning into VRAM will actually upload an up to date display buffer from dmabuf GTT backing store. During the pinning into GTT, we skip the actual data move from VRAM to GTT to avoid a needless bo copy of stale image data. Signed-off-by: Mario

"Fixes" for page flipping under PRIME on AMD & nouveau

2016-08-17 Thread Mario Kleiner
efresh from the up to date dmabuf in system RAM. Btw. i'll be offline for the next few hours, just wanted to get this out now. thanks, -mario > > Regards, > Christian. > > Am 17.08.2016 um 18:12 schrieb Mario Kleiner: >> Hi, >> >> i spent some time playing with DR

"Fixes" for page flipping under PRIME on AMD & nouveau

2016-08-18 Thread Mario Kleiner
On 08/17/2016 07:02 PM, Christian König wrote: > Am 17.08.2016 um 18:35 schrieb Mario Kleiner: >> On 08/17/2016 06:27 PM, Christian König wrote: >>>> AMD uses copy swaps because radeon/amdgpu kms can't switch the >>>> scanout mode from tiled to linear on t

"Fixes" for page flipping under PRIME on AMD & nouveau

2016-08-18 Thread Mario Kleiner
On 08/17/2016 07:43 PM, Alex Deucher wrote: > On Wed, Aug 17, 2016 at 12:35 PM, Mario Kleiner > wrote: >> On 08/17/2016 06:27 PM, Christian König wrote: >>>> >>>> AMD uses copy swaps because radeon/amdgpu kms can't switch the >>>> scanout m

[PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v2)

2016-11-05 Thread Mario Kleiner
as DRI3/Present Prime render offload, and with the Tonga standalone as primary gpu. v2: Add a wait for all shared fences before prime export, as suggested by Christian Koenig. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95472 (v1) Tested-by: Mike Lothian Signed-off-by: Mario

[PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-11-05 Thread Mario Kleiner
On 10/28/2016 07:48 PM, Christian König wrote: > Am 28.10.2016 um 19:37 schrieb Mario Kleiner: >> >> >> On 10/28/2016 03:34 AM, Michel Dänzer wrote: >>> On 27/10/16 10:33 PM, Mike Lothian wrote: >>>> >>>> Just another gentle ping to see w

[PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v2)

2016-11-05 Thread Mario Kleiner
On 11/05/2016 01:06 PM, Christian König wrote: > Am 05.11.2016 um 01:56 schrieb Mario Kleiner: >> External clients which import our bo's wait only >> for exclusive dmabuf-fences, not on shared ones, >> so attach fences on such exported buffers as >> exclusive ones. >

[PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v3)

2016-11-07 Thread Mario Kleiner
://bugs.freedesktop.org/show_bug.cgi?id=95472 (v1) Tested-by: Mike Lothian Signed-off-by: Mario Kleiner Cc: Christian König Cc: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c | 14

[PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v3)

2016-11-07 Thread Mario Kleiner
On 11/07/2016 08:55 AM, Christian König wrote: > Am 07.11.2016 um 04:29 schrieb Michel Dänzer: >> On 07/11/16 11:47 AM, Mario Kleiner wrote: >>> External clients which import our bo's wait only >>> for exclusive dmabuf-fences, not on shared ones, >>>

[PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v4)

2016-11-08 Thread Mario Kleiner
from our exported bo. - Also switch to exclusive fence for prime imported bo's. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95472 Tested-by: Mike Lothian (v1) Signed-off-by: Mario Kleiner Cc: Christian König Cc: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu.h

[PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v5)

2016-11-09 Thread Mario Kleiner
from our exported bo. - Also switch to exclusive fence for prime imported bo's. v5: - Drop lret, instead use int ret -> long ret, as proposed by Christian. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95472 Tested-by: Mike Lothian (v1) Signed-off-by: Mario Kleiner Revie

[PATCH] drm/nouveau/kms/nv50: Fix atomic pageflip events.

2016-11-23 Thread Mario Kleiner
-off-by: Mario Kleiner Cc: Ben Skeggs --- drivers/gpu/drm/nouveau/nv50_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index a9855a4..ad9aedb 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b

Fwd: EDID/DP fixes for proper bpc detection of displays.

2016-07-30 Thread Mario Kleiner
6 Jul 2016 12:05:43 +0200 From: Mario Kleiner <mario.kleiner...@gmail.com> To: dri-devel at lists.freedesktop.org CC: mario.kleiner.de at gmail.com Updated series to fix the regressions introduced into stable kernels for active Displayport to dual-link DVI converters and for active Displa

[PATCH 2/2] drm/edid: Add 6 bpc quirk for display AEO model 0.

2016-06-14 Thread Mario Kleiner
On 06/14/2016 12:44 PM, Ville Syrjälä wrote: > On Thu, May 26, 2016 at 04:39:04PM +0200, Mario Kleiner wrote: >> Bugzilla https://bugzilla.kernel.org/show_bug.cgi?id=105331 >> reports that the "AEO model 0" display is driven with 8 bpc >> without dithering by d

[PATCH 1/2] drm/i915/dp: Revert "drm/i915/dp: fall back to 18 bpp when sink capability is unknown"

2016-06-14 Thread Mario Kleiner
On 06/14/2016 01:05 PM, Daniel Vetter wrote: > On Thu, May 26, 2016 at 4:39 PM, Mario Kleiner > wrote: >> This reverts commit 013dd9e03872 >> ("drm/i915/dp: fall back to 18 bpp when sink capability is unknown") >> >> This commit introduced a regression into

[PATCH 1/2] drm/i915/dp: Revert "drm/i915/dp: fall back to 18 bpp when sink capability is unknown"

2016-06-21 Thread Mario Kleiner
Any news on this one? Thanks a bunch, -mario On 06/14/2016 04:12 PM, Mario Kleiner wrote: > On 06/14/2016 01:05 PM, Daniel Vetter wrote: >> On Thu, May 26, 2016 at 4:39 PM, Mario Kleiner >> wrote: >>> This reverts commit 013dd9e03872 >>> ("drm/i915/dp: fa

Precise vblank timestamping for VC4 kms.

2016-06-23 Thread Mario Kleiner
The following patch implements precise vblank timestamping for RaspberryPi's VC4, at least for standard progressive scan display modes. It has been tested on the HDMI output with half a dozen different video modes using special hardware measurement equipment to compare generated time stamps

[PATCH] drm/vc4: Implement precise vblank timestamping.

2016-06-23 Thread Mario Kleiner
, and hope for the best. Measurement shows the generated timestamps to be rather precise, and at least never off more than 1 vblank duration worst-case. Limitations: Doesn't work well yet for interlaced video modes, therefore disabled in interlaced mode for now. Signed-off-by: Mario

linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-16 Thread Mario Kleiner
On 01/15/2016 01:26 PM, Ville Syrjälä wrote: > On Fri, Jan 15, 2016 at 11:34:08AM +0100, Vlastimil Babka wrote: >> Hi, >> >> since kernel 4.4 I'm unable to login to kde5 desktop (on openSUSE >> Tumbleweed). There's a screen with progressbar showing the startup, >> which normally fades away

linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-20 Thread Mario Kleiner
On 01/18/2016 11:49 AM, Vlastimil Babka wrote: > On 01/16/2016 05:24 AM, Mario Kleiner wrote: >> >> >> On 01/15/2016 01:26 PM, Ville Syrjälä wrote: >>> On Fri, Jan 15, 2016 at 11:34:08AM +0100, Vlastimil Babka wrote: >> >> I'm currently running... &g

linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-21 Thread Mario Kleiner
On 01/21/2016 04:43 AM, Michel Dänzer wrote: > On 21.01.2016 05:32, Mario Kleiner wrote: >> >> So the problem is that AMDs hardware frame counters reset to >> zero during a modeset. The old DRM code dealt with drivers doing that by >> keeping vblank irqs enabled durin

[PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.

2016-01-21 Thread Mario Kleiner
ppen. However that glitch would hopefully be hidden by the blanking of the crtc during modeset. A small fix to power management makes sure to check for this and prevent unbalanced vblank reference counts due to mismatched drm_vblank_get/put. Reported-by: Vlastimil Babka Signed-off-by: Mario Kleine

  1   2   3   4   5   6   >