On Mon, May 19, 2014 at 11:39 PM, Rickard Strandqvist
rickard_strandqv...@spectrumdigital.se wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
Now, those are some beautiful changelogs. ;) Thanks so much.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Greg,
Please accept this as the acknowledgment to your reply.
I will take over ozwpan maintainer role from Rupesh.
Thanks
Tateno
From: Greg KH [gre...@linuxfoundation.org]
Sent: 20 May 2014 02:29
To: Gujare, Rupesh
Cc: de...@driverdev.osuosl.org;
Am 18.05.2014 19:27, schrieb Joe Perches:
On Sun, 2014-05-18 at 18:19 +0100, Masaru Nomura wrote:
Remove prohibited space and fix line over 80 characters of
memset(...) to meet kernel coding style.
[]
diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// smpl
@@
type T;
constant C;
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// smpl
@@
type T;
constant C;
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// smpl
@@
type T;
constant C;
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// smpl
@@
type T;
constant C;
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// smpl
@@
type T;
constant C;
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// smpl
@@
type T;
constant C;
Am 20.05.2014 12:33, schrieb Peter Senna Tschudin:
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that
Am 20.05.2014 12:33, schrieb Peter Senna Tschudin:
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that
I'd like to ask what is the policy for back porting fixes for drivers
that already graduated from staging but the fix is needed in kernel
version where it is still in the staging.
Thanks
___
devel mailing list
de...@linuxdriverproject.org
On Tue, May 20, 2014 at 02:17:26PM +0300, Tomas Winkler wrote:
I'd like to ask what is the policy for back porting fixes for drivers
that already graduated from staging but the fix is needed in kernel
version where it is still in the staging.
Same as anything else, just provide the backported
Those concerns are valid but the code was like that in the original so
we should merge this patch as is and hope some volunteer will fix things
up in a follow on patch.
Fixing them in this patch would be a mistake anyway because of the one
thing per patch rule.
regards,
dan carpenter
On Tue, May 20, 2014 at 02:17:26PM +0300, Tomas Winkler wrote:
I'd like to ask what is the policy for back porting fixes for drivers
that already graduated from staging but the fix is needed in kernel
version where it is still in the staging.
Same as anything else, just provide the
Am 20.05.2014 13:41, schrieb Dan Carpenter:
Those concerns are valid but the code was like that in the original so
we should merge this patch as is and hope some volunteer will fix things
up in a follow on patch.
Fixing them in this patch would be a mistake anyway because of the one
thing
This patch outsources the code from the IsFlash2x() check in
bcm_char_ioctl_nvm_rw() function to shorten it.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Bcmchar.c | 98 ---
1 file changed, 56 insertions(+), 42 deletions(-)
Hi,
I did some cleanup for the file
drivers/staging/bcm/Bcmchar.c
The patches shorten some lines and do some code outsourcing from large functions
into smaller ones.
Can someone tell me how to compile (and maybe even test) my patches?
I'm not on the ML, please keep me in CC.
Regards,
This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command
handling to shorten the bcm_char_ioctl_nvm_rw() function.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Bcmchar.c | 72 ++-
1 file changed, 44
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Bcmchar.c | 76 ---
1 file changed, 50 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index ae7490b..e5283dd 100644
---
On Tue, 2014-05-20 at 10:09 +0900, Greg KH wrote:
On Mon, May 19, 2014 at 10:57:08PM +0300, Dan Carpenter wrote:
On Mon, May 19, 2014 at 09:42:22AM -0500, Romer, Benjamin M wrote:
On Sun, 2014-05-18 at 09:49 -0700, Greg KH wrote:
Also, why are these entries moving to debugfs at all? Why
Clean up a few more things in skein to get it closer to mainline
inclusion. The first may be questionable (so I probably should have
put it last -- oh well, I can always respin), but it seemed like
putting all of the threefish block functions in one file, like the
skein block functions are all
fix some comment typos
Signed-off-by: Jake Edge j...@lwn.net
---
against staging-next branch of staging tree
drivers/staging/skein/threefish_api.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/skein/threefish_api.h
Rename a few more variables and structure member names to lower case.
Signed-off-by: Jake Edge j...@lwn.net
---
against staging-next branch of staging tree
drivers/staging/skein/skein.c | 148 +-
drivers/staging/skein/skein.h | 34
On 2014-05-20 at 15:04:50 +0200, Matthias Beyer m...@beyermatthias.de wrote:
Hi,
I did some cleanup for the file
drivers/staging/bcm/Bcmchar.c
The patches shorten some lines and do some code outsourcing from large
functions
into smaller ones.
Can someone tell me how to compile
Jake,
On Tue, May 20, 2014 at 07:56:12AM -0600, Jake Edge wrote:
Clean up a few more things in skein to get it closer to mainline
inclusion. The first may be questionable (so I probably should have
put it last -- oh well, I can always respin), but it seemed like
putting all of the
Hello,
On Tue, May 20, 2014 at 08:54:09AM +0300, Eli Billauer wrote:
That seems OK to me, but the problem I'm concerned with is this: In
devm_get_free_pages() it says
devres = devres_alloc(devm_pages_release,
sizeof(struct pages_devres), GFP_KERNEL);
if
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Bcmchar.c | 76 ---
1 file changed, 50 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index ae7490b..e5283dd 100644
---
This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command
handling to shorten the bcm_char_ioctl_nvm_rw() function.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Bcmchar.c | 72 ++-
1 file changed, 44
This patch outsources the code from the IsFlash2x() check in
bcm_char_ioctl_nvm_rw() function to shorten it.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Bcmchar.c | 101 --
1 file changed, 58 insertions(+), 43 deletions(-)
Hi,
I applied some fixes to my patches as they did not compile before.
I guess I'm not able to test these patches without the appropriate hardware,
unfortunately. Hope you guys like them anyway.
Regards,
Matthias Beyer
Matthias Beyer (3):
Staging: bcm: Fixed line lengths
Staging: bcm:
Jim Davis jim.ep...@gmail.com writes:
Building with the attached random configuration file,
drivers/staging/rtl8723au/core/rtw_cmd.c: In function ‘dynamic_chk_wk_hdl’:
drivers/staging/rtl8723au/core/rtw_cmd.c:1036:2: error: implicit declaration
of
function
Thanks for the reviews!
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote:
Do you have any other series pending for this driver?
No and I won't be doing anything else for the next couple of days --
some darn weekly edition to deal with :)
It seems like most of the straightforward stuff has been dealt with at
this
On Tue, May 20, 2014 at 10:24:11AM -0600, Jake Edge wrote:
On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote:
Do you have any other series pending for this driver?
No and I won't be doing anything else for the next couple of days --
some darn weekly edition to deal with :)
:)
It
On Tue, May 20, 2014 at 10:24:11AM -0600, Jake Edge wrote:
On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote:
but some kind of tests are needed to ensure nothing breaks before
digging into that ...
I have some test: slightly modified version of tests from
Use proper line terminations.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/staging/rtl8188eu/hal/usb_ops_linux.c | 2 +-
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
drivers/staging/rtl8723au/hal/usb_ops_linux.c | 4 ++--
drivers/staging/rtl8723au/os_dep/usb_intf.c | 2 +-
On Tue, May 20, 2014 at 05:12:44PM +0200, Matthias Beyer wrote:
@@ -410,7 +412,8 @@ static int bcm_char_ioctl_gpio_set_request(void __user
*argp,
if (IoBuffer.InputLength sizeof(gpio_info))
return -EINVAL;
- if (copy_from_user(gpio_info, IoBuffer.InputBuffer,
On Tue, May 20, 2014 at 05:12:45PM +0200, Matthias Beyer wrote:
This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command
handling to shorten the bcm_char_ioctl_nvm_rw() function.
This one is grand. I wish you had put the function ahead so we don't
have to have the forward
On Tue, May 20, 2014 at 05:12:46PM +0200, Matthias Beyer wrote:
This patch outsources the code from the IsFlash2x() check in
bcm_char_ioctl_nvm_rw() function to shorten it.
This patch introduces a bug. Please fix and resend.
Also move the function forward so we don't need a declaration.
+
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/staging/ozwpan/ozproto.c |5 -
1 file changed, 4
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 127
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/staging/rtl8192u/r8192U_core.c | 10 +++---
1 file changed, 7
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/staging/rtl8712/usb_intf.c |2 +-
1 file changed, 1
On Tue, May 20, 2014 at 11:28:59PM +0200, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
This is the empty string by default, or a module parameter. I have
looked at
On Tue, May 20, 2014 at 11:32:53PM +0200, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Could you mention in the change log which pointer you are worried about?
I think
On Tue, May 20, 2014 at 11:31:16PM +0200, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
padapter can't be NULL. Just remove the check.
regards,
dan carpenter
On Tue, May 20, 2014 at 11:34:25PM +0200, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
This
On Mon, May 19, 2014 at 11:39:00PM +0200, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
This
On 05/20/2014 04:31 PM, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
On Tue, May 20, 2014 at 11:31:16PM +0200, Rickard Strandqvist wrote:
+ if (!padapter) {
+ goto error_exit;
+ }
Btw, I forgot to mention this before but please run your patches through
scripts/checkpatch.pl.
regards,
dan carpenter
On Tue, May 20, 2014 at 06:26:51PM -0500, Larry Finger wrote:
On 05/20/2014 04:31 PM, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
I was already sent for this. :-)
https://lkml.org/lkml/2014/5/16/114
Regards,
Daeseok Youn.
2014-05-21 6:48 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Tue, May 20, 2014 at 11:28:59PM +0200, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference.
Hi Greg,
Please merge this patchset, It has been pending for some time.
regards,
navin patidar
On Wed, May 7, 2014 at 9:27 AM, navin.pati...@gmail.com wrote:
From: navin patidar navin.pati...@gmail.com
Following patches remove unused functions, variables and functions with empty
The following changes since commit 86281966c7395aa9a13a20c52e26005f5e142451:
Merge tag 'iio-fixes-for-3.15b' of
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-linus
(2014-04-30 14:19:23 -0700)
are available in the git repository at:
56 matches
Mail list logo
