(*insn_read) functions are supposed to do simple polled reads of a single
channel. This driver tries to be tricky and allow enabling interrupts in
the analog input (*insn_config) to allow the (*insn_read) to read samples
with the end-of-conversion interrupt.
The (*insn_config) doesn't follow the c
The APCI-3120 documentation says that the PR/PA bits should be set after the
chanlist sequence is programmed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_3120.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Define the chanlist register and its bits and tidy up the programming
of the scan chanlist.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci3120.c | 38 +++---
drivers/staging/comedi/drivers/addi_apci_3120.c
Introduce a helper function to set the operation mode of a timer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci3120.c | 57 +++---
drivers/staging/comedi/drivers/addi_apci_3120.c| 6 +++
2 files chan
This mask value is the same as APCI3120_DISABLE_TIMER_COUNTER. Use that
instead and remove the "magic" value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletio
For aesthetics, remove this define and just use ~APCI3120_ENABLE_WATCHDOG.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/
The scan sequence does not need to be reset when the driver is attached. Remove
the code in apci3120_reset() that does this.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 7 ---
1 file changed, 7 delet
This member of the private data is not really needed. The devpriv->ctrl
value can be checked to determine if the external trigger is enabled.
Remove the unnecessary member.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv
Rename this CamelCase member of the private data and tidy up the mask/set
of its bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci3120.c | 70 +-
drivers/staging/comedi/drivers/addi_apci_3120.c|
This define is not used in the driver. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c
b
The APCI3120_DISABLE_ALL_INTERRUPT define is a mask value used to clear bits
in devpriv->b_ModeSelectRegister to disable the interrupt sources. Writing this
value directly sets unintended bits.
Just set the devpriv->b_ModeSelectRegister to '0' and write that to the
register.
Signed-off-by: H Har
This function does not follow the comedi API for (*insn_config) functions.
It's also no long needed. Just remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 15 ---
drivers/staging/comedi
Define a macro that returns the mask of the timer_mode bits for a given
timer. Use the macro to remove the "magic" values used to clear the bits.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../staging/comedi/drivers/addi-data/hwdrv_apci3120.c| 16 ---
Rename this CamelCase member of the private data and convert it to
a bit-field.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 4 ++--
drivers/staging/comedi/drivers/addi_apci_3120.c | 4 ++--
2 f
For aesthetics, remove this define and just use ~APCI3120_ENABLE_TIMER_COUNTER.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/
This member of the private data is no longer used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_3120.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_3120.c
b/drivers
Move the common code used to initialize DMA to apci3120_init_dma().
This follows the programming procedure described in the APCI-3120
documentation.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci3120.c | 99 ++---
For aesthetics, remove this define and just use ~APCI3120_ENABLE_EOC_INT.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/stagin
Move this helper function from the included source file into the main driver
source file.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 12
drivers/staging/comedi/drivers/addi_apci_3120.c
Merge these two functions and use an 'enable' parameter to determine if the
external trigger needs to be enabled or disabled.
This function always succeeds and the callers don't check the return. Change
the return type to void.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hart
Rename this CamelCase member of the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci3120.c | 50 --
drivers/staging/comedi/drivers/addi_apci_3120.c| 2 +-
2 files changed, 18 insertion
Following is the big cleanup series for the ADDI-DATA APCI-3120 driver.
Quick summary of the cleanup:
* Removes all the CamelCase
* Cleans up the register map defines
* Fixes the Analog Input subdevice
* Fixes the async command support for the Analog Input subdevice
* Cleans up all the
The wrong define is being used to disable the gate to stop timer 2 in this
function.
Use the apci3120_timer_enable() helper to properly disable the timer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 4 +
For aesthetics, rename this register offset.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 9 -
drivers/staging/comedi/drivers/addi_apci_3120.c | 1 +
2 files changed, 5 insertions(+), 5
Introduce a helper function to select a timer and read a value from it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
.../comedi/drivers/addi-data/hwdrv_apci3120.c | 45 --
1 file changed, 25 insertions(+), 20 deletions(-)
diff --git a/dri
2014-11-03 19:15 GMT+04:00 Hans Verkuil :
> Hi Andrey,
>
> On 10/29/2014 05:03 PM, Andrey Utkin wrote:
>> The used approach actually cannot prevent new encoder interrupt to
>> appear, because interrupt handler can execute in different thread, and
>> in current implementation there is still race con
Am Dienstag, den 04.11.2014, 16:19 + schrieb Emil Velikov:
> Hi Philipp,
>
> Just a flyby question
>
> On 04/11/14 10:52, Philipp Zabel wrote:
> > The imx-drm driver was put into staging mostly for the following reasons,
> > all of which have been addressed or superseded:
> > - convert the i
Remove the private data member 'ai_sample_count' and use the comedi_async
'scans_done' member to detect the analog input end-of-acquisition.
Use the comedi_nsamples_left() helper to get the number of samples to actually
add to the async buffer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc
Remove the private data member 'ai_scan_count' and use the comedi_async
'scans_done'
member to detect the analog input end-of-acquisition.
Use the comedi_nsamples_left() helper to work out the number of 'wake' samples
in
pci230_ai_update_fifo_trigger_level() and the number of 'todo' samples actu
Remove the private data member 'ao_count' and use the comedi_async 'scans_done'
member to detect the analog output end-of-acquisition.
Use the comedi_nsamples_left() helper to get the number of samples to actually
read from the async buffer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: G
Remove the private data member 'count' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Use the comedi_nsamples_left() helper to get the number of samples to actually
add to the async buffer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
-
Remove the private data member 'ai_count' and use the comedi_async 'scans_done'
member to detect the analog output end-of-acquisition.
Use the helper function comedi_nscans_left() to get the number of scans in the
async buffer of left in the command.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbo
Remove the private data member 'ai_count' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Use the helper function comedi_nscans_left() to check if the number of scans
left in the command.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
Introduce a helper function to calculate the number of samples remaining
when the cmd->stop_src is TRIG_COUNT.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/comedidev.h | 2 ++
drivers/staging/comedi/drivers.c | 32
Remove the private data member 'count' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 27
1 file changed, 14 in
Remove the private data member 'ai_count' and use the comedi_async 'scans_done'
member to detect the analog output end-of-acquisition.
Use the comedi_nsamples_left() helper to get the number of samples to actually
add to the async buffer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
Remove the private data member 'count' and use the comedi_async 'scans_done'
member to detect the analog input end-of-acquisition.
Use the comedi_nsamples_left() helper to get the number of samples to actually
add to the async buffer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kro
Introduce a helper function to determine the number of scans left in
the async command.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/comedidev.h | 2 ++
drivers/staging/comedi/drivers.c | 39 ++
2 files
This series converts the remaining comedi drivers to use the comedi_async
'scans_done' member to count the number of scans completed when counting
scans with a cmd->stop_src of TRIG_COUNT.
H Hartley Sweeten (13):
staging: comedi: drivers: introduce comedi_nscans_left()
staging: comedi: amplc_p
Remove the private data member 'ao_count' and use the comedi_async 'scans_done'
member to detect the analog output end-of-acquisition.
Use the comedi_nsamples_left() helper to get the number of samples to actually
read from the async buffer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: G
Remove the private data member 'ao_stop_count' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
Use the helper function comedi_nscans_left() to determine the number of scans
available in the async buffer or left in the command.
Signed-off-by: H Hartley Sweeten
Cc: I
Remove the private data member 'ai_AiActualScan' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
The function v_APCI3120_InterruptDmaMoveBlock16bit() is then just a wrapper
for comedi_buf_write_samples(). Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
The comedi drivers that support async commands with a cmd->stop_src of
TRIG_COUNT
currently have a private data member that is used to count the number of scans
completed in order to detect the end of acquisition for the command.
This series addes a new member, 'scans_done', to comedi_async and m
Remove the private data member 'ao_sample_count' and use the comedi_async
'scans_done' member to detect the analog output end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbdux.c | 29 -
1
This member of the private data is set to '0' but never used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c
b/drivers/st
Remove the private data member 'stopcount' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_dio200_common.c | 14 +++---
1 file changed, 3 inser
Remove the private data member 'ai_act_scan' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl812.c | 9 +
1 file changed, 1 insertion(+), 8 deleti
Remove the private data member 'count' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcmmio.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletio
Remove the private data member 'ai_act_scan' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 15 ++-
1 file changed, 6 insertions(+),
Remove the private data member 'ntrig' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl711.c | 16 ++--
1 file changed, 6 insertions(+), 10 de
Remove the private data member 'ai_act_scan' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 9 +
1 file changed, 1 insertion(+), 8 deleti
Remove the private data member 'ai_sample_count' and use the comedi_async
'scans_done' member to detect the analog input end-of-acquisition.
Move the EOA check so it happens after adding the samples from the current
urb to the async buffer. This prevents the unnecessary resubmit of the urb
when th
Remove the private data member 'ai_sample_count' and use the comedi_async
'scans_done' member to detect the analog input end-of-acquisition.
Move the EOA check so it happens after adding the samples from the current
urb to the async buffer. This prevents the unnecessary resubmit of the urb
when th
Remove the private data member 'count' and use the comedi_async 'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das800.c | 31 ---
1 file changed, 12 inse
Remove the private data member 'ai_act_scan' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 26 +-
1 file changed, 5
Remove the private data member 'ai_sample_count' and use the comedi_async
'scans_done' member to detect the end-of-acquisition.
Also, remove the unnecessary COMEDI_CB_EOS event. The core automatically
detects and adds that event.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Ha
Remove the private data member 'stop_count' and use the comedi_async
'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_2032.c | 17 +
1 file changed, 5 inser
Remove the private data member 'stop_count' and use the comedi_async
'scans_done'
member to detect the end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcmuio.c | 14 +++---
1 file changed, 3 insertions(+), 1
Remove the private data member 'ao_sample_count' and use the comedi_async
'scans_done' member to detect the analog output end-of-acquisition.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxsigma.c | 30 ---
Introduce a new member to comedi_async to count the number of scans completed.
This member is cleared by comedi_buf_reset() along with the other comedi_async
members. It is incremented in comedi_inc_scan_progress() when the end of scan
is detected.
This member will be used to clean up the scan cou
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Tuesday, November 4, 2014 4:40 AM
> To: KY Srinivasan; Haiyang Zhang
> Cc: Greg Kroah-Hartman; de...@linuxdriverproject.org; linux-
> ker...@vger.kernel.org
> Subject: [PATCH] Drivers: hv: vmbus: Fix a race
Split up the doubled assignment in visor_charqueue_create() into two separate
assignments.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/charqueue.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorutil/charqueue.c
b/drivers/
Remove all the extraneous blank lines from visorkmodutils.c.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/visorkmodutils.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/unisys/visorutil/visorkmodutils.c
b/drivers/staging/unisys/visorutil/visorkmodu
Get rid of all extra spaces between casts and their targets in this file.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/memregion_direct.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorutil/memregion_direct.c
b/drivers
Remove the typedef and just use struct charqueue instead. Update all references.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/charqueue.c | 21 +++--
drivers/staging/unisys/visorutil/charqueue.h | 17 +
2 files changed, 20 insertions(+), 18 d
Fix the sizeof() so it uses the variable name rather than the type, fix the
argument alignment to the kzalloc(), and rename the goto label.
Away => cleanup
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/memregion_direct.c | 8
1 file changed, 4 insertions(+), 4 dele
Remove the typedef for this structure and just use struct memregion instead.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchannel/visorchannel.h | 2 +-
.../unisys/visorchannel/visorchannel_funcs.c | 6 ++--
drivers/staging/unisys/visorchipset/parser.c | 2 +-
dri
Fix the function name declaration so it is just one line, and add the missing
brackets to the else clause in the if statement.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/visorkmodutils.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/sta
Fix warnings, errors, and strict checks in the visorutil directory.
Benjamin Romer (15):
staging: unisys: fix line spacing in charqueue.c
staging: unisys: refactor CHARQUEUE
staging: unisys: split double assignment in visor_charqueue_create()
staging: unisys: add comment to spinlock in str
The last if statement in this function is missing brackets on the else
clause. Add them.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/periodic_work.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorutil/periodic_work.c
b/dr
Fix the declaration line so it is just one single line, and add the missing
brackets on the else clause in the if statement.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/visorkmodutils.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/stagi
Clean up the extraneous blank lines in charqueue.c.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/charqueue.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/unisys/visorutil/charqueue.c
b/drivers/staging/unisys/visorutil/charqueue.c
ind
Get rid of the extra blank lines in this file.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/memregion_direct.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorutil/memregion_direct.c
b/drivers/staging/unisys/visorutil/memregion_direct.c
ind
Add a comment to the charqueue's spinlock to explain that it is a lock for the
structure.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/charqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorutil/charqueue.c
b/drivers/sta
Use the variable name rather than the type in the sizeof() call in this
function.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/memregion_direct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorutil/memregion_direct.c
b/drive
Get rid of all extraneous blank lines in periodic_work.c.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/periodic_work.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/unisys/visorutil/periodic_work.c
b/drivers/staging/unisys/visorutil/p
The error output in mapit() in memregion_direct.c has variables past the 80
character limit. Move them to the next line, but the string constant will still
go past the limit, and that's okay.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/memregion_direct.c | 3 ++-
1 file ch
Hi Philipp,
Just a flyby question
On 04/11/14 10:52, Philipp Zabel wrote:
> The imx-drm driver was put into staging mostly for the following reasons,
> all of which have been addressed or superseded:
> - convert the irq driver to use linear irq domains
> - work out the device tree bindings, thi
On Tue, Nov 04, 2014 at 09:39:58PM +0800, Andy Yan wrote:
> From: Andy yan
>
> the original imx hdmi driver is under staging/imx-drm,
> which depends on imx-drm, so move the imx hdmi drvier out
> to drm/bridge and rename imx-hdmi to dw-hdmi
>
> Change-Id: I5f417372f256aa26cd00a3cd0160741680afd39
On Tue, Nov 04, 2014 at 09:33:10PM +0800, Andy Yan wrote:
> From: Andy yan
>
> We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
> use the interface compatible Designware HDMI IP, but they also have some
> lightly difference, such as phy pll configuration, register widt
Hi Andy,
On 04/11/14 13:33, Andy Yan wrote:
> imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS)
> use the interface compatible Designware HDMI IP, but they
> also have some lightly difference, such as phy pll configuration,
> register width(imx hdmi register is one byte, but rk3288 is 4
>
imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they
also have some lightly difference, such as phy pll configuration,
register width(imx hdmi register is one byte, but rk3288 is 4
bytes width), 4K support(imx6 doesn't support 4k, but r
Hi,
On 04/11/14 13:39, Andy Yan wrote:
> From: Andy yan
>
> the original imx hdmi driver is under staging/imx-drm,
> which depends on imx-drm, so move the imx hdmi drvier out
> to drm/bridge and rename imx-hdmi to dw-hdmi
>
> Change-Id: I5f417372f256aa26cd00a3cd0160741680afd39d
> ---
> drivers
KY Srinivasan writes:
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Wednesday, October 22, 2014 9:07 AM
>> To: KY Srinivasan; Haiyang Zhang; de...@linuxdriverproject.org
>> Cc: linux-ker...@vger.kernel.org
>> Subject: [PATCH] tools: hv: introduce -n
From: Andy yan
We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they also have some
lightly difference, such as phy pll configuration, register width(imx hdmi
register is one byte, but rk3288 is 4 bytes width and can
When build with Debug the following crash is sometimes observed:
Call Trace:
[] string+0x40/0x100
[] vsnprintf+0x218/0x5e0
[] ? trace_hardirqs_off+0xd/0x10
[] vscnprintf+0x11/0x30
[] vprintk+0xd0/0x5c0
[] ? vmbus_process_rescind_offer+0x0/0x110 [hv_vmbus]
[] printk+0x41/0x45
[] vmbus_device
On Tue, Nov 4, 2014 at 6:52 PM, Philipp Zabel wrote:
> Add myself as the maintainer of the i.MX DRM driver.
>
> Signed-off-by: Philipp Zabel
Acked-by: Shawn Guo
> ---
> MAINTAINERS | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index df2aecf..ddf19
Well, I gave two alternatives :-)
Both are fine as far as I am concerned, but it would be nice to hear
what others think.
Regards,
Hans
On 11/04/14 11:45, Boris Brezillon wrote:
> Hi Hans,
>
> On Tue, 04 Nov 2014 11:20:40 +0100
> Hans Verkuil wrote:
>
>> Hi Boris,
>>
>> On 11/04/14 1
Am Dienstag, den 04.11.2014, 11:52 +0100 schrieb Philipp Zabel:
> The imx-drm driver was put into staging mostly for the following reasons,
> all of which have been addressed or superseded:
> - convert the irq driver to use linear irq domains
> - work out the device tree bindings, this lead to th
The imx-drm driver was put into staging mostly for the following reasons,
all of which have been addressed or superseded:
- convert the irq driver to use linear irq domains
- work out the device tree bindings, this lead to the common of_graph
bindings being used
- factor out common helper fun
Linux already includes a copy of the GPL, checkpatch compains about the address.
Remove it from the license text.
Signed-off-by: Philipp Zabel
---
drivers/staging/imx-drm/imx-ldb.c | 5 -
drivers/staging/imx-drm/imx-tve.c | 5 -
drivers/staging/imx-drm/ipuv3-crtc.c
Add myself as the maintainer of the i.MX DRM driver.
Signed-off-by: Philipp Zabel
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index df2aecf..ddf191d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3183,6 +3183,13 @@ F: drivers/gpu/drm
Hi Hans,
On Tue, 04 Nov 2014 11:20:40 +0100
Hans Verkuil wrote:
> Hi Boris,
>
> On 11/04/14 10:54, Boris Brezillon wrote:
> > Rename mediabus formats and move the enum into a separate header file so
> > that it can be used by DRM/KMS subsystem without any reference to the V4L2
> > subsystem.
>
Hi Boris,
On 11/04/14 10:54, Boris Brezillon wrote:
> Rename mediabus formats and move the enum into a separate header file so
> that it can be used by DRM/KMS subsystem without any reference to the V4L2
> subsystem.
>
> Old V4L2_MBUS_FMT_ definitions are now referencing MEDIA_BUS_FMT_ value.
I
On 11/04/14 11:20, Hans Verkuil wrote:
> Hi Boris,
>
> On 11/04/14 10:54, Boris Brezillon wrote:
>> Rename mediabus formats and move the enum into a separate header file so
>> that it can be used by DRM/KMS subsystem without any reference to the V4L2
>> subsystem.
>>
>> Old V4L2_MBUS_FMT_ defini
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all platform drivers.
Signed-off-by: Boris Brezillon
---
D
In order to have subsytem agnostic media bus format definitions we've
moved media bus definitions to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Replace all references to the old definitions in i2c drivers.
Signed-off-by: Boris Brezi
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Update the v4l documentation accordingly.
Signed-off-by: Boris Brezillon
---
Documentat
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all media drivers residing in staging.
Signed-off-by: Boris
The v4l2-mediabus.h header is now deprecated and should be replaced with
v4l2-mbus.h.
Signed-off-by: Boris Brezillon
---
drivers/media/i2c/mt9m032.c | 2 +-
drivers/media/i2c/mt9t001.c | 2 +-
drivers/media/i2c/mt9v032.c | 2 +-
drivers/media/i2c/smiapp/
101 - 200 of 214 matches
Mail list logo
