Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

2014-06-09 Thread Russell King - ARM Linux
On Mon, Jun 09, 2014 at 03:15:16PM -0300, Fabio Estevam wrote: With HDMI cable connected (no image is seen on HDMI, only on lvds cable): imx-drm display-subsystem.11: bound 12.hdmi (ops hdmi_ops) imx-hdmi 12.hdmi: EVENT=plugin imx-hdmi 12.hdmi: Non-CEA mode used in HDMI imx-hdmi

Re: [RFC PATCH 0/8] component helper improvements

2014-04-27 Thread Russell King - ARM Linux
On Sun, Apr 27, 2014 at 02:51:30PM +0200, Daniel Vetter wrote: On Sun, Apr 27, 2014 at 1:00 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: A while back, Laurent raised some comments about the component helper, which this patch set starts to address. The first point

Re: [PATCH] imx-drm: fix hdmi hotplug detection initial state

2014-04-24 Thread Russell King - ARM Linux
On Thu, Apr 24, 2014 at 02:00:49PM -0700, Tim Harvey wrote: I'm still seeing issues with HDMI detect on powerup, at least on my Gateworks Ventana boards (which have no voltage devider or anything else on the HPD line to the IMX6 other than a TVS). I'm currently using your latest

Re: [PATCH] imx-drm: fix hdmi hotplug detection initial state

2014-04-24 Thread Russell King - ARM Linux
On Thu, Apr 24, 2014 at 03:57:27PM -0700, Tim Harvey wrote: On Thu, Apr 24, 2014 at 3:07 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Apr 24, 2014 at 02:00:49PM -0700, Tim Harvey wrote: I'm still seeing issues with HDMI detect on powerup, at least on my Gateworks

Re: [PATCH v2 0/8] Reorder i.MX IPU display enable/disable sequence

2014-04-18 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 11:53:15PM +0200, Philipp Zabel wrote: Repeatedly enabling and disabling the display currently can lead to a state in which the IPU doesn't produce a valid signal anymore because we disable IPU submodules before they can finish their interaction. This series reorders

Re: [PATCH 2/4] staging: imx-hdmi: correct connector detect and hotplug

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 10:42:32AM +0200, Lucas Stach wrote: Am Sonntag, den 13.04.2014, 15:58 +0100 schrieb Russell King - ARM Linux: On Fri, Apr 11, 2014 at 04:13:33PM +0200, Lucas Stach wrote: Make sure that we probe for a display on detect regardless of previous hotplug events. Don't

Re: [PATCH 2/4] staging: imx-hdmi: correct connector detect and hotplug

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 11:38:43AM +0200, Lucas Stach wrote: Am Montag, den 14.04.2014, 10:10 +0100 schrieb Russell King - ARM Linux: On Mon, Apr 14, 2014 at 10:42:32AM +0200, Lucas Stach wrote: Am Sonntag, den 13.04.2014, 15:58 +0100 schrieb Russell King - ARM Linux: On Fri, Apr 11

Re: [PATCH 0/7] Reorder i.MX IPU display enable/disable sequence

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 05:21:28PM +0200, Philipp Zabel wrote: Repeatedly enabling and disabling the display currently can lead to a state in which the IPU doesn't produce a valid signal anymore because we disable IPU submodules before they can finish their interaction. Well done at finding

Re: [PATCH 2/4] staging: imx-hdmi: correct connector detect and hotplug

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 12:24:45PM +0200, Lucas Stach wrote: Am Montag, den 14.04.2014, 11:09 +0100 schrieb Russell King - ARM Linux: Now *you* please go back and read what you said about kms/userspace being able to poll the connector, thereby causing an EDID read attempt while HPD may

Re: [PATCH 0/7] Reorder i.MX IPU display enable/disable sequence

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 05:21:28PM +0200, Philipp Zabel wrote: Repeatedly enabling and disabling the display currently can lead to a state in which the IPU doesn't produce a valid signal anymore because we disable IPU submodules before they can finish their interaction. I'm afraid to say that

Re: [PATCH 4/7] imx-drm: ipu-dc: Wait for DC_FC_1 / DP_SF_END interrupt

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 05:21:32PM +0200, Philipp Zabel wrote: Wait for the DC Frame Complete or DP Sync Flow End interrupts before disabling DC channels. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 71

Re: [PATCH v2 0/8] Reorder i.MX IPU display enable/disable sequence

2014-04-14 Thread Russell King - ARM Linux
On Mon, Apr 14, 2014 at 11:53:15PM +0200, Philipp Zabel wrote: Repeatedly enabling and disabling the display currently can lead to a state in which the IPU doesn't produce a valid signal anymore because we disable IPU submodules before they can finish their interaction. Yes, this appears to

Re: [PATCH 2/4] staging: imx-hdmi: correct connector detect and hotplug

2014-04-13 Thread Russell King - ARM Linux
On Fri, Apr 11, 2014 at 04:13:33PM +0200, Lucas Stach wrote: Make sure that we probe for a display on detect regardless of previous hotplug events. Don't handle connector hotplug state ourselves, but let DRM do the right thing for us. This brings our hotplug handling in line with what other

Re: [PATCH 3/4] staging: imx-hdmi: clear all hotplug IRQs on bind

2014-04-13 Thread Russell King - ARM Linux
On Fri, Apr 11, 2014 at 04:13:34PM +0200, Lucas Stach wrote: Makes sure we don't receive a stray IRQ on startup. Signed-off-by: Lucas Stach l.st...@pengutronix.de --- drivers/staging/imx-drm/imx-hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v12][ 03/12] imx-drm: Correct BGR666 and the board's dts that use them.

2014-04-08 Thread Russell King - ARM Linux
On Mon, Apr 07, 2014 at 02:44:42PM +0200, Denis Carikli wrote: arch/arm/boot/dts/imx51-apf51dev.dts|2 +- arch/arm/boot/dts/imx53-m53evk.dts |2 +- drivers/staging/imx-drm/imx-ldb.c |4 ++-- drivers/staging/imx-drm/ipu-v3/ipu-dc.c |4 ++-- 4 files changed, 6

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-04-07 Thread Russell King - ARM Linux
On Mon, Apr 07, 2014 at 12:23:37PM +0800, Shawn Guo wrote: And I see another HDMI regression with my testing on mainline kernel. I can have my HDMI work at 1920x1080 with v3.14 kernel, but it can only probes 1024x768 with the mainline today. Works for me here. [20.606] (II) LoadModule:

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-03-21 Thread Russell King - ARM Linux
On Fri, Mar 07, 2014 at 12:24:33AM +0100, Laurent Pinchart wrote: However, we (as in the V4L2 community, and me personally) would have appreciated to be CC'ed on the proposal. As you might know we already had a solution for this problem, albeit V4L2-specific, in drivers/media/v4l2-

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-03-19 Thread Russell King - ARM Linux
On Wed, Mar 19, 2014 at 06:22:14PM +0100, Laurent Pinchart wrote: Hi Russell, (CC'ing Philipp Zabel who might be able to provide feedback as a user of the component framework) Could you please have a look at the questions below and provide an answer when you'll have time ? I'd like to

Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags

2014-03-18 Thread Russell King - ARM Linux
On Tue, Mar 18, 2014 at 08:50:30AM +0100, Lothar Waßmann wrote: Hi, Laurent Pinchart wrote: Hi Lothar, On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote: DE is not a clock signal, but an 'Enable' signal whose value (high or low) defines the window in which the pixel data is

Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags

2014-03-18 Thread Russell King - ARM Linux
On Tue, Mar 18, 2014 at 01:41:54PM +0100, Laurent Pinchart wrote: Hi Lothar, That's not my point. I *know* that DE is a data gating signal with a polarity already defined by the DRM_MODE_FLAG_POL_DE_(LOW|HIGH) flags. Like all other signals it gets generated on a clock edge and is sampled

Re: [PATCH v9][ 4/8] imx-drm: Match ipu_di_signal_cfg's clk_pol with its description.

2014-03-07 Thread Russell King - ARM Linux
On Thu, Mar 06, 2014 at 05:04:25PM +0100, Denis Carikli wrote: According to the datasheet, setting the di0_polarity_disp_clk field in the GENERAL di register sets the output clock polarity to active high. Signed-off-by: Denis Carikli de...@eukrea.com --- ChangeLog v8-v9: - New patch that

Re: [PATCH 2/2] imx-drm: imx-ldb: Use OF graph to find connected panel

2014-03-07 Thread Russell King - ARM Linux
On Thu, Mar 06, 2014 at 02:54:40PM +0100, Philipp Zabel wrote: @@ -566,9 +566,18 @@ static int imx_ldb_bind(struct device *dev, struct device *master, void *data) return -EINVAL; } - panel_node = of_parse_phandle(child, fsl,panel, 0); -

Re: [PATCH 1/2] imx-drm: imx-ldb: Add drm_panel support

2014-03-07 Thread Russell King - ARM Linux
On Thu, Mar 06, 2014 at 02:54:39PM +0100, Philipp Zabel wrote: This patch allows to optionally attach the lvds-channel to a panel supported by a drm_panel driver instead of supplying the modes via device tree. Hmm, I think something may be missing in this patch... you're introducing calls into

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-07 Thread Russell King - ARM Linux
On Wed, Mar 05, 2014 at 10:20:51AM +0100, Philipp Zabel wrote: Hi, this latest version of the imx-drm DT binding patches applies on top of staging-next and also depends on the OF graph binding patchset that moves the v4l2_of helpers to drivers/of. Currently, the two patchsets are also

Re: [PATCH v5 00/11] imx-drm dt bindings

2014-03-07 Thread Russell King - ARM Linux
On Fri, Mar 07, 2014 at 07:57:51PM +0100, Philipp Zabel wrote: [Added Shawn to Cc:] On Fri, Mar 7, 2014 at 7:28 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Mar 07, 2014 at 05:56:12PM +, Russell King - ARM Linux wrote: On Wed, Mar 05, 2014 at 10:20:51AM +0100

Re: [PATCH v5 06/11] imx-drm: imx-tve: Fix DDC I2C bus property

2014-03-06 Thread Russell King - ARM Linux
On Wed, Mar 05, 2014 at 10:20:57AM +0100, Philipp Zabel wrote: This patch fixes the TV Encoder DDC I2C bus property to use the common 'ddc-i2c-bus' property name instead of 'ddc'. Looking at both hdmi and tve, the ddc part is very similar. The difference is how the probe is handled: imx-hdmi:

Re: [PATCH v5 01/11] staging: imx-drm-core: Use OF graph to find components and connections between encoder and crtcs

2014-03-05 Thread Russell King - ARM Linux
On Wed, Mar 05, 2014 at 10:20:52AM +0100, Philipp Zabel wrote: +struct imx_drm_component { + struct device_node *of_node; + struct list_head list; +}; + The only thing this structure appears to be doing is ensuring that a single component doesn't get added twice - is that correct?

Re: [PATCH 2/3] imx-drm: ipu-dc: Use usleep_range instead of msleep

2014-02-28 Thread Russell King - ARM Linux
On Tue, Feb 25, 2014 at 12:43:42PM +0100, Philipp Zabel wrote: Since msleep(2) can sleep up to 20ms anyway, make this explicit by using usleep_range(2000, 2). Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 2 +- 1 file changed, 1

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Russell King - ARM Linux
On Thu, Feb 27, 2014 at 02:06:25PM +0100, Philipp Zabel wrote: For the i.MX6 display subsystem there is no clear single master device, and the physical configuration changes across the SoC family. The i.MX6Q/i.MX6D SoCs have two separate display controller devices IPU1 and IPU2, with two

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Russell King - ARM Linux
On Thu, Feb 27, 2014 at 03:16:03PM +0200, Tomi Valkeinen wrote: On 27/02/14 13:56, Russell King - ARM Linux wrote: Is there even need for such a master device? You can find all the connected display devices from any single display device, by just following the endpoint links. Please

Re: [PATCH v4 3/6] imx-drm: imx-ldb: Use snprintf()

2014-02-27 Thread Russell King - ARM Linux
On Thu, Feb 27, 2014 at 02:54:43PM -0800, Greg KH wrote: On Wed, Feb 26, 2014 at 08:53:41PM -0300, Fabio Estevam wrote: diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c index abf8517..daa54df 100644 --- a/drivers/staging/imx-drm/imx-ldb.c +++

Re: [RFC PATCH 0/5] Move IPUv3 core out of staging, add CSI support

2014-02-26 Thread Russell King - ARM Linux
On Wed, Feb 26, 2014 at 11:39:03AM +0300, Dan Carpenter wrote: Please fix the following static checker complaints before moving out of staging: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) Note that

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-26 Thread Russell King - ARM Linux
On Wed, Feb 26, 2014 at 10:00:25PM +0100, Guennadi Liakhovetski wrote: Hi Russell (I suspect this my email will be rejected by ALKML too like other my recent emails, but at least other MLs will pick it up and individual CCs too, so, if replying, maybe it would be good to keep my entire

Re: [PATCH 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Russell King - ARM Linux
On Wed, Feb 26, 2014 at 06:44:36PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is

Re: [PATCH v3 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Russell King - ARM Linux
On Wed, Feb 26, 2014 at 07:44:33PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory

Re: [RFC PATCH v3 1/9] staging: imx-drm-core: don't request probe deferral in imx_drm_encoder_parse_of

2014-02-24 Thread Russell King - ARM Linux
On Tue, Feb 18, 2014 at 12:36:02PM +0100, Philipp Zabel wrote: From: Lucas Stach l.st...@pengutronix.de Since imx_drm_encoder_parse_of is called from the encoder bind callbacks, it is too late to request probe deferral. Rather the core should make sure that the crtcs are bound before the

Re: [RFC PATCH v3 2/9] staging: imx-drm: Add temporary copies of v4l2-of parsing functions

2014-02-24 Thread Russell King - ARM Linux
On Tue, Feb 18, 2014 at 12:36:03PM +0100, Philipp Zabel wrote: From: Philipp Zabel philipp.za...@gmail.com The existing v4l2-of parser functions for the video interface bindings described in Documentation/device-tree/bindings/media/video-interfaces.txt are useful for DRM drivers, too. They

Re: [RFC PATCH v3 1/9] staging: imx-drm-core: don't request probe deferral in imx_drm_encoder_parse_of

2014-02-24 Thread Russell King - ARM Linux
On Mon, Feb 24, 2014 at 05:56:38PM +0100, Philipp Zabel wrote: Am Montag, den 24.02.2014, 15:49 + schrieb Russell King - ARM Linux: One issue was that the DT parsing code would try to add the imx-ldb component right after the first crtc, and then its bind would fail

Re: [GIT PULL] imx-drm conversion to component support

2014-02-24 Thread Russell King - ARM Linux
On Mon, Feb 24, 2014 at 12:41:41PM -0800, Greg KH wrote: On Mon, Feb 24, 2014 at 02:20:20PM +, Russell King wrote: Greg, Please incorporate the latest imx-drm updates into staging, which can be found at: git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-staging with

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-18 Thread Russell King - ARM Linux
On Tue, Feb 18, 2014 at 12:45:09PM +0100, Philipp Zabel wrote: Thanks for your comments there. I have just updated and resent this series ([RFC PATCH v3 0/9] imx-drm dt bindings), still with a temporary local copy of the v4l2_of functions, as long as the final resting place of the

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 12:28:03PM +, Russell King - ARM Linux wrote: This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated to v3.14-rc2. Since the last round of patches were posted

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Russell King - ARM Linux
On Wed, Feb 12, 2014 at 01:04:30PM +0100, Christian Gmeiner wrote: 2014-02-12 12:53 GMT+01:00 Fabio Estevam feste...@gmail.com: On Mon, Feb 10, 2014 at 10:28 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: This is the latest revision of my series cleaning up imx-drm

[PATCH] hostap: fix hostap: proc: Use remove_proc_subtree()

2014-02-12 Thread Russell King - ARM Linux
remove_proc_subtree() doesn't work here as local-ddev has already been removed, and NULLed out. Use proc_remove() instead. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Tested-by: Russell King rmk+ker...@arm.linux.org.uk --- I would include an oops, however the machine I discovered

Re: [PATCH] staging: drm/imx: remove an unnecessary local variable

2014-02-10 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote: This patch removes an unnecessary local variable defined in the function imx_drm_driver_unload() so as to fix the following build warning. drivers/staging/imx-drm/imx-drm-core.c: \ In function ‘imx_drm_driver_unload’:

Re: [PATCH] staging: drm/imx: remove an unnecessary local variable

2014-02-10 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 06:42:57PM +0800, Liu Ying wrote: On 02/10/2014 06:29 PM, Russell King - ARM Linux wrote: On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote: This patch removes an unnecessary local variable defined in the function imx_drm_driver_unload() so as to fix

Re: [PATCH v3 1/2] drivers/base: permit base components to omit the bind/unbind ops

2014-02-10 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 01:53:08PM +0100, Thierry Reding wrote: On Fri, Feb 07, 2014 at 04:55:00PM +0100, Jean-Francois Moine wrote: Some simple components don't need to do any specific action on bind to / unbind from a master component. This patch permits such components to omit the

Re: [PATCH v3 1/2] drivers/base: permit base components to omit the bind/unbind ops

2014-02-10 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 03:35:51PM +0100, Jean-Francois Moine wrote: On Mon, 10 Feb 2014 13:12:33 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: I've NAK'd these patches already - I believe they're based on a mis-understanding of how this should be used. I believe Jean

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-10 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 04:12:19PM +0100, Philipp Zabel wrote: Am Montag, den 10.02.2014, 12:28 + schrieb Russell King - ARM Linux: This is the latest revision of my series cleaning up imx-drm and hopefully getting it ready to be moved out of drivers/staging. This series is updated

Re: [RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder

2014-02-10 Thread Russell King - ARM Linux
On Mon, Jan 06, 2014 at 03:52:01PM +0100, Philipp Zabel wrote: @@ -438,24 +453,21 @@ int imx_drm_encoder_parse_of(struct drm_device *drm, struct drm_encoder *encoder, struct device_node *np) { struct imx_drm_device *imxdrm = drm-dev_private; + struct device_node *ep, *last_ep

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-10 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 06:37:26PM +0100, Philipp Zabel wrote: I'd like all of them to go through, too. If you don't want to have the DT changes integrated, I'd appreciate if you could have a look at my patches on top of your series and possibly append them to your series or let me

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-09 Thread Russell King - ARM Linux
On Sun, Feb 09, 2014 at 10:22:19AM +0100, Jean-Francois Moine wrote: On Fri, 7 Feb 2014 20:23:51 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: Here's my changes to the TDA998x driver to add support for the component helper. The TDA998x driver retains support for the old way

Re: [PATCH] imx-drm: imx-drm-core: Remove unused 'imxdrm' variable

2014-02-08 Thread Russell King - ARM Linux
On Sat, Feb 08, 2014 at 06:49:49PM -0200, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Since commit 020a9ea7c2 (imx-drm: imx-drm-core: avoid going the long route round for drm_device) the 'imxdrm' variable is not used anymore, which causes the following build

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 10:04:30AM +0100, Daniel Vetter wrote: I've chatted a bit with Hans Verkuil about this topic at fosdem and apparently both v4l and alsa have something like this already in their helper libraries. Adding more people as fyi in case they want to switch to the new driver

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 12:57:21PM +0100, Jean-Francois Moine wrote: I started to use your code (which works fine, thanks), and it avoids a lot of problems, especially, about probe_defer in a DT context. I was wondering if your componentised mechanism could be extended to the devices defined

Re: [PATCH RFC 1/2] drivers/base: permit base components to omit the bind/unbind ops

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 04:55:00PM +0100, Jean-Francois Moine wrote: Some simple components don't need to do any specific action on bind to / unbind from a master component. This patch permits such components to omit the bind/unbind operations. Signed-off-by: Jean-Francois Moine

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote: This patch series tries to simplify the code of simple devices in case they are part of componentised subsystems, are declared in a DT, and are not using the component bin/unbind functions. I wonder - I said earlier today

Re: [PATCH RFC 2/2] drivers/base: declare phandle DT nodes as components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 05:53:27PM +0100, Jean-Francois Moine wrote: At system startup time, some devices depends on the availability of some other devices before starting. The infrastructure for componentised subsystems permits to handle this dependence, each driver defining its own role.

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 07:42:04PM +0100, Jean-Francois Moine wrote: On Fri, 7 Feb 2014 17:33:26 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote: This patch series tries to simplify the code of simple devices

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote: This patch series tries to simplify the code of simple devices in case they are part of componentised subsystems, are declared in a DT, and are not using the component bin/unbind functions. Here's my changes to the TDA998x

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 06:59:11PM +, Russell King - ARM Linux wrote: Sorry. Deferred probe does work, it's been tested with imx-drm, not only from the master component but also the sub-components. There's no problem here. Here's the proof that it also works with the Cubox, and armada

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2014-02-05 Thread Russell King - ARM Linux
On Wed, Feb 05, 2014 at 12:02:49PM -0800, Greg Kroah-Hartman wrote: On Tue, Dec 17, 2013 at 05:13:48PM -0800, Greg Kroah-Hartman wrote: I'll apply these after the first round goes into Linus's tree to make the merging easier (i.e. after the next -rc). Now applied. Thanks. I'll see about

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-11 Thread Russell King - ARM Linux
On Sat, Jan 11, 2014 at 12:31:19PM +0100, Robert Schwebel wrote: On Fri, Jan 10, 2014 at 11:23:37PM +, Russell King - ARM Linux wrote: We do this in DT by providing a superdevice node which specifies the components, eg: imx-drm { compatible = fsl,drm

Re: [RFC PATCH v2] staging: imx-hdmi: use rx sense status for plug detection if hpd is unreliable

2014-01-10 Thread Russell King - ARM Linux
On Fri, Jan 10, 2014 at 03:22:24PM +0100, Philipp Zabel wrote: Due to the voltage divider on the HPD line, the HDMI connector on imx6q-sabrelite doesn't reliably detect connected DVI monitors. This patch allows to use the RX_SENSE0 signal as a workaround when enabled by a boolean device tree

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-10 Thread Russell King - ARM Linux
On Thu, Jan 02, 2014 at 07:10:55PM -0800, Greg Kroah-Hartman wrote: On Thu, Jan 02, 2014 at 09:27:58PM +, Russell King wrote: Subsystems such as ALSA, DRM and others require a single card-level device structure to represent a subsystem. However, firmware tends to describe the

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-10 Thread Russell King - ARM Linux
On Fri, Jan 10, 2014 at 07:07:02AM -0800, Greg Kroah-Hartman wrote: On Fri, Jan 10, 2014 at 02:54:44PM +, Russell King - ARM Linux wrote: Greg, Not sure if you saw the outcome to your comment above. My conclusion was: Yes, I'm coming to that conclusion as well. It looks like

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-10 Thread Russell King - ARM Linux
On Fri, Jan 10, 2014 at 12:42:59PM -0800, Greg Kroah-Hartman wrote: On Fri, Jan 10, 2014 at 07:30:21PM +0100, Robert Schwebel wrote: On Fri, Jan 10, 2014 at 07:35:30AM -0800, Greg Kroah-Hartman wrote: I'll sort out a new set of patches today, along with a branch to pull if you wish to

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-09 Thread Russell King - ARM Linux
On Thu, Jan 09, 2014 at 11:25:38PM +0800, Shawn Guo wrote: Yea, adding all four into imx-drm crtcs works for imx6q, but it doesn't for imx6dl, because ipu2 is unavailable for imx6dl at all. Here is how I get around it. Thanks, I've rolled your change into this commit now. -- FTTC broadband

Re: [PATCH RFC 24/46] imx-drm: provide common connector mode validation function

2014-01-08 Thread Russell King - ARM Linux
On Tue, Jan 07, 2014 at 02:38:05PM +0800, Shawn Guo wrote: On Thu, Jan 02, 2014 at 09:27:48PM +, Russell King wrote: diff --git a/drivers/staging/imx-drm/imx-drm.h b/drivers/staging/imx-drm/imx-drm.h index 5649f180dc44..4eb594ce9cff 100644 --- a/drivers/staging/imx-drm/imx-drm.h

Re: [PATCH RFC 30/46] imx-drm: remove separate imx-fbdev

2014-01-08 Thread Russell King - ARM Linux
On Tue, Jan 07, 2014 at 02:49:50PM +0800, Shawn Guo wrote: On Thu, Jan 02, 2014 at 09:28:19PM +, Russell King wrote: @@ -449,6 +458,24 @@ static int imx_drm_driver_load(struct drm_device *drm, unsigned long flags) } } + /* +* All components are now

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-08 Thread Russell King - ARM Linux
On Tue, Jan 07, 2014 at 04:59:35PM +0800, Shawn Guo wrote: On Thu, Jan 02, 2014 at 09:28:03PM +, Russell King wrote: diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index e75e11b36dff..0e005f21d241 100644 ---

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-08 Thread Russell King - ARM Linux
On Tue, Jan 07, 2014 at 05:29:55PM +0100, Philipp Zabel wrote: Thanky you. This is what I came up with so far: From: Philipp Zabel p.za...@pengutronix.de Subject: [PATCH 1/2] staging: imx-hdmi: use RX_SENSE0 for plug detection if HPD is unreliable On some boards HPD might not reliably

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-06 Thread Russell King - ARM Linux
On Mon, Jan 06, 2014 at 06:41:28PM +0100, Philipp Zabel wrote: Hi Eric, Am Freitag, den 03.01.2014, 12:14 -0700 schrieb Eric Nelson: This is an issue we've seen before. The SABRE Lite board has a voltage divider on the HPD pins and some monitors (esp. DVI monitors) either don't drive

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Russell King - ARM Linux
On Thu, Jan 02, 2014 at 07:10:55PM -0800, Greg Kroah-Hartman wrote: On Thu, Jan 02, 2014 at 09:27:58PM +, Russell King wrote: Subsystems such as ALSA, DRM and others require a single card-level device structure to represent a subsystem. However, firmware tends to describe the

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 12:58:16PM +0100, Rafael J. Wysocki wrote: On Friday, January 03, 2014 11:00:30 AM Russell King - ARM Linux wrote: On Thu, Jan 02, 2014 at 07:10:55PM -0800, Greg Kroah-Hartman wrote: On Thu, Jan 02, 2014 at 09:27:58PM +, Russell King wrote: Subsystems

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 02:24:26PM +0100, Rafael J. Wysocki wrote: On Friday, January 03, 2014 12:18:13 PM Russell King - ARM Linux wrote: I'm not sure what I'm looking for. I've tried looking at the results of searching your linux-next branch for container but I don't see anything

Re: [PATCH RFC 21/46] drm: provide a helper for the encoder possible_crtcs mask

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 05:05:46PM +0100, David Herrmann wrote: Hi On Thu, Jan 2, 2014 at 10:27 PM, Russell King rmk+ker...@arm.linux.org.uk wrote: The encoder possible_crtcs mask identifies which CRTCs can be bound to a particular encoder. Each bit from bit 0 defines an index in the

Re: [PATCH RFC 21/46] drm: provide a helper for the encoder possible_crtcs mask

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 05:26:14PM +0100, David Herrmann wrote: Hi On Fri, Jan 3, 2014 at 5:13 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: I'm not so sure - since the only place this mask gets used is with the possible_crtcs field. It's got nothing to do

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 05:48:57PM +0100, Philipp Zabel wrote: Hi Russell, I've tested this series on a BD-SL (SabreLite) with HDMI. Right now the HPD signal doesn't seem to work, but after overwriting the connection check, I got a stable and correct picture on the monitor: Hmm. Does this

Re: [PATCH RFC 27/46] imx-drm: convert to componentised device support

2014-01-03 Thread Russell King - ARM Linux
On Fri, Jan 03, 2014 at 06:26:44PM +0100, Philipp Zabel wrote: Am Freitag, den 03.01.2014, 17:07 + schrieb Russell King - ARM Linux: On Fri, Jan 03, 2014 at 05:48:57PM +0100, Philipp Zabel wrote: Hi Russell, I've tested this series on a BD-SL (SabreLite) with HDMI. Right now

[PATCH RFC 00/46] Preview of imx-drm cleanup series

2014-01-02 Thread Russell King - ARM Linux
Here is my large patch series which cleans up imx-drm, and gets it ready to move out of drivers/staging. This is a preview only. One of these patches introduces a generic helper in drivers/base which can be used by any subsystem to assemble a sub-devices together and complete the probe of a

Re: [PATCH 3/4] imx-drm: fix missing symbol exports

2013-12-17 Thread Russell King - ARM Linux
On Tue, Dec 17, 2013 at 12:28:37PM +0800, Shawn Guo wrote: On Mon, Dec 16, 2013 at 11:34:05AM +, Russell King wrote: Trying to build a modular imx-drm results in a number of missing symbol exports, caused by the recent changes to this driver. Add the necessary exports, and the missing

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2013-12-17 Thread Russell King - ARM Linux
On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux wrote: Russell King (8): imx-drm: imx-drm-core: fix error cleanup path for imx_drm_add_crtc() imx-drm: imx-drm-core: fix DRM cleanup paths imx

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2013-12-17 Thread Russell King - ARM Linux
On Tue, Dec 17, 2013 at 08:05:41AM -0800, Greg Kroah-Hartman wrote: On Tue, Dec 17, 2013 at 03:17:02PM +, Russell King - ARM Linux wrote: On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux wrote: Russell King

[PATCH 0/4] Fix some bugs/races in imx-drm

2013-12-16 Thread Russell King - ARM Linux
The following patch series fixes some bugs and races in the imx-drm code, which should probably be applied to an -rc kernel. drivers/staging/imx-drm/imx-drm-core.c | 21 - drivers/staging/imx-drm/ipu-v3/ipu-common.c | 32 +-

Re: [PATCH 0/8] Fix some bugs/races in imx-drm

2013-12-16 Thread Russell King - ARM Linux
On Mon, Dec 16, 2013 at 11:33:01AM +, Russell King - ARM Linux wrote: The following patch series fixes some bugs and races in the imx-drm code, which should probably be applied to an -rc kernel. drivers/staging/imx-drm/imx-drm-core.c | 21 - drivers/staging/imx

Re: [PATCH 1/3] drm: Add LCD display clock polarity flags

2013-12-03 Thread Russell King - ARM Linux
On Tue, Dec 03, 2013 at 07:44:52PM +0800, Shawn Guo wrote: On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote: Add DRM flags for the LCD display clock polarity so the pixelclk-active DT property can be properly handled by drivers using the DRM API. Signed-off-by: Marek Vasut

Re: [PATCH 1/3] drm: Add LCD display clock polarity flags

2013-12-02 Thread Russell King - ARM Linux
On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote: Add DRM flags for the LCD display clock polarity so the pixelclk-active DT property can be properly handled by drivers using the DRM API. I still say that not even this should be part of the DRM mode API to userspace. The hint that

Re: [PATCHv3 1/8] drm: Add the lacking DRM_MODE_FLAG_* for matching the DISPLAY_FLAGS_*

2013-11-13 Thread Russell King - ARM Linux
On Wed, Nov 13, 2013 at 08:53:18AM +0100, Eric Bénard wrote: Hi Russell, Le Tue, 12 Nov 2013 17:04:55 +, Russell King - ARM Linux li...@arm.linux.org.uk a écrit : On Tue, Nov 12, 2013 at 05:49:18PM +0100, Denis Carikli wrote: diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm

Re: [PATCHv4][ 3/7] staging: imx-drm: Add RGB666 support for parallel display.

2013-11-13 Thread Russell King - ARM Linux
On Wed, Nov 13, 2013 at 11:43:44AM -0700, Troy Kisky wrote: On 11/13/2013 2:23 AM, Denis Carikli wrote: + /* rgb666 */ +ipu_dc_map_clear(priv, IPU_DC_MAP_RGB666); +ipu_dc_map_config(priv, IPU_DC_MAP_RGB666, 2, 17, 0xfc); /* red */ +ipu_dc_map_config(priv, IPU_DC_MAP_RGB666, 1,

Re: [PATCHv3 1/8] drm: Add the lacking DRM_MODE_FLAG_* for matching the DISPLAY_FLAGS_*

2013-11-12 Thread Russell King - ARM Linux
On Tue, Nov 12, 2013 at 05:49:18PM +0100, Denis Carikli wrote: diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index fc2adb6..586c12f 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -537,6 +537,15 @@ int

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-10-31 Thread Russell King - ARM Linux
On Thu, Oct 31, 2013 at 09:46:40AM -0200, Mauro Carvalho Chehab wrote: Hi Russell, Em Mon, 30 Sep 2013 13:57:47 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On 09/19/2013 11:44 PM, Russell King wrote: Replace the following sequence: dma_set_mask(dev, mask);

Re: [PATCH v4] imx-drm: Add mx6 hdmi transmitter support

2013-10-31 Thread Russell King - ARM Linux
On Thu, Oct 31, 2013 at 06:45:41PM -0200, Fabio Estevam wrote: Hi Troy, On Thu, Oct 31, 2013 at 6:38 PM, Troy Kisky troy.ki...@boundarydevices.com wrote: I get a magenta line down the left side of the screen unless I replace the 5 with a 6. ie. +for (count = 0; count 6;

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-30 Thread Russell King - ARM Linux
On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: + /*Wait for PHY PLL lock */ + msec = 4; + val = hdmi_readb(hdmi, HDMI_PHY_STAT0) HDMI_PHY_TX_PHY_LOCK; + while (!val) { + udelay(1000); + if (msec-- == 0) { +

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Russell King - ARM Linux
On Tue, Oct 29, 2013 at 01:45:50PM -0200, Fabio Estevam wrote: On Tue, Oct 29, 2013 at 1:00 PM, Fabio Estevam feste...@gmail.com wrote: Today I was able to get access to a wandboard solo and the HDMI image does look different compared to a wandboard quad board: - The Linux logo penguins

Re: [PATCH] imx-drm: ipuv3-crtc: Invert IPU DI0 clock polarity

2013-10-29 Thread Russell King - ARM Linux
On Tue, Oct 29, 2013 at 07:42:22PM -0200, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com sig_cfg.clk_pol controls the 'di0_polarity_disp_clk' bit of register IPUx_DI0_GENERAL through the following code in imx-drm/ipu-v3/ipu-di.c: if (!sig-clk_pol)

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-29 Thread Russell King - ARM Linux
On Tue, Oct 29, 2013 at 08:01:46PM -0200, Fabio Estevam wrote: Hi Greg, On Mon, Oct 28, 2013 at 7:03 PM, Greg KH gre...@linuxfoundation.org wrote: And why is new support being added to this driver instead of working to get it out of staging? Philipp Zabel mentioned that he will submit

Re: [PATCH v3] imx-drm: Add mx6 hdmi transmitter support

2013-10-28 Thread Russell King - ARM Linux
On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com This is based on the initial work done by Sascha Hauer and Tony Prisk. It looks like you've also taken some of the suggestions I've made too - like the voltage drive and symbol

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-20 Thread Russell King - ARM Linux
Another problem. After performing several modesets, the IPU seems to lock up and produce no syncs or output data. I've seen this many times over the last week while testing out various aspects of imx-drm, and had put it down to problems with the clocking arrangement getting its settings wrong.

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-20 Thread Russell King - ARM Linux
On Sun, Oct 20, 2013 at 02:00:57PM +0100, Russell King - ARM Linux wrote: As for imx-drm, there was a warning which preceded that oops. Here's the full log, below the - marker - this is from unbinding the imx-drm module, and then trying to reboot. imx-drm is really very broken

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-20 Thread Russell King - ARM Linux
On Sun, Oct 20, 2013 at 05:31:56PM +0100, Russell King - ARM Linux wrote: On Sun, Oct 20, 2013 at 02:00:57PM +0100, Russell King - ARM Linux wrote: As for imx-drm, there was a warning which preceded that oops. Here's the full log, below the - marker - this is from unbinding the imx

<    1   2   3   4   >