Re: [PATCH] staging: media: lirc: replace dev_err by pr_err

2014-11-05 Thread Aya Mahfouz
On Wed, Nov 05, 2014 at 12:57:38PM +0530, Sudip Mukherjee wrote: On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote: On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote: On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote: This patch replaces dev_err by

[PATCH] staging: dgap: remove unnecessary function

2014-11-05 Thread Daeseok Youn
The dgap_init_global() initialize the dgap_board that is a global variable as static and dgap_poll_timer. But init_timer() is called twice in dgap_start() and dgap_board doesn't need to be initialized to NULL. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |

Re: [PATCH 2/2] move imx-hdmi to bridge/dw-hdmi

2014-11-05 Thread Dan Carpenter
On Tue, Nov 04, 2014 at 09:39:58PM +0800, Andy Yan wrote: From: Andy yan andy@rock-chips.com Leave this out. It's for when you are forwarding a patch from someone else. Also it has a typo and your email From: header is correct. the original imx hdmi driver is under staging/imx-drm,

Re: [PATCH 0/2] staging: comedi: per-file read/write subdevice choice

2014-11-05 Thread Ian Abbott
On 04/11/2014 18:44, Hartley Sweeten wrote: On Tuesday, November 04, 2014 11:09 AM, Ian Abbott wrote: This series of patches adds a couple of ioctl codes to the Comedi core to allow the current read and write subdevice to be changed after opening the comedi device. The current read and write

Re: [PATCH] staging: media: lirc: replace dev_err by pr_err

2014-11-05 Thread Mauro Carvalho Chehab
Em Tue, 4 Nov 2014 02:13:19 +0200 Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu: This patch replaces dev_err by pr_err since the value of ir is NULL when the message is displayed. This one doesn't apply at the media tree: diff --git a/drivers/staging/media/lirc/lirc_zilog.c

Re: [PATCH] staging: media: lirc: modify print calls

2014-11-05 Thread Mauro Carvalho Chehab
Em Tue, 4 Nov 2014 23:43:07 +0200 Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu: This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls. Also doesn't apply. Probably made to apply on Greg's tree. Regards, Mauro Signed-off-by: Aya

Re: [PATCH] staging: panel: Fix single-open policy race condition

2014-11-05 Thread Dan Carpenter
On Tue, Nov 04, 2014 at 10:47:19PM +0100, Mariusz Gorski wrote: Fix the implementation of a single-open policy for both devices (lcd and keypad) by using atomic_t instead of plain ints. This seems like it might be a real life bug that you have experienced? The changelog should tell the user

Re: [PATCH 12/18] staging: comedi: s626: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread Ian Abbott
On 04/11/14 16:50, H Hartley Sweeten wrote: Remove the private data member 'ai_sample_count' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Also, remove the unnecessary COMEDI_CB_EOS event. The core automatically detects and adds that event. Signed-off-by: H

Re: [PATCH 14/18] staging: comedi: usbdux: use comedi_async 'scans_done' to detect AI EOA

2014-11-05 Thread Ian Abbott
On 04/11/14 16:50, H Hartley Sweeten wrote: Remove the private data member 'ai_sample_count' and use the comedi_async 'scans_done' member to detect the analog input end-of-acquisition. Move the EOA check so it happens after adding the samples from the current urb to the async buffer. This

Re: [PATCH 01/18] staging: comedi: comedidev.h: add 'scans_done' member to comedi_async

2014-11-05 Thread Ian Abbott
On 04/11/14 16:50, H Hartley Sweeten wrote: Introduce a new member to comedi_async to count the number of scans completed. This member is cleared by comedi_buf_reset() along with the other comedi_async members. It is incremented in comedi_inc_scan_progress() when the end of scan is detected.

Re: [PATCH] staging: media: lirc: modify print calls

2014-11-05 Thread Sudip Mukherjee
On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote: This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls. i think you should mention in the commit message why you are changing the device. and also for revised patch its better if

[PATCH v2] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-11-05 Thread Sanjeev Sharma
This is a patch to the rtw_cmd.c file that fixes Error reported by checkpatch. Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com --- Changes in v2: - Shorten variable name by taking temporary structure drivers/staging/rtl8723au/core/rtw_cmd.c | 126 +++ 1

Re: [PATCH 16/18] staging: comedi: usbduxsigma: use comedi_async 'scans_done' to detect AI EOA

2014-11-05 Thread Ian Abbott
On 04/11/14 16:50, H Hartley Sweeten wrote: Remove the private data member 'ai_sample_count' and use the comedi_async 'scans_done' member to detect the analog input end-of-acquisition. Move the EOA check so it happens after adding the samples from the current urb to the async buffer. This

RE: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-11-05 Thread Sharma, Sanjeev
-Original Message- From: Jes Sorensen [mailto:jes.soren...@redhat.com] Sent: Thursday, October 30, 2014 8:21 PM To: Sharma, Sanjeev Cc: Joe Perches; larry.fin...@lwfinger.net; gre...@linuxfoundation.org; linux-wirel...@vger.kernel.org; de...@driverdev.osuosl.org;

Re: [PATCH] staging: panel: Fix single-open policy race condition

2014-11-05 Thread Mariusz Gorski
On Wed, Nov 05, 2014 at 01:19:10PM +0300, Dan Carpenter wrote: On Tue, Nov 04, 2014 at 10:47:19PM +0100, Mariusz Gorski wrote: Fix the implementation of a single-open policy for both devices (lcd and keypad) by using atomic_t instead of plain ints. This seems like it might be a real

Re: [PATCH 00/13] staging: comedi: convert more drivers to use 'scans_done'

2014-11-05 Thread Ian Abbott
On 04/11/14 17:00, H Hartley Sweeten wrote: This series converts the remaining comedi drivers to use the comedi_async 'scans_done' member to count the number of scans completed when counting scans with a cmd-stop_src of TRIG_COUNT. H Hartley Sweeten (13): staging: comedi: drivers: introduce

Re: [PATCH 00/18] staging: comedi: make core track the number of scans

2014-11-05 Thread Ian Abbott
On 04/11/14 16:50, H Hartley Sweeten wrote: The comedi drivers that support async commands with a cmd-stop_src of TRIG_COUNT currently have a private data member that is used to count the number of scans completed in order to detect the end of acquisition for the command. This series addes a

[PATCH 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-05 Thread Andy Yan
imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also have some lightly difference, such as phy pll configuration, register width(imx hdmi register is one byte, but rk3288 is 4 bytes width), 4K support(imx6 doesn't support 4k, but

[PATCH V2 0/2] make imx hdmi publicly used by dw hdmi compatible platform

2014-11-05 Thread Andy Yan
We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also have some lightly difference, such as phy pll configuration, register width(imx hdmi register is one byte, but rk3288 is 4 bytes width and can only access by

[PATCH V2 2/2] move imx-hdmi to bridge/dw-hdmi

2014-11-05 Thread Andy Yan
the original imx hdmi driver is under staging/imx-drm, which depends on imx-drm, so move the imx hdmi drvier out to drm/bridge and rename imx-hdmi to dw-hdmi Signed-off-by: Andy Yan andy@rock-chips.com --- drivers/gpu/drm/bridge/Kconfig | 5 +

[PATCH V2 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-05 Thread Andy Yan
imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also have some lightly difference, such as phy pll configuration, register width(imx hdmi register is one byte, but rk3288 is 4 bytes width), 4K support(imx6 doesn't support 4k, but

Re: [PATCH V2 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-05 Thread Zubair Lutfullah Kakakhel
This one patch does too much to be reviewed easily. One patch is supposed to modify/add one thing at a time in the kernel. Separating platform specific code from imx-drm/imx-hdmi is one thing. Adding support for multi-byte register access is something different. i.e. Something like. 1/3 split

Re: [PATCH] staging: media: lirc: modify print calls

2014-11-05 Thread Aya Mahfouz
On Wed, Nov 05, 2014 at 04:59:15PM +0530, Sudip Mukherjee wrote: On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote: This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls. i think you should mention in the commit message why you

Re: [PATCH 1/2] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi

2014-11-05 Thread Philipp Zabel
Hi Andy, I think separating the core from the SoC specific part is a good step into the right direction. Am Mittwoch, den 05.11.2014, 20:55 +0800 schrieb Andy Yan: imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS) use the interface compatible Designware HDMI IP, but they also have

Re: [PATCH] staging: media: lirc: modify print calls

2014-11-05 Thread Aya Mahfouz
On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote: Em Tue, 4 Nov 2014 23:43:07 +0200 Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu: This patches replaces one pr_debug call by dev_dbg and changes the device used by one of the dev_err calls. Also doesn't apply.

Re: [PATCH 000/108] staging: comedi: addi_apci_3120: cleanup driver

2014-11-05 Thread Ian Abbott
On 04/11/14 17:53, H Hartley Sweeten wrote: Following is the big cleanup series for the ADDI-DATA APCI-3120 driver. Quick summary of the cleanup: * Removes all the CamelCase * Cleans up the register map defines * Fixes the Analog Input subdevice * Fixes the async command support

Re: [PATCH 02/15] [media] v4l: Update subdev-formats doc with new MEDIA_BUS_FMT values

2014-11-05 Thread Boris Brezillon
Hi Sakari, On Wed, 5 Nov 2014 16:57:27 +0200 Sakari Ailus sakari.ai...@iki.fi wrote: Hi Boris, On Tue, Nov 04, 2014 at 10:54:57AM +0100, Boris Brezillon wrote: In order to have subsytem agnostic media bus format definitions we've moved media bus definition to

Re: [PATCH 01/15] [media] Move mediabus format definition to a more standard place

2014-11-05 Thread Sakari Ailus
Hi, On Tue, Nov 04, 2014 at 12:09:59PM +0100, Hans Verkuil wrote: Well, I gave two alternatives :-) Both are fine as far as I am concerned, but it would be nice to hear what others think. In fact I think both are good options. :-) I'd perhaps lean towards the latter, for it has the benefit

Re: [PATCH 02/15] [media] v4l: Update subdev-formats doc with new MEDIA_BUS_FMT values

2014-11-05 Thread Sakari Ailus
Hi Boris, On Tue, Nov 04, 2014 at 10:54:57AM +0100, Boris Brezillon wrote: In order to have subsytem agnostic media bus format definitions we've moved media bus definition to include/uapi/linux/media-bus-format.h and prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT. Update

Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

2014-11-05 Thread Sakari Ailus
Hi Boris, On Tue, Nov 04, 2014 at 10:55:06AM +0100, Boris Brezillon wrote: The v4l2_mbus_pixelcode enum (or its values) should be replaced by the media_bus_format enum. Keep this enum in v4l2-mediabus.h and create a new header containing the v4l2_mbus_framefmt struct definition (which is not

Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

2014-11-05 Thread Boris Brezillon
On Wed, 5 Nov 2014 17:08:15 +0200 Sakari Ailus sakari.ai...@iki.fi wrote: Hi Boris, On Tue, Nov 04, 2014 at 10:55:06AM +0100, Boris Brezillon wrote: The v4l2_mbus_pixelcode enum (or its values) should be replaced by the media_bus_format enum. Keep this enum in v4l2-mediabus.h and create

Re: [PATCH 03/15] [media] Make use of the new media_bus_format definitions

2014-11-05 Thread Sakari Ailus
On Tue, Nov 04, 2014 at 10:54:58AM +0100, Boris Brezillon wrote: Replace references to the v4l2_mbus_pixelcode enum with the new media_bus_format enum in all common headers. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Acked-by: Sakari Ailus sakari.ai...@linux.intel.com

Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

2014-11-05 Thread Hans Verkuil
On 11/05/14 16:15, Boris Brezillon wrote: On Wed, 5 Nov 2014 17:08:15 +0200 Sakari Ailus sakari.ai...@iki.fi wrote: Hi Boris, On Tue, Nov 04, 2014 at 10:55:06AM +0100, Boris Brezillon wrote: The v4l2_mbus_pixelcode enum (or its values) should be replaced by the media_bus_format enum.

Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

2014-11-05 Thread Sakari Ailus
Hi Boris, On Wed, Nov 05, 2014 at 04:15:38PM +0100, Boris Brezillon wrote: On Wed, 5 Nov 2014 17:08:15 +0200 Sakari Ailus sakari.ai...@iki.fi wrote: I would keep the original file name, even if the compatibility definitions are there. I don't see any harm in having them around as well.

Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

2014-11-05 Thread Boris Brezillon
On Wed, 05 Nov 2014 16:19:56 +0100 Hans Verkuil hansv...@cisco.com wrote: On 11/05/14 16:15, Boris Brezillon wrote: On Wed, 5 Nov 2014 17:08:15 +0200 Sakari Ailus sakari.ai...@iki.fi wrote: Hi Boris, On Tue, Nov 04, 2014 at 10:55:06AM +0100, Boris Brezillon wrote: The

Re: [PATCH 01/15] [media] Move mediabus format definition to a more standard place

2014-11-05 Thread Boris Brezillon
On Wed, 5 Nov 2014 17:00:25 +0200 Sakari Ailus sakari.ai...@iki.fi wrote: Hi, On Tue, Nov 04, 2014 at 12:09:59PM +0100, Hans Verkuil wrote: Well, I gave two alternatives :-) Both are fine as far as I am concerned, but it would be nice to hear what others think. In fact I think

Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode

2014-11-05 Thread Hans Verkuil
On 11/05/14 16:30, Boris Brezillon wrote: On Wed, 05 Nov 2014 16:19:56 +0100 Hans Verkuil hansv...@cisco.com wrote: On 11/05/14 16:15, Boris Brezillon wrote: On Wed, 5 Nov 2014 17:08:15 +0200 Sakari Ailus sakari.ai...@iki.fi wrote: Hi Boris, On Tue, Nov 04, 2014 at 10:55:06AM +0100,

[PATCH] staging: unisys: Remove extra blank lines from virthba files

2014-11-05 Thread Ken Depro
From: Ken Depro kenneth.de...@unisys.com This patch removes extra blank lines from the virthba header and source files. This is the first of a set of patches that will clean up the virthba source file. The only checkpatch issue in the header file was the blank line warnings. Signed-off-by: Ken

[PATCH] Staging: rtl8192e: Fix segfault upon alloc failure

2014-11-05 Thread Daniel Dressler
Kernel space allocations can fail. This patch fixes a crash condition upon allocation failure. Should this condition occur init_firmware() will goto its error handler and declare download failure. Of interesting note is that prior to this patch fw_download_code() could never fail yet our caller

Re: [PATCH v2] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-11-05 Thread Greg KH
On Wed, Nov 05, 2014 at 05:05:03PM +0530, Sanjeev Sharma wrote: This is a patch to the rtw_cmd.c file that fixes Error reported by checkpatch. What error are you fixing? Please be specific. thanks, greg k-h ___ devel mailing list

Re: [PATCH] staging: media: lirc: modify print calls

2014-11-05 Thread Greg Kroah-Hartman
On Wed, Nov 05, 2014 at 03:43:44PM +0200, Aya Mahfouz wrote: On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote: Em Tue, 4 Nov 2014 23:43:07 +0200 Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu: This patches replaces one pr_debug call by dev_dbg and changes

RE: [PATCH 01/18] staging: comedi: comedidev.h: add 'scans_done' member to comedi_async

2014-11-05 Thread Hartley Sweeten
On Wednesday, November 05, 2014 4:25 AM, Ian Abbott wrote: On 04/11/14 16:50, H Hartley Sweeten wrote: Introduce a new member to comedi_async to count the number of scans completed. This member is cleared by comedi_buf_reset() along with the other comedi_async members. It is incremented in

Caro usuário

2014-11-05 Thread Administrador
Caro usuário Seu e-mail ultrapassou 2 GB criados pelo webmaster, que está atualmente em execução no 2.30GB, o que não é possível enviar ou receber nova mensagem dentro das próximas 24 horas, até que você verifique se você enviar e-mail da conta. Por favor, informe seus dados abaixo para

Re: [PATCH v2] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-11-05 Thread Joe Perches
On Wed, 2014-11-05 at 17:05 +0530, Sanjeev Sharma wrote: This is a patch to the rtw_cmd.c file that fixes Error reported by checkpatch. Please run your patches through checkpatch before sending them. WARNING: suspect code indent for conditional statements (24, 24) #178: FILE:

[PATCH v2 02/18] staging: comedi: addi_apci_2032: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'stop_count' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 03/18] staging: comedi: amplc_dio200_common: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'stopcount' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 01/18] staging: comedi: comedidev.h: add 'scans_done' member to comedi_async

2014-11-05 Thread H Hartley Sweeten
Introduce a new member to comedi_async to count the number of scans completed. This member is cleared by comedi_buf_reset() along with the other comedi_async members. It is incremented in comedi_inc_scan_progress() when the end of scan is detected. This member will be used to clean up the scan

[PATCH v2 04/18] staging: comedi: pcl711: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ntrig' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 00/18] staging: comedi: make core track the number of scans

2014-11-05 Thread H Hartley Sweeten
The comedi drivers that support async commands with a cmd-stop_src of TRIG_COUNT currently have a private data member that is used to count the number of scans completed in order to detect the end of acquisition for the command. This series addes a new member, 'scans_done', to comedi_async and

[PATCH v2 05/18] staging: comedi: pcl812: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ai_act_scan' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 11/18] staging: comedi: pcmuio: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'stop_count' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 10/18] staging: comedi: pcmmio: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'count' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 06/18] staging: comedi: pcl816: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ai_act_scan' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 09/18] staging: comedi: adv_pci1710: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ai_act_scan' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 15/18] staging: comedi: usbduxsigma: use comedi_async 'scans_done' to detect AO EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ao_sample_count' and use the comedi_async 'scans_done' member to detect the analog output end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH v2 08/18] staging: comedi: pcl818: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ai_act_scan' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 12/18] staging: comedi: s626: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ai_sample_count' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Also, remove the unnecessary COMEDI_CB_EOS event. The core automatically detects and adds that event. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc:

[PATCH v2 18/18] staging: comedi: das800: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'count' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 17/18] staging: comedi: addi_apci_3120: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ai_AiActualScan' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. The function v_APCI3120_InterruptDmaMoveBlock16bit() is then just a wrapper for comedi_buf_write_samples(). Remove it. Signed-off-by: H Hartley Sweeten

[PATCH v2 14/18] staging: comedi: usbdux: use comedi_async 'scans_done' to detect AI EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ai_sample_count' and use the comedi_async 'scans_done' member to detect the analog input end-of-acquisition. Move the EOA check so it happens after adding the samples from the current urb to the async buffer. This prevents the unnecessary resubmit of the urb when

[PATCH v2 13/18] staging: comedi: usbdux: use comedi_async 'scans_done' to detect AO EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ao_sample_count' and use the comedi_async 'scans_done' member to detect the analog output end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH v2 07/18] staging: comedi: pcl818: remove private data member 'ai_act_chan'

2014-11-05 Thread H Hartley Sweeten
This member of the private data is set to '0' but never used. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/pcl818.c | 2 -- 1 file changed, 2

[PATCH v2 16/18] staging: comedi: usbduxsigma: use comedi_async 'scans_done' to detect AI EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ai_sample_count' and use the comedi_async 'scans_done' member to detect the analog input end-of-acquisition. Move the EOA check so it happens after adding the samples from the current urb to the async buffer. This prevents the unnecessary resubmit of the urb when

Re: [PATCH v2 00/18] staging: comedi: make core track the number of scans

2014-11-05 Thread Ian Abbott
On 05/11/2014 17:20, H Hartley Sweeten wrote: The comedi drivers that support async commands with a cmd-stop_src of TRIG_COUNT currently have a private data member that is used to count the number of scans completed in order to detect the end of acquisition for the command. This series addes a

[PATCH v2 05/13] staging: comedi: drivers: introduce comedi_nsamples_left()

2014-11-05 Thread H Hartley Sweeten
Introduce a helper function to calculate the number of samples remaining when the cmd-stop_src is TRIG_COUNT. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 04/13] staging: comedi: amplc_pci230: use comedi_async 'scans_done' to detect AO EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ai_count' and use the comedi_async 'scans_done' member to detect the analog output end-of-acquisition. Use the helper function comedi_nscans_left() to get the number of scans in the async buffer of left in the command. Signed-off-by: H Hartley Sweeten

[PATCH v2 03/13] staging: comedi: comedi_test: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ai_count' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Use the helper function comedi_nscans_left() to check if the number of scans left in the command. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by:

[PATCH v2 00/13] staging: comedi: convert more drivers to use 'scans_done'

2014-11-05 Thread H Hartley Sweeten
This series converts the remaining comedi drivers to use the comedi_async 'scans_done' member to count the number of scans completed when counting scans with a cmd-stop_src of TRIG_COUNT. v2: Fix PATCH 01/13 as pointed out by Ian Abbott H Hartley Sweeten (13): staging: comedi: drivers:

[PATCH v2 02/13] staging: comedi: amplc_pci224: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ao_stop_count' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Use the helper function comedi_nscans_left() to determine the number of scans available in the async buffer or left in the command. Signed-off-by: H Hartley Sweeten

[PATCH v2 08/13] staging: comedi: cb_pcidas: use comedi_async 'scans_done' to detect AI EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'count' and use the comedi_async 'scans_done' member to detect the analog input end-of-acquisition. Use the comedi_nsamples_left() helper to get the number of samples to actually add to the async buffer. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com

[PATCH v2 09/13] staging: comedi: cb_pcidas: use comedi_async 'scans_done' to detect AO EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ao_count' and use the comedi_async 'scans_done' member to detect the analog output end-of-acquisition. Use the comedi_nsamples_left() helper to get the number of samples to actually read from the async buffer. Signed-off-by: H Hartley Sweeten

[PATCH v2 07/13] staging: comedi: usbduxfast: use comedi_async 'scans_done' to detect AI EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ai_sample_count' and use the comedi_async 'scans_done' member to detect the analog input end-of-acquisition. Use the comedi_nsamples_left() helper to get the number of samples to actually add to the async buffer. Signed-off-by: H Hartley Sweeten

[PATCH v2 01/13] staging: comedi: drivers: introduce comedi_nscans_left()

2014-11-05 Thread H Hartley Sweeten
Introduce a helper function to determine the number of scans left in the async command. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/comedidev.h | 2 ++

[PATCH v2 11/13] staging: comedi: cb_pcidas64: use comedi_async 'scans_done' to detect AO EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ao_count' and use the comedi_async 'scans_done' member to detect the analog output end-of-acquisition. Use the comedi_nsamples_left() helper to get the number of samples to actually read from the async buffer. Signed-off-by: H Hartley Sweeten

[PATCH v2 12/13] staging: comedi: quatech_daqp_cs: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'count' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH v2 13/13] staging: comedi: das1800: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'count' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Use the comedi_nsamples_left() helper to get the number of samples to actually add to the async buffer. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Reviewed-by:

[PATCH v2 06/13] staging: comedi: amplc_pci230: use comedi_async 'scans_done' to detect AI EOA

2014-11-05 Thread H Hartley Sweeten
Remove the private data member 'ai_scan_count' and use the comedi_async 'scans_done' member to detect the analog input end-of-acquisition. Use the comedi_nsamples_left() helper to work out the number of 'wake' samples in pci230_ai_update_fifo_trigger_level() and the number of 'todo' samples

[PATCH] staging: unisys: remove unused types from visorchipset.h

2014-11-05 Thread Benjamin Romer
Delete the following unused types, and unused function prototypes: VISORCHIPSET_SWITCH_INFO VISORCHIPSET_EXTERNALPORT_INFO VISORCHIPSET_INTERNALPORT_INFO visorchipset_get_switch_info() visorchipset_get_externalport_info() Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com ---

[PATCH] staging: unisys: remove unused functions from uislib.c

2014-11-05 Thread Benjamin Romer
Delete uislib_client_add_vnic() and uislib_client_delete_vnic(), since these are never used. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/uislib/uislib.c | 76 -- 1 file changed, 76 deletions(-) diff --git

RE: [PATCH 000/108] staging: comedi: addi_apci_3120: cleanup driver

2014-11-05 Thread Hartley Sweeten
On Wednesday, November 05, 2014 7:48 AM, Ian Abbott wrote: On 04/11/14 17:53, H Hartley Sweeten wrote: Following is the big cleanup series for the ADDI-DATA APCI-3120 driver. Quick summary of the cleanup: * Removes all the CamelCase * Cleans up the register map defines * Fixes the

RE: [PATCH 12/18] staging: comedi: s626: use comedi_async 'scans_done' to detect EOA

2014-11-05 Thread Hartley Sweeten
On Wednesday, November 05, 2014 4:08 AM, Ian Abbott wrote: On 04/11/14 16:50, H Hartley Sweeten wrote: Remove the private data member 'ai_sample_count' and use the comedi_async 'scans_done' member to detect the end-of-acquisition. Also, remove the unnecessary COMEDI_CB_EOS event. The core

Re: [PATCH 04/15] staging: unisys: add comment to spinlock in struct charqueue

2014-11-05 Thread Greg KH
On Tue, Nov 04, 2014 at 11:25:14AM -0500, Benjamin Romer wrote: Add a comment to the charqueue's spinlock to explain that it is a lock for the structure. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visorutil/charqueue.c | 2 +- 1 file changed, 1

Re: [PATCH] staging: unisys: remove unused types from visorchipset.h

2014-11-05 Thread Greg KH
On Wed, Nov 05, 2014 at 12:47:49PM -0500, Benjamin Romer wrote: Delete the following unused types, and unused function prototypes: VISORCHIPSET_SWITCH_INFO VISORCHIPSET_EXTERNALPORT_INFO VISORCHIPSET_INTERNALPORT_INFO visorchipset_get_switch_info() visorchipset_get_externalport_info()

Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver

2014-11-05 Thread sostalle
On Mon, Nov 03, 2014 at 04:13:55PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 04:04:42PM -0800, steph wrote: On Mon, Nov 03, 2014 at 01:21:39PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote: [snip] +static int mausb_hcd_init(void) +{

[PATCH] staging: unisys: Remove unnecessary spaces after casts in virthba.c

2014-11-05 Thread Ken Depro
From: Ken Depro kenneth.de...@unisys.com This patch removes unneeded spaces after casts within the virthba.c file. The checkpatch script was run after these changes, and no remove spaces after casts checks were generated. Later patches will fix the other checkpatch warnings/checks.

Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver

2014-11-05 Thread Greg KH
On Wed, Nov 05, 2014 at 12:14:33PM -0800, sostalle wrote: On Mon, Nov 03, 2014 at 04:13:55PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 04:04:42PM -0800, steph wrote: On Mon, Nov 03, 2014 at 01:21:39PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick

Re: [PATCH 0/5] staging: comedi: split bus support into separate modules

2014-11-05 Thread Greg Kroah-Hartman
On Fri, Oct 31, 2014 at 11:00:54PM +, Ian Abbott wrote: On 31/10/14 22:53, Ian Abbott wrote: I like the idea of the core comedi module being separated from all the various buses. And other buses can be added easily without pulling extra dependencies into the core (e.g. for platform or spi

Re: [PATCH] Staging: rtl8192e: Fix segfault upon alloc failure

2014-11-05 Thread Greg Kroah-Hartman
On Thu, Nov 06, 2014 at 01:11:17AM +0900, Daniel Dressler wrote: Kernel space allocations can fail. This patch fixes a crash condition upon allocation failure. Should this condition occur init_firmware() will goto its error handler and declare download failure. Of interesting note is that

Re: [PATCH] staging: unisys: Remove unnecessary spaces after casts in virthba.c

2014-11-05 Thread Greg KH
On Wed, Nov 05, 2014 at 04:04:32PM -0500, Ken Depro wrote: From: Ken Depro kenneth.de...@unisys.com This patch removes unneeded spaces after casts within the virthba.c file. The checkpatch script was run after these changes, and no remove spaces after casts checks were generated. Later

RE: [PATCH 0/5] staging: comedi: split bus support into separate modules

2014-11-05 Thread Hartley Sweeten
On Wednesday, November 05, 2014 3:51 PM, Greg Kroah-Hartman wrote: On Fri, Oct 31, 2014 at 11:00:54PM +, Ian Abbott wrote: On 31/10/14 22:53, Ian Abbott wrote: I like the idea of the core comedi module being separated from all the various buses. And other buses can be added easily without

RE: [PATCH v2] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-11-05 Thread Sharma, Sanjeev
-Original Message- From: Joe Perches [mailto:j...@perches.com] Sent: Wednesday, November 05, 2014 10:46 PM To: Sharma, Sanjeev Cc: larry.fin...@lwfinger.net; jes.soren...@redhat.com; gre...@linuxfoundation.org; linux-wirel...@vger.kernel.org; de...@driverdev.osuosl.org;

[PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-11-05 Thread Sanjeev Sharma
This is a patch to the rtw_cmd.c file that fixes following error. ERROR: spaces required around that '' (ctx:WxV) ERROR: that open brace { should be on the previous line Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com --- drivers/staging/rtl8723au/core/rtw_cmd.c | 83

[PATCH] staging:rtl8723au: core: Fix Warning reported by checkpatch.

2014-11-05 Thread Sanjeev Sharma
This is a patch to the rtw_cmd.c file that fixes following Warning by introducing temporary structure. WARNING: line over 80 characters Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com --- drivers/staging/rtl8723au/core/rtw_cmd.c | 123 +++ 1 file changed, 60

RE: [PATCH v2] staging:rtl8723au: core: Fix error reported by checkpatch.

2014-11-05 Thread Sharma, Sanjeev
-Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Wednesday, November 05, 2014 9:58 PM To: Sharma, Sanjeev Cc: larry.fin...@lwfinger.net; jes.soren...@redhat.com; de...@driverdev.osuosl.org; linux-wirel...@vger.kernel.org; linux-ker...@vger.kernel.org Subject: