Getting the ccree driver out of staging

2018-01-09 Thread Gilad Ben-Yossef
Hi folks, With the enormous help of people in the to and CCed lists I've gotten the ccree driver to a point I believe it is ready to graduate out of the staging tree: - The code base has been reduced by something by 30% and is *much* more readable and manageable. - The very few checkpatch

RE: [PATCH] storvsc: do not assume SG list is continuous when doing bounce buffers (for 4.1 stable only)

2018-01-09 Thread Long Li
> Christoph, > > > Ok. If the stable maintainers are ok with your small fix I'm not > > going to complain too loudly. But I'm always worried about stable > > trees divering too much from mainline. > > The seemingly innocuous transition from SG_GAPS to virt boundary has > caused several data

Re: [PATCH] staging: pi433: remove unnecessary parentheses

2018-01-09 Thread Joe Perches
On Tue, 2018-01-09 at 20:28 +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 09, 2018 at 11:21:37AM -0800, Joe Perches wrote: > > On Tue, 2018-01-09 at 15:31 +0100, Greg Kroah-Hartman wrote: > > > On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote: > > > > Fixes checkpatch warnings: > >

[PATCH v3 4/6] uio_hv_generic: check that host supports monitor page

2018-01-09 Thread Stephen Hemminger
In order for userspace application to signal host, it needs the host to support the monitor page property. Check for the flag and fail if this is not supported. Signed-off-by: Stephen Hemminger --- drivers/uio/uio_hv_generic.c | 7 +++ 1 file changed, 7 insertions(+)

[PATCH v3 5/6] uio_hv_generic: add rescind support

2018-01-09 Thread Stephen Hemminger
When host rescinds the device, the UIO driver will clear the interrupt state and notify application. The read (or write) on the interrupt FD will then fail with -EIO. This is simpler than adding lots extra uevent stuff inside UIO. Signed-off-by: Stephen Hemminger ---

[PATCH v3 2/6] uio: document uio_hv_generic regions

2018-01-09 Thread Stephen Hemminger
Describe the regions present with uio_hv_generic in documentation for driver API. Signed-off-by: Stephen Hemminger --- Documentation/driver-api/uio-howto.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/driver-api/uio-howto.rst

[PATCH v3 6/6] uio_hv_generic: support sub-channels

2018-01-09 Thread Stephen Hemminger
Use sysfs to allow supporting sub-channels. The userspace application makes request to host to create sub-channels and the UIO kernel driver populates the sysfs per-channel directory with a binary attribute file that can be used to read/write ring. Signed-off-by: Stephen Hemminger

[PATCH v3 3/6] uio_hv_generic: create send and receive buffers

2018-01-09 Thread Stephen Hemminger
Map in receive and send buffers for networking in UIO device. These buffers are special and need to be setup by kernel API's; userspace can not do it. Signed-off-by: Stephen Hemminger --- Documentation/driver-api/uio-howto.rst | 2 + drivers/uio/uio_hv_generic.c

[PATCH v3 0/6] uio_hv_generice improvements

2018-01-09 Thread Stephen Hemminger
These patches extend uio_hv_generic driver to make it usable for DPDK networking. The original version did not enough functionality to support userspace network drivers. Needed support of send/receive buffers and sub channels. Patches against current char-misc-next v3 - rebase on current

[PATCH v3 1/6] doc: fix documentation about uio_hv_generic

2018-01-09 Thread Stephen Hemminger
The vmbus sysfs file names changed in commit f6b2db084b65 ("vmbus: make sysfs names consistent with PCI") and the uio documenatation does not match the current names. Signed-off-by: Stephen Hemminger --- Documentation/driver-api/uio-howto.rst | 15 --- 1

Re: [PATCH] staging: pi433: Cleanup codestyle, indent statements after case labels

2018-01-09 Thread Dan Carpenter
On Tue, Jan 09, 2018 at 09:04:50PM +0100, Valentin Vidic wrote: > On Sun, Dec 24, 2017 at 02:42:57PM +0100, Marcus Wolf wrote: > > > int rf69_set_dagc(struct spi_device *spi, enum dagc dagc) > > > { > > > switch (dagc) { > > > - case normalMode: return rf69_write_reg(spi, > >

Re: [PATCH] staging: pi433: Cleanup codestyle, indent statements after case labels

2018-01-09 Thread Marcus Wolf
Am 09.01.2018 um 21:04 schrieb Valentin Vidic: > On Sun, Dec 24, 2017 at 02:42:57PM +0100, Marcus Wolf wrote: >>> int rf69_set_dagc(struct spi_device *spi, enum dagc dagc) >>> { >>> switch (dagc) { >>> - case normalMode: return rf69_write_reg(spi, >>> REG_TESTDAGC,

Re: [PATCH] staging: pi433: Cleanup codestyle, indent statements after case labels

2018-01-09 Thread Valentin Vidic
On Sun, Dec 24, 2017 at 02:42:57PM +0100, Marcus Wolf wrote: > > int rf69_set_dagc(struct spi_device *spi, enum dagc dagc) > > { > > switch (dagc) { > > - case normalMode: return rf69_write_reg(spi, > > REG_TESTDAGC, DAGC_NORMAL); > > - case improve:

Re: [PATCH 2/2] drivers: android: Fix logtags in methods

2018-01-09 Thread Greg Kroah-Hartman
On Tue, Jan 09, 2018 at 07:45:33PM +, Harsh Shandilya wrote: > On Tue 9 Jan, 2018, 10:32 PM Greg Kroah-Hartman, > wrote: > > > On Fri, Dec 22, 2017 at 07:37:03PM +0530, Harsh Shandilya wrote: > > > From: Harsh Shandilya > > > > > > Several methods

Re: [PATCH] staging: pi433: remove unnecessary parentheses

2018-01-09 Thread Joe Perches
On Tue, 2018-01-09 at 15:31 +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote: > > Fixes checkpatch warnings: > > CHECK: Unnecessary parentheses around 'mantisse != mantisse16' > > CHECK: Unnecessary parentheses around 'mantisse != mantisse20' >

Re: [PATCH] staging: pi433: remove unnecessary parentheses

2018-01-09 Thread Greg Kroah-Hartman
On Tue, Jan 09, 2018 at 11:21:37AM -0800, Joe Perches wrote: > On Tue, 2018-01-09 at 15:31 +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote: > > > Fixes checkpatch warnings: > > > CHECK: Unnecessary parentheses around 'mantisse != mantisse16' >

Re: [PATCH 05/10] uio_hv_generic: make ring size configurable

2018-01-09 Thread Greg KH
On Tue, Jan 09, 2018 at 11:14:11AM -0800, Stephen Hemminger wrote: > On Tue, 9 Jan 2018 19:58:34 +0100 > Greg KH wrote: > > > On Tue, Jan 09, 2018 at 10:53:10AM -0800, Stephen Hemminger wrote: > > > On Tue, 9 Jan 2018 19:42:40 +0100 > > > Greg KH

Re: [PATCH 05/10] uio_hv_generic: make ring size configurable

2018-01-09 Thread Stephen Hemminger
On Tue, 9 Jan 2018 19:58:34 +0100 Greg KH wrote: > On Tue, Jan 09, 2018 at 10:53:10AM -0800, Stephen Hemminger wrote: > > On Tue, 9 Jan 2018 19:42:40 +0100 > > Greg KH wrote: > > > > > On Thu, Jan 04, 2018 at 02:13:29PM -0800, Stephen

Re: [PATCH 05/10] uio_hv_generic: make ring size configurable

2018-01-09 Thread Greg KH
On Tue, Jan 09, 2018 at 10:53:10AM -0800, Stephen Hemminger wrote: > On Tue, 9 Jan 2018 19:42:40 +0100 > Greg KH wrote: > > > On Thu, Jan 04, 2018 at 02:13:29PM -0800, Stephen Hemminger wrote: > > > Allow setting size of ring buffer for host communication via > > >

Re: [PATCH 05/10] uio_hv_generic: make ring size configurable

2018-01-09 Thread Stephen Hemminger
On Tue, 9 Jan 2018 19:42:40 +0100 Greg KH wrote: > On Thu, Jan 04, 2018 at 02:13:29PM -0800, Stephen Hemminger wrote: > > Allow setting size of ring buffer for host communication via > > module parameter. > > > > Signed-off-by: Stephen Hemminger

Re: [PATCH v2 00/11] vmbus and uio_hv_generice improvements

2018-01-09 Thread Greg KH
On Tue, Jan 09, 2018 at 10:29:03AM -0800, Stephen Hemminger wrote: > These patches improve vmbus sysfs support for better management and > make the UIO hyperv driver usable. The original version did not enough > functionality to support userspace network drivers. Needed support > of send/receive

Re: [PATCH 08/10] uio_hv_generic: check that host supports monitor page

2018-01-09 Thread Greg KH
On Thu, Jan 04, 2018 at 02:13:32PM -0800, Stephen Hemminger wrote: > In order for userspace application to signal host, it needs the > host to support the monitor page property. Check for the flag > and fail if this is not supported. > > Signed-off-by: Stephen Hemminger >

Re: [PATCH 06/10] uio_hv_generic: create send and receive buffers

2018-01-09 Thread Greg KH
On Thu, Jan 04, 2018 at 02:13:30PM -0800, Stephen Hemminger wrote: > Map in receive and send buffers for networking in UIO device. > These buffers are special and need to be setup by kernel > API's. > > Signed-off-by: Stephen Hemminger > --- >

Re: [PATCH 05/10] uio_hv_generic: make ring size configurable

2018-01-09 Thread Greg KH
On Thu, Jan 04, 2018 at 02:13:29PM -0800, Stephen Hemminger wrote: > Allow setting size of ring buffer for host communication via > module parameter. > > Signed-off-by: Stephen Hemminger > --- > drivers/uio/uio_hv_generic.c | 25 + > 1 file

[PATCH v2 08/11] uio_hv_generic: use ISR callback method

2018-01-09 Thread Stephen Hemminger
The UIO IRQ handler doesn't need to be called from a tasklet. Signed-off-by: Stephen Hemminger --- drivers/uio/uio_hv_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c index

[PATCH v2 06/11] uio_hv_generic: make ring size configurable

2018-01-09 Thread Stephen Hemminger
Allow setting size of ring buffer for host communication via module parameter. Signed-off-by: Stephen Hemminger --- drivers/uio/uio_hv_generic.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/uio/uio_hv_generic.c

[PATCH v2 10/11] uio_hv_generic: add rescind support

2018-01-09 Thread Stephen Hemminger
When host rescinds the device, the UIO driver will clear the interrupt state and notify application. The read (or write) on the interrupt FD will then fail with -EIO. This is simpler than adding lots extra uevent stuff inside UIO. Signed-off-by: Stephen Hemminger ---

[PATCH v2 09/11] uio_hv_generic: check that host supports monitor page

2018-01-09 Thread Stephen Hemminger
In order for userspace application to signal host, it needs the host to support the monitor page property. Check for the flag and fail if this is not supported. Signed-off-by: Stephen Hemminger --- drivers/uio/uio_hv_generic.c | 20 ++-- 1 file changed,

[PATCH v2 11/11] uio_hv_generic: support sub-channels

2018-01-09 Thread Stephen Hemminger
Use sysfs to allow supporting sub-channels. The userspace application makes request to host to create sub-channels and the UIO kernel driver populates the sysfs per-channel directory with a binary attribute file that can be used to read/write ring. Signed-off-by: Stephen Hemminger

[PATCH v2 05/11] uio_hv_generic: use standard mmap for resources

2018-01-09 Thread Stephen Hemminger
The generic UIO mmap should work for us. Signed-off-by: Stephen Hemminger --- drivers/uio/uio_hv_generic.c | 33 +++-- 1 file changed, 7 insertions(+), 26 deletions(-) diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c

[PATCH v2 07/11] uio_hv_generic: create send and receive buffers

2018-01-09 Thread Stephen Hemminger
Map in receive and send buffers for networking in UIO device. These buffers are special and need to be setup by kernel API's. Signed-off-by: Stephen Hemminger --- Documentation/driver-api/uio-howto.rst | 2 + drivers/uio/uio_hv_generic.c | 114

[PATCH v2 02/11] vmbus: fix ABI documentation

2018-01-09 Thread Stephen Hemminger
Fixes to vmbus ABI document including: - make it clear that relid is numeric value in sub directory - clarify interrupt mask description - spelling fixes - document regions Signed-off-by: Stephen Hemminger ---

[PATCH v2 04/11] uio_hv_generic: fix documentation and configuration comments

2018-01-09 Thread Stephen Hemminger
The suggested method for configuration does not work with current kernels. Paths and ids changed. Signed-off-by: Stephen Hemminger --- Documentation/driver-api/uio-howto.rst | 20 +--- drivers/uio/uio_hv_generic.c | 8 +--- 2 files changed,

[PATCH v2 03/11] vmbus: add monitor_id and subchannel_id to sysfs per channel

2018-01-09 Thread Stephen Hemminger
Useful to identify which network queue is associated with which vmbus channel. Signed-off-by: Stephen Hemminger --- Documentation/ABI/stable/sysfs-bus-vmbus | 14 ++ drivers/hv/vmbus_drv.c | 17 + 2 files changed, 31

[PATCH v2 01/11] vmbus: make channel attributes static

2018-01-09 Thread Stephen Hemminger
These channel attribute data structures are only used by vmbus_drv sysfs routines. Signed-off-by: Stephen Hemminger --- drivers/hv/vmbus_drv.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/hv/vmbus_drv.c

[PATCH v2 00/11] vmbus and uio_hv_generice improvements

2018-01-09 Thread Stephen Hemminger
These patches improve vmbus sysfs support for better management and make the UIO hyperv driver usable. The original version did not enough functionality to support userspace network drivers. Needed support of send/receive buffers and sub channels. Patches against current char-misc-next v2 -

[PATCH][staging-next] ncpfs: remove redundant cast of struct ncp_inode_info

2018-01-09 Thread Colin King
From: Colin Ian King Casting a value returned by memory an allocation function is not required and can be removed. Also add in a newline after before the first statement. Code clean up as suggested by coccinelle. Signed-off-by: Colin Ian King

Re: [PATCH 2/2] drivers: android: Fix logtags in methods

2018-01-09 Thread Greg Kroah-Hartman
On Fri, Dec 22, 2017 at 07:37:03PM +0530, Harsh Shandilya wrote: > From: Harsh Shandilya > > Several methods in the driver were hardcoding > the function name in their logging calls which > is a checkpatch violation. Utilise the __func__ > macro to avoid needing to add the

Re: [PATCH v2] staging: rtl8723bs: Fix trailing semicolon

2018-01-09 Thread Luis de Bethencourt
On 01/09/2018 04:46 PM, Greg Kroah-Hartman wrote: > On Tue, Jan 09, 2018 at 04:17:01PM +, Luis de Bethencourt wrote: >> Fix trailing semicolon. > > Please be more explicit. That says what it does, but not _why_ :) > After walking around with my head down in shame I sent a new version.

[PATCH v3] staging: rtl8723bs: Fix trailing semicolon

2018-01-09 Thread Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt --- Hi all, Testing the waters with this cleanup patch. If it is OK to send these there are two very similar ones, plus more in

Re: [PATCH] staging: rtl8723bs: Fix trailing semicolon

2018-01-09 Thread Greg Kroah-Hartman
On Tue, Jan 09, 2018 at 05:11:52PM +0100, Hans de Goede wrote: > Hi, > > On 09-01-18 17:02, Luis de Bethencourt wrote: > > On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote: > > > On Tue, Jan 09, 2018 at 03:09:27PM +, Luis de Bethencourt wrote: > > > > Signed-off-by: Luis de Bethencourt

Re: [PATCH v2] staging: rtl8723bs: Fix trailing semicolon

2018-01-09 Thread Greg Kroah-Hartman
On Tue, Jan 09, 2018 at 04:17:01PM +, Luis de Bethencourt wrote: > Fix trailing semicolon. Please be more explicit. That says what it does, but not _why_ :) ___ devel mailing list de...@linuxdriverproject.org

[PATCH 1/1] staging: pi433: Cleanup codestyle, indent statements after case labels

2018-01-09 Thread Michael Panzlaff
This patch changes the indentation of the statements after case labels. The linux coding guidelines do not explicitly mentiond this but pretty much all existing code doesn't put any statements into the same line of their belonging case labels. Therefore this adapts to the more usual style. Please

[PATCH v2] staging: rtl8723bs: Fix trailing semicolon

2018-01-09 Thread Luis de Bethencourt
Fix trailing semicolon. Signed-off-by: Luis de Bethencourt --- Changes since v1: - Added a changelog body to the commit message drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] staging: rtl8723bs: Fix trailing semicolon

2018-01-09 Thread Luis de Bethencourt
On 01/09/2018 04:11 PM, Hans de Goede wrote: > Hi, > > On 09-01-18 17:02, Luis de Bethencourt wrote: >> On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote: >>> On Tue, Jan 09, 2018 at 03:09:27PM +, Luis de Bethencourt wrote: Signed-off-by: Luis de Bethencourt ---

Re: [PATCH] staging: rtl8723bs: Fix trailing semicolon

2018-01-09 Thread Hans de Goede
Hi, On 09-01-18 17:02, Luis de Bethencourt wrote: On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote: On Tue, Jan 09, 2018 at 03:09:27PM +, Luis de Bethencourt wrote: Signed-off-by: Luis de Bethencourt --- I can't take patches without any changelog text, sorry :( Hi

Re: [PATCH] staging: rtl8723bs: Fix trailing semicolon

2018-01-09 Thread Luis de Bethencourt
On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote: > On Tue, Jan 09, 2018 at 03:09:27PM +, Luis de Bethencourt wrote: >> Signed-off-by: Luis de Bethencourt >> --- > > I can't take patches without any changelog text, sorry :( > Hi Greg, I have done some research around

Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2018-01-09 Thread Greg Kroah-Hartman
On Thu, Dec 21, 2017 at 11:34:10AM +0200, Sakari Ailus wrote: > Hi Joe, > > On Tue, Dec 19, 2017 at 10:15:08AM -0800, Joe Perches wrote: > > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > > b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > > index

Re: [PATCH] staging: rtl8723bs: Fix trailing semicolon

2018-01-09 Thread Greg Kroah-Hartman
On Tue, Jan 09, 2018 at 03:09:27PM +, Luis de Bethencourt wrote: > Signed-off-by: Luis de Bethencourt > --- I can't take patches without any changelog text, sorry :( ___ devel mailing list de...@linuxdriverproject.org

[PATCH] staging: rtl8723bs: Fix trailing semicolon

2018-01-09 Thread Luis de Bethencourt
Signed-off-by: Luis de Bethencourt --- Hi all, Testing the waters with this cleanup patch. If it is OK to send these there are two very similar ones, plus more in general. Happy to send them. I have a C.H.I.P. board, which is why this driver is interesting for me to play

[PATCH v2] staging: pi433: align function parameters with open parenthesis

2018-01-09 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Alignment should match open parenthesis Signed-off-by: Valentin Vidic --- v2: add missing Signed-off-by drivers/staging/pi433/pi433_if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] staging: pi433: align function parameters with open parenthesis

2018-01-09 Thread Greg Kroah-Hartman
On Mon, Jan 08, 2018 at 06:39:33PM +0100, Valentin Vidic wrote: > Fixes checkpatch warnings: > > CHECK: Alignment should match open parenthesis > --- > drivers/staging/pi433/pi433_if.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) No signed-off-by line :(

Re: [PATCH] staging: pi433: remove unnecessary parentheses

2018-01-09 Thread Greg Kroah-Hartman
On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote: > Fixes checkpatch warnings: > > CHECK: Unnecessary parentheses around 'mantisse != mantisse16' > CHECK: Unnecessary parentheses around 'mantisse != mantisse20' > CHECK: Unnecessary parentheses around 'mantisse != mantisse24' >

Re: [PATCH] staging: wilc1000: removed typedef from enum BSSTYPE_T

2018-01-09 Thread Greg KH
On Tue, Jan 09, 2018 at 02:37:42PM +0530, Ajay Singh wrote: > This patch removes typedef from enum BSSTYPE_T and > rename it to bss_types. > > It fixes "WARNING: do not add new typdefs" warning > reported by checkpatch.pl. > > Signed-off-by: ajaysk Hi, This is the

答复: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting

2018-01-09 Thread Zengtao (B)
>-邮件原件- >发件人: Dan Carpenter [mailto:dan.carpen...@oracle.com] >发送时间: 2018年1月9日 17:14 >收件人: Chenfeng (puck) >抄送: Zengtao (B) ; labb...@redhat.com; >sumit.sem...@linaro.org; gre...@linuxfoundation.org; a...@android.com; >tk...@android.com;

[PATCH 5/5] staging: ccree: dma mask is type u64

2018-01-09 Thread Gilad Ben-Yossef
The dma mask var was defined as dma_addr_t but should be u64. This showed as a sparse warning when building for 32 bit. Fix it by changing type to u64 and drop the cast. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_driver.c | 4 ++-- 1 file changed, 2

[PATCH 4/5] staging: ccree: make stub function static inline

2018-01-09 Thread Gilad Ben-Yossef
The debugfs interface defines stub function if debugfs is not enabled, which were missing the 'static inline' qualifiers causing sparse warnings. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_debugfs.h | 8 1 file changed, 4 insertions(+), 4

[PATCH 1/5] staging: ccree: use a consistent file naming convention

2018-01-09 Thread Gilad Ben-Yossef
The ccree driver source files were using an inconsistent naming convention stemming from what the company was called when they were added. Move to a single consistent naming convention for better code readability. Signed-off-by: Gilad Ben-Yossef ---

[PATCH 3/5] staging: ccree: add missing include

2018-01-09 Thread Gilad Ben-Yossef
Add the missing include of include file with function declarations. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ccree/cc_debugfs.c b/drivers/staging/ccree/cc_debugfs.c index

[PATCH 0/5] more cleanups

2018-01-09 Thread Gilad Ben-Yossef
File name consistency renames, include files diet and address some sparse warnings. Gilad Ben-Yossef (5): staging: ccree: use a consistent file naming convention staging: ccree: remove unneeded includes staging: ccree: add missing include staging: ccree: make stub function static inline

[PATCH 2/5] staging: ccree: remove unneeded includes

2018-01-09 Thread Gilad Ben-Yossef
Remove include files not needed for compilation. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_aead.c| 7 --- drivers/staging/ccree/cc_buffer_mgr.c | 6 -- drivers/staging/ccree/cc_cipher.c | 4 drivers/staging/ccree/cc_driver.c

[PATCH] staging: wilc1000: removed enum typedef BUS_RELEASE_T

2018-01-09 Thread Ajay Singh
This patch removes enum typedef BUS_RELEASE_T and define "enum bus_release" to use instead of typedef. checkpatch.pl not to add new typedef warning is fixed with this patch. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c| 2 +-

[PATCH] staging: wilc1000: removed enum typedef BUS_ACQUIRE_T

2018-01-09 Thread Ajay Singh
This patch removes enum typedef BUS_ACQUIRE_T and define enum bus_acquire to use instead of typedef. checkpatch.pl not to add new typedef warning is fixed with this patch. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c| 2 +-

Re: [PATCH v2] Staging: greybus: camera: cleanup multiple checks for null pointers

2018-01-09 Thread Johan Hovold
On Mon, Jan 08, 2018 at 10:20:15PM +0530, Sumit Pundir wrote: > Fixed coding style issue regarding null comparison at multiple lines. > Issue reported by checkpatch.pl > > Signed-off-by: Sumit Pundir > --- > v2: > Updated the patch title and description. Thanks for the

[PATCH] staging: wilc1000: removed enum typedef CHIP_PS_STATE_T

2018-01-09 Thread Ajay Singh
This patch removes enum typedef CHIP_PS_STATE_T and introduce enum chip_ps_states to use instead of typedef. checkpatch.pl not to add new typedef warning is fixed with this patch. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.c| 2 +-

[PATCH] staging: wilc1000: removed enums typedef for BEACON_IE & TX_RATE_T

2018-01-09 Thread Ajay Singh
This patch removed the unnecessary enum typedef for BEACON_IE & TX_RATE_T It fix "WARNING: do not add new typedefs" reported by checkpatch.pl Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_if.h | 8 1 file changed, 4 insertions(+), 4

[PATCH] staging: wilc1000: removed few unnecessary enums typedef

2018-01-09 Thread Ajay Singh
This patch removes following N_OPERATING_MODE_T,N_OBSS_DETECTION_T, N_PROTECTION_TYPE_T,N_SMPS_MODE_T,TX_ABORT_OPTION_T, typedef enum. Now, these enums are used as anonymous-enums for constants. checkpatch.pl warning to not add new typedef is fixes with this patch. Signed-off-by: Ajay Singh

[PATCH] staging: wilc1000: removed few unnecessary enums typedef

2018-01-09 Thread Ajay Singh
This patch removes following RSNA_REKEY_POLICY_T,SCAN_CLASS_FITLER_T, SCAN_PRI_T,CH_FILTER_T,N_PROTECTION_MODE_T,G_PROTECTION_MODE_T typedef enum. Now, these enums are used as anonymous-enums for constants. checkpatch.pl warning to avoid new typedef is fixes with this patch. Signed-off-by: Ajay

[PATCH] staging: wilc1000: removed unnecessary enum typedefs

2018-01-09 Thread Ajay Singh
This patch removes following G_PREAMBLE_T,SCANTYPE_T, USER_PS_MODE_T,SECURITY_T,ACK_POLICY_T,RESET_REQ_T typedef enum. Now, these enums are used as anonymous-enums for constants. checkpatch.pl warning to avoid new typedef is fixes with this patch. Signed-off-by: Ajay Singh

[PATCH] staging: wilc1000: remove unnecessary typedef enum G_OPERATING_MODE_T

2018-01-09 Thread Ajay Singh
This patch has removed G_OPERATING_MODE_T typedef enum. Now, its used as anonymous-enums for constants. checkpatch.pl warning to avoid new typedef is fixed with this patch. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++-- 1 file changed,

[PATCH] staging: wilc1000: removed typedef from enum BSSTYPE_T

2018-01-09 Thread Ajay Singh
This patch removes typedef from enum BSSTYPE_T and rename it to bss_types. It fixes "WARNING: do not add new typdefs" warning reported by checkpatch.pl. Signed-off-by: ajaysk --- drivers/staging/wilc1000/host_interface.c | 2 +-

Re: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting

2018-01-09 Thread Dan Carpenter
On Tue, Jan 09, 2018 at 11:30:09AM +0800, Chen Feng wrote: > > > On 2018/1/9 18:43, Zeng Tao wrote: > > This issue is introduced by the commit ("ION: Sys_heap: > > Add cached pool to spead up cached buffer alloc"), Use the Fixes tag. Fixes: e7f63771b60e ("ION: Sys_heap: Add cached pool to