On Tue, Sep 30, 2014 at 10:56:17PM +0530, Karthik Nayak wrote:
1. WARNING: else is not generally useful after a break or return
2. WARNING: quoted string split across lines
3. WARNING: break quoted strings at a space character
Signed-off-by: Karthik Nayak karthik@gmail.com
---
On Tue, Sep 30, 2014 at 11:29:00PM +0530, Karthik Nayak wrote:
Removed the else statement occurring after an if statement with a
return value as per checkpatch warning.
Signed-off-by: Karthik Nayak karthik@gmail.com
---
drivers/staging/bcm/InterfaceMisc.c | 9 -
1 file
On Thu, Oct 02, 2014 at 02:32:26PM +0200, Nitin Kuppelur wrote:
Removed unnecessary else after return to solve
checkpatch.pl warning
Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com
---
drivers/staging/rtl8712/hal_init.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
On Fri, Oct 03, 2014 at 10:19:44PM +0200, Abel Moyo wrote:
Replaced memcpy with ether_addr_copy in slic_mcast_add_list.
Addresses are _aligned(2) as the struct mcast_address has only
single field of type unsigned char.
Signed-off-by: Abel Moyo abelmoyo...@gmail.com
---
Changes in v2:
On Tue, Oct 07, 2014 at 01:11:42PM +0400, Igor Bogomazov wrote:
checkpatch.pk tiny fix
get rid of 2 warnings and 2 errors for hal/fw.c
Signed-off-by: Igor Bogomazov yg...@ygrex.ru
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: navin patidar navin.pati...@gmail.com
Cc: Stephen
On Wed, Oct 08, 2014 at 08:34:48PM +0200, Rene Kolarik wrote:
Wrapping two too long lines in two files of the imx-drm driver.
Signed-off-by: Rene Kolarik rene.kola...@gmail.com
---
drivers/staging/imx-drm/imx-drm-core.c | 3 ++-
drivers/staging/imx-drm/imx-tve.c | 3 ++-
2 files
On Thu, Oct 09, 2014 at 10:30:06AM +0400, Igor Bogomazov wrote:
checkpatch.pl tiny fix
get rid of 2 warnings and 2 errors for hal/fw.c
What warnings? What errors? Be specific please.
Trailing whitespace :(
___
devel mailing list
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Oct 09, 2014 at 09:00:58PM +0530, Nitin Kuppelur wrote:
Hi Greg,
Sorry for noob question. I am still new to Kernel development.
I understood from your comment that the patch did not
On Fri, Oct 10, 2014 at 09:41:34PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
We don't do anything with these, so get rid of them
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
drivers/staging/rtl8723au/core/rtw_xmit.c| 6 --
On Sat, Oct 11, 2014 at 05:32:49AM -0700, Greg KH wrote:
On Fri, Oct 10, 2014 at 09:41:34PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
We don't do anything with these, so get rid of them
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
On Sat, Oct 11, 2014 at 08:13:42PM +0100, Filipe Gonçalves wrote:
This patch fixes a sparse warning on layout.c (ptlrpc) that was caused by
having preprocessor directives in the arguments to a macro.
Signed-off-by: Filipe Gonçalves fil...@codinghighway.com
---
On Sun, Oct 12, 2014 at 11:44:07AM -0500, Erich Cordoba Malibran wrote:
From: Erich Cordoba erich.cord...@yandex.com
prism2fw.c
prism2sta.c
Fixed style warning reported by checkpatch.pl
prism2mib.c
Renamed function prism2mib_framenthreshold to
meet style guidelines.
You
On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
Re-arrange the functions for removing forward declarations.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
This patch has too many changes for re-arranging the functions.
So I wonder that I should break this up into
On Sun, Oct 12, 2014 at 09:29:32PM -0500, Erich Cordoba Malibran wrote:
From: Erich Cordoba Malibran erich.cord...@yandex.com
Renamed function to fix style issues.
Why is changing a name, to a misspelled one, a style issue fix?
Signed-off-by: Erich Cordoba Malibran
On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
Hi,
2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
Re-arrange the functions for removing
On Tue, Oct 14, 2014 at 01:23:46AM -0700, Thomas Shao wrote:
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -1786,6 +1786,7 @@ int do_adjtimex(struct timex *txc)
return ret;
}
+EXPORT_SYMBOL(do_adjtimex);
EXPORT_SYMBOL_GPL()?
On Wed, Oct 15, 2014 at 03:59:21PM -0700, Jeff Kirsher wrote:
On Wed, 2014-10-15 at 12:01 -0700, Jeff Kirsher wrote:
From: Fabio Estevam fabio.este...@freescale.com
The Beceem WIMAX was generating compile warnings on 64bit machines,
which were:
drivers/staging/bcm/CmHost.c: In
On Wed, Oct 15, 2014 at 03:53:27PM -0700, Jeff Kirsher wrote:
The Beceem WiMAX driver was barely function in its current state
and was non-functional on 64 bit systems. Based on repeated
statements from Greg KH that he wanted the driver removed, I am
removing the driver.
CC: Matthias Beyer
On Wed, Oct 15, 2014 at 03:06:54PM -0700, David Cohen wrote:
On Wed, Oct 15, 2014 at 10:57:00PM +0100, Ian Abbott wrote:
On 15/10/14 22:25, David Cohen wrote:
ii_pci20kc uses io memory which makes it not compilable on architectures
without HAS_IOMEM such as UML:
CC
On Sun, Oct 19, 2014 at 06:28:16PM +0200, Abel Moyo wrote:
Replaced EXTRA_CFLAGS which is deprecated with ccflags-y
Signed-off-by: Abel Moyo abelmoyo...@gmail.com
---
drivers/staging/dgnc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Sun, Oct 12, 2014 at 10:09:04AM +0200, Jes Sorensen wrote:
Greg KH gre...@linuxfoundation.org writes:
On Fri, Oct 10, 2014 at 09:41:23PM +0200, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Hi,
Please find attached a couple of fixes and cleanups
On Wed, Oct 22, 2014 at 05:52:21PM -0400, Erik Arfvidson wrote:
This patch removes unnecessary blanks lines and adds necessary blank lines in
virthba.
Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
On Tue, Oct 28, 2014 at 09:50:19PM +0400, Anton Saraev wrote:
Function lnet_selftest_structure_assertion is never used and can
be removed.
Signed-off-by: Anton Saraev antonysar...@gmail.com
---
drivers/staging/lustre/lnet/selftest/module.c | 11 ---
1 file changed, 11 deletions(-)
On Tue, Oct 28, 2014 at 09:50:18PM +0400, Anton Saraev wrote:
Fix sparse warnings: symbol X was not declared. Should it be static?
Some functions used only in files where they are declared. They can
be static.
Signed-off-by: Anton Saraev antonysar...@gmail.com
---
On Mon, Oct 27, 2014 at 09:20:31AM -0400, Jason Cooper wrote:
Greg,
On Fri, Oct 24, 2014 at 05:29:09PM -0500, Eric Rost wrote:
Adds CryptoAPI and loadable module support to the Skein Hashing
Algorithm. Collapses threefish module into skein module. Renames skein.c
and skein.h to
On Tue, Oct 28, 2014 at 09:35:15PM +0200, Evaldas Palaima wrote:
Fix a style issue reported by checkpatch.pl for the Eudyptula challenge.
Signed-off-by: Evaldas Palaima evaldas.pala...@gmail.com
---
drivers/staging/lustre/lustre/libcfs/fail.c | 24
1 file changed,
On Sun, Oct 12, 2014 at 01:13:51PM +0530, Akshay Sarode wrote:
Checkpatch coding warnings of 'Missing a blank line after declaration'
Signed-off-by: Akshay Sarode akshaysarod...@gmail.com
---
drivers/staging/octeon/ethernet-tx.c | 11 +++
1 file changed, 11 insertions(+)
Someone
On Wed, Oct 15, 2014 at 11:37:24PM -0300, Gaston Gonzalez wrote:
Fix line over 80 characters in imx-tve.c
Signed-off-by: Gaston Gonzalez gasc...@gmail.com
---
drivers/staging/imx-drm/imx-tve.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
On Wed, Oct 29, 2014 at 02:12:38AM +0800, Cheng-Yi He wrote:
This is a patch to the digi.h file that fixes up the following error
found by the checkpatch tool.
ERROR: Macros with complex values should be enclosed in parentheses
Signed-off-by: Cheng-Yi He chengyihetai...@gmail.com
---
On Fri, Oct 17, 2014 at 12:30:51AM +0100, Mike Roocroft wrote:
Fixed a coding style issue.
Signed-off-by: Mike Roocroft mike.li...@btinternet.com
---
drivers/staging/rts5208/rtsx_scsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
On Sun, Oct 26, 2014 at 03:10:22PM +, Paul McQuade wrote:
ERROR: that open brace { should be on the previous line
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_ap.c | 130
++--
1 file changed, 40 insertions(+), 90
On Sun, Oct 26, 2014 at 04:18:52PM +, Paul McQuade wrote:
ERROR: spaces required around that ':' (ctx:VxE)
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_ieee80211.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
Your
On Sun, Oct 26, 2014 at 03:59:56PM +, Paul McQuade wrote:
ERROR: foo*bar should be foo *bar
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_cmd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
The subject does not make sense
On Mon, Oct 27, 2014 at 12:16:08AM +, Paul McQuade wrote:
spaces required around %
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_recv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Your subject does not make sense :(
On Tue, Oct 28, 2014 at 07:46:55PM +0100, Fabio Falzoi wrote:
Define the helper function rtsx_reset_aspm to shorten the
rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
Reviewed-by: Dan Carpenter
On Sun, Oct 26, 2014 at 04:17:46PM +, Paul McQuade wrote:
ERROR: foo * bar should be foo *bar
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Again with the odd subject
On Tue, Oct 28, 2014 at 06:42:37PM -0400, Erik Arfvidson wrote:
This patch removes unnecessary blanks lines and adds necessary blank lines in
virthba.
Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com
---
drivers/staging/unisys/virthba/virthba.c | 7 +--
1 file changed, 1
On Tue, Oct 28, 2014 at 11:09:10PM -0700, Tristan Lelong wrote:
This patch removes tabs used to align variable names in declaration and
assignation.
It replaces them with exactly one space.
Why? This seems like a totally unneeded change, sorry.
greg k-h
On Wed, Oct 29, 2014 at 12:24:57PM -0400, Erik Arfvidson wrote:
This patch removes unnecessary blanks lines and adds necessary blank lines in
virthba.
Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com
---
drivers/staging/unisys/virthba/virthba.c | 7 +--
1 file changed, 1
On Wed, Oct 29, 2014 at 10:58:17PM +0100, Fabio Falzoi wrote:
Clean up the code in rtsx_reset_chip function defining two new helper
functions rtsx_reset_aspm and rtsx_enable_pcie_intr.
Specifically, the following checkpatch warnings are corrected:
* PARENTHESIS_ALIGNMENT at rows 295 and 313
On Thu, Oct 30, 2014 at 12:14:00PM +0900, Daeseok Youn wrote:
Re-arrange the functions for removing forward declarations.
Tested-by: Mark Hounschell ma...@compro.net
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
Tested-by: Mark Hounschell ma...@compro.net
---
V2: this patch is rebased
The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1:
Linux 3.18-rc1 (2014-10-19 18:08:38 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.18-rc3
for you to fetch changes up to
On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote:
+#define DEBUG
I doubt you want this in the driver enabled by default :(
___
devel mailing list
de...@linuxdriverproject.org
On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote:
+EXPORT_SYMBOL(mausb_register_ms_driver);
EXPORT_SYMBOL_GPL()? I have to ask...
+static int mausb_hcd_init(void)
+{
+ int ret;
+
+ /* register HCD driver */
+ ret = platform_driver_register(mausb_driver);
Why
On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote:
--- /dev/null
+++ b/drivers/staging/mausb/drivers/Makefile
@@ -0,0 +1,20 @@
+#MY_CFLAGS =-g -O0 -DEBUG_OUTPUT
Please remove that line, it's not ever to be used.
___
devel mailing
On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote:
--- /dev/null
+++ b/drivers/staging/mausb/TODO
@@ -0,0 +1,14 @@
+TODO:
+ - checkpatch.pl cleanups
Is this still true?
And why does this need to be a staging driver? What's wrong with making
it a real driver now?
+
On Fri, Oct 31, 2014 at 09:57:30AM -0400, Benjamin Romer wrote:
Remove the typedef and just use struct visorchipset_externalport_info instead.
Fix all CamelCase names:
switchNo = switch_no
externalPortNo = external_port_no
networkZoneGuid = network_zone_uuid
pdPort = pd_port
ipNetmask =
On Fri, Oct 31, 2014 at 09:57:31AM -0400, Benjamin Romer wrote:
Get rid of the typedef and use struct visorchipset_internalport_info and fix
CamelCase member names:
switchNo = switch_no
internalPortNo = internal_port_no
busNo = bus_no
devNo = dev_no
Reserved1 = reserved1
Reserved2 =
On Fri, Oct 31, 2014 at 09:57:29AM -0400, Benjamin Romer wrote:
Remove the typedef and use struct visorchipset_switch_info instead. Fix all
CamelCase member names:
switchNo = switch_no
switchTypeGuid = switch_type_uuid
authService1 = authservice1
authService2 = authservice2
authService3 =
On Mon, Nov 03, 2014 at 04:04:42PM -0800, steph wrote:
On Mon, Nov 03, 2014 at 01:21:39PM -0800, Greg KH wrote:
On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote:
+EXPORT_SYMBOL(mausb_register_ms_driver);
EXPORT_SYMBOL_GPL()? I have to ask...
The source is dual
On Tue, Nov 04, 2014 at 08:07:01AM +0900, DaeSeok Youn wrote:
Greg,
check this patch, please.
This patch was rebased on staging-testing tree.
Thanks.
regards,
Daeseok Youn
2014-10-31 10:20 GMT+09:00 Daeseok Youn daeseok.y...@gmail.com:
3 days after sending this? Please give me a
On Tue, Nov 04, 2014 at 09:48:33AM +0100, Tobias Klauser wrote:
On 2014-11-03 at 21:42:52 +0100, Stephanie Wallick
stephanie.s.wall...@intel.com wrote:
This is where we handle media specific packets and transport. The MS driver
interfaces with a media agnostic (MA) driver via a series of
On Tue, Nov 04, 2014 at 09:55:19AM -0800, sostalle wrote:
On Mon, Nov 03, 2014 at 01:24:04PM -0800, Greg KH wrote:
On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote:
--- /dev/null
+++ b/drivers/staging/mausb/TODO
@@ -0,0 +1,14 @@
+TODO:
+ - checkpatch.pl cleanups
On Wed, Nov 05, 2014 at 05:05:03PM +0530, Sanjeev Sharma wrote:
This is a patch to the rtw_cmd.c file that fixes
Error reported by checkpatch.
What error are you fixing? Please be specific.
thanks,
greg k-h
___
devel mailing list
On Tue, Nov 04, 2014 at 11:25:14AM -0500, Benjamin Romer wrote:
Add a comment to the charqueue's spinlock to explain that it is a lock for the
structure.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/charqueue.c | 2 +-
1 file changed, 1
On Wed, Nov 05, 2014 at 12:47:49PM -0500, Benjamin Romer wrote:
Delete the following unused types, and unused function prototypes:
VISORCHIPSET_SWITCH_INFO
VISORCHIPSET_EXTERNALPORT_INFO
VISORCHIPSET_INTERNALPORT_INFO
visorchipset_get_switch_info()
visorchipset_get_externalport_info()
On Wed, Nov 05, 2014 at 12:14:33PM -0800, sostalle wrote:
On Mon, Nov 03, 2014 at 04:13:55PM -0800, Greg KH wrote:
On Mon, Nov 03, 2014 at 04:04:42PM -0800, steph wrote:
On Mon, Nov 03, 2014 at 01:21:39PM -0800, Greg KH wrote:
On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick
On Wed, Nov 05, 2014 at 04:04:32PM -0500, Ken Depro wrote:
From: Ken Depro kenneth.de...@unisys.com
This patch removes unneeded spaces after casts within the virthba.c
file. The checkpatch script was run after these changes, and no
remove spaces after casts checks were generated.
Later
Please specify the error in the subject in some way.
On Thu, Nov 06, 2014 at 11:46:13AM +0530, Sanjeev Sharma wrote:
This is a patch to the rtw_cmd.c file that fixes following
error.
ERROR: spaces required around that '' (ctx:WxV)
ERROR: that open brace { should be on the previous line
On Thu, Nov 06, 2014 at 12:06:36PM +0530, Sanjeev Sharma wrote:
This is a patch to the rtw_cmd.c file that fixes following
Warning by introducing temporary structure.
WARNING: line over 80 characters
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
---
On Thu, Nov 06, 2014 at 10:33:28AM -0500, Ken Depro wrote:
From: Ken Depro kenneth.de...@unisys.com
This patch removes unneeded spaces after casts within the virthba.c
file. The checkpatch script was run after these changes, and no
remove spaces after casts checks were generated.
Later
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Nov 06, 2014 at 10:22:30AM -0600, Depro, Kenneth J wrote:
Greg,
When I executed the format-patch command, it added the conflict lines below.
There was indeed a conflict in this file
On Thu, Nov 06, 2014 at 12:53:32PM -0600, Ken Cox wrote:
From: Benjamin Romer benjamin.ro...@unisys.com
This patch adds the visorclientbus driver to the Unisys s-Par driver set. This
driver is responsible for helping manage virtual devices like keyboards, mice,
serial ports, displays, and
On Mon, Nov 03, 2014 at 07:52:38PM +0100, Konrad Zapalowicz wrote:
This commit adds the Digi Classic board implementation to the
staging/jsm driver.
The code here is taken from the staging/dgnc driver and modified to
match the serial/jsm state. This work is mostly based on the changes
that
On Thu, Nov 06, 2014 at 01:17:56PM -0600, Ken Cox wrote:
There are also other checkpatch errors in this patch, which makes me not
want to take it at all, as you would now just be required to send more
fixes for the file. So why not fix things up right the first time?
The only checkpatch
On Fri, Nov 07, 2014 at 12:05:34AM +0100, Konrad Zapalowicz wrote:
This commit removes the staging/dgnc driver in favor of the serial/jsm
driver.
This is because the serial/jsm driver now supports all of the hardware
that has been supported by the staging/dgnc plus it offers better
overall
On Fri, Nov 07, 2014 at 12:36:23AM +0100, Konrad Zapalowicz wrote:
On 11/06, Greg KH wrote:
On Fri, Nov 07, 2014 at 12:05:34AM +0100, Konrad Zapalowicz wrote:
This commit removes the staging/dgnc driver in favor of the serial/jsm
driver.
This is because the serial/jsm driver now
On Fri, Nov 07, 2014 at 12:51:34PM -0500, Ken Depro wrote:
Signed-off-by: Ken Depro kenneth.de...@unisys.com
Your Subject: is a bit long...
___
devel mailing list
de...@linuxdriverproject.org
On Fri, Nov 07, 2014 at 12:58:24PM -0500, Ken Depro wrote:
While fixing the CamelCase checks for the functions in the chanstub
source and header files, I discovered they are no longer being used.
This patch removes the two chanstub files, and deletes the #include
of these files from
On Tue, Oct 21, 2014 at 04:46:58PM +0200, Matej Mužila wrote:
From: Matej Mužila mmuz...@redhat.com
Check if cpmsg-size is in limits of DATA_FRAGMENT
Signed-off-by: Matej Mužila mmuz...@redhat.com
---
If corrupted data are read from /dev/vmbus/hv_fcopy, pwrite can
read from memory
On Sat, Nov 08, 2014 at 06:39:06PM +0200, sharon wrote:
Fix coding style warning.
What coding style warning? Be specific please.
And your subject:, you aren't saying where in the kernel you are fixing
anything, look at other patches for this file in git, what did the
subject look like for
The following changes since commit 0df1f2487d2f0d04703f142813d53615d62a1da4:
Linux 3.18-rc3 (2014-11-02 15:01:51 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.18-rc4
for you to fetch changes up to
On Mon, Nov 10, 2014 at 06:09:32PM -0800, Stephanie Wallick wrote:
+static int mausb_bus_probe(struct device *dev)
+{
+ return mausb_probe(dev);
+}
+
+static int mausb_bus_remove(struct device *dev)
+{
+ return mausb_remove(dev);
+}
Wrapper functions that just call another
On Mon, Nov 10, 2014 at 06:09:36PM -0800, Stephanie Wallick wrote:
+static int ma_open;
Why do you need this variable?
+/**
+ * This function is used to open the device file in order to read/write
+ * from/to it.
+ *
+ * @inode: Struct with various information that is passed in when this
On Mon, Nov 10, 2014 at 06:09:41PM -0800, Stephanie Wallick wrote:
Signed-off-by: Sean O. Stalley sean.stal...@intel.com
Signed-off-by: Stephanie Wallick stephanie.s.wall...@intel.com
No changelog entry?
---
MAINTAINERS| 7 +++
drivers/staging/Kconfig
On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote:
+/**
+ * Returns the number of urbs currently in the MA USB HCD. Will return 0 if
the
+ * MA USB HCD is empty or a negative errno if an error occurs.
How can this function return a negative number? I don't see that
codepath
On Tue, Nov 11, 2014 at 02:42:22PM -0800, Sean O. Stalley wrote:
On Tue, Nov 11, 2014 at 01:38:21PM +0900, Greg KH wrote:
On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote:
Intel has a whole group of very experienced Linux kernel developers who
will review code before you
On Sat, Nov 15, 2014 at 09:59:34PM +0100, Pavel Machek wrote:
On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote:
On 11/15, Christian Resell wrote:
Simple style fix (checkpatch.pl: space prohibited before that ',').
For the eudyptula challenge (http://eudyptula-challenge.org/).
On Mon, Nov 17, 2014 at 11:11:36AM -0800, Thomas Wood wrote:
Fixed Subject line containing the entire patch description.
88
Ick, what is that here? Please put that below the --- line, otherwise I
have to hand-edit the
On Mon, Nov 17, 2014 at 02:46:35PM -0500, Jeffrey Brown wrote:
From: Jeff jeffrey.br...@unisys.com
This doesn't match your signed-off-by: line, nor your From: line of your
email above. Why even have this line when it isn't needed, and wrong?
greg k-h
On Tue, Nov 18, 2014 at 02:51:45AM +, Tobenna Peter, Igwe wrote:
On Mon, Nov 17, 2014 at 05:59:47PM -0800, Greg KH wrote:
On Tue, Nov 18, 2014 at 01:45:41AM +, Tobenna P. Igwe wrote:
This patch fixes the following sparse warning:
drivers/staging/rtl8723au/hal/rtl8723a_bt
On Mon, Nov 17, 2014 at 04:23:08PM -0800, Juston wrote:
On Tue, 2014-11-18 at 01:46 +0300, Dan Carpenter wrote:
On Mon, Nov 17, 2014 at 02:23:48PM -0800, Juston Li wrote:
FMODE_EXEC is type fmode_t but is used in operations
with integers which leads to sparse warnings:
On Fri, Nov 21, 2014 at 05:37:04AM +0530, Anjana Sasindran wrote:
This patch fixes the checkpatch.pl error:
ERROR: trailing whitespace
Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com
---
drivers/staging/skein/skein_generic.c | 1 +
1 file changed, 1 insertion(+)
diff
On Sat, Nov 22, 2014 at 11:34:29AM +0530, Anjana Sasindran wrote:
This patch fixes the checkpatch.pl error:
ERROR: trailing whitespace
Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com
---
drivers/staging/skein/skein_generic.c | 1 +
1 file changed, 1 insertion(+)
diff
On Sat, Nov 22, 2014 at 01:11:59PM +0530, Anjana Sasindran wrote:
This patch fixes the checkpatch.pl error:
ERROR: trailing whitespace
Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com
---
drivers/staging/skein/skein_generic.c | 1 -
1 file changed, 1 deletion(-)
On Tue, Nov 11, 2014 at 12:15:28AM -0500, Adrian Nicoara wrote:
All the changes are against variables/functions that are only accessed from
within the same file. If the scope needs to change later on, the static
keyword
can be removed.
Build tested.
Signed-off-by: Adrian Nicoara
On Tue, Nov 25, 2014 at 11:00:35PM +0530, icyflame wrote:
Changing the following:
Adapater - Adapter
STATUS_SUCESS - STATUS_SUCCESS
Signed-off by: Siddharth Kannan kannan.siddhart...@gmail.com
---
drivers/staging/bcm/nvm.c | 26 +-
1 file changed, 13
On Tue, Nov 11, 2014 at 03:28:57PM +0530, Sanjeev Sharma wrote:
This is a patch to the rtw_cmd.c file that fixes following
Error.
ERROR: that open brace { should be on the previous line
This patch does much more than that :(
___
devel mailing list
On Mon, Nov 24, 2014 at 07:55:40PM +0100, Zahari Doychev wrote:
The two patches fix several sparse warning in the lustre module.
Zahari Doychev (2):
[drivers] staging/lustre: fix sparse warnings
[drivers] staging/lustre: fix sparse warnings
On Wed, Nov 26, 2014 at 05:15:48PM +0100, Loic Pefferkorn wrote:
Add __acquires() and __releases() function annotations, to fix sparse
warnings related to lock context imbalance.
This fixes the following warnings:
drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c:153:5:
On Fri, Nov 07, 2014 at 10:17:40AM -0800, Greg KH wrote:
On Fri, Nov 07, 2014 at 12:58:24PM -0500, Ken Depro wrote:
While fixing the CamelCase checks for the functions in the chanstub
source and header files, I discovered they are no longer being used.
This patch removes the two chanstub
On Wed, Nov 12, 2014 at 11:28:15AM -0500, Jeffrey Brown wrote:
Sorry for all of the messy patches from before but here
are the improved patches for parser.h and parser.c.
The camel cases are grouped on functions and structs
that occurs in both files.
You have to do a 'vN' where 'N' is a
On Thu, Nov 13, 2014 at 09:56:39AM -0500, Jeffrey Brown wrote:
Fixed small bug in parser.c by removing cleanups: in parser_init
_guts struct. Replaced it with proper error handling code
and removed the instances of rc = NULL in the code. rc = NULL is
redudant
Signed-off-by: Jeffrey Brown
I _strongly_ suggest unisys get their act together here. The number of
patches that were sent recently that make no sense at all is horrid.
I've now purged all of them from my to-apply queue, please resend
_everything_ that you have, in the correct order, _AFTER_ you all review
them among
On Thu, Nov 20, 2014 at 11:31:14PM +0530, Lekshmi wrote:
The following checkpatch warning was fixed:
WARNING: Missing a blank line after declarations
Signed-off-by: Lekshmi andnlnb...@gmail.com
I need a full name here, sorry.
Please fix and resend.
greg k-h
On Wed, Nov 26, 2014 at 05:58:37PM +0530, Athira Lekshmi C V wrote:
Fixed the checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com
What is the C V at the end of the name here? Is that your full
name? I need a real name,
On Thu, Nov 20, 2014 at 04:03:23PM +0100, Abel Moyo wrote:
Changed return type of function get_my_bssid from __inline to inline
Signed-off-by: Abel Moyo abelmoyo...@gmail.com
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Sat, Nov 22, 2014 at 11:36:40AM +0530, Anjana Sasindran wrote:
This patch fixes the five checkpatch.pl warnings:
WARNING:Missing a blank line after declaration
Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 6
On Tue, Nov 25, 2014 at 05:16:40PM +0530, Athira Lekshmi C V wrote:
The following checkpatch warning was fixed
WARNING: line over 80 characters
Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com
---
drivers/staging/wlan-ng/prism2fw.c | 10 +++---
1 file changed, 7 insertions(+),
On Wed, Nov 26, 2014 at 04:56:55PM +0530, Athira Lekshmi C V wrote:
Fixed the checkpatch warning:
WARNING: please, no space before tabs
Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com
Same question about the name here as before.
Also, be more specific in your subject as to what you
1 - 100 of 4692 matches
Mail list logo
