Re: [PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c
On Tue, Sep 30, 2014 at 10:56:17PM +0530, Karthik Nayak wrote: 1. WARNING: else is not generally useful after a break or return 2. WARNING: quoted string split across lines 3. WARNING: break quoted strings at a space character Signed-off-by: Karthik Nayak karthik@gmail.com --- drivers/staging/bcm/InterfaceIdleMode.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) Doesn't apply to my tree :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: bcm: remove unnecessary else statement
On Tue, Sep 30, 2014 at 11:29:00PM +0530, Karthik Nayak wrote:
Removed the else statement occurring after an if statement with a
return value as per checkpatch warning.
Signed-off-by: Karthik Nayak karthik@gmail.com
---
drivers/staging/bcm/InterfaceMisc.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceMisc.c
b/drivers/staging/bcm/InterfaceMisc.c
index e5bcfec..1f31b8f 100644
--- a/drivers/staging/bcm/InterfaceMisc.c
+++ b/drivers/staging/bcm/InterfaceMisc.c
@@ -102,12 +102,11 @@ int InterfaceWRM(struct bcm_interface_adapter
*psIntfAdapter,
DBG_LVL_ALL, WRM failed status :%d, retval);
psIntfAdapter-psAdapter-DeviceAccess = false;
return retval;
- } else {
- psIntfAdapter-psAdapter-DeviceAccess = false;
- BCM_DEBUG_PRINT(psIntfAdapter-psAdapter, DBG_TYPE_OTHERS, WRM,
- DBG_LVL_ALL, WRM sent %d, retval);
- return STATUS_SUCCESS;
}
+ psIntfAdapter-psAdapter-DeviceAccess = false;
+ BCM_DEBUG_PRINT(psIntfAdapter-psAdapter, DBG_TYPE_OTHERS, WRM,
+ DBG_LVL_ALL, WRM sent %d, retval);
+ return STATUS_SUCCESS;
}
int BcmRDM(void *arg,
--
2.1.0
This doesn't apply either, someone else must have done this change
already.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH V3] Staging: rtl8712 removed unnecessary else after return
On Thu, Oct 02, 2014 at 02:32:26PM +0200, Nitin Kuppelur wrote:
Removed unnecessary else after return to solve
checkpatch.pl warning
Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com
---
drivers/staging/rtl8712/hal_init.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index 81cd654..fbaba11 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -387,12 +387,9 @@ uint rtl8712_hal_deinit(struct _adapter *padapter)
uint rtl871x_hal_init(struct _adapter *padapter)
{
padapter-hw_init_completed = false;
- if (padapter-halpriv.hal_bus_init == NULL)
+ if (padapter-halpriv.hal_bus_init == NULL ||
+ padapter-halpriv.hal_bus_init(padapter) != _SUCCESS)
return _FAIL;
- else {
- if (padapter-halpriv.hal_bus_init(padapter) != _SUCCESS)
- return _FAIL;
- }
if (rtl8712_hal_init(padapter) == _SUCCESS)
padapter-hw_init_completed = true;
else {
This doesn't apply to my tree :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] Staging: slicoss: slicoss: replaced memcpy with ether_addr_copy
On Fri, Oct 03, 2014 at 10:19:44PM +0200, Abel Moyo wrote: Replaced memcpy with ether_addr_copy in slic_mcast_add_list. Addresses are _aligned(2) as the struct mcast_address has only single field of type unsigned char. Signed-off-by: Abel Moyo abelmoyo...@gmail.com --- Changes in v2: - Indicate how ether_addr_copy is safe in changelog drivers/staging/slicoss/slicoss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Someone just did this right before you did, sorry :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8188eu: coding style fixup
On Tue, Oct 07, 2014 at 01:11:42PM +0400, Igor Bogomazov wrote: checkpatch.pk tiny fix get rid of 2 warnings and 2 errors for hal/fw.c Signed-off-by: Igor Bogomazov yg...@ygrex.ru Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: navin patidar navin.pati...@gmail.com Cc: Stephen Rothwell s...@canb.auug.org.au --- linux-next 3.17.0 I think someone else already did this before you sent it in, as this doesn't apply to my tree, sorry :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] drivers: staging: imx-drm driver cleanup
On Wed, Oct 08, 2014 at 08:34:48PM +0200, Rene Kolarik wrote: Wrapping two too long lines in two files of the imx-drm driver. Signed-off-by: Rene Kolarik rene.kola...@gmail.com --- drivers/staging/imx-drm/imx-drm-core.c | 3 ++- drivers/staging/imx-drm/imx-tve.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c index 9cb222e..9d1f861 100644 --- a/drivers/staging/imx-drm/imx-drm-core.c +++ b/drivers/staging/imx-drm/imx-drm-core.c @@ -632,7 +632,8 @@ static int imx_drm_platform_probe(struct platform_device *pdev) continue; } - component_match_add(pdev-dev, match, compare_of, remote); + component_match_add(pdev-dev, match, compare_of, + remote); Please line this up with the ( character on the line above. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8188eu: coding style fixup
On Thu, Oct 09, 2014 at 10:30:06AM +0400, Igor Bogomazov wrote: checkpatch.pl tiny fix get rid of 2 warnings and 2 errors for hal/fw.c What warnings? What errors? Be specific please. Trailing whitespace :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH V3] Staging: rtl8712 removed unnecessary else after return
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Oct 09, 2014 at 09:00:58PM +0530, Nitin Kuppelur wrote: Hi Greg, Sorry for noob question. I am still new to Kernel development. I understood from your comment that the patch did not apply cleanly to your tree (may be due to change in the code which I have modified) Or due to changes that others made and got accepted. But what should I do after this? 1) Send patch on rebased file to same mail chain with (--in-reply-to) and [PATCH V4] ? OR 2) Create new PATCH and start new mail chain done on latest code. Create a new patch and new email thread please. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 11/15] staging: rtl8723au: Remove a stack of write only counters
On Fri, Oct 10, 2014 at 09:41:34PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com We don't do anything with these, so get rid of them Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_xmit.c| 6 -- drivers/staging/rtl8723au/include/rtw_xmit.h | 5 - drivers/staging/rtl8723au/os_dep/usb_ops_linux.c | 16 3 files changed, 27 deletions(-) This one didn't apply to my tree for some reason, let me see if I can do it by hand... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 11/15] staging: rtl8723au: Remove a stack of write only counters
On Sat, Oct 11, 2014 at 05:32:49AM -0700, Greg KH wrote: On Fri, Oct 10, 2014 at 09:41:34PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com We don't do anything with these, so get rid of them Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_xmit.c| 6 -- drivers/staging/rtl8723au/include/rtw_xmit.h | 5 - drivers/staging/rtl8723au/os_dep/usb_ops_linux.c | 16 3 files changed, 27 deletions(-) This one didn't apply to my tree for some reason, let me see if I can do it by hand... Got it, all now applied, thanks. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] drivers/staging: Fixed sparse error directive in argument list
On Sat, Oct 11, 2014 at 08:13:42PM +0100, Filipe Gonçalves wrote: This patch fixes a sparse warning on layout.c (ptlrpc) that was caused by having preprocessor directives in the arguments to a macro. Signed-off-by: Filipe Gonçalves fil...@codinghighway.com --- drivers/staging/lustre/lustre/ptlrpc/layout.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/layout.c b/drivers/staging/lustre/lustre/ptlrpc/layout.c index 5b83371..211df78 100644 --- a/drivers/staging/lustre/lustre/ptlrpc/layout.c +++ b/drivers/staging/lustre/lustre/ptlrpc/layout.c @@ -978,10 +978,11 @@ struct req_msg_field RMF_CONN = EXPORT_SYMBOL(RMF_CONN); struct req_msg_field RMF_CONNECT_DATA = +#if LUSTRE_VERSION_CODE OBD_OCD_VERSION(2, 7, 50, 0) DEFINE_MSGF(cdata, RMF_F_NO_SIZE_CHECK /* we allow extra space for interop */, -#if LUSTRE_VERSION_CODE OBD_OCD_VERSION(2, 7, 50, 0) sizeof(struct obd_connect_data), + lustre_swab_connect, NULL); Ick ick ick. Yeah, sparse might complain about this, but how about just properly deleting the #ifdef entirely, and not perpetuate it even more? It shouldn't be needed anymore now that the code is in the kernel tree. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: wlan-ng: prism2 simple style modifications
On Sun, Oct 12, 2014 at 11:44:07AM -0500, Erich Cordoba Malibran wrote: From: Erich Cordoba erich.cord...@yandex.com prism2fw.c prism2sta.c Fixed style warning reported by checkpatch.pl prism2mib.c Renamed function prism2mib_framenthreshold to meet style guidelines. You are doing multiple different things here in one patch. Please break it up into one logical thing per patch and resend them. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.
On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing forward declarations. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- This patch has too many changes for re-arranging the functions. So I wonder that I should break this up into smaller patches. Are the .o files identical before and after this patch? If so, it's fine. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: wlan-ng: Renamed prism2_fragmenthreshold in prism2mib.c
On Sun, Oct 12, 2014 at 09:29:32PM -0500, Erich Cordoba Malibran wrote:
From: Erich Cordoba Malibran erich.cord...@yandex.com
Renamed function to fix style issues.
Why is changing a name, to a misspelled one, a style issue fix?
Signed-off-by: Erich Cordoba Malibran erich.cord...@yandex.com
---
drivers/staging/wlan-ng/prism2mib.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2mib.c
b/drivers/staging/wlan-ng/prism2mib.c
index 0163e06..30d224f 100644
--- a/drivers/staging/wlan-ng/prism2mib.c
+++ b/drivers/staging/wlan-ng/prism2mib.c
@@ -132,12 +132,12 @@ static int prism2mib_excludeunencrypted(struct mibrec
*mib,
struct p80211msg_dot11req_mibset *msg,
void *data);
-static int prism2mib_fragmentationthreshold(struct mibrec *mib,
- int isget,
- wlandevice_t *wlandev,
- hfa384x_t *hw,
- struct p80211msg_dot11req_mibset
*msg,
- void *data);
+static int prism2mib_fragmenthreshold(struct mibrec *mib,
+ int isget,
+ wlandevice_t *wlandev,
+ hfa384x_t *hw,
+ struct p80211msg_dot11req_mibset *msg,
+ void *data);
static int prism2mib_priv(struct mibrec *mib,
int isget,
@@ -198,7 +198,7 @@ static struct mibrec mibtab[] = {
{DIDmib_dot11mac_dot11OperationTable_dot11FragmentationThreshold,
F_STA | F_READ | F_WRITE,
HFA384x_RID_FRAGTHRESH, 0, 0,
- prism2mib_fragmentationthreshold},
+ prism2mib_fragmenthreshold},
{DIDmib_dot11mac_dot11OperationTable_dot11MaxTransmitMSDULifetime,
F_STA | F_READ,
HFA384x_RID_MAXTXLIFETIME, 0, 0,
@@ -660,12 +660,12 @@ static int prism2mib_excludeunencrypted(struct mibrec
*mib,
*
*/
-static int prism2mib_fragmentationthreshold(struct mibrec *mib,
- int isget,
- wlandevice_t *wlandev,
- hfa384x_t *hw,
- struct p80211msg_dot11req_mibset
*msg,
- void *data)
+static int prism2mib_fragmenthreshold(struct mibrec *mib,
+ int isget,
+ wlandevice_t *wlandev,
+ hfa384x_t *hw,
+ struct p80211msg_dot11req_mibset *msg,
+ void *data)
{
int result;
u32 *uint32 = (u32 *) data;
--
2.1.2
I don't understand the problem you are trying to solve here, what is it?
confused,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.
On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: Hi, 2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: Re-arrange the functions for removing forward declarations. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- This patch has too many changes for re-arranging the functions. So I wonder that I should break this up into smaller patches. Are the .o files identical before and after this patch? If so, it's fine. Ok. I will check for that. The .o files shouldn't be identical after function reordering. Hm, they might be the same size, but I can see how on some architectures (like ppc) how that would not be the case, you are right. Isn't there an objdiff program or something like that which might help in validating that nothing changed in the source for type of patch that just moves functions around in a file. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] hyperv: Implement Time Synchronization using host time sample
On Tue, Oct 14, 2014 at 01:23:46AM -0700, Thomas Shao wrote: --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -1786,6 +1786,7 @@ int do_adjtimex(struct timex *txc) return ret; } +EXPORT_SYMBOL(do_adjtimex); EXPORT_SYMBOL_GPL()? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings
On Wed, Oct 15, 2014 at 03:59:21PM -0700, Jeff Kirsher wrote: On Wed, 2014-10-15 at 12:01 -0700, Jeff Kirsher wrote: From: Fabio Estevam fabio.este...@freescale.com The Beceem WIMAX was generating compile warnings on 64bit machines, which were: drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’: drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( ^ drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( ^ drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] (struct bcm_connect_mgr_params *) ntohl( This resolves the issue by preventing the driver to compile if CONFIG_64BIT is enabled, since the driver is known to be broken for 64 bit arch's. CC: Dan Carpenter dan.carpen...@oracle.com CC: Joe Perches j...@perches.com Signed-off-by: Fabio Estevam fabio.este...@freescale.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com Greg- I have also submitted a patch to remove this driver entirely. So if you choose to apply the patch to remove the driver, then you can disregard this patch. Thanks, I'll take that removal patch now, I'm glad to get rid of that mess. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] bcm_wimax: remove driver support
On Wed, Oct 15, 2014 at 03:53:27PM -0700, Jeff Kirsher wrote: The Beceem WiMAX driver was barely function in its current state and was non-functional on 64 bit systems. Based on repeated statements from Greg KH that he wanted the driver removed, I am removing the driver. CC: Matthias Beyer m...@beyermatthias.de CC: Kevin McKinney klmckinn...@gmail.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com Many thanks for this, I've now applied this to my testing tree. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: comedi: ii_pci20kc: add CONFIG_HAS_IOMEM dependence
On Wed, Oct 15, 2014 at 03:06:54PM -0700, David Cohen wrote: On Wed, Oct 15, 2014 at 10:57:00PM +0100, Ian Abbott wrote: On 15/10/14 22:25, David Cohen wrote: ii_pci20kc uses io memory which makes it not compilable on architectures without HAS_IOMEM such as UML: CC drivers/net/wireless/ti/wl1251/main.o drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’: drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] dev-mmio = ioremap(membase, II20K_SIZE); ^ drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast dev-mmio = ioremap(membase, II20K_SIZE); ^ drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’: drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] iounmap(dev-mmio); ^ Signed-off-by: David Cohen david.a.co...@linux.intel.com --- drivers/staging/comedi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig index a8bc2b567789..56be2112c731 100644 --- a/drivers/staging/comedi/Kconfig +++ b/drivers/staging/comedi/Kconfig @@ -425,6 +425,7 @@ config COMEDI_AIO_IIRO_16 called aio_iiro_16. config COMEDI_II_PCI20KC + depends on HAS_IOMEM tristate Intelligent Instruments PCI-20001C carrier support ---help--- Enable support for Intelligent Instruments PCI-20001C carrier The same fix was already submitted by Chen Gang: https://lkml.org/lkml/2014/10/2/318 Thanks. I sent this patch based on today's linux-next's make ARCH=um allyesconfig. But nevermind if it was already sent. I can't add patches, even bugfixes, to my trees until 3.18-rc1 is out, which is why this fix isn't in linux-next. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: dgnc: Makefile: replaced EXTRA_CFLAGS with ccflags-y
On Sun, Oct 19, 2014 at 06:28:16PM +0200, Abel Moyo wrote: Replaced EXTRA_CFLAGS which is deprecated with ccflags-y Signed-off-by: Abel Moyo abelmoyo...@gmail.com --- drivers/staging/dgnc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile index b69f7b6..d70323e 100644 --- a/drivers/staging/dgnc/Makefile +++ b/drivers/staging/dgnc/Makefile @@ -1,4 +1,4 @@ -EXTRA_CFLAGS += -DDG_NAME=\dgnc-1.3-16\ -DDG_PART=\40002369_F\ +ccflags-y += -DDG_NAME=\dgnc-1.3-16\ -DDG_PART=\40002369_F\ How about removing the kernel use of these flags instead, as they should not be needed to be added to the Makefile. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/15] staging: rtl8723au: Fixes and cleanups
On Sun, Oct 12, 2014 at 10:09:04AM +0200, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Fri, Oct 10, 2014 at 09:41:23PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Hi, Please find attached a couple of fixes and cleanups for the rtl8723au driver. This includes a fix for the mac_addr alignment reported by Dan Carpenter and two patches from Greg Donald. Should any of these go into 3.18-final, or are all ok for 3.19-rc1? The first one would be good for 3.18-final since it fixes the alignment issue for ether_addr_copy() I've now queued this one patch up for 3.18-final. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/10] staging: unisys: fix blank lines virthba
On Wed, Oct 22, 2014 at 05:52:21PM -0400, Erik Arfvidson wrote:
This patch removes unnecessary blanks lines and adds necessary blank lines in
virthba.
Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/virthba/virthba.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/virthba/virthba.c
b/drivers/staging/unisys/virthba/virthba.c
index e4130c9..e8868ae2 100644
--- a/drivers/staging/unisys/virthba/virthba.c
+++ b/drivers/staging/unisys/virthba/virthba.c
@@ -101,7 +101,6 @@ static DEF_SCSI_QCMD(virthba_queue_command)
#define virthba_queue_command virthba_queue_command_lck
#endif
-
static int virthba_slave_alloc(struct scsi_device *scsidev);
static int virthba_slave_configure(struct scsi_device *scsidev);
static void virthba_slave_destroy(struct scsi_device *scsidev);
@@ -166,6 +165,7 @@ struct virtdisk_info {
atomic_t error_count;
struct virtdisk_info *next;
};
+
/* Each Scsi_Host has a host_data area that contains this struct. */
struct virthba_info {
struct Scsi_Host *scsihost;
@@ -420,7 +420,9 @@ static irqreturn_t
virthba_ISR(int irq, void *dev_id)
{
struct virthba_info *virthbainfo = (struct virthba_info *) dev_id;
+
CHANNEL_HEADER __iomem *pChannelHeader;
+
SIGNAL_QUEUE_HEADER __iomem *pqhdr;
Same extra line problem here as well.
Please fix both of those up and resend both series.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 02/02] staging:lustre:lnet:selftest: remove unused function
On Tue, Oct 28, 2014 at 09:50:19PM +0400, Anton Saraev wrote:
Function lnet_selftest_structure_assertion is never used and can
be removed.
Signed-off-by: Anton Saraev antonysar...@gmail.com
---
drivers/staging/lustre/lnet/selftest/module.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/module.c
b/drivers/staging/lustre/lnet/selftest/module.c
index 718663f..92520c2 100644
--- a/drivers/staging/lustre/lnet/selftest/module.c
+++ b/drivers/staging/lustre/lnet/selftest/module.c
@@ -90,17 +90,6 @@ lnet_selftest_fini(void)
return;
}
-static void
-lnet_selftest_structure_assertion(void)
-{
- CLASSERT(sizeof(srpc_msg_t) == 160);
- CLASSERT(sizeof(srpc_test_reqst_t) == 70);
- CLASSERT(offsetof(srpc_msg_t, msg_body.tes_reqst.tsr_concur) == 72);
- CLASSERT(offsetof(srpc_msg_t, msg_body.tes_reqst.tsr_ndest) == 78);
- CLASSERT(sizeof(srpc_stat_reply_t) == 136);
- CLASSERT(sizeof(srpc_stat_reqst_t) == 28);
-}
-
static int
lnet_selftest_init(void)
{
This doesn't apply to my tree at all :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 01/02] staging:lustre:lnet:selftest: fix sparse warnings
On Tue, Oct 28, 2014 at 09:50:18PM +0400, Anton Saraev wrote: Fix sparse warnings: symbol X was not declared. Should it be static? Some functions used only in files where they are declared. They can be static. Signed-off-by: Anton Saraev antonysar...@gmail.com --- drivers/staging/lustre/lnet/selftest/conctl.c| 34 drivers/staging/lustre/lnet/selftest/conrpc.c| 20 +- drivers/staging/lustre/lnet/selftest/framework.c | 50 drivers/staging/lustre/lnet/selftest/module.c| 6 +-- drivers/staging/lustre/lnet/selftest/rpc.c | 34 drivers/staging/lustre/lnet/selftest/timer.c | 8 ++-- 6 files changed, 76 insertions(+), 76 deletions(-) This patch adds a build warning to the build, so I can't apply it. Please fix it up and resend. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v6 0/7] staging: skein: CryptoAPI and Module Support
On Mon, Oct 27, 2014 at 09:20:31AM -0400, Jason Cooper wrote: Greg, On Fri, Oct 24, 2014 at 05:29:09PM -0500, Eric Rost wrote: Adds CryptoAPI and loadable module support to the Skein Hashing Algorithm. Collapses threefish module into skein module. Renames skein.c and skein.h to skein_base.c and skein_base.h so module can be named skein.ko. Inlines rotl_64 macro. Removes unneeded #define and skein_debug.h include. Eric Rost (7): staging: skein: Collapses threefish module staging: skein: Renames skein to skein_base staging: skein: Adds CryptoAPI Support staging: skein: Adds Loadable Module Support staging: skein: Inlines rotl_64 staging: skein: Removes unneeded #define For patches 1 through 6, Reviewed-by: Jason Cooper ja...@lakedaemon.net We'll keep working on #7, but feel free to take the first six when you get a moment Greg. Now applied, thanks. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: lustre: Fix coding style. Switch and case at the same indent.
On Tue, Oct 28, 2014 at 09:35:15PM +0200, Evaldas Palaima wrote:
Fix a style issue reported by checkpatch.pl for the Eudyptula challenge.
Signed-off-by: Evaldas Palaima evaldas.pala...@gmail.com
---
drivers/staging/lustre/lustre/libcfs/fail.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/fail.c
b/drivers/staging/lustre/lustre/libcfs/fail.c
index e73ca3d..92444b0 100644
--- a/drivers/staging/lustre/lustre/libcfs/fail.c
+++ b/drivers/staging/lustre/lustre/libcfs/fail.c
@@ -103,18 +103,18 @@ int __cfs_fail_check_set(__u32 id, __u32 value, int set)
}
switch (set) {
- case CFS_FAIL_LOC_NOSET:
- case CFS_FAIL_LOC_VALUE:
- break;
- case CFS_FAIL_LOC_ORSET:
- cfs_fail_loc |= value ~(CFS_FAILED | CFS_FAIL_ONCE);
- break;
- case CFS_FAIL_LOC_RESET:
- cfs_fail_loc = value;
- break;
- default:
- LASSERTF(0, called with bad set %u\n, set);
- break;
+ case CFS_FAIL_LOC_NOSET:
+ case CFS_FAIL_LOC_VALUE:
+ break;
+ case CFS_FAIL_LOC_ORSET:
+ cfs_fail_loc |= value ~(CFS_FAILED | CFS_FAIL_ONCE);
+ break;
+ case CFS_FAIL_LOC_RESET:
+ cfs_fail_loc = value;
+ break;
+ default:
+ LASSERTF(0, called with bad set %u\n, set);
+ break;
}
return 1;
Someone else did this change before you, sorry :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] Octeon: Staging Driver: Remove coding warnings
On Sun, Oct 12, 2014 at 01:13:51PM +0530, Akshay Sarode wrote: Checkpatch coding warnings of 'Missing a blank line after declaration' Signed-off-by: Akshay Sarode akshaysarod...@gmail.com --- drivers/staging/octeon/ethernet-tx.c | 11 +++ 1 file changed, 11 insertions(+) Someone else already did this, sorry :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] drivers: staging: imx-drm Fix checkpatch warning
On Wed, Oct 15, 2014 at 11:37:24PM -0300, Gaston Gonzalez wrote:
Fix line over 80 characters in imx-tve.c
Signed-off-by: Gaston Gonzalez gasc...@gmail.com
---
drivers/staging/imx-drm/imx-tve.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/imx-tve.c
b/drivers/staging/imx-drm/imx-tve.c
index 3e8b0a1..a46905f 100644
--- a/drivers/staging/imx-drm/imx-tve.c
+++ b/drivers/staging/imx-drm/imx-tve.c
@@ -665,7 +665,8 @@ static int imx_tve_bind(struct device *dev, struct device
*master, void *data)
ret = regmap_read(tve-regmap, TVE_COM_CONF_REG, val);
if (ret 0) {
- dev_err(dev, failed to read configuration register: %d\n,
ret);
+ dev_err(dev, failed to read configuration register: %d\n,
+ ret);
return ret;
}
if (val != 0x0010) {
Does not apply :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: dgnc: fix macro coding style issue in digi.h
On Wed, Oct 29, 2014 at 02:12:38AM +0800, Cheng-Yi He wrote: This is a patch to the digi.h file that fixes up the following error found by the checkpatch tool. ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Cheng-Yi He chengyihetai...@gmail.com --- drivers/staging/dgnc/digi.h | 60 ++--- 1 file changed, 30 insertions(+), 30 deletions(-) You didn't test build this patch :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: rts5208: rtsx_scsi: Fixed a brace coding style issue
On Fri, Oct 17, 2014 at 12:30:51AM +0100, Mike Roocroft wrote:
Fixed a coding style issue.
Signed-off-by: Mike Roocroft mike.li...@btinternet.com
---
drivers/staging/rts5208/rtsx_scsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_scsi.c
b/drivers/staging/rts5208/rtsx_scsi.c
index bbbf796..1161082 100644
--- a/drivers/staging/rts5208/rtsx_scsi.c
+++ b/drivers/staging/rts5208/rtsx_scsi.c
@@ -584,9 +584,8 @@ static int start_stop_unit(struct scsi_cmnd *srb, struct
rtsx_chip *chip)
case MAKE_MEDIUM_READY:
case LOAD_MEDIUM:
- if (check_card_ready(chip, lun)) {
+ if (check_card_ready(chip, lun))
return TRANSPORT_GOOD;
- }
set_sense_type(chip, lun, SENSE_TYPE_MEDIA_NOT_PRESENT);
TRACE_RET(chip, TRANSPORT_FAILED);
--
2.1.2
Does not apply :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH][V2] Staging:rtl8723au: open/closed brace issue
On Sun, Oct 26, 2014 at 03:10:22PM +, Paul McQuade wrote:
ERROR: that open brace { should be on the previous line
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_ap.c | 130
++--
1 file changed, 40 insertions(+), 90 deletions(-)
This doesn't apply to my tree :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] staging: rtl8723au:core
On Sun, Oct 26, 2014 at 04:18:52PM +, Paul McQuade wrote: ERROR: spaces required around that ':' (ctx:VxE) Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Your Subject: makes no sense :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8723au pointer issue
On Sun, Oct 26, 2014 at 03:59:56PM +, Paul McQuade wrote: ERROR: foo*bar should be foo *bar Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_cmd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) The subject does not make sense :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] staging: rtl8723au: core style issue
On Mon, Oct 27, 2014 at 12:16:08AM +, Paul McQuade wrote: spaces required around % Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Your subject does not make sense :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH RESEND v2 1/2] Staging: rts5208: helper function to manage aspm during reset
On Tue, Oct 28, 2014 at 07:46:55PM +0100, Fabio Falzoi wrote: Define the helper function rtsx_reset_aspm to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com Reviewed-by: Dan Carpenter dan.carpe...@oracle.com --- drivers/staging/rts5208/rtsx_chip.c | 70 + 1 file changed, 39 insertions(+), 31 deletions(-) These both don't apply, can you refresh again? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/2] staging: rtl8723au: core: pointer issue
On Sun, Oct 26, 2014 at 04:17:46PM +, Paul McQuade wrote: ERROR: foo * bar should be foo *bar Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Again with the odd subject :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/10] staging: unisys: fix blank lines virthba
On Tue, Oct 28, 2014 at 06:42:37PM -0400, Erik Arfvidson wrote: This patch removes unnecessary blanks lines and adds necessary blank lines in virthba. Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) This series doesn't apply, can you please refresh it against my latest staging-testing branch of staging.git and resend? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: android: logger: Remove uneeded tabs in variable declaration
On Tue, Oct 28, 2014 at 11:09:10PM -0700, Tristan Lelong wrote: This patch removes tabs used to align variable names in declaration and assignation. It replaces them with exactly one space. Why? This seems like a totally unneeded change, sorry. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/10] staging: unisys: fix blank lines virthba
On Wed, Oct 29, 2014 at 12:24:57PM -0400, Erik Arfvidson wrote: This patch removes unnecessary blanks lines and adds necessary blank lines in virthba. Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) This patch series still does not apply, please refresh it against my staging-testing branch of staging.git and resend. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3 0/2] Staging: rts5208: rtsx_reset_chip style clean up
On Wed, Oct 29, 2014 at 10:58:17PM +0100, Fabio Falzoi wrote: Clean up the code in rtsx_reset_chip function defining two new helper functions rtsx_reset_aspm and rtsx_enable_pcie_intr. Specifically, the following checkpatch warnings are corrected: * PARENTHESIS_ALIGNMENT at rows 295 and 313 This patch is inspired by the following post on LKML regarding another clean up for rts5208 module: http://www.spinics.net/lists/linux-driver-devel/msg55038.html Changes in v3: * rebased against master branch of linux-next tree That's not going to work, can you redo it against my staging-testing branch of staging.git? Or, if you really want to work off of linux-next, wait a few days before I merge my staging-testing branch into staging-next to show up in linux-next. As it is, these patches don't apply, so I'm going to have to drop them from my queue. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH V2] staging: dgap: re-arrange functions for removing forward declarations
On Thu, Oct 30, 2014 at 12:14:00PM +0900, Daeseok Youn wrote: Re-arrange the functions for removing forward declarations. Tested-by: Mark Hounschell ma...@compro.net Signed-off-by: Daeseok Youn daeseok.y...@gmail.com Tested-by: Mark Hounschell ma...@compro.net --- V2: this patch is rebased on staging-next branch. Still doesn't apply :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[GIT PULL] Staging driver fixes for 3.18-rc3
The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1: Linux 3.18-rc1 (2014-10-19 18:08:38 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.18-rc3 for you to fetch changes up to 238b5ad855924919e5b98d0c772d9dc78795639b: staging: comedi: fix memory leak / bad pointer freeing for chanlist (2014-10-29 16:18:31 +0800) Staging fixes for 3.18-rc3 Here are some staging driver fixes for 3.18-rc3. Mostly iio and comedi driver fixes for issues reported by people. All of these have been in linux-next for a while with no reported issues. Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org Chen Gang (1): drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM Fabio Estevam (1): iio: adc: mxs-lradc: Disable the clock on probe failure Greg Kroah-Hartman (1): Merge tag 'iio-fixes-for-3.18a' of git://git.kernel.org/.../jic23/iio into staging-linus Ian Abbott (4): staging: comedi: (regression) channel list must be set for COMEDI_CMD ioctl staging: comedi: widen subdevice number argument in ioctl handlers staging: comedi: Kconfig: fix config COMEDI_ADDI_APCI_3120 dependants staging: comedi: fix memory leak / bad pointer freeing for chanlist Jes Sorensen (1): staging: rtl8723au: Fix alignment of mac_addr for ether_addr_copy() usage Lars-Peter Clausen (2): staging:iio:ad5933: Fix NULL pointer deref when enabling buffer staging:iio:ad5933: Drop raw from channel names Robin van der Gracht (1): iio: st_sensors: Fix buffer copy drivers/iio/common/st_sensors/st_sensors_buffer.c | 2 +- drivers/staging/comedi/Kconfig| 2 +- drivers/staging/comedi/comedi_fops.c | 26 --- drivers/staging/iio/adc/mxs-lradc.c | 12 +++ drivers/staging/iio/impedance-analyzer/ad5933.c | 15 ++--- drivers/staging/rtl8723au/include/rtw_eeprom.h| 2 +- 6 files changed, 31 insertions(+), 28 deletions(-) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver
On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote: +#define DEBUG I doubt you want this in the driver enabled by default :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver
On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote:
+EXPORT_SYMBOL(mausb_register_ms_driver);
EXPORT_SYMBOL_GPL()? I have to ask...
+static int mausb_hcd_init(void)
+{
+ int ret;
+
+ /* register HCD driver */
+ ret = platform_driver_register(mausb_driver);
Why is this a platform driver? How does this relate to platform
hardware?
+ if (ret 0) {
+ printk(KERN_DEBUG %s: failed to register HC driver:
+ error number %d\n, __func__, ret);
pr_err()?
return here, that way you don't need:
+ } else {
This indentation.
+ /* register HCD device */
+ ret = platform_device_register(mausb_pdev);
But again, why is this a platform device? What platform resources does
it have / require?
+
+ if (ret 0) {
+ printk(KERN_DEBUG %s: failed to register HC device:
+ error number %d\n, __func__, ret);
pr_err()?
+ platform_driver_unregister(mausb_driver);
+ } else {
+ /* direct the release function (for exiting) */
+ mausb_pdev.dev.release = mausb_dev_release;
That seems like a serious hack, why do you need to do this in this
manner?
+
+ if (ret 0) {
+ printk(KERN_DEBUG failed to register HC
+ chardev: error number %d\n, ret);
pr_err()?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 10/10] added kernel build, configuration, and TODO files
On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/drivers/Makefile @@ -0,0 +1,20 @@ +#MY_CFLAGS =-g -O0 -DEBUG_OUTPUT Please remove that line, it's not ever to be used. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 10/10] added kernel build, configuration, and TODO files
On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,14 @@ +TODO: + - checkpatch.pl cleanups Is this still true? And why does this need to be a staging driver? What's wrong with making it a real driver now? + - address miscellaneous TODO statements in code + - add support for multiple media agnostic (MA) devices + - add/improve support for unimplemented packet types + - handle errors and failure with more grace and less crash + +Please send patches to Greg Kroah-Hartman g...@kroah.com and cc: You didn't use this email address... + Sean Stalley sean.stal...@intel.com + Stephanie Wallick stephanie.s.wall...@intel.com + Just make a MAINTAINERS entry please for this info. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 11/24] staging: unisys: refactor VISORCHIPSET_EXTERNALPORT_INFO
On Fri, Oct 31, 2014 at 09:57:30AM -0400, Benjamin Romer wrote:
Remove the typedef and just use struct visorchipset_externalport_info instead.
Fix all CamelCase names:
switchNo = switch_no
externalPortNo = external_port_no
networkZoneGuid = network_zone_uuid
pdPort = pd_port
ipNetmask = ip_netmask
ipBroadcast = ip_broadcast
ipNetwork = ip_network
ipGateway = ip_gateway
ipDNS = ip_dns
Reserved1 = reserved1
Reserved2 = reserved2
pendingMsgHdr = pending_msg_hdr
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorchipset/visorchipset.h | 31
+++---
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h
b/drivers/staging/unisys/visorchipset/visorchipset.h
index 762bc13..e20eb10 100644
--- a/drivers/staging/unisys/visorchipset/visorchipset.h
+++ b/drivers/staging/unisys/visorchipset/visorchipset.h
@@ -178,25 +178,24 @@ struct visorchipset_switch_info {
/** Attributes for a particular Supervisor external port, which is connected
* to a specific switch.
*/
-typedef struct {
- u32 switchNo;
- u32 externalPortNo;
+struct visorchipset_externalport_info {
+ u32 switch_no;
+ u32 external_port_no;
struct visorchipset_state state;
- uuid_le networkZoneGuid;
- int pdPort;
+ uuid_le network_zone_uuid;
+ int pd_port;
u8 *ip;
- u8 *ipNetmask;
- u8 *ipBroadcast;
- u8 *ipNetwork;
- u8 *ipGateway;
- u8 *ipDNS;
- u64 Reserved1;
- u32 Reserved2; /* control_vm_id */
+ u8 *ip_netmask;
+ u8 *ip_broadcast;
+ u8 *ip_network;
+ u8 *ip_gateway;
+ u8 *ip_dns;
+ u64 reserved1;
+ u32 reserved2; /* control_vm_id */
struct device dev;
BOOL dev_exists;
- struct controlvm_message_header pendingMsgHdr;
-
-} VISORCHIPSET_EXTERNALPORT_INFO;
+ struct controlvm_message_header pending_msg_hdr;
+};
/** Attributes for a particular Supervisor internal port, which is how a
* device connects to a particular switch.
@@ -278,7 +277,7 @@ BOOL visorchipset_get_device_info(ulong busNo, ulong
devNo,
BOOL visorchipset_get_switch_info(ulong switchNo,
struct visorchipset_switch_info *switchInfo);
BOOL visorchipset_get_externalport_info(ulong switchNo, ulong externalPortNo,
- VISORCHIPSET_EXTERNALPORT_INFO
+ struct visorchipset_externalport_info
*externalPortInfo);
BOOL visorchipset_set_bus_context(ulong busNo, void *context);
BOOL visorchipset_set_device_context(ulong busNo, ulong devNo, void
*context);
Same here, can it just be deleted?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 12/24] staging: unisys: refactor VISORCHIPSET_INTERNALPORT_INFO
On Fri, Oct 31, 2014 at 09:57:31AM -0400, Benjamin Romer wrote:
Get rid of the typedef and use struct visorchipset_internalport_info and fix
CamelCase member names:
switchNo = switch_no
internalPortNo = internal_port_no
busNo = bus_no
devNo = dev_no
Reserved1 = reserved1
Reserved2 = reserved2
pendingMsgHdr = pending_msg_hdr
procObject = proc_object
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorchipset/visorchipset.h | 22
+++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h
b/drivers/staging/unisys/visorchipset/visorchipset.h
index e20eb10..7d3b2c1 100644
--- a/drivers/staging/unisys/visorchipset/visorchipset.h
+++ b/drivers/staging/unisys/visorchipset/visorchipset.h
@@ -200,18 +200,18 @@ struct visorchipset_externalport_info {
/** Attributes for a particular Supervisor internal port, which is how a
* device connects to a particular switch.
*/
-typedef struct {
- u32 switchNo;
- u32 internalPortNo;
+struct visorchipset_internalport_info {
+ u32 switch_no;
+ u32 internal_port_no;
struct visorchipset_state state;
- u32 busNo; /* valid only when state.attached == 1 */
- u32 devNo; /* valid only when state.attached == 1 */
- u64 Reserved1;
- u32 Reserved2; /* CONTROLVM_ID */
- struct controlvm_message_header pendingMsgHdr;
- MYPROCOBJECT *procObject;
-
-} VISORCHIPSET_INTERNALPORT_INFO;
+ u32 bus_no; /* valid only when state.attached == 1 */
+ u32 dev_no; /* valid only when state.attached == 1 */
+ u64 reserved1;
+ u32 reserved2; /* CONTROLVM_ID */
+ struct controlvm_message_header pending_msg_hdr;
+ MYPROCOBJECT *proc_object;
+
+};
/* These functions will be called from within visorchipset when certain
* events happen. (The implementation of these functions is outside of
And here, deleted?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 10/24] staging: unisys: refactor VISORCHIPSET_SWITCH_INFO
On Fri, Oct 31, 2014 at 09:57:29AM -0400, Benjamin Romer wrote:
Remove the typedef and use struct visorchipset_switch_info instead. Fix all
CamelCase member names:
switchNo = switch_no
switchTypeGuid = switch_type_uuid
authService1 = authservice1
authService2 = authservice2
authService3 = authservice3
securityContext = security_context
Reserved = reserved
Reserved2 = reserved2
pendingMsgHdr = pending_msg_hdr
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorchipset/visorchipset.h | 25
+++---
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h
b/drivers/staging/unisys/visorchipset/visorchipset.h
index a578d0a..762bc13 100644
--- a/drivers/staging/unisys/visorchipset/visorchipset.h
+++ b/drivers/staging/unisys/visorchipset/visorchipset.h
@@ -160,21 +160,20 @@ findbus(struct list_head *list, u32 bus_no)
/** Attributes for a particular Supervisor switch.
*/
-typedef struct {
- u32 switchNo;
+struct visorchipset_switch_info {
+ u32 switch_no;
struct visorchipset_state state;
- uuid_le switchTypeGuid;
- u8 *authService1;
- u8 *authService2;
- u8 *authService3;
- u8 *securityContext;
- u64 Reserved;
- u32 Reserved2; /* control_vm_id */
+ uuid_le switch_type_uuid;
+ u8 *authservice1;
+ u8 *authservice2;
+ u8 *authservice3;
+ u8 *security_context;
+ u64 reserved;
+ u32 reserved2; /* control_vm_id */
struct device dev;
BOOL dev_exists;
- struct controlvm_message_header pendingMsgHdr;
-
-} VISORCHIPSET_SWITCH_INFO;
+ struct controlvm_message_header pending_msg_hdr;
+};
/** Attributes for a particular Supervisor external port, which is connected
* to a specific switch.
@@ -277,7 +276,7 @@ BOOL visorchipset_get_bus_info(ulong busNo,
BOOL visorchipset_get_device_info(ulong busNo, ulong devNo,
struct visorchipset_device_info *devInfo);
BOOL visorchipset_get_switch_info(ulong switchNo,
- VISORCHIPSET_SWITCH_INFO *switchInfo);
+ struct visorchipset_switch_info *switchInfo);
BOOL visorchipset_get_externalport_info(ulong switchNo, ulong externalPortNo,
VISORCHIPSET_EXTERNALPORT_INFO
*externalPortInfo);
Does no one do anythign with this structure? If so, why not just delete
it?
In future patches, don't worry about it in this series.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver
On Mon, Nov 03, 2014 at 04:04:42PM -0800, steph wrote:
On Mon, Nov 03, 2014 at 01:21:39PM -0800, Greg KH wrote:
On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote:
+EXPORT_SYMBOL(mausb_register_ms_driver);
EXPORT_SYMBOL_GPL()? I have to ask...
The source is dual-licenced under BSD and GPL. It was our understanding
that dual-licensed should use EXPORT_SYMBOL() instead. Is that wrong?
Talk to your company lawyers please to get confirmation of what you want
to do here, I can't answer this question, I just have to ask...
+static int mausb_hcd_init(void)
+{
+ int ret;
+
+ /* register HCD driver */
+ ret = platform_driver_register(mausb_driver);
Why is this a platform driver? How does this relate to platform
hardware?
The driver doesn't require platform resources. It looks like a host
controller driver but communicates over the network instead of to
a physical host controller. There is no MA USB-specific hardware.
Should we use a struct device instead of a struct platform_device?
Yes, please make it a virtual device.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH V3] staging: dgap: re-arrange functions for removing forward declarations
On Tue, Nov 04, 2014 at 08:07:01AM +0900, DaeSeok Youn wrote: Greg, check this patch, please. This patch was rebased on staging-testing tree. Thanks. regards, Daeseok Youn 2014-10-31 10:20 GMT+09:00 Daeseok Youn daeseok.y...@gmail.com: 3 days after sending this? Please give me a chance, I get hundreds of patches a week... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 05/10] added media specific (MS) TCP drivers
On Tue, Nov 04, 2014 at 09:48:33AM +0100, Tobias Klauser wrote:
On 2014-11-03 at 21:42:52 +0100, Stephanie Wallick
stephanie.s.wall...@intel.com wrote:
This is where we handle media specific packets and transport. The MS driver
interfaces with a media agnostic (MA) driver via a series of transfer pairs.
Transfer pairs consist of a set of functions to pass MA USB packets back
and forth between MA and MS drivers. There is one transfer pair per device
endpoint and one transfer pair for control/management traffic. When the MA
driver needs to send an MA USB packet, it hands the packet off to the MS
layer where the packet is converted into an MS form and sent via TCP over
the underlying ethernet or wireless medium. When the MS driver receives a
packet, it converts it into an MA USB packet and hands it off the the MA
driver for handling.
In addition, the MS driver provides an interface to inititate connection
events.
Because there are no physical MA USB ports in an MA USB host, the host must
be
notified via software when a device is connected.
Lastly, the MS driver contains a number of ioctl functions that are used by
a
utility to adjust medium-related driver parameters and connect or
disconnect the
MA USB host and device drivers.
Signed-off-by: Sean O. Stalley sean.stal...@intel.com
Signed-off-by: Stephanie Wallick stephanie.s.wall...@intel.com
---
drivers/staging/mausb/drivers/mausb_ioctl.c | 373 +++
drivers/staging/mausb/drivers/mausb_ioctl.h | 99 +
drivers/staging/mausb/drivers/mausb_msapi.c | 110 ++
drivers/staging/mausb/drivers/mausb_msapi.h | 232
drivers/staging/mausb/drivers/mausb_tcp-device.c | 147
drivers/staging/mausb/drivers/mausb_tcp-host.c | 144
drivers/staging/mausb/drivers/mausb_tcp.c| 446
+++
drivers/staging/mausb/drivers/mausb_tcp.h| 129 +++
8 files changed, 1680 insertions(+)
create mode 100644 drivers/staging/mausb/drivers/mausb_ioctl.c
create mode 100644 drivers/staging/mausb/drivers/mausb_ioctl.h
create mode 100644 drivers/staging/mausb/drivers/mausb_msapi.c
create mode 100644 drivers/staging/mausb/drivers/mausb_msapi.h
create mode 100644 drivers/staging/mausb/drivers/mausb_tcp-device.c
create mode 100644 drivers/staging/mausb/drivers/mausb_tcp-host.c
create mode 100644 drivers/staging/mausb/drivers/mausb_tcp.c
create mode 100644 drivers/staging/mausb/drivers/mausb_tcp.h
diff --git a/drivers/staging/mausb/drivers/mausb_ioctl.c
b/drivers/staging/mausb/drivers/mausb_ioctl.c
new file mode 100644
index 000..0c6c6bd
--- /dev/null
+++ b/drivers/staging/mausb/drivers/mausb_ioctl.c
[...]
+/**
+ * This function is used to send a message to the user, in other words, the
+ * calling process. It basically copies the message one byte at a time.
+ *
+ * @msg: The message to be sent to the user.
+ * @buffer:The buffer in which to put the message. This buffer was
given to
+ * us to fill.
+ */
+void to_user(char *msg, long unsigned int buffer)
+{
+ int length = (int)strlen(msg);
+ int bytes = 0;
+
+ while (length *msg) {
+ put_user(*(msg++), (char *)buffer++);
+ length--;
+ bytes++;
+ }
Any reason not to use copy_to_user here? That way, access_ok would only
need to be executed once for the whole range.
In any case, the return value of put_user/copy_to_user will need to be
checked.
Never use put_user if you can help it, this whole function should go
away, and copy_to_user() should be used at the caller sites instead as
you point out.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 10/10] added kernel build, configuration, and TODO files
On Tue, Nov 04, 2014 at 09:55:19AM -0800, sostalle wrote: On Mon, Nov 03, 2014 at 01:24:04PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,14 @@ +TODO: + - checkpatch.pl cleanups Is this still true? checkpatch.pl reports: total: 7 errors, 208 warnings, 10489 lines checked Ok, fair enough. And why does this need to be a staging driver? What's wrong with making it a real driver now? The short answer is: We don't think it's ready to be real. We didn't want to release it as a real driver because: - It's not stable enough yet. - It doesn't implement all the features required by the MA USB spec. - The MA USB spec isn't standalone. It requires a supplemental spec to define media-specific behavior, like how MA USB packets are encapsulated, how to discover MA USB devices on a network, etc. So far, no media-specific specifications have been published. - There are no commercially-available Media Agnostic USB devices. We wanted to release it to staging now because: - We have received requests from multiple companies for our host MA USB driver. Putting it in staging seemed the best way to distribute it. - We feel that releasing what we have to staging now could promote collaboration on one driver help prevent duplicate work. Ok, please include that information in the first email, it's much more helpful :) Can you resend this series, and cc: the linux-usb mailing list, and address the what about usbip? questions as well? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging:rtl8723au: core: Fix error reported by checkpatch.
On Wed, Nov 05, 2014 at 05:05:03PM +0530, Sanjeev Sharma wrote: This is a patch to the rtw_cmd.c file that fixes Error reported by checkpatch. What error are you fixing? Please be specific. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 04/15] staging: unisys: add comment to spinlock in struct charqueue
On Tue, Nov 04, 2014 at 11:25:14AM -0500, Benjamin Romer wrote:
Add a comment to the charqueue's spinlock to explain that it is a lock for the
structure.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/visorutil/charqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorutil/charqueue.c
b/drivers/staging/unisys/visorutil/charqueue.c
index 1ce7003..46582f1 100644
--- a/drivers/staging/unisys/visorutil/charqueue.c
+++ b/drivers/staging/unisys/visorutil/charqueue.c
@@ -28,7 +28,7 @@
struct charqueue {
int alloc_size;
int nslots;
- spinlock_t lock;
+ spinlock_t lock; /*read/write lock for this structure*/
What's the adversion to using ' ' in a comment block? :)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: unisys: remove unused types from visorchipset.h
On Wed, Nov 05, 2014 at 12:47:49PM -0500, Benjamin Romer wrote: Delete the following unused types, and unused function prototypes: VISORCHIPSET_SWITCH_INFO VISORCHIPSET_EXTERNALPORT_INFO VISORCHIPSET_INTERNALPORT_INFO visorchipset_get_switch_info() visorchipset_get_externalport_info() Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visorchipset/visorchipset.h | 62 -- 1 file changed, 62 deletions(-) You already sent this patch, right? I doesn't apply at all to my tree :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver
On Wed, Nov 05, 2014 at 12:14:33PM -0800, sostalle wrote:
On Mon, Nov 03, 2014 at 04:13:55PM -0800, Greg KH wrote:
On Mon, Nov 03, 2014 at 04:04:42PM -0800, steph wrote:
On Mon, Nov 03, 2014 at 01:21:39PM -0800, Greg KH wrote:
On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote:
[snip]
+static int mausb_hcd_init(void)
+{
+ int ret;
+
+ /* register HCD driver */
+ ret = platform_driver_register(mausb_driver);
Why is this a platform driver? How does this relate to platform
hardware?
The driver doesn't require platform resources. It looks like a host
controller driver but communicates over the network instead of to
a physical host controller. There is no MA USB-specific hardware.
Should we use a struct device instead of a struct platform_device?
Yes, please make it a virtual device.
Is it OK for our virtual host controller to use struct platform_device?
The other virtual host controllers (usbip/vhci_hcd.c gadget/udc/dummy_hcd.c)
use the platform_device struct. Unless I am missing something, it doesn't look
like the other virtual host controllers use platform resources.
If it is not ok, is there a good example somewhere of a virtual non-platform
device?
If your device is not really a platform device (i.e. no platform
resources), then just create a virtual device with a call to
device_create() and don't pass in a parent pointer. But you need to
create a class for it, which is a pain, but shouldn't be that hard.
Hope this helps,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: unisys: Remove unnecessary spaces after casts in virthba.c
On Wed, Nov 05, 2014 at 04:04:32PM -0500, Ken Depro wrote: From: Ken Depro kenneth.de...@unisys.com This patch removes unneeded spaces after casts within the virthba.c file. The checkpatch script was run after these changes, and no remove spaces after casts checks were generated. Later patches will fix the other checkpatch warnings/checks. Signed-off-by: Ken Depro kenneth.de...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 130 +++--- 1 files changed, 65 insertions(+), 65 deletions(-) This doesn't apply to my tree, please always sync up with changes that others on your team have sent in for the same file... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch.
Please specify the error in the subject in some way.
On Thu, Nov 06, 2014 at 11:46:13AM +0530, Sanjeev Sharma wrote:
This is a patch to the rtw_cmd.c file that fixes following
error.
ERROR: spaces required around that '' (ctx:WxV)
ERROR: that open brace { should be on the previous line
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
---
drivers/staging/rtl8723au/core/rtw_cmd.c | 83
+++-
1 file changed, 40 insertions(+), 43 deletions(-)
This does two different things, please make it different patches.
And you sent 2 patches, with no hint as to which one comes before which.
Please resend all of them, correctly numbered in a series, so that I
have a chance to get the order correct when applying them.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging:rtl8723au: core: Fix Warning reported by checkpatch.
On Thu, Nov 06, 2014 at 12:06:36PM +0530, Sanjeev Sharma wrote:
This is a patch to the rtw_cmd.c file that fixes following
Warning by introducing temporary structure.
WARNING: line over 80 characters
Signed-off-by: Sanjeev Sharma sanjeev_sha...@mentor.com
---
drivers/staging/rtl8723au/core/rtw_cmd.c | 123
+++
1 file changed, 60 insertions(+), 63 deletions(-)
Same as the other patch, give us a hint as to the warning in the
subject.
diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c
b/drivers/staging/rtl8723au/core/rtw_cmd.c
index 4eaa502..6186575 100644
--- a/drivers/staging/rtl8723au/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723au/core/rtw_cmd.c
@@ -919,34 +919,34 @@ static void traffic_status_watchdog(struct rtw_adapter
*padapter)
u8 bHigherBusyTxTraffic = false;
struct mlme_priv *pmlmepriv = padapter-mlmepriv;
int BusyThreshold = 100;
+ struct rt_link_detect *ldi = pmlmepriv-LinkDetectInfo;
+
/* */
/* Determine if our traffic is busy now */
/* */
if (check_fwstate(pmlmepriv, _FW_LINKED)) {
if (rtl8723a_BT_coexist(padapter))
BusyThreshold = 50;
- else if (pmlmepriv-LinkDetectInfo.bBusyTraffic)
+ else if (ldi-bBusyTraffic)
BusyThreshold = 75;
/* if we raise bBusyTraffic in last watchdog, using
lower threshold. */
- if (pmlmepriv-LinkDetectInfo.NumRxOkInPeriod BusyThreshold ||
- pmlmepriv-LinkDetectInfo.NumTxOkInPeriod BusyThreshold) {
+ if (ldi-NumRxOkInPeriod BusyThreshold ||
+ ldi-NumTxOkInPeriod BusyThreshold) {
bBusyTraffic = true;
- if (pmlmepriv-LinkDetectInfo.NumRxOkInPeriod
- pmlmepriv-LinkDetectInfo.NumTxOkInPeriod)
+ if (ldi-NumRxOkInPeriod ldi-NumTxOkInPeriod)
bRxBusyTraffic = true;
else
bTxBusyTraffic = true;
}
/* Higher Tx/Rx data. */
- if (pmlmepriv-LinkDetectInfo.NumRxOkInPeriod 4000 ||
- pmlmepriv-LinkDetectInfo.NumTxOkInPeriod 4000) {
+ if (ldi-NumRxOkInPeriod 4000 ||
+ ldi-NumTxOkInPeriod 4000) {
bHigherBusyTraffic = true;
- if (pmlmepriv-LinkDetectInfo.NumRxOkInPeriod
- pmlmepriv-LinkDetectInfo.NumTxOkInPeriod)
+ if (ldi-NumRxOkInPeriod ldi-NumTxOkInPeriod)
bHigherBusyRxTraffic = true;
else
bHigherBusyTxTraffic = true;
@@ -955,9 +955,9 @@ static void traffic_status_watchdog(struct rtw_adapter
*padapter)
if (!rtl8723a_BT_coexist(padapter) ||
!rtl8723a_BT_using_antenna_1(padapter)) {
/* check traffic for powersaving. */
- if (((pmlmepriv-LinkDetectInfo.NumRxUnicastOkInPeriod +
- pmlmepriv-LinkDetectInfo.NumTxOkInPeriod) 8) ||
- pmlmepriv-LinkDetectInfo.NumRxUnicastOkInPeriod 2)
+ if (((ldi-NumRxUnicastOkInPeriod +
+ ldi-NumTxOkInPeriod) 8) ||
+ ldi-NumRxUnicastOkInPeriod 2)
bEnterPS = false;
else
bEnterPS = true;
@@ -971,15 +971,15 @@ static void traffic_status_watchdog(struct rtw_adapter
*padapter)
} else
LPS_Leave23a(padapter);
- pmlmepriv-LinkDetectInfo.NumRxOkInPeriod = 0;
- pmlmepriv-LinkDetectInfo.NumTxOkInPeriod = 0;
- pmlmepriv-LinkDetectInfo.NumRxUnicastOkInPeriod = 0;
- pmlmepriv-LinkDetectInfo.bBusyTraffic = bBusyTraffic;
- pmlmepriv-LinkDetectInfo.bTxBusyTraffic = bTxBusyTraffic;
- pmlmepriv-LinkDetectInfo.bRxBusyTraffic = bRxBusyTraffic;
- pmlmepriv-LinkDetectInfo.bHigherBusyTraffic = bHigherBusyTraffic;
- pmlmepriv-LinkDetectInfo.bHigherBusyRxTraffic = bHigherBusyRxTraffic;
- pmlmepriv-LinkDetectInfo.bHigherBusyTxTraffic = bHigherBusyTxTraffic;
+ ldi-NumRxOkInPeriod = 0;
+ ldi-NumTxOkInPeriod = 0;
+ ldi-NumRxUnicastOkInPeriod = 0;
+ ldi-bBusyTraffic = bBusyTraffic;
+ ldi-bTxBusyTraffic = bTxBusyTraffic;
+ ldi-bRxBusyTraffic = bRxBusyTraffic;
+ ldi-bHigherBusyTraffic = bHigherBusyTraffic;
+ ldi-bHigherBusyRxTraffic = bHigherBusyRxTraffic;
+ ldi-bHigherBusyTxTraffic = bHigherBusyTxTraffic;
}
static void dynamic_chk_wk_hdl(struct rtw_adapter *padapter, u8 *pbuf, int
sz)
@@ -1017,46 +1017,44 @@ static void lps_ctrl_wk_hdl(struct rtw_adapter
*padapter, u8 lps_ctrl_type)
check_fwstate(pmlmepriv, WIFI_ADHOC_STATE))
Re: [PATCH] staging: unisys: Remove unnecessary spaces after casts in virthba.c
On Thu, Nov 06, 2014 at 10:33:28AM -0500, Ken Depro wrote: From: Ken Depro kenneth.de...@unisys.com This patch removes unneeded spaces after casts within the virthba.c file. The checkpatch script was run after these changes, and no remove spaces after casts checks were generated. Later patches will fix the other checkpatch warnings/checks. Conflicts: drivers/staging/unisys/virthba/virthba.c How can a single patch conflict with anything else? What is this here from? confused, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: unisys: Remove unnecessary spaces after casts in virthba.c
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Nov 06, 2014 at 10:22:30AM -0600, Depro, Kenneth J wrote: Greg, When I executed the format-patch command, it added the conflict lines below. There was indeed a conflict in this file from yesterday (I had originally pulled/built from staging-next, but there was another pending patch of mine in staging-testing that was not in -next, which caused the original apply failure). Please line-wrap your emails... Anyway, please resend this, with the change that Dan pointed out, and the text removed from the changelog area, as obviously, that doesn't make any sense to have in a patch, right? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: unisys: add visorclientbus driver
On Thu, Nov 06, 2014 at 12:53:32PM -0600, Ken Cox wrote: From: Benjamin Romer benjamin.ro...@unisys.com This patch adds the visorclientbus driver to the Unisys s-Par driver set. This driver is responsible for helping manage virtual devices like keyboards, mice, serial ports, displays, and any customized drivers for special-purpose guests. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com Signed-off-by: Ken Cox j...@redhat.com --- drivers/staging/unisys/Kconfig | 1 + drivers/staging/unisys/Makefile| 1 + drivers/staging/unisys/visorclientbus/Kconfig | 9 + drivers/staging/unisys/visorclientbus/Makefile | 13 + .../unisys/visorclientbus/visorclientbus_main.c| 378 + I really don't want to accept any new features for this codebase, until you have cleaned up the existing mess. 5 files changed, 402 insertions(+) create mode 100644 drivers/staging/unisys/visorclientbus/Kconfig create mode 100644 drivers/staging/unisys/visorclientbus/Makefile create mode 100644 drivers/staging/unisys/visorclientbus/visorclientbus_main.c diff --git a/drivers/staging/unisys/Kconfig b/drivers/staging/unisys/Kconfig index ac080c9..d63b035 100644 --- a/drivers/staging/unisys/Kconfig +++ b/drivers/staging/unisys/Kconfig @@ -16,5 +16,6 @@ source drivers/staging/unisys/channels/Kconfig source drivers/staging/unisys/uislib/Kconfig source drivers/staging/unisys/virtpci/Kconfig source drivers/staging/unisys/virthba/Kconfig +source drivers/staging/unisys/visorclientbus/Kconfig endif # UNISYSSPAR diff --git a/drivers/staging/unisys/Makefile b/drivers/staging/unisys/Makefile index b988d69..794177b 100644 --- a/drivers/staging/unisys/Makefile +++ b/drivers/staging/unisys/Makefile @@ -8,3 +8,4 @@ obj-$(CONFIG_UNISYS_CHANNELSTUB) += channels/ obj-$(CONFIG_UNISYS_UISLIB) += uislib/ obj-$(CONFIG_UNISYS_VIRTPCI) += virtpci/ obj-$(CONFIG_UNISYS_VIRTHBA) += virthba/ +obj-$(CONFIG_UNISYS_VISORCLIENTBUS) += visorclientbus/ diff --git a/drivers/staging/unisys/visorclientbus/Kconfig b/drivers/staging/unisys/visorclientbus/Kconfig new file mode 100644 index 000..62bdbb9 --- /dev/null +++ b/drivers/staging/unisys/visorclientbus/Kconfig @@ -0,0 +1,9 @@ +# +# Unisys visorclientbus configuration +# + +config UNISYS_VISORCLIENTBUS + tristate Unisys visorclientbus driver + depends on UNISYSSPAR UNISYS_VISORCHIPSET UNISYS_UISLIB + ---help--- + If you say Y here, you will enable the Unisys visorclientbus driver. What about if you say 'M'? :) A whole subdirectory for a single .c file? That's not needed, or acceptable. diff --git a/drivers/staging/unisys/visorclientbus/Makefile b/drivers/staging/unisys/visorclientbus/Makefile new file mode 100644 index 000..bfacc0d --- /dev/null +++ b/drivers/staging/unisys/visorclientbus/Makefile @@ -0,0 +1,13 @@ +# +# Makefile for Unisys visorclientbus +# + +obj-$(CONFIG_UNISYS_VISORCLIENTBUS) += visorclientbus.o + +visorclientbus-y := visorclientbus_main.o As this is a single-file module, why not just have the .c file be called visorclientbus.c? +ccflags-y += -Idrivers/staging/unisys/include +ccflags-y += -Idrivers/staging/unisys/uislib +ccflags-y += -Idrivers/staging/unisys/visorchipset +ccflags-y += -Idrivers/staging/unisys/common-spar/include +ccflags-y += -Idrivers/staging/unisys/common-spar/include/channels Here's one example of things that need to be fixed up, you should never need -I lines in a kernel Makefile, otherwise some testing tools are broken. There are also other checkpatch errors in this patch, which makes me not want to take it at all, as you would now just be required to send more fixes for the file. So why not fix things up right the first time? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/5] drivers: serial: jsm: Add the Classic board implementation
On Mon, Nov 03, 2014 at 07:52:38PM +0100, Konrad Zapalowicz wrote:
This commit adds the Digi Classic board implementation to the
staging/jsm driver.
The code here is taken from the staging/dgnc driver and modified to
match the serial/jsm state. This work is mostly based on the changes
that has been done to the code handling the Digi Neo cards with the
inspiration coming from the diff between staging/dgnc and serial/jsm
as well as the LKML history for the jsm_neo.c
The code compiles now and has no sparse and checkpatch errors or
warnings.
The compiler does give me one warning for this file:
+/*
+ * cls_param()
+ * Send any/all changes to the line to the UART.
+ */
+static void cls_param(struct jsm_channel *ch)
+{
+ u8 lcr = 0;
+ u8 uart_lcr = 0;
+ u8 ier = 0;
+ u32 baud = 9600;
+ int quot = 0;
+ struct jsm_board *bd;
+ int i;
+ unsigned int cflag;
+
+ bd = ch-ch_bd;
+ if (!bd)
+ return;
+
+ /*
+ * If baud rate is zero, flush queues, and set mval to drop DTR.
+ */
+ if ((ch-ch_c_cflag (CBAUD)) == 0) {
+ ch-ch_r_head = 0;
+ ch-ch_r_tail = 0;
+ ch-ch_e_head = 0;
+ ch-ch_e_tail = 0;
+
+ cls_flush_uart_write(ch);
+ cls_flush_uart_read(ch);
+
+ /* The baudrate is B0 so all modem lines are to be dropped. */
+ ch-ch_flags |= (CH_BAUD0);
+ ch-ch_mostat = ~(UART_MCR_RTS | UART_MCR_DTR);
+ cls_assert_modem_signals(ch);
+ return;
+ }
+
+ static struct {
+ unsigned int rate;
+ unsigned int cflag;
+ } baud_rates[] = {
+ { 921600, B921600 },
+ { 460800, B460800 },
+ { 230400, B230400 },
+ { 115200, B115200 },
+ { 57600, B57600 },
+ { 38400, B38400 },
+ { 19200, B19200 },
+ { 9600, B9600 },
+ { 4800, B4800 },
+ { 2400, B2400 },
+ { 1200, B1200 },
+ {600, B600},
+ {300, B300},
+ {200, B200},
+ {150, B150},
+ {134, B134},
+ {110, B110},
+ { 75, B75 },
+ { 50, B50 },
+ };
baud_rates needs to be up above the code, as gcc tells me:
drivers/tty/serial/jsm/jsm_cls.c: In function ‘cls_param’:
drivers/tty/serial/jsm/jsm_cls.c:701:2: warning: ISO C90 forbids mixed
declarations and code [-Wdeclaration-after-statement]
static struct {
^
Can you fix that up and resend the series? I've taken the first patch in this
series, as that is an easy one to accept, so no need to resend that one.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: unisys: add visorclientbus driver
On Thu, Nov 06, 2014 at 01:17:56PM -0600, Ken Cox wrote: There are also other checkpatch errors in this patch, which makes me not want to take it at all, as you would now just be required to send more fixes for the file. So why not fix things up right the first time? The only checkpatch warnings I get are: -a warning about the MAINTAINERS file not being updated when adding a new file. MAINTAINERS already has an entry that covers this file -warnings about lines over 80 characters. These are strings for error messages that make the line exceed 80 characters. I thought this was OK. Those error messages should use the correct printk-like calls, and then the checkpatch messages will go away :) So no, it's not ok as-is, please fix up. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 3/4] staging: dgnc: Remove driver in favor of serial/jsm driver
On Fri, Nov 07, 2014 at 12:05:34AM +0100, Konrad Zapalowicz wrote: This commit removes the staging/dgnc driver in favor of the serial/jsm driver. This is because the serial/jsm driver now supports all of the hardware that has been supported by the staging/dgnc plus it offers better overall quality. Given above the staging/dgnc is obsolete now. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com I've applied the other patches in this series, but am going to skip this one at the moment until I get some it works for me verification from someone who has this hardware. So you will have to resend this later on when that happens. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 3/4] staging: dgnc: Remove driver in favor of serial/jsm driver
On Fri, Nov 07, 2014 at 12:36:23AM +0100, Konrad Zapalowicz wrote: On 11/06, Greg KH wrote: On Fri, Nov 07, 2014 at 12:05:34AM +0100, Konrad Zapalowicz wrote: This commit removes the staging/dgnc driver in favor of the serial/jsm driver. This is because the serial/jsm driver now supports all of the hardware that has been supported by the staging/dgnc plus it offers better overall quality. Given above the staging/dgnc is obsolete now. Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com I've applied the other patches in this series, but am going to skip this one at the moment until I get some it works for me verification from someone who has this hardware. I will have some patches following-up this series, mostly fixing some minor stuff that I found going through the current jsm code plus the stuff that can now be shared between neo and cls code. So should I send it and it will end up in the tty testing tree or wait till my patches will make it to the next/mainline. Please send them whenever you have them done and you feel they are correct. In case you want the patches should I mark them somehow so that you know it is something that should go to the tty testing tree? If you just send them saying it is against my tty-testing (or tty-next, as your patches are now merged into that), it's fine. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: unisys: Remove chanstub files While fixing the CamelCase checks for the functions in the chanstub source and header files, I discovered they are no longer being used. This patch r
On Fri, Nov 07, 2014 at 12:51:34PM -0500, Ken Depro wrote: Signed-off-by: Ken Depro kenneth.de...@unisys.com Your Subject: is a bit long... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: unisys: Remove chanstub files
On Fri, Nov 07, 2014 at 12:58:24PM -0500, Ken Depro wrote: While fixing the CamelCase checks for the functions in the chanstub source and header files, I discovered they are no longer being used. This patch removes the two chanstub files, and deletes the #include of these files from uislib.c and uisqueue.c. It also removes the chanstub.o from the channels Makefile. Are you sure this patch is correct? You now have no MODULE_LICENSE or other MODULE_* information for this module, and you have no module_init() or _exit calls. You might not need the init/exit calls, but you will need the MODULE_LICENSE macro. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 1/3] tools: hv: fcopy_daemon: Check buffer limits
On Tue, Oct 21, 2014 at 04:46:58PM +0200, Matej Mužila wrote:
From: Matej Mužila mmuz...@redhat.com
Check if cpmsg-size is in limits of DATA_FRAGMENT
Signed-off-by: Matej Mužila mmuz...@redhat.com
---
If corrupted data are read from /dev/vmbus/hv_fcopy, pwrite can
read from memory outside of the buffer (defined at line 138).
Added check.
Changes made since v1:
* max value of cmesg-size is now derived from structure
definition in sources/include/uapi/linux/hyperv.h
* Fixed comments
diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c
index 6f27e2f..1fc2dc2 100644
--- a/tools/hv/hv_fcopy_daemon.c
+++ b/tools/hv/hv_fcopy_daemon.c
@@ -104,6 +104,10 @@ static int hv_copy_data(struct hv_do_fcopy *cpmsg)
{
ssize_t bytes_written;
+ /* Check if the cpmsg-size is in limits of DATA_FRAGMENT */
+ if (cpmsg-size sizeof(cpmsg-data))
+ return HV_E_FAIL;
+
bytes_written = pwrite(target_fd, cpmsg-data, cpmsg-size,
cpmsg-offset);
ALWAYS run your patches through checkpatch before sending them, so you
don't get grumpy emails from maintainers telling you to do the same
thing...
Please fix this up and resend the whole series.
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: PATCH: Fix coding style warning.
On Sat, Nov 08, 2014 at 06:39:06PM +0200, sharon wrote:
Fix coding style warning.
What coding style warning? Be specific please.
And your subject:, you aren't saying where in the kernel you are fixing
anything, look at other patches for this file in git, what did the
subject look like for them?
(First submission, sorry in advance for any dumb stuff I'm missing.
Let me know and I'll fix it.)
These two sentances don't need to be here :)
Signed-off-by: Sharon Dvir sharon.dv...@mail.huji.ac.il
This doesn't match up with what the From: line above says, so please fix
the from: line.
diff --git a/drivers/staging/android/binder.c
b/drivers/staging/android/binder.c
index c69c40d..655c3bf 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -1267,8 +1267,8 @@ static void
binder_transaction_buffer_release(struct binder_proc *proc,
switch (fp-type) {
case BINDER_TYPE_BINDER:
case BINDER_TYPE_WEAK_BINDER: {
- struct binder_node *node = binder_get_node(proc,
fp-binder);
-
+ struct binder_node *node = binder_get_node(proc,
+ fp-binder);
if (node == NULL) {
pr_err(transaction release %d bad node
%016llx\n,
debug_id, (u64)fp-binder);
What tree did you make this against? This file isn't in linux-next
anymore, is it?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[GIT PULL] Staging driver fixes for 3.18-rc4
The following changes since commit 0df1f2487d2f0d04703f142813d53615d62a1da4: Linux 3.18-rc3 (2014-11-02 15:01:51 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.18-rc4 for you to fetch changes up to bce20b2396626301c65e08306364bce9a7505ae5: Merge tag 'iio-fixes-for-3.18b' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-linus (2014-11-05 11:30:45 -0800) Staging driver fixes for 3.18-rc4 Here are some staging/iio fixes for 3.18-rc4. Nothing major, just a few bugfixes of things that have been reported. Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org Dan Murphy (1): iio: tsl4531: Fix compiler error when CONFIG_PM_OPS is not defined Daniel Baluta (1): io: accel: kxcjk-1013: Fix iio_event_spec direction Fabio Estevam (1): iio: adc: mxs-lradc: Disable the clock on probe failure George McCollister (1): iio: as3935: allocate correct iio_device size Greg Kroah-Hartman (1): Merge tag 'iio-fixes-for-3.18b' of git://git.kernel.org/.../jic23/iio into staging-linus Lars-Peter Clausen (5): staging:iio:ad5933: Fix NULL pointer deref when enabling buffer staging:iio:ad5933: Drop raw from channel names staging:iio:ade7758: Fix NULL pointer deref when enabling buffer staging:iio:ade7758: Fix check if channels are enabled in prenable staging:iio:ade7758: Remove raw from channel name Robin van der Gracht (1): iio: st_sensors: Fix buffer copy drivers/iio/accel/kxcjk-1013.c | 2 +- drivers/iio/light/tsl4531.c | 7 ++-- drivers/iio/proximity/as3935.c | 2 +- drivers/staging/iio/meter/ade7758.h | 1 - drivers/staging/iio/meter/ade7758_core.c | 57 ++-- drivers/staging/iio/meter/ade7758_ring.c | 5 ++- 6 files changed, 20 insertions(+), 54 deletions(-) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [V2 PATCH 01/10] added media agnostic (MA) USB HCD driver
On Mon, Nov 10, 2014 at 06:09:32PM -0800, Stephanie Wallick wrote:
+static int mausb_bus_probe(struct device *dev)
+{
+ return mausb_probe(dev);
+}
+
+static int mausb_bus_remove(struct device *dev)
+{
+ return mausb_remove(dev);
+}
Wrapper functions that just call another function? Why?
+static void mausb_dev_release(struct device *dev)
+{
+ /* TODO: if we dynamically allocate anything, free it here */
+}
As per the documentation in the kernel source tree[1], I am now allowed
to mock you mercilessly for thinking that you know more than the kernel,
and are just providing an empty function just to shut it up from
complaining about no release function at all. Did you stop to think
about _why_ the kernel was warning you about this, and how would an
empty function solve anything?
Sorry, I can never accept code that does this in the kernel, even in
staging, which says a lot...
thanks,
greg k-h
[1] Documentation/kobject.txt, line 270
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [V2 PATCH 05/10] added media specific (MS) TCP drivers
On Mon, Nov 10, 2014 at 06:09:36PM -0800, Stephanie Wallick wrote:
+static int ma_open;
Why do you need this variable?
+/**
+ * This function is used to open the device file in order to read/write
+ * from/to it.
+ *
+ * @inode: Struct with various information that is passed in when this
+ * function is called. We don't need to use it for our purposes.
+ * @file:The file to be opened.
+ */
+static int mausb_open(struct inode *inode, struct file *file)
+{
+ if (ma_open)
+ return -EBUSY;
+ ma_open++;
Racy :(
+ try_module_get(THIS_MODULE);
Even more racy, _NEVER_ make this type of call, it's _ALWAYS_ wrong.
And totally not even needed at all, if you set up your file structure
properly.
+
+ return 0;
+}
+
+/**
+ * This function is used to close the device file.
+ *
+ * @inode: Struct with various information that is passed in when this
+ * function is called. We don't need to use it for our purposes.
+ * @file:The file to be closed.
+ */
+static int mausb_release(struct inode *inode, struct file *file)
+{
+ ma_open--;
Again, racy, and pointless, why are you doing this?
+ module_put(THIS_MODULE);
And again, broken and racy :(
+ return 0;
+}
+
+
+/**
+ * This function is used to execute ioctl commands, determined by ioctl_func.
+ *
+ * @file: The device file. We don't use it directly, but it's passed in.
+ * @ioctl_func:This value determines which ioctl function will be
used.
+ * @ioctl_buffer: This buffer is used to transfer data to/from the device.
+ */
+long mausb_ioctl(struct file *file, unsigned int ioctl_func,
+ unsigned long ioctl_buffer)
+{
+ char message[BUFFER];
+ int ret, value;
+ unsigned long int long_value;
+ char __user *msg = (char *)ioctl_buffer;
+ char *response;
+
+ switch (ioctl_func) {
+ case IOCTL_GET_VRSN:
+ ret = copy_to_user(msg, DRIVER_VERSION, strlen(DRIVER_VERSION));
+ break;
This should be a sysfs file. Why even care about the version?
+ case IOCTL_GET_NAME:
+ ret = copy_to_user(msg, MAUSB_NAME, strlen(MAUSB_NAME));
+ break;
Why?
+ case IOCTL_GADGET_C:
+ ret = gadget_connection(1);
+ if (ret = 0)
+ response = MAUSB_GADGET_C_SUCCESS;
+ else
+ response = MAUSB_GADGET_C_FAIL;
+
+ ret = copy_to_user(msg, response, strlen(response));
+ break;
Can't this be a sysfs file?
+ case IOCTL_GADGET_D:
+ ret = gadget_connection(0);
+ if (ret = 0)
+ response = MAUSB_GADGET_D_SUCCESS;
+ else
+ response = MAUSB_GADGET_D_FAIL;
+
+ ret = copy_to_user(msg, response, strlen(response));
+ break;
Same here.
+ case IOCTL_SET_PORT:
+ ret = strncpy_from_user(message, msg, BUFFER);
+ if (ret 0)
+ break;
+ ret = kstrtoint(msg, 0, value);
+ if (ret != 0)
+ break;
+
+ ret = set_port_no(value);
+ sprintf(message, PORT NUMBER:%d, Returned %i\n, value,
+ ret);
That looks like a debug message.
+ ret = copy_to_user(msg, message, strlen(message));
+ break;
That really looks like a sysfs file.
+ case IOCTL_SET_IP:
+ ret = strncpy_from_user(message, msg, BUFFER);
+ if (ret 0)
+ break;
+ ret = kstrtoul(message, 0, long_value);
+ if (ret != 0)
+ break;
+
+ ret = set_ip_addr(long_value);
+ sprintf(message, IP ADDRESS:%lx, returned %i\n,
+ long_value, ret);
That looks like a debug message :(
+ ret = copy_to_user(msg, message, strlen(message));
+ break;
again sysfs file?
+ case IOCTL_SET_MAC:
+ {
+ u8 mac[6];
+ int i;
+ ret = copy_from_user(mac, msg, 6);
+ if (ret) {
+ pr_err(copy_from_user failed\n);
+ break;
+ }
+ for (i = 0; i ETH_ALEN; i++)
+ pr_info(mac[%d]=0x%x\n, i, mac[i]);
+ ret = set_mac_addr(mac);
+ if (ret)
+ pr_err(unable to set MAC addr\n);
+
+ break;
+ }
And again, sysfs file.
What about any other ioctl? You forgot to return an invalid number.
+ }
+
+ /* failure */
+ if (ret 0)
+ return ret;
You could have just returned a stack value here :(
+
+ /* success */
+ return 0;
No need for the comments, this is a
Re: [V2 PATCH 10/10] added kernel build, configuration, and TODO files
On Mon, Nov 10, 2014 at 06:09:41PM -0800, Stephanie Wallick wrote: Signed-off-by: Sean O. Stalley sean.stal...@intel.com Signed-off-by: Stephanie Wallick stephanie.s.wall...@intel.com No changelog entry? --- MAINTAINERS| 7 +++ drivers/staging/Kconfig| 2 ++ drivers/staging/Makefile | 1 + drivers/staging/mausb/Kconfig | 16 drivers/staging/mausb/Makefile | 2 ++ drivers/staging/mausb/TODO | 5 + drivers/staging/mausb/drivers/Kconfig | 34 ++ drivers/staging/mausb/drivers/Makefile | 18 ++ 8 files changed, 85 insertions(+) create mode 100644 drivers/staging/mausb/Kconfig create mode 100644 drivers/staging/mausb/Makefile create mode 100644 drivers/staging/mausb/TODO create mode 100644 drivers/staging/mausb/drivers/Kconfig create mode 100644 drivers/staging/mausb/drivers/Makefile diff --git a/MAINTAINERS b/MAINTAINERS index c3cfa1b..bd52ec2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8721,6 +8721,13 @@ W: http://www.lirc.org/ S: Odd Fixes F: drivers/staging/media/lirc/ +STAGING - MEDIA AGNOSTIC USB DRIVERS +M: Sean O. Stalley sean.stal...@intel.com +M: Stephanie Wallick stephanie.s.wall...@intel.com +L: linux-...@vger.kernel.org +S: Maintained +F: drivers/staging/mausb + STAGING - NVIDIA COMPLIANT EMBEDDED CONTROLLER INTERFACE (nvec) M: Julian Andres Klode j...@jak-linux.org M: Marc Dietrich marvi...@gmx.de diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index 35b494f..f57621b 100644 --- a/drivers/staging/Kconfig +++ b/drivers/staging/Kconfig @@ -24,6 +24,8 @@ menuconfig STAGING if STAGING +source drivers/staging/mausb/Kconfig + source drivers/staging/et131x/Kconfig source drivers/staging/slicoss/Kconfig Please put yourself at the end, not the top of this file. --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,5 @@ +TODO: + - checkpatch.pl cleanups + - address miscellaneous TODO statements in code + - add support for multiple media agnostic (MA) devices + - add/improve support for unimplemented packet types What about the other comments you already received such as: - unify with usbip diff --git a/drivers/staging/mausb/drivers/Kconfig b/drivers/staging/mausb/drivers/Kconfig new file mode 100644 index 000..9e12e22 --- /dev/null +++ b/drivers/staging/mausb/drivers/Kconfig @@ -0,0 +1,34 @@ +config MA_CORE + tristate MA USB core + ---help--- + This builds ma_core module. + +config MAUSB_HOST + tristate MA USB host + depends on MA_CORE + ---help--- + This builds MA USB host driver module. + +config MAUSB_DEVICE + tristate MA USB device + depends on MA_CORE USB_GADGET + ---help--- + This builds MA USB device driver module. + +config MATCP_CORE + tristate MA USB tcp core + ---help--- + This builds tcp_core module. + +config MATCP_HOST + tristate MA USB host tcp + depends on MATCP_CORE + ---help--- + This builds tcp_host module. + +config MATCP_DEVICE + tristate MA USB device tcp + depends on MATCP_CORE + ---help--- + This builds tcp_dev module. + diff --git a/drivers/staging/mausb/drivers/Makefile b/drivers/staging/mausb/drivers/Makefile new file mode 100644 index 000..47f3222 --- /dev/null +++ b/drivers/staging/mausb/drivers/Makefile @@ -0,0 +1,18 @@ +obj-$(CONFIG_MA_CORE) += ma_core.o +ma_core-y := mausb_pkt.o mausb_tx.o mausb_msapi.o mausb_mem.o mausb_mgmt.o + +obj-$(CONFIG_MAUSB_HOST) += mausb.o +mausb-y := mausb_hcd.o mausb_hub.o mausb_tx-host.o mausb_mem-host.o + +obj-$(CONFIG_MAUSB_DEVICE) += maudc.o +maudc-y := mausb_udc.o mausb_tx-device.o + +obj-$(CONFIG_MATCP_HOST) += matcp_host.o +matcp_host-y := mausb_tcp-host.o + +obj-$(CONFIG_MATCP_DEVICE) += matcp_dev.o +matcp_dev-y := mausb_tcp-device.o + +obj-$(CONFIG_MATCP_CORE) += matcp_core.o +matcp_core-y := mausb_tcp.o mausb_ioctl.o Why so many different modules? Can't you merge most of these together as you can't do anything with just a few of them alone. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [V2 PATCH 03/10] added media agnostic (MA) data structures and handling
On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote:
+/**
+ * Returns the number of urbs currently in the MA USB HCD. Will return 0 if
the
+ * MA USB HCD is empty or a negative errno if an error occurs.
How can this function return a negative number? I don't see that
codepath here, can you show it to me?
+ */
+int mausb_hcd_urb_count(struct mausb_hcd *mhcd)
+{
+ int count = 0;
+ struct mausb_host_ep*ma_ep;
+ struct mausb_dev*mausb_dev;
+ struct mausb_urb*maurb;
+ unsigned long irq_flags;
+
+ /* for every device */
+ spin_lock_irqsave(mhcd-hcd_lock, irq_flags);
+ list_for_each_entry(mausb_dev, mhcd-ma_dev.dev_list, dev_list) {
+ spin_unlock_irqrestore(mhcd-hcd_lock, irq_flags);
+
+ /* for every endpoint */
+ spin_lock_irqsave(mausb_dev-dev_lock, irq_flags);
+ list_for_each_entry(ma_ep, mausb_dev-ep_list, ep_list) {
+ spin_unlock_irqrestore(mausb_dev-dev_lock, irq_flags);
+
+ /* for every urb */
+ spin_lock_irqsave(ma_ep-ep_lock, irq_flags);
+ list_for_each_entry(maurb, ma_ep-urb_list, urb_list) {
+ ++count;
+ }
+
+ spin_unlock_irqrestore(ma_ep-ep_lock, irq_flags);
+ spin_lock_irqsave(mausb_dev-dev_lock, irq_flags);
+ }
+
+ spin_unlock_irqrestore(mausb_dev-dev_lock, irq_flags);
+ spin_lock_irqsave(mhcd-hcd_lock, irq_flags);
+ }
+
+ spin_unlock_irqrestore(mhcd-hcd_lock, irq_flags);
+
+ return count;
+}
There honestly is too many things wrong with this function to even know
where to start. So how about I just ask why you would ever want to know
this number, and what good it would do to even care about it? You do
realize that this number is almost always guaranteed to be wrong once
the function returns, so you better not be doing something with it that
matters.
Intel has a whole group of very experienced Linux kernel developers who
will review code before you sent it out publicly. Please take advantage
of them and run this all through them before resending this out again.
If you did run this code through that group, please let me know who it
was specifically that allowed this stuff to get through, and why they
didn't want their name on this code submission. I need to have a strong
word with them...
Yes, I am holding you to a higher standard than staging code normally
is, and yes, it is purely because of the company you work for. But I
only do that because your company knows how to do this stuff right, and
you have access to the resources and talent to help make this code
right. Other people and companies do not have the kind of advantage
that you do.
Wasting community member's time (i.e. mine) by forcing _them_ to review
stuff like this, is something that your company knows better than to do,
as should you as well.
I want to see some more senior Intel kernel developer's signed-off-by
lines on this code before I will ever consider accepting it for the
kernel. Please do not resend this code until that happens.
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [V2 PATCH 03/10] added media agnostic (MA) data structures and handling
On Tue, Nov 11, 2014 at 02:42:22PM -0800, Sean O. Stalley wrote: On Tue, Nov 11, 2014 at 01:38:21PM +0900, Greg KH wrote: On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote: Intel has a whole group of very experienced Linux kernel developers who will review code before you sent it out publicly. Please take advantage of them and run this all through them before resending this out again. If you did run this code through that group, please let me know who it was specifically that allowed this stuff to get through, and why they didn't want their name on this code submission. I need to have a strong word with them... We submitted the patches for internal review and got no objections to release. We will be more aggressive in seeking out feedback (and approval) before resubmitting any code. Fair enough, it seems you took the only available path and submitted it to the community, which was a good idea, sorry for the rant. Thanks for submitting it publicly and not just waiting forever like I have seen some people do in the past. Yes, I am holding you to a higher standard than staging code normally is, and yes, it is purely because of the company you work for. But I only do that because your company knows how to do this stuff right, and you have access to the resources and talent to help make this code right. Other people and companies do not have the kind of advantage that you do. We know we are fortunate to work for a company with so much talent and resources and we don't mind being held to a higher standard. We have been receiving multiple requests for our host driver and wanted to make it available as soon as possible for others to use. We thought putting our host driver into staging would be a good way to release it, but realize now that it was premature. Does the code even work? The number of basic mistakes in it seems to imply that it doesn't, but I could be mistaken. We won't resubmit the driver until a senior kernel developer has signed off on it. Good, go kick some of them and get them to review the code, _after_ at least addressing the issues that the community has raised, you don't want to waste their time finding the same things we just did :) thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: media: bcm2048: fix coding style error
On Sat, Nov 15, 2014 at 09:59:34PM +0100, Pavel Machek wrote: On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote: On 11/15, Christian Resell wrote: Simple style fix (checkpatch.pl: space prohibited before that ','). For the eudyptula challenge (http://eudyptula-challenge.org/). Nice, however we do not need the information about the 'eudyptula challenge' in the commit message. If you want to include extra information please do it after the '---' line (just below the signed-off). You will find more details in the SubmittingPatches (chapter 15) of the kernel documentation. Greg is staging tree maintainer... And if single extra space is all you can fix in the driver, perhaps it is not worth the patch? I am not the maintainer of drivers/staging/media/ please look at MAINTAINERS before you make statements like that. And yes, one space fixes is just fine, that's why the code is in staging. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] drivers: staging: lustre: lnet: api-nc.c: Fix Style Warnings
On Mon, Nov 17, 2014 at 11:11:36AM -0800, Thomas Wood wrote: Fixed Subject line containing the entire patch description. 88 Ick, what is that here? Please put that below the --- line, otherwise I have to hand-edit the patch in order to apply this :( Please try again. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] staging: unisys: parser.c bug
On Mon, Nov 17, 2014 at 02:46:35PM -0500, Jeffrey Brown wrote: From: Jeff jeffrey.br...@unisys.com This doesn't match your signed-off-by: line, nor your From: line of your email above. Why even have this line when it isn't needed, and wrong? greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging:rtl8723au: Fix sparse warning cast to restricted __le16
On Tue, Nov 18, 2014 at 02:51:45AM +, Tobenna Peter, Igwe wrote: On Mon, Nov 17, 2014 at 05:59:47PM -0800, Greg KH wrote: On Tue, Nov 18, 2014 at 01:45:41AM +, Tobenna P. Igwe wrote: This patch fixes the following sparse warning: drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:343:36: warning: cast to restricted __le16 by using the le16_to_cpus function. Signed-off-by: Tobenna P. Igwe pti...@gmail.com --- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c index d80ea4e..78665ee 100644 --- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c +++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c @@ -340,7 +340,7 @@ static u8 bthci_GetAssocInfo(struct rtw_adapter *padapter, u8 EntryNum) tempBuf, TotalLen-BaseMemoryShift); pAmpAsoc = (struct amp_assoc_structure *)tempBuf; - pAmpAsoc-Length = le16_to_cpu(pAmpAsoc-Length); + le16_to_cpus(pAmpAsoc-Length); This doesn't change the logic, and you should still have the same warning. How about fixing up Length to be the proper endian type? thanks, greg k-h I've checked and sparse doesn't return the warning anymore. Also, I backtracked through the file and Length seems to be set to its correct endian type. The reason for the conversion is tempBuf being an array of 'u8'. Ah, that makes sense, ok, I'll queue this up in a few days when I get a chance. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: lustre: mdc: use __FMODE_EXEC macro
On Mon, Nov 17, 2014 at 04:23:08PM -0800, Juston wrote: On Tue, 2014-11-18 at 01:46 +0300, Dan Carpenter wrote: On Mon, Nov 17, 2014 at 02:23:48PM -0800, Juston Li wrote: FMODE_EXEC is type fmode_t but is used in operations with integers which leads to sparse warnings: drivers/staging/lustre/lustre/mdc/mdc_lib.c:198:21: warning: restricted fmode_t degrades to integer drivers/staging/lustre/lustre/mdc/mdc_locks.c:300:49: warning: restricted fmode_t degrades to integer Fix by using __FMODE_EXEC macro defined in fs.h. Note the same warnings occurs with other fmode flags here but they don't have a corresponding int macro. When are FMODE_EXEC and __FMODE_EXEC not defined? I think they're always defined. I don't understand the point of these ifdefs. I guess maybe they are for compatability with obsolete kernels? regards, dan carpenter Seems to be the case. Looked at some old commits (2.6.17) and found FMODE_EXEC was mainlined to allow lustre to be installed on a vanilla kernel. Since you pointed it out, if we are dealing with compatability with obselete kernels, __FMODE_EXEC was added later in 2.6.38. Wondering if I should address the case where FMODE_EXEC is defined but __FMODE_EXEC isn't since I currently only check __FMODE_EXEC. Just fix it up to work the the current kernel version, no need to support anything else in this codebase. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging:skein: Fix trailing whitespace error
On Fri, Nov 21, 2014 at 05:37:04AM +0530, Anjana Sasindran wrote: This patch fixes the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com --- drivers/staging/skein/skein_generic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c index 7096d5a..8660509 100644 --- a/drivers/staging/skein/skein_generic.c +++ b/drivers/staging/skein/skein_generic.c @@ -190,6 +190,7 @@ static int __init skein_generic_init(void) goto unreg512; return 0; + unreg512: crypto_unregister_shash(alg512); unreg256: Doesn't apply :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging:skein: Fix trailing whitespace error
On Sat, Nov 22, 2014 at 11:34:29AM +0530, Anjana Sasindran wrote: This patch fixes the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com --- drivers/staging/skein/skein_generic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c index 7096d5a..8660509 100644 --- a/drivers/staging/skein/skein_generic.c +++ b/drivers/staging/skein/skein_generic.c @@ -190,6 +190,7 @@ static int __init skein_generic_init(void) goto unreg512; return 0; + unreg512: crypto_unregister_shash(alg512); unreg256: Still doesn't apply :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] drivers:staging:skein:skein_generic.c: Fixed a whitespace error
On Sat, Nov 22, 2014 at 01:11:59PM +0530, Anjana Sasindran wrote: This patch fixes the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com --- drivers/staging/skein/skein_generic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c index 7096d5a..268e4de 100644 --- a/drivers/staging/skein/skein_generic.c +++ b/drivers/staging/skein/skein_generic.c @@ -188,7 +188,6 @@ static int __init skein_generic_init(void) goto unreg256; if (crypto_register_shash(alg1024)) goto unreg512; - return 0; unreg512: crypto_unregister_shash(alg512); Your changelog body does not match the patch :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: lustre: Fix sparse warnings for static declarations
On Tue, Nov 11, 2014 at 12:15:28AM -0500, Adrian Nicoara wrote: All the changes are against variables/functions that are only accessed from within the same file. If the scope needs to change later on, the static keyword can be removed. Build tested. Signed-off-by: Adrian Nicoara anico...@uwaterloo.ca Adds a few build warnings, so I can't take this patch, sorry :( ALWAYS test your patches. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: bcm: nvm: Fixed spelling errors, that may break grep.
On Tue, Nov 25, 2014 at 11:00:35PM +0530, icyflame wrote: Changing the following: Adapater - Adapter STATUS_SUCESS - STATUS_SUCCESS Signed-off by: Siddharth Kannan kannan.siddhart...@gmail.com --- drivers/staging/bcm/nvm.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) Your From: line name does not match your Signed-off-by: line (and you typoed Signed-off-by:), so I can't take this patch, sorry. Please fix and resend. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging:rtl8723au: core: fix checkpatch error: that open brace { should be on the previous line
On Tue, Nov 11, 2014 at 03:28:57PM +0530, Sanjeev Sharma wrote:
This is a patch to the rtw_cmd.c file that fixes following
Error.
ERROR: that open brace { should be on the previous line
This patch does much more than that :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/2] fix some sparse warnings in lustre
On Mon, Nov 24, 2014 at 07:55:40PM +0100, Zahari Doychev wrote: The two patches fix several sparse warning in the lustre module. Zahari Doychev (2): [drivers] staging/lustre: fix sparse warnings [drivers] staging/lustre: fix sparse warnings drivers/staging/lustre/include/linux/lnet/lib-lnet.h | 14 +- drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 15 ++- 2 files changed, 19 insertions(+), 10 deletions(-) Please fix up and resend anything still pending, I've purged your patches from my queue now as they all seem to not be correct :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance
On Wed, Nov 26, 2014 at 05:15:48PM +0100, Loic Pefferkorn wrote:
Add __acquires() and __releases() function annotations, to fix sparse
warnings related to lock context imbalance.
This fixes the following warnings:
drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c:153:5: warning:
context imbalance in 'cfs_trace_lock_tcd' - wrong count at exit
drivers/staging/lustre/lustre/libcfs/hash.c:128:1: warning: context imbalance
in 'cfs_hash_spin_lock' - wrong count at exit
drivers/staging/lustre/lustre/libcfs/hash.c:142:9: warning: context imbalance
in 'cfs_hash_rw_lock' - wrong count at exit
drivers/staging/lustre/lustre/ptlrpc/../../lustre/ldlm/l_lock.c:57:17:
warning: context imbalance in 'lock_res_and_lock' - wrong count at exit
drivers/staging/lustre/lustre/libcfs/libcfs_lock.c:93:1: warning: context
imbalance in 'cfs_percpt_lock' - wrong count at exit
Signed-off-by: Loic Pefferkorn l...@loicp.eu
---
drivers/staging/lustre/lustre/libcfs/hash.c | 4
drivers/staging/lustre/lustre/libcfs/libcfs_lock.c | 2 ++
drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c | 2 ++
drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 ++
4 files changed, 10 insertions(+)
diff --git a/drivers/staging/lustre/lustre/libcfs/hash.c
b/drivers/staging/lustre/lustre/libcfs/hash.c
index 32da783..7c6e2a3 100644
--- a/drivers/staging/lustre/lustre/libcfs/hash.c
+++ b/drivers/staging/lustre/lustre/libcfs/hash.c
@@ -126,18 +126,21 @@ cfs_hash_nl_unlock(union cfs_hash_lock *lock, int
exclusive) {}
static inline void
cfs_hash_spin_lock(union cfs_hash_lock *lock, int exclusive)
+ __acquires(lock-spin)
{
spin_lock(lock-spin);
}
static inline void
cfs_hash_spin_unlock(union cfs_hash_lock *lock, int exclusive)
+ __releases(lock-spin)
{
spin_unlock(lock-spin);
}
Ugh, how horrid, please just delete these functions and push down the
spin_lock/unlock calls down into the places these are called.
static inline void
cfs_hash_rw_lock(union cfs_hash_lock *lock, int exclusive)
+ __acquires(lock-rw)
{
if (!exclusive)
read_lock(lock-rw);
@@ -147,6 +150,7 @@ cfs_hash_rw_lock(union cfs_hash_lock *lock, int exclusive)
static inline void
cfs_hash_rw_unlock(union cfs_hash_lock *lock, int exclusive)
+ __releases(lock-rw)
{
if (!exclusive)
read_unlock(lock-rw);
Same for these.
diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_lock.c
b/drivers/staging/lustre/lustre/libcfs/libcfs_lock.c
index 2c199c7..1e529fc 100644
--- a/drivers/staging/lustre/lustre/libcfs/libcfs_lock.c
+++ b/drivers/staging/lustre/lustre/libcfs/libcfs_lock.c
@@ -91,6 +91,7 @@ EXPORT_SYMBOL(cfs_percpt_lock_alloc);
*/
void
cfs_percpt_lock(struct cfs_percpt_lock *pcl, int index)
+ __acquires(pcl-pcl_locks[index])
{
int ncpt = cfs_cpt_number(pcl-pcl_cptab);
int i;
@@ -125,6 +126,7 @@ EXPORT_SYMBOL(cfs_percpt_lock);
/** unlock a CPU partition */
void
cfs_percpt_unlock(struct cfs_percpt_lock *pcl, int index)
+ __releases(pcl-pcl_locks[index])
{
int ncpt = cfs_cpt_number(pcl-pcl_cptab);
int i;
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c
b/drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c
index 976c61e..257669b 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c
@@ -151,6 +151,7 @@ cfs_trace_buf_type_t cfs_trace_buf_idx_get(void)
* for details.
*/
int cfs_trace_lock_tcd(struct cfs_trace_cpu_data *tcd, int walking)
+ __acquires(tcd-tc_lock)
{
__LASSERT(tcd-tcd_type CFS_TCD_TYPE_MAX);
if (tcd-tcd_type == CFS_TCD_TYPE_IRQ)
@@ -165,6 +166,7 @@ int cfs_trace_lock_tcd(struct cfs_trace_cpu_data *tcd,
int walking)
}
void cfs_trace_unlock_tcd(struct cfs_trace_cpu_data *tcd, int walking)
+ __releases(tcd-tcd_lock)
{
__LASSERT(tcd-tcd_type CFS_TCD_TYPE_MAX);
if (tcd-tcd_type == CFS_TCD_TYPE_IRQ)
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c
b/drivers/staging/lustre/lustre/obdclass/cl_object.c
index ce96bd2..8577f97 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
@@ -193,6 +193,7 @@ static spinlock_t *cl_object_attr_guard(struct cl_object
*o)
* cl_object_attr_get(), cl_object_attr_set().
*/
void cl_object_attr_lock(struct cl_object *o)
+ __acquires(cl_object_attr_guard(o))
{
spin_lock(cl_object_attr_guard(o));
}
@@ -202,6 +203,7 @@ EXPORT_SYMBOL(cl_object_attr_lock);
* Releases data-attributes lock, acquired by cl_object_attr_lock().
*/
void cl_object_attr_unlock(struct cl_object *o)
+ __releases(cl_object_attr_guard(o))
{
spin_unlock(cl_object_attr_guard(o));
}
Re: [PATCH] staging: unisys: Remove chanstub files
On Fri, Nov 07, 2014 at 10:17:40AM -0800, Greg KH wrote: On Fri, Nov 07, 2014 at 12:58:24PM -0500, Ken Depro wrote: While fixing the CamelCase checks for the functions in the chanstub source and header files, I discovered they are no longer being used. This patch removes the two chanstub files, and deletes the #include of these files from uislib.c and uisqueue.c. It also removes the chanstub.o from the channels Makefile. Are you sure this patch is correct? You now have no MODULE_LICENSE or other MODULE_* information for this module, and you have no module_init() or _exit calls. You might not need the init/exit calls, but you will need the MODULE_LICENSE macro. Given that you seem to be ignoring my emails, I'll just go dump the pending patches you have sent me for this driver, as there seems to be a problem in the feedback loop here. Please resend all of your pending patches after fixing this. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/10] parser.h and parser.c patches
On Wed, Nov 12, 2014 at 11:28:15AM -0500, Jeffrey Brown wrote: Sorry for all of the messy patches from before but here are the improved patches for parser.h and parser.c. The camel cases are grouped on functions and structs that occurs in both files. You have to do a 'vN' where 'N' is a number saying that this obsoletes previous patches from you. And I'm totally confused here as to what patches to apply, so please, just resend all of the pending unisys patches you have, in the order you need me to apply them in. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 11/11] staging: unisys: small bug parser.c
On Thu, Nov 13, 2014 at 09:56:39AM -0500, Jeffrey Brown wrote: Fixed small bug in parser.c by removing cleanups: in parser_init _guts struct. Replaced it with proper error handling code and removed the instances of rc = NULL in the code. rc = NULL is redudant Signed-off-by: Jeffrey Brown jeffrey.br...@unisys.com --- drivers/staging/unisys/visorchipset/parser.c | 46 ++--- 1 files changed, 11 insertions(+), 35 deletions(-) where are patches 01/11 - 10/11? Totally confused. What would you do if you were on the receiving end of all of this mess? Am just now deleting all unisys patches from my queue. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: unisys: get rid of channel stub
I _strongly_ suggest unisys get their act together here. The number of patches that were sent recently that make no sense at all is horrid. I've now purged all of them from my to-apply queue, please resend _everything_ that you have, in the correct order, _AFTER_ you all review them among yourselves and agree that they are correct. I also want to see signed-off-by: from more than one person here, showing that someone has actually reviewed them, and takes responsibility for them. In other words, start acting like a maintainer of a subsystem, don't throw random crap all over the place and expect me to sort it out. Otherwise I'll sort it out by just deleting the code from the tree. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Drivers:Staging:octeon: Fixed missing a blank line warning
On Thu, Nov 20, 2014 at 11:31:14PM +0530, Lekshmi wrote: The following checkpatch warning was fixed: WARNING: Missing a blank line after declarations Signed-off-by: Lekshmi andnlnb...@gmail.com I need a full name here, sorry. Please fix and resend. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning
On Wed, Nov 26, 2014 at 05:58:37PM +0530, Athira Lekshmi C V wrote: Fixed the checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com What is the C V at the end of the name here? Is that your full name? I need a real name, not initials. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: rtl8188eu: core: rtw_wlan_util: replaced __inline with inline
On Thu, Nov 20, 2014 at 04:03:23PM +0100, Abel Moyo wrote: Changed return type of function get_my_bssid from __inline to inline Signed-off-by: Abel Moyo abelmoyo...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c index c495977..700c070 100644 --- a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c @@ -405,7 +405,7 @@ int get_bsstype(unsigned short capability) return 0; } -__inline u8 *get_my_bssid(struct wlan_bssid_ex *pnetwork) +inline u8 *get_my_bssid(struct wlan_bssid_ex *pnetwork) I agree with Dan, just remove inline. Actually, just open code this by removing the function entirely, it's pointless. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Drivers:Staging:rtl8188eu:hal:usb_halinit.c: Added blank lines after declarations
On Sat, Nov 22, 2014 at 11:36:40AM +0530, Anjana Sasindran wrote: This patch fixes the five checkpatch.pl warnings: WARNING:Missing a blank line after declaration Signed-off-by: Anjana Sasindran anjanasasindran...@gmail.com --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++ 1 file changed, 6 insertions(+) Why send 2 identical copies of this? Which to apply? How about neither, please resend it properly... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Drivers:staging:wlan-ng: Fixed checkpatch warning
On Tue, Nov 25, 2014 at 05:16:40PM +0530, Athira Lekshmi C V wrote: The following checkpatch warning was fixed WARNING: line over 80 characters Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com --- drivers/staging/wlan-ng/prism2fw.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Doesn't apply to my tree :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Drivers:staging:comedi:drivers: Fixed checkpatch warning
On Wed, Nov 26, 2014 at 04:56:55PM +0530, Athira Lekshmi C V wrote: Fixed the checkpatch warning: WARNING: please, no space before tabs Signed-off-by: Athira Lekshmi C V andnlnb...@gmail.com Same question about the name here as before. Also, be more specific in your subject as to what you are changing. fixed checkpatch warning is very vague. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
