AW: [PATCH] staging: gasket: Fix sizeof() in gasket_handle_ioctl()

why not mark it as "Deprecated" and remove it with the next version ? Maybe soneone will wakeup ? re, wh Von: Greg Kroah-Hartman Gesendet: Dienstag, 9. März 2021 14:26:55 An: Dan Carpenter Cc: Rob Springer; de...@driverdev.osuosl.org;

AW: [PATCH] staging: rtl8723bs: core: remove redundant zero'ing of counter variable k

Von: Dan Carpenter Gesendet: Montag, 24. Februar 2020 12:27 An: Walter Harms Cc: Colin King; Greg Kroah-Hartman; de...@driverdev.osuosl.org; kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.org Betreff: Re: [PATCH] staging: rtl8723bs: core

AW: [PATCH] staging: rtl8723bs: core: remove redundant zero'ing of counter variable k

Von: kernel-janitors-ow...@vger.kernel.org im Auftrag von Colin King Gesendet: Sonntag, 23. Februar 2020 16:28 An: Greg Kroah-Hartman; de...@driverdev.osuosl.org Cc: kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.org Betreff: [PATCH]

Re: [PATCH] staging: rtl8192u: fix indentation issue

Am 14.11.2019 10:54, schrieb Colin King: > From: Colin Ian King > > There is a block of statements that are indented > too deeply, remove the extraneous tabs. > > Signed-off-by: Colin Ian King > --- > drivers/staging/rtl8192u/r819xU_cmdpkt.c | 25 > 1 file changed,

Re: [PATCH] staging: rtl8192u: fix potential infinite loop because loop counter being too small

Am 01.11.2019 15:51, schrieb Dan Carpenter: > On Fri, Nov 01, 2019 at 02:26:04PM +, Colin King wrote: >> From: Colin Ian King >> >> Currently the for-loop counter i is a u8 however it is being checked >> against a maximum value priv->ieee80211->LinkDetectInfo.SlotNum which is a >> u16.

Re: [PATCH v2] staging: iio: tsl2x7x: clean up limit checks

Am 08.09.2017 12:53, schrieb Dan Carpenter: > The background of this code is that we can either use the default > tables or load our own table with sysfs. The default tables are three > element arrays of struct tsl2x7x_lux. If we load the table with sysfs > then we can have as many as nine

Re: [PATCH] staging: rtl8192u: fix incorrect mask when calculating TxPowerLevelCCK

Am 05.09.2017 18:32, schrieb Colin King: > From: Colin Ian King > > The mask of 0xff and right shift of 8 bits on ret always results in > a value of 0 for TxPowerLevelCCK. I believe this should be a mask of > 0xff00, however I do not have the hardware at hand to test

Re: [PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

nctions because for a linux kernel the scope of DEFINE is a bit large. Small functions tend to be inlined by the compiler, so there is no speed disadvatage. But this is a matter of taste and the maintainer has to maintain whatever happens. just my 2 cents re, wh > > Cheers, > &

Re: [PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

Am 19.07.2017 20:18, schrieb Wolf Entwicklungen: > Bugfixes for rf69_set_modulation, rf69_set_deviation, rf69_set_lna_gain and > rf69_get_lna_gain > The fixes are cross-checked with the datasheet of the rfm69cw > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Marcus Wolf

Re: [PATCH] staging: pi433: fix a precedence bug

Am 19.07.2017 11:51, schrieb Dan Carpenter: > We had intended to do the mask first and then the shift. Shift has > higher precedence so we need to add parenthesis. > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Dan Carpenter > > diff --git

Re: [PATCH] staging: speakup: make function ser_to_dev static

Am 28.06.2017 15:13, schrieb Colin King: > From: Colin Ian King > > The helper function ser_to_dev does not need to be in global scope, so > make it static. > > Cleans up sparse warning: > "warning: symbol 'ser_to_dev' was not declared. Should it be static?" > >

Re: [PATCH] atomisp: ensure that status values > 7 are reported as errors

Am 06.06.2017 18:30, schrieb Colin King: > From: Colin Ian King > > The current code checks if a status value is greater than 7 and > sets the status string as "ERROR" and then over writes the > string based on the bottom 3 bits of the value. Instead, fix this by >

Re: [PATCH 2/2] staging/atomisp: putting NULs in the wrong place

Am 15.05.2017 12:01, schrieb Dan Carpenter: > We're putting the NUL terminators one space beyond where they belong. > This doesn't show up in testing because all but the callers put a NUL in > the correct place themselves. LOL. It causes a static checker warning > about buffer overflows. > >

Re: [PATCH 2/2] staging: atomisp: use local variable to reduce the number of reference

Am 30.03.2017 08:25, schrieb Daeseok Youn: > Define new local variable to reduce the number of reference. > The new local variable is added to save the addess of dfs > and used in atomisp_freq_scaling() function. > > Signed-off-by: Daeseok Youn > --- >

Re: [PATCH 2/4] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

Am 20.03.2017 13:51, schrieb DaeSeok Youn: > 2017-03-20 21:04 GMT+09:00 walter harms <wha...@bfs.de>: >> >> >> Am 20.03.2017 11:59, schrieb Daeseok Youn: >>> If v4l2_subdev_call() gets the global frame interval values, >>> it returned 0 and

Re: [PATCH 2/4] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

Am 20.03.2017 11:59, schrieb Daeseok Youn: > If v4l2_subdev_call() gets the global frame interval values, > it returned 0 and it could be checked whether numerator is zero or not. > > If the numerator is not zero, the fps could be calculated in this function. > If not, it just returns 0. > >

Re: [PATCH] staging: wilc1000: fix incorrect copy of pmkid data

Am 17.03.2017 00:21, schrieb Colin King: > From: Colin Ian King > > The pmkid data is meant be be copied to the previous item in the > pmkidlist, however the code is just copying the data to itself because > the src index into pmkidlist is the same as the dst index

Re: [PATCH] staging: atomisp: clean up return logic, remove redunant code

Am 11.03.2017 20:32, schrieb Colin King: > From: Colin Ian King > > There is no need to check if ret is non-zero, remove this > redundant check and just return the error status from the call > to mt9m114_write_reg_array. > > Detected by CoverityScan, CID#1416577

Re: [patch v2] staging: bcm2835-camera: fix error handling in init

returning directly. > > Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera > driver.") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > --- > v2: Change the style to make Walter Harms happy. Fix some additional > bugs I missed in

Re: [patch] staging: bcm2835-camera: free first element in array

Am 15.02.2017 13:25, schrieb Dan Carpenter: > We should free gdev[0] so the > should be >=. > > Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera > driver.") > Signed-off-by: Dan Carpenter > > diff --git

Re: [patch] staging: wilc1000: NULL dereference on error

Am 16.07.2016 12:07, schrieb Dan Carpenter: > We can't pass NULL pointers to destroy_workqueue(). > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/staging/wilc1000/host_interface.c > b/drivers/staging/wilc1000/host_interface.c > index 0b1760c..78f524f

Re: [patch] staging: comedi: dt2811: fix a precedence bug

Am 21.06.2016 15:56, schrieb Ian Abbott: > On 21/06/16 12:46, Dan Carpenter wrote: >> Bitwise | has higher precedence than ?: so we need to add some >> parenthesis for this to work as intended. >> >> Fixes: 7c9574090d30 ('staging: comedi: dt2811: simplify A/D reference >> configuration') >>

Re: [PATCH] staging: dgnc: replace dgnc_offset_table with bit shift.

Am 25.03.2016 12:33, schrieb Daeseok Youn: > the dgnc_offset_table has a same value with (1 << port). > So I tried to replace dgnc_offset_table array with 1 << port. > And also there are redundant assignments(tmp and current_port) > inside while loop for checking uart port, and remove them. > >

Re: [PATCH] staging: dgnc: fix camelcase of SerialDriver and PrintDriver

You have send this patch before, right ? then it is a good custom to have something like: [Patch V2] in the subject line. In the comment you should write somethink like v2: fix withspace damage v1: fix issue Otherwise none of the reviewer maintainer will see what was changes. Sometimes patch

Re: [patch] staging: wilc1000: fix mgmt_tx()

Am 10.02.2016 10:05, schrieb Dan Carpenter: > There was a missing curly brace so this function returns failure instead > of succeeding. > > Fixes: 06fb9336acdc ('staging: wilc1000: wilc_wfi_cfgoperations.c: replaces > PRINT_ER with netdev_err') > Signed-off-by: Dan Carpenter

Re: [patch] staging: comedi: das16: remove a duplicate condition

Am 29.07.2015 23:36, schrieb Dan Carpenter: We checked that it-options[3] was non-zero on the line before so there is no need to check again. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/staging/comedi/drivers/das16.c

Re: [PATCH 09/12] staging: lustre: obdclass: Use !x to check for kzalloc failure

Am 20.06.2015 18:59, schrieb Julia Lawall: !x is more normal for kzalloc failure in the kernel. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression x; statement S1, S2; @@ x = kzalloc(...); if ( - x == NULL + !x ) S1

Re: [PATCH 8/11] staging: lustre: obdclass: Use kzalloc and kfree

hi Julia, your patch seems fine. I tried to understand the code and it seems that much of it can be simplified by using already available functions. I have added some comments but i am not sure what to make of it. re, wh Am 01.05.2015 17:51, schrieb Julia Lawall: From: Julia Lawall

Re: [PATCH 2/5] staging: lustre: lnet: socklnd: Clean up memset(...)

Am 18.05.2014 19:27, schrieb Joe Perches: On Sun, 2014-05-18 at 18:19 +0100, Masaru Nomura wrote: Remove prohibited space and fix line over 80 characters of memset(...) to meet kernel coding style. [] diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c

Re: [PATCH 1/8] staging: r8712u: Remove useless return variables

Am 20.05.2014 12:33, schrieb Peter Senna Tschudin: This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that

Re: [PATCH 3/8] drivers/staging: Remove useless return variables

Am 20.05.2014 12:33, schrieb Peter Senna Tschudin: This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that

Re: [PATCH 1/8] staging: r8712u: Remove useless return variables

Am 20.05.2014 13:41, schrieb Dan Carpenter: Those concerns are valid but the code was like that in the original so we should merge this patch as is and hope some volunteer will fix things up in a follow on patch. Fixing them in this patch would be a mistake anyway because of the one thing

Re: [patch 2/2 v2] staging: lustre: integer overflow in obd_ioctl_is_invalid()

. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- v2: Updated the error messages as Walter Harms pointed out. diff --git a/drivers/staging/lustre/lustre/include/lustre_lib.h b/drivers/staging/lustre/lustre/include/lustre_lib.h index bdc9812..3c26bbd 100644 --- a/drivers/staging

Re: [patch 2/2] staging: lustre: integer overflow in obd_ioctl_is_invalid()

Am 24.04.2014 23:49, schrieb Dan Carpenter: The obd_ioctl_getdata() function caps data-ioc_len at OBD_MAX_IOCTL_BUFFER and then calls this obd_ioctl_is_invalid() to check that the other values inside data are valid. There are several lengths inside data but when they are added together

Re: [patch 2/2] staging: r8188eu: overflow in rtw_p2p_get_go_device_address()

Am 03.02.2014 23:38, schrieb Dan Carpenter: The go_devadd_str[] array is two characters too small to hold the address so we corrupt memory. I've changed the user space API slightly and I don't have a way to test if this breaks anything. In the original code we truncated away the last

Re: [patch] Staging: vt6655-6: potential NULL dereference in hostap_disable_hostapd()

Am 07.11.2013 08:55, schrieb Dan Carpenter: We fixed this to use free_netdev() instead of kfree() but unfortunately free_netdev() doesn't accept NULL pointers. Smatch complains about this, it's not something I discovered through testing. Fixes: 3030d40b5036 ('staging: vt6655: use

Re: [PATCH v2 1/2] staging: lustre: Fix non-ANSI sparse warnings

Am 28.07.2013 00:38, schrieb Emil Goode: This patch fixes a lot of non-ANSI sparse warnings by adding void to parameterless functions. Signed-off-by: Emil Goode emilgo...@gmail.com --- v2: A bit more specific commit message. .../lustre/lnet/klnds/socklnd/socklnd_lib-linux.c|