Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote: > Michael Zoran writes: > > > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > > > Michael Zoran writes: > > > > > > > > > Since the API is completely documented, I see no reason we > > > > >

RE: [PATCH v2] scsi: storvsc: Add support for FC rport.

> -Original Message- > From: Cathy Avery [mailto:cav...@redhat.com] > Sent: Friday, March 17, 2017 8:18 AM > To: KY Srinivasan ; h...@infradead.org; Haiyang Zhang > ; j...@linux.vnet.ibm.com; > martin.peter...@oracle.com > Cc:

Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks

On Tue, 21 Mar 2017, Alison Schofield wrote: > On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote: > > > > > > On Tue, 21 Mar 2017, Arushi Singhal wrote: > > > > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield > > > wrote: > > > On Tue, Mar 21, 2017 at

Re: [Outreachy kernel] [PATCH v6] staging: Use buf_lock instead of mlock and Refactor code

On Tue, Mar 21, 2017 at 10:18 PM, Alison Schofield wrote: > On Mon, Mar 20, 2017 at 01:36:21AM +0530, simran singhal wrote: > > Hi Simran, > > I going to ask for a v7 without looking at the code ;) > Subject line needs subsystem and driver. > Subject and log message can be

Re: [PATCH v7] staging: adis16060_core: Replace mlock with buf_lock and refactor code

On 20/03/17 12:53, simran singhal wrote: > The IIO subsystem is redefining iio_dev->mlock to be used by > the IIO core only for protecting device operating mode changes. > ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. > > In this driver, mlock was being used to protect hardware

Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks

On Tue, 21 Mar 2017, Arushi Singhal wrote: > > > On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield > wrote: > On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote: > > > > > > On Tue, 21 Mar 2017, Arushi Singhal wrote: > > > >

Re: [PATCH] Staging: ks7010 - fixed style block comments

On Tue, Mar 21, 2017 at 08:56:25AM +0100, Greg KH wrote: > On Sun, Mar 19, 2017 at 01:07:17PM +1300, Derek Robson wrote: > > Fixed style of all block comments across whole driver > > Found by checkpatch > > > > Signed-off-by: Derek Robson > > --- > >

Re: [PATCH] drivers: staging: vt6656: fxed coding style errors

On Tue, Mar 21, 2017 at 10:25:40PM +0530, Prasant Jalan wrote: > This patch replaces spaces with tabs for indentation as per kernel > coding standards. > > Signed-off-by: Prasant Jalan > --- > drivers/staging/vt6656/rf.c | 10 +- > 1 file changed, 5

[PATCH v3 2/2] staging: iio: ade7753: Replace mlock with driver private lock

The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. Replace it with a lock in the devices

[PATCH v3 0/2] Replace mlock with private lock and delete whitespaces

The patch series replaces mlock with a private lock for driver ad9834 and Fix coding style issues related to white spaces. v3: -Using new private "lock" instead of using "buf_lock" as it can cause deadlock. -Sending it as a series of two patches. v2: -Using the existing buf_lock instead

[PATCH v3 1/2] staging: iio: ade7753: Remove trailing whitespaces

This patch removes trailing whitespaces in order to follow the Linux coding style. Signed-off-by: simran singhal --- drivers/staging/iio/meter/ade7753.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/meter/ade7753.c

Re: [PATCH] drivers: staging: vt6656: fixed coding style errors

On Wed, Mar 22, 2017 at 12:10:50AM +0530, Prasant Jalan wrote: > This patch replaces spaces with tabs for indentation as per kernel > coding standards. > > Signed-off-by: Prasant Jalan > --- > drivers/staging/vt6656/rf.c | 11 ++- > 1 file changed, 6

Re: [Outreachy kernel] [PATCH v6] staging: Use buf_lock instead of mlock and Refactor code

On Tue, Mar 21, 2017 at 10:18 PM, Alison Schofield wrote: > On Mon, Mar 20, 2017 at 01:36:21AM +0530, simran singhal wrote: > > Hi Simran, > > I going to ask for a v7 without looking at the code ;) > Subject line needs subsystem and driver. > Subject and log message can be

Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks

On Tue, Mar 21, 2017 at 10:52:46PM +0530, Arushi Singhal wrote: > On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield > wrote: > > > On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote: > > > > > > > > > On Tue, 21 Mar 2017, Arushi Singhal wrote: > > > > > > > On

Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

Michael Zoran writes: > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: >> Michael Zoran writes: >> >> > > > Since the API is completely documented, I see no reason we or >> > > > anybody >> > > > couldn't essentially rewrite the driver while

Re: [PATCH] Staging: ks7010 - fixed style block comments

On Wed, Mar 22, 2017 at 07:29:50AM +1300, Derek Robson wrote: > On Tue, Mar 21, 2017 at 08:56:25AM +0100, Greg KH wrote: > > On Sun, Mar 19, 2017 at 01:07:17PM +1300, Derek Robson wrote: > > > Fixed style of all block comments across whole driver > > > Found by checkpatch > > > > > >

[PATCH v2] drivers: staging: vt6656: fixed coding style errors

This patch replaces spaces with tabs for indentation as per kernel coding standards. Signed-off-by: Prasant Jalan --- drivers/staging/vt6656/rf.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/rf.c

Re: [PATCH v2 0/2] Remove Typedefs.

On 21/03/17 15:06, Arushi Singhal wrote: > Typedefs are removed in sm750fb driver. > > Arushi Singhal (2): > staging: sm750fb: Remove typedef from "typedef struct _mode_parameter_t" > staging: sm750fb: Remove typedef from "typedef enum _spolarity_t" > > drivers/staging/sm750fb/ddk750_mode.c

Re: [Outreachy kernel] [PATCH v6] staging: Use buf_lock instead of mlock and Refactor code

On Tue, Mar 21, 2017 at 10:34:01PM +0530, SIMRAN SINGHAL wrote: > On Tue, Mar 21, 2017 at 10:18 PM, Alison Schofield > wrote: > > On Mon, Mar 20, 2017 at 01:36:21AM +0530, simran singhal wrote: > > > > Hi Simran, > > > > I going to ask for a v7 without looking at the code

Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks

On 21 March 2017 17:27:02 GMT+00:00, Julia Lawall wrote: > > >On Tue, 21 Mar 2017, Arushi Singhal wrote: > >> >> >> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield > >> wrote: >> On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote:

Re: [Outreachy kernel] [PATCH v3 0/2] Replace mlock with private lock and delete whitespaces

On Tue, Mar 21, 2017 at 11:33:54PM +0530, simran singhal wrote: > The patch series replaces mlock with a private lock for driver ad9834 and > Fix coding style issues related to white spaces. Hi Simran, I'm getting lost. Patchset Subject Line needs subsystem and driver. The comment above says

[PATCH] drivers: staging: vt6656: fixed coding style errors

This patch replaces spaces with tabs for indentation as per kernel coding standards. Signed-off-by: Prasant Jalan --- drivers/staging/vt6656/rf.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/rf.c

Re: [PATCH v5] staging: Use buf_lock instead of mlock and Refactor code

On 21/03/17 15:05, SIMRAN SINGHAL wrote: > On Tue, Mar 21, 2017 at 8:01 PM, kbuild test robot <l...@intel.com> wrote: >> Hi simran, >> >> [auto build test WARNING on iio/togreg] >> [also build test WARNING on v4.11-rc3 next-20170321] >> [if your patch is app

[PATCH] drivers: staging: vt6656: fixed coding style errors

This patch replaces spaces with tabs for indentation as per kernel coding standards. Signed-off-by: Prasant Jalan --- drivers/staging/vt6656/rf.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/rf.c

[PATCH] staging:r8188eu: add iv length to frame data offset

If this frame contains IV/ICV fields, ether_type field located a little farther. This bug already fixed here: https://github.com/lwfinger/rtl8188eu/blob/master/core/rtw_recv.c#L569 . Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +- 1 file

Re: [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues,

On Sun, Mar 19, 2017 at 06:44:53PM +0530, Arushi Singhal wrote: > Improve readability by fixing multiple checkpatch.pl > issues in speakup driver. > > Arushi Singhal (2): > staging: speakup: Moved OR operator to previous line. > staging: speakup: spaces preferred around operator You have

[PATCH staging/speakup v3 2/3] remove unnecessary initial allocation of vc

This patch removes the unnecessary allocation of current foreground vc during initialization. This initialization is already handled in the loop that follows it for all available virtual consoles. Signed-off-by: Pranay Kr. Srivastava Reviewed-by: Samuel Thibault

[PATCH staging/speakup v3 1/3] return same error value from spk_set_key_info

This patch makes spk_set_key_info return -EINVAL in case of failure instead of returning 4 different values for the type of error that occurred. Print the offending values instead as debug message. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c | 27

[PATCH staging/speakup v3 3/3] use speakup_allocate as per required context

speakup_allocate used GFP_ATOMIC for allocations even while during initialization due to it's use in notifier call. Pass GFP_ flags as well to speakup_allocate depending on the context it is called in. Signed-off-by: Pranay Kr. Srivastava --- drivers/staging/speakup/main.c |

Re: [PATCH] staging: dgnc: fix printk warnings in dgnc_tty.c

On Sun, Mar 19, 2017 at 03:46:11AM -0700, absh...@gmail.com wrote: > From: Abhishek Bhardwaj > > Use __func__ to print dgnc_tty_send_xchar function name. > > Signed-off-by: Abhishek Bhardwaj > --- > drivers/staging/dgnc/dgnc_tty.c | 4 ++-- > 1 file

[PATCH 7/7] staging: speakup: spaces preferred around operator

Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal

[PATCH 3/7] staging: speakup: Simplify "NULL" comparisons

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/selection.c | 2 +-

Re: [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues,

On Tue, Mar 21, 2017 at 12:03:50PM +0530, Arushi Singhal wrote: > > > On Tue, Mar 21, 2017 at 11:41 AM, Greg KH wrote: > > On Sun, Mar 19, 2017 at 06:44:53PM +0530, Arushi Singhal wrote: > > Improve readability by fixing multiple checkpatch.pl > > issues

Re: [PATCH 00/36] staging: unisys: additional code cleanups

On Fri, Mar 17, 2017 at 11:26:51AM -0400, David Kershner wrote: > This series cleans up several different checkpatch, sparse and other > miscellaneous code issues found throughout the Unisys s-Par driver stack. > It also cleans up the comments surrounding #defines. > > Note: Acceptence of this

[PATCH staging/speakup v3 0/3] cleanup error and initilization

Changelog from v2: Fixed the message subject line. Changelog from v1: 1. fixed kbuild warning for i386 build as reported by kbuild robot 2. split initialization code in two patches. Pranay Kr. Srivastava (3): return same error value from spk_set_key_info remove

Re: [PATCH 24/29] drivers: convert iblock_req.pending from atomic_t to refcount_t

Hi Elena, On Mon, 2017-03-06 at 16:21 +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free >

Re: [PATCH 1/5] bcm2835-camera: Correct port_parameter_get return value

On Fri, Mar 17, 2017 at 02:56:42PM -0700, Michael Zoran wrote: > From: Dave Stevenson > > The API for port_parameter_get() requires that the > filled length is returned, or if insufficient space > that the required space is returned. > > Signed-off-by: Dave

Re: [PATCH 2/5] staging: bcm2835-camera: Fix integer underrun in port_parameter_get

On Fri, Mar 17, 2017 at 02:56:43PM -0700, Michael Zoran wrote: > Fix port_paremeter_get function blindly subtracts 8 from a reply > size without checking that the size is at lest 8 bytes. This can > casue a large buffer to be copied since the size is unsigned. > > Add a WARN_ON, and also add min

Re: [PATCH] Staging: ks7010 - fixed style block comments

On Sun, Mar 19, 2017 at 01:07:17PM +1300, Derek Robson wrote: > Fixed style of all block comments across whole driver > Found by checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/ks7010/ks7010_sdio.c | 3 ++- > drivers/staging/ks7010/ks_hostif.h | 35

[PATCH 4/7] staging: speakup: fixes braces {} should be used on all arms of this statement

This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 35 +++-

[PATCH 2/7] staging: speakup: Remove multiple assignments

This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[PATCH 1/7] staging: speakup: Moved logical to previous line.

Moved logical AND operators to previous line to fix the following checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 12 ++-- 1 file changed, 6 insertions(+),

[PATCH 0/7] staging: speakup: Multiple CheckPatch issues.

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (7): staging: speakup: Moved logical to previous line. staging: speakup: Remove multiple assignments staging: speakup: Simplify "NULL" comparisons staging: speakup: fixes braces {} should be used

[PATCH 6/7] staging: speakup: Moved OR operator to previous line.

Moved logical OR operator to previous line to fix the following checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4

[PATCH 5/7] staging: speakup: Remove multiple assignments

This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/main.c

[PATCH v5 6/6] staging: rtl8192e: Fix blank lines and space after a cast

From: Suniel Mahesh Fixed the following checkpatch.pl checks: Blank lines aren't necessary after an open brace '{' and before a close brace '}', removed No space is necessary after a cast, removed Please don't use multiple blank lines, removed Signed-off-by: Suniel

Re: [PATCH] vc04_services: Fixing coding guideline error

On Wed, Mar 15, 2017 at 12:01:08PM +0530, Pushkar Jambhlekar wrote: > Fixing 'if' block coding style. '{' should follow 'if' for multiline block > > Signed-off-by: Pushkar Jambhlekar > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +-- > 1 file

Re: [PATCH 1/5] bcm2835-camera: Correct port_parameter_get return value

On Tue, 2017-03-21 at 08:27 +0100, Greg KH wrote: > On Fri, Mar 17, 2017 at 02:56:42PM -0700, Michael Zoran wrote: > > From: Dave Stevenson > > > > The API for port_parameter_get() requires that the > > filled length is returned, or if insufficient space > > that

[PATCH 0/4] staging: speakup: Checkpatch issues.

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (4): staging: speakup: Removed Unnecessary parentheses. staging: speakup: Simplify the NULL comparisons staging: speakup: Match alignment with open parenthesis. staging: speakup: Fix alignment

[PATCH 2/4] staging: speakup: Simplify the NULL comparisons

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/fakekey.c | 2 +-

[PATCH 4/4] staging: speakup: Fix alignment with parenthesis.

This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_apollo.c | 2 +- drivers/staging/speakup/speakup_decext.c | 4

[PATCH 3/4] staging: speakup: Match alignment with open parenthesis.

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/selection.c | 2 +- drivers/staging/speakup/serialio.c | 2 +-

[PATCH 1/4] staging: speakup: Removed Unnecessary parentheses.

Unnecessary parentheses are removed to improve readability. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c

[PATCH v5 3/6] staging: rtl8192e: Rectify pointer comparisions with NULL

From: Suniel Mahesh This patch simplifies code by replacing explicit NULL comparison with ! or unmark operator Reported by checkpatch.pl for comparison to NULL could be written '!foo' or 'foo' Signed-off-by: Suniel Mahesh --- Changes for v5:

[PATCH v5 4/6] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct

From: Suniel Mahesh Replaced sizeof(struct foo) into sizeof(*ptr), found by checkpatch.pl Signed-off-by: Suniel Mahesh --- Changes for v5: - Changed email address from suni...@techveda.org to suniel.spar...@gmail.com, reason being few

[PATCH v5 0/6] staging: rtl8192e: Fix coding style, warnings and checks

From: Suniel Mahesh Changed email address from suni...@techveda.org to suniel.spar...@gmail.com, reason being few patches were being dropped and not getting delivered, couldn't resolve that issue. Split earlier patches into multiple commits for easy review as suggested

[PATCH v5 2/6] staging: rtl8192e: Remove unnecessary 'out of memory' message

From: Suniel Mahesh Fixed the following checkpatch.pl warning: Possible unnecessary 'out of memory' message If it is out of memory, function should return with an appropriate error code. Since this function is of type void, a return statement is used. Signed-off-by:

[PATCH v5 1/6] staging: rtl8192e: Fix comments as per kernel coding style

From: Suniel Mahesh Fixed the following checkpatch.pl warnings: Block comments should align the * on each line Block comments use * on subsequent lines Signed-off-by: Suniel Mahesh --- Changes for v5: - Changed email address from

[PATCH v5 5/6] staging: rtl8192e: Fix issues reported by checkpatch.pl

From: Suniel Mahesh Fixed the following checkpatch.pl checks: spaces preferred around that 'operator', spacing provided Logical continuations should be on the previous line, modified accordingly Unnecessary parentheses around variables, removed Please use a blank line

[PATCH 0/2] IIO coding tasks

Patchseries of IIO coding tasks Arushi Singhal (2): staging: ad7759: Replace mlock with driver private lock staging: iio: ade7759: Move header content to implementation file drivers/staging/iio/meter/ade7759.c | 56 +-- drivers/staging/iio/meter/ade7759.h

[PATCH 2/2] staging: iio: ade7759: Move header content to implementation file

The contents of ade7759.h are only used in ade7759.c. Move the header contents to the implemtation file, and delete the header file. Signed-off-by: Arushi Singhal --- drivers/staging/iio/meter/ade7759.c | 52 ++-

[PATCH 1/2] staging: ad7759: Replace mlock with driver private lock

The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. Replace it with a lock in the devices

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/21/17 11:42, Niklas Söderlund wrote: > On 2017-03-20 16:57:54 +0100, Hans Verkuil wrote: >> On 03/20/2017 03:11 PM, Russell King - ARM Linux wrote: >>> On Mon, Mar 20, 2017 at 02:57:03PM +0100, Hans Verkuil wrote: On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote: > It's what I

[PATCH 1/2] staging: sm750fb: Remove typedefs from struct

This patch removes typedefs from structure and renames them as per kernel coding standards. Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/ddk750_mode.c | 8 +--- drivers/staging/sm750fb/ddk750_mode.h | 8 +++-

[PATCH 2/2] staging: sm750fb: Remove typedefs from enum

This patch removes typedefs from enum and renames them as per kernel coding standards. Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/ddk750_mode.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[PATCH 0/2] Remove Typrdefs

Typedefs are removed in sm750fb driver. Arushi Singhal (2): staging: sm750fb: Remove typedefs from struct staging: sm750fb: Remove typedefs from enum drivers/staging/sm750fb/ddk750_mode.c | 8 +--- drivers/staging/sm750fb/ddk750_mode.h | 19 ---

Re: [PATCH 2/5] staging: bcm2835-camera: Fix integer underrun in port_parameter_get

You're fixing a bug you introduced in [PATCH 1/5]. Don't do that. Just fix Dave's patch and add a note in the commit log. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH v5 00/39] i.MX Media Driver

On 2017-03-20 16:57:54 +0100, Hans Verkuil wrote: > On 03/20/2017 03:11 PM, Russell King - ARM Linux wrote: > > On Mon, Mar 20, 2017 at 02:57:03PM +0100, Hans Verkuil wrote: > >> On 03/20/2017 02:29 PM, Russell King - ARM Linux wrote: > >>> It's what I have - remember, not everyone is happy to

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

Hi! > > Making use of the full potential of the hardware requires using a more > > expressive interface. > > That's the core of the problem: most users don't need "full potential > of the hardware". It is actually worse than that: several boards > don't allow "full potential" of the SoC

Re: [PATCH 04/10] staging: ks7010: fix checkpatch BRACES

On Tue, Mar 21, 2017 at 01:37:06PM +1100, Tobin C. Harding wrote: > Checkpatch emits CHECK: Unbalanced braces around else > statement. Statements in question are single statements so we do not > need braces. Checkpatch also warns about multiple line dereference for > this code. > > Fix

[PATCH v2] staging: lustre: replace simple_strtoul with kstrtoint

Replace simple_strtoul with kstrtoint. simple_strtoul is marked for obsoletion as reported by checkpatch.pl Signed-off-by: Marcin Ciupak --- v2: -improving kstrtoint error handling -updating commit message

Re: [PATCH 09/10] staging: ks7010: remove zero comparison

On Tue, Mar 21, 2017 at 01:37:11PM +1100, Tobin C. Harding wrote: > Comparison, equal to zero, is redundant > > 'if (foo == 0)' is equal to 'if (!foo)' > > Typical kernel coding style is to use the shorter form. > > Remove unnecessary zero comparison. Not exactly. If you're talking about

Re: [PATCH 10/10] staging: ks7010: rename return value identifier

On Tue, Mar 21, 2017 at 01:37:12PM +1100, Tobin C. Harding wrote: > static int ks7010_sdio_data_compare(struct ks_wlan_private *priv, u32 > address, > unsigned char *data, unsigned int size) > { > - int rc; > + int ret; > unsigned char *read_buf;

Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-'

On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote: > Resolving 2 checkpatch warnings generated due to: > CHECK: spaces preferred around that '-' > > Signed-off-by: Matthew Giassa > --- > drivers/staging/vt6656/rf.c | 6 +++--- > 1 file changed, 3 insertions(+),

Re: [PATCH] staging: wilc1000: use kernel define byte order macros

Thanks for taking a look, Dan. Sorry if I missed the mark here. Can you tell me a bit more about the bug this would introduce? I see that ieee80211_is_action is defined like this: static inline bool ieee80211_is_action(__le16 fc) ...and that buff[FRAME_TYPE_ID]is a u8 (since FRAME_TYPE_ID =

[PATCH] staging: fbtft: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- drivers/staging/fbtft/fb_agm1264k-fl.c | 4 ++-- drivers/staging/fbtft/fb_ili9163.c | 2 +-

[PATCH v2] staging: radio-bcm2048: fixed bare use of unsigned int

Fixed checkpatch WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Eddie Youseph --- Changes in v2: - Added changelog drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +-- 1 file changed, 22 insertions(+), 22

[PATCH] staging: lustre: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +-

[PATCH] staging: rtl8712: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- drivers/staging/rtl8712/rtl8712_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 3/4] staging: ks7010: add explicit check to 'size' variables

When checking the value of a variable that holds a 0 an explicit check is good style. i.e -if (!size) +if (size == 0) Update checks on 'numerical' variables to use explicit checks. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks7010_sdio.c | 4 ++--

[PATCH 0/4] staging: ks7010: fix style issues

Review from previous (merged) patch set made comment on a couple of style issues. In the same review a bug was reported. We start off fixing the bug then move on to fix the style issues. None of these issues are reported by checkpatch, Sparse, or Smatch. Some instances were introduced by Tobin

[PATCH 2/4] staging: ks7010: add explicit check to memcmp() calls

Calls to functions memcmp() and strcmp() are more clearly readable when the return value is explicitly checked. i.e if (memcmp(foo, bar, size) == 0) Modify driver to use an explicit check on the value returned by memcmp(). Signed-off-by: Tobin C. Harding ---

[PATCH 1/4] staging: ks7010: fix memcmp() bug

Call site to memcmp() treats return value as if it were an error code, it is not. If memcmp() finds inputs to be not the same, an error return code should be set explicitly. Correctly handle return value from call to memcmp(), set error code explicitly. Reported-by: Dan Carpenter

[PATCH 4/4] staging: ks7010: add braces to multi-line indent

The addition of curly braces around single statements that span multiple lines makes the code more readable in general. Add curly braces to multi-line indented statement. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_hostif.c | 18 ++ 1 file

[PATCH 2/2] staging: ks7010: invert if statement conditionals

Checkpatch emits WARNING: Avoid multiple line dereference. Function uses if statement blocks to guard the body of the function. If we invert these conditionals and return, then the code becomes more readable and subsequent code is indented less. The checkpatch fix then follows trivially. Invert

[PATCH] staging: rts5208: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- drivers/staging/rts5208/rtsx_chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 0/2] staging: ks7010: refactor hostif_sme_task()

Function lends itself to being refactored. There are two checkpatch issues generated from this function. Patch 01 removes a redundant nested conditional check. Patch 02 inverts two conditionals, and reduces the subsequent code indentation. Tobin C. Harding (2): staging: ks7010: remove

[PATCH 1/2] staging: ks7010: remove redundant check

Function checks for condition inside a loop that checks the same condition, this is redundant. Fix also removes checkpatch CHECK. Remove redundant check. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_hostif.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH] staging: sm750fb: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

staging: iio: Replace a bit shift by a use of BIT.

This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- drivers/staging/iio/adc/ad7816.c | 2 +- drivers/staging/iio/cdc/ad7150.c | 2 +-

Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

On Tue, 2017-03-21 at 12:09 -0700, Michael Zoran wrote: > On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote: > > Michael Zoran writes: > > > > > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > > > > Michael Zoran writes: > > > > > > > > > >

Re: [PATCH] staging: wilc1000: use kernel define byte order macros

On Tue, Mar 21, 2017 at 01:55:40PM -0600, Perry Hooker wrote: > This commit fixes the following sparse warnings: > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:1473:45: warning: incorrect > type in argument 1 (different base types) > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51:

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

On Tue, 2017-03-21 at 23:30 +0300, Dan Carpenter wrote: > I've read Stefan's review comments and intervened where I didn't > understand them.  The recent ones are very specific and reasonable... > > Just send a v2.  I don't get what the deal is... Partly because Eric and Stefan have publically

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

I've read Stefan's review comments and intervened where I didn't understand them. The recent ones are very specific and reasonable... Just send a v2. I don't get what the deal is... regards, dan carpenter ___ devel mailing list

Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

Michael Zoran writes: > On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote: >> Michael Zoran writes: >> >> > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: >> > > Michael Zoran writes: >> > > >> > > > > > Since the API

Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-'

* Dan Carpenter [2017-03-21 15:55:52 +0300]: On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote: Resolving 2 checkpatch warnings generated due to: CHECK: spaces preferred around that '-' Signed-off-by: Matthew Giassa ---

Re: [PATCH v5] staging: Use buf_lock instead of mlock and Refactor code

Hi simran, [auto build test WARNING on iio/togreg] [also build test WARNING on v4.11-rc3 next-20170321] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/simran-singhal/staging-Use-buf_lock

Re: [PATCH 10/10] staging: ks7010: rename return value identifier

On Tue, Mar 21, 2017 at 03:53:46PM +0300, Dan Carpenter wrote: > On Tue, Mar 21, 2017 at 01:37:12PM +1100, Tobin C. Harding wrote: > > static int ks7010_sdio_data_compare(struct ks_wlan_private *priv, u32 > > address, > > unsigned char *data, unsigned int size) >

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

Hi Philipp, Russell, On 03/20/2017 10:23 AM, Philipp Zabel wrote: Hi Steve, Russell, What do you think of this: --8<-- From 2830aebc404bdfc9d7fc1ec94e5282d0b668e8f6 Mon Sep 17 00:00:00 2001 From: Philipp Zabel Date: Mon, 20 Mar 2017 17:10:21 +0100

Re: [PATCH 04/10] staging: ks7010: fix checkpatch BRACES

On Tue, Mar 21, 2017 at 03:36:34PM +0300, Dan Carpenter wrote: > On Tue, Mar 21, 2017 at 01:37:06PM +1100, Tobin C. Harding wrote: > > Checkpatch emits CHECK: Unbalanced braces around else > > statement. Statements in question are single statements so we do not > > need braces. Checkpatch also

  1   2   >