Re: checkpatch induced patches...

a patch that implements my suggestion in that thread. https://lkml.org/lkml/2014/7/17/427 I wonder if the undocumented --force option is acceptable to Pavel and Kalle. I don't mind if I have to add --force to my scripts as long as checkpatch works similarly as before. -- Kalle Valo

Re: [PATCH] realtek: rtlwifi: rtl8821ae: Fix lockups on boot

y: Larry Finger <larry.fin...@lwfinger.net> > Cc: Stable <sta...@vger.kernel.org> [V4.1+] I think the "realtek:" prefix is superfluous, "rtlwifi:" should be enough. I'll also add a fixes line before I commit this: Fixes: 54328e64047a ("rtlwifi: rtl8821ae: Fi

Re: rtlwifi: rtl8821ae: Fix lockups on boot

kups on boot") > Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> > Cc: Stable <sta...@vger.kernel.org> [V4.1+] Thanks, applied to wireless-drivers.git. Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: rtlwifi: rtl8821ae: Fix system lockups on boot

ed > to disable the interrupt clear > > Fixes: 1277fa2ab2f9 ("rtlwifi: Remove the clear interrupt routine from all > drivers") > Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> > Cc: Stable <sta...@vger.kernel.org> [V4.1+] Thanks, applied to wireless-drivers.

Re: [RFC] Documentation: Clarify wording regarding submission of wireless patches to stable

updated to clarify this case. > > Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> > --- > > Kalle, > > Is this change clear, and strong enough? Looks good to me, thanks! -- Kalle Valo ___ devel m

Re: [1/8] rtlwifi: rtl8723be: Fix module parameter initialization

ter initialization b24f19f16b9e rtlwifi: rtl8192ce: Fix handling of module parameters b68d0ae7e586 rtlwifi: rtl8192cu: Add missing parameter setup Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: rtlwifi: Fix scheduling while atomic error from commit 49f86ec21c01

Larry Finger wrote: > Commit 49f86ec21c01 ("rtlwifi: Change long delays to sleeps") was correct > for most cases; however, driver rtl8192ce calls the affected routines while > in atomic context. The kernel bug output is as follows: > > BUG: scheduling while atomic:

Re: rtlwifi: fix broken VHT support

VHT_MCS is not set in the rate flags. > > Reported-by: Linus Torvalds <torva...@linux-foundation.org> > Tested-by: Linus Torvalds <torva...@linux-foundation.org> > Signed-off-by: Johannes Berg <johan...@sipsolutions.net> > Sig

Re: Move wlan-ng out of staging?

asonable shape, fixing checkpatch warnings will not be enough. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] rtlwifi: Fix warning from ieee80211_get_tx_rates() when using 5G

port When using a 5G-capable device with VHT (802.11ac) rates enabled was not working (packets were not delivered) and the following mac80211 warning was printed: ... -- -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [1/4] rtlwifi: Prepare for reworking 5G channels

less-drivers-next.git: 9696a159c398 rtlwifi: Prepare for reworking 5G channels bb6fa826ba30 rtlwifi: rtl8192de: Convert driver to use common 5G channels 2784b00aa316 rtlwifi: rtl8192ee: Convert driver to use new 5G channel tables 0a44b22009d5 rtlwifi: rtl8821ae: Convert driver to use common 5G chan

Re: [PATCH] rtlwifi: rtl8821ae: Fix 5G failure when EEPROM is incorrectly encoded

c: littlesmart...@gmail.com > Cc: g...@codehaus.org > Cc: Stable <sta...@vger.kernel.org> [v4.2+] I'll queue this to 4.5. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V2 00/26] use unified firmware and add ops in cfg

> > * fix bug on p2p, WEP security and chaning virtual interface > > Changes in V2: details in each patch files. > - 0004-staging-wilc1000-add-sdio-resume-suspend.patch It's good practise to also add "staging: wilc1000: " prefix to the cover letter. -- Kalle Valo _

Re: rtlwifi: rtl8821ae: Fix 5G failure when EEPROM is incorrectly encoded

s.org > Cc: Stable <sta...@vger.kernel.org> [v4.2+] Thanks, applied to wireless-drivers.git. Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [1/2] rtlwifi: rtl8723be: Add antenna select module parameter

anges needed for the driver. > > Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> > Cc: Stable <sta...@vger.kernel.org> [V4.0+] Thanks, 2 patches applied to wireless-drivers-next.git: c18d8f509571 rtlwifi: rtl8723be: Add antenna select module parameter baa170229095 rtlwifi: bt

Re: [1/9] rtlwifi: Fix Smatch warnings

tch warnings 1e812458206e rtlwifi: rtl8821ae: Fix Smatch warnings Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: rtlwifi: rtl8821ae: Silence useless log output

Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, applied to wireless-drivers-next.git. Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: rtlwifi: Change long delays to sleeps

t of their > input values. > > Suggested-by: Byeoungwook Kim <quddnr...@gmail.com> > Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, applied to wireless-drivers-next.git. Kalle Valo ___ devel mail

Re: [PATCH] rtlwifi: Fix size of wireless mode variable

> > Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> I can't find commit acc6907b87a9 from any of my trees. And oddly enough I can't either any commits with title "rtlwifi: Fix warning from ieee80211_get_tx_rates() when using 5G". I can fix it before co

Re: rtlwifi: Fix size of wireless mode variable

s patch also reorders struct rtl_sta_info to save a little space. > > Fixes: d76d65fd2695 ("rtlwifi: fix broken VHT support") > Reported-by: Dan Williams <d...@redhat.com> > Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, applied to wireless-

Re: [PATCH] rtlwifi: Fix size of wireless mode variable

If you would rather not fix this on commit, I can submit a new version. No need, I can edit the commit log before I commit. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] rtlwifi: Fix scheduling while atomic error from commit 49f86ec21c01

t;ja...@nurealm.net> > Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> > Cc: James Feeney <ja...@nurealm.net> > Cc: Stable <sta...@vger.kernel.org> [4.6+] I'm planning to queue this to 4.7. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/7] fix typo

Julia Lawall <julia.law...@lip6.fr> writes: > On Tue, 17 May 2016, Kalle Valo wrote: > >> Julia Lawall <julia.law...@lip6.fr> writes: >> >> > firmare -> firmware >> > >> > --- >> > >> > drivers/media/dvb-frontends/mn88

Re: [PATCH 0/7] fix typo

know in advance what tree you are planning to submit these for. For example, should I take ath6kl and mwifiex patches or someone else? -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [RFC] rfkill: Add new ACPI device for Realtek serial BT

gpio.c | 1 + > 1 file changed, 1 insertion(+) BTW Johannes maintains rfkill, not me. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [1/6] rtlwifi: Remove unused parameter from rtl_ps_set_rf_state()

Larry Finger wrote: > Commit 4b9d8d67b44a ("rtlwifi: rtl8192cu: Remove unused parameter") reworked > this routine. Those changes were later reverted by commit d3feae41a347 > ("rtlwifi: Update power-save routines for 062814 driver"). > > There were two changes in commit

Re: [v3,01/10] rtlwifi: Create common routine to get hardware info

Larry Finger wrote: > All of the rtlwifi family of drivers have a similar routine that acquires > the hardware info from efuse and initializes a number of variables in the > driver's private area. A common routine is created for all drivers to use. > > Reported-by:

Re: [PATCH] rtlwifi: Fix missing country code for Great Britain

n anything about that so I want to double check that this is really intentionally. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 1/6] rtl8723au: remove declaration of unimplemented functions

er...@vger.kernel.org > > --- > > Changes v1 -> v2: > - improve the commit message. > --- > drivers/staging/rtl8723au/include/recv_osdep.h | 3 --- > 1 file changed, 3 deletions(-) Please prefix staging drivers with "staging:". -- Kalle Valo

Re: [V2] rtlwifi: Fix missing country code for Great Britain

Larry Finger wrote: > Some RTL8821AE devices sold in Great Britain have the country code of > 0x25 encoded in their EEPROM. This value is not tested in the routine > that establishes the regulatory info for the chip. The fix is to set > this code to have the same

Re: [PATCH] rtl8xxxu: Stop log spam from each successful interrupt

(0) > > Yuck yuck yuck, no thanks! > > Any attempt of adding that kinda grossness to the driver will get a > NACK. Huh, how is that ugly? To me it's the opposite, original code is ugly and Joes' proposal makes sense. Lots of wireless drivers have something similar. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [1/2] rtlwifi: Add HAL_DEF_WOWLAN case to *_get_hw() routines

Larry Finger wrote: > Only rtl8821ae implements WOWLAN; however, the other drivers may receive > a call requesting information about this mode. The other drivers need to > ignore the request rather than logging that the default branch of the > switch statement has been

Re: ssb: Fix error routine when fallback SPROM fails

Larry Finger wrote: > When there is a CRC error in the SPROM read from the device, the code > attempts to handle a fallback SPROM. When this also fails, the driver > returns zero rather than an error code. > > Signed-off-by: Larry Finger >

Re: [1/8] rtlwifi: rtl8192de: Remove address of Free Software Foundation

Larry Finger wrote: > Since this driver was added to the kernel, the checkpatch script was > modified to request that the address of the FSF not be included. > > Signed-off-by: Larry Finger 8 patches applied to wireless-drivers-next.git,

Re: rtlwifi: rtl8723be: Fix bug in ant_sel code from commit c18d8f509571

Larry Finger wrote: > From: Ping-Ke Shih > > In commit c18d8f509571 ("rtlwifi: rtl8723be: Add antenna select module > parameter"), wifi was fixed for those laptops that have only a single > antenna but have an incorrectly coded EEPROM. This error

Re: Revert "rtlwifi: rtl818x: constify local structures"

Larry Finger wrote: > This reverts commit d86e64768859fca82c78e52877ceeba04e25d27a. > > For drivers rtl8188ee, rtl8192ce, rtl8192ee, rtl8723ae, and rtl8821ae, > the Coccinelle script missed the fact that the code changes the firmware > name. When that happens, the

Re: [PATCH] rtlwifi: Fix regression caused by commit d86e64768859

d. Many thanks for making this super clear for me, makes my life a lot easier. I'm hoping that this will make it to 4.9-rc2. CCing Thorsten to get this regression to his radar. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [V2] rtlwifi: Fix regression caused by commit d86e64768859

Larry Finger wrote: > In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), > the configuration struct for most of the drivers was changed to be > constant. The problem is that five of the modified drivers need to be > able to update the firmware name

Re: rtlwifi: Fix regression caused by commit d86e64768859

Larry Finger wrote: > In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), > the configuration struct for most of the drivers was changed to be > constant. The problem is that five of the modified drivers need to be > able to update the firmware name

Re: [PATCH] rtlwifi: Fix regression caused by commit d86e64768859

rivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c: In function 'rtl8723e_init_sw_vars': drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c:187:6: warning: 'fw_name' may be used uninitialized in this function [-Wuninitialized] (Sending manually for the second time as I don't see

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

Dan Carpenter <dan.carpen...@oracle.com> writes: > On Wed, Dec 07, 2016 at 02:16:06PM +0200, Kalle Valo wrote: >> We have disccused this before, but for wireless it's not really that >> simple. AFAIK with dyndbg you can only control the messages per line >> (painful

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

Dan Carpenter <dan.carpen...@oracle.com> writes: > On Thu, Dec 08, 2016 at 02:50:49PM +0300, Dan Carpenter wrote: >> On Thu, Dec 08, 2016 at 01:43:42PM +0200, Kalle Valo wrote: >> > But it would make me very happy if someone would add a similar grouping >> >

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

ff. Sure, I agree with that. My point was just that sometimes it's ok to have own logging wrappers and there's no hard rule for this. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex

amically as the kernel runs. No need to invent fancy > custom macros for things we have already for many many years. We have disccused this before, but for wireless it's not really that simple. AFAIK with dyndbg you can only control the messages per line (painful t

Re: [PATCH 8/8] Makefile: drop -D__CHECK_ENDIAN__ from cflags

c80211/Makefile | 2 +- > net/mac802154/Makefile| 2 -- > net/wireless/Makefile | 2 -- > 38 files changed, 5 insertions(+), 68 deletions(-) For drivers/net/wireless: Acked-by:

Re: [next] rtlwifi: rtl8192de: fix missing curly braces

line 326 > > Fixes: c93ac39da006457f ("rtlwifi: Remove some redundant code") > Signed-off-by: Vincent Stehlé <vincent.ste...@laposte.net> > Cc: Larry Finger <larry.fin...@lwfinger.net> > Cc: Kalle Valo <kv...@codeaurora.org> > Cc: Joe Perches <j...@

Re: rtlwifi: Fix enter/exit power_save

Larry Finger wrote: > In commit a5ffbe0a1993 ("rtlwifi: Fix scheduling while atomic bug") and > commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and rtl_lps_enter() > to use work queue"), an error was introduced in the power-save routines > due to the fact that

Re: [01/14] rtlwifi: Correct power save capability while init mac80211

Larry Finger wrote: > Set IEEE80211_HW_SUPPORTS_PS when driver is fwlps > Because mac80211 control SW-LPS only, we add constraints to avoid errors. > > Signed-off-by: Vincent Fann > Signed-off-by: shaofu > Signed-off-by:

Re: rtlwifi: rtl_usb: Fix missing entry in USB driver's private data

Larry Finger wrote: > These drivers need to be able to reference "struct ieee80211_hw" from > the driver's private data, and vice versa. The USB driver failed to > store the address of ieee80211_hw in the private data. Although this > bug has been present for a long

Re: [PATCH 14/14 V2] rtlwifi: Remove some redundant code

ut this is good enough for me, if you really want to remove it submit a followup patch. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [01/14,V2] rtlwifi: Replace local debug macro RT_ASSERT

Larry Finger wrote: > This macro can be replaced with WARN_ONCE. In addition to using a > standard debugging macro for these critical errors, we also get > a stack dump. > > In rtl8821ae/hw.c, a senseless comment was removed, and an incorrect > indentation was fixed. >

Re: [1/7] rtlwifi: btcoexist: Update routines for RTL8192EE

Larry Finger wrote: > From: Ping-Ke Shih > > The btcoexist routines for the RTL8192EE have been extensively rewritten. > > Signed-off-by: Ping-Ke Shih > Signed-off-by: Larry Finger Dropped per

Re: rtlwifi: Fix kernel oops introduced with commit e49656147359

Larry Finger wrote: > With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of > kfree_skb"), the method used to free an skb was changed because the > kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb() > guards against a NULL value for

Re: [PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359

uawei.com> > --- > Kalle, > > This change should be sent to mainline during the 4.10 merge period, > or as soon as possible. Ok, I'll queue this to 4.10. Most likely I'll send a pull request to Dave later this week or so. -- Kalle Valo

Re: [PATCH RFC] remove custom Michael MIC implementation

g points to get familiar with the stack. And I guess you already saw the documentation: https://wireless.wiki.kernel.org/en/developers/documentation/mac80211 -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH RFC] remove custom Michael MIC implementation

driver and get out of staging :) So next step > is I guess study the ath6kl driver, learn how CFG80211 is done and > implement that interface in ks7010? Oh, and test that it works. Please keep linux-wireless list in loop so that people on that list can help. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/2] wireless: move prism54 to staging

t less conflicts that way, but I can take this as well if needed. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/2] wireless: move prism54 out to staging

s with the PCI IDs of p54pci and the *very* unlikely situation > of folks really need this driver anymore. > > Before trying to due away with prism54 once more stuff it into staging, > which is our hospice for dying drivers. > > Signed-off-by: Luis R. Rodriguez <mcg...@kernel

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

bout 10-15 > working days spread over my free time/week-end, that isn't for in one > month :) I could use help for sure on this driver, that's why I posted > it in staging. > > I've done the cleanup on a per-file basis so maybe you looked at one of > the cleaned up files? > > Jus

Re: [PATCH] rtl8723bs: fix build when DEBUG_RTL871X is defined

use prefix "staging:" for staging patches. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Two rtlwifi drivers?

rstand it > any way" is nor really helpful :) > Please don't repeat bad experience of Broadcom. I agree with Oleksij here, but I want to still point out that there are cases when using magic numbers are ok, for example look at ar5008_initvals.h from ath9k. So it depends on case by case. --

Re: Two rtlwifi drivers?

Intel's iwlwifi has support for hardware which have not reached customers yet. > On the way, I'll attend netdev workshop in Korea, so we can meet there > if you attend too. I'm also attending Netdev 2.2, looking forward to meeting you there. -- Kalle Valo

Re: Two rtlwifi drivers?

more reasonable, like 10-12 patches per set. I think Dave also has a similar rule for net patches. I wrote a FAQ entry about this: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#too_many_patches -- Kalle Valo _

Re: Two rtlwifi drivers?

(Sorry for taking so long with the reply, I wanted first to check what the rtlwifi in staging contains.) Larry Finger <larry.fin...@lwfinger.net> writes: > On 08/24/2017 07:14 AM, Kalle Valo wrote: >> Dan Carpenter <dan.carpen...@oracle.com> writes: >> >>>

Re: Two rtlwifi drivers?

months or something) for the drivers/staging/rtlwifi and after that you refuse to take any patches for it. Hopefully this makes it clear for everyone that this fork is just temporary. I think Larry is trying to do this, which is great. 2) We move the whole rtlwifi driver to staging. A very bad option but still better than forking the drivers. -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Two rtlwifi drivers?

Larry Finger <larry.fin...@lwfinger.net> writes: > On 10/11/2017 08:13 AM, Greg Kroah-Hartman wrote: > >> On Wed, Oct 11, 2017 at 12:06:00PM +0300, Kalle Valo wrote: >> I think it's horrid too. But, if no one is able to do the real work >> here, we hurt users who j

Two rtlwifi drivers?

is is not directed to Dan, he is just fixing bugs found by smatch, but more like a general question.) -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Two rtlwifi drivers?

ew driver some people split the driver to one file per patch for easier review but the final commit needs to be one big patch with all files included. If you are adding big files to rtlwifi I think you could try to follow the same model. -- Kalle Valo

Re: [PATCH v3 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

Greg KH writes: > On Mon, Jun 18, 2018 at 10:29:43AM +0300, Kalle Valo wrote: >> Greg KH writes: >> >> > On Sun, Jun 17, 2018 at 01:07:36PM +0300, Omer Efrat wrote: >> >> The BIT macro uses unsigned long which some architectures handle as 32 bit >>

Re: [PATCH v3 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

ibutes by mistake. >> >> This commit cleans up all usages of BIT macro with the above field >> in cfg80211 by changing it to BIT_ULL instead. >> >> Signed-off-by: Omer Efrat > > Acked-by: Greg Kroah-Hartman Via which tree is this supposed to go

Re: feedback on mainlining wilc1000 staging driver

read from DT > -replace SIOCDEVPRIVATE commands with generic API functions > -use wext-core handling instead of private SIOCSIWPRIV implementation >From wireless point of view: if I see wext mentioned anywhere in the driver I stop right t

Re: feedback on mainlining wilc1000 staging driver

Kalle Valo writes: > Ajay Singh writes: > >> Hi Greg, >> >> We all are working on submitting and reviewing patches for wilc1000 in >> staging driver for quite some time. >> >> We would like to have feedback on the next steps to bring wilc1000

Re: feedback on mainlining wilc1000 staging driver

Arend van Spriel writes: > On 8/17/2018 9:49 AM, Kalle Valo wrote: >> Ajay Singh writes: >> >>> On Thu, 16 Aug 2018 13:53:50 +0300 >>> Kalle Valo wrote: >>> >>>> Kalle Valo writes: >>>> >>>>> From wireless

Re: feedback on mainlining wilc1000 staging driver

Ajay Singh writes: > On Thu, 16 Aug 2018 13:53:50 +0300 > Kalle Valo wrote: > >> Kalle Valo writes: >> >> > Ajay Singh writes: >> > >> >> Hi Greg, >> >> >> >> We all are working on submitting and reviewing patche

Re: feedback on mainlining wilc1000 staging driver

might cause conflicts etc. > And the fixes will be submitted to staging tree in parallel. right? I don't think the fixes matter in the initial review. So yeah, Greg can apply fixes as he sees fit for now. At some point we need to do a cut off period and freeze the driver for the last review ro

Re: [PATCH v6 13/18] wireless/lib80211: Convert from ahash to shash

e in net-next now. Yup, I see it in net-next: d17504b16ea2 wireless/lib80211: Convert from ahash to shash -- Kalle Valo ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 15/20] net: Remove depends on HAS_DMA in case of platform dependency

> drivers/net/ethernet/mellanox/mlxsw/Kconfig | 2 +- > drivers/net/ethernet/renesas/Kconfig| 2 -- > drivers/net/wireless/broadcom/brcm80211/Kconfig | 1 - > drivers/net/wireless/quantenna/qtnfmac/Kconfig | 2 +- > 12 files changed, 12 insertions(+), 19 deletions(-) F

Re: feedback on mainlining wilc1000 staging driver

me time. >> > > Thanks for the update. > Btw I could see our driver was added to the pending branch. Just > curious, could you please share details about how the pending branch is > used ? I use pending branch mainly for testing bigger patches with kbuild bot,

Re: [PATCH] staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

t; --- >> drivers/staging/rtlwifi/wifi.h | 4 > > Presumably the equivalent uses in > drivers/net/wireless/realtek/rtlwifi/wifi.h > should be removed as well. But if it's needed, just do it in separate patch as the patches go via different trees. -- Kalle Valo __

Re: feedback on mainlining wilc1000 staging driver

Ajay Singh writes: > Hi Kalle, > > On Thu, 23 Aug 2018 16:37:45 +0530 > Kalle Valo wrote: > >> Ajay Singh writes: >> >> >> >>> We need help to review and identify if there are any pending >> >> >>> items for wilc1000 drive

Re: [PATCH 01/15] staging: wilc1000: avoid the use of 'wilc_wfi_mon' static variable

t; @@ -18,8 +18,6 @@ struct wilc_wfi_radiotap_cb_hdr { > u16 tx_flags; > } __packed; > > -static struct net_device *wilc_wfi_mon; /* global monitor netdev */ > - > static u8 srcadd[6]; > static u8 bssid[6]; I hope you are working on moving srcadd an

Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy

George Spelvin writes: > On Fri, Apr 03, 2020 at 12:10:29PM +0300, Dan Carpenter wrote: >> On Thu, Apr 02, 2020 at 03:30:34PM +, George Spelvin wrote: >> > On Thu, Apr 02, 2020 at 11:27:45AM +0300, Dan Carpenter wrote: >> > > I don't know how this patch made it through two versions without

Re: [PATCH v6 00/17] wilc1000: move out of staging

writes: > From: Ajay Singh > > This patch series is to review and move wilc1000 driver out of staging. > Most of the review comments received in [1] & [2] are addressed in the > latest code. Please review and provide your inputs. > > [1]. >

Re: [PATCH] staging: wilc1000: remove label from examples in DT binding documentation

writes: > From: Ajay Singh > > Remove labels and not relevant property from DT binding documentation > examples as suggested in [1]. > > 1. https://patchwork.ozlabs.org/patch/1252837 Just a nitpick but patchwork links are not that reliable in the long run. Instead using a lore link is better

Re: [PATCH 2/8] staging: wfx: check memory allocation

Jerome Pouiller writes: > From: Jérôme Pouiller > > Smatch complains: > >main.c:228 wfx_send_pdata_pds() warn: potential NULL parameter dereference > 'tmp_buf' >227 tmp_buf = kmemdup(pds->data, pds->size, GFP_KERNEL); >228 ret = wfx_send_pds(wdev, tmp_buf,

Re: [PATCH 3/8] staging: wfx: standardize the error when vif does not exist

Jerome Pouiller writes: > From: Jérôme Pouiller > > Smatch complains: > >drivers/staging/wfx/hif_rx.c:177 hif_scan_complete_indication() warn: > potential NULL parameter dereference 'wvif' >drivers/staging/wfx/data_tx.c:576 wfx_flush() warn: potential NULL > parameter dereference

Re: [PATCH 0/7] wfx: move out from the staging area

Greg Kroah-Hartman writes: > On Wed, Oct 07, 2020 at 12:19:36PM +0200, Jerome Pouiller wrote: >> From: Jérôme Pouiller >> >> I think the wfx driver is now mature enough to be accepted in the >> drivers/net/wireless directory. >> >> There is still one item on the TODO list. It is an idea to

Re: [PATCH 0/7] wfx: move out from the staging area

Kalle Valo writes: > Greg Kroah-Hartman writes: > >> On Wed, Oct 07, 2020 at 12:19:36PM +0200, Jerome Pouiller wrote: >>> From: Jérôme Pouiller >>> >>> I think the wfx driver is now mature enough to be accepted in the >>> drivers/net/wire

Re: [PATCH 0/7] wfx: move out from the staging area

Jérôme Pouiller writes: > On Thursday 8 October 2020 09:30:06 CEST Kalle Valo wrote: > [...] >> Yes, the driver needs to be reviewed in linux-wireless list. I recommend >> submitting the whole driver in a patchset with one file per patch, which >> seems to be the easi

Re: [PATCH 00/10] staging: wfx: introduce nl80211 vendor extensions

Jerome Pouiller writes: > This series introduces some nl80211 vendor extensions to the wfx driver. > > This series may lead to some discussions: > > 1. Patch 7 allows to change the dynamic PS timeout. I have found > an API in wext (cfg80211_wext_siwpower()) that do more or less the >

Re: [PATCH 00/10] staging: wfx: introduce nl80211 vendor extensions

Jérôme Pouiller writes: > On Wednesday 27 May 2020 14:34:37 CEST Kalle Valo wrote: >> Jerome Pouiller writes: >> >> > This series introduces some nl80211 vendor extensions to the wfx driver. >> > >> > This series may lead to some discussions: >>

Re: [PATCH v7 00/17] wilc1000: move out of staging

Greg KH writes: > On Fri, Jun 26, 2020 at 08:34:48AM +0300, Kalle Valo wrote: > >> And Ajay already submitted that the simple rename patch proposed, thanks >> Ajay! >> >> https://patchwork.kernel.org/patch/11625025/ >> >> And indeed the patch is

Re: [PATCH] staging/wilc1000: let wilc_mac_xmit() to NETDEV_TX_OK

writes: > Luc, > > Thanks for your patch... > > On 28/06/2020 at 20:32, Luc Van Oostenryck wrote: >> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', >> which is a typedef for an enum type defining 'NETDEV_TX_OK' but this >> driver returns '0' instead of 'NETDEV_TX_OK'. >>

Re: [PATCH] wilc1000: move wilc driver out of staging

writes: > From: Ajay Singh > > WILC1000 is an IEEE 802.11 b/g/n IoT link controller module. The > WILC1000 connects to Microchip AVR/SMART MCUs, SMART MPUs, and other > processors with minimal resource requirements with a simple > SPI/SDIO-to-Wi-Fi interface. > > WILC1000 driver has been part

Re: [PATCH] wilc1000: move wilc driver out of staging

writes: > On 02/07/20 12:30 pm, Kalle Valo wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you >> know the content is safe >> >> writes: >> >>> From: Ajay Singh >>> >>> WILC1000 is an IEEE 802.11 b/g/n IoT li

Re: [PATCH v7 00/17] wilc1000: move out of staging

Greg KH writes: > On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote: >> writes: >> >> > From: Ajay Singh >> > >> > This patch series is to review and move wilc1000 driver out of staging. >> > Most of the review comments received

Re: [PATCH v7 00/17] wilc1000: move out of staging

writes: > From: Ajay Singh > > This patch series is to review and move wilc1000 driver out of staging. > Most of the review comments received in [1] & [2] are addressed in the > latest code. > Please review and provide your inputs. > > [1]. >

Re: [PATCH v7 00/17] wilc1000: move out of staging

Greg KH writes: > On Wed, Jun 24, 2020 at 12:49:24PM +0300, Kalle Valo wrote: >> Greg KH writes: >> >> > On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote: >> >> writes: >> >> >> >> > From: Ajay Singh >> >

Re: [PATCH] wilc1000: move wilc driver out of staging

writes: > From: Ajay Singh > > WILC1000 is an IEEE 802.11 b/g/n IoT link controller module. The > WILC1000 connects to Microchip AVR/SMART MCUs, SMART MPUs, and other > processors with minimal resource requirements with a simple > SPI/SDIO-to-Wi-Fi interface. > > WILC1000 driver has been part

Re: [PATCH v3 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip

Jerome Pouiller writes: > From: Jérôme Pouiller > > Add Silabs SDIO ID to sdio_ids.h. > > Note that the values used by Silabs are uncommon. A driver cannot fully > rely on the SDIO PnP. It should also check if the device is declared in > the DT. > > Signed-off-by: Jérôme Pouiller > --- >

  1   2   >