Re: [Duplicity-team] [Merge] lp:~mterry/duplicity/early-catch-498933 into lp:duplicity

2011-08-30 Thread Michael Terry
I'll mark this branch 'rejected' as it has been superseded by the merged check-volumes branch. -- https://code.launchpad.net/~mterry/duplicity/early-catch-498933/+merge/72607 Your team duplicity-team is requested to review the proposed merge of lp:~mterry/duplicity/early-catch-498933 into

Re: [Duplicity-team] [Merge] lp:~mterry/duplicity/early-catch-498933 into lp:duplicity

2011-08-24 Thread edso
in this case it means we add a new interface like get_info() that backends are free to implement. if they do, some extra duplicity functionality kicks in. if not, then it does not ;). But no reason to invent some complicated thing that all backends have to support. Why not do

Re: [Duplicity-team] [Merge] lp:~mterry/duplicity/early-catch-498933 into lp:duplicity

2011-08-24 Thread edso
On 24.08.2011 16:12, Michael Terry wrote: I feel like the importance of the details of the API design, while not a trivial matter, has still been dwarfed by the amount of virtual ink we've spilled. :) that's the nice thing of going paperless ;) you might have noticed, i try to model future

Re: [Duplicity-team] [Merge] lp:~mterry/duplicity/early-catch-498933 into lp:duplicity

2011-08-24 Thread edso
On 24.08.2011 16:31, Kenneth Loafman wrote: I think you two have indeed hashed the design down to it's essentials, so here are some thoughts on the issue. The idea of get_info(filename_list) is a good idea, but it is not necessary to specify what info to return. It is necessary for this

Re: [Duplicity-team] [Merge] lp:~mterry/duplicity/early-catch-498933 into lp:duplicity

2011-08-23 Thread edso
On 23.08.2011 20:25, Kenneth Loafman wrote: The size info is the problem. Each backend returns a list of filenames, but getting size info is problematic. That's going to be a major piece of work to get that info. I am no pythonist per se, but is there a possibility to add a list_extended to

Re: [Duplicity-team] [Merge] lp:~mterry/duplicity/early-catch-498933 into lp:duplicity

2011-08-23 Thread Michael Terry
true but backends usually list all files anyway. dont they? .. ede They do if you ask them to, and that's the only listing capability the current Duplicity backend.py API has. But if we're talking about adding to that API, I suspect most backends have a query info about a particular file call

Re: [Duplicity-team] [Merge] lp:~mterry/duplicity/early-catch-498933 into lp:duplicity

2011-08-23 Thread edso
On 23.08.2011 21:02, Michael Terry wrote: true but backends usually list all files anyway. dont they? .. ede They do if you ask them to, and that's the only listing capability the current Duplicity backend.py API has. But if we're talking about adding to that API, I suspect most backends

Re: [Duplicity-team] [Merge] lp:~mterry/duplicity/early-catch-498933 into lp:duplicity

2011-08-23 Thread Michael Terry
ede, making resume optional is a good idea (maybe a --no-resume option). But that's a separate bug/branch. As for get_info() vs get_size(), I'm nervous about getting *all* infor we can. That might be a lot, and some info is more or less expensive on different backends. See, for example, all

Re: [Duplicity-team] [Merge] lp:~mterry/duplicity/early-catch-498933 into lp:duplicity

2011-08-23 Thread Michael Terry
Heh, obviously that GFileInfo link should have been http://developer.gnome.org/gio/stable/GFileInfo.html -- https://code.launchpad.net/~mterry/duplicity/early-catch-498933/+merge/72607 Your team duplicity-team is requested to review the proposed merge of lp:~mterry/duplicity/early-catch-498933

Re: [Duplicity-team] [Merge] lp:~mterry/duplicity/early-catch-498933 into lp:duplicity

2011-08-23 Thread edso
On 23.08.2011 22:49, Michael Terry wrote: this is a mapped list, right? I'm not familiar with that term, but were you asking what I meant by dictionary? I meant a python dictionary, like: a = {'key': 'value'} a['key'] == 'value' i am no pythonist, so yes a key-value list is called a