Re: [E1000-devel] [net] Intel Wired LAN Driver Updates

2015-03-31 Thread David Miller
From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Tue, 31 Mar 2015 21:27:53 -0700 On Tue, 2015-03-31 at 19:19 -0700, Jeff Kirsher wrote: On Tue, 2015-03-31 at 13:22 -0400, David Miller wrote: From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Fri, 27 Mar 2015 16:04:10 -0700

Re: [E1000-devel] [net] Intel Wired LAN Driver Updates

2015-03-31 Thread David Miller
From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Fri, 27 Mar 2015 16:04:10 -0700 The following are changes since commit dde93dfea53c72b07907d9e44a6e4b1545f6bdc4: cxgb4: Fix frame size warning for 32 bit arch and are available in the git repository at:

Re: [E1000-devel] [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0

2015-03-31 Thread David Miller
From: Joe Perches j...@perches.com Date: Sun, 29 Mar 2015 18:25:12 -0700 Use bool constants as the return values instead of 1 and 0. Signed-off-by: Joe Perches j...@perches.com Applied, thanks Joe. -- Dive into the

Re: [E1000-devel] [PATCH v2 net-next 0/7] Stacked vlan TSO

2015-03-29 Thread David Miller
From: Toshiaki Makita makita.toshi...@lab.ntt.co.jp Date: Fri, 27 Mar 2015 14:31:09 +0900 On the basis of Netdev 0.1 discussion[1], I made a patch set to enable TSO for packets with multiple vlans. Series applied, thank you.

Re: [E1000-devel] [PATCH net 0/4] Fix checksum error when using stacked vlan

2015-01-30 Thread David Miller
From: Toshiaki Makita makita.toshi...@lab.ntt.co.jp Date: Thu, 29 Jan 2015 20:37:06 +0900 When I was testing 802.1ad, I found several drivers don't take into account 802.1ad or multiple vlans when retrieving L3 (IP/IPv6) or L4 (TCP/UDP) protocol for checksum offload. It is mainly due to

Re: [E1000-devel] [PATCH] igb in linux-3.18.0: some potential bugs

2014-12-20 Thread David Miller
From: Jia-Ju Bai baijiaju1...@163.com Date: Sat, 20 Dec 2014 20:59:18 +0800 Thank for the reply! Please do not top-post. Etiquette on these mailing lists is that you quote a minimal amount of material from the email you are replying to to give enough context to the reader, than you give your

Re: [E1000-devel] [PATCH] e100 in linux-3.18.0: some potential bugs

2014-12-20 Thread David Miller
Your patch submissions are not usable by us. Instead of immediately sending your patch 10 seconds after you receive feedback, take your time and make sure you do everything calmly and cleanly and as tidy as possible. There is absolutely no rush with these changes.

Re: [E1000-devel] ixgbe/linux/sparc perf issues

2014-12-11 Thread David Miller
From: Sowmini Varadhan sowmini.varad...@oracle.com Date: Thu, 11 Dec 2014 14:45:42 -0500 1. lockstat and perf report that iommu-lock is the hot-lock (in a typical instance, I get about 21M contentions out of 27M acquisitions, 25 us avg wait time). Even if I fix this issue (see below), I

Re: [E1000-devel] ixgbe/linux/sparc perf issues

2014-12-11 Thread David Miller
From: Sowmini Varadhan sowmini.varad...@oracle.com Date: Thu, 11 Dec 2014 15:21:00 -0500 All this may be true, but it would also be true for Solaris, which manages to do line-speed (for the exact same setup), so there must be some other bottleneck going on? They have DMA mapping interfaces

Re: [E1000-devel] ixgbe/linux/sparc perf issues

2014-12-11 Thread David Miller
From: David Miller da...@davemloft.net Date: Thu, 11 Dec 2014 15:24:17 -0500 (EST) From: Sowmini Varadhan sowmini.varad...@oracle.com Date: Thu, 11 Dec 2014 15:21:00 -0500 All this may be true, but it would also be true for Solaris, which manages to do line-speed (for the exact same setup

Re: [E1000-devel] [PATCH] e100: Don't enable WoL by default on Toshiba devices

2014-11-12 Thread David Miller
From: Ondrej Zary li...@rainbow-software.org Date: Wed, 12 Nov 2014 23:47:25 +0100 Enabling WoL on some Toshiba laptops (such as Portege R100) causes battery drain after shutdown (WoL is active even on battery). These laptops have the WoL bit set in EEPROM ID, causing e100 driver to enable WoL

Re: [E1000-devel] [PATHC] net: napi_reuse_skb() should check pfmemalloc

2014-10-26 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Thu, 23 Oct 2014 06:30:30 -0700 From: Eric Dumazet eduma...@google.com Do not reuse skb if it was pfmemalloc tainted, otherwise future frame might be dropped anyway. Signed-off-by: Eric Dumazet eduma...@google.com Applied, thanks Eric.

Re: [E1000-devel] [PATCH v2] fm10k: Add skb-xmit_more support

2014-10-14 Thread David Miller
From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Sat, 11 Oct 2014 04:14:43 -0700 On Fri, 2014-10-10 at 14:30 -0700, alexander.du...@gmail.com wrote: From: Alexander Duyck alexander.h.du...@redhat.com This change adds support for skb-xmit_more based on the changes that were made to igb

Re: [E1000-devel] [PATCH] networking: fm10k: Fix build failure

2014-10-09 Thread David Miller
From: Pranith Kumar bobby.pr...@gmail.com Date: Fri, 10 Oct 2014 00:55:29 -0400 The latest linus git tip (3.18-rc1) fails with the following build failure. Fix this by making PTP support explicit for fm10k driver. rivers/built-in.o: In function `fm10k_ptp_register': (.text+0x12e760):

Re: [E1000-devel] [PATCH v2] networking: fm10k: Fix build failure

2014-10-09 Thread David Miller
From: Pranith Kumar bobby.pr...@gmail.com Date: Fri, 10 Oct 2014 01:19:06 -0400 The latest linus git tip (3.18-rc1) fails with the following build failure. Fix this by making PTP support explicit for fm10k driver. rivers/built-in.o: In function `fm10k_ptp_register': (.text+0x12e760):

Re: [E1000-devel] [PATCH v2 0/8] Fix TSO and checksum issues with non-accelerated vlan traffic.

2014-08-25 Thread David Miller
From: Vladislav Yasevich vyasev...@gmail.com Date: Mon, 25 Aug 2014 10:34:47 -0400 I've recently ran across something rather interesting when testing vlans from inside VMs. In some scenarios I was getting awfull thruput. Some debugging uncovered a very scary packet corruption. I was seeing

Re: [E1000-devel] [PATCH 5/8] i40e: Fix TSO and hw checksums for non-accelerated vlan packets.

2014-08-23 Thread David Miller
From: vyasev...@gmail.com Date: Fri, 22 Aug 2014 22:17:07 -0400 @@ -2295,7 +2295,7 @@ static netdev_tx_t i40e_xmit_frame_ring(struct sk_buff *skb, goto out_drop; /* obtain protocol of skb */ - protocol = skb-protocol; + protocol = get_vlan_protocol(skb); I

Re: [E1000-devel] [linux-nics] linux-next: Tree for Aug 11 (net/ethernet/intel/i40e)

2014-08-11 Thread David Miller
From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Mon, 11 Aug 2014 12:53:06 -0700 On Mon, 2014-08-11 at 09:17 -0700, Randy Dunlap wrote: On 08/10/14 22:52, Stephen Rothwell wrote: Hi all, Please do not add code intended for v3.18 until after v3.17-rc1 is released. Changes since

Re: [E1000-devel] [linux-nics] linux-next: Tree for Aug 11 (net/ethernet/intel/i40e)

2014-08-11 Thread David Miller
From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Mon, 11 Aug 2014 15:16:32 -0700 On Mon, 2014-08-11 at 14:54 -0700, David Miller wrote: I see no such change in my tree. http://patchwork.ozlabs.org/patch/376699/ This is what I was referring to, it looks like you set the patch status

Re: [E1000-devel] [PATCH] drivers: net: ethernet: intel: i40e: Fix missing uapi/linux/dcbnl.h include in i40e_fcoe.c

2014-08-05 Thread David Miller
From: Lucas Tanure tan...@linux.com Date: Tue, 5 Aug 2014 10:11:43 -0300 Fix missing include in intel i40e driver. Without this include linux next tree won't compile. Signed-off-by: Lucas Tanure tan...@linux.com Applied, thank you.

Re: [E1000-devel] [PATCH 3/9] i40e: use correct structure type name in sizeof

2014-07-30 Thread David Miller
From: Julia Lawall julia.law...@lip6.fr Date: Tue, 29 Jul 2014 17:16:45 +0200 From: Julia Lawall julia.law...@lip6.fr Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution. This

Re: [E1000-devel] [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-20 Thread David Miller
From: Benoit Taine benoit.ta...@lip6.fr Date: Fri, 18 Jul 2014 17:26:47 +0200 We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes

Re: [E1000-devel] [PATCH 00/30] drivers/net: remove unnecessary break after return

2014-07-20 Thread David Miller
From: Fabian Frederick f...@skynet.be Date: Sun, 20 Jul 2014 16:16:08 +0200 Second patchset after remove unnecessary break after goto addressing break redundancy on drivers/net branch (suggested by Joe Perches) All applied except the i40e patch, which did not apply to net-next at all.

Re: [E1000-devel] [PATCH V2 0/9] drivers/net: remove unnecessary break after goto

2014-07-14 Thread David Miller
From: Fabian Frederick f...@skynet.be Date: Sat, 12 Jul 2014 20:09:39 +0200 Small patchset addressing break redundancy on drivers/net branch (suggested by Joe Perches). V2: cc to maintainers of each section. Series applied to net-next, thanks.

Re: [E1000-devel] [PATCH] e1000: Use time_after() for time comparison

2014-05-22 Thread David Miller
From: Manuel Schölling manuel.schoell...@gmx.de Date: Thu, 22 May 2014 22:21:30 +0200 To be future-proof and for better readability the time comparisons are modified to use time_after() instead of plain, error-prone math. Signed-off-by: Manuel Schölling manuel.schoell...@gmx.de I'll let

Re: [E1000-devel] [PATCH net-next] e1000: Use is_broadcast_ether_addr/is_multicast_ether_addr helpers

2014-05-16 Thread David Miller
From: Tobias Klauser tklau...@distanz.ch Date: Fri, 16 May 2014 10:00:38 +0200 Use the is_broadcast_ether_addr/is_multicast_ether_addr helper functions from linux/etherdevice.h instead of open coding them. Signed-off-by: Tobias Klauser tklau...@distanz.ch I'll let Jeff Kirsher take this via

Re: [E1000-devel] [PATCH net-next] i40evf: Use is_multicast_ether_addr helper

2014-05-16 Thread David Miller
From: Tobias Klauser tklau...@distanz.ch Date: Fri, 16 May 2014 10:00:34 +0200 Use the is_multicast_ether_addr helper function from linux/etherdevice.h instead of open coding the multicast address check. Signed-off-by: Tobias Klauser tklau...@distanz.ch Likewise, I'll let Jeff Kirsher take

Re: [E1000-devel] [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

2014-05-13 Thread David Miller
From: Wilfried Klaebe w-l...@lebenslange-mailadresse.de Date: Sun, 11 May 2014 00:12:32 + net: get rid of SET_ETHTOOL_OPS Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone. This does that. Mostly done via coccinelle script: @@ struct ethtool_ops *ops; struct net_device

Re: [E1000-devel] fail to add 64 VLANs or more when SR-IOV is enabled

2014-04-02 Thread David Miller
From: Madoka Komatsubara m-komatsub...@ab.jp.nec.com Date: Thu, 3 Apr 2014 01:12:13 + Thank you for the quick response. How can I increase the limit? It's a hardware limit, you cannot increase it. --

Re: [E1000-devel] [PATCH net-next 5/9] ixgbe: Convert uses of __constant_foo to foo

2014-03-12 Thread David Miller
From: Joe Perches j...@perches.com Date: Wed, 12 Mar 2014 10:22:34 -0700 The use of __constant_foo has been unnecessary for quite awhile now. Make these uses consistent with the rest of the kernel. Signed-off-by: Joe Perches j...@perches.com Will let the Intel folks pick this up.

Re: [E1000-devel] [PATCH net-next 6/9] ixgbevf: Convert uses of __constant_foo to foo

2014-03-12 Thread David Miller
From: Joe Perches j...@perches.com Date: Wed, 12 Mar 2014 10:22:35 -0700 The use of __constant_foo has been unnecessary for quite awhile now. Make these uses consistent with the rest of the kernel. Signed-off-by: Joe Perches j...@perches.com Will let the Intel folks pick this up.

Re: [E1000-devel] [PATCH net-next 4/9] igbvf: Convert uses of __constant_foo to foo

2014-03-12 Thread David Miller
From: Joe Perches j...@perches.com Date: Wed, 12 Mar 2014 10:22:33 -0700 The use of __constant_foo has been unnecessary for quite awhile now. Make these uses consistent with the rest of the kernel. Signed-off-by: Joe Perches j...@perches.com Will let the Intel folks pick this up.

Re: [E1000-devel] [PATCH net-next 2/9] e100: Convert uses of __constant_foo to foo

2014-03-12 Thread David Miller
From: Joe Perches j...@perches.com Date: Wed, 12 Mar 2014 10:22:31 -0700 The use of __constant_foo has been unnecessary for quite awhile now. Make these uses consistent with the rest of the kernel. Signed-off-by: Joe Perches j...@perches.com Will let the Intel folks pick this up.

Re: [E1000-devel] [PATCH net-next 3/9] igb: Convert uses of __constant_foo to foo

2014-03-12 Thread David Miller
From: Joe Perches j...@perches.com Date: Wed, 12 Mar 2014 10:22:32 -0700 The use of __constant_foo has been unnecessary for quite awhile now. Make these uses consistent with the rest of the kernel. Signed-off-by: Joe Perches j...@perches.com Will let the Intel folks pick this up.

Re: [E1000-devel] [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown

2014-03-07 Thread David Miller
From: Marcelo Tosatti mtosa...@redhat.com Date: Fri, 7 Mar 2014 12:14:35 -0300 checkpatch.pl did not complain about those - feel free to fix them, thanks. The problem is that GIT does when the maintainer applies your patch. You can sanity check your patch using GIT without commiting it into

Re: [E1000-devel] [PATCH net-next] ixgbevf: fix skb-pkt_type checks

2014-02-27 Thread David Miller
From: Florian Fainelli f.faine...@gmail.com Date: Wed, 26 Feb 2014 14:44:00 -0800 skb-pkt_type is not a bitmask, but contains only value at a time from the range defined in include/uapi/linux/if_packet.h. Checking it like if it was a bitmask of values would also cause PACKET_OTHERHOST,

Re: [E1000-devel] [PATCH net-next 00/35] net: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-02-18 Thread David Miller
From: Alexander Gordeev agord...@redhat.com Date: Tue, 18 Feb 2014 11:07:52 +0100 As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and

Re: [E1000-devel] ixgbevf: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-02-18 Thread David Miller
From: Amir Vadai am...@mellanox.com Date: Tue, 18 Feb 2014 14:01:38 +0200 On 18/02/14 11:11 +0100, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use

Re: [E1000-devel] [PATCH net] igb: Fix Null-pointer dereference in igb_reset_q_vector

2014-02-18 Thread David Miller
From: Christoph Paasch christoph.paa...@uclouvain.be Date: Tue, 18 Feb 2014 14:06:57 +0100 When igb_set_interrupt_capability() calls igb_reset_interrupt_capability() (e.g., because CONFIG_PCI_MSI is unset), num_q_vectors has been set but no vector has yet been allocated.

Re: [E1000-devel] [PATCH 1/1] net: i40evf: Remove duplicate include

2014-02-17 Thread David Miller
From: Sachin Kamat sachin.ka...@linaro.org Date: Mon, 17 Feb 2014 15:29:21 +0530 linux/sctp.h was included twice. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Applied to net-next, thank you. -- Managing the

Re: [E1000-devel] [PATCH net-next V2] intel: Remove unnecessary OOM messages

2014-02-13 Thread David Miller
From: Joe Perches j...@perches.com Date: Tue, 11 Feb 2014 17:30:52 -0800 Don't emit these as there's a generic OOM with a dump_stack() on allocation failures. Signed-off-by: Joe Perches j...@perches.com --- With patch attached this time... I expect the Intel folks to pick this up.

Re: [E1000-devel] [PATCH net] e100: Fix disabling already-disabled device warning

2014-01-30 Thread David Miller
From: Brown, Aaron F aaron.f.br...@intel.com Date: Fri, 31 Jan 2014 00:40:16 + From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of David Miller Sent: Thursday, January 30, 2014 4:28 PM To: mich...@acksyn.org Cc: net...@vger.kernel.org; e1000-devel

Re: [E1000-devel] [PATCH] [trivial] ixgbe: Fix format string in ixgbe_fcoe.c

2014-01-15 Thread David Miller
From: Masanari Iida standby2...@gmail.com Date: Wed, 15 Jan 2014 01:14:42 +0900 cppcheck detected following warning in ixgbe_fcoe.c (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. Signed-off-by: Masanari Iida standby2...@gmail.com Intel folks,

Re: [E1000-devel] [PATCH 1/2 Net-next] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63

2014-01-15 Thread David Miller
From: ethan zhao ethan.z...@oracle.com Date: Thu, 16 Jan 2014 12:25:01 +0800 Signed-off-by: Ethan Zhao ethan.z...@oracle.com Signed-off-by: Ethan Zhao ethan.ker...@gmail.com Please don't give two signoffs for yourself, it is not appropriate at all. I am very genuinely curious where you got

Re: [E1000-devel] [PATCH net V3 2/2] net: core: explicitly select a txq before doing l2 forwarding

2014-01-10 Thread David Miller
From: Jason Wang jasow...@redhat.com Date: Fri, 10 Jan 2014 16:18:26 +0800 Currently, the tx queue were selected implicitly in ndo_dfwd_start_xmit(). The will cause several issues: - NETIF_F_LLTX were removed for macvlan, so txq lock were done for macvlan instead of lower device which

Re: [E1000-devel] [PATCH-next] intel ethernet: fix s390 build failure due to implicit prefetch.h

2014-01-10 Thread David Miller
From: Paul Gortmaker paul.gortma...@windriver.com Date: Fri, 10 Jan 2014 14:28:16 -0500 As of commit 7f12ad741a4870b8b6e3aafbcd868d0191770802 (i40evf: transmit and receive functionality) the s390 builds (allyesconfig) fail with: drivers/net/ethernet/intel/i40evf/i40e_txrx.c: In function

Re: [E1000-devel] [PATCH net-next] net:drivers/net: Miscellaneous conversions to ETH_ALEN

2013-10-02 Thread David Miller
From: Joe Perches j...@perches.com Date: Tue, 01 Oct 2013 19:04:40 -0700 Convert the memset/memcpy uses of 6 to ETH_ALEN where appropriate. Also convert some struct definitions and u8 array declarations of [6] to ETH_ALEN. Signed-off-by: Joe Perches j...@perches.com Looks fine, applied,

Re: [E1000-devel] [PATCH 00/10 - GIT PULL] drivers: net: Next block of Remove extern from function prototypes

2013-09-25 Thread David Miller
From: Joe Perches j...@perches.com Date: Tue, 24 Sep 2013 14:09:54 -0700 The following changes since commit b0983d3c9b132c33b6fb2e28d157a1edc18a173c: tcp: fix dynamic right sizing (2013-09-24 11:07:32 -0400) are available in the git repository at:

Re: [E1000-devel] [PATCH 02/10] intel: Remove extern from function prototypes

2013-09-24 Thread David Miller
From: Ben Hutchings bhutchi...@solarflare.com Date: Tue, 24 Sep 2013 23:16:52 +0100 On Tue, 2013-09-24 at 15:07 -0700, Jeff Kirsher wrote: On Tue, 2013-09-24 at 14:09 -0700, Joe Perches wrote: There are a mix of function prototypes with and without extern in the kernel sources. Standardize

Re: [E1000-devel] [net v7 0/8][pull request] Intel Wired LAN Driver Updates

2013-09-11 Thread David Miller
From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Wed, 11 Sep 2013 02:50:48 -0700 git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net master Ok, I've pulled this. Please send fixups based upon the trivial issues a few folks have pointed out. Thanks.

Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

2013-09-06 Thread David Miller
I'm kind of getting sick of the we'll fix it in a follow up patch talk. Please rename this Kbuild file to the normal Makefile instead of trying to be different from every single other driver in the networking for the sake of an issue that is your, and your problem alone. You guys should really

Re: [E1000-devel] [net-next v5 8/8] i40e: include i40e in kernel proper

2013-09-06 Thread David Miller
From: Joe Perches j...@perches.com Date: Fri, 06 Sep 2013 11:20:15 -0700 On Fri, 2013-09-06 at 17:28 +, Williams, Mitch A wrote: My goal was to make our out-of-tree driver as close as possible - including the makefiles - to the upstream driver. Doing this makes it simpler for us to

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-04 Thread David Miller
From: Nelson, Shannon shannon.nel...@intel.com Date: Thu, 5 Sep 2013 01:25:47 + Will this work for you? You will fix the problems people are reporting with this patch series before I apply it. -- Learn the

Re: [E1000-devel] [net-next v4 7/8] i40e: sysfs and debugfs interfaces

2013-09-04 Thread David Miller
From: Brandeburg, Jesse jesse.brandeb...@intel.com Date: Thu, 5 Sep 2013 04:08:39 + On Wed, 2013-09-04 at 23:19 -0400, David Miller wrote: You will fix the problems people are reporting with this patch series before I apply it. Okay, the quickest path to that might be to drop the sysfs

Re: [E1000-devel] [net-next v3 1/8] i40e: main driver core

2013-08-30 Thread David Miller
From: Stephen Hemminger step...@networkplumber.org Date: Fri, 30 Aug 2013 11:10:29 -0700 On Fri, 30 Aug 2013 09:32:48 -0700 Joe Perches j...@perches.com wrote: +static int debug = -1; +module_param(debug, int, 0); +MODULE_PARM_DESC(debug, Debug level (0=none,...,16=all)); Maybe

Re: [E1000-devel] [PATCH net-next] drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent

2013-08-29 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 26 Aug 2013 22:45:23 -0700 __GFP_ZERO is an uncommon flag and perhaps is better not used. static inline dma_zalloc_coherent exists so convert the uses of dma_alloc_coherent with __GFP_ZERO to the more common kernel style with zalloc. Remove

Re: [E1000-devel] [net-next v2 1/8] i40e: main driver core

2013-08-27 Thread David Miller
From: Nelson, Shannon shannon.nel...@intel.com Date: Tue, 27 Aug 2013 20:34:04 + I understand the aesthetics as it does make the code look a little cleaner, and we can do this with a lot of our functions. However, there are several instances where one declaration initialization depends

Re: [E1000-devel] [net-next v2 2/8] i40e: transmit, receive, and napi

2013-08-23 Thread David Miller
From: Stefan Assmann sassm...@kpanic.de Date: Fri, 23 Aug 2013 14:42:07 +0200 On 23.08.2013 04:15, Jeff Kirsher wrote: From: Jesse Brandeburg jesse.brandeb...@intel.com This patch contains the transmit, receive, and napi routines, as well as ancillary routines. This file is code that is

Re: [E1000-devel] [PATCH RFC net-next] net: epoll support for busy poll

2013-08-22 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Wed, 21 Aug 2013 13:39:54 +0300 + SK_LL_STATE_MISS_2, /* data came through napi poll twice in a row */ Please rename this to SK_LL_STATE_MISS_MULTI or something like that. Thanks.

Re: [E1000-devel] [PATCH net-next v3 0/3] net: finish renaming lls to busy poll

2013-07-10 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Wed, 10 Jul 2013 17:13:07 +0300 Here are three patches that complete the rename of lls to busy-poll 1. rename include/net/ll_poll.h to include/net/busy_poll.h 2. Rename ndo_ll_poll to ndo_busy_poll. Rename sk_mark_ll to

Re: [E1000-devel] [PATCH v4 net-next] net: poll/select low latency socket support

2013-06-25 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Mon, 24 Jun 2013 10:28:03 +0300 select/poll busy-poll support. Split sysctl value into two separate ones, one for read and one for poll. updated Documentation/sysctl/net.txt Add a new poll flag POLL_LL. When this flag is set,

Re: [E1000-devel] [PATCH v3 net-next 0/1] net: lls select poll support

2013-06-23 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Wed, 19 Jun 2013 13:04:21 +0300 One question: do we need in sock_poll() to test that sock-sk is not null? (Thanks to Willem de Bruijn for pointing this out.) We should not have to. Please clean up various things in this patch: 1) You

Re: [E1000-devel] [PATCH v3 net-next 0/4] net: low latency sockets follow ups

2013-06-13 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Thu, 13 Jun 2013 17:46:13 +0300 Here are three clean up patches, plus one that adds a socket option for LLS. Patch 1 converts low latency sockets to sched_clock. Patch 2 removes the config menu for NET_LL_RX_POLL and defaults to y.

Re: [E1000-devel] [PATCH net-next 1/2] net: remove NET_LL_RX_POLL config menue

2013-06-12 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Tue, 11 Jun 2013 17:24:28 +0300 depends on X86_TSC Wait a second, I didn't notice this before. There needs to be a better way to test for the accuracy you need, or if the issue is lack of a proper API for cycle counter reading, fix

Re: [E1000-devel] [PATCH v10 net-next 0/6] net: low latency Ethernet device polling

2013-06-11 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Tue, 11 Jun 2013 09:49:31 +0300 I would like to hear opinions on what needs to be added to make this feature complete. The list I have so far is: 1. add a socket option 2. support for poll/select 3. support for epoll I actually

Re: [E1000-devel] [PATCH v10 net-next 0/6] net: low latency Ethernet device polling

2013-06-10 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Mon, 10 Jun 2013 11:39:30 +0300 I removed the select/poll patch (was 5/7 in v9) from the set. The rest are the same patches that were in v9. Please consider applying. Thanks to everyone for their input. There used to be a really

Re: [E1000-devel] [PATCH v10 net-next 0/6] net: low latency Ethernet device polling

2013-06-10 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Tue, 11 Jun 2013 05:25:42 +0300 Here is the text from the RFC and v2 cover letters, updated and merged. If this is too long, please tell me what you think should be removed. It's perfect, and since this went through so many iterations I

Re: [E1000-devel] [PATCH v9 net-next 0/7] net: low latency Ethernet device polling

2013-06-07 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Wed, 05 Jun 2013 13:34:00 +0300 And here is v9. Except for typo fixes in comments/description, only 2/7 and 5/7 were changed. Thanks to everyone for their input. Since there is some discussion about the way the poll() bits work, might

Re: [E1000-devel] [PATCH v7 net-next 0/5] net: low latency Ethernet device polling

2013-06-02 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Sun, 02 Jun 2013 17:02:33 +0300 Or I can submit a v8 with those fixes. Please submit v8 -- Get 100% visibility into Java/.NET code with AppDynamics Lite It's a

Re: [E1000-devel] [PATCH net-next 4/4] igb: enable auxiliary PHC functions for the i210.

2013-05-29 Thread David Miller
From: Richard Cochran richardcoch...@gmail.com Date: Wed, 29 May 2013 09:24:45 +0200 Also, using ethtool or sysfs is not really attractive for embedded designs (let's not forget the poor embedded guys). I think we need to have a way to specify the pin functions at (or before) kernel boot

Re: [E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

2013-05-21 Thread David Miller
From: Eilon Greenstein eil...@broadcom.com Date: Tue, 21 May 2013 10:06:43 +0300 Hopefully this series will be accepted so we can send follow up support for the bnx2x as well. I think in two or three more iterations it will be merged. There are no objections on the fundamentals, it's just

Re: [E1000-devel] [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

2013-05-21 Thread David Miller
From: Or Gerlitz or.gerl...@gmail.com Date: Tue, 21 May 2013 11:24:41 +0300 On Tue, May 21, 2013 at 10:14 AM, David Miller da...@davemloft.net wrote: From: Eilon Greenstein eil...@broadcom.com Date: Tue, 21 May 2013 10:06:43 +0300 Hopefully this series will be accepted so we can send follow

Re: [E1000-devel] [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-21 Thread David Miller
From: Pekka Riikonen priik...@iki.fi Date: Tue, 21 May 2013 19:02:19 +0200 (CEST) On Tue, 21 May 2013, Eric Dumazet wrote: : Alternatively, use a napi_id instead of a pointer. : : I'm not sure I understand what you propose. : : Oh well. : : To get a pointer to a struct

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Sun, 19 May 2013 13:25:33 +0300 +#ifndef _LINUX_NET_LL_POLL_H +#define _LINUX_NET_LL_POLL_H +#ifdef CONFIG_INET_LL_RX_POLL Please put an empty line before the final ifdef test here. +static inline void sk_mark_ll(struct sock *sk,

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 20 May 2013 01:29:47 -0700 On Mon, 2013-05-20 at 00:54 -0700, David Miller wrote: From: Eliezer Tamir eliezer.ta...@linux.intel.com [] { struct socket *sock; + unsigned int poll_result; Please order local variable declarations

Re: [E1000-devel] [PATCH v2 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Mon, 20 May 2013 12:39:59 +0300 On 20/05/2013 10:54, David Miller wrote: From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Sun, 19 May 2013 13:25:33 +0300 +#else /* CONFIG_INET_LL_RX_FLUSH */ + +#define sk_valid_ll(sk) 0

Re: [E1000-devel] [PATCH v3 net-next 1/4] net: implement support for low latency socket polling

2013-05-20 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Mon, 20 May 2013 08:29:24 -0700 Part of this information was in your 0/4 text, but it wont be included in the git tree. Yes it will, in the merge commit I make when I merge this stuff in.

Re: [E1000-devel] getting VF link info seems to be broken in 3.9-rc8

2013-04-25 Thread David Miller
From: Alexander Duyck alexander.h.du...@intel.com Date: Thu, 25 Apr 2013 13:20:24 -0700 On 04/25/2013 12:24 PM, David Miller wrote: From: Alexander Duyck alexander.h.du...@intel.com Date: Thu, 25 Apr 2013 11:29:04 -0700 diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index b65441d

Re: [E1000-devel] getting VF link info seems to be broken in 3.9-rc8

2013-04-25 Thread David Miller
From: Stephen Hemminger step...@networkplumber.org Date: Thu, 25 Apr 2013 13:45:13 -0700 On Thu, 25 Apr 2013 13:36:06 -0700 Alexander Duyck alexander.h.du...@intel.com wrote: On 04/25/2013 01:25 PM, David Miller wrote: From: Alexander Duyck alexander.h.du...@intel.com Date: Thu, 25 Apr

Re: [E1000-devel] [net] e100: Add dma mapping error check

2013-04-10 Thread David Miller
From: Jeff Kirsher jeffrey.t.kirs...@intel.com Date: Wed, 10 Apr 2013 02:19:00 -0700 From: Neil Horman nhor...@tuxdriver.com e100 uses pci_map_single, but fails to check for a dma mapping error after its use, resulting in a stack trace: ... Easy fix, modify the cb paramter to e100_exec_cb

Re: [E1000-devel] [PATCH net-next] drivers:net: dma_alloc_coherent: use __GFP_ZERO instead of memset(, 0)

2013-03-17 Thread David Miller
From: Joe Perches j...@perches.com Date: Fri, 15 Mar 2013 10:23:58 -0700 Reduce the number of calls required to alloc a zeroed block of memory. Trivially reduces overall object size. Other changes around these removals o Neaten call argument alignment o Remove an unnecessary OOM message

Re: [E1000-devel] [PATCH net-next] drivers:net: Remove dma_alloc_coherent OOM messages

2013-03-15 Thread David Miller
From: Joe Perches j...@perches.com Date: Thu, 14 Mar 2013 16:07:21 -0700 I believe these error messages are already logged on allocation failure by warn_alloc_failed and so get a dump_stack on OOM. Remove the unnecessary additional error logging. Around these deletions: o Alignment

Re: [E1000-devel] [RFC PATCH 1/5] net: implement support for low latency socket polling

2013-03-05 Thread David Miller
From: Ben Hutchings bhutchi...@solarflare.com Date: Tue, 5 Mar 2013 16:43:01 + In general it appears to require a run-time check. You might need to augment asm/timex.h. On the other hand, unlike get_cycles, sched_clock() is always available.

Re: [E1000-devel] [RFC PATCH 1/5] net: implement support for low latency socket polling

2013-03-05 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.intel.com Date: Tue, 05 Mar 2013 19:15:26 +0200 We are not very sensitive to this setting, anything on the order of your half round time trip plus a few standard deviations works well. We are busy waiting, so setting a higher value does not change the

Re: [E1000-devel] [RFC PATCH 0/5] net: low latency Ethernet device polling

2013-03-01 Thread David Miller
From: Eliezer Tamir eliezer.ta...@linux.jf.intel.com Date: Wed, 27 Feb 2013 09:55:49 -0800 This patchset adds the ability for the socket layer code to poll directly on an Ethernet device's RX queue. This eliminates the cost of the interrupt and context switch and with proper tuning allows us

Re: [E1000-devel] [PATCHv2-net-3.8 0/3] fix kernel crash with macvtap on top of LRO

2013-02-10 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Thu, 7 Feb 2013 15:12:56 +0200 At the moment, macvtap crashes are observed if macvtap is attached to an interface with LRO enabled. The crash in question is BUG() in macvtap_skb_to_vnet_hdr. This happens because several drivers set gso_size but

Re: [E1000-devel] [PATCH 0/2] fix kernel crash with macvtap on top of LRO

2013-02-10 Thread David Miller
From: Ben Hutchings bhutchi...@solarflare.com Date: Thu, 7 Feb 2013 22:31:35 + On Thu, 2013-02-07 at 23:33 +0200, Michael S. Tsirkin wrote: We might want to add code to forward LRO status from macvlan (not macvtap) back to the lowerdev, so that setting up forwarding from macvlan disables

Re: [E1000-devel] [PATCH] drivers: net: Remove remaining alloc/OOM messages

2013-02-08 Thread David Miller
From: Joe Perches j...@perches.com Date: Thu, 07 Feb 2013 13:46:27 -0800 alloc failures already get standardized OOM messages and a dump_stack. For the affected mallocs around these OOM messages: Converted kmallocs with multiplies to kmalloc_array. Converted a kmalloc/memcpy to kmemdup.

Re: [E1000-devel] [PATCH 0/2] fix kernel crash with macvtap on top of LRO

2013-02-07 Thread David Miller
From: Ben Hutchings bhutchi...@solarflare.com Date: Thu, 7 Feb 2013 16:20:46 + If the consensus is still that we must preserve packets exactly (aside from the usual modifications by IP routers) then LRO should be disabled on all devices for which forwarding is enabled. I believe this is

Re: [E1000-devel] [PATCH 0/8] drivers/net: Remove unnecessary alloc/OOM messages

2013-02-04 Thread David Miller
From: Joe Perches j...@perches.com Date: Sun, 3 Feb 2013 19:28:07 -0800 Remove all the OOM messages that follow kernel alloc failures as there is already a generic equivalent to these messages in the mm subsystem. Joe Perches (8): caif: Remove unnecessary alloc/OOM messages can:

Re: [E1000-devel] [PATCH 3.0.y 0/3] rtnetlink: Fix problem with buffer allocation

2013-01-03 Thread David Miller
: Compute and store minimum ifinfo dump size') went into 3.1 and has also been included in SLE11 SP2. The second and third were acked by David Miller and included in 3.2.34. I've applied and briefly tested these changes in conjunction with a backport of the sfc driver to SLE11 SP3. I'm fine

Re: [E1000-devel] Should we report bus width/speed via ethtool?

2012-12-05 Thread David Miller
From: Ben Greear gree...@candelatech.com Date: Wed, 05 Dec 2012 15:09:11 -0800 On 12/05/2012 02:36 PM, David Miller wrote: From: Ben Greear gree...@candelatech.com Date: Wed, 05 Dec 2012 13:35:01 -0800 It seems the only way to get the current pci-e bus speed width in ixgbe (and probably

Re: [E1000-devel] [PATCH v2] netfilter: take care of timewait sockets

2012-09-03 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Mon, 03 Sep 2012 11:57:18 +0200 David, tell me if you prefer to change TCP demux to avoid timewait, as I have no strong opinion. It would be the stupidest thing ever to do the whole hash lookup just to throw the result away just because it's a

Re: [E1000-devel] [PATCH] net: e100: ucode is optional in some cases

2012-07-19 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Thu, 19 Jul 2012 11:33:13 +0200 + * http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/fxp/rcvbundl.h?rev=HEAD;content-type=text%2Fplain Please don't put URLs into the source code, they generally lack permanence.

Re: [E1000-devel] [PATCH v2] net: e100: ucode is optional in some cases

2012-07-19 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Thu, 19 Jul 2012 18:28:40 +0200 commit 9ac32e1b firmware: convert e100 driver to request_firmware() did a straight conversion of the in-driver ucode to external files. This introduced the possibility of the driver failing to enable an interface due to

Re: [E1000-devel] [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr

2012-07-16 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Mon, 16 Jul 2012 13:14:38 +0300 if you're really renaming the function, then this patch alone will break all of the below users. That should all be a single patch, I'm afraid. It would help if you actually read his patches before saying what they might or

Re: [E1000-devel] [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr

2012-07-16 Thread David Miller
From: Felipe Balbi ba...@ti.com Date: Mon, 16 Jul 2012 14:12:19 +0300 Acked-by: Felipe Balbi ba...@ti.com You need to provide this in a reply to the patch you actually want to ACK, so that the patch tracking system attaches your ACK to the proper patch. Thank you.

Re: [E1000-devel] [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr

2012-07-16 Thread David Miller
From: Joe Perches j...@perches.com Date: Thu, 12 Jul 2012 22:33:04 -0700 net-next commit ad7eee98be (etherdevice: introduce eth_broadcast_addr) added a new style API. Rename random_ether_addr to eth_random_addr to create some API symmetry. Series applied, thanks Joe.

Re: [E1000-devel] [PATCH] e1000: save skb counts in TX to avoid cache misses

2012-06-07 Thread David Miller
From: Jeff Kirsher tar...@gmail.com Date: Thu, 07 Jun 2012 14:38:17 -0700 Thanks! I have applied the patch to my queue Why? My impression is that this is a patch already in the tree, and it's being submitted for -stable but such minor performance hacks are absolutely not appropriate for

Re: [E1000-devel] [PATCH] e1000e: disable rxhash when try to enable jumbo frame also rxhash and rxcsum have enabled

2012-06-07 Thread David Miller
From: Joe Jin joe@oracle.com Date: Fri, 08 Jun 2012 09:06:40 +0800 Upstream commit 70495a5 check if both rxhash and rxcsum enabled when enabling jumbo frames and disallowed all of them enabled at the same time. Since jumbo frame widely be used in real world, so when try to enable jumbo

  1   2   >