Re: [edk2] [Patch v3] NetworkPkg: Add old IPv4_DEVICE_PATH and IPv6_DEVICE_PATH support

2015-07-21 Thread Ye, Ting
Reviewed-by: Ye Ting ting...@intel.com -Original Message- From: Wang, Fan Sent: Wednesday, July 22, 2015 8:57 AM To: Ye, Ting; Fu, Siyuan; Wu, Jiaxin; edk2-de...@lists.sourceforge.net; edk2-devel@lists.01.org Cc: Tian, Hot; Ni, Ruiyu Subject: [Patch v3] NetworkPkg: Add old

Re: [edk2] [PATCH 2/2] SecurityPkg AuthVariableLib: Correct address pointers data

2015-07-21 Thread Yao, Jiewen
Reviewed by: Yao, Jiewen jiewen@intel.com -Original Message- From: Zeng, Star Sent: Tuesday, July 21, 2015 5:02 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [PATCH 2/2] SecurityPkg AuthVariableLib: Correct address pointers data Originally, the double pointer (VOID **) is

Re: [edk2] Simple text protocol- Help

2015-07-21 Thread Neeraj Ladkani
In case you are using events for registering your callback. make sure your TPL levels are at correct levels. pBS-CreateEvent( EVT_NOTIFY_WAIT, TPL_NOTIFY, YOUR_FUNCTION Context, WaitForKey); VOID YOUR_FUNCTION( EFI_EVENT Event, VOID

Re: [edk2] [PATCH 1/7] MdePkg: Add missing PCD usage information in UNI files.

2015-07-21 Thread Gao, Liming
Reviewed-by: Liming Gao liming@intel.com -Original Message- From: Qiu, Shumin Sent: Tuesday, July 21, 2015 8:50 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Gao, Liming Subject: [PATCH 1/7] MdePkg: Add missing PCD usage information in UNI files. Cc: Liming Gao

Re: [edk2] Simple text protocol- Help

2015-07-21 Thread Andrew Fish
On Jul 21, 2015, at 6:59 PM, Saiprasad Chavali s...@marvell.com wrote: Comments Inline From: Andrew Fish [mailto:af...@apple.com mailto:af...@apple.com] Sent: Tuesday, July 21, 2015 6:49 PM To: Saiprasad Chavali Cc: edk2-de...@ml01.01.org mailto:edk2-de...@ml01.01.org Subject: Re:

Re: [edk2] [PATCH v2 3/6] MdeModulePkg: SmbiosDxe: ARM and AARCH64 are VALID_ARCHITECTURES

2015-07-21 Thread Tian, Feng
Reviewed-by: Feng Tian feng.t...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, July 21, 2015 7:10 PM To: edk2-de...@ml01.01.org Cc: Tian, Feng; Elvin Li; Zeng, Star Subject: [edk2] [PATCH v2 3/6]

Re: [edk2] [PATCH 2/2] SecurityPkg AuthVariableLib: Correct address pointers data

2015-07-21 Thread Zeng, Star
Good comments and sure to add (VOID **) cast. Thanks for your Tested-by. Thanks, Star -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, July 21, 2015 8:39 PM To: Zeng, Star; edk2-de...@ml01.01.org Cc: Yao, Jiewen; Alex Williamson Subject: Re: [edk2] [PATCH

[edk2] [PATCH 3/7] IntelFrameworkModulePkg: Add missing PCD usage information in UNI and DEC files.

2015-07-21 Thread Qiu Shumin
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin shumin@intel.com Signed-off-by: Jeff Fan jeff@intel.com --- IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec | 4 IntelFrameworkModulePkg/IntelFrameworkModulePkg.uni | Bin 33748 - 37454 bytes 2