[edk2] MdePkg: Fix RAM Disk Device Path To Text Issue

2015-08-03 Thread Shah, Tapan
Feng / Star, Can you review this fix? Thanks, Tapan MdePkg: Perform Left Shift 32 bits of a 32-bit StartAddr[1] and EndingAddr[1] instead of Right Shift when displaying 64-bit Start and End Address Value StartAddr[1] and EndingAddr[1] are already a 32-bit

Re: [edk2] [PATCH] Check arguments for PrintLib format format string

2015-08-03 Thread Scott Duplichan
Andrew Fish [mailto:af...@apple.com] wrote: ]Sent: Monday, August 03, 2015 04:48 PM ]To: Scott Duplichan sc...@notabs.org ]Cc: edk2-devel@lists.01.org edk2-de...@ml01.01.org; Laszlo Ersek ler...@redhat.com ]Subject: Re: [edk2] [PATCH] Check arguments for PrintLib format format string ] ] ] On

[edk2] [PATCH n+1/m] CryptoPkg/BaseCryptLib: Use X509_V_FLAG_NO_CHECK_TIME

2015-08-03 Thread David Woodhouse
OpenSSL HEAD is in the process of adding this flag to disable the validity time checking. Backport it to 1.0.2 and use it too, for consistency. https://rt.openssl.org/Ticket/Display.html?id=3951user=guestpass=guest Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David

Re: [edk2] MdePkg: Fix RAM Disk Device Path To Text Issue

2015-08-03 Thread Tian, Feng
Reviewed-by: Feng Tian feng.t...@intel.com I will help check this patch in. Thanks Feng From: Shah, Tapan [mailto:tapands...@hp.com] Sent: Monday, August 03, 2015 22:33 To: Tian, Feng; Zeng, Star; edk2-devel@lists.01.org Subject: MdePkg: Fix RAM Disk Device Path To Text Issue Feng / Star,

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Jordan Justen
On 2015-08-03 14:32:15, Andrew Fish wrote: On Aug 3, 2015, at 2:04 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-03 12:58:28, Kinney, Michael D wrote: Jordan, If we make a slight change to the requirements, we can provide clear priority rules. WORKSPACE is

[edk2] [patch 1/2] IntelFrameworkModulePkg:Refine the code comments in LegacyBootMaintUiLib

2015-08-03 Thread Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi dandan...@intel.com --- .../Library/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 4 +--- .../Library/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf| 12 ++-- 2 files changed, 7 insertions(+), 9

[edk2] [patch] MdeModulePkg:Fix the issue that refresh the question fail in DriverSample

2015-08-03 Thread Dandan Bi
Once the question is refreshed,the processing should happen in the callback function of EFI_BROWSER_ACTION_RETRIEVE case,rather than EFI_BROWSER_ACTION_CHANGING in DriverSample. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi dandan...@intel.com ---

Re: [edk2] [patch 2/2] MdeModulePkg:Refine the code comments in UiApp

2015-08-03 Thread Dong, Eric
Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: Bi, Dandan Sent: Tuesday, August 04, 2015 12:51 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch 2/2] MdeModulePkg:Refine the code comments in UiApp Contributed-under: TianoCore Contribution

Re: [edk2] [patch] MdeModulePkg:Fix the issue that refresh the question fail in DriverSample

2015-08-03 Thread Dong, Eric
Reviewed-by: Eric Dong eric.d...@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Tuesday, August 04, 2015 1:16 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [edk2] [patch] MdeModulePkg:Fix the issue

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Andrew Fish
On Aug 3, 2015, at 2:04 PM, Jordan Justen jordan.l.jus...@intel.com wrote: On 2015-08-03 12:58:28, Kinney, Michael D wrote: Jordan, If we make a slight change to the requirements, we can provide clear priority rules. WORKSPACE is used to find Build and Conf. If WORKSPACE_MULTIPLE

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2015-08-03 Thread David Woodhouse
On Mon, 2015-08-03 at 13:41 +0800, Ruiyu Ni wrote: A new BDS and UiApp was created in MdeModulePkg and are already used in Nt32Pkg. The patch changes the OvmfPkg to use the new BDS and UiApp as well. Hi Ruiyu, were these changes tested with the SeaBIOS CSM? -- David Woodhouse

[edk2] [PATCH v2 6/7] BaseTools/GenFw: allow AArch64 tiny and small code model relocations

2015-08-03 Thread Ard Biesheuvel
The AArch64 small C model makes extensive use of ADRP/ADD and ADRP/{LDR,STR} pairs to emit PC-relative symbol references with a +/- 4 GB range. Since the relocation pair splits the relative offset into a relative page offset and an absolute offset into a 4 KB page, we need to take extra care to

[edk2] [PATCH v2 1/7] ArmPkg/GicV3: use GICv3 generic sysreg names only for GNU as

2015-08-03 Thread Ard Biesheuvel
The GNU assembler extends the generic notation for IMPLEMENTATION DEFINED system registers to support any system register, so that system registers defined by newer versions of the architecture can still be used by older versions of the toolchain. Clang before v3.6 supports the generic notation,

[edk2] [PATCH v2 4/7] ArmPlatformPkg/ArmJunoPkg: use TE 'auto' alignment for SEC modules

2015-08-03 Thread Ard Biesheuvel
No need to hardcode the TE alignment anymore, now that GenFw sets the PE/COFF alignment according to the alignment requirements of the ELF input sections. Also enable FIXED FFS placement so that we can reclaim some of the space wasted to padding when using clang with 4 KB section alignment.

[edk2] [PATCH v2 2/7] ArmPkg/GenericWatchdogDxe: add missing VOID* cast

2015-08-03 Thread Ard Biesheuvel
Use an explicit VOID* cast when passing a static char array into a function taking a void pointer. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org --- ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 2 +- 1 file changed, 1

Re: [edk2] [PATCH] SecurityPkg/Tcg/MemoryOverwriteRequestControlLock: Add missing header file description in INF file

2015-08-03 Thread Yao, Jiewen
Reviewed by: Yao, Jiewen jiewen@intel.com -Original Message- From: Qiu, Shumin Sent: Monday, August 03, 2015 3:05 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Yao, Jiewen Subject: [PATCH] SecurityPkg/Tcg/MemoryOverwriteRequestControlLock: Add missing header file description in

[edk2] [Patch 1/2] UiApp: Update copyright info, cover old code existed in old BdsDxe driver.

2015-08-03 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.com Cc: Ruiyu Ni ruiyu...@intel.com Cc: Daryl McDaniel edk2-li...@mc2research.org --- MdeModulePkg/Application/UiApp/BootMaint/Bm.vfr | 2 +- MdeModulePkg/Application/UiApp/BootMaint/BmLib.c

[edk2] [Patch 2/2] LegacyBootMaintUi: Update copyright info, cover old code existed in old BdsDxe driver.

2015-08-03 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong eric.d...@intel.com Cc: Ruiyu Ni ruiyu...@intel.com Cc: Daryl McDaniel edk2-li...@mc2research.org --- .../Library/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 2 +-

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Paolo Bonzini
On 03/08/2015 05:56, Gao, Liming wrote: Hi, all We will update BaseTools feature to allow more than one workspaces. The detail design in the below. Please help review it. If you have any comments, please let me know. 1. Keep $(WORKSPACE) environment as is a. $(WORKSPACE)

Re: [edk2] [PATCH v4 00/13] BaseTools: unify all GCC linker scripts

2015-08-03 Thread Ard Biesheuvel
On 3 August 2015 at 03:39, Liu, Yingke D yingke.d@intel.com wrote: Hi Ard, Sorry for delaying reply, please go ahead, If Liming agreed BaseTools' patches, you could commit them without my feedback. Thanks for clarifying. Committed as SVN r18130 ... r18142 Cheers, Ard. -Original

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Gao, Liming
Paolo: I think that keep the exiting syntax for WORKSPACE to be a single path can minimize the impacts to exiting tools that assume a single workspace. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Paolo Bonzini Sent: Monday,

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Jordan Justen
Cc: edk2-devel On 2015-08-03 10:41:43, Tim Lewis wrote: There are dozens of tools in commercial environments (including some by Insyde) which will fail in this case. In addition, there are codebases that I am aware of where $(WORKSPACE) is allowed directly in other build files. Will all

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Jordan Justen
On 2015-08-03 02:08:14, Gao, Liming wrote: Paolo: I think that keep the exiting syntax for WORKSPACE to be a single path can minimize the impacts to exiting tools that assume a single workspace. I know you originally suggested to use WORKSPACE, but got some feedback that it might be

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Tim Lewis
Actually, I have less problem with the type of change being proposed, and more with the way in which it is accomplished. Today: set up the build environment requires: set up my tools, set up WORKSPACE, build. To build any project, that's it. But with the proposed solution, this is not enough,

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Kinney, Michael D
Jordan, If we make a slight change to the requirements, we can provide clear priority rules. WORKSPACE is used to find Build and Conf. If WORKSPACE_MULTIPLE exists, then it is used as a prioritized list of paths to resolve all other workspace relative paths. This means WORKSPACE_MULTIPLE