[edk2] MdeModulePkg: Nvme Controller Name

2015-11-29 Thread Anbazhagan, Baraneedharan
Hi, With recent changes to Nvme module, NvmExpressComponentNameGetControllerName returns EFI_UNSUPPORTED if child handle is passed. Seems like gEfiNvmExpressPassThruProtocolGuid needs to be passed to EfiTestChildHandle instead of gEfiPciIoProtocolGuid. -Baranee

Re: [edk2] MdeModulePkg: Nvme Controller Name

2015-11-29 Thread Tian, Feng
Yes, you are right. I will help commit it in after tuning the commit log. Reviewed-by: Feng Tian -Original Message- From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Monday, November 30, 2015 05:45 To: edk2-devel@lists.01.org; Tian, Feng Subject:

Re: [edk2] [PATCH V4 07/13] CorebootPayloadPkg: Use SerialDxe in MdeModulePkg

2015-11-29 Thread Zeng, Star
Hi Laszlo, On 2015/11/27 1:44, Laszlo Ersek wrote: On 11/26/15 18:39, Laszlo Ersek wrote: Hi Star, On 11/25/15 02:33, Star Zeng wrote: 1. Update fdf and dsc to use SerialDxe in MdeModulePkg. 2. Separate the code that gets SerialRegBase and SerialRegAccessType by CbParseLib from

Re: [edk2] [PATCH v4 41/41] OvmfPkg: README: document SMM status

2015-11-29 Thread Jordan Justen
On 2015-11-26 16:26:57, Laszlo Ersek wrote: > On 11/26/15 17:17, Laszlo Ersek wrote: > > On 11/25/15 22:29, Jordan Justen wrote: > >> On 2015-11-25 10:06:03, Laszlo Ersek wrote: > >>> On 11/25/15 18:46, Jordan Justen wrote: > On 2015-11-03 13:01:17, Laszlo Ersek wrote: > > > +

[edk2] [PATCH] CorebootPayloadPkg PlatformHookLib: Fix GCC build failure

2015-11-29 Thread Star Zeng
Add return status check to fix GCC build failure below. error: right-hand operand of comma expression has no effect [-Werror=unused-value] #define _PCD_SET_MODE_BOOL_S_PcdSerialUseMmio(Value) ((_gPcd_BinaryPatch_PcdSerialUseMmio = (Value)), RETURN_SUCCESS) error: right-hand operand of comma

Re: [edk2] [PATCH] CorebootPayloadPkg PlatformHookLib: Fix GCC build failure

2015-11-29 Thread Laszlo Ersek
On 11/30/15 02:22, Star Zeng wrote: > Add return status check to fix GCC build failure below. > > error: right-hand operand of comma expression has no effect > [-Werror=unused-value] > #define _PCD_SET_MODE_BOOL_S_PcdSerialUseMmio(Value) > ((_gPcd_BinaryPatch_PcdSerialUseMmio = (Value)),

[edk2] [Patch 1/2] MdeModulePkg/BmpImageDecoderLib: Fix function header comments

2015-11-29 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Shumin Qiu --- MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[edk2] [Patch 2/2] MdeModulePkg/BootLogoLib: Fix INF comments to follow coding standards

2015-11-29 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Shumin Qiu --- MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [edk2] [PATCH 1/2] ArmVirtPkg: Find the lowest memory node

2015-11-29 Thread Shannon Zhao
On 2015/11/30 13:56, Laszlo Ersek wrote: > Looks good to me. > > Reviewed-by: Laszlo Ersek > > When committing this (a bit later), I think I'll fix up the commit > message. There'a s typo in it, plus I'd like to add, from your original > email, "QEMU NUMA support on ARM

Re: [edk2] [PATCH 1/2] ArmVirtPkg: Find the lowest memory node

2015-11-29 Thread Laszlo Ersek
On 11/29/15 07:31, Shannon Zhao wrote: > From: Shannon Zhao > > If there are more than one /memory nodes in FDT, it needs to find the > lowest one, and set PcdSystemMemorySize with thes size of this node. > > Contributed-under: TianoCore Contribution Agreement 1.0 >

Re: [edk2] [PATCH v4 41/41] OvmfPkg: README: document SMM status

2015-11-29 Thread Laszlo Ersek
On 11/30/15 01:50, Jordan Justen wrote: > On 2015-11-26 16:26:57, Laszlo Ersek wrote: >> On 11/26/15 17:17, Laszlo Ersek wrote: >>> On 11/25/15 22:29, Jordan Justen wrote: On 2015-11-25 10:06:03, Laszlo Ersek wrote: > On 11/25/15 18:46, Jordan Justen wrote: >> On 2015-11-03 13:01:17,

Re: [edk2] [PATCH 1/2] ArmVirtPkg: Find the lowest memory node

2015-11-29 Thread Ard Biesheuvel
On 29 November 2015 at 07:31, Shannon Zhao wrote: > From: Shannon Zhao > > If there are more than one /memory nodes in FDT, it needs to find the > lowest one, and set PcdSystemMemorySize with thes size of this node. > > Contributed-under: