[edk2] [PATCH v3 0/2] ArmVirtPkg: Add support for multiple memory nodes

From: Shannon Zhao If there are more than one memory nodes in FDT, currently UEFI will assert. These two patches firstly let UEFI find the memory node with lowest base address and check if the address is what we expected and set PcdSystemMemorySize as the size of this

[edk2] [PATCH v3 1/2] ArmVirtPkg: Find the lowest memory node

From: Shannon Zhao While QEMU NUMA support on ARM will introduce more than one /memory node in the device tree, it needs to find the lowest one and set PcdSystemMemorySize with the actual size of this memory node. Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH] MdeModulePkg: allow DxeIpl to load without permanent memory to enable S3 resume from temporary memory

> You're probably right. I'm very used to catching problems with PEI at > that ASSERT() so I hate to see it go. But it could move to some well- > defined place in DxeIpl. I agree - I have hit that friendly ASSERT many times over the years as well. This addition in my patchset in DxeIpl on the

Re: [edk2] MdeModulePkg: DebugAssert enhancement

Reviewed-by: Liming Gao I would like to help commit your serial patches if no other comments. Thanks Liming -Original Message- From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Friday, December 04, 2015 1:13 AM To: Kinney, Michael D; Gao, Liming;

Re: [edk2] [PATCH v3 2/2] ArmVirtPkg: Add memory space for the high memory nodes

Nice in general; I have three comments: On 12/04/15 11:13, Shannon Zhao wrote: > From: Shannon Zhao > > Here we add the memory space for the high memory nodes except the lowest > one in FDT. So these spaces will show up in the UEFI memory map. > > Contributed-under:

Re: [edk2] [PATCH v3 0/2] ArmVirtPkg: Add support for multiple memory nodes

On 12/04/15 11:13, Shannon Zhao wrote: > From: Shannon Zhao > > If there are more than one memory nodes in FDT, currently UEFI will > assert. These two patches firstly let UEFI find the memory node with > lowest base address and check if the address is what we expected

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

On 4 December 2015 at 10:17, Gao, Liming wrote: > Good fix. How do you find this issue? > I got build failures with RVCT when using the UEFI Secure Boot versions of VariableRuntimeDxe. Could you check how VS deals with this? I.e., if the two copies of

[edk2] [PATCH v3 2/2] ArmVirtPkg: Add memory space for the high memory nodes

From: Shannon Zhao Here we add the memory space for the high memory nodes except the lowest one in FDT. So these spaces will show up in the UEFI memory map. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Shannon Zhao ---

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

Good fix. How do you find this issue? Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 03, 2015 8:54 PM To: edk2-devel@lists.01.org; Justen, Jordan L; Gao, Liming; Zhu, Yonghong Cc: Ard

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

Ard: I check VS build. Two copies of mVirtualAddressChangeEvent are mapped to the same memory location. For RuntimeDxe case, it doesn't cause any issue, because their notification function doesn't use Event. I agree this is a potential issue. But, VS and GCC compiler doesn't report

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

On 12/03/15 13:54, Ard Biesheuvel wrote: > The default behavior of the GCC compiler is to emit uninitialized > globals into a COMMON section, where duplicate definitions are merged. > This may result in unexpected behavior, since global variables appearing > by the same name in different C files

Re: [edk2] [PATCH v3 2/2] ArmVirtPkg: Add memory space for the high memory nodes

On 4 December 2015 at 12:53, Laszlo Ersek wrote: > Nice in general; I have three comments: > > On 12/04/15 11:13, Shannon Zhao wrote: >> From: Shannon Zhao >> >> Here we add the memory space for the high memory nodes except the lowest >> one in FDT. So

Re: [edk2] [PATCH 0/4] CryptoPkg: fix ARM and RVCT issues

For the series, reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, December 3, 2015 6:51 PM > To: edk2-devel@lists.01.org; eug...@hp.com; Long, Qin;

Re: [edk2] [PATCH] CryptoPkg/OpensslLib: upgrade to openssl-1.0.2e

On 4 December 2015 at 15:50, Long, Qin wrote: > Another open is: > I know some companies / orgs will use the script to download / unpack / patch > the openssl tar package for daily / automatic build testing. > In before, OpenSSl put all releases (old and the latest) in one

[edk2] [PATCH] MdeModulePkg: Convert HiiDatabaseDxe ConfigRouting ASSERT to return an error

This should just return an error and not assert. We hit this when testing with a client that was trying to access the old IP4_CONFIG on firmware implementing IP4_CONFIG2. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eugene Cohen ---

Re: [edk2] [PATCH] CryptoPkg/OpensslLib: upgrade to openssl-1.0.2e

Ard, Thanks for your quick response against this OpenSSL upgrade. Your patch was ready when I am still evaluating the security impacts and source changes. :-) The severity evaluation should be moderate / high for EDKII-CryptoPkg, since there were potential vulnerabilities on big number

Re: [edk2] [PATCH] CryptoPkg/OpensslLib: upgrade to openssl-1.0.2e

Another open is: I know some companies / orgs will use the script to download / unpack / patch the openssl tar package for daily / automatic build testing. In before, OpenSSl put all releases (old and the latest) in one same folder, so no impacts to this process. In this year, OpenSSL only

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

On 12/04/15 17:23, Paolo Bonzini wrote: > > > On 04/12/2015 11:39, Laszlo Ersek wrote: >> (4) Linking those two files into a complete program is a violation of >> "6.7 External definitions": >> >> [...] If an identifier declared with external linkage is used in an >> expression (other

Re: [edk2] [PATCH] CryptoPkg: remove global variable 'timeval' from OpenSslSupport.h

On 3 December 2015 at 10:32, Ard Biesheuvel wrote: > The header file OpenSslSupport.h not only defines a type 'struct timeval' > but also defines a global variable 'timeval' of that type. The RVCT > compiler does not merge this definition into a common symbol, resulting

Re: [edk2] [PATCH v3 2/2] ArmVirtPkg: Add memory space for the high memory nodes

On 12/04/15 16:26, Ard Biesheuvel wrote: > On 4 December 2015 at 12:53, Laszlo Ersek wrote: >> Nice in general; I have three comments: >> >> On 12/04/15 11:13, Shannon Zhao wrote: >>> From: Shannon Zhao >>> >>> Here we add the memory space for the high

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

On 4 December 2015 at 17:27, Laszlo Ersek wrote: > On 12/04/15 17:23, Paolo Bonzini wrote: >> >> >> On 04/12/2015 11:39, Laszlo Ersek wrote: >>> (4) Linking those two files into a complete program is a violation of >>> "6.7 External definitions": >>> >>> [...] If an

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

On 04/12/2015 11:39, Laszlo Ersek wrote: > (4) Linking those two files into a complete program is a violation of > "6.7 External definitions": > > [...] If an identifier declared with external linkage is used in an > expression (other than as part of the operand of a *sizeof* >

[edk2] [PATCH v2 16/20] SecurityPkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py SecurityPkg Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- SecurityPkg/Application/RngTest/RngTest.uni |

[edk2] [PATCH v2 12/20] NetworkPkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py NetworkPkg Cc: Siyuan Fu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- NetworkPkg/Application/IfConfig6/IfConfig6.uni | Bin

[edk2] [PATCH v2 11/20] MdeModulePkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py MdeModulePkg Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- .../BootManagerMenuApp/BootManagerMenuApp.uni | Bin

[edk2] [PATCH v2 05/20] DuetPkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py DuetPkg Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- DuetPkg/SmbiosGenDxe/SmbiosGenStrings.uni | Bin 2006 -> 1002

[edk2] [PATCH v2 06/20] EmbeddedPkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py EmbeddedPkg Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen ---

Re: [edk2] [PATCH v2 15/20] PerformancePkg: Convert all .uni files to utf-8

Reviewed-by: Jaben Carsey > -Original Message- > From: Justen, Jordan L > Sent: Friday, December 04, 2015 12:14 PM > To: edk2-devel@lists.01.org > Cc: Justen, Jordan L ; Daryl McDaniel li...@mc2research.org>; Carsey, Jaben

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

Agreed. that works fine too... > -Original Message- > From: Justen, Jordan L > Sent: Friday, December 04, 2015 2:14 PM > To: Carsey, Jaben ; edk2-devel@lists.01.org > Cc: Qiu, Shumin ; Carsey, Jaben > > Subject: RE:

Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8

On 2015-12-04 13:16:34, Carsey, Jaben wrote: > There is a large change outstanding that was reviewed, but not yet > committed for updating DH to display additional protocols. Can you > commit that before this change? How about we do the opposite? Commit this one first, and then rebase that patch.

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

On 4 December 2015 at 20:20, Daryl McDaniel wrote: [...] >> On 12/03/15 13:54, Ard Biesheuvel wrote: >>> The default behavior of the GCC compiler is to emit uninitialized >>> globals into a COMMON section, where duplicate definitions are merged. >>> This may result in

Re: [edk2] MdeModulePkg: DebugAssert enhancement

Thanks. I will send updated code change for the same library in IntelFrameworkModulePkg. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Friday, December 04, 2015 3:32 AM > To: Anbazhagan, Baraneedharan; Kinney, Michael D; edk2-devel@lists.01.org > Subject:

[edk2] Can I determine from Linux if Secure Boot is supported?

Hi, I'm wondering under what conditions the SecureBoot EFI variable (with GUID 8be4df61-93ca-11d2-aa0d-00e098032b8c) created. In particular, is it necessarily present on computers that support Secure Boot but on which that feature is disabled? I realize that it will normally exist in this case

[edk2] [PATCH v2 00/20] Convert utf-16 .uni files to utf-8

web: https://github.com/jljusten/edk2/tree/uni-to-utf8-v2 git: https://github.com/jljusten/edk2.git uni-to-utf8-v2 Jordan Justen (20): BaseTools/Scripts: Add ConvertUni.py script ArmPkg: Convert all .uni files to utf-8 ArmPlatformPkg: Convert all .uni files to utf-8 CryptoPkg: Convert

[edk2] [PATCH v2 08/20] IntelFrameworkModulePkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py IntelFrameworkModulePkg Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- .../Bus/Isa/IsaBusDxe/IsaBusDxe.uni

[edk2] [PATCH v2 20/20] Vlv2TbltDevicePkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py Vlv2TbltDevicePkg Cc: David Wei Cc: Tim He Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen ---

[edk2] [PATCH v2 03/20] ArmPlatformPkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py ArmPlatformPkg Cc: Leif Lindholm Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen ---

[edk2] [PATCH v2 07/20] EmulatorPkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py EmulatorPkg Cc: Andrew Fish Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- .../MiscBaseBoardManufacturer.uni | Bin

[edk2] [PATCH v2 04/20] CryptoPkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py CryptoPkg Cc: Qin Long Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- CryptoPkg/Application/Cryptest/Cryptest.uni | Bin

[edk2] [PATCH v2 01/20] BaseTools/Scripts: Add ConvertUni.py script

This script uses python codecs to convert .uni string files between the utf-16 and utf-8 formats. The advantages of utf-8 data: * Generally smaller files * More commonly supported by editors * Not treated as binary data in patch files The script was tested on MdePkg with both python 2.7 and

[edk2] [PATCH v2 10/20] MdePkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py MdePkg Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen ---

[edk2] [PATCH v2 13/20] Nt32Pkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py Nt32Pkg Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- Nt32Pkg/CpuRuntimeDxe/Strings.uni| Bin 2172

[edk2] [PATCH v2 18/20] SourceLevelDebugPkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py SourceLevelDebugPkg Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.uni

[edk2] [PATCH v2 15/20] PerformancePkg: Convert all .uni files to utf-8

To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUni.py PerformancePkg Cc: Daryl McDaniel Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen ---

Re: [edk2] IntelFrameworkModulePkg: DebugAssert enhancement

Updated patch to use CopyMem instead of AsciiSPrint based on code review feedback. --- .../PeiDxeDebugLibReportStatusCode/DebugLib.c | 51 +++--- 1 file changed, 36 insertions(+), 15 deletions(-) diff --git

[edk2] Double or floating point on edk2 ?

I know this question has been answered before. Do I need to convert my application to a UEFI StdLib applicationto do double or floating point math ? Can't do it in a regular Shell App ? Please illuminate. Thanks, Shubha Shubha D. ramanishubharam...@gmail.com shubharam...@yahoo.com

Re: [edk2] [PATCH] ShellPkg: Make 'dh' support showing all spec defined protocols.

I am the author. Shumin did some final verification and fixed a bug and then sent out for review. > -Original Message- > From: Justen, Jordan L > Sent: Friday, December 04, 2015 4:11 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Qiu, Shumin >

[edk2] [PATCH] ShellPkg: Make 'dh' support showing all spec defined protocols.

From: Qiu Shumin When using 'dh' to dump all protocols installed on a handle, some of them are shown as 'UnknownDevice'. Device patch make 'dh' support all spec defined protocols. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey

Re: [edk2] [Patch] ShellPkg: Fix ifconfig hang issue with incomplete parameters

Looks good to me. I think we should wait for Leekha for up to a few days to confirm that this fixes the problem at their location. Reviewed-by: Jaben Carsey -Jaben > -Original Message- > From: Wu, Jiaxin > Sent: Thursday, December 03, 2015 5:27 PM > To:

Re: [edk2] [PATCH] CryptoPkg: remove global variable 'timeval' from OpenSslSupport.h

Sorry, I missed this patch. Yes, this looks good. Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Saturday, December 5, 2015 12:45 AM > To: edk2-devel@lists.01.org; Long,

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

On Friday, December 04, 2015, Laszlo Ersek wrote: > Now, after reading the -fno-common documentation in the gcc manual, I'm > actually *convinced* this is a gcc bug. The manual says on my RHEL-7.2 > system (excerpt): > >-fno-common >In C code, controls the placement of

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

On 2015-12-04 08:43:29, Ard Biesheuvel wrote: > On 4 December 2015 at 17:27, Laszlo Ersek wrote: > > On 12/04/15 17:23, Paolo Bonzini wrote: > >> > >> > >> On 04/12/2015 11:39, Laszlo Ersek wrote: > >>> (4) Linking those two files into a complete program is a violation of > >>>

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

On 4 December 2015 at 20:13, Jordan Justen wrote: > On 2015-12-04 08:43:29, Ard Biesheuvel wrote: >> On 4 December 2015 at 17:27, Laszlo Ersek wrote: >> > On 12/04/15 17:23, Paolo Bonzini wrote: >> >> >> >> >> >> On 04/12/2015 11:39, Laszlo Ersek